[PATCH] D71082: Allow system header to provide their own implementation of some builtin

serge-sans-paille updated this revision to Diff 233923. serge-sans-paille marked an inline comment as done. serge-sans-paille added a comment. Take comment into account. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71082/new/

[PATCH] D71082: Allow system header to provide their own implementation of some builtin

serge-sans-paille updated this revision to Diff 233924. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71082/new/ https://reviews.llvm.org/D71082 Files: clang/include/clang/AST/Decl.h clang/lib/AST/Decl.cpp clang/lib/CodeGen/CGExpr.cpp

[PATCH] D71510: [clang][checkers] Added new checker 'error-return-checker'. (WIP)

balazske created this revision. Herald added subscribers: cfe-commits, gamesh411, Szelethus, dkrupp, mgorny. Herald added a project: clang. Currently work-in-progress. This should check if the return values from certain C API functions are checked for error. The list of functions is included. A

[PATCH] D71510: [clang][checkers] Added new checker 'error-return-checker'. (WIP)

balazske added a comment. Code is to be reformatted later. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71510/new/ https://reviews.llvm.org/D71510 ___ cfe-commits mailing list

[clang] c2f1831 - Move ASTRecordReader into its own header; NFC.

Author: John McCall Date: 2019-12-14T03:28:23-05:00 New Revision: c2f18315ff53006e44afe065368019e41cb98053 URL: https://github.com/llvm/llvm-project/commit/c2f18315ff53006e44afe065368019e41cb98053 DIFF: https://github.com/llvm/llvm-project/commit/c2f18315ff53006e44afe065368019e41cb98053.diff

[PATCH] D71374: Improve support of GNU mempcpy

serge-sans-paille added a comment. @xbolva00 : validation is ok: https://github.com/serge-sans-paille/llvm-project/pull/5/checks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71374/new/ https://reviews.llvm.org/D71374

[PATCH] D71499: Add builtins for aligning and checking alignment of pointers and integers

lebedev.ri added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:14323 +Result = Builder.CreateIntrinsic( +Intrinsic::ptrmask, {Args.SrcType, SrcForMask->getType(), Args.IntType}, +{SrcForMask, NegatedMask}, nullptr, "aligned_result");

[PATCH] D63960: [C++20] Add consteval-specific semantic for functions

Tyker added a comment. ping @rsmith CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63960/new/ https://reviews.llvm.org/D63960 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D71345: [clangd] Fall back to selecting token-before-cursor if token-after-cursor fails.

thakis added a comment. Reverted in f0604e73a4daa35a10eb17a998657d6c4bd0e971 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71345/new/ https://reviews.llvm.org/D71345

[PATCH] D71345: [clangd] Fall back to selecting token-before-cursor if token-after-cursor fails.

thakis added a comment. This breaks compile on most bots in the "clang" section on http://lab.llvm.org:8011/console , probably the ones that use gcc as host compiler. Here's an example:

[clang-tools-extra] 687e98d - Fix build with older (still supported) gcc versions.

Author: Nico Weber Date: 2019-12-14T10:13:15-05:00 New Revision: 687e98d294c4f77e8b431adb7d86dfba5ab84645 URL: https://github.com/llvm/llvm-project/commit/687e98d294c4f77e8b431adb7d86dfba5ab84645 DIFF: https://github.com/llvm/llvm-project/commit/687e98d294c4f77e8b431adb7d86dfba5ab84645.diff

[PATCH] D71503: New warning on for-loops that never run because condition is false on the first iteration

lebedev.ri added a comment. Thank you for working on this! This seems to be missing tests. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71503/new/ https://reviews.llvm.org/D71503 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D71499: Add builtins for aligning and checking alignment of pointers and integers

arichardson marked an inline comment as done. arichardson added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:14323 +Result = Builder.CreateIntrinsic( +Intrinsic::ptrmask, {Args.SrcType, SrcForMask->getType(), Args.IntType}, +{SrcForMask,

[PATCH] D69475: [clang] Provide better fix-it on exception spec error

jdemeule added a comment. Kindly ping reviewer. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69475/new/ https://reviews.llvm.org/D69475 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D69282: [RFC] Add a VCS conflict marker format printing on tooling::ReplacementError

jdemeule added a comment. Kindly ping reviewers. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69282/new/ https://reviews.llvm.org/D69282 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D71512: [clang-format] Fix short block when braking after control statement

Bouska created this revision. Bouska added reviewers: djasper, klimek, krasimir. Bouska added a project: clang-format. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch fixes bug #44192 When clang-format is run with option AllowShortBlocksOnASingleLine, it is

[PATCH] D71507: [perf-training] Make training data location configurable

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71507/new/ https://reviews.llvm.org/D71507

[PATCH] D71414: [clangd] Introduce codeblocks

thakis added inline comments. Comment at: clang-tools-extra/clangd/unittests/FormattedStringTests.cpp:126 +test +``` +bar)md"); Older (but still supported) gccs can't handle multiline raw strings in macro arguments, see e.g.

[PATCH] D71499: Add builtins for aligning and checking alignment of pointers and integers

lebedev.ri marked an inline comment as done. lebedev.ri added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:14323 +Result = Builder.CreateIntrinsic( +Intrinsic::ptrmask, {Args.SrcType, SrcForMask->getType(), Args.IntType}, +{SrcForMask,

[PATCH] D71320: [IR] Split out target specific intrinsic enums into separate headers

thakis added a comment. I think this broke the reverse-iteration bot: http://lab.llvm.org:8011/builders/reverse-iteration/builds/15619 In D71320#1782204 , @rnk wrote: > In D71320#1780805 , @thakis wrote: > > >

Re: [clang] c2f1831 - Move ASTRecordReader into its own header; NFC.

One of the commits in this series, likely https://github.com/llvm/llvm-project/commit/d505e57cc273750541ec8bbce2065b8b87c99ad6 (which for some reason doesn't show up on cfe-commits?) broke Modules/merge-lifetime-extended-temporary.cpp when using a clang built at r365097 as host compiler. (Full

Re: [clang] c2f1831 - Move ASTRecordReader into its own header; NFC.

On 14 Dec 2019, at 14:37, Nico Weber wrote: One of the commits in this series, likely https://github.com/llvm/llvm-project/commit/d505e57cc273750541ec8bbce2065b8b87c99ad6 (which for some reason doesn't show up on cfe-commits?) broke Modules/merge-lifetime-extended-temporary.cpp when using a

[PATCH] D71433: [analyzer] CERT: POS34-C

zukatsinadze marked 4 inline comments as done. zukatsinadze added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Checkers/Checkers.td:765 + HelpText<"Finds calls to the `putenv` function which pass a pointer to " + "an automatic variable as the

[clang] 357e64e - [cxx_status] Fix paper number for "Concept auto" paper.

Author: Richard Smith Date: 2019-12-14T14:53:05-08:00 New Revision: 357e64e95267de3dfc64b5563dec2df84e6cce0e URL: https://github.com/llvm/llvm-project/commit/357e64e95267de3dfc64b5563dec2df84e6cce0e DIFF: https://github.com/llvm/llvm-project/commit/357e64e95267de3dfc64b5563dec2df84e6cce0e.diff

[PATCH] D41910: [Concepts] Constrained partial specializations and function overloads.

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. Only a few non-nit comments; if you feel confident addressing those, please feel free to commit after doing so. (If you'd like another round of review, let me know.) Thanks!

[PATCH] D71433: [analyzer] CERT: POS34-C

zukatsinadze added a comment. In D71433#1784238 , @NoQ wrote: > Thanks! This looks like a simple and efficient check. I have one overall > suggestion. > > Currently the check may warn on non-bugs of the following kind: > > void foo() { > char env[]

[PATCH] D71499: Add builtins for aligning and checking alignment of pointers and integers

rsmith added a comment. To me these seem sufficiently useful to be worth having. Please add documentation for them. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:2913 +def warn_alignment_builtin_useless : Warning< + "%select{aligning a value|checking whether a

[PATCH] D71433: [analyzer] CERT: POS34-C

NoQ added a comment. In D71433#1784920 , @zukatsinadze wrote: > @NoQ I like the idea, but I am not really sure how to do that. I started > working on Static Analyzer just lask week. Let's get the initial attempt right first, and delay this for the

Re: [clang] 5708f2d - [clang] Fix modules build after addition of TypeBitCodes.def

On 14 Dec 2019, at 12:25, Raphael Isemann via cfe-commits wrote: Author: Raphael Isemann Date: 2019-12-14T18:24:53+01:00 New Revision: 5708f2daf7386ef5f1ec54db4bda2b48bbcbe934 URL: https://github.com/llvm/llvm-project/commit/5708f2daf7386ef5f1ec54db4bda2b48bbcbe934 DIFF:

[PATCH] D71026: Fix LLVM_ENABLE_MODULES=ON + BUILD_SHARED_LIBS=ON build

rsmith added a comment. Please can you describe the problem that this is fixing? Without that, it's hard to know whether this is the appropriate fix. Is there a modules buildbot that's failing, that we could look at the output from? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D71508: [DebugInfo] Duplicate file names in debug info

dstenb added a comment. It should be possible to create a test for this using something like: RUN: rm -rf %t && mkdir %t RUN: cp %s %t/filename.c RUN: cd %t RUN: clang ./filename.c [...] Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D71512: [clang-format] Fix short block when braking after control statement

MyDeveloperDay added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:586 verifyFormat("if (true) {\n" - " ff();\n" "}", any reason you are changing existing

[PATCH] D71433: [analyzer] CERT: POS34-C

zukatsinadze updated this revision to Diff 233946. zukatsinadze added a comment. Addressed most of the inline comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71433/new/ https://reviews.llvm.org/D71433 Files: clang/docs/analyzer/checkers.rst

[PATCH] D43357: [Concepts] Function trailing requires clauses

rsmith added inline comments. Comment at: clang/include/clang/Basic/DiagnosticParseKinds.td:179-180 def err_unexpected_semi : Error<"unexpected ';' before %0">; +def err_expected_primary_got_unary : Error< + "expected primary expression before %0; did you forget

[PATCH] D71513: [compiler-rt] [test] Disable MPROTECT on two builtin tests

mgorny created this revision. mgorny added reviewers: krytarowski, rnk, samsonov, howard.hinnant. Herald added subscribers: llvm-commits, dberris. Herald added a project: LLVM. Introduce a new %paxctl_nomprotect substitution and call it on two builtin tests that do not work with MPROTECT on

[clang] 2c59c4f - [perf-training] Make training data location configurable

Author: Shoaib Meenai Date: 2019-12-14T09:46:41-08:00 New Revision: 2c59c4ffb9c111f8d87a65839697d03fc485c51c URL: https://github.com/llvm/llvm-project/commit/2c59c4ffb9c111f8d87a65839697d03fc485c51c DIFF: https://github.com/llvm/llvm-project/commit/2c59c4ffb9c111f8d87a65839697d03fc485c51c.diff

[PATCH] D70469: [attributes] [analyzer] Add handle related attributes

aaron.ballman added a comment. In D70469#1779906 , @xazax.hun wrote: > In D70469#1778609 , @NoQ wrote: > > > What about `__attribute__((acquire_handle("fuchsia")))` > > > I would by fine with this as well. Aaron?

[clang] 5708f2d - [clang] Fix modules build after addition of TypeBitCodes.def

Author: Raphael Isemann Date: 2019-12-14T18:24:53+01:00 New Revision: 5708f2daf7386ef5f1ec54db4bda2b48bbcbe934 URL: https://github.com/llvm/llvm-project/commit/5708f2daf7386ef5f1ec54db4bda2b48bbcbe934 DIFF:

[PATCH] D71507: [perf-training] Make training data location configurable

This revision was automatically updated to reflect the committed changes. Closed by commit rG2c59c4ffb9c1: [perf-training] Make training data location configurable (authored by smeenai). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71507/new/