sylvestre.ledru added inline comments.
Comment at: clang-tools-extra/docs/clang-tidy/checks/list.rst:75
`bugprone-sizeof-expression `_, , "high"
+ `bugprone-spuriously-wake-up-functions
`_, , ""
`bugprone-string-constructor `_, "Yes",
"high"
Could
njames93 updated this revision to Diff 235278.
njames93 added a comment.
I added test cases for the matchers and the check, wasn't able to add the
CXXRangeFor to the matcher as that class uses a different dialect for the
initializer statement handling. I also couldn't generate the new
SouraVX added inline comments.
Comment at: llvm/docs/ReleaseNotes.rst:169
+* C DebugInfo API ``LLVMDIBuilderCreateTypedef`` is updated to include an extra
+argument ``AlignInBits``, to facilitate / propagate specified Alignment
information
jdoerfert accepted this revision.
jdoerfert added a comment.
This revision is now accepted and ready to land.
I would have just stripped the last chars of ` Out.str()` but if this passes
all the tests I'm fine with it.
LGTM.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
djtodoro added inline comments.
Comment at: llvm/docs/ReleaseNotes.rst:169
+* C DebugInfo API ``LLVMDIBuilderCreateTypedef`` is updated to include an extra
+argument ``AlignInBits``, to facilitate / propagate specified Alignment
information
tianqing created this revision.
Herald added subscribers: cfe-commits, guansong.
Herald added a reviewer: jdoerfert.
Herald added a project: clang.
tianqing added a reviewer: ABataev.
`getListOfPossibleValues()` formatted incorrectly when there is only one value,
emitting something like
kbobyrev created this revision.
Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous,
MaskRay, ilya-biryukov.
Herald added a project: clang.
This patch introduces new canonicalization rules which are used for AST-based
rename in Clangd. By comparing two canonical
This revision was automatically updated to reflect the committed changes.
Closed by commit rGf9c3c5da19ab: [OpenMP][IR-Builder] Introduce the
finalization stack (authored by jdoerfert).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D70258/new/
Author: Johannes Doerfert
Date: 2019-12-25T16:57:08-06:00
New Revision: f9c3c5da19ab6d8cbbd4611fbb24e97fe7a85078
URL:
https://github.com/llvm/llvm-project/commit/f9c3c5da19ab6d8cbbd4611fbb24e97fe7a85078
DIFF:
njames93 updated this revision to Diff 235301.
njames93 edited the summary of this revision.
njames93 added a comment.
fixed a spelling mistake in unit tests
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D71846/new/
https://reviews.llvm.org/D71846
Files:
njames93 updated this revision to Diff 235300.
njames93 marked an inline comment as done.
njames93 added a comment.
Renamed 'hasInitStorage' to 'hasInitStatement'.
Added support for range for loops in 'hasInitStatement'.
'hasInitStatement' now has a match predicate on the init statement.
xbolva00 added subscribers: aaron.ballman, xbolva00.
xbolva00 added inline comments.
Comment at: llvm/lib/CodeGen/MachineBasicBlock.cpp:1116
+if (auto *cbr = dyn_cast(getBasicBlock()->getTerminator()))
+ if (cbr->getDefaultDest() != bb)
+for (unsigned i = 0, e =
merge_guards_bot added a comment.
{icon check-circle color=green} Unit tests: pass. 61107 tests passed, 0 failed
and 728 were skipped.
{icon times-circle color=red} clang-tidy: fail. Please fix clang-tidy findings
kbobyrev planned changes to this revision.
kbobyrev added a comment.
This is a WIP draft. Few items to address before pushing for a review
- More tests: renaming is a complex feature and I want to make sure there are
no regressions/corner-cases I did not handle. It might make sense to adopt a
14 matches
Mail list logo