[clang] 170de3d - [ParserTest] Move raw string literal out of macro

Author: David Green Date: 2020-01-05T11:24:04Z New Revision: 170de3de2eea8eb7f514dfa64d3f845ef10d8425 URL: https://github.com/llvm/llvm-project/commit/170de3de2eea8eb7f514dfa64d3f845ef10d8425 DIFF: https://github.com/llvm/llvm-project/commit/170de3de2eea8eb7f514dfa64d3f845ef10d8425.diff LOG:

[PATCH] D72217: [clang-tidy] Added readability-qualified-auto check

Mordante added a comment. Nice to see this patch! I intended to look at a similar patch, but that's no longer required. One question does it also handle cases like `std::vector PtrPtrVec;` properly? Comment at:

[PATCH] D54943: [clang-tidy] implement const-transformation for cppcoreguidelines-const-correctness

JonasToth marked 4 inline comments as done. JonasToth added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/cppcoreguidelines-const-correctness-values.cpp:608 +} + +template JonasToth wrote: > 0x8000- wrote: > > JonasToth wrote: > >

[PATCH] D69758: [Gnu toolchain] Look at standard GCC paths for libstdcxx by default

kristina requested changes to this revision. kristina added a comment. Sorry for responding late, was away. This seems to be tripping up a regression test: FAIL: Clang :: Driver/cross-linux.c (5312 of 16608) llvm-project/clang/test/Driver/cross-linux.c:62:26: error: CHECK-MULTI32-X86-64:

[PATCH] D71499: Add builtins for aligning and checking alignment of pointers and integers

arichardson updated this revision to Diff 236243. arichardson added a comment. - Add a test that the new alignment is propagated to e.g. llvm.memcpy To do this emit a llvm.assume for pointer types and mark the builtin as having an alloc_align attribute (although that does not seem to do

[PATCH] D72213: [clang-tidy] Add `bugprone-reserved-identifier` to flag usages of reserved C++ names

Mordante added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/ReservedIdentifierCheck.cpp:70 + const bool IsInGlobalNamespace) { + return IsInGlobalNamespace && Name.size() > 1 && Name[0] == '_'; +}

[PATCH] D72227: Add options for clang to align branches within 32B boundary

skan created this revision. skan added reviewers: craig.topper, LuoYuanke, annita.zhang, jyknight, reames, MaskRay. Herald added a project: clang. Herald added a subscriber: cfe-commits. Add an option -mbranches-within-32B-boundaries to align branches within a 32-Byte boundary to reduce the

[PATCH] D71903: [Coroutines][6/6] Clang schedules new passes

modocache updated this revision to Diff 236245. modocache removed a subscriber: wenlei. modocache added a comment. Herald added a subscriber: hiraditya. Herald added a project: LLVM. Thanks for the reviews. Based on my latest revision of D71899 , the coro-split

[PATCH] D72217: [clang-tidy] Added readability-qualified-auto check

njames93 added a comment. I'll address those issues tonight. As for the ** case, I'll. Hadn't even thought of that, I'll try and sort that out Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72217/new/ https://reviews.llvm.org/D72217

[PATCH] D72212: [Sema] Improve -Wrange-loop-analysis warnings

Mordante marked 3 inline comments as done. Mordante added inline comments. Comment at: clang/lib/Sema/SemaStmt.cpp:2806 - // constructors. - if (VariableType.isPODType(SemaRef.Context)) return; xbolva00 wrote: > Mordante wrote: > > xbolva00 wrote: > > >

[PATCH] D71499: Add builtins for aligning and checking alignment of pointers and integers

lebedev.ri accepted this revision. lebedev.ri added a subscriber: erichkeane. lebedev.ri added a comment. This revision is now accepted and ready to land. Nice. Thank you for working on this. I think this finally fully looks good to me. Not sure whether we should be really adding an attribute to

[PATCH] D71499: Add builtins for aligning and checking alignment of pointers and integers

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 61248 tests passed, 0 failed and 736 were skipped. {icon times-circle color=red} clang-tidy: fail. Please fix clang-tidy findings

[PATCH] D54943: [clang-tidy] implement const-transformation for cppcoreguidelines-const-correctness

0x8000- marked an inline comment as done. 0x8000- added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/cppcoreguidelines-const-correctness-values.cpp:608 +} + +template JonasToth wrote: > JonasToth wrote: > > 0x8000- wrote:

[PATCH] D72231: [Sema] Adds the pointer-to-int-cast diagnostic

Mordante created this revision. Mordante added reviewers: dblaikie, rsmith. Mordante added a project: clang. Converting a pointer to an integer whose result cannot represented in the integer type is undefined behavior is C and prohibited in C++. C++ already has a diagnostic when casting. This

[PATCH] D72231: [Sema] Adds the pointer-to-int-cast diagnostic

xbolva00 added a comment. >> The diagnostic is not enabled by default But GCC enables it for C even without "-Wall or -Wextra". Clang should follow it.. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72231/new/ https://reviews.llvm.org/D72231

[PATCH] D69758: [Gnu toolchain] Look at standard GCC paths for libstdcxx by default

kristina added a comment. I ran `check-clang` on a x86_64 Ubuntu 18.04 machine (toolchain compiled with `compiler-rt` as the default CRT and `libc++`/`libc++abi`/`libunwind_llvm`). I think one of the driver tests for multilib stuff may be broken, in which case it should probably be

[clang] ad0a458 - Allow using traverse() with bindings

Author: Stephen Kelly Date: 2020-01-05T20:48:56Z New Revision: ad0a45833b940057cc74364c82271247bd7925e1 URL: https://github.com/llvm/llvm-project/commit/ad0a45833b940057cc74364c82271247bd7925e1 DIFF: https://github.com/llvm/llvm-project/commit/ad0a45833b940057cc74364c82271247bd7925e1.diff

[PATCH] D69758: [Gnu toolchain] Look at standard GCC paths for libstdcxx by default

kristina accepted this revision. kristina added a comment. On second look this seems to be caused by `compiler-rt` being used as the default runtime, which is not accounted for in that particular test. Test is expecting a GCCesque crtbegin here which is missing with `compiler-rt`: "crt1.o"

[clang] b18cb9c - [Gnu toolchain] Look at standard GCC paths for libstdcxx by default

Author: Kristina Brooks Date: 2020-01-05T21:43:18Z New Revision: b18cb9c4716677b048a88125be14d59a56865b9c URL: https://github.com/llvm/llvm-project/commit/b18cb9c4716677b048a88125be14d59a56865b9c DIFF: https://github.com/llvm/llvm-project/commit/b18cb9c4716677b048a88125be14d59a56865b9c.diff

[PATCH] D69758: [Gnu toolchain] Look at standard GCC paths for libstdcxx by default

This revision was not accepted when it landed; it landed in state "Needs Revision". This revision was automatically updated to reflect the committed changes. Closed by commit rGb18cb9c47166: [Gnu toolchain] Look at standard GCC paths for libstdcxx by default (authored by kristina). Repository:

[clang] 445f4d2 - Clang-format previous commit

Author: Stephen Kelly Date: 2020-01-05T22:58:32Z New Revision: 445f4d2310e751a6ab18f84b1d4ad13037ffd819 URL: https://github.com/llvm/llvm-project/commit/445f4d2310e751a6ab18f84b1d4ad13037ffd819 DIFF: https://github.com/llvm/llvm-project/commit/445f4d2310e751a6ab18f84b1d4ad13037ffd819.diff

[PATCH] D72236: [Clang] Force rtlib=platform in test to avoid fails with CLANG_DEFAULT_RTLIB

kristina created this revision. kristina added reviewers: sammccall, lebedev.ri, sthibaul. Herald added a project: clang. Driver test `cross-linux.c` fails when CLANG_DEFAULT_RTLIB is "compiler-rt" as the it expects a GCC-style `"crtbegin.o"` after `"crti.o"` but instead receives something akin

[PATCH] D72239: [clang-tidy] new opencl recursion not supported check

ffrankies created this revision. ffrankies added reviewers: aaron.ballman, alexfh, hokein. ffrankies added projects: clang, clang-tools-extra, LLVM. Herald added subscribers: mgehre, arphaman, xazax.hun, Anastasia, yaxunl, mgorny. This lint check is part of the FLOCL (FPGA Linters for OpenCL)

[PATCH] D72235: [clang-tidy] new altera unroll loops check

Eugene.Zelenko added a comment. I think will be good idea to separate module code in own review or refer to previous one of previous reviews as dependency. Comment at: clang-tidy/altera/UnrollLoopsCheck.cpp:31 +void UnrollLoopsCheck::check(const MatchFinder::MatchResult ) { +

[PATCH] D72241: [clang-tidy] new altera single work item barrier check

Eugene.Zelenko added a comment. I think will be good idea to separate module code in own review or refer to previous one of previous reviews as dependency. Comment at: clang-tidy/altera/SingleWorkItemBarrierCheck.cpp:51 +if (Attribute->getKind() ==

[PATCH] D69758: [Gnu toolchain] Look at standard GCC paths for libstdcxx by default

MaskRay added a comment. > Patch by sthibaul (Samuel Thibault) @kristina As a belated advice... since LLVM has moved from svn to git, we can ask contributors's names and emails, and then do `git commit --amend --author 'name '` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D64305: [clangd] Add path mappings functionality

wwagner19 updated this revision to Diff 236295. wwagner19 added a comment. To be honest, I'm not sure how to remedy this. So I just rebased all my commits into one and dropped the `git show HEAD -U99` into here. Please let me know if you need me to fix anything / open a new diff. CHANGES

[PATCH] D72245: [PoC][RISCV][LTO] Pass target-abi via module flag metadata

khchen created this revision. Herald added subscribers: llvm-commits, cfe-commits, luismarques, apazos, sameer.abuasal, pzheng, s.egerton, lenary, Jim, benna, psnobl, dang, jocewei, PkmX, rkruppe, dexonsmith, the_o, brucehoult, MartinMosbeck, rogfer01, steven_wu, edward-jones, zzheng, MaskRay,

[PATCH] D72236: [Clang] Force rtlib=platform in test to avoid fails with CLANG_DEFAULT_RTLIB

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 61250 tests passed, 0 failed and 736 were skipped. {icon times-circle color=red} clang-tidy: fail. Please fix clang-tidy findings

[PATCH] D72227: Add options for clang to align branches within 32B boundary

skan updated this revision to Diff 236280. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72227/new/ https://reviews.llvm.org/D72227 Files: clang/include/clang/Driver/Options.td clang/lib/Driver/ToolChains/Clang.cpp clang/test/Driver/intel-align-branch.c Index:

[PATCH] D64305: [clangd] Add path mappings functionality

wwagner19 updated this revision to Diff 236293. wwagner19 added a comment. The last diff was broken, this most recent one - Changes IsIncoming boolean to an enum - Refactors the matching path logic CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64305/new/

Re: [clang] 4711512 - Fix oversight in AST traversal helper

Sorry, will do. This was something I had intended to do in the original commit. Thanks, Stephen. On 05/01/2020 22:00, Aaron Ballman wrote: Can you also include more detail in commit logs than this? It doesn't explain why this is an oversight, which makes code archaeology harder later.

[PATCH] D72235: [clang-tidy] new altera unroll loops check

ffrankies updated this revision to Diff 236270. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72235/new/ https://reviews.llvm.org/D72235 Files: clang-tidy/CMakeLists.txt clang-tidy/ClangTidyForceLinker.h clang-tidy/altera/AlteraTidyModule.cpp clang-tidy/altera/CMakeLists.txt

[PATCH] D72235: [clang-tidy] new altera unroll loops check

ffrankies created this revision. ffrankies added reviewers: aaron.ballman, hokein, alexfh. ffrankies added projects: clang-tools-extra, clang, LLVM. Herald added subscribers: mgehre, arphaman, zzheng, xazax.hun, Anastasia, mgorny. ffrankies updated this revision to Diff 236270. ffrankies updated

[PATCH] D72235: [clang-tidy] new altera unroll loops check

ffrankies updated this revision to Diff 236271. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72235/new/ https://reviews.llvm.org/D72235 Files: clang-tidy/CMakeLists.txt clang-tidy/ClangTidyForceLinker.h clang-tidy/altera/AlteraTidyModule.cpp clang-tidy/altera/CMakeLists.txt

[PATCH] D72242: Fix crash on value dependent bitfields in if conditions in templates

eandrews created this revision. eandrews added reviewers: rnk, erichkeane, alexfh, alexfh_. This patch is a follow up to D69950 , to fix a new crash on CXX condition expressions in templates, for value dependent bitfields. Clang currently crashes when integral

[PATCH] D72241: [clang-tidy] new altera single work item barrier check

ffrankies created this revision. ffrankies added reviewers: aaron.ballman, alexfh, hokein, Eugene.Zelenko. ffrankies added projects: clang-tools-extra, clang. Herald added subscribers: mgehre, jfb, arphaman, xazax.hun, Anastasia, mgorny. This lint check is a part of the FLOCL (FPGA Linters for

[PATCH] D54943: [clang-tidy] implement const-transformation for cppcoreguidelines-const-correctness

0x8000- added a comment. In D54943#1804943 , @JonasToth wrote: > - Merge branch 'master' into feature_transform_const.patch > - link clangAnalysis to the cppcoreguidelines-module > - fix InitListExpr as well This last version too builds with

[PATCH] D72110: [X86] ABI compat bugfix for MSVC vectorcall

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72110/new/ https://reviews.llvm.org/D72110

[PATCH] D72245: [PoC][RISCV][LTO] Pass target-abi via module flag metadata

khchen updated this revision to Diff 236296. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72245/new/ https://reviews.llvm.org/D72245 Files: clang/lib/CodeGen/CodeGenModule.cpp clang/lib/Driver/ToolChains/RISCVToolchain.cpp clang/lib/Driver/ToolChains/RISCVToolchain.h

[PATCH] D69758: [Gnu toolchain] Look at standard GCC paths for libstdcxx by default

sthibaul added a comment. Which checksuite are you running? I had been using ninja check-all, and I do indeed get unexpected failures, but exactly the same set of failures as when building against master. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69758/new/

[PATCH] D54943: [clang-tidy] implement const-transformation for cppcoreguidelines-const-correctness

JonasToth added a comment. `clang/lib` almost transforms cleanly. issues still left: - `InitListExpr` can initialize non-const references. Such cases are not figured out yet (see `create_false_positive` at the end of the testcases) - I found a case in clang, where `const` was correctly added to

[PATCH] D54943: [clang-tidy] implement const-transformation for cppcoreguidelines-const-correctness

JonasToth added a comment. In D54943#1804905 , @0x8000- wrote: > In D54943#1804904 , @JonasToth wrote: > > > In D54943#1804890 , @0x8000- > > wrote: > > > > > I

Re: [clang] 4711512 - Fix oversight in AST traversal helper

Added in 35efef5351e. Thanks, Stephen. On 05/01/2020 20:33, Roman Lebedev wrote: Is there a test for this missing? On Sun, Jan 5, 2020 at 11:32 PM Stephen Kelly via cfe-commits wrote: Author: Stephen Kelly Date: 2020-01-05T20:27:37Z New Revision: 471151238438201f3fe365a7784f1a091328e46c

[PATCH] D54943: [clang-tidy] implement const-transformation for cppcoreguidelines-const-correctness

0x8000- added a comment. In D54943#1804904 , @JonasToth wrote: > In D54943#1804890 , @0x8000- > wrote: > > > I can't build this on top of current llvm-project tree > >

[PATCH] D72217: [clang-tidy] Added readability-qualified-auto check

njames93 added a comment. fixed some of the code guidelines issues. Will tackle some of the more pressing issues like ensuring correctness CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72217/new/ https://reviews.llvm.org/D72217 ___

[PATCH] D54943: [clang-tidy] implement const-transformation for cppcoreguidelines-const-correctness

JonasToth updated this revision to Diff 236259. JonasToth added a comment. - Merge branch 'master' into feature_transform_const.patch - link clangAnalysis to the cppcoreguidelines-module - fix InitListExpr as well Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D72231: [Sema] Adds the pointer-to-int-cast diagnostic

Mordante added a comment. In D72231#1804929 , @xbolva00 wrote: > >> The diagnostic is not enabled by default > > But GCC enables it for C even without "-Wall or -Wextra". Clang should follow > it.. I'll have a look what the impact is. When I tested it

Re: [clang] 4711512 - Fix oversight in AST traversal helper

Can you also include more detail in commit logs than this? It doesn't explain why this is an oversight, which makes code archaeology harder later. On Sun, Jan 5, 2020, 3:32 PM Stephen Kelly via cfe-commits < cfe-commits@lists.llvm.org> wrote: > > Author: Stephen Kelly > Date:

[PATCH] D69758: [Gnu toolchain] Look at standard GCC paths for libstdcxx by default

kristina added a comment. For future - Since you seem to put up a lot of (well, almost all) patches related to Hurd support, may I suggest requesting commit access so you can land patches yourself after review? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D72217: [clang-tidy] Added readability-qualified-auto check

njames93 updated this revision to Diff 236255. njames93 marked 13 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72217/new/ https://reviews.llvm.org/D72217 Files: clang-tools-extra/clang-tidy/readability/CMakeLists.txt

[PATCH] D72231: [Sema] Adds the pointer-to-int-cast diagnostic

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 61248 tests passed, 0 failed and 736 were skipped. {icon times-circle color=red} clang-tidy: fail. Please fix clang-tidy findings

[PATCH] D69758: [Gnu toolchain] Look at standard GCC paths for libstdcxx by default

sthibaul added a comment. > Let me know if you need this committed. Yes, please commit. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69758/new/ https://reviews.llvm.org/D69758 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D72053: [RFC] Handling implementation limits

Mordante updated this revision to Diff 236248. Mordante marked an inline comment as done. Mordante added a comment. Made some improvements based on feedback of @craig.topper: - Adds a not - Implements an example of the maximum string length when using -Wpedantic CHANGES SINCE LAST ACTION

[PATCH] D71221: [HIP] Add option --gpu-max-threads-per-block=n

yaxunl added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71221/new/ https://reviews.llvm.org/D71221 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 4711512 - Fix oversight in AST traversal helper

Author: Stephen Kelly Date: 2020-01-05T20:27:37Z New Revision: 471151238438201f3fe365a7784f1a091328e46c URL: https://github.com/llvm/llvm-project/commit/471151238438201f3fe365a7784f1a091328e46c DIFF: https://github.com/llvm/llvm-project/commit/471151238438201f3fe365a7784f1a091328e46c.diff

Re: [clang] 4711512 - Fix oversight in AST traversal helper

Is there a test for this missing? On Sun, Jan 5, 2020 at 11:32 PM Stephen Kelly via cfe-commits wrote: > > > Author: Stephen Kelly > Date: 2020-01-05T20:27:37Z > New Revision: 471151238438201f3fe365a7784f1a091328e46c > > URL: >

[PATCH] D54943: [clang-tidy] implement const-transformation for cppcoreguidelines-const-correctness

JonasToth updated this revision to Diff 236253. JonasToth added a comment. - find more false positives - fix false positive with refernces to containers in range-for. This introduces false negative though - new test-case for check - fix range-for iterator speciality; start working on complex

[PATCH] D72217: [clang-tidy] Added readability-qualified-auto check

sylvestre.ledru added a comment. In D72217#1804533 , @njames93 wrote: > side note when creating this, the add_new_check.py file hasn't been updated > in relation to this commit >

[PATCH] D54943: [clang-tidy] implement const-transformation for cppcoreguidelines-const-correctness

0x8000- added a comment. I can't build this on top of current llvm-project tree (6a6e6f04ec2cd2f4f07ec4943036c5c2d47ce0c7 ): /usr/bin/ld: lib/libclangTidyCppCoreGuidelinesModule.a(ConstCorrectnessCheck.cpp.o): in

[PATCH] D72217: [clang-tidy] Added readability-qualified-auto check

JonasToth added a comment. +1 for the check from me as well :) Comment at: clang-tools-extra/clang-tidy/readability/QualifiedAutoCheck.cpp:19 + if (!getLangOpts().CPlusPlus) { +// auto deduction not used in c +return; Please make the comments full

[PATCH] D54943: [clang-tidy] implement const-transformation for cppcoreguidelines-const-correctness

JonasToth added a comment. In D54943#1804890 , @0x8000- wrote: > I can't build this on top of current llvm-project tree > (6a6e6f04ec2cd2f4f07ec4943036c5c2d47ce0c7 > ): > >

[PATCH] D72014: [PowerPC]: Add powerpcspe target triple subarch component

jhibbits added a comment. Any more feedback on this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72014/new/ https://reviews.llvm.org/D72014 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D69758: [Gnu toolchain] Look at standard GCC paths for libstdcxx by default

sthibaul added a comment. I am actually getting many failures with ninja check-all on my build box: Expected Passes: 56258 Expected Failures : 203 Unsupported Tests : 1485 Unexpected Failures: 164 I have attached the whole check log: F11178531: check.log

[PATCH] D69758: [Gnu toolchain] Look at standard GCC paths for libstdcxx by default

sthibaul added a comment. (I don't see anything looking like what you have, so can't investigate) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69758/new/ https://reviews.llvm.org/D69758 ___ cfe-commits mailing list

[clang] 35efef5 - Add missing test

Author: Stephen Kelly Date: 2020-01-05T21:55:52Z New Revision: 35efef5351e3b3a4e50bcd862407ef7edc0b2166 URL: https://github.com/llvm/llvm-project/commit/35efef5351e3b3a4e50bcd862407ef7edc0b2166 DIFF: https://github.com/llvm/llvm-project/commit/35efef5351e3b3a4e50bcd862407ef7edc0b2166.diff

[PATCH] D72239: [clang-tidy] new opencl recursion not supported check

Eugene.Zelenko added a comment. I think will be good idea to separate module code in own review or refer to previous one of previous reviews as dependency. Comment at: clang-tidy/opencl/RecursionNotSupportedCheck.cpp:28 +void RecursionNotSupportedCheck::check(const

[clang] ce67db4 - [Clang] Force rtlib=platform in test to avoid fails with CLANG_DEFAULT_RTLIB

Author: Kristina Brooks Date: 2020-01-06T07:21:15Z New Revision: ce67db4185374016a9f5745869f9dbedfc12e6d2 URL: https://github.com/llvm/llvm-project/commit/ce67db4185374016a9f5745869f9dbedfc12e6d2 DIFF: https://github.com/llvm/llvm-project/commit/ce67db4185374016a9f5745869f9dbedfc12e6d2.diff

[PATCH] D72236: [Clang] Force rtlib=platform in test to avoid fails with CLANG_DEFAULT_RTLIB

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rGce67db418537: [Clang] Force rtlib=platform in test to avoid fails with CLANG_DEFAULT_RTLIB (authored by kristina).

[PATCH] D72247: Add Triple::isX86()

MaskRay created this revision. MaskRay added reviewers: craig.topper, jyknight, reames, skan. Herald added subscribers: llvm-commits, cfe-commits, dexonsmith, hiraditya. Herald added projects: clang, LLVM. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D72247 Files:

[PATCH] D72239: [clang-tidy] new opencl recursion not supported check

lebedev.ri requested changes to this revision. lebedev.ri added a comment. This revision now requires changes to proceed. I was just going to look into this kind of check. This can be implemented without recursion in the check itself. Let me write it and post my variant. Repository: rCTE

[PATCH] D72227: Add options for clang to align branches within 32B boundary

MaskRay added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:2010 +static void AlignBranchesOptions(const Driver , const ArgList , + ArgStringList ) { The convention is `camelCase`. This file is inconsistent

[PATCH] D72236: [Clang] Force rtlib=platform in test to avoid fails with CLANG_DEFAULT_RTLIB

MaskRay added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72236/new/ https://reviews.llvm.org/D72236 ___ cfe-commits mailing list cfe-commits@lists.llvm.org