[clang-tools-extra] 734aa1d - [clangd] Publish xref for macros from Index and AST.

2020-01-13 Thread Utkarsh Saxena via cfe-commits
Author: Utkarsh Saxena Date: 2020-01-13T11:11:18+01:00 New Revision: 734aa1d133f264746f721a244d2c66bc99648ee5 URL: https://github.com/llvm/llvm-project/commit/734aa1d133f264746f721a244d2c66bc99648ee5 DIFF:

[PATCH] D72395: [clangd] Publish xref for macros from Index and AST.

2020-01-13 Thread UTKARSH SAXENA via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG734aa1d133f2: [clangd] Publish xref for macros from Index and AST. (authored by usaxena95). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72395/new/

[PATCH] D71688: [AArch64] Add -mtls-size option for ELF targets

2020-01-13 Thread Peter Smith via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG10c11e4e2d05: This option allows selecting the TLS size in the local exec TLS model, which is… (authored by kawashima-fj, committed by peter.smith). Herald added a subscriber: cfe-commits. Repository:

[PATCH] D72395: [clangd] Publish xref for macros from Index and AST.

2020-01-13 Thread pre-merge checks [bot] via Phabricator via cfe-commits
merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 61641 tests passed, 0 failed and 777 were skipped. {icon check-circle color=green} clang-tidy: pass. {icon check-circle color=green} clang-format: pass. Build artifacts

[PATCH] D72498: [clangd] Print underlying type for decltypes in hover

2020-01-13 Thread Sam McCall via Phabricator via cfe-commits
sammccall added a comment. In D72498#1816244 , @ilya-biryukov wrote: > In D72498#1815500 , @lh123 wrote: > > > - hover over the `front` , you'll see "instance-method `front` → > > `std::vector >::reference`". > >

[PATCH] D72401: Fixes for spaces around C# object initializers

2020-01-13 Thread Krasimir Georgiev via Phabricator via cfe-commits
krasimir added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:2869 +// space before '{' in "new MyType {" +if (Left.is(TT_Unknown) && Right.is(tok::l_brace) && Left.Previous && +Left.Previous->is(tok::kw_new)) krasimir wrote: >

[PATCH] D69970: [CGDebugInfo] Emit subprograms for decls when AT_tail_call is understood (reland with fixes)

2020-01-13 Thread Djordje Todorovic via Phabricator via cfe-commits
djtodoro added a comment. I guess this should be closed? :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69970/new/ https://reviews.llvm.org/D69970 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D62686: [RISCV] Add support for save/restore of callee-saved registers via libcalls

2020-01-13 Thread Lewis Revill via Phabricator via cfe-commits
lewis-revill updated this revision to Diff 237620. lewis-revill added a comment. Fix .cfi_offset signedness error. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62686/new/ https://reviews.llvm.org/D62686 Files:

[PATCH] D72498: [clangd] Print underlying type for decltypes in hover

2020-01-13 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet added a comment. In D72498#1813989 , @ilya-biryukov wrote: > In D72498#1813962 , @sammccall wrote: > > > It's particularly unclear to me why typeprinter descends into auto but > > prints decltype, but

[PATCH] D62686: [RISCV] Add support for save/restore of callee-saved registers via libcalls

2020-01-13 Thread Lewis Revill via Phabricator via cfe-commits
lewis-revill added a comment. In D62686#1815158 , @pzheng wrote: > I see the following .cfi_offset directives generated using @shiva0217's test > case. Any idea why the offset for ra is 536870908? > > callt0, __riscv_save_0 > .cfi_def_cfa_offset

[PATCH] D70524: Support DebugInfo generation for auto return type for C++ functions.

2020-01-13 Thread Sourabh Singh Tomar via Phabricator via cfe-commits
SouraVX added a comment. Thanks @sammccall , for the test case. Seems like, this implementation doesn't address the lambda functions returning "auto". We're looking into this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70524/new/

[PATCH] D72395: [clangd] Publish xref for macros from Index and AST.

2020-01-13 Thread UTKARSH SAXENA via Phabricator via cfe-commits
usaxena95 updated this revision to Diff 237596. usaxena95 marked 3 inline comments as done. usaxena95 added a comment. Removed repeated check from the test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72395/new/ https://reviews.llvm.org/D72395

[PATCH] D72395: [clangd] Publish xref for macros from Index and AST.

2020-01-13 Thread UTKARSH SAXENA via Phabricator via cfe-commits
usaxena95 added inline comments. Comment at: clang-tools-extra/clangd/unittests/XRefsTests.cpp:1093 + + // If the main file is in the index, we don't return duplicates. + // (even if the references are in a different location) kadircet wrote: > i know the

[clang] e45fcfc - Revert "[DWARF5][clang]: Added support for DebugInfo generation for auto return type for C++ member functions."

2020-01-13 Thread Sam McCall via cfe-commits
Author: Sam McCall Date: 2020-01-13T11:13:16+01:00 New Revision: e45fcfc3aa57bb237fd4fd694d0c257be66d5482 URL: https://github.com/llvm/llvm-project/commit/e45fcfc3aa57bb237fd4fd694d0c257be66d5482 DIFF: https://github.com/llvm/llvm-project/commit/e45fcfc3aa57bb237fd4fd694d0c257be66d5482.diff

[clang] 10c11e4 - This option allows selecting the TLS size in the local exec TLS model,

2020-01-13 Thread Peter Smith via cfe-commits
Author: KAWASHIMA Takahiro Date: 2020-01-13T10:16:53Z New Revision: 10c11e4e2d05cf0e8f8251f50d84ce77eb1e9b8d URL: https://github.com/llvm/llvm-project/commit/10c11e4e2d05cf0e8f8251f50d84ce77eb1e9b8d DIFF: https://github.com/llvm/llvm-project/commit/10c11e4e2d05cf0e8f8251f50d84ce77eb1e9b8d.diff

[PATCH] D62686: [RISCV] Add support for save/restore of callee-saved registers via libcalls

2020-01-13 Thread Lewis Revill via Phabricator via cfe-commits
lewis-revill added a comment. In D62686#1808041 , @apazos wrote: > Lewis, is the patch final? It would be good to merge it before the 10.0 > release branch creation on Jan 15th I would say so now. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D70524: Support DebugInfo generation for auto return type for C++ functions.

2020-01-13 Thread Sam McCall via Phabricator via cfe-commits
sammccall added a comment. This seems to have introduced a crash compiling libcxx. I'm currently reducing the crashing code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70524/new/ https://reviews.llvm.org/D70524

[PATCH] D71688: [AArch64] Add -mtls-size option for ELF targets

2020-01-13 Thread Peter Smith via Phabricator via cfe-commits
peter.smith added a comment. Committed as 10c11e4e2d05cf0e8f8251f50d84ce77eb1e9b8d , I've used the new attribution process https://llvm.org/docs/DeveloperPolicy.html so you should show up as the author of the patch in the

[PATCH] D69825: [Clang][Driver] Re-use the calling process instead of creating a new process for the cc1 invocation

2020-01-13 Thread Hans Wennborg via Phabricator via cfe-commits
hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. Looks good to me (with a minor comment). Thanks! Comment at: clang/tools/driver/driver.cpp:271 +unsigned long long Enable; +if (getAsUnsignedInteger(SpawnCC1Str, 10,

[PATCH] D72498: [clangd] Print underlying type for decltypes in hover

2020-01-13 Thread liu hui via Phabricator via cfe-commits
lh123 added a comment. In D72498#1816339 , @sammccall wrote: > In D72498#1816244 , @ilya-biryukov > wrote: > > > In D72498#1815500 , @lh123 wrote: > > > > > - hover over

[PATCH] D72591: [clang] [test] Fix riscv-toolchain-extra to be less picky about paths

2020-01-13 Thread Michał Górny via Phabricator via cfe-commits
mgorny created this revision. mgorny added reviewers: edward-jones, MaskRay. Herald added subscribers: luismarques, apazos, sameer.abuasal, pzheng, s.egerton, lenary, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, zzheng, shiva0217, kito-cheng, niosHD, sabuasal,

[PATCH] D72594: [clangd] Include expression in DecltypeTypeLoc sourcerange while building SelectionTree

2020-01-13 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Currently AST only contains the location for `decltype` keyword, therefore we were skipping

[PATCH] D70524: Support DebugInfo generation for auto return type for C++ functions.

2020-01-13 Thread Sam McCall via Phabricator via cfe-commits
sammccall added a comment. Following crashes for me with `clang++ -g2`: struct Thing { void crash(Thing ) { auto Lambda = [&] { Other.external(); }; Lambda(); } void external(); }; void test(Thing , Thing ) { A.crash(B); } Haven't yet

[PATCH] D70524: Support DebugInfo generation for auto return type for C++ functions.

2020-01-13 Thread Sam McCall via Phabricator via cfe-commits
sammccall added a comment. In D70524#1816492 , @sammccall wrote: > Following crashes for me with `clang++ -g2`: This crashes at 6d6a4590c5d4 but not at c958639098a8

[PATCH] D69868: Allow "callbr" to return non-void values

2020-01-13 Thread Bill Wendling via Phabricator via cfe-commits
void marked 2 inline comments as done. void added inline comments. Comment at: llvm/lib/CodeGen/MachineVerifier.cpp:701 + } else if (MBB->succ_size() == LandingPadSuccs.size() || + MBB->succ_size() == IndirectPadSuccs.size()) { // It's possible that

[PATCH] D72594: [clangd] Include expression in DecltypeTypeLoc sourcerange while building SelectionTree

2020-01-13 Thread pre-merge checks [bot] via Phabricator via cfe-commits
merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 61742 tests passed, 0 failed and 780 were skipped. {icon question-circle color=gray} clang-tidy: unknown. {icon check-circle color=green} clang-format: pass. Build artifacts

[clang-tools-extra] b96ec49 - [clangd] Remove raw string literals in macros

2020-01-13 Thread Oliver Stannard via cfe-commits
Author: Oliver Stannard Date: 2020-01-13T11:45:05Z New Revision: b96ec492d34ecf31fd2c8d2f0033f00e36cc2b9c URL: https://github.com/llvm/llvm-project/commit/b96ec492d34ecf31fd2c8d2f0033f00e36cc2b9c DIFF: https://github.com/llvm/llvm-project/commit/b96ec492d34ecf31fd2c8d2f0033f00e36cc2b9c.diff

[PATCH] D72245: [PoC][RISCV][LTO] Pass target-abi via module flag metadata

2020-01-13 Thread Sam Elliott via Phabricator via cfe-commits
lenary added inline comments. Comment at: llvm/lib/LTO/LTOBackend.cpp:151 + TargetMachine::initTargetOptions(M, Conf.Options); + tejohnson wrote: > lenary wrote: > > tejohnson wrote: > > > This is going to be problematic. The Conf is a reference to the Config

[PATCH] D71451: Support to emit extern variables debuginfo with "-fstandalone-debug"

2020-01-13 Thread Adrian Prantl via Phabricator via cfe-commits
aprantl added a comment. In D71451#1816269 , @Jac1494 wrote: > ping I'd be curious to the answer to David's questions. If the size increase is because of unused extern variables coming in from libc or something then it doesn't seem worth the cost.

[PATCH] D71365: expand printf when compiling HIP to AMDGPU

2020-01-13 Thread Matt Arsenault via Phabricator via cfe-commits
arsenm added inline comments. Comment at: clang/test/CodeGenHIP/printf.cpp:18 +} + +// CHECK: [[BEGIN:%.*]] = call i64 @__ockl_printf_begin(i64 0) sameerds wrote: > sameerds wrote: > > arsenm wrote: > > > This could use a lot more testcases. Can you add some

[PATCH] D72623: [clangd] Rearrange type, returntype and parameters in hover card

2020-01-13 Thread Sam McCall via Phabricator via cfe-commits
sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/Hover.cpp:552 +// For functions we display signature in a list form, e.g.: +// Generates `x` from: +// - `bool

[PATCH] D72527: [clang-tidy] adjust scripts to subsubsections in Release Notes

2020-01-13 Thread Alexander Kornienko via Phabricator via cfe-commits
alexfh added a comment. In D72527#1817518 , @Eugene.Zelenko wrote: > Both scripts works fine. However rename script should also sort entries > alphabetically, but probably this should be separate patch. Yep, sorting of the list on rename is a separate

[PATCH] D72612: [AArch64][SVE] Add ImmArg property to intrinsics with immediates

2020-01-13 Thread Sander de Smalen via Phabricator via cfe-commits
sdesmalen added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64InstrFormats.td:1099 +class AsmVectorIndexOpnd +: Operand, ComplexPattern", []> { let ParserMatchClass = mc; @efriedma @rengolin The idea here is to use a ComplexPattern to

[PATCH] D69970: [CGDebugInfo] Emit subprograms for decls when AT_tail_call is understood (reland with fixes)

2020-01-13 Thread Vedant Kumar via Phabricator via cfe-commits
vsk closed this revision. vsk added a comment. Yes, this landed in 568db780bb7267651a902da8e85bc59fc89aea70 . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69970/new/ https://reviews.llvm.org/D69970

[PATCH] D70524: Support DebugInfo generation for auto return type for C++ functions.

2020-01-13 Thread Stella Stamenova via Phabricator via cfe-commits
stella.stamenova added a comment. This also broke a number of the tests on the Windows LLDB bot, so when you get around to resubmitting the change with a fix, please make sure the bot doesn't get broken again: http://lab.llvm.org:8011/builders/lldb-x64-windows-ninja/builds/12551 Repository:

[PATCH] D72500: [clangd] Show hover info for expressions

2020-01-13 Thread pre-merge checks [bot] via Phabricator via cfe-commits
merge_guards_bot added a comment. {icon question-circle color=gray} Unit tests: unknown. {icon question-circle color=gray} clang-tidy: unknown. {icon question-circle color=gray} clang-format: unknown. Build artifacts :

[PATCH] D72579: Evaluate __{c11_,}atomic_is_lock_free to 0 (avoid libcall) if larger than MaxAtomicPromoteWidth

2020-01-13 Thread Nemanja Ivanovic via Phabricator via cfe-commits
nemanjai added a comment. If I understand this correctly, this just evaluates the query for lock free atomics at compile time if the size is larger than the maximum possible size for an atomic on the target. If that's the case, this looks fine to me. But of course, some of the other target

[PATCH] D72245: [PoC][RISCV][LTO] Pass target-abi via module flag metadata

2020-01-13 Thread Teresa Johnson via Phabricator via cfe-commits
tejohnson added inline comments. Comment at: llvm/lib/LTO/LTOBackend.cpp:151 + TargetMachine::initTargetOptions(M, Conf.Options); + This is going to be problematic. The Conf is a reference to the Config object saved on the LTO class instance shared by all

[PATCH] D72121: [clang-tidy] Fix readability-identifier-naming missing member variables

2020-01-13 Thread Nathan James via Phabricator via cfe-commits
njames93 marked an inline comment as done. njames93 added a comment. Is anyone able to commit on my behalf? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72121/new/ https://reviews.llvm.org/D72121 ___ cfe-commits mailing list

[PATCH] D72634: [clangd] Improve ObjC property handling in SelectionTree.

2020-01-13 Thread Sam McCall via Phabricator via cfe-commits
sammccall created this revision. sammccall added a reviewer: dgoldman. Herald added subscribers: cfe-commits, usaxena95, kadircet, jfb, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D72634 Files:

[PATCH] D72634: [clangd] Improve ObjC property handling in SelectionTree.

2020-01-13 Thread pre-merge checks [bot] via Phabricator via cfe-commits
merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 61796 tests passed, 0 failed and 781 were skipped. {icon question-circle color=gray} clang-tidy: unknown. {icon check-circle color=green} clang-format: pass. Build artifacts

[PATCH] D72362: [clang-tidy] misc-no-recursion: a new check

2020-01-13 Thread Roman Lebedev via Phabricator via cfe-commits
lebedev.ri marked 3 inline comments as done. lebedev.ri added a comment. In D72362#1817599 , @bader wrote: > Does it make sense to implement such diagnostics in clang Sema, considering > that OpenCL does not allow recursion? > We implemented similar

[PATCH] D72624: [WIP] TargetMachine Hook for Module Metadata

2020-01-13 Thread Sam Elliott via Phabricator via cfe-commits
lenary created this revision. lenary added reviewers: tejohnson, dblaikie, khchen, dsanders, echristo. Herald added subscribers: llvm-commits, lldb-commits, cfe-commits, liufengdb, herhut, lucyrfox, mgester, arpith-jacob, csigg, nicolasvasilache, antiagainst, shauheen, burmako, jpienaar,

[PATCH] D72625: [clangd] Render header of hover card as a heading

2020-01-13 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D72625 Files:

[PATCH] D72523: [remark][diagnostics] Using clang diagnostic handler for IR input files

2020-01-13 Thread Rong Xu via Phabricator via cfe-commits
xur marked 3 inline comments as done. xur added inline comments. Comment at: clang/lib/CodeGen/CodeGenAction.cpp:594 + // SourceLoc. + if (Context == nullptr) { +return FullSourceLoc(); tejohnson wrote: > Does this only happen with IR input? Does it always

[PATCH] D72630: [clang-tidy] Ignore implicit casts in modernize-use-default-member-init

2020-01-13 Thread Malcolm Parsons via Phabricator via cfe-commits
malcolm.parsons created this revision. malcolm.parsons added reviewers: aaron.ballman, alexfh, JonasToth. Herald added subscribers: cfe-commits, xazax.hun. Herald added a project: clang. Initialising a pointer from nullptr involves an implicit cast. Ignore it after getting initialiser from

[clang] 292562c - Try number 2 for fixing bot failures

2020-01-13 Thread Teresa Johnson via cfe-commits
Author: Teresa Johnson Date: 2020-01-13T10:12:35-08:00 New Revision: 292562c0046c72ea1ed229dbe13a89dca73e5b89 URL: https://github.com/llvm/llvm-project/commit/292562c0046c72ea1ed229dbe13a89dca73e5b89 DIFF:

[clang] 7aed43b - Hopefully last fix for bot failures

2020-01-13 Thread Teresa Johnson via cfe-commits
Author: Teresa Johnson Date: 2020-01-13T10:34:54-08:00 New Revision: 7aed43b60739653b13b8503f9df4c958c44feed8 URL: https://github.com/llvm/llvm-project/commit/7aed43b60739653b13b8503f9df4c958c44feed8 DIFF:

[PATCH] D63960: [C++20] Add consteval-specific semantic for functions

2020-01-13 Thread Tyker via Phabricator via cfe-commits
Tyker added a comment. @rsmith friendly reminder CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63960/new/ https://reviews.llvm.org/D63960 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D72622: [clangd] Add a ruler after header in hover

2020-01-13 Thread Sam McCall via Phabricator via cfe-commits
sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/Hover.cpp:553 + // Put a linebreak after header to increase readability. + Output.addRuler(); (When

[PATCH] D72121: [clang-tidy] Fix readability-identifier-naming missing member variables

2020-01-13 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman closed this revision. aaron.ballman added a comment. In D72121#1817170 , @njames93 wrote: > Is anyone able to commit on my behalf? Happy to do so. I've committed for you in fb79ef524171c96a9f3df025ac7a8a3e00fdc0b4

[PATCH] D72245: [PoC][RISCV][LTO] Pass target-abi via module flag metadata

2020-01-13 Thread Teresa Johnson via Phabricator via cfe-commits
tejohnson added inline comments. Comment at: llvm/lib/LTO/LTOBackend.cpp:151 + TargetMachine::initTargetOptions(M, Conf.Options); + lenary wrote: > tejohnson wrote: > > This is going to be problematic. The Conf is a reference to the Config > > object saved

[PATCH] D72484: [clang-tidy] Fix check for Abseil internal namespace access

2020-01-13 Thread Gennadiy Rozental via Phabricator via cfe-commits
rogeeff marked 2 inline comments as done. rogeeff added inline comments. Comment at: clang-tools-extra/clang-tidy/abseil/NoInternalDependenciesCheck.cpp:43-44 + + if (!LocAtFault.isValid()) +return; + lebedev.ri wrote: > Is there test coverage for this?

[clang] bb2e5f5 - Fix tests for builtbot failures

2020-01-13 Thread Teresa Johnson via cfe-commits
Author: Teresa Johnson Date: 2020-01-13T09:28:13-08:00 New Revision: bb2e5f5e454245c8e7e9e4c9bf7a463c64604292 URL: https://github.com/llvm/llvm-project/commit/bb2e5f5e454245c8e7e9e4c9bf7a463c64604292 DIFF:

[PATCH] D72527: [clang-tidy] adjust scripts to subsubsections in Release Notes

2020-01-13 Thread Eugene Zelenko via Phabricator via cfe-commits
Eugene.Zelenko marked an inline comment as done. Eugene.Zelenko added a comment. Both scripts works fine. However rename script should also sort entries alphabetically, but probably this should be separate patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D72594: [clangd] Include expression in DecltypeTypeLoc sourcerange while building SelectionTree

2020-01-13 Thread Sam McCall via Phabricator via cfe-commits
sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Thanks! Comment at: clang-tools-extra/clangd/Selection.cpp:530 SourceRange S = N.getSourceRange(); +if (auto *TL = N.get()) { + // DecltypeTypeLoc only

[PATCH] D71600: PowerPC 32-bit - forces 8 byte lock/lock_free decisions at compiled time

2020-01-13 Thread JF Bastien via Phabricator via cfe-commits
jfb added a comment. In D71600#1816834 , @adalava wrote: > In D71600#1816160 , @MaskRay wrote: > > > I am still confused why you need the special rule for > > `__atomic_is_lock_free` (GCC/clang) and

[PATCH] D72579: Evaluate __{c11_,}atomic_is_lock_free to 0 (avoid libcall) if larger than MaxAtomicPromoteWidth

2020-01-13 Thread JF Bastien via Phabricator via cfe-commits
jfb added a subscriber: jwakely. jfb added a comment. This changes the expression to a constant expression as well, right? You should point this out in the commit message. The divergence with GCC is unfortunate, @jwakely do you think you'd be able to get GCC to match this behavior as well?

[PATCH] D71365: expand printf when compiling HIP to AMDGPU

2020-01-13 Thread Matt Arsenault via Phabricator via cfe-commits
arsenm added a comment. Mostly looks fine, except vectors are supposed to work Comment at: llvm/lib/Transforms/Utils/AMDGPUEmitPrintf.cpp:52 + } else if (Ty->getTypeID() == Type::DoubleTyID) { +return Builder.CreateBitCast(Arg, Int64Ty); + } else if (auto PtrTy =

[PATCH] D72527: [clang-tidy] adjust scripts to subsubsections in Release Notes

2020-01-13 Thread Eugene Zelenko via Phabricator via cfe-commits
Eugene.Zelenko updated this revision to Diff 237720. Eugene.Zelenko added a comment. Renamed "New aliases" to "New check aliases". Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72527/new/ https://reviews.llvm.org/D72527 Files:

[clang-tools-extra] fb79ef5 - Fix readability-identifier-naming missing member variables

2020-01-13 Thread Aaron Ballman via cfe-commits
Author: Nathan James Date: 2020-01-13T13:28:55-05:00 New Revision: fb79ef524171c96a9f3df025ac7a8a3e00fdc0b4 URL: https://github.com/llvm/llvm-project/commit/fb79ef524171c96a9f3df025ac7a8a3e00fdc0b4 DIFF: https://github.com/llvm/llvm-project/commit/fb79ef524171c96a9f3df025ac7a8a3e00fdc0b4.diff

[clang] cb988a8 - Add a couple of missed wildcards in debug-pass-manager output checking

2020-01-13 Thread Teresa Johnson via cfe-commits
Author: Teresa Johnson Date: 2020-01-13T10:49:40-08:00 New Revision: cb988a858abbaf1a1ae0fe03f2a1dae692131ea9 URL: https://github.com/llvm/llvm-project/commit/cb988a858abbaf1a1ae0fe03f2a1dae692131ea9 DIFF:

[PATCH] D72625: [clangd] Render header of hover card as a heading

2020-01-13 Thread pre-merge checks [bot] via Phabricator via cfe-commits
merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 61781 tests passed, 0 failed and 780 were skipped. {icon question-circle color=gray} clang-tidy: unknown. {icon check-circle color=green} clang-format: pass. Build artifacts

[PATCH] D72523: [remark][diagnostics] Using clang diagnostic handler for IR input files

2020-01-13 Thread Rong Xu via Phabricator via cfe-commits
xur updated this revision to Diff 237716. xur added a comment. Integrated Teresa's review comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72523/new/ https://reviews.llvm.org/D72523 Files: clang/lib/CodeGen/CodeGenAction.cpp

[PATCH] D72624: [WIP] TargetMachine Hook for Module Metadata

2020-01-13 Thread Teresa Johnson via Phabricator via cfe-commits
tejohnson added a comment. I'm not sure if ThinLTOCodeGenerator.cpp and LTOBackend.cpp were intentionally left out due to the LTO concerns mentioned in the description? Note if we are just passing in the Module and updating the TM based on that, it wouldn't hit the threading issue I mentioned

[PATCH] D72362: [clang-tidy] misc-no-recursion: a new check

2020-01-13 Thread Alexey Bader via Phabricator via cfe-commits
bader added a comment. Does it make sense to implement such diagnostics in clang Sema, considering that OpenCL does not allow recursion? We implemented similar diagnostics for SYCL programming model and would be like to upstream it to clang later

[PATCH] D72566: [clang-tidy] Clang tidy is now alias aware

2020-01-13 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added a comment. In D72566#1816109 , @lebedev.ri wrote: > I think the fact that this is a fourth (?) different incarnation of a patch > trying to solve the same *major* *ugly* problem, it may be an evidence that > perhaps this problem

[PATCH] D72634: [clangd] Improve ObjC property handling in SelectionTree.

2020-01-13 Thread David Goldman via Phabricator via cfe-commits
dgoldman requested changes to this revision. dgoldman added inline comments. This revision now requires changes to proceed. Comment at: clang-tools-extra/clangd/unittests/SelectionTests.cpp:347 + )cpp", + "ObjCPropertyRefExpr"}, + Please add a

[clang] 6288f86 - Revert "[ThinLTO] Add additional ThinLTO pipeline testing with new PM"

2020-01-13 Thread Teresa Johnson via cfe-commits
Author: Teresa Johnson Date: 2020-01-13T11:01:48-08:00 New Revision: 6288f86e870c7bb7fe47cc138320b9eb34c93941 URL: https://github.com/llvm/llvm-project/commit/6288f86e870c7bb7fe47cc138320b9eb34c93941 DIFF:

[PATCH] D72245: [PoC][RISCV][LTO] Pass target-abi via module flag metadata

2020-01-13 Thread Sam Elliott via Phabricator via cfe-commits
lenary added inline comments. Comment at: llvm/lib/LTO/LTOBackend.cpp:151 + TargetMachine::initTargetOptions(M, Conf.Options); + tejohnson wrote: > This is going to be problematic. The Conf is a reference to the Config object > saved on the LTO class

[PATCH] D72622: [clangd] Add a ruler after header in hover

2020-01-13 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D72622 Files:

[PATCH] D72621: PR44514: Fix recovery from noexcept with non-convertible expressions

2020-01-13 Thread Erich Keane via Phabricator via cfe-commits
erichkeane created this revision. erichkeane added a reviewer: aaron.ballman. Herald added a project: clang. We currently treat noexcept(not-convertible-to-bool) as 'none', which results in the typeloc info being a different size, and causing an assert later on in the process. In order to make

[PATCH] D72500: [clangd] Show hover info for expressions

2020-01-13 Thread pre-merge checks [bot] via Phabricator via cfe-commits
merge_guards_bot added a comment. {icon question-circle color=gray} Unit tests: unknown. {icon question-circle color=gray} clang-tidy: unknown. {icon question-circle color=gray} clang-format: unknown. Build artifacts :

[PATCH] D69878: Consoldiate internal denormal flushing controls

2020-01-13 Thread Matt Arsenault via Phabricator via cfe-commits
arsenm updated this revision to Diff 237665. arsenm added a comment. Mention support in langref CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69878/new/ https://reviews.llvm.org/D69878 Files: clang/include/clang/Basic/CodeGenOptions.def clang/include/clang/Basic/CodeGenOptions.h

[PATCH] D72498: [clangd] Print underlying type for decltypes in hover

2020-01-13 Thread Sam McCall via Phabricator via cfe-commits
sammccall added a comment. In D72498#1816957 , @kadircet wrote: > In D72498#1816785 , @ilya-biryukov > wrote: > > > In D72498#1816424 , @lh123 wrote: > > > > > Currently, I

[PATCH] D69825: [Clang][Driver] Re-use the calling process instead of creating a new process for the cc1 invocation

2020-01-13 Thread Alexandre Ganea via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. aganea marked an inline comment as done. Closed by commit rGb4a99a061f51: [Clang][Driver] Re-use the calling process instead of creating a new process… (authored by aganea). Changed prior to commit:

[PATCH] D72484: [clang-tidy] Fix check for Abseil internal namespace access

2020-01-13 Thread Eugene Zelenko via Phabricator via cfe-commits
Eugene.Zelenko added a comment. In D72484#1817187 , @rogeeff wrote: > It is my first time submitting clang-tidy change. So I'm not sure of the > procedure exactly. Do we wait for something from me? Reviewers should make comments and finally approve

[PATCH] D72484: [clang-tidy] Fix check for Abseil internal namespace access

2020-01-13 Thread Roman Lebedev via Phabricator via cfe-commits
lebedev.ri added inline comments. Comment at: clang-tools-extra/clang-tidy/abseil/NoInternalDependenciesCheck.cpp:43-44 + + if (!LocAtFault.isValid()) +return; + Is there test coverage for this? When does/can this happen? CHANGES SINCE LAST ACTION

[clang] 6c20314 - [clang] Remove raw string literals in macros

2020-01-13 Thread Oliver Stannard via cfe-commits
Author: Oliver Stannard Date: 2020-01-13T12:38:58Z New Revision: 6c203149b60e92e802df0c7a431744c337830a09 URL: https://github.com/llvm/llvm-project/commit/6c203149b60e92e802df0c7a431744c337830a09 DIFF: https://github.com/llvm/llvm-project/commit/6c203149b60e92e802df0c7a431744c337830a09.diff

[PATCH] D72538: [ThinLTO] Add additional ThinLTO pipeline testing with new PM

2020-01-13 Thread Teresa Johnson via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG2af97be8027a: [ThinLTO] Add additional ThinLTO pipeline testing with new PM (authored by tejohnson). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D72623: [clangd] Rearrange type, returntype and parameters in hover card

2020-01-13 Thread pre-merge checks [bot] via Phabricator via cfe-commits
merge_guards_bot added a comment. {icon question-circle color=gray} Unit tests: unknown. {icon question-circle color=gray} clang-tidy: unknown. {icon question-circle color=gray} clang-format: unknown. Build artifacts :

[PATCH] D72623: [clangd] Rearrange type, returntype and parameters in hover card

2020-01-13 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet created this revision. kadircet added reviewers: sammccall, ilya-biryukov. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay. Herald added a project: clang. Moves type/returntype into its own line as it is more readable in cases where the type is long. Also

[PATCH] D72622: [clangd] Add a ruler after header in hover

2020-01-13 Thread pre-merge checks [bot] via Phabricator via cfe-commits
merge_guards_bot added a comment. {icon question-circle color=gray} Unit tests: unknown. {icon question-circle color=gray} clang-tidy: unknown. {icon check-circle color=green} clang-format: pass. Build artifacts :

[PATCH] D71848: Allow the discovery of Android NDK's triple-prefixed binaries.

2020-01-13 Thread Brian Ledger via Phabricator via cfe-commits
brianpl updated this revision to Diff 237691. brianpl added a comment. - Search for tools prefixed with GNU target triples. - Merge branch 'master' of https://github.com/llvm/llvm-project Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71848/new/

[PATCH] D72500: [clangd] Show hower info for expressions

2020-01-13 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet added a comment. In D72500#1813975 , @sammccall wrote: > Basing this on the hover for the type doesn't seem right. e.g. `int` should > be the `Type` rather than the `Name`. > > Rather than printing the value if evaluable, I think we should only

[PATCH] D72500: [clangd] Show hower info for expressions

2020-01-13 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet updated this revision to Diff 237649. kadircet added a comment. - Ignore literals Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72500/new/ https://reviews.llvm.org/D72500 Files: clang-tools-extra/clangd/Hover.cpp

[PATCH] D71913: [LTO/WPD] Enable aggressive WPD under LTO option

2020-01-13 Thread Eugene Leviant via Phabricator via cfe-commits
evgeny777 added inline comments. Comment at: clang/lib/CodeGen/BackendUtil.cpp:559 + if (!CodeGenOpts.ThinLTOIndexFile.empty()) +MPM.add(createLowerTypeTestsPass(/*ExportSummary=*/nullptr, + /*ImportSummary=*/nullptr,

[clang] b4a99a0 - [Clang][Driver] Re-use the calling process instead of creating a new process for the cc1 invocation

2020-01-13 Thread Alexandre Ganea via cfe-commits
Author: Alexandre Ganea Date: 2020-01-13T10:40:18-05:00 New Revision: b4a99a061f517e60985667e39519f60186cbb469 URL: https://github.com/llvm/llvm-project/commit/b4a99a061f517e60985667e39519f60186cbb469 DIFF:

[PATCH] D72427: [DebugInfo] Add option to clang to limit debug info that is emitted for classes.

2020-01-13 Thread Orlando Cazalet-Hyams via Phabricator via cfe-commits
Orlando added inline comments. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:2225 + !CXXDecl->isLambda() && !isClassOrMethodDLLImport(CXXDecl)) { +for (const auto *ctor : CXXDecl->ctors()) { + if (ctor->isUserProvided()) Nit: Should `ctor` be

[PATCH] D69590: [RISCV] Fix ILP32D lowering for double+double/double+int return types

2020-01-13 Thread Alex Bradbury via Phabricator via cfe-commits
asb accepted this revision. asb added a comment. This revision is now accepted and ready to land. Herald added a subscriber: luismarques. This looks good to me, thanks James. I had a closer step through of the logic here to convince myself. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D72612: [AArch64][SVE] Add ImmArg property to intrinsics with immediates

2020-01-13 Thread Kerry McLaughlin via Phabricator via cfe-commits
kmclaughlin created this revision. kmclaughlin added reviewers: efriedma, sdesmalen, andwar. Herald added subscribers: psnobl, rkruppe, hiraditya, kristof.beyls, tschuett. Herald added a reviewer: rengolin. Herald added a project: LLVM. Several SVE intrinsics with immediate arguments (including

[PATCH] D69590: [RISCV] Fix ILP32D lowering for double+double/double+int return types

2020-01-13 Thread Sam Elliott via Phabricator via cfe-commits
lenary accepted this revision. lenary added a comment. @jrtc27 It would be good to get this in for LLVM 10.0. Having gone through the logic with @asb, we are both confident this is the right fix, and this patch does not require any additions at the moment. Repository: rG LLVM Github

[PATCH] D72527: [clang-tidy] adjust scripts to subsubsections in Release Notes

2020-01-13 Thread Alexander Kornienko via Phabricator via cfe-commits
alexfh added a comment. LG with a nit, if this works. Comment at: clang-tools-extra/clang-tidy/add_new_check.py:223 + lineMatcher = re.compile('New checks') + nextSectionMatcher = re.compile('New aliases') checkerMatcher = re.compile('- New :doc:`(.*)')

[PATCH] D72500: [clangd] Show hover info for expressions

2020-01-13 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet updated this revision to Diff 237660. kadircet added a comment. - Update presentation for expressions, which doesn't have `Name` field set. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72500/new/ https://reviews.llvm.org/D72500 Files:

[PATCH] D71510: [clang][checkers] Added new checker 'error-return-checker'.

2020-01-13 Thread Balázs Kéri via Phabricator via cfe-commits
balazske updated this revision to Diff 237680. balazske added a comment. - Improved function list format in documentation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71510/new/ https://reviews.llvm.org/D71510 Files:

[PATCH] D72484: [clang-tidy] Fix check for Abseil internal namespace access

2020-01-13 Thread Gennadiy Rozental via Phabricator via cfe-commits
rogeeff added a comment. It is my first time submitting clang-tidy change. So I'm not sure of the procedure exactly. Do we wait for something from me? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72484/new/ https://reviews.llvm.org/D72484

[clang] 2af97be - [ThinLTO] Add additional ThinLTO pipeline testing with new PM

2020-01-13 Thread Teresa Johnson via cfe-commits
Author: Teresa Johnson Date: 2020-01-13T08:29:56-08:00 New Revision: 2af97be8027a0823b88d4b6a07fc5eedb440bc1f URL: https://github.com/llvm/llvm-project/commit/2af97be8027a0823b88d4b6a07fc5eedb440bc1f DIFF:

[PATCH] D72498: [clangd] Print underlying type for decltypes in hover

2020-01-13 Thread Ilya Biryukov via Phabricator via cfe-commits
ilya-biryukov added a comment. In D72498#1816424 , @lh123 wrote: > Currently, I think that in most cases, showing both expanded (canonical) and > spelled types is sufficient. > > > This has been used in ycmd for ~4 years without complaint. > >

[PATCH] D71600: PowerPC 32-bit - forces 8 byte lock/lock_free decisions at compiled time

2020-01-13 Thread Alfredo Dal'Ava Júnior via Phabricator via cfe-commits
adalava added a comment. In D71600#1816160 , @MaskRay wrote: > I am still confused why you need the special rule for `__atomic_is_lock_free` > (GCC/clang) and `__c11_atomic_is_lock_free` (clang). > >

[PATCH] D72498: [clangd] Print underlying type for decltypes in hover

2020-01-13 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet added a comment. In D72498#1816785 , @ilya-biryukov wrote: > In D72498#1816424 , @lh123 wrote: > > > Currently, I think that in most cases, showing both expanded (canonical) > > and spelled types is

  1   2   >