[PATCH] D73543: [clang] Add support for __builtin_memcpy_inline

gchatelet added a comment. @efriedma would you mind having a look? It should be my last patch on that matter :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73543/new/ https://reviews.llvm.org/D73543

[clang] a156a0e - [ASTMatchers] Add hasPlacementArg and hasAnyPlacementArg traversal matcher for CXXNewExpr

Author: Nathan James Date: 2020-01-30T10:16:04Z New Revision: a156a0e28df4751f812c84437321339c2eb33af3 URL: https://github.com/llvm/llvm-project/commit/a156a0e28df4751f812c84437321339c2eb33af3 DIFF: https://github.com/llvm/llvm-project/commit/a156a0e28df4751f812c84437321339c2eb33af3.diff LOG:

[PATCH] D73548: [clang-tidy] Added option for disabling const qualifiers in readability-qualified-auto

njames93 updated this revision to Diff 241374. njames93 added a comment. - Streamline fixits - Add documentation about double pointers, maybe a follow up patch to fix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73548/new/

[PATCH] D70818: [Analyzer] Model STL Algoirthms to improve the iterator checkers

baloghadamsoftware updated this revision to Diff 241364. baloghadamsoftware added a comment. Rebased. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70818/new/ https://reviews.llvm.org/D70818 Files: clang/include/clang/StaticAnalyzer/Checkers/Checkers.td

[PATCH] D72362: [clang-tidy] misc-no-recursion: a new check

bader added a comment. @lebedev.ri, thanks for the suggestion. We will investigate this option when we ready to upload clang diagnostics patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72362/new/ https://reviews.llvm.org/D72362

[PATCH] D73562: [ASTMatchers] Add hasPlacementArg and hasAnyPlacementArg traversal matcher for CXXNewExpr

This revision was automatically updated to reflect the committed changes. Closed by commit rGa156a0e28df4: [ASTMatchers] Add hasPlacementArg and hasAnyPlacementArg traversal matcher for… (authored by njames93). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D73624: [clangd][vscode] Get rid of the deprecated vscode module in the extension.

This revision was automatically updated to reflect the committed changes. Closed by commit rG9b71ec899a15: [clangd][vscode] Get rid of the deprecated vscode module in the extension. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang-tools-extra] 9b71ec8 - [clangd][vscode] Get rid of the deprecated vscode module in the extension.

Author: Haojian Wu Date: 2020-01-30T11:36:08+01:00 New Revision: 9b71ec899a1554210ec66756681c047a52866d39 URL: https://github.com/llvm/llvm-project/commit/9b71ec899a1554210ec66756681c047a52866d39 DIFF: https://github.com/llvm/llvm-project/commit/9b71ec899a1554210ec66756681c047a52866d39.diff

[PATCH] D73629: [analyzer] vfork checker: allow execve after vfork

janvcelak added a comment. In D73629#1847750 , @NoQ wrote: > We should add a test for this (cf. `test/Analysis/vfork.c`). There is already a test to check if the whitelist works by making sure that call to `execl` doesn't generate the warning. I think

[PATCH] D73675: Avoid many std::tie/tuple instantiations in ASTImporter

martong added a comment. Thanks for this patch too! However, I have a minor concern with this new approach: If `importSeq` fails then a `ToSomething` still holds a value from the "From" context. This could cause problems if it is used later in creating the new AST node. Normally, this should

[PATCH] D73696: [clang][Index] Introduce a TemplateParm SymbolKind

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, ilya-biryukov, kristof.beyls. Herald added a project: clang. Currently template parameters has symbolkind `Unknown`. This patch introduces a new kind

[PATCH] D73644: [Mips] Add intrinsics for 4-byte and 8-byte MSA loads/stores.

atanasyan added a comment. Is it possible to emulate these new intrinsics using existing ones and some additional code? Is code generated in this case much larger/slower then the code generated by the new intrinsics? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D73693: [clang][DeclPrinter] Implement visitors for {TemplateType,NonTypeTemplate}Parms

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 62330 tests passed, 0 failed and 838 were skipped. {icon check-circle color=green} clang-tidy: pass. {icon check-circle color=green} clang-format: pass. Build artifacts

[PATCH] D72717: [CMake] Disable libc++ filesystem tests in CrossWinToARMLinux cache file

broadwaylamb planned changes to this revision. broadwaylamb added a comment. In D72717#1848509 , @ldionne wrote: > It's weird to mix Clang and libc++ test options because they test > fundamentally different things. But I don't mind about this patch since

[clang-tools-extra] 7fd7a9a - [clangd] Bump vscode-clangd v0.0.20

Author: Haojian Wu Date: 2020-01-30T11:45:54+01:00 New Revision: 7fd7a9a6365f8026d84a89ec3e73d328a63742a0 URL: https://github.com/llvm/llvm-project/commit/7fd7a9a6365f8026d84a89ec3e73d328a63742a0 DIFF: https://github.com/llvm/llvm-project/commit/7fd7a9a6365f8026d84a89ec3e73d328a63742a0.diff

[PATCH] D73548: [clang-tidy] Added option for disabling const qualifiers in readability-qualified-auto

merge_guards_bot added a comment. {icon times-circle color=red} Unit tests: fail. 62275 tests passed, 1 failed and 827 were skipped. failed: Clang.CodeGenOpenCL/amdgpu-features.cl {icon check-circle color=green} clang-tidy: pass. {icon times-circle color=red} clang-format: fail. Please

[PATCH] D73629: [analyzer] vfork checker: allow execve after vfork

janvcelak added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/VforkChecker.cpp:109 "execvpe", + "execve", nullptr xazax.hun wrote: > Well, this is not the case now, but I wonder if it would also make sense to > sort this list

[PATCH] D69221: [clang][darwin] Fix search path logic for C_INCLUDE_DIRS

mhinz added a comment. In D69221#1848425 , @ldionne wrote: > Do you have commit access? No. :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69221/new/ https://reviews.llvm.org/D69221 ___

[PATCH] D73693: [clang][DeclPrinter] Implement visitors for {TemplateType,NonTypeTemplate}Parms

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, kristof.beyls. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D73693 Files:

[PATCH] D73687: [AArch64][SVE] Add SVE2 intrinsics for complex integer dot product

kmclaughlin created this revision. kmclaughlin added reviewers: sdesmalen, efriedma, dancgr, c-rhodes. Herald added subscribers: psnobl, rkruppe, hiraditya, kristof.beyls, tschuett. Herald added a reviewer: rengolin. Herald added a project: LLVM. Implements the following intrinsics: -

[clang-tools-extra] 4fb1adc - [clangd] Log directory when a CDB is loaded

Author: Kadir Cetinkaya Date: 2020-01-30T12:15:04+01:00 New Revision: 4fb1adcde22c06d421598ed1925ee3c7c835abc4 URL: https://github.com/llvm/llvm-project/commit/4fb1adcde22c06d421598ed1925ee3c7c835abc4 DIFF:

[PATCH] D73628: [clangd] Log directory when a CDB is loaded

kadircet updated this revision to Diff 241388. kadircet marked 2 inline comments as done. kadircet added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73628/new/ https://reviews.llvm.org/D73628 Files:

[PATCH] D73628: [clangd] Log directory when a CDB is loaded

This revision was automatically updated to reflect the committed changes. Closed by commit rG4fb1adcde22c: [clangd] Log directory when a CDB is loaded (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73628/new/

[clang-tools-extra] 827f49e - [clangd] Make go-to-def jumps to overriden methods on `final` specifier.

Author: Haojian Wu Date: 2020-01-30T12:49:30+01:00 New Revision: 827f49e3faf59f99082d0085de06dcbc09be8ba3 URL: https://github.com/llvm/llvm-project/commit/827f49e3faf59f99082d0085de06dcbc09be8ba3 DIFF: https://github.com/llvm/llvm-project/commit/827f49e3faf59f99082d0085de06dcbc09be8ba3.diff

[PATCH] D73462: [dwarf-5] Support DebugInfo for Defaulted parameters for C++ templates

awpandey updated this revision to Diff 241391. awpandey marked 7 inline comments as done. awpandey added a comment. Hi @dblaikie, I have incorporated your suggestions (renaming variables, test case modification). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73462/new/

[PATCH] D73462: [dwarf-5] Support DebugInfo for Defaulted parameters for C++ templates

awpandey marked an inline comment as done and an inline comment as not done. awpandey added inline comments. Comment at: llvm/lib/Bitcode/Writer/BitcodeWriter.cpp:1808-1809 Record.push_back(VE.getMetadataOrNullID(N->getType())); + if (M.getDwarfVersion() >= 5) +

[PATCH] D73690: [clangd] Make go-to-def jumps to overriden methods on `final` specifier.

hokein created this revision. hokein added a reviewer: sammccall. Herald added subscribers: usaxena95, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D73690 Files:

[PATCH] D73690: [clangd] Make go-to-def jumps to overriden methods on `final` specifier.

This revision was automatically updated to reflect the committed changes. Closed by commit rG827f49e3faf5: [clangd] Make go-to-def jumps to overriden methods on `final` specifier. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D73360: [OpenCL] Restrict address space conversions in nested pointers

Anastasia marked an inline comment as done. Anastasia added inline comments. Comment at: clang/test/SemaOpenCL/address-spaces-conversions-cl2.0.cl:521 +#else +// expected-error@-5 {{assigning to '__generic int *__generic *' from incompatible type '__local int *__local

[PATCH] D73690: [clangd] Make go-to-def jumps to overriden methods on `final` specifier.

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 62305 tests passed, 0 failed and 838 were skipped. {icon check-circle color=green} clang-tidy: pass. {icon times-circle color=red} clang-format: fail. Please format your changes with clang-format by running

[PATCH] D73667: Speed up compilation of ASTImporter

martong accepted this revision. martong added a comment. This revision is now accepted and ready to land. Thanks for the patch! Looks good to me! Comment at: clang/lib/AST/ASTImporter.cpp:192 + // Don't attempt to import nodes if we hit an error earlier. + if (Err) +

[PATCH] D73675: Avoid many std::tie/tuple instantiations in ASTImporter

martong added a subscriber: gamesh411. martong added inline comments. Comment at: clang/lib/AST/ASTImporter.cpp:1152 + if (Error E = importSeq(ToElementType, ToSizeExpr)) +return std::move(E); Quuxplusone wrote: > As the author of [P1155 "More Implicit

[PATCH] D73543: [clang] Add support for __builtin_memcpy_inline

gchatelet updated this revision to Diff 241356. gchatelet added a comment. rebasing Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73543/new/ https://reviews.llvm.org/D73543 Files: clang/docs/LanguageExtensions.rst

[PATCH] D73651: [OpenCL][CUDA][HIP][SYCL] Add norecurse

bader accepted this revision. bader added a comment. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73651/new/ https://reviews.llvm.org/D73651 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D73687: [AArch64][SVE] Add SVE2 intrinsics for complex integer dot product

efriedma added inline comments. Comment at: llvm/include/llvm/IR/IntrinsicsAArch64.td: + LLVMSubdivide4VectorType<0>, + llvm_i32_ty], +[IntrNoMem]>; Missing ImmArg? Comment at:

[PATCH] D73282: Fix debug-info generation for block invocations so that we set the LinkageName instead of the Name

dblaikie added inline comments. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:3659 // Use llvm function name. -Name = Fn->getName(); +if (Fn->getName().startswith("___Z")) + LinkageName = Fn->getName(); shafik wrote: > dblaikie wrote: > >

[clang] 980517b - [Concepts] Check function constraints before deducing auto return type

Author: Saar Raz Date: 2020-01-31T03:51:26+02:00 New Revision: 980517b3530ffb7faa1a23fdc007d78f5b45ae3c URL: https://github.com/llvm/llvm-project/commit/980517b3530ffb7faa1a23fdc007d78f5b45ae3c DIFF: https://github.com/llvm/llvm-project/commit/980517b3530ffb7faa1a23fdc007d78f5b45ae3c.diff

[PATCH] D73208: [objc_direct] fix codegen for mismatched Decl/Impl return types

MadCoder updated this revision to Diff 241599. MadCoder added a comment. @dexonsmith here, I still hook the same method but do it in a more LLVM-approved way ;) It works with minimap perf impect because the only case we call GenerateDirectMethod with an Implementation is if we're about to

[PATCH] D73208: [objc_direct] fix codegen for mismatched Decl/Impl return types

MadCoder updated this revision to Diff 241601. MadCoder added a comment. damn you tabs! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73208/new/ https://reviews.llvm.org/D73208 Files: clang/lib/CodeGen/CGObjCMac.cpp clang/test/CodeGenObjC/direct-method-ret-mismatch.m Index:

[PATCH] D73543: [clang] Add support for __builtin_memcpy_inline

efriedma added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:1653 +llvm::APSInt I(64); +if (!TheCall->getArg(2)->isIntegerConstantExpr(I, Context)) + Diag(TheCall->getBeginLoc(), diag::err_expr_not_ice) SemaBuiltinConstantArg. Or

[clang] c6cf360 - Revert "[objc_direct] Small updates to help with adoption."

Author: Pierre Habouzit Date: 2020-01-30T18:21:25-08:00 New Revision: c6cf3602e27b76669f785f5fd34b928a889b9db5 URL: https://github.com/llvm/llvm-project/commit/c6cf3602e27b76669f785f5fd34b928a889b9db5 DIFF:

[PATCH] D73734: [Fuchsia] Never link in implicit "system dependencies" of sanitizer runtimes

mcgrathr updated this revision to Diff 241561. mcgrathr added a comment. style nit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73734/new/ https://reviews.llvm.org/D73734 Files: clang/lib/Driver/ToolChains/CommonArgs.cpp Index:

[PATCH] D73052: [clang-tidy] RenamerClangTidy now renames dependent member expr when the member can be resolved

njames93 added a comment. I toyed with the idea of checking the access specifier for the dependent base classes, but I'm pretty sure it doesn't matter. If the compile finds 2 look ups in one base class it will pick the later dependancy regardless of whether its private or not. And if the

[PATCH] D73363: Verify that clang's max alignment is <= LLVM's max alignment

rnk added inline comments. Comment at: clang/lib/CodeGen/CGValue.h:18 #include "clang/AST/ASTContext.h" +#include "clang/Sema/Sema.h" #include "clang/AST/Type.h" This includes Sema.h into every codegen file that uses CGValue.h (most of them). That seems bad

[clang] 01943a5 - Move verification of Sema::MaximumAlignment to a .cpp file

Author: Reid Kleckner Date: 2020-01-30T13:37:52-08:00 New Revision: 01943a59f51d8b5ede062305941c1f864b8a6a13 URL: https://github.com/llvm/llvm-project/commit/01943a59f51d8b5ede062305941c1f864b8a6a13 DIFF: https://github.com/llvm/llvm-project/commit/01943a59f51d8b5ede062305941c1f864b8a6a13.diff

[PATCH] D70950: Add ProcName to TimeTraceProfiler

rnk added a comment. This broke ClangBuildAnalyzer on Windows because it has a very naive check for "clang": https://github.com/aras-p/ClangBuildAnalyzer/blob/master/src/main.cpp#L148 I was wondering why this wasn't working on Windows anymore. =/ Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D73245: Don't define std::max_align_t if not used in C++03 mode

joerg added a comment. Let me clarify the situation for a moment: (1) libc++ does try to work in C++03 mode. See the separate implementation of for pre-C++11. It is also desirable to support. This is completely beside the question of TR1 support. (2) The only reason why max_align_t is

[clang] d28763c - Replace 'AllowExplicit' bool with an enum. No functionality change.

Author: Richard Smith Date: 2020-01-30T17:16:50-08:00 New Revision: d28763cad06e66651e1936756d3e28126b055abf URL: https://github.com/llvm/llvm-project/commit/d28763cad06e66651e1936756d3e28126b055abf DIFF: https://github.com/llvm/llvm-project/commit/d28763cad06e66651e1936756d3e28126b055abf.diff

[clang] 1f3f8c3 - PR44721: Don't consider overloaded operators for built-in comparisons

Author: Richard Smith Date: 2020-01-30T17:16:50-08:00 New Revision: 1f3f8c369a5067a132c871f33a955a7feaea8534 URL: https://github.com/llvm/llvm-project/commit/1f3f8c369a5067a132c871f33a955a7feaea8534 DIFF: https://github.com/llvm/llvm-project/commit/1f3f8c369a5067a132c871f33a955a7feaea8534.diff

[PATCH] D73208: [objc_direct] fix codegen for mismatched Decl/Impl return types

MadCoder updated this revision to Diff 241613. MadCoder marked an inline comment as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73208/new/ https://reviews.llvm.org/D73208 Files: clang/lib/CodeGen/CGObjCMac.cpp clang/test/CodeGenObjC/direct-method-ret-mismatch.m Index:

Re: [clang] 1f3f8c3 - PR44721: Don't consider overloaded operators for built-in comparisons

Hi Hans, This is a pretty safe bugfix for a new feature in Clang 10. OK for branch? On Thu, 30 Jan 2020 at 17:17, Richard Smith via cfe-commits < cfe-commits@lists.llvm.org> wrote: > > Author: Richard Smith > Date: 2020-01-30T17:16:50-08:00 > New Revision:

[PATCH] D73208: [objc_direct] fix codegen for mismatched Decl/Impl return types

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. LGTM, with one style nitpick. Comment at: clang/lib/CodeGen/CGObjCMac.cpp:4049-4051 +if (!OMD->getBody() || COMD->getReturnType() == OMD->getReturnType()) { +

[PATCH] D73742: [Clang][Driver] After default -fintegrated-cc1, fix report_fatal_error no longer generates preprocessed source + reproducer.sh

aganea created this revision. aganea added reviewers: arichardson, rnk, hans. Herald added subscribers: llvm-commits, cfe-commits, hiraditya. Herald added projects: clang, LLVM. As reported by @arichardson , this patch now makes `llvm::report_fatal_error()` to generate a preprocessed source +

[PATCH] D72876: Create a clang-tidy check to warn when -dealloc is implemented inside an ObjC class category.

mwyman added inline comments. Comment at: clang-tools-extra/clang-tidy/objc/DeallocInCategoryCheck.cpp:34 + +void DeallocInCategoryCheck::check(const MatchFinder::MatchResult ) { + const auto *MatchedDecl = Result.Nodes.getNodeAs("dealloc"); stephanemoore

[PATCH] D73245: Don't define std::max_align_t if not used in C++03 mode

rsmith added a comment. libc++ intentionally provides all the C++11 library functionality that it can, even when used from C++03 mode. So on the face of it, providing this name in C++03 mode seems appropriate. However... the implementation currently used by libc++ **doesn't work** in that

[PATCH] D73208: [objc_direct] fix codegen for mismatched Decl/Impl return types

This revision was automatically updated to reflect the committed changes. Closed by commit rG6eb969b7c5b5: [objc_direct] fix codegen for mismatched Decl/Impl return types (authored by MadCoder). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D73762: New warning for for-loops where the iteration does not match the loop condition

rtrieu created this revision. This is a warning for when the increment/decrement in a for loop does not match the condition in the loop. If the condition has a relational operator, one operand can be deduced to be the larger value and the other operand the smaller value when the loop is run.

[clang] 1db66e7 - PR44627: Consider reversing == and <=> candidates found by ADL.

Author: Richard Smith Date: 2020-01-30T18:41:54-08:00 New Revision: 1db66e705f4dbe7dbe17edac804289ef59d5f616 URL: https://github.com/llvm/llvm-project/commit/1db66e705f4dbe7dbe17edac804289ef59d5f616 DIFF: https://github.com/llvm/llvm-project/commit/1db66e705f4dbe7dbe17edac804289ef59d5f616.diff

[PATCH] D73675: Avoid many std::tie/tuple instantiations in ASTImporter

merge_guards_bot added a comment. {icon times-circle color=red} Unit tests: fail. 62352 tests passed, 1 failed and 839 were skipped. failed: libc++.std/containers/sequences/array/array_creation/to_array.fail.cpp {icon times-circle color=red} clang-tidy: fail. clang-tidy found 0 errors and

[PATCH] D73734: [Fuchsia] Never link in implicit "system dependencies" of sanitizer runtimes

mcgrathr updated this revision to Diff 241560. mcgrathr added a comment. builds now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73734/new/ https://reviews.llvm.org/D73734 Files: clang/lib/Driver/ToolChains/CommonArgs.cpp Index:

[PATCH] D73363: Verify that clang's max alignment is <= LLVM's max alignment

rnk added a comment. I moved this include in rG01943a59f51d8b5ede062305941c1f864b8a6a13 . I meant to paste this in the message, but I'll put it here, since the results were significant: $ diff -u deps-before.txt

[PATCH] D72876: Create a clang-tidy check to warn when -dealloc is implemented inside an ObjC class category.

mwyman updated this revision to Diff 241573. mwyman marked 9 inline comments as done. mwyman added a comment. Implemented review feedback. Updated diagnostic message to mention the category name. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D73755: [objc_direct] Small updates to help with adoption.

MadCoder created this revision. MadCoder added reviewers: ahatanak, dexonsmith, arphaman, erik.pilkington. MadCoder added a project: clang. Herald added subscribers: cfe-commits, jfb. Add fixits for messaging self in MRR or using super, as the intent is clear, and it turns out people do that a

[clang] bebb8e2 - [objc_direct] Small updates to help with adoption.

Author: Pierre Habouzit Date: 2020-01-30T18:17:45-08:00 New Revision: bebb8e2596af8fe97f9b6356ff06e4e80580cf32 URL: https://github.com/llvm/llvm-project/commit/bebb8e2596af8fe97f9b6356ff06e4e80580cf32 DIFF:

[clang] 6eb969b - [objc_direct] fix codegen for mismatched Decl/Impl return types

Author: Pierre Habouzit Date: 2020-01-30T18:17:45-08:00 New Revision: 6eb969b7c5b5195d7f85b70e2e060eb2989cdc3c URL: https://github.com/llvm/llvm-project/commit/6eb969b7c5b5195d7f85b70e2e060eb2989cdc3c DIFF:

[PATCH] D73282: Fix debug-info generation for block invocations so that we set the LinkageName instead of the Name

shafik marked an inline comment as done. shafik added inline comments. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:3659 // Use llvm function name. -Name = Fn->getName(); +if (Fn->getName().startswith("___Z")) + LinkageName = Fn->getName();

[clang] fdf31ae - [Fuchsia] Never link in implicit "system dependencies" of sanitizer runtimes

Author: Roland McGrath Date: 2020-01-30T14:21:23-08:00 New Revision: fdf31ae32dd2bddd9cc72ee7108f0c69bb2e637f URL: https://github.com/llvm/llvm-project/commit/fdf31ae32dd2bddd9cc72ee7108f0c69bb2e637f DIFF:

[PATCH] D73734: [Fuchsia] Never link in implicit "system dependencies" of sanitizer runtimes

This revision was automatically updated to reflect the committed changes. Closed by commit rGfdf31ae32dd2: [Fuchsia] Never link in implicit system dependencies of sanitizer runtimes (authored by mcgrathr, committed by phosek). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 5ae6554 - PR41991: Accept attributes on defaulted and deleted friends.

Author: Richard Smith Date: 2020-01-30T17:42:17-08:00 New Revision: 5ae6554a1dcd2e39346030c06d364492901c9e8d URL: https://github.com/llvm/llvm-project/commit/5ae6554a1dcd2e39346030c06d364492901c9e8d DIFF: https://github.com/llvm/llvm-project/commit/5ae6554a1dcd2e39346030c06d364492901c9e8d.diff

[PATCH] D73701: [clang] fix linkage of nested lambda

rsmith added a comment. This is effectively reverting https://reviews.llvm.org/D1783. If we don't need that any more for whatever reason, can we also get rid of the check for whether the outermost lambda has a mangling number a few lines above? (Please also check if we can remove

[PATCH] D73282: Fix debug-info generation for block invocations so that we set the LinkageName instead of the Name

shafik updated this revision to Diff 241508. shafik marked 4 inline comments as done. shafik added a comment. Address comments by not special casing the `___Z` case, this requires setting both the Name and Linkage name because DWARF requires subroutines to have a `DW_AT_name`. We discovered

[PATCH] D73282: Fix debug-info generation for block invocations so that we set the LinkageName instead of the Name

shafik marked an inline comment as done. shafik added inline comments. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:3659 // Use llvm function name. -Name = Fn->getName(); +if (Fn->getName().startswith("___Z")) + LinkageName = Fn->getName();

[PATCH] D73729: [analyzer] AnalyzerOptions: Remove 'fixits-as-remarks'

Charusso created this revision. Charusso added a reviewer: NoQ. Charusso added a project: clang. Herald added subscribers: cfe-commits, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Charusso added a parent revision: D69746: [analyzer] FixItHint:

[PATCH] D73675: Avoid many std::tie/tuple instantiations in ASTImporter

rnk planned changes to this revision. rnk marked an inline comment as done. rnk added a comment. In D73675#1849182 , @martong wrote: > Thanks for this patch too! > However, I have a minor concern with this new approach: > If `importSeq` fails then a

[PATCH] D73052: [clang-tidy] RenamerClangTidy now renames dependent member expr when the member can be resolved

merge_guards_bot added a comment. {icon times-circle color=red} Unit tests: fail. 62347 tests passed, 1 failed and 839 were skipped. failed: libc++.std/containers/sequences/array/array_creation/to_array.fail.cpp {icon check-circle color=green} clang-tidy: pass. {icon check-circle

[PATCH] D73242: [WPD/LowerTypeTests] Delay lowering/removal of type tests until after ICP

tejohnson added a comment. In D73242#1849484 , @tejohnson wrote: > Both of these approaches need the type tests to determine the correct address > point offset (the offset in the type test) to use in the compare sequence. I typed this too fast - the

Re: Getting started

Hi Anshil, take a look at this: https://clang.llvm.org/docs/InternalsManual.html cxx1x is probably done already, but cxx2a has some outstanding features ;) In general, please use 'cfe-dev' instead of 'cfe-commits'. There is the normal discussion and questions/answers for developers. Regards

[PATCH] D73738: [Clang][Bundler][NFC] Replace SmallString<...> with StringRef

sdmitriev created this revision. sdmitriev added a reviewer: ABataev. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D73738 Files: clang/tools/clang-offload-bundler/ClangOffloadBundler.cpp Index:

[PATCH] D73462: [dwarf-5] Support DebugInfo for Defaulted parameters for C++ templates

awpandey marked an inline comment as not done. awpandey added a comment. @aprantl Thanks for your valuable feedback. I have a doubt. You need a .ll file its corresponding llvm bytecode generated by current llvm (without my patch). Doest this ll file includes any checks? In the round trip test

[PATCH] D73282: Fix debug-info generation for block invocations so that we set the LinkageName instead of the Name

shafik updated this revision to Diff 241638. shafik added a comment. Using a more targeted approach. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73282/new/ https://reviews.llvm.org/D73282 Files: clang/lib/CodeGen/CGDebugInfo.cpp

[PATCH] D72841: [RFC] Add support for pragma float_control, to control precision and exception behavior at the source level

sepavloff added a comment. You could check the scope where the pragma appears is the same way as `pragma clang fp` does. The code case tok::annot_pragma_fp: ProhibitAttributes(Attrs); Diag(Tok, diag::err_pragma_fp_scope); ConsumeAnnotationToken(); return StmtError(); is put

[PATCH] D73282: Fix debug-info generation for block invocations so that we set the LinkageName instead of the Name

shafik marked an inline comment as done. shafik added inline comments. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:3659 // Use llvm function name. -Name = Fn->getName(); +if (Fn->getName().startswith("___Z")) + LinkageName = Fn->getName();

[PATCH] D73762: [clang] New warning for for-loops where the iteration does not match the loop condition

Eugene.Zelenko added a comment. It's good question where this check belongs. There are two loop related checks in CLang-tidy: bugprone-infinite-loop and bugprone-too-small-loop-variable. Comment at: clang/lib/Sema/SemaStmt.cpp:1754 +if (!Cond->isRelationalOp()) return; +

[PATCH] D71227: [cuda][hip] Fix function overload resolution in the global initiailizer.

hliao added a comment. In D71227#1831445 , @hliao wrote: > Sorry for the late reply. Really appreciate your feedback. Thanks! @rsmith Have you chance to review the revised change? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D73052: [clang-tidy] RenamerClangTidy now renames dependent member expr when the member can be resolved

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 62329 tests passed, 0 failed and 838 were skipped. {icon check-circle color=green} clang-tidy: pass. {icon check-circle color=green} clang-format: pass. Build artifacts

[PATCH] D73715: - Update .clang-tidy to ignore parameters of main like functions for naming violations in clang and llvm directory

njames93 created this revision. njames93 added reviewers: alexfh, hokein. Herald added subscribers: llvm-commits, cfe-commits, aheejin. Herald added projects: clang, LLVM. njames93 marked an inline comment as done. njames93 added inline comments. Comment at: clang/.clang-tidy:23

[PATCH] D69731: [analyzer] CheckerContext: Make the Preprocessor available

This revision was automatically updated to reflect the committed changes. Closed by commit rG38ab3b876baa: [analyzer] CheckerContext: Make the Preprocessor available (authored by Charusso). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69731/new/

[clang-tools-extra] 3ae11b4 - [NFC] small refactor on RenamerClangTidyCheck.cpp

Author: Nathan James Date: 2020-01-30T17:32:06Z New Revision: 3ae11b42818363f70b3c6b0246bb617e35709c58 URL: https://github.com/llvm/llvm-project/commit/3ae11b42818363f70b3c6b0246bb617e35709c58 DIFF: https://github.com/llvm/llvm-project/commit/3ae11b42818363f70b3c6b0246bb617e35709c58.diff LOG:

[clang] c83d9be - [Concept] Fix incorrect check for containsUnexpandedParameterPack in CSE

Author: Saar Raz Date: 2020-01-30T20:45:44+02:00 New Revision: c83d9bedc0cc430dc620e7a807daeb985d390325 URL: https://github.com/llvm/llvm-project/commit/c83d9bedc0cc430dc620e7a807daeb985d390325 DIFF: https://github.com/llvm/llvm-project/commit/c83d9bedc0cc430dc620e7a807daeb985d390325.diff

[PATCH] D73734: [Fuchsia] Never link in implicit "system dependencies" of sanitizer runtimes

mcgrathr created this revision. mcgrathr added a reviewer: phosek. Herald added a project: clang. Herald added a subscriber: cfe-commits. This is never appropriate on Fuchsia and any future needs for system library dependencies of compiler-supplied runtimes will be addressed via `.deplibs`

[PATCH] D73354: clang-format: insert trailing commas into containers.

MyDeveloperDay added a comment. Nit: don't forget the ClangFormatStyleOption.rst and ReleaseNote.rst changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73354/new/ https://reviews.llvm.org/D73354

[PATCH] D73354: clang-format: insert trailing commas into containers.

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. I'm happy if you are, I think given that you've really been one of the main contributors of clang-format [JS] for the last number of years you are the best person to probably assess the impact on Javascript code. Thanks for

[PATCH] D73637: Fix handling of OO_Spaceship in DecodeOperatorCall

sberg updated this revision to Diff 241485. sberg added a comment. Minimal reproducer is template struct S; template void operator <=>(S, S); template void f(T x) { decltype(x <=> x) v; } Added a corresponding test to clang/test/SemaCXX/cxx2a-three-way-comparison.cpp. CHANGES SINCE LAST

[PATCH] D72811: [WIP][OPENMP5.0] allow lvalue for motion clause

ABataev added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:15201 +namespace { +class LocatorChecker final : public StmtVisitor { + OMPClauseMappableExprCommon::MappableExprComponentList Components; Seems to me, you're skipping many expressions,

[PATCH] D67399: [ARM] Follow AACPS for preserving number of loads/stores of volatile bit-fields

dnsampaio updated this revision to Diff 241486. dnsampaio added a comment. - Added flag to allow user to opt-in Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67399/new/ https://reviews.llvm.org/D67399 Files:

[PATCH] D73360: [OpenCL] Restrict address space conversions in nested pointers

rjmccall added a comment. Is there no follow-up code when actually emitting the failure diagnostic which tries to figure out a more specific cause of failure? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73360/new/ https://reviews.llvm.org/D73360

[PATCH] D73721: [Clang][Driver] Disable llvm passes for the first host OpenMP offload compilation

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73721/new/ https://reviews.llvm.org/D73721

[PATCH] D73723: [clangd][Hover] Handle uninstantiated default args

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 62330 tests passed, 0 failed and 838 were skipped. {icon check-circle color=green} clang-tidy: pass. {icon check-circle color=green} clang-format: pass. Build artifacts

[PATCH] D73721: [Clang][Driver] Disable llvm passes for the first host OpenMP offload compilation

This revision was automatically updated to reflect the committed changes. Closed by commit rG36bfdb7096cf: [Clang][Driver] Disable llvm passes for the first host OpenMP offload… (authored by sdmitriev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D54943: [clang-tidy] implement const-transformation for cppcoreguidelines-const-correctness

JonasToth added a comment. In D54943#1841086 , @AlexanderLanin wrote: > In D54943#1815772 , @0x8000- > wrote: > > > This generated 56 "const const" declarations, of which 25 were triple const! > This could

  1   2   >