[clang] 90dc78b - [ARM, MVE] Add intrinsics for abs, neg and not operations.

2020-02-18 Thread Simon Tatham via cfe-commits
Author: Simon Tatham Date: 2020-02-18T09:34:50Z New Revision: 90dc78bc62784faaa55afb0320cf3c2187d80ac6 URL: https://github.com/llvm/llvm-project/commit/90dc78bc62784faaa55afb0320cf3c2187d80ac6 DIFF: https://github.com/llvm/llvm-project/commit/90dc78bc62784faaa55afb0320cf3c2187d80ac6.diff LOG:

[clang] b6236e9 - [ARM, MVE] Add the vrev16q, vrev32q, vrev64q family.

2020-02-18 Thread Simon Tatham via cfe-commits
Author: Simon Tatham Date: 2020-02-18T09:34:50Z New Revision: b6236e94799e43fad1f024e84ed56a85d9a3623f URL: https://github.com/llvm/llvm-project/commit/b6236e94799e43fad1f024e84ed56a85d9a3623f DIFF: https://github.com/llvm/llvm-project/commit/b6236e94799e43fad1f024e84ed56a85d9a3623f.diff LOG:

[clang] c8b3196 - [ARM, MVE] Add intrinsics for FP rounding operations.

2020-02-18 Thread Simon Tatham via cfe-commits
Author: Simon Tatham Date: 2020-02-18T09:34:50Z New Revision: c8b3196e54308b0113d2a0888d13ccc92e3b7ccc URL: https://github.com/llvm/llvm-project/commit/c8b3196e54308b0113d2a0888d13ccc92e3b7ccc DIFF: https://github.com/llvm/llvm-project/commit/c8b3196e54308b0113d2a0888d13ccc92e3b7ccc.diff LOG:

[clang] df3ed6c - [ARM, MVE] Add intrinsics for int <-> float conversion.

2020-02-18 Thread Simon Tatham via cfe-commits
Author: Simon Tatham Date: 2020-02-18T09:34:50Z New Revision: df3ed6c0fe31094941e4cd814cdf924b63993c4e URL: https://github.com/llvm/llvm-project/commit/df3ed6c0fe31094941e4cd814cdf924b63993c4e DIFF: https://github.com/llvm/llvm-project/commit/df3ed6c0fe31094941e4cd814cdf924b63993c4e.diff LOG:

[PATCH] D70876: [clang-tidy] Add spuriously-wake-up-functions check

2020-02-18 Thread Kocsis Ábel via Phabricator via cfe-commits
abelkocsis updated this revision to Diff 245113. abelkocsis added a comment. Test cases adding, checker modifying to pass new cases. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70876/new/ https://reviews.llvm.org/D70876 Files:

[PATCH] D74735: [analyzer] Add support for CXXInheritedCtorInitExpr.

2020-02-18 Thread Gabor Marton via Phabricator via cfe-commits
martong added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/PathSensitive/CallEvent.h:872 +/// +/// Example: \c class T : public S { using S::S; }; T(1); +class CXXInheritedConstructorCall : public AnyFunctionCall { Perhaps the example

[PATCH] D74337: [ARM,MVE] Add the vmovnbq,vmovntq intrinsic family.

2020-02-18 Thread Simon Tatham via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGc32af4447f79: [ARM,MVE] Add the vmovnbq,vmovntq intrinsic family. (authored by simon_tatham). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74337/new/

[PATCH] D74336: [ARM,MVE] Add the vmovlbq,vmovltq intrinsic family.

2020-02-18 Thread Simon Tatham via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG5e97940cd279: [ARM,MVE] Add the vmovlbq,vmovltq intrinsic family. (authored by simon_tatham). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74336/new/

[PATCH] D73462: [dwarf-5] Support DebugInfo for Defaulted parameters for C++ templates

2020-02-18 Thread Awanish Pandey via Phabricator via cfe-commits
awpandey added a comment. Hi @aprantl, I have included all of your suggestions. Can I merge this? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73462/new/ https://reviews.llvm.org/D73462 ___ cfe-commits mailing list

[PATCH] D74757: Fix compiler extension in standalone mode

2020-02-18 Thread serge via Phabricator via cfe-commits
serge-sans-paille added a comment. I still need to test many configurations, I'll report here. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74757/new/ https://reviews.llvm.org/D74757 ___ cfe-commits

[PATCH] D74757: Fix compiler extension in standalone mode

2020-02-18 Thread serge via Phabricator via cfe-commits
serge-sans-paille created this revision. serge-sans-paille added reviewers: Meinersbur, Keruspe. Herald added subscribers: llvm-commits, cfe-commits, mgorny. Herald added projects: clang, LLVM. serge-sans-paille added a comment. I still need to test many configurations, I'll report here. Use a

[PATCH] D74704: Support -fuse-ld=lld for riscv

2020-02-18 Thread serge via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGdd230142d8a0: Support -fuse-ld=lld for riscv (authored by serge-sans-paille). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74704/new/

[PATCH] D74732: [ARM,CDE] Cosmetic changes, additonal driver tests

2020-02-18 Thread Mikhail Maltsev via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG58f66f8af01d: [ARM,CDE] Cosmetic changes, additonal driver tests (authored by miyuki). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74732/new/

[clang] dd23014 - Support -fuse-ld=lld for riscv

2020-02-18 Thread via cfe-commits
Author: serge-sans-paille Date: 2020-02-18T11:24:09+01:00 New Revision: dd230142d8a00f5f30c3930a2407000e845dcfbf URL: https://github.com/llvm/llvm-project/commit/dd230142d8a00f5f30c3930a2407000e845dcfbf DIFF:

[PATCH] D74732: [ARM,CDE] Cosmetic changes, additonal driver tests

2020-02-18 Thread Sjoerd Meijer via Phabricator via cfe-commits
SjoerdMeijer accepted this revision. SjoerdMeijer added a comment. This revision is now accepted and ready to land. Cheers, LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74732/new/ https://reviews.llvm.org/D74732

[PATCH] D74331: [ARM,MVE] Add intrinsics for abs, neg and not operations.

2020-02-18 Thread Simon Tatham via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG90dc78bc6278: [ARM,MVE] Add intrinsics for abs, neg and not operations. (authored by simon_tatham). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74331/new/

[clang] 5e97940 - [ARM, MVE] Add the vmovlbq, vmovltq intrinsic family.

2020-02-18 Thread Simon Tatham via cfe-commits
Author: Simon Tatham Date: 2020-02-18T09:34:50Z New Revision: 5e97940cd27961a0b872ff551fc98135507288b3 URL: https://github.com/llvm/llvm-project/commit/5e97940cd27961a0b872ff551fc98135507288b3 DIFF: https://github.com/llvm/llvm-project/commit/5e97940cd27961a0b872ff551fc98135507288b3.diff LOG:

[clang] c32af44 - [ARM, MVE] Add the vmovnbq, vmovntq intrinsic family.

2020-02-18 Thread Simon Tatham via cfe-commits
Author: Simon Tatham Date: 2020-02-18T09:34:50Z New Revision: c32af4447f79f5e7f246917fe1c3f58b2f6fc2a6 URL: https://github.com/llvm/llvm-project/commit/c32af4447f79f5e7f246917fe1c3f58b2f6fc2a6 DIFF: https://github.com/llvm/llvm-project/commit/c32af4447f79f5e7f246917fe1c3f58b2f6fc2a6.diff LOG:

[clang] 68b49f7 - [ARM,MVE] Add intrinsics vclzq and vclsq.

2020-02-18 Thread Simon Tatham via cfe-commits
Author: Simon Tatham Date: 2020-02-18T09:34:50Z New Revision: 68b49f7ef49eec068b7ddcf86c868e2a193e64e1 URL: https://github.com/llvm/llvm-project/commit/68b49f7ef49eec068b7ddcf86c868e2a193e64e1 DIFF: https://github.com/llvm/llvm-project/commit/68b49f7ef49eec068b7ddcf86c868e2a193e64e1.diff LOG:

[PATCH] D72857: [SYCL] Driver option to enable SYCL mode and select SYCL version

2020-02-18 Thread Alexey Bader via Phabricator via cfe-commits
bader marked 3 inline comments as done. bader added inline comments. Comment at: clang/include/clang/Basic/LangOptions.def:206 LANGOPT(OpenCLCPlusPlusVersion , 32, 0, "C++ for OpenCL version") +ENUM_LANGOPT(SYCLVersion, SYCLVersionList, 4, SYCLVersionList::undefined,

[PATCH] D72523: [remark][diagnostics] Using clang diagnostic handler for IR input files

2020-02-18 Thread Jeroen Dobbelaere via Phabricator via cfe-commits
jeroen.dobbelaere added a comment. This change triggers a crash in a release build of llvm: See https://bugs.llvm.org/show_bug.cgi?id=44896 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72523/new/ https://reviews.llvm.org/D72523

[PATCH] D73903: [AArch64][SVE] Add remaining SVE2 intrinsics for widening DSP operations

2020-02-18 Thread Sander de Smalen via Phabricator via cfe-commits
sdesmalen accepted this revision. sdesmalen added a comment. This revision is now accepted and ready to land. LGTM! Comment at: llvm/include/llvm/IR/IntrinsicsAArch64.td:1100 [IntrNoMem]>; + class SVE2_2VectorArg_Narrowing_Intrinsic nit:

[PATCH] D73903: [AArch64][SVE] Add remaining SVE2 intrinsics for widening DSP operations

2020-02-18 Thread Kerry McLaughlin via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGd4576080da72: [AArch64][SVE] Add remaining SVE2 intrinsics for widening DSP operations (authored by kmclaughlin). Changed prior to commit: https://reviews.llvm.org/D73903?vs=244367=245114#toc

[PATCH] D74564: libclang: Add static build support for Windows

2020-02-18 Thread Cristian Adam via Phabricator via cfe-commits
cristian.adam added a comment. I do not have commit rights, I need help to submit this patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74564/new/ https://reviews.llvm.org/D74564 ___ cfe-commits

[PATCH] D74689: [clang-tidy] Better custom class support for performance-inefficient-vector-operation

2020-02-18 Thread Nathan James via Phabricator via cfe-commits
njames93 updated this revision to Diff 245115. njames93 added a comment. - Added support for converting loops over c style arrays Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74689/new/ https://reviews.llvm.org/D74689 Files:

[PATCH] D74564: libclang: Add static build support for Windows

2020-02-18 Thread Ivan Donchevskii via Phabricator via cfe-commits
yvvan accepted this revision. yvvan added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/include/clang-c/Platform.h:31 +#elif defined(CINDEX_EXPORTS) + #define CINDEX_LINKAGE __attribute__((visibility("default"))) +#endif

[PATCH] D74334: [ARM,MVE] Add the vrev16q, vrev32q, vrev64q family.

2020-02-18 Thread Simon Tatham via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGb6236e94799e: [ARM,MVE] Add the vrev16q, vrev32q, vrev64q family. (authored by simon_tatham). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74334/new/

[PATCH] D74332: [ARM,MVE] Add intrinsics for int <-> float conversion.

2020-02-18 Thread Simon Tatham via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGdf3ed6c0fe31: [ARM,MVE] Add intrinsics for int - float conversion. (authored by simon_tatham). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74332/new/

[PATCH] D74335: [ARM,MVE] Add intrinsics vclzq and vclsq.

2020-02-18 Thread Simon Tatham via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG68b49f7ef49e: [ARM,MVE] Add intrinsics vclzq and vclsq. (authored by simon_tatham). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74335/new/

[PATCH] D74333: [ARM,MVE] Add intrinsics for FP rounding operations.

2020-02-18 Thread Simon Tatham via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGc8b3196e5430: [ARM,MVE] Add intrinsics for FP rounding operations. (authored by simon_tatham). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74333/new/

[PATCH] D72857: [SYCL] Driver option to enable SYCL mode and select SYCL version

2020-02-18 Thread Victor Lomuller via Phabricator via cfe-commits
Naghasan added inline comments. Comment at: clang/include/clang/Basic/LangOptions.def:206 LANGOPT(OpenCLCPlusPlusVersion , 32, 0, "C++ for OpenCL version") +ENUM_LANGOPT(SYCLVersion, SYCLVersionList, 4, SYCLVersionList::undefined, "Version of the SYCL standard used")

[PATCH] D69782: Summary: Instead of dropping all the ranges associated with a Diagnostic when converting them to a ClangTidy error, instead attach them to the ClangTidyError, so they can be consumed b

2020-02-18 Thread Alexander Kornienko via Phabricator via cfe-commits
alexfh added a comment. Thanks for the update! Please upload patches with full context. That makes navigating the code much easier during reviews. See https://llvm.org/docs/Phabricator.html A few more comments inline. Comment at:

[clang] 8b65f79 - [OpenCL] Add Arm dot product builtin functions

2020-02-18 Thread Sven van Haastregt via cfe-commits
Author: Sven van Haastregt Date: 2020-02-18T10:02:06Z New Revision: 8b65f792a0a96a091c24fdacf4ce04686e0eefb2 URL: https://github.com/llvm/llvm-project/commit/8b65f792a0a96a091c24fdacf4ce04686e0eefb2 DIFF: https://github.com/llvm/llvm-project/commit/8b65f792a0a96a091c24fdacf4ce04686e0eefb2.diff

[clang] 58f66f8 - [ARM,CDE] Cosmetic changes, additonal driver tests

2020-02-18 Thread Mikhail Maltsev via cfe-commits
Author: Mikhail Maltsev Date: 2020-02-18T10:23:09Z New Revision: 58f66f8af01db7f7f349654793a2b88376644122 URL: https://github.com/llvm/llvm-project/commit/58f66f8af01db7f7f349654793a2b88376644122 DIFF: https://github.com/llvm/llvm-project/commit/58f66f8af01db7f7f349654793a2b88376644122.diff

[PATCH] D74689: [clang-tidy] Better custom class support for performance-inefficient-vector-operation

2020-02-18 Thread Nathan James via Phabricator via cfe-commits
njames93 updated this revision to Diff 245116. njames93 added a comment. - Small nit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74689/new/ https://reviews.llvm.org/D74689 Files:

[PATCH] D73846: make sure to not warn about unused macros from -D

2020-02-18 Thread Luboš Luňák via Phabricator via cfe-commits
llunak added a comment. Ping.. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73846/new/ https://reviews.llvm.org/D73846 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D69585: PerformPendingInstatiations() already in the PCH

2020-02-18 Thread Luboš Luňák via Phabricator via cfe-commits
llunak added a comment. Ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69585/new/ https://reviews.llvm.org/D69585 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D74698: [CodeGen] -pg shouldn't add "frame-pointer"="all" fn attr w/ -mfentry

2020-02-18 Thread Nick Desaulniers via Phabricator via cfe-commits
nickdesaulniers added a comment. In D74698#1881034 , @MaskRay wrote: > When -mfentry is specified, why should frame pointers be disabled? It doesn't disable them; `-pg` was force enabling them for all functions, when in GCC does not enable them for the

[PATCH] D70172: [CUDA][HIP][OpenMP] Emit deferred diagnostics by a post-parsing AST travese

2020-02-18 Thread Eric Christopher via Phabricator via cfe-commits
echristo added a comment. In D70172#1879481 , @jpienaar wrote: > This seems to result in triggering clang/lib/CodeGen/CGExpr.cpp:2626 when > compiling mlir/lib/Transforms/AffineDataCopyGeneration.cpp with clang build > with assertions on (clean build at

[clang] 36f480f - Revert "[CUDA][HIP][OpenMP] Add lib/Sema/UsedDeclVisitor.h after D70172"

2020-02-18 Thread Yaxun Liu via cfe-commits
Author: Yaxun (Sam) Liu Date: 2020-02-18T14:45:34-05:00 New Revision: 36f480f22c25d5bb253db77f46cf089d16318e6b URL: https://github.com/llvm/llvm-project/commit/36f480f22c25d5bb253db77f46cf089d16318e6b DIFF:

[clang] 58817a0 - [clang][XCOFF] Indicate that XCOFF does not support COMDATs

2020-02-18 Thread David Tenty via cfe-commits
Author: David Tenty Date: 2020-02-18T16:10:11-05:00 New Revision: 58817a0783ca405cd36a312c7ee80e061d1cecc5 URL: https://github.com/llvm/llvm-project/commit/58817a0783ca405cd36a312c7ee80e061d1cecc5 DIFF: https://github.com/llvm/llvm-project/commit/58817a0783ca405cd36a312c7ee80e061d1cecc5.diff

[PATCH] D74698: [CodeGen] -pg shouldn't unconditionally add "frame-pointer"="all" fn attr w/ -mfentry

2020-02-18 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay added inline comments. Comment at: clang/test/CodeGen/fentry.c:6 +// RUN: %clang -pg -mfentry -O0 -emit-llvm -S -o - %s | FileCheck -check-prefix=FP --implicit-check-not='"frame-pointer"="none"' %s +// RUN: %clang -pg -mfentry -O2 -fno-omit-frame-pointer -emit-llvm -S

[PATCH] D74698: [CodeGen] -pg shouldn't unconditionally add "frame-pointer"="all" fn attr w/ -mfentry

2020-02-18 Thread Nick Desaulniers via Phabricator via cfe-commits
nickdesaulniers updated this revision to Diff 245245. nickdesaulniers added a comment. - add test for explicitly re-enabling -fno-omit-frame-pointer at -O2 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74698/new/ https://reviews.llvm.org/D74698

[PATCH] D72857: [SYCL] Driver option to enable SYCL mode and select SYCL version

2020-02-18 Thread Ronan Keryell via Phabricator via cfe-commits
keryell added inline comments. Comment at: clang/include/clang/Driver/Options.td:3419 +def sycl_std_EQ : Joined<["-"], "sycl-std=">, Group, Flags<[CC1Option, NoArgumentUnused, CoreOption]>, + HelpText<"SYCL language standard to compile for.">, Values<"2015, 121, 1.2.1,

[PATCH] D74704: Support -fuse-ld=lld for riscv

2020-02-18 Thread serge via Phabricator via cfe-commits
serge-sans-paille added a comment. Reverted through b8bea9346af4f2644c9a1bd29710c5e3efbbd7d3 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74704/new/

[PATCH] D73138: [libcxx] [test] Correct asserted type in subspan test; subspan with count should never produce dynamic_extent

2020-02-18 Thread Billy Robert O'Neal III via Phabricator via cfe-commits
BillyONeal added a comment. @ldionne I think you're correct, though the test there is more complex than it needs to be (because the ==Count cases are the only ever encountered here). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73138/new/ https://reviews.llvm.org/D73138

[PATCH] D74704: Support -fuse-ld=lld for riscv

2020-02-18 Thread serge via Phabricator via cfe-commits
serge-sans-paille added a comment. I'll revert and propose an updated patch then. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74704/new/ https://reviews.llvm.org/D74704 ___ cfe-commits mailing list

[PATCH] D74704: Support -fuse-ld=lld for riscv

2020-02-18 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay added a comment. The problem may be `-DCLANG_DEFAULT_LINKER=lld`. (FWIW I really don't like supporting numerous -D configurations and ask authors to revert because of some weird -D configurations.) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D74784: [driver][darwin] Don't use -platform_version flag by default

2020-02-18 Thread dmajor via Phabricator via cfe-commits
dmajor created this revision. dmajor added reviewers: arphaman, steven_wu, dexonsmith. dmajor added projects: clang, LLVM. Herald added a subscriber: cfe-commits. (Note, I don't currently have commit access.) The code in llvmorg-10-init-12188-g25ce33a6e4f is a breaking change for users of older

[PATCH] D74033: [clang-tidy] Fix PR#44620 'readability-redundant-string-cstr quick-fix causes invalid code'

2020-02-18 Thread Karasev Nikita via Phabricator via cfe-commits
f00kat added a comment. Yes, commit please. Thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74033/new/ https://reviews.llvm.org/D74033 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D73138: [libcxx] [test] Correct asserted type in subspan test; subspan with count should never produce dynamic_extent

2020-02-18 Thread Louis Dionne via Phabricator via cfe-commits
ldionne accepted this revision. ldionne added a comment. This revision is now accepted and ready to land. In D73138#1881198 , @BillyONeal wrote: > @ldionne I think you're correct, though the test there is more complex than > it needs to be (because the

[PATCH] D74698: [CodeGen] -pg shouldn't add "frame-pointer"="all" fn attr w/ -mfentry

2020-02-18 Thread Nick Desaulniers via Phabricator via cfe-commits
nickdesaulniers updated this revision to Diff 245241. nickdesaulniers added a comment. - prefer implicit-check-not, add test for -O2 vs -O0 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74698/new/ https://reviews.llvm.org/D74698 Files:

[PATCH] D74634: Remove "ELF Only" restriction from section flags

2020-02-18 Thread Reid Kleckner via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGa0a1f412fd1d: Remove ELF Only from -f*-sections help text (authored by rnk). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74634/new/

[PATCH] D74787: [IRBuilder] Always respect inserter/folder

2020-02-18 Thread Nikita Popov via Phabricator via cfe-commits
nikic marked an inline comment as done. nikic added inline comments. Comment at: llvm/test/Transforms/InstCombine/saturating-add-sub.ll:2 ; NOTE: Assertions have been autogenerated by utils/update_test_checks.py -; RUN: opt < %s -instcombine -S | FileCheck %s +; RUN: opt < %s

[PATCH] D74698: [CodeGen] -pg shouldn't unconditionally add "frame-pointer"="all" fn attr w/ -mfentry

2020-02-18 Thread Nick Desaulniers via Phabricator via cfe-commits
nickdesaulniers updated this revision to Diff 245249. nickdesaulniers added a comment. - move test from clang/test/CodeGen/fentry to clang/test/Driver/mfentry Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74698/new/ https://reviews.llvm.org/D74698

[PATCH] D74790: [Sema][CodeComplete] Handle symlinks for include code completion

2020-02-18 Thread David Goldman via Phabricator via cfe-commits
dgoldman created this revision. dgoldman added a reviewer: sammccall. Herald added a project: clang. Herald added a subscriber: cfe-commits. Previously any symlinks would be ignored since the directory traversal doesn't follow them. With this change we now follow symlinks (via a `stat` call in

[PATCH] D74698: [CodeGen] -pg shouldn't unconditionally add "frame-pointer"="all" fn attr w/ -mfentry

2020-02-18 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay added inline comments. Comment at: clang/test/Driver/mfentry.c:5 +// RUN: %clang -pg -mfentry -O0 -emit-llvm -S -o - %s | FileCheck -check-prefix=FP --implicit-check-not='"frame-pointer"="none"' %s +// RUN: %clang -pg -mfentry -O2 -fno-omit-frame-pointer -emit-llvm -S

[PATCH] D73916: [clang] Add `forceReload` clangd extension to 'textDocument/didChange'

2020-02-18 Thread Nathan Ridge via Phabricator via cfe-commits
nridge added a comment. Which client(s) use or plan to use this extension? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73916/new/ https://reviews.llvm.org/D73916 ___ cfe-commits mailing list

[PATCH] D73138: [libcxx] [test] Correct asserted type in subspan test; subspan with count should never produce dynamic_extent

2020-02-18 Thread Billy Robert O'Neal III via Phabricator via cfe-commits
BillyONeal added a comment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73138/new/ https://reviews.llvm.org/D73138 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D74033: [clang-tidy] Fix PR#44620 'readability-redundant-string-cstr quick-fix causes invalid code'

2020-02-18 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman closed this revision. aaron.ballman added a comment. I've commit on your behalf in 47282b1b4bf3e18d2e2166b87159115ed520a2aa , thank you for the patch! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D74689: [clang-tidy] Better custom class support for performance-inefficient-vector-operation

2020-02-18 Thread Nathan James via Phabricator via cfe-commits
njames93 updated this revision to Diff 245240. njames93 added a comment. - Better template support - Removed excess code - Refactor alot of the check Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74689/new/ https://reviews.llvm.org/D74689 Files:

[clang] a0a1f41 - Remove "ELF Only" from -f*-sections help text

2020-02-18 Thread Reid Kleckner via cfe-commits
Author: Reid Kleckner Date: 2020-02-18T12:59:50-08:00 New Revision: a0a1f412fd1d86146c5b4ef5b7b66fcc57a8b56b URL: https://github.com/llvm/llvm-project/commit/a0a1f412fd1d86146c5b4ef5b7b66fcc57a8b56b DIFF: https://github.com/llvm/llvm-project/commit/a0a1f412fd1d86146c5b4ef5b7b66fcc57a8b56b.diff

[PATCH] D72231: [Sema] Adds the pointer-to-int-cast diagnostic

2020-02-18 Thread Mark de Wever via Phabricator via cfe-commits
Mordante added a comment. In D72231#1879347 , @rjmccall wrote: > In D72231#1878528 , @nathanchance > wrote: > > > There appear to a be semantic difference between GCC and clang with the > > current version of

[PATCH] D69782: Summary: Instead of dropping all the ranges associated with a Diagnostic when converting them to a ClangTidy error, instead attach them to the ClangTidyError, so they can be consumed b

2020-02-18 Thread Joe Turner via Phabricator via cfe-commits
compositeprimes added a comment. Sorry about the lack of context on the last upload, this one should have it all Comment at: include/clang/Tooling/Core/Diagnostic.h:62-70 +/// Represents extra source ranges to be associated with a diagnostic. +struct DiagnosticAssociatedRanges

[PATCH] D69782: Summary: Instead of dropping all the ranges associated with a Diagnostic when converting them to a ClangTidy error, instead attach them to the ClangTidyError, so they can be consumed b

2020-02-18 Thread Joe Turner via Phabricator via cfe-commits
compositeprimes updated this revision to Diff 245207. compositeprimes marked 2 inline comments as done. compositeprimes added a comment. Removed unnecessary DiagnosticAssociatedRanges struct CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69782/new/ https://reviews.llvm.org/D69782

[clang] bcadb1f - Revert "[CUDA][HIP][OpenMP] Emit deferred diagnostics by a post-parsing AST travese"

2020-02-18 Thread Yaxun Liu via cfe-commits
Author: Yaxun (Sam) Liu Date: 2020-02-18T14:45:34-05:00 New Revision: bcadb1f2e6afe51d5646c6e98faa14aa1a1c669c URL: https://github.com/llvm/llvm-project/commit/bcadb1f2e6afe51d5646c6e98faa14aa1a1c669c DIFF:

RE: [PATCH] D70172: [CUDA][HIP][OpenMP] Emit deferred diagnostics by a post-parsing AST travese

2020-02-18 Thread Liu, Yaxun (Sam) via cfe-commits
[AMD Official Use Only - Internal Distribution Only] Reverted. I will make sure it does not regress mlir before commit again. Thanks. Sam -Original Message- From: Eric Christopher via Phabricator Sent: Tuesday, February 18, 2020 11:21 AM To: Liu, Yaxun (Sam) ; t...@google.com;

[libunwind] 1ae8d81 - [libunwind] Fix memory leak in handling of DW_CFA_remember_state and DW_CFA_restore_state

2020-02-18 Thread Jorge Gorbe Moya via cfe-commits
Author: Jorge Gorbe Moya Date: 2020-02-18T11:57:18-08:00 New Revision: 1ae8d81147a0724cc972054afbd72943032e4832 URL: https://github.com/llvm/llvm-project/commit/1ae8d81147a0724cc972054afbd72943032e4832 DIFF:

[clang] b8bea93 - Revert "Support -fuse-ld=lld for riscv"

2020-02-18 Thread via cfe-commits
Author: serge-sans-paille Date: 2020-02-18T20:56:02+01:00 New Revision: b8bea9346af4f2644c9a1bd29710c5e3efbbd7d3 URL: https://github.com/llvm/llvm-project/commit/b8bea9346af4f2644c9a1bd29710c5e3efbbd7d3 DIFF:

[PATCH] D74787: [IRBuilder] Always respect inserter/folder

2020-02-18 Thread Nikita Popov via Phabricator via cfe-commits
nikic created this revision. nikic added reviewers: nhaehnle, Meinersbur, spatel, lebedev.ri. Herald added subscribers: llvm-commits, cfe-commits, hiraditya. Herald added a reviewer: jdoerfert. Herald added projects: clang, LLVM. Some IRBuilder methods that were originally defined on

[PATCH] D73138: [libcxx] [test] Correct asserted type in subspan test; subspan with count should never produce dynamic_extent

2020-02-18 Thread Louis Dionne via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGa7dcbe90cc2d: [libc++] Fix overly complicated test of std::spans extent (authored by ldionne). Herald added a project: libc++. Herald added a subscriber: libcxx-commits. Changed prior to commit:

[PATCH] D74529: [clang-tidy] Added a case to UnconventionalAssignOperatorCheck.

2020-02-18 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74529/new/ https://reviews.llvm.org/D74529

[PATCH] D74698: [CodeGen] -pg shouldn't unconditionally add "frame-pointer"="all" fn attr w/ -mfentry

2020-02-18 Thread Nick Desaulniers via Phabricator via cfe-commits
nickdesaulniers marked an inline comment as done. nickdesaulniers added inline comments. Comment at: clang/test/Driver/mfentry.c:5 +// RUN: %clang -pg -mfentry -O0 -emit-llvm -S -o - %s | FileCheck -check-prefix=FP --implicit-check-not='"frame-pointer"="none"' %s +// RUN:

RE: [PATCH] D70172: [CUDA][HIP][OpenMP] Emit deferred diagnostics by a post-parsing AST travese

2020-02-18 Thread Liu, Yaxun (Sam) via cfe-commits
[AMD Official Use Only - Internal Distribution Only] Probably I missed something. I will look again. Thanks. Sam -Original Message- From: Jacques Pienaar Sent: Tuesday, February 18, 2020 8:56 AM To: Liu, Yaxun (Sam) Cc: reviews+d70172+public+e13d5528b180f...@reviews.llvm.org;

[PATCH] D71433: [analyzer] CERT: POS34-C

2020-02-18 Thread Zurab Tsinadze via Phabricator via cfe-commits
zukatsinadze added a comment. In D71433#1880436 , @Szelethus wrote: > I think for an alpha checker this is ready to land if you're ready -- do you > have commit access or need assistance? Thank you. @Charusso will help. CHANGES SINCE LAST ACTION

[PATCH] D72857: [SYCL] Driver option to enable SYCL mode and select SYCL version

2020-02-18 Thread Alexey Bader via Phabricator via cfe-commits
bader updated this revision to Diff 245213. bader added a comment. Address comments from Victor and Alexey. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72857/new/ https://reviews.llvm.org/D72857 Files:

[PATCH] D74704: Support -fuse-ld=lld for riscv

2020-02-18 Thread Leonard Chan via Phabricator via cfe-commits
leonardchan added a comment. In D74704#1881012 , @vvereschaka wrote: > Hello @serge-sans-paille, > > looks like these changes broke the ARM builders: > http://lab.llvm.org:8011/builders/llvm-clang-win-x-armv7l/builds/4749 >

[PATCH] D74033: [clang-tidy] Fix PR#44620 'readability-redundant-string-cstr quick-fix causes invalid code'

2020-02-18 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Do you need me to commit on your behalf, or have you obtained git privileges recently? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D74776: [Hexagon] clang driver should consider --sysroot option when looking for includes

2020-02-18 Thread Sid Manning via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGfaa889b23587: [Hexagon] clang driver should consider --sysroot option (authored by sidneym). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74776/new/

[PATCH] D74631: [clang][XCOFF] Indicate that XCOFF does not support COMDATs

2020-02-18 Thread Sean Fertile via Phabricator via cfe-commits
sfertile accepted this revision. sfertile added a comment. This revision is now accepted and ready to land. LGTM. Comment at: llvm/docs/LangRef.rst:913 -Note that the Mach-O platform doesn't support COMDATs, and ELF and WebAssembly -only support ``any`` as a selection kind.

[clang] faa889b - [Hexagon] clang driver should consider --sysroot option

2020-02-18 Thread Sid Manning via cfe-commits
Author: Sid Manning Date: 2020-02-18T14:25:55-06:00 New Revision: faa889b2358704c57febf2ad75ad88eec5debf31 URL: https://github.com/llvm/llvm-project/commit/faa889b2358704c57febf2ad75ad88eec5debf31 DIFF: https://github.com/llvm/llvm-project/commit/faa889b2358704c57febf2ad75ad88eec5debf31.diff

[clang-tools-extra] 47282b1 - Fix PR#44620 'readability-redundant-string-cstr quick-fix causes invalid code'

2020-02-18 Thread Aaron Ballman via cfe-commits
Author: Karasev Nikita Date: 2020-02-18T15:33:52-05:00 New Revision: 47282b1b4bf3e18d2e2166b87159115ed520a2aa URL: https://github.com/llvm/llvm-project/commit/47282b1b4bf3e18d2e2166b87159115ed520a2aa DIFF:

[PATCH] D74631: [clang][XCOFF] Indicate that XCOFF does not support COMDATs

2020-02-18 Thread David Tenty via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG58817a0783ca: [clang][XCOFF] Indicate that XCOFF does not support COMDATs (authored by daltenty). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74631/new/

[PATCH] D74698: [CodeGen] -pg shouldn't add "frame-pointer"="all" fn attr w/ -mfentry

2020-02-18 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay added a comment. When -mfentry is specified, why should frame pointers be disabled? Is that because the Linux kernel has assumption about the exact code sequence? `call __fentry__` is the first instruction. Isn't that sufficient? (There is another difference. GCC emits `call

[PATCH] D74562: [OpenMP][OMPIRBuilder] Introducing the `OMPBuilderCBHelpers` helper class

2020-02-18 Thread Fady Ghanim via Phabricator via cfe-commits
fghanim updated this revision to Diff 245227. fghanim added a comment. Marking a call void Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74562/new/ https://reviews.llvm.org/D74562 Files: clang/lib/CodeGen/CGStmtOpenMP.cpp

[PATCH] D74698: [CodeGen] -pg shouldn't add "frame-pointer"="all" fn attr w/ -mfentry

2020-02-18 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. In D74698#188 , @nickdesaulniers wrote: > In D74698#1881034 , @MaskRay wrote: > > > When -mfentry is

[PATCH] D74784: [driver][darwin] Don't use -platform_version flag by default

2020-02-18 Thread Duncan P. N. Exon Smith via Phabricator via cfe-commits
dexonsmith added a comment. Code change looks correct to me. Thanks for the fix! @arphaman, can you confirm the test changes are reasonable? My instinct would have been, instead of changing all of the 400s to 0s, to just adding a single `RUN` line somewhere to confirm we don't do the wrong

[PATCH] D74787: [IRBuilder] Always respect inserter/folder

2020-02-18 Thread Michael Kruse via Phabricator via cfe-commits
Meinersbur added a comment. Nice work Comment at: llvm/test/Transforms/InstCombine/saturating-add-sub.ll:2 ; NOTE: Assertions have been autogenerated by utils/update_test_checks.py -; RUN: opt < %s -instcombine -S | FileCheck %s +; RUN: opt < %s -instcombine

[PATCH] D73534: [DebugInfo] Enable the debug entry values feature by default

2020-02-18 Thread Djordje Todorovic via Phabricator via cfe-commits
djtodoro updated this revision to Diff 245123. djtodoro added a comment. -Addressing the latest comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73534/new/ https://reviews.llvm.org/D73534 Files: clang/include/clang/Basic/CodeGenOptions.def

[PATCH] D74760: [Analyzer] Fix for iterator modeling and checkers: handle negative numbers correctly

2020-02-18 Thread Balogh, Ádám via Phabricator via cfe-commits
baloghadamsoftware created this revision. baloghadamsoftware added reviewers: NoQ, Szelethus. baloghadamsoftware added a project: clang. Herald added subscribers: steakhal, Charusso, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, whisperity. Currently, using negative numbers in

[PATCH] D74724: [AArch64][SVE] CodeGen of ACLE Builtin Types

2020-02-18 Thread Sander de Smalen via Phabricator via cfe-commits
sdesmalen updated this revision to Diff 245127. sdesmalen added a comment. - Inlined function into switch statement - Removed changes to IRTranslator.cpp from this patch. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74724/new/ https://reviews.llvm.org/D74724 Files:

[PATCH] D74735: [analyzer] Add support for CXXInheritedCtorInitExpr.

2020-02-18 Thread Gábor Horváth via Phabricator via cfe-commits
xazax.hun added a comment. If the AST is hard to work with would it make sense to try to change the AST a bit? Comment at: clang/lib/StaticAnalyzer/Core/CallEvent.cpp:944 + if (Data) { +loc::MemRegionVal MV(static_cast(Data)); +if (SymbolRef Sym =

[clang] cc7a197 - Fix riscv/lld test interaction

2020-02-18 Thread via cfe-commits
Author: serge-sans-paille Date: 2020-02-18T12:34:07+01:00 New Revision: cc7a197f9f1039e36625249199aa652f84506802 URL: https://github.com/llvm/llvm-project/commit/cc7a197f9f1039e36625249199aa652f84506802 DIFF:

[clang] a82d3e8 - Reland "[DebugInfo] Enable the debug entry values feature by default"

2020-02-18 Thread Djordje Todorovic via cfe-commits
Author: Djordje Todorovic Date: 2020-02-18T14:41:08+01:00 New Revision: a82d3e8a6e67473c94a5ce6345372748e9b61718 URL: https://github.com/llvm/llvm-project/commit/a82d3e8a6e67473c94a5ce6345372748e9b61718 DIFF:

[PATCH] D71433: [analyzer] CERT: POS34-C

2020-02-18 Thread Kristóf Umann via Phabricator via cfe-commits
Szelethus added a comment. Herald added a subscriber: martong. I think for an alpha checker this is ready to land if you're ready -- do you have commit access or need assistance? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71433/new/ https://reviews.llvm.org/D71433

[PATCH] D74698: [CodeGen] -pg shouldn't unconditionally add "frame-pointer"="all" fn attr w/ -mfentry

2020-02-18 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay added a comment. The title should be changed from CodeGen to Driver And `fn attr` is no longer appropriate. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74698/new/ https://reviews.llvm.org/D74698

[PATCH] D74698: [Driver] -pg -mfentry should respect target specific decisions for -mframe-pointer=all

2020-02-18 Thread Nick Desaulniers via Phabricator via cfe-commits
nickdesaulniers marked an inline comment as done. nickdesaulniers added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:592 + if (Args.hasArg(options::OPT_pg) && Args.hasArg(options::OPT_mfentry)) +return false; This hunk does nothing

[PATCH] D74698: [Driver] -pg -mfentry should respect target specific decisions for -mframe-pointer=all

2020-02-18 Thread Nick Desaulniers via Phabricator via cfe-commits
nickdesaulniers updated this revision to Diff 245279. nickdesaulniers added a comment. - respect target specific frame pointer optimizations Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74698/new/ https://reviews.llvm.org/D74698 Files:

[PATCH] D74698: [Driver] -pg -mfentry should respect target specific decisions for -mframe-pointer=all

2020-02-18 Thread Nick Desaulniers via Phabricator via cfe-commits
nickdesaulniers added a comment. Ok, sorry for the excessive churn. I think this now accurately describes the logic of how this was expected to work, from the stance of GCC compatibility. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74698/new/

[PATCH] D74795: Make diagnostic reporting more robust in presence of corrupt PCH data.

2020-02-18 Thread Duncan P. N. Exon Smith via Phabricator via cfe-commits
dexonsmith added a comment. Thanks for working on this! I have a couple of comments inline. Comment at: clang/include/clang/Basic/Diagnostic.h:918-927 /// The ID of the current diagnostic that is in flight. /// /// This is set to std::numeric_limits::max() when there

  1   2   3   >