[PATCH] D73898: [analyzer] StdLibraryFunctionsChecker: Add argument constraints

2020-02-24 Thread Gabor Marton via Phabricator via cfe-commits
martong updated this revision to Diff 246229. martong added a comment. Rebase on top of https://reviews.llvm.org/D74973 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73898/new/ https://reviews.llvm.org/D73898 Files:

[PATCH] D69662: [Checkers] Avoid using evalCall in StreamChecker.

2020-02-24 Thread Kristóf Umann via Phabricator via cfe-commits
Szelethus added a comment. Herald added a subscriber: martong. In D69662#1744479 , @NoQ wrote: > In D69662#1736601 , @balazske wrote: > > > Anyway the checks that do not use BindExpr (all except the open functions)

[PATCH] D74878: [remark][diagnostics] [codegen] Fix PR44896

2020-02-24 Thread serge via Phabricator via cfe-commits
serge-sans-paille added a comment. In D74878#1889460 , @jeroen.dobbelaere wrote: > Will this also give a warning when passing a .ll file to a release clang, > without explicitly passing the '-fdiscard-value-names' ? Is this what we > want it to be ?

[PATCH] D74268: [X86] Add back fmaddsub intrinsics to work towards fixing the strict fp implementation

2020-02-24 Thread Craig Topper via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG727328433ad6: [X86] Add back fmaddsub intrinsics to work towards fixing the strict fp… (authored by craig.topper). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG

[PATCH] D75057: Syndicate, test and fix base64 implementation

2020-02-24 Thread serge via Phabricator via cfe-commits
serge-sans-paille updated this revision to Diff 246243. serge-sans-paille added a comment. Fix typo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75057/new/ https://reviews.llvm.org/D75057 Files:

[PATCH] D69560: [clang-tidy] Add 'cppcoreguidelines-avoid-adjacent-arguments-of-same-type' check

2020-02-24 Thread Kim Viggedal via Phabricator via cfe-commits
vingeldal added a comment. In D69560#1889719 , @aaron.ballman wrote: > In D69560#1889483 , @whisperity > wrote: > > > I'd rather not call them //false positive// because the definition of > > `false positive` is

[PATCH] D75063: [analyzer] StdLibraryFunctionsChecker: Add NotNull Arg Constraint

2020-02-24 Thread Gabor Marton via Phabricator via cfe-commits
martong created this revision. martong added reviewers: NoQ, Szelethus, balazske, gamesh411, baloghadamsoftware, steakhal. Herald added subscribers: cfe-commits, Charusso, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, xazax.hun, whisperity. Herald added a project: clang.

[PATCH] D74973: [analyzer] StdLibraryFunctionsChecker refactor w/ inheritance

2020-02-24 Thread Gabor Marton via Phabricator via cfe-commits
martong marked an inline comment as done. martong added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp:93 +ValueConstraint(ArgNo ArgN) : ArgN(ArgN) {} +virtual ProgramStateRef apply(ProgramStateRef State, const CallEvent , +

[PATCH] D74973: [analyzer] StdLibraryFunctionsChecker refactor w/ inheritance

2020-02-24 Thread Gabor Marton via Phabricator via cfe-commits
martong added a comment. @balazske See https://reviews.llvm.org/D75063 about the simple independent implementation of the NotNull constraint. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74973/new/ https://reviews.llvm.org/D74973

[PATCH] D69560: [clang-tidy] Add 'cppcoreguidelines-avoid-adjacent-arguments-of-same-type' check

2020-02-24 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added a comment. In D69560#1889483 , @whisperity wrote: > I'd rather not call them //false positive// because the definition of `false > positive` is ugly and mushy with regards to this check. This check attempts > to enforce an interface

[PATCH] D75006: [clang-format] Wrap lines for C# property accessors

2020-02-24 Thread Jonathan B Coe via Phabricator via cfe-commits
jbcoe updated this revision to Diff 246235. jbcoe added a comment. This revision is now accepted and ready to land. Simplify logic for merging property accessors CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75006/new/ https://reviews.llvm.org/D75006 Files:

[PATCH] D75057: Syndicate, test and fix base64 implementation

2020-02-24 Thread serge via Phabricator via cfe-commits
serge-sans-paille updated this revision to Diff 246240. serge-sans-paille added a comment. Restore duplication, fix the bug in two separate locations. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75057/new/ https://reviews.llvm.org/D75057 Files:

[PATCH] D73898: [analyzer] StdLibraryFunctionsChecker: Add argument constraints

2020-02-24 Thread Gabor Marton via Phabricator via cfe-commits
martong marked an inline comment as done. martong added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp:152 +break; + default: +llvm_unreachable("Unknown RangeConstraint kind!"); This `default`

[PATCH] D74925: [OpenMP][Opt] Combine `struct ident_t*` during deduplication

2020-02-24 Thread Johannes Doerfert via Phabricator via cfe-commits
jdoerfert added a comment. In D74925#1889185 , @JonChesterfield wrote: > Cool. Can we reasonably add the reproducible from 44893 to a regression > suite, in addition to these IR tests? It's written in C so would need to be > under clang's tests.

[PATCH] D74925: [OpenMP][Opt] Combine `struct ident_t*` during deduplication

2020-02-24 Thread Johannes Doerfert via Phabricator via cfe-commits
jdoerfert updated this revision to Diff 246256. jdoerfert marked an inline comment as done. jdoerfert added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Add tests, addressed comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D74878: [remark][diagnostics] [codegen] Fix PR44896

2020-02-24 Thread Rong Xu via Phabricator via cfe-commits
xur updated this revision to Diff 246265. xur added a comment. Uploaded a wrong patch in the last time. This is the correct one. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74878/new/ https://reviews.llvm.org/D74878 Files: clang/include/clang/Basic/DiagnosticDriverKinds.td

[PATCH] D75068: libclang: Add static build support for Windows

2020-02-24 Thread Cristian Adam via Phabricator via cfe-commits
cristian.adam created this revision. cristian.adam added reviewers: yvvan, thakis, mstorsjo. Herald added subscribers: cfe-commits, mgorny. Herald added a project: clang. This patch is a squash for: https://reviews.llvm.org/D74564 https://reviews.llvm.org/D74907 And a fix for the issue that got

[PATCH] D74846: fix -fcodegen-modules code when used with PCH (PR44953)

2020-02-24 Thread David Blaikie via Phabricator via cfe-commits
dblaikie added a comment. In D74846#1888410 , @llunak wrote: > Upon further investigation it turns out I probably should not have enabled > those two places for PCH in D69778 at all, > since they do not deal with

[PATCH] D72841: [RFC] Add support for pragma float_control, to control precision and exception behavior at the source level

2020-02-24 Thread Melanie Blower via Phabricator via cfe-commits
mibintc updated this revision to Diff 246285. mibintc marked an inline comment as done. mibintc added a comment. This patch is code complete and ready for your review and consideration. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72841/new/

[PATCH] D69560: [clang-tidy] Add 'cppcoreguidelines-avoid-adjacent-arguments-of-same-type' check

2020-02-24 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added a comment. In D69560#1889925 , @vingeldal wrote: > Doesn't clang-tidy exclude warnings from system headers by default though? Third-party SDKs are not always brought in as system headers, unfortunately. Even ignoring system and

[PATCH] D75057: Syndicate, test and fix base64 implementation

2020-02-24 Thread serge via Phabricator via cfe-commits
serge-sans-paille updated this revision to Diff 246248. serge-sans-paille added a comment. Other copy/paste typo. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75057/new/ https://reviews.llvm.org/D75057 Files:

[PATCH] D69662: [Checkers] Avoid using evalCall in StreamChecker.

2020-02-24 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ added a comment. In D69662#1889545 , @Szelethus wrote: > Sorry for the slack :) > > One should never count on the invocation order of callback funcions in > between checkers. In fact, I'm not too sure that my patches affect this, but > I suspect

[PATCH] D66839: Fix stack address builtin for negative numbers

2020-02-24 Thread Eli Friedman via Phabricator via cfe-commits
efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66839/new/ https://reviews.llvm.org/D66839

[PATCH] D75048: [ASTImporter] Improved import of AlignedAttr.

2020-02-24 Thread Shafik Yaghmour via Phabricator via cfe-commits
shafik accepted this revision. shafik added a comment. This revision is now accepted and ready to land. LGTM aside from the comments I made. Comment at: clang/lib/AST/ASTImporter.cpp:7944 + if (auto ToEOrErr = Import(From->getAlignmentExpr())) +To =

[PATCH] D71524: [analyzer] Support tainted objects in GenericTaintChecker

2020-02-24 Thread Kristóf Umann via Phabricator via cfe-commits
Szelethus added a comment. In D71524#1889566 , @boga95 wrote: > @steakhal's revision is on the top of this. Changing the order will only > cause unnecessary work on both sides. He recently rebased on top of master. I'm no fan of creating unnecessary

[PATCH] D75046: [docs] dump_ast_matchers strips internal::(Bindable)?Matcher from Result_type

2020-02-24 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75046/new/ https://reviews.llvm.org/D75046

[PATCH] D74878: [remark][diagnostics] [codegen] Fix PR44896

2020-02-24 Thread Rong Xu via Phabricator via cfe-commits
xur updated this revision to Diff 246260. xur added a comment. check if the -fdiscard-value-names explicitly in args (suggested by Jeroen and Serge) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74878/new/ https://reviews.llvm.org/D74878 Files:

[PATCH] D75057: Syndicate, test and fix base64 implementation

2020-02-24 Thread serge via Phabricator via cfe-commits
serge-sans-paille updated this revision to Diff 246279. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75057/new/ https://reviews.llvm.org/D75057 Files: clang-tools-extra/clangd/SemanticHighlighting.cpp compiler-rt/lib/fuzzer/FuzzerUtil.cpp

[PATCH] D66839: Fix stack address builtin for negative numbers

2020-02-24 Thread Zoe Carver via Phabricator via cfe-commits
zoecarver updated this revision to Diff 246277. zoecarver added a comment. - move verification to SemaChecking Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66839/new/ https://reviews.llvm.org/D66839 Files: clang/lib/Sema/SemaChecking.cpp

[PATCH] D75061: [RISCV] Fix sysroot tests without GCC on RISC-V hosts with GCC

2020-02-24 Thread Luís Marques via Phabricator via cfe-commits
luismarques created this revision. luismarques added reviewers: edward-jones, lenary. Herald added subscribers: cfe-commits, evandro, apazos, sameer.abuasal, pzheng, s.egerton, Jim, benna, psnobl, jocewei, PkmX, rkruppe, the_o, brucehoult, MartinMosbeck, rogfer01, zzheng, jrtc27, shiva0217,

[PATCH] D71524: [analyzer] Support tainted objects in GenericTaintChecker

2020-02-24 Thread Borsik Gábor via Phabricator via cfe-commits
boga95 marked 6 inline comments as done. boga95 added a comment. @steakhal's revision is on the top of this. Changing the order will only cause unnecessary work on both sides. Comment at: clang/lib/StaticAnalyzer/Checkers/GenericTaintChecker.cpp:103-132 struct FunctionData

[clang] 7273284 - [X86] Add back fmaddsub intrinsics to work towards fixing the strict fp implementation

2020-02-24 Thread Craig Topper via cfe-commits
Author: Craig Topper Date: 2020-02-24T12:07:21-08:00 New Revision: 727328433ad61b8c7acdd4d63e73241303a6beb7 URL: https://github.com/llvm/llvm-project/commit/727328433ad61b8c7acdd4d63e73241303a6beb7 DIFF: https://github.com/llvm/llvm-project/commit/727328433ad61b8c7acdd4d63e73241303a6beb7.diff

[PATCH] D75057: Syndicate, test and fix base64 implementation

2020-02-24 Thread serge via Phabricator via cfe-commits
serge-sans-paille removed a reviewer: lebedev.ri. serge-sans-paille added a comment. As a side note, pre-reserving the buffer size gives interesting speedup, see http://quick-bench.com/Lp6OwO2etW1YEmJayVWn3U8JDiY Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D75022: clang-format: Extend AllowShortLoopsOnASingleLine to do ... while loops.

2020-02-24 Thread Daan De Meyer via Phabricator via cfe-commits
DaanDeMeyer updated this revision to Diff 246244. DaanDeMeyer added a comment. Added unit tests and fixed the case where stuff follows the do statement (like a comment). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75022/new/ https://reviews.llvm.org/D75022 Files:

[PATCH] D75077: [OpenMP5.0] Allow pointer arithmetic in motion/map clause

2020-02-24 Thread Chi Chun Chen via Phabricator via cfe-commits
cchen marked 4 inline comments as done. cchen added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:7616 dyn_cast(I->getAssociatedExpression()); + const auto *UO = dyn_cast(I->getAssociatedExpression()); bool IsPointer =

[PATCH] D71734: [Modules] Handle tag types and complain about bad merges in C/Objective-C mode

2020-02-24 Thread Bruno Cardoso Lopes via Phabricator via cfe-commits
bruno added a comment. Ping! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71734/new/ https://reviews.llvm.org/D71734 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D71314: Emit a warning if a variable is uninitialized in indirect ASM goto destination.

2020-02-24 Thread Bill Wendling via Phabricator via cfe-commits
void updated this revision to Diff 246363. void added a comment. Explain what's going on in VisitGCCAsmStmt better. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71314/new/ https://reviews.llvm.org/D71314 Files:

[PATCH] D71314: Emit a warning if a variable is uninitialized in indirect ASM goto destination.

2020-02-24 Thread Bill Wendling via Phabricator via cfe-commits
void marked an inline comment as done. void added inline comments. Comment at: clang/lib/Analysis/UninitializedValues.cpp:856 +vals[VD] = MayUninitialized; } nickdesaulniers wrote: > Can you walk me through the logic of this function? > > I would

[PATCH] D75077: [OpenMP5.0] Allow pointer arithmetic in motion/map clause

2020-02-24 Thread Alexey Bataev via Phabricator via cfe-commits
ABataev added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:7616 dyn_cast(I->getAssociatedExpression()); + const auto *UO = dyn_cast(I->getAssociatedExpression()); bool IsPointer = What about binary operator?

[PATCH] D66839: Fix stack address builtin for negative numbers

2020-02-24 Thread Zoe Carver via Phabricator via cfe-commits
zoecarver closed this revision. zoecarver added a comment. Resolved by c93112dc4f745b0455addb54bfe1c2f79b827c6d Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66839/new/

[PATCH] D74935: [LangRef][AliasAnalysis] Clarify `noalias` affects only modified objects

2020-02-24 Thread Eli Friedman via Phabricator via cfe-commits
efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. Current language seems fine. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74935/new/ https://reviews.llvm.org/D74935

[PATCH] D75046: [docs] dump_ast_matchers strips internal::(Bindable)?Matcher from Result_type

2020-02-24 Thread Nathan James via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGe6f9cb025cd7: [docs] dump_ast_matchers strips internal::(Bindable)?Matcher from Result_type (authored by njames93). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] e6f9cb0 - [docs] dump_ast_matchers strips internal::(Bindable)?Matcher from Result_type

2020-02-24 Thread Nathan James via cfe-commits
Author: Nathan James Date: 2020-02-25T00:00:39Z New Revision: e6f9cb025cd765f422b51d01f4a5714db788b3a7 URL: https://github.com/llvm/llvm-project/commit/e6f9cb025cd765f422b51d01f4a5714db788b3a7 DIFF: https://github.com/llvm/llvm-project/commit/e6f9cb025cd765f422b51d01f4a5714db788b3a7.diff LOG:

[PATCH] D74996: [arcconfig] Delete subproject arcconfigs

2020-02-24 Thread Shoaib Meenai via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGe34ddc09f464: [arcconfig] Delete subproject arcconfigs (authored by smeenai). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74996/new/

[clang] c93112d - Validate argument passed to __builtin_frame_address and __builtin_return_address

2020-02-24 Thread via cfe-commits
Author: zoecarver Date: 2020-02-24T14:23:41-08:00 New Revision: c93112dc4f745b0455addb54bfe1c2f79b827c6d URL: https://github.com/llvm/llvm-project/commit/c93112dc4f745b0455addb54bfe1c2f79b827c6d DIFF: https://github.com/llvm/llvm-project/commit/c93112dc4f745b0455addb54bfe1c2f79b827c6d.diff

[PATCH] D69746: [analyzer] FixItHint: Apply and test hints with the Clang-Tidy's script

2020-02-24 Thread Alexander Kornienko via Phabricator via cfe-commits
alexfh accepted this revision. alexfh added a comment. LG CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69746/new/ https://reviews.llvm.org/D69746 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D75077: [OpenMP5.0] Allow pointer arithmetic in motion/map clause

2020-02-24 Thread Chi Chun Chen via Phabricator via cfe-commits
cchen created this revision. cchen added a reviewer: ABataev. Herald added subscribers: cfe-commits, guansong. Herald added a reviewer: jdoerfert. Herald added a project: clang. Base declaration in pointer arithmetic expression is determined by binary search with type information. Take "int *a,

[PATCH] D75057: Syndicate, test and fix base64 implementation

2020-02-24 Thread serge via Phabricator via cfe-commits
serge-sans-paille updated this revision to Diff 246290. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75057/new/ https://reviews.llvm.org/D75057 Files: clang-tools-extra/clangd/SemanticHighlighting.cpp compiler-rt/lib/fuzzer/FuzzerUtil.cpp

[PATCH] D71018: [ASTImporter] Improved import of TypeSourceInfo (TypeLoc)

2020-02-24 Thread Shafik Yaghmour via Phabricator via cfe-commits
shafik added a comment. A few comments and I would like @teemperor to give this a look as well but it looks good to me. Comment at: clang/lib/AST/ASTImporter.cpp:3281 + // Import the function parameters. + SmallVector Parameters; I am curious, why move

[PATCH] D75077: [OpenMP5.0] Allow pointer arithmetic in motion/map clause

2020-02-24 Thread Alexey Bataev via Phabricator via cfe-commits
ABataev added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:9965 "memory order clause '%0' is specified here">; +def err_omp_non_lvalue_in_map_or_motion_clauses: Error< + "expected lvalue with no function call in '#pragma omp target update'

[PATCH] D75077: [OpenMP5.0] Allow pointer arithmetic in motion/map clause

2020-02-24 Thread Chi Chun Chen via Phabricator via cfe-commits
cchen marked an inline comment as done. cchen added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:15712 +const std::string RTS = RT->getCanonicalTypeInternal().getAsString(); +auto CntLayer = [](char c) { return c == '*' || c == '['; }; +size_t LLayerCnt

[PATCH] D75077: [OpenMP5.0] Allow pointer arithmetic in motion/map clause

2020-02-24 Thread Chi Chun Chen via Phabricator via cfe-commits
cchen updated this revision to Diff 246304. cchen added a comment. Remove the counting in MapBaseChecker, instead, comparing the type of root with the type of LHS and RHS, and only visit the subtree having the same type as root. This scheme pass all the test I have. I'll add BinOp into

[PATCH] D75040: [ASTMatchers] Adds a matcher called `hasAnyOperatorName`

2020-02-24 Thread Nathan James via Phabricator via cfe-commits
njames93 updated this revision to Diff 246335. njames93 added a comment. - Rebase with trunk Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75040/new/ https://reviews.llvm.org/D75040 Files: clang/docs/LibASTMatchersReference.html

[PATCH] D75077: [OpenMP5.0] Allow pointer arithmetic in motion/map clause

2020-02-24 Thread Chi Chun Chen via Phabricator via cfe-commits
cchen updated this revision to Diff 246293. cchen added a comment. Remove redundant code in test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75077/new/ https://reviews.llvm.org/D75077 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td

[PATCH] D74941: [OpenMP] `omp begin/end declare variant` - part 1, parsing

2020-02-24 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added inline comments. Comment at: clang/include/clang/Parse/Parser.h:2959 + /// if there was an error. + bool ParseOMPDeclareVariantMatchClause(SourceLocation Loc, OMPTraitInfo ); + This file is inconsistent currently, but it looks like

[PATCH] D69868: Allow "callbr" to return non-void values

2020-02-24 Thread Bill Wendling via Phabricator via cfe-commits
void marked 2 inline comments as done. void added inline comments. Comment at: llvm/include/llvm/CodeGen/MachineBasicBlock.h:137 + /// List of indirect targets of the callbr of a basic block. + SmallPtrSet InlineAsmBrIndirectTargets; + nickdesaulniers wrote: >

[clang] 6980782 - Revert "Validate argument passed to __builtin_frame_address and __builtin_return_address"

2020-02-24 Thread via cfe-commits
Author: zoecarver Date: 2020-02-24T14:35:02-08:00 New Revision: 698078257285a044110620d7dab2fb4451a3fa29 URL: https://github.com/llvm/llvm-project/commit/698078257285a044110620d7dab2fb4451a3fa29 DIFF: https://github.com/llvm/llvm-project/commit/698078257285a044110620d7dab2fb4451a3fa29.diff

[PATCH] D74925: [OpenMP][Opt] Combine `struct ident_t*` during deduplication

2020-02-24 Thread Jon Chesterfield via Phabricator via cfe-commits
JonChesterfield accepted this revision. JonChesterfield added a comment. This revision is now accepted and ready to land. Nice. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74925/new/ https://reviews.llvm.org/D74925

[clang] 5522e82 - [NFC] Cleaned up ASTMatchersInternal Code

2020-02-24 Thread Nathan James via cfe-commits
Author: Nathan James Date: 2020-02-25T01:47:51Z New Revision: 5522e8296fc5a082ebfc2cd1904099b1ba0570d9 URL: https://github.com/llvm/llvm-project/commit/5522e8296fc5a082ebfc2cd1904099b1ba0570d9 DIFF: https://github.com/llvm/llvm-project/commit/5522e8296fc5a082ebfc2cd1904099b1ba0570d9.diff LOG:

[PATCH] D69876: Support output constraints on "asm goto"

2020-02-24 Thread Bill Wendling via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG50cac248773c: Support output constraints on asm goto (authored by void). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69876/new/

[PATCH] D66839: Fix stack address builtin for negative numbers

2020-02-24 Thread Zoe Carver via Phabricator via cfe-commits
zoecarver reopened this revision. zoecarver added a comment. This revision is now accepted and ready to land. Reverted: 698078257285a044110620d7dab2fb4451a3fa29 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D75093: clang-cl: Add a `/showIncludes:user` flag.

2020-02-24 Thread Nico Weber via Phabricator via cfe-commits
thakis created this revision. thakis added a reviewer: hans. This flag is like /showIncludes, but it only includes user headers and omits system headers (similar to MD and MMD). The motivation is that projects that already track system includes though other means can use this flag to get

[clang] 50cac24 - Support output constraints on "asm goto"

2020-02-24 Thread Bill Wendling via cfe-commits
Author: Bill Wendling Date: 2020-02-24T18:51:29-08:00 New Revision: 50cac248773c3a023e8f6ceb9938bdd5e9f15da2 URL: https://github.com/llvm/llvm-project/commit/50cac248773c3a023e8f6ceb9938bdd5e9f15da2 DIFF: https://github.com/llvm/llvm-project/commit/50cac248773c3a023e8f6ceb9938bdd5e9f15da2.diff

[PATCH] D75028: Make __builtin_amdgcn_dispatch_ptr dereferenceable and align at 4

2020-02-24 Thread Matt Arsenault via Phabricator via cfe-commits
arsenm accepted this revision. arsenm added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75028/new/ https://reviews.llvm.org/D75028 ___ cfe-commits mailing list

[PATCH] D75028: Make __builtin_amdgcn_dispatch_ptr dereferenceable and align at 4

2020-02-24 Thread Matt Arsenault via Phabricator via cfe-commits
arsenm added inline comments. Comment at: llvm/include/llvm/IR/IntrinsicsAMDGPU.td:144 def int_amdgcn_dispatch_ptr : - GCCBuiltin<"__builtin_amdgcn_dispatch_ptr">, Intrinsic<[LLVMQualPointerType], [], I don't think you actually need to delete this. It

[PATCH] D75096: [ASTMatchers] Matcher macros with params move params instead of copying

2020-02-24 Thread Nathan James via Phabricator via cfe-commits
njames93 created this revision. njames93 added reviewers: aaron.ballman, gribozavr2. Herald added a project: clang. Herald added a subscriber: cfe-commits. Use move semantics instead of copying for AST Matchers with parameters Repository: rG LLVM Github Monorepo

[PATCH] D75097: [cc1as] Unset UseNamesOnTempLabels

2020-02-24 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay created this revision. MaskRay added a reviewer: efriedma. Herald added a project: clang. Herald added a subscriber: cfe-commits. Similar to rL236642 . This fixes https://reviews.llvm.org/D74006#1890487 Repository: rG LLVM Github Monorepo

[PATCH] D69868: Allow "callbr" to return non-void values

2020-02-24 Thread Bill Wendling via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG23c2a5ce33f0: Allow callbr to return non-void values (authored by void). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69868/new/

[PATCH] D75028: Make __builtin_amdgcn_dispatch_ptr dereferenceable and align at 4

2020-02-24 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl marked an inline comment as done. yaxunl added inline comments. Comment at: llvm/include/llvm/IR/IntrinsicsAMDGPU.td:144 def int_amdgcn_dispatch_ptr : - GCCBuiltin<"__builtin_amdgcn_dispatch_ptr">, Intrinsic<[LLVMQualPointerType], [], arsenm wrote: >

[PATCH] D75040: [ASTMatchers] Adds a matcher called `hasAnyOperatorName`

2020-02-24 Thread Nathan James via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG6a0c066c6102: [ASTMatchers] Adds a matcher called `hasAnyOperatorName` (authored by njames93). Changed prior to commit: https://reviews.llvm.org/D75040?vs=246335=246375#toc Repository: rG LLVM

[PATCH] D75096: [ASTMatchers] Matcher macros with params move params instead of copying

2020-02-24 Thread Nathan James via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG3e9a7b2ba470: [ASTMatchers] Matcher macros with params move params instead of copying (authored by njames93). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D69560: [clang-tidy] Add 'cppcoreguidelines-avoid-adjacent-arguments-of-same-type' check

2020-02-24 Thread Kim Viggedal via Phabricator via cfe-commits
vingeldal added a comment. In D69560#1890026 , @aaron.ballman wrote: > In D69560#1889925 , @vingeldal wrote: > > > Doesn't clang-tidy exclude warnings from system headers by default though? > > > Third-party SDKs

[clang] 3e9a7b2 - [ASTMatchers] Matcher macros with params move params instead of copying

2020-02-24 Thread Nathan James via cfe-commits
Author: Nathan James Date: 2020-02-25T07:50:34Z New Revision: 3e9a7b2ba470bbe9cf3de3e4b15ba09dcfd206aa URL: https://github.com/llvm/llvm-project/commit/3e9a7b2ba470bbe9cf3de3e4b15ba09dcfd206aa DIFF: https://github.com/llvm/llvm-project/commit/3e9a7b2ba470bbe9cf3de3e4b15ba09dcfd206aa.diff LOG:

[clang] 6a0c066 - [ASTMatchers] Adds a matcher called `hasAnyOperatorName`

2020-02-24 Thread Nathan James via cfe-commits
Author: Nathan James Date: 2020-02-25T07:51:20Z New Revision: 6a0c066c6102cd463e8ad48881e91e596547507a URL: https://github.com/llvm/llvm-project/commit/6a0c066c6102cd463e8ad48881e91e596547507a DIFF: https://github.com/llvm/llvm-project/commit/6a0c066c6102cd463e8ad48881e91e596547507a.diff LOG:

[PATCH] D75034: [clang-format] use spaces for alignment with UT_ForContinuationAndIndentation

2020-02-24 Thread Maximilian Fickert via Phabricator via cfe-commits
fickert created this revision. fickert added reviewers: clang-format, MyDeveloperDay, krasimir. fickert added projects: clang-format, clang-tools-extra. Herald added a project: clang. Herald added a subscriber: cfe-commits. Use spaces instead of tabs for alignment with

[PATCH] D75022: clang-format: Extend AllowShortLoopsOnASingleLine to do ... while loops.

2020-02-24 Thread Daan De Meyer via Phabricator via cfe-commits
DaanDeMeyer updated this revision to Diff 246150. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75022/new/ https://reviews.llvm.org/D75022 Files: clang/lib/Format/UnwrappedLineFormatter.cpp Index: clang/lib/Format/UnwrappedLineFormatter.cpp

[PATCH] D75034: [clang-format] use spaces for alignment with UT_ForContinuationAndIndentation

2020-02-24 Thread Maximilian Fickert via Phabricator via cfe-commits
fickert added a comment. I added an `IsAligned` flag to `ParenState` and `Change` to track if an indent was created for alignment. I adapted the corresponding test cases where alignments were previously done with tabs, including a test case where leading whitespace in a comment is interpreted

[PATCH] D75034: [clang-format] use spaces for alignment with UT_ForContinuationAndIndentation

2020-02-24 Thread MyDeveloperDay via Phabricator via cfe-commits
MyDeveloperDay added a comment. If you are changing unit tests then I'm nervous, imagine if this many tests change what the impact is on a large code base. I think we need to understand more about why you are making this change and why you think its ok to change/remove existing tests which

[PATCH] D75022: clang-format: Extend AllowShortLoopsOnASingleLine to do ... while loops.

2020-02-24 Thread MyDeveloperDay via Phabricator via cfe-commits
MyDeveloperDay added a comment. You need to add unit tests CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75022/new/ https://reviews.llvm.org/D75022 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D75006: Wrap lines for C# property accessors

2020-02-24 Thread MyDeveloperDay via Phabricator via cfe-commits
MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. This LGTM, thank you for the patch CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75006/new/ https://reviews.llvm.org/D75006

[PATCH] D74643: [Parse] Fix `TryParsePtrOperatorSeq`.

2020-02-24 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman accepted this revision. aaron.ballman added a comment. Thank you for the new tests and drive-by fix for `_Atomic`! LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74643/new/ https://reviews.llvm.org/D74643

[PATCH] D74643: [Parse] Fix `TryParsePtrOperatorSeq`.

2020-02-24 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman closed this revision. aaron.ballman added a comment. Thank you for the patch -- I've commit on your behalf in bd5b22070b6984d89c13b6cf38c3e54fc98ce291 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D75044: [AArch64] __builtin_extract_return_addr for PAuth.

2020-02-24 Thread Daniel Kiss via Phabricator via cfe-commits
danielkiss created this revision. danielkiss added reviewers: ostannard, asl. Herald added subscribers: llvm-commits, cfe-commits, jdoerfert, hiraditya, kristof.beyls. Herald added projects: clang, LLVM. This change adds the support for __builtin_extract_return_addr for ARMv8.3A Pointer

[PATCH] D75038: [ARM,MVE] Remove 64-bit variants of vbrsrq* intrinsics

2020-02-24 Thread Simon Tatham via Phabricator via cfe-commits
simon_tatham accepted this revision. simon_tatham added a comment. This revision is now accepted and ready to land. ... and we weren't //testing// the accidental 64-bit builtins (or else we'd have spotted the problem!), so no tests need to be changed. LGTM. Repository: rG LLVM Github

[PATCH] D75034: [clang-format] use spaces for alignment with UT_ForContinuationAndIndentation

2020-02-24 Thread Maximilian Fickert via Phabricator via cfe-commits
fickert updated this revision to Diff 246176. fickert marked an inline comment as done. fickert added a comment. uploaded full context diff CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75034/new/ https://reviews.llvm.org/D75034 Files: clang/lib/Format/BreakableToken.cpp

[PATCH] D74954: Add a basic tiling pass for parallel loops

2020-02-24 Thread Benjamin Kramer via Phabricator via cfe-commits
bkramer updated this revision to Diff 246167. bkramer added a comment. Herald added a subscriber: wuzish. Herald added a reviewer: mclow.lists. - WTF phab? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74954/new/ https://reviews.llvm.org/D74954

[PATCH] D74954: Add a basic tiling pass for parallel loops

2020-02-24 Thread Benjamin Kramer via Phabricator via cfe-commits
bkramer updated this revision to Diff 246166. bkramer marked 4 inline comments as done. bkramer added a comment. Herald added subscribers: libc-commits, libcxx-commits, lldb-commits, Sanitizers, cfe-commits, bader, kerbowa, csigg, usaxena95, jdoerfert, ormris, jsji, kadircet, rupprecht, jfb,

[PATCH] D75040: [ASTMatchers] Adds a matcher called `hasAnyOperatorName`

2020-02-24 Thread Nathan James via Phabricator via cfe-commits
njames93 created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. njames93 edited the summary of this revision. njames93 added reviewers: aaron.ballman, gribozavr2. Acts on `BinaryOperator` and `UnaryOperator` and functions the same as

[PATCH] D75038: [ARM,MVE] Remove 64-bit variants of vbrsrq* intrinsics

2020-02-24 Thread Mikhail Maltsev via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG12fed51c0807: [ARM,MVE] Remove 64-bit variants of vbrsrq* intrinsics (authored by miyuki). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75038/new/

[clang] bd5b220 - Fix TryParsePtrOperatorSeq.

2020-02-24 Thread Aaron Ballman via cfe-commits
Author: Michele Scandale Date: 2020-02-24T08:08:47-05:00 New Revision: bd5b22070b6984d89c13b6cf38c3e54fc98ce291 URL: https://github.com/llvm/llvm-project/commit/bd5b22070b6984d89c13b6cf38c3e54fc98ce291 DIFF:

[PATCH] D75045: [analyzer] Improved check of `fgetc` in StreamChecker.

2020-02-24 Thread Balázs Kéri via Phabricator via cfe-commits
balazske created this revision. Herald added subscribers: cfe-commits, martong, Charusso, gamesh411, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a reviewer: Szelethus. Herald added a project: clang. A warning is produced if the

[PATCH] D75034: [clang-format] use spaces for alignment with UT_ForContinuationAndIndentation

2020-02-24 Thread MyDeveloperDay via Phabricator via cfe-commits
MyDeveloperDay added a comment. you need to add any diff as a full context diff (normally by adding -U 999) to the diff command Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75034/new/ https://reviews.llvm.org/D75034

[PATCH] D75034: [clang-format] use spaces for alignment with UT_ForContinuationAndIndentation

2020-02-24 Thread Maximilian Fickert via Phabricator via cfe-commits
fickert added a comment. I understand the caution around changing the unit tests. The tests I modified assumed that alignment would be made with mixed tabs and spaces, which is arguably not the expected behavior with `UT_ForContinuationAndIndentation` (see

[clang] 12fed51 - [ARM, MVE] Remove 64-bit variants of vbrsrq* intrinsics

2020-02-24 Thread Mikhail Maltsev via cfe-commits
Author: Mikhail Maltsev Date: 2020-02-24T12:49:20Z New Revision: 12fed51c0807b0727f9eecdd3dcf774a82fa7ecd URL: https://github.com/llvm/llvm-project/commit/12fed51c0807b0727f9eecdd3dcf774a82fa7ecd DIFF: https://github.com/llvm/llvm-project/commit/12fed51c0807b0727f9eecdd3dcf774a82fa7ecd.diff

[PATCH] D75041: [WIP][clang-tidy] Approximate implicit conversion issues for the 'cppcoreguidelines-avoid-adjacent-arguments-of-same-type' check

2020-02-24 Thread Whisperity via Phabricator via cfe-commits
whisperity created this revision. whisperity added a project: clang-tools-extra. Herald added subscribers: cfe-commits, martong, gamesh411, Szelethus, dkrupp, rnkovacs, kbarton, xazax.hun, nemanjai. Herald added a project: clang. whisperity added a parent revision: D69560: [clang-tidy] Add

[PATCH] D74961: [clangd] Make global rename file limit adjustable

2020-02-24 Thread Kirill Bobyrev via Phabricator via cfe-commits
kbobyrev abandoned this revision. kbobyrev added a comment. In D74961#1886479 , @hokein wrote: > oops, I should have synced with you first (the task was assigned to me in the > Tuesday meeting), I have https://reviews.llvm.org/D74834 which is under >

[PATCH] D75040: [ASTMatchers] Adds a matcher called `hasAnyOperatorName`

2020-02-24 Thread Dmitri Gribenko via Phabricator via cfe-commits
gribozavr2 accepted this revision. gribozavr2 added inline comments. This revision is now accepted and ready to land. Comment at: clang/include/clang/ASTMatchers/ASTMatchersInternal.h:1870 +std::is_same::value, +"unsupported class for

[PATCH] D52136: [clang-tidy] Add modernize-concat-nested-namespaces check

2020-02-24 Thread Andi via Phabricator via cfe-commits
Abpostelnicu added inline comments. Comment at: clang-tidy/modernize/ConcatNestedNamespacesCheck.cpp:88 + + if (!Sources.isInMainFile(ND.getBeginLoc())) +return; This breaks the usage of this checker in an unified build scenario since the main file for the

[PATCH] D74953: [profile] Don't dump counters when forking and don't reset when calling exec** functions

2020-02-24 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG8f46269f0c1c: [profile] Dont dump counters when forking and dont reset when calling exec**… (authored by Calixte Denizet calixte.deni...@gmail.com). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D75006: Wrap lines for C# property accessors

2020-02-24 Thread Jonathan B Coe via Phabricator via cfe-commits
jbcoe updated this revision to Diff 246170. jbcoe added a comment. Handle C# access modifier `internal `. Fix typo in test for expression-bodied get/set methods. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75006/new/ https://reviews.llvm.org/D75006 Files:

  1   2   >