[clang-tools-extra] e397a0a - [clangd] Add instrumentation mode in clangd for metrics collection.

Author: Utkarsh Saxena Date: 2020-03-05T12:39:15+01:00 New Revision: e397a0a5c3c0fa1912fbac23b550fa7d239196ba URL: https://github.com/llvm/llvm-project/commit/e397a0a5c3c0fa1912fbac23b550fa7d239196ba DIFF:

[PATCH] D75470: [SVE] Auto-generate builtins and header for svld1.

sdesmalen updated this revision to Diff 248432. sdesmalen marked 11 inline comments as done. sdesmalen added a comment. - Renamed CK and BaseTS - Refactored switch statementsd in SVEType::getTypeFlags() CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75470/new/

[PATCH] D75470: [SVE] Auto-generate builtins and header for svld1.

sdesmalen added inline comments. Comment at: clang/include/clang/Basic/arm_sve.td:121 +// Load one vector (scalar base) +def SVLD1 : MInst<"svld1[_{2}]", "dPc", "csilUcUsUiUlhfd", [IsLoad]>; SjoerdMeijer wrote: > This encoding, e.g, this is "csilUcUsUiUlhfd",

[PATCH] D75538: [clang-tidy] Updated language supported restrictions on some checks

alexfh added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/modernize-use-nullptr-basic.cpp:1 -// RUN: %check_clang_tidy -std=c++98 %s modernize-use-nullptr %t -- -- -Wno-non-literal-null-conversion -// njames93 wrote: > alexfh wrote:

[PATCH] D75675: [clang-format] do not insert spaces around inline asm symbolic names

krasimir created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. krasimir edited the summary of this revision. krasimir added a reviewer: hans. hans added a comment. Very nice, thanks! Comment at: clang/lib/Format/TokenAnnotator.cpp:502

[PATCH] D75675: [clang-format] do not insert spaces around inline asm symbolic names

hans added a comment. Very nice, thanks! Comment at: clang/lib/Format/TokenAnnotator.cpp:502 Left->Type = TT_ObjCMethodExpr; + } else if (Style.isCpp() && InsideInlineASM) { +Left->Type = TT_InlineASMSymbolicNameLSquare; Is the

[clang] 66addf8 - Revert "Fix regression in bdad0a1: force rebuilding of StmtExpr nodes in", "PR45083: Mark statement expressions as being dependent if they appear in"

Author: Benjamin Kramer Date: 2020-03-05T14:14:31+01:00 New Revision: 66addf8e803618758457e4d578c5084e322ca448 URL: https://github.com/llvm/llvm-project/commit/66addf8e803618758457e4d578c5084e322ca448 DIFF:

Re: [clang] bdad0a1 - PR45083: Mark statement expressions as being dependent if they appear in

It's still crashing clang, reverted this and f545ede91c9d9f271e7504282cab7bf509607ead in 66addf8e8036. c-reduce is still chewing on the reproducer. On Wed, Mar 4, 2020 at 10:20 PM Richard Smith via cfe-commits wrote: > > We found a regression introduced by this patch; fixed in >

[clang] 36c2ab8 - [clang-format] do not insert spaces around inline asm symbolic names

Author: Krasimir Georgiev Date: 2020-03-05T14:17:21+01:00 New Revision: 36c2ab8d04cd9ff2e50cffa1ca6b3de00e4faa81 URL: https://github.com/llvm/llvm-project/commit/36c2ab8d04cd9ff2e50cffa1ca6b3de00e4faa81 DIFF:

[PATCH] D75356: [Analyzer][StreamChecker] Introduction of stream error state handling.

Szelethus added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StreamChecker.cpp:37-40 + // NoError: No error flag is set or stream is not open. + // EofError: EOF condition (feof returns true) + // OtherError: other (non-EOF) error (ferror returns true) + //

[PATCH] D74618: [ARM] Creating 'call_mangled' for Neon intrinsics definitions

dnsampaio added inline comments. Comment at: clang/utils/TableGen/NeonEmitter.cpp:1890-1891 } +if (MangledName) + Good &= I.getMangledName(true) == MangledName; + Can we move this above the loop just before? Perhaps, if false, can we just continue

[PATCH] D75603: [clangd] Add instrumentation mode in clangd for metrics collection.

This revision was automatically updated to reflect the committed changes. Closed by commit rGe397a0a5c3c0: [clangd] Add instrumentation mode in clangd for metrics collection. (authored by usaxena95). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D75603: [clangd] Add instrumentation mode in clangd for metrics collection.

usaxena95 updated this revision to Diff 248422. usaxena95 added a comment. Passed score as a float as an explicit argument of the callback. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75603/new/ https://reviews.llvm.org/D75603 Files:

[PATCH] D75678: [analyzer] Skip analysis of inherited ctor as top-level function

martong added a comment. For those who are interested in more details please refer to the related discussion after the commit of the patch that introduces handling of inherited ctors . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D73638: [AST] Move dependence computations into a separate file

hokein commandeered this revision. hokein added a reviewer: ilya-biryukov. hokein added a comment. This patch contains too many changes, most of them are just NFC, it likely takes a long time to do a full review. I actually did an review for the original patch. I have highlighted places (see

[PATCH] D75678: [analyzer] Skip analysis of inherited ctor as top-level function

NoQ added a comment. Thanks!! I also recommend a more direct test with `-analyzer-display-progress | FileCheck`. Comment at: clang/lib/StaticAnalyzer/Frontend/AnalysisConsumer.cpp:507-508 + // Skip analysis of inherited constructors as top-level functions because we + //

[PATCH] D75184: [clang-tidy] Optional inheritance of file configs from parent directories 

DmitryPolukhin updated this revision to Diff 248457. DmitryPolukhin added a comment. Comments resolved, please take another look. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75184/new/ https://reviews.llvm.org/D75184 Files:

[PATCH] D75470: [SVE] Auto-generate builtins and header for svld1.

SjoerdMeijer added inline comments. Comment at: clang/include/clang/Basic/arm_sve.td:121 +// Load one vector (scalar base) +def SVLD1 : MInst<"svld1[_{2}]", "dPc", "csilUcUsUiUlhfd", [IsLoad]>; sdesmalen wrote: > SjoerdMeijer wrote: > > This encoding, e.g,

Re: [clang] bdad0a1 - PR45083: Mark statement expressions as being dependent if they appear in

creduce produced this. It's a crash on invalid, but was created from a valid input. $ cat r.ii template auto b(a) { auto c = [](auto, int) -> decltype(({})) {}; return c(0, 0); } using d = decltype(b(0)); bool f = d ::e; $ clang r.ii -std=c++17 -w clang-11: clang/lib/AST/Decl.cpp:2343:

[PATCH] D74669: [clang-tidy] New check: bugprone-suspicious-include

lebedev.ri added inline comments. Comment at: clang-tools-extra/clang-tidy/utils/FileExtensionsUtils.h:38 +/// extensions. +inline StringRef defaultHeaderFileExtensions() { return ",h,hh,hpp,hxx"; } + njames93 wrote: > A lot of configuration options for clang

Re: [clang] ec3060c - [AST] Refactor propagation of dependency bits. NFC

Hi Hokein, Ilya, Clang warns on this code when compiled without asserts: ../../clang/lib/AST/TemplateName.cpp:189:3: error: unannotated fall- through between switch labels [-Werror,-Wimplicit-fallthrough] default: ^ ../../clang/lib/AST/TemplateName.cpp:189:3: note: insert 'break;' to avoid

[PATCH] D75603: [clangd] Add instrumentation mode in clangd for metrics collection.

kadircet added a comment. In D75603#1906418 , @sammccall wrote: > Forgot to mention: I also think the trace approach certainly has things going > for it, or even parsing out the messages from the existing logs. > But in this particular case the callback

[PATCH] D75582: [clangd] Track document versions, include them with diags, enhance logs

kadircet added inline comments. Comment at: clang-tools-extra/clangd/ClangdServer.h:73 virtual void onDiagnosticsReady(PathRef File, +const llvm::json::Value , std::vector Diagnostics) {}

[PATCH] D75356: [Analyzer][StreamChecker] Introduction of stream error state handling.

balazske marked 8 inline comments as done. balazske added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StreamChecker.cpp:37-40 + // NoError: No error flag is set or stream is not open. + // EofError: EOF condition (feof returns true) + // OtherError: other

[PATCH] D75356: [Analyzer][StreamChecker] Introduction of stream error state handling.

balazske marked 2 inline comments as done. balazske added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StreamChecker.cpp:37-40 + // NoError: No error flag is set or stream is not open. + // EofError: EOF condition (feof returns true) + // OtherError: other

[PATCH] D75604: [clangd] Round WorkDoneProgressBegin.percentage down

kbobyrev abandoned this revision. kbobyrev marked an inline comment as done. kbobyrev added inline comments. Comment at: clang-tools-extra/clangd/ClangdLSPServer.cpp:1409 (Stats.Enqueued - Stats.LastIdle); + // Round down to 2 decimal places for

[PATCH] D75569: [clang-tidy] New check for methods marked __attribute__((unavailable)) that do not override a method from a superclass.

njames93 added a comment. Fix the test case. Comment at: clang-tools-extra/clang-tidy/objc/MethodUnavailableNotOverrideCheck.cpp:29 +// intended to be matched here. +AST_MATCHER(ObjCMethodDecl, isUnavailableMethodNotOverriding) { + return !Node.isOverriding() &&

[PATCH] D75665: [analyzer] On-demand parsing capability for CTU

gamesh411 created this revision. gamesh411 added reviewers: martong, balazske. Herald added subscribers: cfe-commits, steakhal, Charusso, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun, whisperity, mgorny. Herald added a reviewer:

[PATCH] D74935: [LangRef][AliasAnalysis] Clarify `noalias` affects only modified objects

jeroen.dobbelaere added a comment. Just to give an example: int foo(int* restrict *pA, int* restrict *pB) { int tmp=**pB; **pA=42; return tmp - **pB; // **pA and **pB can refer to the same objects } This gives following llvm-ir code with the 'full noalias' clang version (after

[PATCH] D74669: [clang-tidy] New check: bugprone-suspicious-include

lebedev.ri added inline comments. Comment at: clang-tools-extra/clang-tidy/utils/FileExtensionsUtils.h:38 +/// extensions. +inline StringRef defaultHeaderFileExtensions() { return ",h,hh,hpp,hxx"; } + njames93 wrote: > lebedev.ri wrote: > > njames93 wrote: > > >

[clang] 737394c - Revert "clang: Treat ieee mode as the default for denormal-fp-math"

Author: Jeremy Morse Date: 2020-03-05T10:55:24Z New Revision: 737394c490444e968a6f640b99a6614567ca7f28 URL: https://github.com/llvm/llvm-project/commit/737394c490444e968a6f640b99a6614567ca7f28 DIFF: https://github.com/llvm/llvm-project/commit/737394c490444e968a6f640b99a6614567ca7f28.diff LOG:

[PATCH] D75603: [clangd] Add instrumentation mode in clangd for metrics collection.

usaxena95 added inline comments. Comment at: clang-tools-extra/clangd/CodeComplete.h:139 + /// in the output. + std::function *RecordCCResult = nullptr; sammccall wrote: > I'd suggest including the final score in the signature rather than recompute > it,

[PATCH] D74617: [ARM] Keeping sign information on bitcasts for Neon vdot_lane intrinsics

dnsampaio added a comment. Is this missing a test? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74617/new/ https://reviews.llvm.org/D74617 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D75603: [clangd] Add instrumentation mode in clangd for metrics collection.

usaxena95 updated this revision to Diff 248416. usaxena95 marked 5 inline comments as done. usaxena95 added a comment. Addressed comments. - Populated score in CodeCompletion before invoking the callback. - Tested that CodeCompletion is scored - Updated comment for callback. Repository: rG

[clang] cd1dc7f - [AST] Replace assert with llvm_unreachable to silence compiler warning

Author: Mikael Holmen Date: 2020-03-05T11:07:54+01:00 New Revision: cd1dc7f15d637b42067546e658574237cd0f0d46 URL: https://github.com/llvm/llvm-project/commit/cd1dc7f15d637b42067546e658574237cd0f0d46 DIFF: https://github.com/llvm/llvm-project/commit/cd1dc7f15d637b42067546e658574237cd0f0d46.diff

[PATCH] D74669: [clang-tidy] New check: bugprone-suspicious-include

njames93 added inline comments. Comment at: clang-tools-extra/clang-tidy/utils/FileExtensionsUtils.h:38 +/// extensions. +inline StringRef defaultHeaderFileExtensions() { return ",h,hh,hpp,hxx"; } + lebedev.ri wrote: > njames93 wrote: > > A lot of configuration

[PATCH] D75665: [analyzer] On-demand parsing capability for CTU

gamesh411 added a comment. This patch adds an alternative way of loading ASTs to provide the CTU definitions needed during analysis. The additional approach is to use Tooling with a user-provided compile_commands.json, and look up the needed file from the output of the ext-def-mapping tool

[clang-tools-extra] 5abfe64 - [clangd] Fix test (it worked by coincidence before)

Author: Sam McCall Date: 2020-03-05T10:11:55+01:00 New Revision: 5abfe646f5e194bb2330b80c7f0e23fba00e30fe URL: https://github.com/llvm/llvm-project/commit/5abfe646f5e194bb2330b80c7f0e23fba00e30fe DIFF: https://github.com/llvm/llvm-project/commit/5abfe646f5e194bb2330b80c7f0e23fba00e30fe.diff

[PATCH] D74616: [ARM] Setting missing isLaneQ attribute on Neon Intrisics definitions

dnsampaio accepted this revision. dnsampaio added a comment. This revision is now accepted and ready to land. LGTM with a nit: we can save some space using sintax like this: let isLaneQ = 1 in def UDOT_LANEQ : SOpInst<"vdot_laneq", "..(<<)(<; or concatenating those that are just one after

Re: [clang] c64ca93 - clang: Treat ieee mode as the default for denormal-fp-math

Hi Matt, FYI several build bots tripped on this commit: http://lab.llvm.org:8011/builders/clang-x86_64-debian-fast/builds/24703/ http://lab.llvm.org:8011/builders/clang-cmake-x86_64-avx2-linux/builds/13465/ http://lab.llvm.org:8011/builders/clang-with-lto-ubuntu/builds/15994/

[PATCH] D75163: [analyzer][StreamChecker] Adding precall and refactoring.

Szelethus added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StreamChecker.cpp:64-70 +/// Get the value of the stream argument out of the passed call event. +/// The call should contain a function that is described by Desc. +SVal getStreamArg(const

[PATCH] D75612: [Analyzer][StreamChecker] Adding PreCall and refactoring (NFC).

Szelethus added a comment. Wouldn't it be better just to upload this diff to D75163 by the way? It feels like we're discarding much of the discussion. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75612/new/

[PATCH] D75612: [Analyzer][StreamChecker] Adding PreCall and refactoring (NFC).

Szelethus accepted this revision. Szelethus added a comment. This revision is now accepted and ready to land. LGTM! Lets have a link to the original discussion: D75163 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D75514: [Analyzer] Only add container note tags to the operations of the affected container

baloghadamsoftware added a comment. In D75514#1905268 , @Szelethus wrote: > But why is this related to `UndefinedVal`? Because `UndefinedVal` seems to be the "null" value of `SVal` thus it is suitable for default value of the parameter. CHANGES SINCE

[PATCH] D75675: [clang-format] do not insert spaces around inline asm symbolic names

krasimir marked an inline comment as done. krasimir added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:502 Left->Type = TT_ObjCMethodExpr; + } else if (Style.isCpp() && InsideInlineASM) { +Left->Type = TT_InlineASMSymbolicNameLSquare;

[PATCH] D75675: [clang-format] do not insert spaces around inline asm symbolic names

This revision was automatically updated to reflect the committed changes. Closed by commit rG36c2ab8d04cd: [clang-format] do not insert spaces around inline asm symbolic names (authored by krasimir). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D75677: [Analyzer] Only add iterator note tags to the operations of the affected iterators

baloghadamsoftware created this revision. baloghadamsoftware added reviewers: NoQ, Szelethus. baloghadamsoftware added a project: clang. Herald added subscribers: martong, steakhal, Charusso, gamesh411, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, xazax.hun, whisperity.

[PATCH] D75675: [clang-format] do not insert spaces around inline asm symbolic names

krasimir updated this revision to Diff 248445. krasimir marked an inline comment as done. krasimir added a comment. Remove redundant check. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75675/new/ https://reviews.llvm.org/D75675 Files:

[PATCH] D75675: [clang-format] do not insert spaces around inline asm symbolic names

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. lgtm, thanks for the quick fix! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75675/new/ https://reviews.llvm.org/D75675

[PATCH] D75675: [clang-format] do not insert spaces around inline asm symbolic names

krasimir updated this revision to Diff 248449. krasimir added a comment. Merging commits into 1 patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75675/new/ https://reviews.llvm.org/D75675 Files: clang/lib/Format/FormatToken.h

[PATCH] D75678: [analyzer] Skip analysis of inherited ctor as top-level function

martong created this revision. martong added a reviewer: NoQ. Herald added subscribers: cfe-commits, steakhal, Charusso, gamesh411, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun, whisperity. Herald added a reviewer: Szelethus. Herald

[PATCH] D74735: [analyzer] Add support for CXXInheritedCtorInitExpr.

martong added a comment. Thanks Richard for the explanation. Artem, I think this justifies your suggestion to skip the analysis of inherited constructors as top level functions. I just created the patch https://reviews.llvm.org/D75678 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D75470: [SVE] Auto-generate builtins and header for svld1.

SjoerdMeijer added a subscriber: simon_tatham. SjoerdMeijer added a comment. Adding @simon_tatham in case he feels wants to have a look too. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75470/new/ https://reviews.llvm.org/D75470 ___

[PATCH] D75678: [analyzer] Skip analysis of inherited ctor as top-level function

martong updated this revision to Diff 248473. martong marked an inline comment as done. martong added a comment. - Change comments, add FileCheck test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75678/new/ https://reviews.llvm.org/D75678 Files:

[clang] a8648fd - Replace getAs with castAs to fix null dereference static analyzer warning.

Author: Simon Pilgrim Date: 2020-03-05T15:28:54Z New Revision: a8648fd19aecfe2aed3ce529f488930cc37db4c2 URL: https://github.com/llvm/llvm-project/commit/a8648fd19aecfe2aed3ce529f488930cc37db4c2 DIFF: https://github.com/llvm/llvm-project/commit/a8648fd19aecfe2aed3ce529f488930cc37db4c2.diff

[PATCH] D75678: [analyzer] Skip analysis of inherited ctor as top-level function

Szelethus added a comment. I followed the discussion, on the other patch, and this seems to be the appropriate fix -- I lack the confidence to accept, but LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75678/new/

[PATCH] D75623: [clangd][VSCode] Force VSCode to use the ranking provided by clangd.

hokein added a comment. thanks for fixing that! Played around it locally, it seems work, found an issue where the global code completion is not triggered, see my comment. Comment at: clang-tools-extra/clangd/clients/clangd-vscode/src/extension.ts:116 +// Get the

[clang] ea5b3ef - [OPENMP50]Skip the first element when storing the list of dependencies

Author: Alexey Bataev Date: 2020-03-05T14:26:07-05:00 New Revision: ea5b3ef5935c1a64b78e06fb4b4dcc919fd585b5 URL: https://github.com/llvm/llvm-project/commit/ea5b3ef5935c1a64b78e06fb4b4dcc919fd585b5 DIFF: https://github.com/llvm/llvm-project/commit/ea5b3ef5935c1a64b78e06fb4b4dcc919fd585b5.diff

[clang] 8d7b118 - [OPENMP50]Add codegen for update clause in depobj directive.

Author: Alexey Bataev Date: 2020-03-05T14:31:07-05:00 New Revision: 8d7b1188751b9fcc3345e80fb48a2bc00b7c315f URL: https://github.com/llvm/llvm-project/commit/8d7b1188751b9fcc3345e80fb48a2bc00b7c315f DIFF: https://github.com/llvm/llvm-project/commit/8d7b1188751b9fcc3345e80fb48a2bc00b7c315f.diff

[clang-tools-extra] a7c655f - [clangd] Remove vsc-extension-quickstart.md from the vscode-clangd plugin

Author: Nathan Ridge Date: 2020-03-05T15:28:40-05:00 New Revision: a7c655f1480fbcee853fb7d9f6fd4cff80a0dc2f URL: https://github.com/llvm/llvm-project/commit/a7c655f1480fbcee853fb7d9f6fd4cff80a0dc2f DIFF: https://github.com/llvm/llvm-project/commit/a7c655f1480fbcee853fb7d9f6fd4cff80a0dc2f.diff

[PATCH] D75698: [analyzer][WIP] Suppress bug reports where a tracked expression's latest value change was a result of an invalidation

Szelethus marked an inline comment as done. Szelethus added a comment. In D75698#1908335 , @NoQ wrote: > In my head this patch should ideally be reduced to a single if-statement: > "This value is a `SymbolDerived` //therefore// it was produced by >

[PATCH] D75271: [analyzer][NFC] Change LangOptions to CheckerManager in the shouldRegister* functions.

Szelethus added a comment. Thanks for bringing it up, I'll attend to it -- though both of those changes are out of scope of this change, and I'd be strongly against solving any of those issues within this revision. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75271/new/

[PATCH] D31342: Add ParsedAttrInfo::handleDeclAttribute

aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaDeclAttr.cpp:6701-6707 if (!AL.isStmtAttr()) { // Type attributes are handled elsewhere; silently move on. assert(AL.isTypeAttr() && "Non-type attribute not handled"); break; }

[PATCH] D75698: [analyzer][WIP] Suppress bug reports where a tracked expression's latest value change was a result of an invalidation

NoQ added a comment. In D75698#1908370 , @Szelethus wrote: > In D75698#1908335 , @NoQ wrote: > > > In my head this patch should ideally be reduced to a single if-statement: > > "This value is a `SymbolDerived`

[PATCH] D75698: [analyzer][WIP] Suppress bug reports where a tracked expression's latest value change was a result of an invalidation

NoQ added a comment. Like, the only reason why we have `trackExpressionValue` is because our concrete values are indistinguishable from each other. Regardless of where it comes from, `0 (Loc)` is the same as all other `0 (Loc)`s, so we have to manually observe how it was copied around in order

[PATCH] D71913: [LTO/WPD] Enable aggressive WPD under LTO option

pcc added inline comments. Comment at: clang/test/CodeGenCXX/lto-visibility-inference.cpp:73 c1->f(); - // ITANIUM-NOT: type.test{{.*}}!"_ZTS2C2" + // ITANIUM: type.test{{.*}}!"_ZTS2C2" // MS: type.test{{.*}}!"?AUC2@@" tejohnson wrote: > pcc wrote: > >

[PATCH] D71966: [Wdocumentation][RFC] Improve identifier's of \param

aaronpuchert added a comment. Thanks for working on this, I'd like to see this being fixed. Comment at: clang/include/clang-c/Documentation.h:383 CINDEX_LINKAGE -CXString clang_ParamCommandComment_getParamName(CXComment Comment); gribozavr2 wrote: >

[PATCH] D75271: [analyzer][NFC] Change LangOptions to CheckerManager in the shouldRegister* functions.

baloghadamsoftware added a comment. It is even worse: the `shouldRegister()` functions do not prevent the registration of a checker, at least in cases when they are not enabled directly but via dependencies. See D75171 . CHANGES SINCE LAST ACTION

[PATCH] D75215: [DebugInfo] Fix for adding "returns cxx udt" option to functions in CodeView.

akhuang marked an inline comment as done and an inline comment as not done. akhuang added inline comments. Comment at: llvm/include/llvm/IR/DebugInfoFlags.def:61 HANDLE_DI_FLAG((1 << 29), AllCallsDescribed) +HANDLE_DI_FLAG((1 << 30), CxxReturnUdt) akhuang

Re: [clang] bdad0a1 - PR45083: Mark statement expressions as being dependent if they appear in

On Thu, 5 Mar 2020 at 06:13, Benjamin Kramer via cfe-commits < cfe-commits@lists.llvm.org> wrote: > creduce produced this. It's a crash on invalid, but was created from a > valid input. > Well, "valid" is unclear when using language extensions, but OK. > $ cat r.ii > template auto b(a) { >

[PATCH] D72841: [RFC] Add support for pragma float_control, to control precision and exception behavior at the source level

mibintc added a comment. I got an email like this "Harbormaster failed remote builds in B48237 : Diff 248536!" but there is no further information. It builds OK from my workstation. I did have to paste the review because an upload to Phabricator exceeded the

[PATCH] D72860: [modules] Do not cache invalid state for modules that we attempted to load.

dblaikie added inline comments. Comment at: clang/lib/Serialization/ModuleManager.cpp:183 // Get a buffer of the file and close the file descriptor when done. - Buf = FileMgr.getBufferForFile(NewModule->File, /*isVolatile=*/false); + Buf =

[PATCH] D75708: Add warnings for casting ptr -> smaller int for C++ in Microsoft mode

aeubanks created this revision. aeubanks added a reviewer: rnk. Herald added a project: clang. Herald added a subscriber: cfe-commits. Adds warnings to groups recently added in https://reviews.llvm.org/D72231. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D75708 Files:

[PATCH] D75286: [clangd] Handle clang-tidy suppression comments for diagnostics inside macro expansions

nridge updated this revision to Diff 248598. nridge marked 4 inline comments as done. nridge added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75286/new/ https://reviews.llvm.org/D75286 Files:

[PATCH] D75286: [clangd] Handle clang-tidy suppression comments for diagnostics inside macro expansions

nridge marked an inline comment as done. nridge added inline comments. Comment at: clang-tools-extra/clang-tidy/ClangTidyDiagnosticConsumer.h:215 /// to this function. -/// The `CheckMacroExpansion` parameter determines whether the function should -/// handle the case where the

[PATCH] D75489: [clang-tidy] Generalize HeaderFileExtensions.{h, cpp}. NFC

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75489/new/ https://reviews.llvm.org/D75489

[PATCH] D75332: [clang-tidy] Add module for llvm-libc and restrict-system-libc-header-check.

aaron.ballman added a comment. In D75332#1904317 , @MaskRay wrote: > In D75332#1904264 , @PaulkaToast > wrote: > > > In D75332#1903570 , @MaskRay wrote: > > > > > >

[PATCH] D31343: Add an attribute plugin example

aaron.ballman added a comment. In D31343#1902903 , @john.brawn wrote: > I've been looking into attribute merging, and as far as I can tell there's > two things going on: > > - In SemaDeclAttr.cpp, the various handleXyzAttr functions may call >

[PATCH] D75469: Add C standard upgrade in clang-11 release note

nickdesaulniers abandoned this revision. nickdesaulniers added a comment. Abandoning; I've already pushed this to the right branch. I suspect phabricator doesn't watch the release brances. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75469/new/

[PATCH] D75697: [analyzer] Allow null false positive suppression for conditions

NoQ added a comment. Aha! We need some positive results tho, given that these are heuristics. Comment at: clang/test/Analysis/inlining/inline-defensive-checks.m:113 if (!mem) -return 5/zero; // expected-warning {{Division by zero}} +return 5/zero; return 0;

[PATCH] D75494: [PowerPC] Delete PPCMachObjectWriter and triple for darwin

This revision was automatically updated to reflect the committed changes. Closed by commit rG3e851f4a688c: [PowerPC] Delete PPCMachObjectWriter and powerpc{,64}-apple-darwin (authored by MaskRay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D73245: Depend stddef.h to provide max_align_t for C++11 and provide better fallback in

ldionne added a comment. In D73245#1896786 , @ldionne wrote: > In D73245#1894420 , @EricWF wrote: > > > @ldionne Since this has the possibility of breaking existing users of > > `std::max_align_t`, can you test

[PATCH] D75655: [Docs] Document -lto-whole-program-visibility

tejohnson updated this revision to Diff 248582. tejohnson marked an inline comment as done. tejohnson added a comment. Fix gold plugin option Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75655/new/ https://reviews.llvm.org/D75655 Files:

[PATCH] D75655: [Docs] Document -lto-whole-program-visibility

tejohnson marked 3 inline comments as done. tejohnson added a subscriber: evgeny777. tejohnson added inline comments. Comment at: clang/docs/LTOVisibility.rst:40 +to hidden LTO visibility when the ``-lto-whole-program-visibility`` lld linker +option is applied

[PATCH] D69573: [clang-format] [PR36294] AlwaysBreakAfterReturnType works incorrectly for some operator functions

sylvestre.ledru added a comment. @hans done here: https://github.com/llvm/llvm-project/commit/50eedc134a219ef6d2345e4efc5471a2e3824223 :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69573/new/ https://reviews.llvm.org/D69573

[PATCH] D75621: [clang-tidy] Use ; as separator for HeaderFileExtensions

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM with a minor nit. Comment at: clang-tools-extra/clang-tidy/utils/FileExtensionsUtils.cpp:40 SmallVector Suffixes; - AllFileExtensions.split(Suffixes, Delimiter); + for (const char Delimiter :

[clang] c359f95 - [AST Matchers] Restrict `optionally` matcher to a single argument.

Author: Yitzhak Mandelbaum Date: 2020-03-05T14:48:40-05:00 New Revision: c359f9537ffb17c4f40a933980ddb515d7ee923b URL: https://github.com/llvm/llvm-project/commit/c359f9537ffb17c4f40a933980ddb515d7ee923b DIFF:

[PATCH] D75292: [clangd] Remove vsc-extension-quickstart.md from the vscode-clangd plugin

This revision was automatically updated to reflect the committed changes. Closed by commit rGa7c655f1480f: [clangd] Remove vsc-extension-quickstart.md from the vscode-clangd plugin (authored by nridge). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D75698: [analyzer][WIP] Suppress bug reports where a tracked expression's latest value change was a result of an invalidation

Szelethus abandoned this revision. Szelethus added a comment. This sounds exciting! Back to work then. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75698/new/ https://reviews.llvm.org/D75698 ___

[PATCH] D64464: [CodeGen] Emit destructor calls to destruct compound literals

ahatanak updated this revision to Diff 248586. ahatanak marked an inline comment as done. ahatanak added a comment. Return `make_error` instead of a nullptr. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64464/new/ https://reviews.llvm.org/D64464

Re: [clang] bdad0a1 - PR45083: Mark statement expressions as being dependent if they appear in

The test case is not important at all, but the crasher seems to be rather bad. I'll send you the full test case. On Thu, Mar 5, 2020 at 9:20 PM Richard Smith via cfe-commits wrote: > > On Thu, 5 Mar 2020 at 06:13, Benjamin Kramer via cfe-commits > wrote: >> >> creduce produced this. It's a

[PATCH] D75556: [AST Matchers] Restrict `optionally` matcher to a single argument.

This revision was automatically updated to reflect the committed changes. Closed by commit rGc359f9537ffb: [AST Matchers] Restrict `optionally` matcher to a single argument. (authored by ymandel). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D73979: [HIP] Allow non-incomplete array type for extern shared var

yaxunl added a comment. In D73979#1907965 , @JonChesterfield wrote: > In D73979#1857736 , @yaxunl wrote: > > > BTW this is requested by HIP users, who have similar code for CUDA and HIP. > > They found it

[PATCH] D75697: [analyzer] Allow null false positive suppression for conditions

Szelethus added a comment. I'm too sure what the implications of such a change is, so I'll get some real-life results before even thinking of commiting. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75697/new/ https://reviews.llvm.org/D75697

[PATCH] D75591: [OpenMP] Add firstprivate as a default data-sharing attribute to clang

jdoerfert added inline comments. Comment at: clang/test/OpenMP/parallel_master_codegen.cpp:143 +// CK31: [[A_VAL:%.+]] = alloca i32 +// CK31: call void (%struct.ident_t*, i32, void (i32*, i32*, ...)*, ...) @__kmpc_fork_call(%struct.ident_t* {{.+}}, i32 1, void

[PATCH] D75698: [analyzer][WIP] Suppress bug reports where a tracked expression's latest value change was a result of an invalidation

NoQ added a comment. In my head this patch should ideally be reduced to a single if-statement: "This value is a `SymbolDerived` //therefore// it was produced by invalidation". It's harder than that, of course, because some derived symbols are legitimate (i.e., values returned through

[PATCH] D74166: [AIX][Frontend] Static init implementation for AIX considering no priority

Xiangling_L updated this revision to Diff 248571. Xiangling_L marked 2 inline comments as done. Xiangling_L added a comment. Fix the formatting issue; Address the 1st round reviews; CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74166/new/ https://reviews.llvm.org/D74166 Files:

[PATCH] D75615: Revert "[CGBlocks] Improve line info in backtraces containing *_helper_block"

This revision was automatically updated to reflect the committed changes. Closed by commit rG314b9278f097: Revert [CGBlocks] Improve line info in backtraces containing *_helper_block (authored by aprantl). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D75665: [analyzer] On-demand parsing capability for CTU

martong added inline comments. Comment at: clang/include/clang/CrossTU/CrossTranslationUnit.h:23 #include "llvm/ADT/StringMap.h" +#include "llvm/IR/DiagnosticInfo.h" +#include "llvm/IR/OperandTraits.h" Perhaps this include is needed only in the .cpp file?

[PATCH] D75556: [AST Matchers] Restrict `optionally` matcher to a single argument.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75556/new/ https://reviews.llvm.org/D75556

  1   2   3   >