[clang] e963063 - [Syntax] Split syntax tests

Author: Marcel Hlopko Date: 2020-03-20T09:53:43+01:00 New Revision: e9630630ffa2a69bf3eabe154a3846deab694fa0 URL: https://github.com/llvm/llvm-project/commit/e9630630ffa2a69bf3eabe154a3846deab694fa0 DIFF: https://github.com/llvm/llvm-project/commit/e9630630ffa2a69bf3eabe154a3846deab694fa0.diff

[PATCH] D76424: [AST] Use TypeDependence bitfield to calculate dependence on Types. NFC

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. Thanks. Comment at: clang/lib/AST/Type.cpp:3036 -if (epi.ExceptionSpec.NoexceptExpr->isValueDependent() || -

[PATCH] D72810: [LifetimeAnalysis] Add support for lifetime annotations on functions

xazax.hun updated this revision to Diff 251569. xazax.hun marked an inline comment as done. xazax.hun added a comment. - Rebase. - Address some review comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72810/new/ https://reviews.llvm.org/D72810 Files:

[PATCH] D72810: [LifetimeAnalysis] Add support for lifetime annotations on functions

xazax.hun marked 14 inline comments as done. xazax.hun added inline comments. Comment at: clang/include/clang/AST/LifetimeAttr.h:163 +// Maps each annotated entity to a lifetime set. +using LifetimeContracts = std::map; + aaron.ballman wrote: > xazax.hun wrote:

[PATCH] D76361: [Analyzer] Iterator Modeling - Model `std::advance()`, `std::prev()` and `std::next()`

baloghadamsoftware updated this revision to Diff 251567. baloghadamsoftware added a comment. Updated according to the comments and automatic formatting suggestions. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76361/new/ https://reviews.llvm.org/D76361 Files:

[PATCH] D75184: [clang-tidy] Optional inheritance of file configs from parent directories 

njames93 added a comment. In D75184#1932764 , @alexfh wrote: > There's one more thing to consider: just by looking at the name of a local > option we don't know whether it will be read using `get()` or > `getLocalOrGlobal()`. By removing local options

[PATCH] D76361: [Analyzer] Iterator Modeling - Model `std::advance()`, `std::prev()` and `std::next()`

baloghadamsoftware marked 9 inline comments as done. baloghadamsoftware added a comment. In D76361#1929483 , @martong wrote: > I suppose we could get this strange behavior with `std::distance` too? Would > it be worth to handle that as well here?

[PATCH] D76366: [Syntax] Split syntax tests

hlopko updated this revision to Diff 251571. hlopko added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76366/new/ https://reviews.llvm.org/D76366 Files: clang/unittests/Tooling/Syntax/TreeTest.cpp Index:

[PATCH] D76366: [Syntax] Split syntax tests

This revision was automatically updated to reflect the committed changes. Closed by commit rGe9630630ffa2: [Syntax] Split syntax tests (authored by hlopko, committed by gribozavr). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76366/new/

[PATCH] D60748: Adds an option "malign-pass-aggregate" to make the alignment of the struct and union parameters compatible with the default gcc

LiuChen3 marked 3 inline comments as done. LiuChen3 added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:1559 + if (const auto *AT = QT->getAsArrayTypeUnsafe()) +TempAlignment = getContext().getTypeAlign(AT->getElementType()) / 8; +

[PATCH] D76433: [Syntax] Test both the default and windows target platforms in unittests

hlopko updated this revision to Diff 251576. hlopko added a comment. Refactored to run tests on both default and windows platforms. Opting out Templates test for now since it doesn't work with -fdelayed-template-parsing yet. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D76433: [Syntax] Test both the default and windows target platforms in unittests

gribozavr2 accepted this revision. gribozavr2 added inline comments. This revision is now accepted and ready to land. Comment at: clang/unittests/Tooling/Syntax/TreeTest.cpp:102 +std::vector Args = {"-target", Target.data(), +

[PATCH] D75360: [analyzer][NFC] Tie CheckerRegistry to CheckerManager, allow CheckerManager to be constructed for non-analysis purposes

baloghadamsoftware accepted this revision. baloghadamsoftware added a comment. This revision is now accepted and ready to land. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75360/new/ https://reviews.llvm.org/D75360 ___ cfe-commits

[clang] 9967352 - Revert "[Syntax] Test both the default and windows target platforms in unittests"

Author: Dmitri Gribenko Date: 2020-03-20T12:13:49+01:00 New Revision: 9967352a0346021d389afb6e3283d0c58911a560 URL: https://github.com/llvm/llvm-project/commit/9967352a0346021d389afb6e3283d0c58911a560 DIFF:

[clang] a4edea2 - Fix `-Wunused-variable` warning. NFC.

Author: Michael Liao Date: 2020-03-20T09:31:58-04:00 New Revision: a4edea29be2a77a8c8c237d75563a09a61791442 URL: https://github.com/llvm/llvm-project/commit/a4edea29be2a77a8c8c237d75563a09a61791442 DIFF: https://github.com/llvm/llvm-project/commit/a4edea29be2a77a8c8c237d75563a09a61791442.diff

[PATCH] D76296: [ARM,CDE] Implement GPR CDE intrinsics

MarkMurrayARM accepted this revision. MarkMurrayARM added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76296/new/ https://reviews.llvm.org/D76296 ___ cfe-commits mailing

[PATCH] D75903: [AArch64][CodeGen] Fixing stack alignment of HFA arguments on AArch64 PCS

pratlucas added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75903/new/ https://reviews.llvm.org/D75903 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D76433: [Syntax] Test both the default and windows target platforms in unittests

hlopko updated this revision to Diff 251582. hlopko marked 3 inline comments as done. hlopko added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76433/new/ https://reviews.llvm.org/D76433 Files:

[PATCH] D75904: [ARM][CodeGen] Fixing stack alignment of HFA arguments on AArch32 PCS

pratlucas added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75904/new/ https://reviews.llvm.org/D75904 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D76433: [Syntax] Test both the default and windows target platforms in unittests

hlopko updated this revision to Diff 251585. hlopko added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76433/new/ https://reviews.llvm.org/D76433 Files: clang/unittests/Tooling/Syntax/TreeTest.cpp Index:

[clang] fd7300f - [Syntax] Test both the default and windows target platforms in unittests

Author: Marcel Hlopko Date: 2020-03-20T11:42:18+01:00 New Revision: fd7300f717c18c861e77685efe6f16f12fb63ae7 URL: https://github.com/llvm/llvm-project/commit/fd7300f717c18c861e77685efe6f16f12fb63ae7 DIFF: https://github.com/llvm/llvm-project/commit/fd7300f717c18c861e77685efe6f16f12fb63ae7.diff

[PATCH] D74007: [clang] Add support for consteval constructors

This revision was automatically updated to reflect the committed changes. Closed by commit rG180581cfcf51: [clang] Add support for consteval constructors (authored by Tyker). Herald added a project: clang. Herald added a subscriber: cfe-commits. Changed prior to commit:

[PATCH] D76433: [Syntax] Test both the default and windows target platforms in unittests

thakis added a comment. Breaks tests on Windows: http://45.33.8.238/win/10881/step_7.txt Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76433/new/ https://reviews.llvm.org/D76433 ___ cfe-commits

[PATCH] D72446: [Syntax] Build mapping from AST to syntax tree nodes

hlopko added a comment. Taking over the patch in https://reviews.llvm.org/D76355. Comment at: clang/lib/Tooling/Syntax/BuildTree.cpp:147 + void add(ASTPtr From, syntax::Tree *To) { +assert(To != nullptr); + gribozavr2 wrote: > Also assert that From is not

[PATCH] D76355: [Syntax] Build mapping from AST to syntax tree nodes

hlopko updated this revision to Diff 251603. hlopko added a comment. Addressing comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76355/new/ https://reviews.llvm.org/D76355 Files: clang/include/clang/Tooling/Syntax/Tree.h

[PATCH] D76490: [ARM,MVE] Add ACLE intrinsics for the vminv/vmaxv family.

simon_tatham created this revision. simon_tatham added reviewers: dmgreen, MarkMurrayARM, miyuki, ostannard. Herald added subscribers: cfe-commits, hiraditya, kristof.beyls. Herald added a project: clang. I've implemented these as target-specific IR intrinsics, because they're not //quite//

[PATCH] D76078: [AArch64][SVE] Add a pass for SVE intrinsic optimisations

andwar added a comment. > Have you considered adding an interface for the new PM? Please ignore that comment ^^^. I incorrectly assumed that the backend has also been ported to the new PM, but that's not the case. In particular, `llc` will only use the legacy PM anyway:

[PATCH] D76491: [ARM,MVE] Add ACLE intrinsics for the vaddv/vaddlv family.

simon_tatham created this revision. simon_tatham added reviewers: dmgreen, MarkMurrayARM, miyuki, ostannard. Herald added subscribers: cfe-commits, danielkiss, hiraditya, kristof.beyls. Herald added a project: clang. I've implemented them as target-specific IR intrinsics rather than using

[clang] fcba7c3 - [OPENMP50]Initial support for scan directive.

Author: Alexey Bataev Date: 2020-03-20T07:58:15-04:00 New Revision: fcba7c3534f98851531095f8457eb3142e237f0b URL: https://github.com/llvm/llvm-project/commit/fcba7c3534f98851531095f8457eb3142e237f0b DIFF: https://github.com/llvm/llvm-project/commit/fcba7c3534f98851531095f8457eb3142e237f0b.diff

[PATCH] D76433: [Syntax] Test both the default and windows target platforms in unittests

This revision was automatically updated to reflect the committed changes. Closed by commit rGfd7300f717c1: [Syntax] Test both the default and windows target platforms in unittests (authored by hlopko, committed by gribozavr). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D75184: [clang-tidy] Optional inheritance of file configs from parent directories 

DmitryPolukhin added a comment. In D75184#1932764 , @alexfh wrote: > There's one more thing to consider: just by looking at the name of a local > option we don't know whether it will be read using `get()` or > `getLocalOrGlobal()`. By removing local

[PATCH] D76444: Use FinishThunk to finish musttail thunks

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76444/new/ https://reviews.llvm.org/D76444 ___

[PATCH] D76299: [ARM,CDE] Implement CDE unpredicated Q-register intrinsics

MarkMurrayARM accepted this revision. MarkMurrayARM added a comment. This revision is now accepted and ready to land. I like to use of the macros instead of a huge cross-product of types. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76299/new/ https://reviews.llvm.org/D76299

[PATCH] D76298: [ARM,CDE] Implement CDE S and D-register intrinsics

MarkMurrayARM accepted this revision. MarkMurrayARM added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76298/new/ https://reviews.llvm.org/D76298 ___ cfe-commits mailing

[PATCH] D76300: [ARM,CDE] Implement CDE vreinterpret intrinsics

MarkMurrayARM accepted this revision. MarkMurrayARM added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76300/new/ https://reviews.llvm.org/D76300

[clang] 180581c - [clang] Add support for consteval constructors

Author: Tyker Date: 2020-03-20T11:33:54+01:00 New Revision: 180581cfcf5115388caa3b8ee20eac1fd35f2d11 URL: https://github.com/llvm/llvm-project/commit/180581cfcf5115388caa3b8ee20eac1fd35f2d11 DIFF: https://github.com/llvm/llvm-project/commit/180581cfcf5115388caa3b8ee20eac1fd35f2d11.diff LOG:

[PATCH] D75591: [OpenMP] Add firstprivate as a default data-sharing attribute to clang

lebedev.ri requested changes to this revision. lebedev.ri added a comment. This revision now requires changes to proceed. In D75591#1904969 , @lebedev.ri wrote: > IIUC `default(firstprivate)` is being added in openmp-5.1, > it is not in openmp-4.5, so it

[PATCH] D76140: [InlineFunction] update attributes during inlining

anna marked an inline comment as done. anna added inline comments. Herald added a reviewer: aartbik. Comment at: llvm/lib/Transforms/Utils/InlineFunction.cpp:1172 +return true; +return false; + }; jdoerfert wrote: > `mayThrow` is not sufficient. As

[PATCH] D76140: [InlineFunction] update attributes during inlining

anna updated this revision to Diff 251615. anna added a comment. use isGuaranteedToTransferExecutionToSuccessor instead of `MayThrow` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76140/new/ https://reviews.llvm.org/D76140 Files:

[PATCH] D76296: [ARM,CDE] Implement GPR CDE intrinsics

This revision was automatically updated to reflect the committed changes. Closed by commit rG7a85e3585ec5: [ARM,CDE] Implement GPR CDE intrinsics (authored by miyuki). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76296/new/

[PATCH] D76300: [ARM,CDE] Implement CDE vreinterpret intrinsics

This revision was automatically updated to reflect the committed changes. Closed by commit rG6ae3eff8baac: [ARM,CDE] Implement CDE vreinterpret intrinsics (authored by miyuki). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76300/new/

[clang] 94061df - [analyzer] StdLibraryFunctionsChecker: Add argument constraints

Author: Gabor Marton Date: 2020-03-20T16:33:14+01:00 New Revision: 94061df6e5f24c2f25ad7c55af13dd175856 URL: https://github.com/llvm/llvm-project/commit/94061df6e5f24c2f25ad7c55af13dd175856 DIFF: https://github.com/llvm/llvm-project/commit/94061df6e5f24c2f25ad7c55af13dd175856.diff

[PATCH] D76497: [Syntax] Test both the default and windows target platforms in unittests

This revision was automatically updated to reflect the committed changes. Closed by commit rGeddede9d5184: [Syntax] Test both the default and windows target platforms in unittests (authored by hlopko, committed by gribozavr). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 7a85e35 - [ARM,CDE] Implement GPR CDE intrinsics

Author: Mikhail Maltsev Date: 2020-03-20T14:01:51Z New Revision: 7a85e3585ec59b1bfe3b08072ff042af80d07f22 URL: https://github.com/llvm/llvm-project/commit/7a85e3585ec59b1bfe3b08072ff042af80d07f22 DIFF: https://github.com/llvm/llvm-project/commit/7a85e3585ec59b1bfe3b08072ff042af80d07f22.diff

[clang] 969034b - [ARM, CDE] Implement CDE unpredicated Q-register intrinsics

Author: Mikhail Maltsev Date: 2020-03-20T14:01:56Z New Revision: 969034b86037d3c1daf725aef13ba16424f92fe1 URL: https://github.com/llvm/llvm-project/commit/969034b86037d3c1daf725aef13ba16424f92fe1 DIFF: https://github.com/llvm/llvm-project/commit/969034b86037d3c1daf725aef13ba16424f92fe1.diff

[clang] 6ae3eff - [ARM,CDE] Implement CDE vreinterpret intrinsics

Author: Mikhail Maltsev Date: 2020-03-20T14:01:57Z New Revision: 6ae3eff8baaca95752b1ec9732c605b3d4e8d630 URL: https://github.com/llvm/llvm-project/commit/6ae3eff8baaca95752b1ec9732c605b3d4e8d630 DIFF: https://github.com/llvm/llvm-project/commit/6ae3eff8baaca95752b1ec9732c605b3d4e8d630.diff

[PATCH] D73898: [analyzer] StdLibraryFunctionsChecker: Add argument constraints

This revision was automatically updated to reflect the committed changes. Closed by commit rG94061df6e5f2: [analyzer] StdLibraryFunctionsChecker: Add argument constraints (authored by martong). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D76504: [clang] Fix crash during template sema checking

gchatelet created this revision. gchatelet added reviewers: efriedma, courbet. Herald added a project: clang. Herald added a subscriber: cfe-commits. gchatelet added a subscriber: abrachet. gchatelet added a comment. Buggy trace here

[PATCH] D75661: Remove SequentialType from the type heirarchy.

ctetreau added inline comments. Herald added a reviewer: aartbik. Comment at: clang/lib/CodeGen/CGDecl.cpp:1059 +llvm::Type *ElemTy = ArrayTy->getElementType(); +bool ZeroInitializer = constant->isNullValue(); llvm::Constant *OpValue, *PaddedOp; I

[PATCH] D76504: [clang] Fix crash during template sema checking

gchatelet added a comment. Buggy trace here Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76504/new/ https://reviews.llvm.org/D76504

[PATCH] D73245: Depend stddef.h to provide max_align_t for C++11 and provide better fallback in

ldionne requested changes to this revision. ldionne added a comment. This revision now requires changes to proceed. I think the direction works, but I have questions about some thing I don't understand (mostly in the tests). Comment at: libcxx/include/stddef.h:58

[PATCH] D76323: [AST] Fix handling of long double and bool in __builtin_bit_cast

ldionne accepted this revision. ldionne added a comment. This revision is now accepted and ready to land. LGTM at high level, but I'm not really familiar with the code. Comment at: clang/lib/AST/ExprConstant.cpp:6365 +const llvm::fltSemantics =

[PATCH] D73898: [analyzer] StdLibraryFunctionsChecker: Add argument constraints

martong updated this revision to Diff 251648. martong marked an inline comment as done. martong added a comment. - Use prefixes for -verify to check different things in the same test file Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73898/new/

[PATCH] D76497: [Syntax] Test both the default and windows target platforms in unittests

hlopko updated this revision to Diff 251649. hlopko added a comment. .equals -> == :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76497/new/ https://reviews.llvm.org/D76497 Files: clang/unittests/Tooling/Syntax/TreeTest.cpp Index:

[PATCH] D76497: [Syntax] Test both the default and windows target platforms in unittests

hlopko updated this revision to Diff 251646. hlopko added a comment. Polish Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76497/new/ https://reviews.llvm.org/D76497 Files: clang/unittests/Tooling/Syntax/TreeTest.cpp Index:

[PATCH] D73898: [analyzer] StdLibraryFunctionsChecker: Add argument constraints

martong marked an inline comment as done. martong added a comment. Thanks for the review guys! Comment at: clang/test/Analysis/std-c-library-functions-arg-constraints.c:1-7 +// RUN: %clang_analyze_cc1 %s \ +// RUN: -analyzer-checker=core \ +// RUN:

[PATCH] D76491: [ARM,MVE] Add ACLE intrinsics for the vaddv/vaddlv family.

dmgreen accepted this revision. dmgreen added a comment. This revision is now accepted and ready to land. Sounds great, from what I can see. The predicated lowering looks useful when/if we try and get predicated vecreduce's working. We'll have to do the same for VMLA at some point. LGTM

[PATCH] D76238: [SveEmitter] Implement builtins for contiguous loads/stores

sdesmalen marked 4 inline comments as done. sdesmalen added inline comments. Comment at: clang/include/clang/Basic/arm_sve.td:128 def SVLD1 : MInst<"svld1[_{2}]", "dPc", "csilUcUsUiUlhfd", [IsLoad]>; +def SVLD1SB : MInst<"svld1sb_{d}", "dPS", "silUsUiUl", [IsLoad],

[clang] d22e661 - [ARM, CDE] Implement CDE S and D-register intrinsics

Author: Mikhail Maltsev Date: 2020-03-20T14:01:53Z New Revision: d22e66171251cd3dd07507912189aa814a419678 URL: https://github.com/llvm/llvm-project/commit/d22e66171251cd3dd07507912189aa814a419678 DIFF: https://github.com/llvm/llvm-project/commit/d22e66171251cd3dd07507912189aa814a419678.diff

[PATCH] D76299: [ARM,CDE] Implement CDE unpredicated Q-register intrinsics

This revision was automatically updated to reflect the committed changes. Closed by commit rG969034b86037: [ARM,CDE] Implement CDE unpredicated Q-register intrinsics (authored by miyuki). Changed prior to commit: https://reviews.llvm.org/D76299?vs=251039=251635#toc Repository: rG LLVM

[PATCH] D76298: [ARM,CDE] Implement CDE S and D-register intrinsics

This revision was automatically updated to reflect the committed changes. Closed by commit rGd22e66171251: [ARM,CDE] Implement CDE S and D-register intrinsics (authored by miyuki). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76298/new/

[PATCH] D76497: [Syntax] Test both the default and windows target platforms in unittests

hlopko created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This increases the coverage for things that differ between Linux and Windows, such as -fdelayed-template-parsing. This would have prevented the rollback of https://reviews.llvm.org/D76346.

[PATCH] D52898: [Porting MergeSimilarFunctions 2/n] Changes to DataLayout

vish99 updated this revision to Diff 251630. vish99 added a comment. Reverting back to diff 222348, the previous diff was against a wrong branch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D52898/new/ https://reviews.llvm.org/D52898 Files:

[PATCH] D76365: [cuda][hip] Add CUDA builtin surface/texture reference support.

hliao added a comment. In D76365#1932517 , @tra wrote: > In D76365#1932439 , @hliao wrote: > > > > > > > > > That's a magic. I could not figure out how it works. From its use, e.g. > > `tex2D` on `texture`, > > >

[PATCH] D76238: [SveEmitter] Implement builtins for contiguous loads/stores

SjoerdMeijer accepted this revision. SjoerdMeijer added a comment. This revision is now accepted and ready to land. Looks good to me. Please wait a day in case Eli has more comments. Comment at: clang/include/clang/Basic/arm_sve.td:128 def SVLD1 : MInst<"svld1[_{2}]",

[PATCH] D75851: [Analyzer][StreamChecker] Added evaluation of fseek.

balazske updated this revision to Diff 251640. balazske added a comment. Simplified code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75851/new/ https://reviews.llvm.org/D75851 Files: clang/lib/StaticAnalyzer/Checkers/StreamChecker.cpp

[clang] 45a9945 - [ARM, MVE] Add ACLE intrinsics for the vminv/vmaxv family.

Author: Simon Tatham Date: 2020-03-20T15:42:33Z New Revision: 45a9945b9ea95bd065d3c4e08d9089a309b24a23 URL: https://github.com/llvm/llvm-project/commit/45a9945b9ea95bd065d3c4e08d9089a309b24a23 DIFF: https://github.com/llvm/llvm-project/commit/45a9945b9ea95bd065d3c4e08d9089a309b24a23.diff LOG:

[PATCH] D76490: [ARM,MVE] Add ACLE intrinsics for the vminv/vmaxv family.

MarkMurrayARM accepted this revision. MarkMurrayARM added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76490/new/ https://reviews.llvm.org/D76490

[PATCH] D76496: [clang-tidy] StringFindStartswith should ignore 3-arg find()

niko created this revision. niko added a reviewer: hokein. Herald added subscribers: cfe-commits, xazax.hun. Herald added a project: clang. string::find() has a 3-argument version, with the third argument specifying the 'length of sequence of characters to match' (for a const char* 1st argument,

[PATCH] D76490: [ARM,MVE] Add ACLE intrinsics for the vminv/vmaxv family.

simon_tatham updated this revision to Diff 251626. simon_tatham added a comment. Update tests to fix CI failure (oops). Also added `opt -sroa` to make the incidental half/float argument marshalling a bit less verbose. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] eddede9 - [Syntax] Test both the default and windows target platforms in unittests

Author: Marcel Hlopko Date: 2020-03-20T16:33:58+01:00 New Revision: eddede9d5184a431c7f859ef1869f1a4de8d08d4 URL: https://github.com/llvm/llvm-project/commit/eddede9d5184a431c7f859ef1869f1a4de8d08d4 DIFF: https://github.com/llvm/llvm-project/commit/eddede9d5184a431c7f859ef1869f1a4de8d08d4.diff

[clang] 1adfa4c - [ARM, MVE] Add ACLE intrinsics for the vaddv/vaddlv family.

Author: Simon Tatham Date: 2020-03-20T15:42:33Z New Revision: 1adfa4c99169733dedb67b4f7ab03d2fbb196162 URL: https://github.com/llvm/llvm-project/commit/1adfa4c99169733dedb67b4f7ab03d2fbb196162 DIFF: https://github.com/llvm/llvm-project/commit/1adfa4c99169733dedb67b4f7ab03d2fbb196162.diff LOG:

[clang] ffcc076 - [[Clang CallGraph]] CallGraph should still record calls to decls.

Author: Erich Keane Date: 2020-03-20T08:55:23-07:00 New Revision: ffcc076a2b23363025de2f67243086963f235b20 URL: https://github.com/llvm/llvm-project/commit/ffcc076a2b23363025de2f67243086963f235b20 DIFF: https://github.com/llvm/llvm-project/commit/ffcc076a2b23363025de2f67243086963f235b20.diff

[PATCH] D76444: Use FinishThunk to finish musttail thunks

This revision was automatically updated to reflect the committed changes. Closed by commit rGce5173c0e174: Use FinishThunk to finish musttail thunks (authored by rnk). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76444/new/

[PATCH] D76509: [analyzer][NFC] Move the text output type to its own file, move code to PathDiagnosticConsumer creator functions

Szelethus marked an inline comment as done. Szelethus added inline comments. Comment at: clang/lib/StaticAnalyzer/Frontend/AnalysisConsumer.cpp:148 void DigestAnalyzerOptions() { -if (Opts->AnalysisDiagOpt != PD_NONE) { - // Create the PathDiagnosticConsumer. -

[PATCH] D73534: [DebugInfo] Enable the debug entry values feature by default

manojgupta added a comment. Still causing a crash using a previously supplied test https://bugs.chromium.org/p/chromium/issues/detail?id=1061533#c7. Any reason this was not tested with a previous repro? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73534/new/

[PATCH] D75661: Remove SequentialType from the type heirarchy.

efriedma marked 2 inline comments as done. efriedma added inline comments. Comment at: clang/lib/CodeGen/CGDecl.cpp:1059 +llvm::Type *ElemTy = ArrayTy->getElementType(); +bool ZeroInitializer = constant->isNullValue(); llvm::Constant *OpValue, *PaddedOp;

[PATCH] D76384: Move FPFeatures from BinaryOperator bitfields to Trailing storage

mibintc updated this revision to Diff 251699. mibintc retitled this revision from "Move FPFeatures from BinaryOperator bitfields to Trailing storage - preliminary" to "Move FPFeatures from BinaryOperator bitfields to Trailing storage". mibintc added a comment. This revision has been rebased,

[PATCH] D76377: Correctly initialize the DW_AT_comp_dir attribute of Clang module skeleton CUs

aprantl marked an inline comment as done. aprantl added inline comments. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:2499 +DIB.createFile(Mod.getModuleName(), TheCU->getDirectory()), +TheCU->getProducer(), false, StringRef(), 0, Mod.getASTFile(), +

[PATCH] D52898: [Porting MergeSimilarFunctions 2/n] Changes to DataLayout

vish99 updated this revision to Diff 251696. vish99 added a comment. Changes to merge the 5 patches together Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D52898/new/ https://reviews.llvm.org/D52898 Files:

[clang] ce5173c - Use FinishThunk to finish musttail thunks

Author: Reid Kleckner Date: 2020-03-20T09:02:21-07:00 New Revision: ce5173c0e174870934d1b3a026f631d996136191 URL: https://github.com/llvm/llvm-project/commit/ce5173c0e174870934d1b3a026f631d996136191 DIFF: https://github.com/llvm/llvm-project/commit/ce5173c0e174870934d1b3a026f631d996136191.diff

[PATCH] D76504: [clang] Fix crash during template sema checking

courbet added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:1655 +clang::Expr *SizeOp = TheCall->getArg(2); +// If any arg is instantiation dependent we bail out. +if (DstOp->isInstantiationDependent() || Are the first two necessary ?

[PATCH] D76361: [Analyzer] Iterator Modeling - Model `std::advance()`, `std::prev()` and `std::next()`

martong accepted this revision. martong added a comment. This revision is now accepted and ready to land. LGTM! Comment at: clang/lib/StaticAnalyzer/Checkers/IteratorModeling.cpp:221 +if (Handler) { + if (!C.wasInlined) { +if (Call.getNumArgs() > 1) {

[PATCH] D75063: [analyzer] StdLibraryFunctionsChecker: Add NotNull Arg Constraint

This revision was automatically updated to reflect the committed changes. Closed by commit rGededa65d559d: [analyzer] StdLibraryFunctionsChecker: Add NotNull Arg Constraint (authored by martong). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] ededa65 - [analyzer] StdLibraryFunctionsChecker: Add NotNull Arg Constraint

Author: Gabor Marton Date: 2020-03-20T17:34:29+01:00 New Revision: ededa65d559dac04ae50d3a33610875bb8f1a85e URL: https://github.com/llvm/llvm-project/commit/ededa65d559dac04ae50d3a33610875bb8f1a85e DIFF: https://github.com/llvm/llvm-project/commit/ededa65d559dac04ae50d3a33610875bb8f1a85e.diff

[PATCH] D76323: [AST] Fix handling of long double and bool in __builtin_bit_cast

jfb added a comment. Maybe you should test `nullptr` as well, given that it's all padding? Comment at: clang/test/SemaCXX/constexpr-builtin-bit-cast.cpp:407 + +constexpr bool test_bad_bool = bit_cast('A'); // expected-error {{must be initialized by a constant expression}}

[clang] f59bb40 - Attempt to fix failing build-bot with [-Werror,-Wcovered-switch-default]

Author: Gabor Marton Date: 2020-03-20T18:04:55+01:00 New Revision: f59bb40e361c061adaa19e988f1f5769d3b8fac7 URL: https://github.com/llvm/llvm-project/commit/f59bb40e361c061adaa19e988f1f5769d3b8fac7 DIFF: https://github.com/llvm/llvm-project/commit/f59bb40e361c061adaa19e988f1f5769d3b8fac7.diff

[PATCH] D76078: [AArch64][SVE] Add a pass for SVE intrinsic optimisations

kmclaughlin added a comment. Thanks for reviewing this, @efriedma & @andwar! Comment at: llvm/lib/Target/AArch64/AArch64TargetMachine.cpp:441 + // Expand any SVE vector library calls that we can't code generate directly. + bool ExpandToOptimize = (TM->getOptLevel() !=

[PATCH] D76490: [ARM,MVE] Add ACLE intrinsics for the vminv/vmaxv family.

This revision was automatically updated to reflect the committed changes. Closed by commit rG45a9945b9ea9: [ARM,MVE] Add ACLE intrinsics for the vminv/vmaxv family. (authored by simon_tatham). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76490/new/

[PATCH] D76491: [ARM,MVE] Add ACLE intrinsics for the vaddv/vaddlv family.

This revision was automatically updated to reflect the committed changes. Closed by commit rG1adfa4c99169: [ARM,MVE] Add ACLE intrinsics for the vaddv/vaddlv family. (authored by simon_tatham). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D76078: [AArch64][SVE] Add a pass for SVE intrinsic optimisations

kmclaughlin updated this revision to Diff 251643. kmclaughlin marked 13 inline comments as done. kmclaughlin added a comment. - Changed this from a function pass to a module pass & now check if any of the relevant SVE intrinsics are declared first before iterating over functions - Added more

[PATCH] D76435: [[Clang CallGraph]] CallGraph should still record calls to decls.

This revision was automatically updated to reflect the committed changes. Closed by commit rGffcc076a2b23: [[Clang CallGraph]] CallGraph should still record calls to decls. (authored by erichkeane). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM

[PATCH] D76509: [analyzer][NFC] Move the text output type to its own file, move code to PathDiagnosticConsumer creator functions

Szelethus created this revision. Szelethus added reviewers: NoQ, xazax.hun, baloghadamsoftware, martong, balazske, rnkovacs, dcoughlin, steakhal. Szelethus added a project: clang. Herald added subscribers: cfe-commits, ASDenysPetrov, usaxena95, Charusso, gamesh411, dkrupp, donat.nagy, kadircet,

[PATCH] D76510: [analyzer] Change the default output type to PD_TEXT_MINIMAL, error if an output loc is missing for PathDiagConsumers that need it

Szelethus created this revision. Szelethus added reviewers: NoQ, xazax.hun, baloghadamsoftware, rnkovacs, martong, balazske, dcoughlin. Szelethus added a project: clang. Herald added subscribers: cfe-commits, ASDenysPetrov, steakhal, Charusso, gamesh411, dkrupp, donat.nagy, mikhail.ramalho,

[PATCH] D75063: [analyzer] StdLibraryFunctionsChecker: Add NotNull Arg Constraint

martong updated this revision to Diff 251674. martong marked 9 inline comments as done. martong added a comment. - Use report/bugpath verify prefixes in test - Address review nits Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75063/new/

[PATCH] D76435: [[Clang CallGraph]] CallGraph should still record calls to decls.

lebedev.ri added a comment. Whoops, i did not see cfe-commits again got sidestepped. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76435/new/ https://reviews.llvm.org/D76435 ___ cfe-commits mailing

[PATCH] D76504: [clang] Fix crash during template sema checking

gchatelet updated this revision to Diff 251671. gchatelet marked an inline comment as done. gchatelet added a comment. Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76504/new/ https://reviews.llvm.org/D76504 Files:

[PATCH] D75063: [analyzer] StdLibraryFunctionsChecker: Add NotNull Arg Constraint

martong added a comment. In D75063#1923780 , @NoQ wrote: > This is basically a shorthand for "outside [0, 0]", right? I don't mind ^.^ Yeah, and my first attempt was exactly to implement this with ranges. However, it failed when I realized that we

[PATCH] D76504: [clang] Fix crash during template sema checking

gchatelet added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:1655 +clang::Expr *SizeOp = TheCall->getArg(2); +// If any arg is instantiation dependent we bail out. +if (DstOp->isInstantiationDependent() || courbet wrote: > Are the

[PATCH] D76377: Correctly initialize the DW_AT_comp_dir attribute of Clang module skeleton CUs

probinson added inline comments. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:2499 +DIB.createFile(Mod.getModuleName(), TheCU->getDirectory()), +TheCU->getProducer(), false, StringRef(), 0, Mod.getASTFile(), +llvm::DICompileUnit::FullDebug, Signature);

  1   2   >