[clang] afcb77c - [Analyzer] Fix for incorrect use of container and iterator checkers

Author: Adam Balogh Date: 2020-03-30T09:14:45+02:00 New Revision: afcb77cc88a2ed489bbd383774c54daa82340761 URL: https://github.com/llvm/llvm-project/commit/afcb77cc88a2ed489bbd383774c54daa82340761 DIFF: https://github.com/llvm/llvm-project/commit/afcb77cc88a2ed489bbd383774c54daa82340761.diff L

[clang] eb90692 - [Analyzer] Rename test `iterator-modelling.cpp` to `iterator-modeling.cpp`

Author: Adam Balogh Date: 2020-03-30T09:23:35+02:00 New Revision: eb90692d8a660bb3172c9c2cc5adb3864c626d96 URL: https://github.com/llvm/llvm-project/commit/eb90692d8a660bb3172c9c2cc5adb3864c626d96 DIFF: https://github.com/llvm/llvm-project/commit/eb90692d8a660bb3172c9c2cc5adb3864c626d96.diff L

[PATCH] D75171: [Analyzer] Fix for incorrect use of container and iterator checkers

This revision was automatically updated to reflect the committed changes. Closed by commit rGafcb77cc88a2: [Analyzer] Fix for incorrect use of container and iterator checkers (authored by baloghadamsoftware). Herald added a subscriber: ASDenysPetrov. Changed prior to commit: https://reviews.llv

[PATCH] D77037: [AST] Fix crashes on decltype(recovery-expr).

hokein created this revision. hokein added a reviewer: sammccall. Herald added a project: clang. We mark these decls as invalid. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D77037 Files: clang/include/clang/AST/DependenceFlags.h clang/include/clang/AST/Type.h clang/lib

[PATCH] D77039: [clang-format] Don't break multi block parameters on ObjCBreakBeforeNestedBlockParam

ghvg1313 created this revision. ghvg1313 added reviewers: jolesiak, benhamilton. Herald added a project: clang. Herald added a subscriber: cfe-commits. While the original diff makes a lot of sense, and multiple inline block parameter/trailing paramemter after inl

[PATCH] D76922: [Syntax] Remove delayed folding from tree building.

hlopko updated this revision to Diff 253517. hlopko added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76922/new/ https://reviews.llvm.org/D76922 Files: clang/lib/Tooling/Syntax/BuildTree.cpp clang/lib/Tooling/Syntax/Tokens.

[PATCH] D77041: [AST] Fix a crash on invalid constexpr Ctorinitializer when building RecoveryExpr.

hokein created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. hokein edited the summary of this revision. hokein added inline comments. hokein added a reviewer: sammccall. Comment at: clang/lib/Sema/SemaDecl.cpp:14359 +!ErrorsInCtorI

[PATCH] D76953: [AST] Fix a crash on invalid bitwidth exprs when preserving the recoveryexprs.

hokein updated this revision to Diff 253523. hokein marked 2 inline comments as done. hokein added a comment. address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76953/new/ https://reviews.llvm.org/D76953 Files: clang/lib/AST/ASTCont

[PATCH] D77041: [AST] Fix a crash on invalid constexpr Ctorinitializer when building RecoveryExpr.

hokein added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:14359 +!ErrorsInCtorInitializer && !CheckConstexprFunctionDefinition(FD, CheckConstexprKind::Diagnose)) FD->setInvalidDecl(); The crash is in `CheckConstexprFunctionDefi

[clang] dcc04e0 - [Analyzer][MallocChecker] No warning for kfree of ZERO_SIZE_PTR.

Author: Balázs Kéri Date: 2020-03-30T10:33:14+02:00 New Revision: dcc04e09cf6e36c6d2c47057a8f201f2c0784c69 URL: https://github.com/llvm/llvm-project/commit/dcc04e09cf6e36c6d2c47057a8f201f2c0784c69 DIFF: https://github.com/llvm/llvm-project/commit/dcc04e09cf6e36c6d2c47057a8f201f2c0784c69.diff L

[clang] f757ecb - [AST] Fix a crash on invalid bitwidth exprs when preserving the recoveryexprs.

Author: Haojian Wu Date: 2020-03-30T10:52:00+02:00 New Revision: f757ecbf85605735195441abefd9c291f5e317cc URL: https://github.com/llvm/llvm-project/commit/f757ecbf85605735195441abefd9c291f5e317cc DIFF: https://github.com/llvm/llvm-project/commit/f757ecbf85605735195441abefd9c291f5e317cc.diff LO

[PATCH] D76830: [Analyzer][MallocChecker] No warning for kfree of ZERO_SIZE_PTR.

This revision was automatically updated to reflect the committed changes. Closed by commit rGdcc04e09cf6e: [Analyzer][MallocChecker] No warning for kfree of ZERO_SIZE_PTR. (authored by balazske). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76830/ne

[PATCH] D76953: [AST] Fix a crash on invalid bitwidth exprs when preserving the recoveryexprs.

This revision was automatically updated to reflect the committed changes. Closed by commit rGf757ecbf8560: [AST] Fix a crash on invalid bitwidth exprs when preserving the recoveryexprs. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D77037: [AST] Fix crashes on decltype(recovery-expr).

sammccall added inline comments. Comment at: clang/include/clang/AST/Type.h:2144 + bool isErrorType() const { +return getDependence() & TypeDependence::Error; + } Why is this called `isErrorType` when the expr version is `containsErrors`? ===

[PATCH] D77012: [analyzer] Fix StdLibraryFunctionsChecker NotNull Constraint Check

martong accepted this revision. martong added a comment. LGTM and thanks! In D77012#1948550 , @NoQ wrote: > Thanks! > > @Szelethus can we make this checker depend on undefined value checker > (probably CallAndMessage) so that uninitialized arguments were

[PATCH] D75068: libclang: Add static build support for Windows

cristian.adam added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75068/new/ https://reviews.llvm.org/D75068 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.o

[PATCH] D77037: [AST] Fix crashes on decltype(recovery-expr).

hokein updated this revision to Diff 253537. hokein marked 3 inline comments as done. hokein added a comment. address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77037/new/ https://reviews.llvm.org/D77037 Files: clang/include/

[PATCH] D77037: [AST] Fix crashes on decltype(recovery-expr).

hokein added inline comments. Comment at: clang/lib/Parse/ParseExprCXX.cpp:3109 +QualType PreferredType; +if (TypeRep) + PreferredType = Actions.ProduceConstructorSignatureHelp( sammccall wrote: > Add a comment for what the null case mean

[PATCH] D77041: [AST] Fix a crash on invalid constexpr Ctorinitializer when building RecoveryExpr.

sammccall added a comment. This makes me nervous, marking the constructor as invalid seems much safer. Can you show tests it regresses? Comment at: clang/lib/Sema/SemaDecl.cpp:14359 +!ErrorsInCtorInitializer && !CheckConstexprFunctionDefinition(FD, CheckConste

[PATCH] D77048: [Clang][CodeGen] Fixing mismatch between memory layout and const expressions for oversized bitfields

pratlucas created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The construction of constants for structs/unions was conflicting the expected memory layout for over-sized bit-fields. When building the necessary bits for those fields, clang was ignoring the s

[PATCH] D77037: [AST] Fix crashes on decltype(recovery-expr).

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Parse/ParseExprCXX.cpp:3109 +QualType PreferredType; +if (TypeRep) + PreferredType = Actions.ProduceConstructorSignat

[clang] 0574030 - [clang-format] only parse C# generic type constraints in C#

Author: Krasimir Georgiev Date: 2020-03-30T13:13:07+02:00 New Revision: 0574030c01615d4ce26de0d9b0d64292ab3eac9b URL: https://github.com/llvm/llvm-project/commit/0574030c01615d4ce26de0d9b0d64292ab3eac9b DIFF: https://github.com/llvm/llvm-project/commit/0574030c01615d4ce26de0d9b0d64292ab3eac9b.d

[PATCH] D76725: [clangd] Build ASTs only with fresh preambles or after building a new preamble

kadircet updated this revision to Diff 253552. kadircet added a comment. - Make use of a separate queue for golden ASTs to prevent any races that might occur due PreambleThread finishing multiple preambles before ASTWorker gets to process others. Repository: rG LLVM Github Monorepo CHANGES S

[PATCH] D76594: [clang][AST] Support AST files larger than 512M

sammccall added inline comments. Comment at: clang/include/clang/Serialization/ASTBitCodes.h:220 /// Source range/offset of a preprocessed entity. struct DeclOffset { + /// Raw source location. The unsigned i.e. 32-bit integer is enough for Is ther

[PATCH] D76725: [clangd] Build ASTs only with fresh preambles or after building a new preamble

kadircet updated this revision to Diff 253556. kadircet added a comment. - Add assertion to explicitly spell out scheduling for golden ASTs. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76725/new/ https://reviews.llvm.org/D76725 Files: clang-to

[PATCH] D75364: [clang-format] Handle macros in function params and return value

tamas.petz added a comment. Friendly ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75364/new/ https://reviews.llvm.org/D75364 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-

[PATCH] D75914: systemz: allow configuring default CLANG_SYSTEMZ_ARCH

This revision was automatically updated to reflect the committed changes. Closed by commit rG9c9d88d8b1bb: [SystemZ] Allow configuring default CLANG_SYSTEMZ_ARCH (authored by uweigand). Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION http

[clang] 9c9d88d - [SystemZ] Allow configuring default CLANG_SYSTEMZ_ARCH

Author: Ulrich Weigand Date: 2020-03-30T14:20:48+02:00 New Revision: 9c9d88d8b1bb6468f6c4258fe41bbcd01f742801 URL: https://github.com/llvm/llvm-project/commit/9c9d88d8b1bb6468f6c4258fe41bbcd01f742801 DIFF: https://github.com/llvm/llvm-project/commit/9c9d88d8b1bb6468f6c4258fe41bbcd01f742801.diff

[PATCH] D77053: [Syntax] A tool to dump syntax tree and token buffer

hlopko created this revision. Herald added subscribers: cfe-commits, mgorny. Herald added a project: clang. hlopko updated this revision to Diff 253561. hlopko added a comment. hlopko updated this revision to Diff 253562. hlopko added a reviewer: gribozavr2. hlopko edited the summary of this revisi

[PATCH] D77053: [Syntax] A tool to dump syntax tree and token buffer

hlopko updated this revision to Diff 253562. hlopko added a comment. Cleanup Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77053/new/ https://reviews.llvm.org/D77053 Files: clang/test/CMakeLists.txt clang/test/clang-syntax/no_args.cpp clang/

[PATCH] D75181: [AArch64] Handle BTI/PAC in case of generated functions.

danielkiss added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75181/new/ https://reviews.llvm.org/D75181 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D77053: [Syntax] A tool to dump syntax tree and token buffer

hlopko updated this revision to Diff 253561. hlopko added a comment. Cleanup Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77053/new/ https://reviews.llvm.org/D77053 Files: clang/test/CMakeLists.txt clang/test/clang-syntax/no_args.cpp clang/

[PATCH] D77037: [AST] Fix crashes on decltype(recovery-expr).

hokein updated this revision to Diff 253567. hokein marked 4 inline comments as done. hokein added a comment. address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77037/new/ https://reviews.llvm.org/D77037 Files: clang/include/clang/A

[PATCH] D75914: systemz: allow configuring default CLANG_SYSTEMZ_ARCH

Hahnfeld added inline comments. Comment at: clang/CMakeLists.txt:311 + "SystemZ Default Arch") +add_definitions( -DCLANG_SYSTEMZ_DEFAULT_ARCH="${CLANG_SYSTEMZ_DEFAULT_ARCH}") + Passing values like this is unusual for CMake and causes all source files to be reco

[PATCH] D77048: [Clang][CodeGen] Fixing mismatch between memory layout and const expressions for oversized bitfields

pratlucas updated this revision to Diff 253568. pratlucas added a comment. Formatting. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77048/new/ https://reviews.llvm.org/D77048 Files: clang/lib/CodeGen/CGExprConstant.cpp clang/test/CodeGenCXX/b

[PATCH] D77037: [AST] Fix crashes on decltype(recovery-expr).

hokein added inline comments. Comment at: clang/lib/Parse/ParseExprCXX.cpp:3109 +QualType PreferredType; +if (TypeRep) + PreferredType = Actions.ProduceConstructorSignatureHelp( sammccall wrote: > hokein wrote: > > sammccall wrote: > > >

[clang] 6f428e0 - [AST] Fix crashes on decltype(recovery-expr).

Author: Haojian Wu Date: 2020-03-30T14:56:33+02:00 New Revision: 6f428e09fbe8ce7e3510ae024031a5fc19653483 URL: https://github.com/llvm/llvm-project/commit/6f428e09fbe8ce7e3510ae024031a5fc19653483 DIFF: https://github.com/llvm/llvm-project/commit/6f428e09fbe8ce7e3510ae024031a5fc19653483.diff LO

[PATCH] D77037: [AST] Fix crashes on decltype(recovery-expr).

This revision was automatically updated to reflect the committed changes. Closed by commit rG6f428e09fbe8: [AST] Fix crashes on decltype(recovery-expr). (authored by hokein). Changed prior to commit: https://reviews.llvm.org/D77037?vs=253567&id=253581#toc Repository: rG LLVM Github Monorepo

[PATCH] D76932: [AIX] emit .extern and .weak directive linkage

DiggerLin updated this revision to Diff 253579. DiggerLin added a comment. delete -u from clang test case aix-as.c Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76932/new/ https://reviews.llvm.org/D76932 Files: clang/lib/Driver/ToolChains/AIX.cp

[PATCH] D75914: systemz: allow configuring default CLANG_SYSTEMZ_ARCH

uweigand added a comment. Ah, good point. Dimitry, can you prepare an updated patch to implement Jonas' suggestion? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75914/new/ https://reviews.llvm.org/D75914 __

[PATCH] D77054: [AArch64][SVE] Add SVE intrinsics for saturating add & subtract

kmclaughlin created this revision. kmclaughlin added reviewers: sdesmalen, c-rhodes, dancgr, efriedma, cameron.mcinally. Herald added subscribers: danielkiss, psnobl, rkruppe, hiraditya, kristof.beyls, tschuett. Herald added a reviewer: rengolin. Herald added a project: LLVM. Adds the following

[clang] 7ac9efb - [OPENMP50]Add basic support for array-shaping operation.

Author: Alexey Bataev Date: 2020-03-30T09:18:24-04:00 New Revision: 7ac9efb0c322bacd4f09e6aed82466116b685892 URL: https://github.com/llvm/llvm-project/commit/7ac9efb0c322bacd4f09e6aed82466116b685892 DIFF: https://github.com/llvm/llvm-project/commit/7ac9efb0c322bacd4f09e6aed82466116b685892.diff

[PATCH] D76432: [clangd] Add a tweak for adding "using" statement.

adamcz updated this revision to Diff 253583. adamcz marked 10 inline comments as done. adamcz added a comment. review round 2 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76432/new/ https://reviews.llvm.org/D76432 Files: clang-tools-extra/clang

[PATCH] D76932: [AIX] emit .extern and .weak directive linkage

DiggerLin marked an inline comment as done. DiggerLin added inline comments. Comment at: llvm/include/llvm/MC/MCDirectives.h:47 + MCSA_WeakReference, ///< .weak_reference (MachO) + MCSA_WeakDefAutoPrivate ///< .weak_def_can_be_hidden (MachO) };

[PATCH] D74144: [OPENMP50]Add basic support for array-shaping operation.

This revision was automatically updated to reflect the committed changes. Closed by commit rG7ac9efb0c322: [OPENMP50]Add basic support for array-shaping operation. (authored by ABataev). Changed prior to commit: https://reviews.llvm.org/D74144?vs=252859&id=253584#toc Repository: rG LLVM Gith

[PATCH] D76996: [analyzer] Improve PlacementNewChecker

martong added a comment. Wohoow! I am impressed, this is really nice work, I like it! :) Could not find any glitch, looks good from my side once you address NoQ's concerns. Comment at: clang/lib/StaticAnalyzer/Checkers/CheckPlacementNew.cpp:125 +Msg = std::string(llvm:

[PATCH] D77053: [Syntax] A tool to dump syntax tree and token buffer

hlopko abandoned this revision. hlopko added a comment. Talked to gribozavr2 offline and decided to abandon this patch. If in the future we'll have a need for a tool to dump syntax trees, we'll probably implement it in clang behind hidden options, and we'll provide a json output format as well.

[PATCH] D76432: [clangd] Add a tweak for adding "using" statement.

adamcz added inline comments. Comment at: clang-tools-extra/clangd/refactor/tweaks/AddUsing.cpp:89 + + // If we're looking at a type or NestedNameSpecifier, walk up the tree until + // we find the "main" node we care about, which would be ElaboratedTypeLoc or s

[clang] 703a1b8 - [analyzer][MallocChecker][NFC] Split checkPostCall up, deploy CallDescriptionMap

Author: Louis Dionne Date: 2020-03-30T16:01:58+02:00 New Revision: 703a1b8caf09a5262a45c2179b8131922f71cf25 URL: https://github.com/llvm/llvm-project/commit/703a1b8caf09a5262a45c2179b8131922f71cf25 DIFF: https://github.com/llvm/llvm-project/commit/703a1b8caf09a5262a45c2179b8131922f71cf25.diff

[PATCH] D77056: RFC: [Sema][SVE] Allow non-member operators for SVE types

rsandifo-arm created this revision. rsandifo-arm added reviewers: sdesmalen, efriedma, rovka, rjmccall. Herald added subscribers: cfe-commits, danielkiss, psnobl, rkruppe, kristof.beyls, tschuett. Herald added a reviewer: rengolin. Herald added a project: clang. rsandifo-arm edited the summary of

[PATCH] D76496: [clang-tidy] StringFindStartswith should ignore 3-arg find()

niko added a comment. In D76496#1947127 , @njames93 wrote: > In D76496#1947059 , @niko wrote: > > > In D76496#1935127 , @njames93 > > wrote: > > > > > I'm not hugely familia

[PATCH] D75682: [Analyzer][StreamChecker] Introduction of stream error handling.

balazske updated this revision to Diff 253587. balazske added a comment. Added test checker. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75682/new/ https://reviews.llvm.org/D75682 Files: clang/include/clang/StaticAnalyzer/Checkers/Checkers.td

[PATCH] D76922: [Syntax] Remove delayed folding from tree building.

gribozavr2 accepted this revision. gribozavr2 added a comment. This revision is now accepted and ready to land. Could you add the following tests? struct Point { int x, y; } point, *pointPtr; typedef struct Point { int x, y; } PointTy, *PointPtr; typedef struct { int x, y; } PointTy, *Point

[PATCH] D77058: [Clang] Add llvm.loop.unroll.disable to loops with -fno-unroll-loops.

fhahn created this revision. fhahn added reviewers: Meinersbur, hfinkel, dexonsmith, tejohnson. Herald added a subscriber: zzheng. Herald added a project: clang. Currently Clang does not respect -fno-unroll-loops during LTO. During D76916 it was suggested to respe

[PATCH] D77012: [analyzer] Fix StdLibraryFunctionsChecker NotNull Constraint Check

Szelethus added a comment. In D77012#1948550 , @NoQ wrote: > @Szelethus can we make this checker depend on undefined value checker > (probably CallAndMessage) so that uninitialized arguments were handled first? I'll drop some pointers to previous disc

[PATCH] D77012: [analyzer] Fix StdLibraryFunctionsChecker NotNull Constraint Check

Szelethus accepted this revision. Szelethus added a comment. Oh, yea, LGTM! Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77012/new/ https://reviews.llvm.org/D77012 ___ cfe-commits mailing list

[PATCH] D68165: [analyzer][MallocChecker][NFC] Split checkPostCall up, deploy CallDescriptionMap

This revision was automatically updated to reflect the committed changes. Szelethus marked 5 inline comments as done. Closed by commit rG703a1b8caf09: [analyzer][MallocChecker][NFC] Split checkPostCall up, deploy CallDescriptionMap (authored by ldionne, committed by Szelethus). Herald added a sub

[clang] 7899a11 - Revert "[Darwin] Respect -fno-unroll-loops during LTO."

Author: Florian Hahn Date: 2020-03-30T15:20:30+01:00 New Revision: 7899a111ea1160e2ae0aae42de37b14a0b75d71b URL: https://github.com/llvm/llvm-project/commit/7899a111ea1160e2ae0aae42de37b14a0b75d71b DIFF: https://github.com/llvm/llvm-project/commit/7899a111ea1160e2ae0aae42de37b14a0b75d71b.diff

[PATCH] D76790: [analyzer] StdLibraryFunctionsChecker: fix bug with arg constraints

martong updated this revision to Diff 253595. martong added a comment. - Test multiple constraints on the same arg Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76790/new/ https://reviews.llvm.org/D76790 Files: clang/include/clang/StaticAnalyzer

[PATCH] D76916: [Darwin] Respect -fno-unroll-loops during LTO.

fhahn marked an inline comment as done. fhahn added a comment. Thanks for taking a look @dexonsmith! In D76916#1947324 , @dexonsmith wrote: > @fhahn, please revert, this isn't how we usually pass options in LTO. Reverted in 7899a111ea1160e2ae0aae42de37b

[PATCH] D76360: [PPC][AIX] Emit correct Vaarg for 32BIT-AIX in clang

jasonliu added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:10019 + return SetCGInfo( + new PPCAIX32TargetCodeGenInfo(Types, CodeGenOpts.FloatABI == "soft")); return SetCGInfo( Does AIX have soft Float? If not, do we want to a

[PATCH] D76211: OpenMP Metadirective with user defined condition

jdoerfert added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:5801 +Expr *expr = whenClause->getExpr(); +Stmt *stmt = NULL; + Style: start names with upper case letter. Comment at: clang/lib/Sema/SemaOpenMP.cpp:5817 +

[PATCH] D68165: [analyzer][MallocChecker][NFC] Split checkPostCall up, deploy CallDescriptionMap

ldionne added a comment. > Closed by commit rG703a1b8caf09 > : > [analyzer][MallocChecker][NFC] Split checkPostCall up, deploy > CallDescriptionMap (authored by ldionne, committed by Szelethus). · Explain > Why This is reall

[PATCH] D77061: [analyzer] Add core.CallAndMessage to StdCLibraryFunctionArgsChecker's dependency

martong created this revision. martong added reviewers: Szelethus, NoQ. Herald added subscribers: cfe-commits, ASDenysPetrov, steakhal, Charusso, gamesh411, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun, whisperity. Herald added a project: clang.

[PATCH] D77061: [analyzer] Add core.CallAndMessage to StdCLibraryFunctionArgsChecker's dependency

Szelethus accepted this revision. Szelethus added a comment. This revision is now accepted and ready to land. LGTM! It would be great if we could separate the modeling portions of the `CallAndMessage` checker out, but hey, there are only so many hours in each day :^) Repository: rG LLVM Gith

[PATCH] D77058: [Clang] Add llvm.loop.unroll.disable to loops with -fno-unroll-loops.

tejohnson added a comment. I think this is a good approach, rather than a per-function attribute, since as mentioned this will be preserved through inlining. @dexonsmith, does that seem reasonable to you? I missed the original patch and agree with you that we don't want to fix this in LTO by pas

[PATCH] D77063: [WIP][clangd] Dont block for preamble builds

kadircet created this revision. Herald added subscribers: cfe-commits, usaxena95, jfb, arphaman, jkorous, MaskRay, javed.absar, ilya-biryukov. Herald added a project: clang. kadircet added a parent revision: D76725: [clangd] Build ASTs only with fresh preambles or after building a new preamble. k

[PATCH] D77013: [AMDGPU] Add options -mamdgpu-ieee -mno-amdgpu-ieee

arsenm added inline comments. Comment at: clang/include/clang/Basic/CodeGenOptions.def:399 +/// Whether to emit IEEE754-2008 NaN compliant instructions if available (AMDGPU Only) +CODEGENOPT(EmitIEEENaNCompliantInsts, 1, 1) Description is misleading. Better de

[PATCH] D77013: [AMDGPU] Add options -mamdgpu-ieee -mno-amdgpu-ieee

arsenm added inline comments. Comment at: clang/test/CodeGenOpenCL/amdgpu-ieee.cl:20 +} + +// ON-NOT: attributes [[ATTRS]] = {{.*}} "amdgpu-ieee" arsenm wrote: > Should also test a non-kernel function I think we should also have some ISA check run lines that show

[PATCH] D77063: [WIP][clangd] Dont block for preamble builds

kadircet added a comment. This requires patched-up ASTs and getting rid of consistent preamble needs first. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77063/new/ https://reviews.llvm.org/D77063 ___

[PATCH] D77064: [clang-format] Correct line breaks in C# generic type constraints

jbcoe created this revision. jbcoe added a reviewer: krasimir. jbcoe added a project: clang-format. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D77064 Files: clang/lib/Format/TokenAnnotator.cpp clang/li

[clang] 1a1bb87 - [analyzer] Add core.CallAndMessage to StdCLibraryFunctionArgsChecker's dependency

Author: Gabor Marton Date: 2020-03-30T17:57:15+02:00 New Revision: 1a1bb876dba41066f6e9a273c24fad04e0f9f2da URL: https://github.com/llvm/llvm-project/commit/1a1bb876dba41066f6e9a273c24fad04e0f9f2da DIFF: https://github.com/llvm/llvm-project/commit/1a1bb876dba41066f6e9a273c24fad04e0f9f2da.diff

[PATCH] D76937: Fix infinite recursion in deferred diagnostic emitter

rjmccall added a comment. Can you explain what exactly the emission/semantic model is for variables? Normal code-generation absolutely triggers the emission of many variables lazily (e.g. internal-linkage globals, C++ inline variables); and any variable that's *not* being emitted lazily actual

[PATCH] D77066: [analyzer] ApiModeling: Add buffer size arg constraint

martong created this revision. martong added reviewers: NoQ, Szelethus, Charusso, steakhal. Herald added subscribers: cfe-commits, ASDenysPetrov, gamesh411, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun, whisperity. Herald added a project: clang.

[PATCH] D77013: [AMDGPU] Add options -mamdgpu-ieee -mno-amdgpu-ieee

yaxunl planned changes to this revision. yaxunl added a comment. This patch is put on hold due to some concerns. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77013/new/ https://reviews.llvm.org/D77013 ___ cfe-commits mailing list cfe-commi

[PATCH] D77068: [XCore] fix crash on unused inline in EmitTargetMetadata

nigelp-xmos created this revision. nigelp-xmos added a reviewer: rsmith. nigelp-xmos added a project: clang. EmitTargetMetadata passes to emitTargetMD a null pointer as returned from GetGlobalValue for an unused inline function which has been removed from the module at that point. Richard Smith

[PATCH] D77061: [analyzer] Add core.CallAndMessage to StdCLibraryFunctionArgsChecker's dependency

This revision was automatically updated to reflect the committed changes. Closed by commit rG1a1bb876dba4: [analyzer] Add core.CallAndMessage to StdCLibraryFunctionArgsChecker's… (authored by martong). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77

[PATCH] D74387: [SYCL] Defer __float128 type usage diagnostics

Fznamznon added inline comments. Comment at: clang/include/clang/Sema/Sema.h:12248 + /// SYCLDiagIfDeviceCode(Loc, diag::err_type_unsupported) << "__float128"; + DeviceDiagBuilder SYCLDiagIfDeviceCode(SourceLocation Loc, unsigned DiagID); + rjmccall wrote: >

[PATCH] D74387: [SYCL] Defer __float128 type usage diagnostics

Fznamznon updated this revision to Diff 253615. Fznamznon added a comment. Herald added a reviewer: jdoerfert. Rebased to fresh version. Applied fixes after https://reviews.llvm.org/D70172 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74387/new/ ht

[PATCH] D77070: [SemaObjC] Add a warning for declarations of BOOL:1 when BOOL is a signed char

erik.pilkington created this revision. erik.pilkington added reviewers: rjmccall, steven_wu. Herald added subscribers: ributzka, dexonsmith, jkorous. Instead, recommend using a real boolean type. Its possible to get away with BOOL:1, if you only read from it in a context where its contextually co

[PATCH] D68165: [analyzer][MallocChecker][NFC] Split checkPostCall up, deploy CallDescriptionMap

NoQ added a comment. **`$ git show --pretty=full 703a1b8caf09`** commit 703a1b8caf09a5262a45c2179b8131922f71cf25 Author: Louis Dionne Commit: Kirstóf Umann [analyzer][MallocChecker][NFC] Split checkPostCall up, deploy CallDescriptionMap ... Not a phabricator bug. Maybe

[PATCH] D76365: [cuda][hip] Add CUDA builtin surface/texture reference support.

tra added a comment. In D76365#1947479 , @hliao wrote: > Nice! I'll file a bug with NVIDIA. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76365/new/ https://reviews.llvm.org/D76365

[PATCH] D76887: AMDGPU: Make HIPToolChain a subclass of ROCMToolChain

yaxunl accepted this revision. yaxunl added a comment. This revision is now accepted and ready to land. LGTM. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76887/new/ https://reviews.llvm.org/D76887 ___ cfe-commits mailing list cfe-

[PATCH] D75951: Keep a list of already-included pragma-once files for mods.

oontvoo updated this revision to Diff 253623. oontvoo added a comment. Rebaase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75951/new/ https://reviews.llvm.org/D75951 Files: clang/include/clang/Lex/HeaderSearch.h clang/include/clang/Lex/Prepr

[PATCH] D77074: [FPEnv][AArch64] Platform-specific builtin constrained FP enablement

kpn marked 3 inline comments as done. kpn added a comment. Note that the AArch64 backend isn't ready for some of these changes. That's why the test is marked XFAIL. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:5706 +Function *F; +//exit(2); // XXX +if (Builder.getIs

[PATCH] D76996: [analyzer] Improve PlacementNewChecker

f00kat updated this revision to Diff 253628. f00kat marked 3 inline comments as done. f00kat added a comment. 1. Removed code and tests for ConcreteInt cases 2. Fixed FieldRegion check 3. Added handling for ElementRegion cases such as void f7() { short b[10]; // ok. 2(short align) +

[clang] 81194bf - [Hexagon] MaxAtomicPromoteWidth and MaxAtomicInlineWidth are not getting set.

Author: Sid Manning Date: 2020-03-30T12:33:51-05:00 New Revision: 81194bfeea7b40b6e8c543bb4ae49b59f590475b URL: https://github.com/llvm/llvm-project/commit/81194bfeea7b40b6e8c543bb4ae49b59f590475b DIFF: https://github.com/llvm/llvm-project/commit/81194bfeea7b40b6e8c543bb4ae49b59f590475b.diff L

[clang] 7842e7e - [OPENMP50]Add codegen support for array shaping expression in depend

Author: Alexey Bataev Date: 2020-03-30T13:37:21-04:00 New Revision: 7842e7ebbf3b68ebe52592d51aaf7a20f94d047b URL: https://github.com/llvm/llvm-project/commit/7842e7ebbf3b68ebe52592d51aaf7a20f94d047b DIFF: https://github.com/llvm/llvm-project/commit/7842e7ebbf3b68ebe52592d51aaf7a20f94d047b.diff

[PATCH] D77056: RFC: [Sema][SVE] Allow non-member operators for SVE types

efriedma added a comment. I'm concerned we're going to run into trouble if two people define different SVE "libraries", and you try to link both of them into the same program. If you're not careful, you end up with ODR violations. The scope of this is sort of restricted in normal C++: class a

[PATCH] D68165: [analyzer][MallocChecker][NFC] Split checkPostCall up, deploy CallDescriptionMap

Szelethus added a comment. In D68165#1949954 , @ldionne wrote: > > Closed by commit rG703a1b8caf09 > > : > > [analyzer][MallocChecker][NFC] Split checkPostCall up, deploy > > CallDescr

[PATCH] D76987: Rename options --cuda-gpu-arch and --no-cuda-gpu-arch

gregrodgers added a comment. This was discussed on llvm-dev three years ago. Here is the thread. http://lists.llvm.org/pipermail/llvm-dev/2017-February/109930.html The last name discussed was "-- offload-arch". I don't believe we need a list option anymore. So ignore the very old request f

[PATCH] D76546: [Hexagon] MaxAtomicPromoteWidth, MaxAtomicInlineWidth are not getting set.

This revision was automatically updated to reflect the committed changes. Closed by commit rG81194bfeea7b: [Hexagon] MaxAtomicPromoteWidth and MaxAtomicInlineWidth are not getting set. (authored by sidneym). Changed prior to commit: https://reviews.llvm.org/D76546?vs=251896&id=253640#toc Repos

[clang] c506adc - Move CLANG_SYSTEMZ_DEFAULT_ARCH to config.h.

Author: Nico Weber Date: 2020-03-30T14:16:17-04:00 New Revision: c506adcdf2ca3ba6459e52e09c55868e3b57af46 URL: https://github.com/llvm/llvm-project/commit/c506adcdf2ca3ba6459e52e09c55868e3b57af46 DIFF: https://github.com/llvm/llvm-project/commit/c506adcdf2ca3ba6459e52e09c55868e3b57af46.diff LO

[PATCH] D77022: [analyzer] Use IgnoreImpCasts() instead of reimplementing it.

thakis marked an inline comment as done. thakis added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/NullabilityChecker.cpp:512 + return E->IgnoreImpCasts(); } NoQ wrote: > Charusso wrote: > > I think it would make sense to remove the helper-f

[PATCH] D75914: systemz: allow configuring default CLANG_SYSTEMZ_ARCH

thakis added inline comments. Comment at: clang/CMakeLists.txt:311 + "SystemZ Default Arch") +add_definitions( -DCLANG_SYSTEMZ_DEFAULT_ARCH="${CLANG_SYSTEMZ_DEFAULT_ARCH}") + Hahnfeld wrote: > Passing values like this is unusual for CMake and causes all source f

[PATCH] D76996: [analyzer] Improve PlacementNewChecker

f00kat updated this revision to Diff 253642. f00kat marked an inline comment as done. f00kat added a comment. test fix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76996/new/ https://reviews.llvm.org/D76996 Files: clang/lib/StaticAnalyzer/Check

[PATCH] D76932: [AIX] emit .extern and .weak directive linkage

hubert.reinterpretcast added inline comments. Comment at: llvm/include/llvm/MC/MCDirectives.h:47 + MCSA_WeakReference, ///< .weak_reference (MachO) + MCSA_WeakDefAutoPrivate ///< .weak_def_can_be_hidden (MachO) }; DiggerLin wrote: > @hubert.rei

[PATCH] D75914: systemz: allow configuring default CLANG_SYSTEMZ_ARCH

thakis added inline comments. Comment at: clang/CMakeLists.txt:311 + "SystemZ Default Arch") +add_definitions( -DCLANG_SYSTEMZ_DEFAULT_ARCH="${CLANG_SYSTEMZ_DEFAULT_ARCH}") + thakis wrote: > thakis wrote: > > Hahnfeld wrote: > > > Passing values like this is unu

[PATCH] D75914: systemz: allow configuring default CLANG_SYSTEMZ_ARCH

thakis added inline comments. Comment at: clang/CMakeLists.txt:311 + "SystemZ Default Arch") +add_definitions( -DCLANG_SYSTEMZ_DEFAULT_ARCH="${CLANG_SYSTEMZ_DEFAULT_ARCH}") + thakis wrote: > Hahnfeld wrote: > > Passing values like this is unusual for CMake and c

[PATCH] D76140: [InlineFunction] update attributes during inlining

reames accepted this revision. reames added a comment. This revision is now accepted and ready to land. LGTM, but with two specific required follow ups. If you're not comfortable committing to both, please don't land this one. Comment at: llvm/lib/Transforms/Utils/InlineFunct

  1   2   >