[clang-tools-extra] 9e1af17 - [OpenMP][FIX] Add missing cmake dependence needed after 931c0cd713ee

Author: Johannes Doerfert Date: 2020-04-06T09:01:43-05:00 New Revision: 9e1af172eec9a06bffac337057a2452b88466288 URL: https://github.com/llvm/llvm-project/commit/9e1af172eec9a06bffac337057a2452b88466288 DIFF:

[PATCH] D77520: Treat default values in LangOptions.def in the scope of enums

rnk requested changes to this revision. rnk added a comment. This revision now requires changes to proceed. I don't think we can do this because GCC 5.1 won't support it. To confirm, that's still the minimum supported version:

[PATCH] D77058: [Clang] Add llvm.loop.unroll.disable to loops with -fno-unroll-loops.

fhahn added a comment. ping. @tejohnson are you happy with this approach, given that it sounds good to @dexonsmith as well? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77058/new/ https://reviews.llvm.org/D77058

[PATCH] D75453: [Driver][ARM] fix undefined behaviour when checking architecture version

j0le updated this revision to Diff 255354. j0le added a comment. I added a test case. I hope the folder "clang/tests/Driver" is the right one. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75453/new/ https://reviews.llvm.org/D75453 Files: clang/lib/Driver/ToolChains/Clang.cpp

[PATCH] D77028: Speed up deferred diagnostic emitter

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Thank you. Minor request, but feel free to commit with that change. Comment at: clang/lib/Sema/Sema.cpp:1558 +// visited before. +if (Done.count(FD)) +

[PATCH] D77393: [X86] Fix implicit sign conversion warnings in X86 headers.

RKSimon added a comment. @craig.topper Any comments? Hopefully we can add extra tests as time goes on (for instance I'm intending to add Wdocumentation test coverage for PR35949). Comment at: clang/test/Headers/x86-header-warnings.c:12 +void test() { + // CHECK-NOT: warning:

[clang] 2aa593b - Fix a typo in an assert message; NFC.

Author: BoYao Zhang Date: 2020-04-06T11:50:50-04:00 New Revision: 2aa593be5486a9c5d3092647f2576273f84f3159 URL: https://github.com/llvm/llvm-project/commit/2aa593be5486a9c5d3092647f2576273f84f3159 DIFF: https://github.com/llvm/llvm-project/commit/2aa593be5486a9c5d3092647f2576273f84f3159.diff

[PATCH] D77519: Fix __is_pointer builtin type trait to work with Objective-C pointer types.

zoecarver updated this revision to Diff 255362. zoecarver added a comment. Diff from master not last commit. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77519/new/ https://reviews.llvm.org/D77519 Files: clang/lib/Sema/SemaExprCXX.cpp

[PATCH] D77532: Fix a typo in clang/lib/Frontend/FrontendAction.cpp

aaron.ballman closed this revision. aaron.ballman added a comment. Thank you for the patch! I've committed on your behalf in 2aa593be5486a9c5d3092647f2576273f84f3159 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang] 11a04a6 - [DebugInfo] Change to constructor homing debug info mode: skip literal types

Author: Amy Huang Date: 2020-04-06T09:52:53-07:00 New Revision: 11a04a64aaa3dba6fddadbcf026d197fc02226e0 URL: https://github.com/llvm/llvm-project/commit/11a04a64aaa3dba6fddadbcf026d197fc02226e0 DIFF: https://github.com/llvm/llvm-project/commit/11a04a64aaa3dba6fddadbcf026d197fc02226e0.diff

[clang] f8e1fc2 - Make clang/test/Driver/cl-options.cu pass in 32-bit builds

Author: Hans Wennborg Date: 2020-04-06T16:04:43+02:00 New Revision: f8e1fc20cb3984faf62cdd947e4d1a408a9000d8 URL: https://github.com/llvm/llvm-project/commit/f8e1fc20cb3984faf62cdd947e4d1a408a9000d8 DIFF: https://github.com/llvm/llvm-project/commit/f8e1fc20cb3984faf62cdd947e4d1a408a9000d8.diff

[PATCH] D77410: [analyzer] StdLibraryFunctionsChecker: match signature based on FunctionDecl

This revision was automatically updated to reflect the committed changes. martong marked an inline comment as done. Closed by commit rG8f961399739f: [analyzer] StdLibraryFunctionsChecker: match signature based on FunctionDecl (authored by martong). Changed prior to commit:

[PATCH] D77519: Fix __is_pointer builtin type trait to work with Objective-C pointer types.

zoecarver marked an inline comment as done. zoecarver added a comment. @ldionne of course! Comment at: libcxx/include/type_traits:901 +// In clang 10.0.0 and earlier __is_pointer didn't work with Objective-C types. +#if __has_keyword(__is_pointer) && _LIBCPP_CLANG_VER > 1000 +

[PATCH] D77411: [analyzer] StdLibraryFunctionsChecker: Add test for function with default parameter

This revision was automatically updated to reflect the committed changes. Closed by commit rGab1fad8a3a8b: [analyzer] StdLibraryFunctionsChecker: Add test for function with default… (authored by martong). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D75682: [Analyzer][StreamChecker] Introduction of stream error handling.

balazske updated this revision to Diff 255360. balazske added a comment. - Adding comment about ferror, feof. - Enabled core checker in test file. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75682/new/ https://reviews.llvm.org/D75682 Files:

[PATCH] D77548: clang-format: [JS] handle pseudo-keywords.

This revision was automatically updated to reflect the committed changes. Closed by commit rG92201505cdec: clang-format: [JS] handle pseudo-keywords. (authored by mprobst). Changed prior to commit: https://reviews.llvm.org/D77548?vs=255314=255357#toc Repository: rG LLVM Github Monorepo

[PATCH] D77257: Clean up usages of asserting vector getters in Type

sdesmalen accepted this revision. sdesmalen added a comment. This revision is now accepted and ready to land. LGTM! Comment at: clang/lib/CodeGen/CGBuiltin.cpp:5830 BuiltinID == NEON::BI__builtin_neon_vqrdmulhq_lane_v) - RTy =

[PATCH] D77519: Fix __is_pointer builtin type trait to work with Objective-C pointer types.

zoecarver updated this revision to Diff 255361. zoecarver added a comment. Fix based on review: - Use static_assert directly in the test - Update run command to work on non-objc platforms (e.g. linux) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D68115: Zero initialize padding in unions

hubert.reinterpretcast added a comment. In D68115#1962892 , @rsmith wrote: > In D68115#1962863 , @jfb wrote: > > > In D68115#1962833 , @rsmith wrote: > > > > > I think the

[PATCH] D76130: [PPC][AIX] Implement variadic function handling in LowerFormalArguments_AIX

ZarkoCA updated this revision to Diff 255321. ZarkoCA added a comment. Rebase and ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76130/new/ https://reviews.llvm.org/D76130 Files: llvm/lib/Target/PowerPC/PPCISelLowering.cpp

[PATCH] D77209: [Syntax] Add mapping from spelled to expanded tokens for TokenBuffer

hlopko updated this revision to Diff 255326. hlopko marked 4 inline comments as done. hlopko added a comment. Adressing comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77209/new/ https://reviews.llvm.org/D77209 Files:

[PATCH] D76360: [PPC][AIX] Emit correct Vaarg for 32BIT-AIX in clang

ZarkoCA updated this revision to Diff 255323. ZarkoCA added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76360/new/ https://reviews.llvm.org/D76360 Files: clang/lib/Basic/Targets/PPC.h clang/lib/CodeGen/TargetInfo.cpp

[PATCH] D77499: [ASTMatchers] Matchers that take enumerations args provide hints with invalid arguments

aaron.ballman added a reviewer: aaron.ballman. aaron.ballman added a comment. Thank you for working on this, I think it's very useful functionality! I'd appreciate seeing some unit test coverage for these changes. Comment at: clang/lib/ASTMatchers/Dynamic/CMakeLists.txt:17

[PATCH] D77209: [Syntax] Add mapping from spelled to expanded tokens for TokenBuffer

hlopko marked an inline comment as done. hlopko added a comment. Adressing comments. Comment at: clang/lib/Tooling/Syntax/Tokens.cpp:264 + auto *FrontMapping = mappingStartingBeforeSpelled(File, ()); + unsigned SpelledFrontI = () - File.SpelledTokens.data(); + unsigned

[clang] 9220150 - clang-format: [JS] handle pseudo-keywords.

Author: Martin Probst Date: 2020-04-06T17:13:04+02:00 New Revision: 92201505cdecd8ba5795f5e33821c49dc57f0816 URL: https://github.com/llvm/llvm-project/commit/92201505cdecd8ba5795f5e33821c49dc57f0816 DIFF: https://github.com/llvm/llvm-project/commit/92201505cdecd8ba5795f5e33821c49dc57f0816.diff

[clang] 8f96139 - [analyzer] StdLibraryFunctionsChecker: match signature based on FunctionDecl

Author: Gabor Marton Date: 2020-04-06T17:34:08+02:00 New Revision: 8f961399739f539cb0b3c9ac68ca1b62c2a17a80 URL: https://github.com/llvm/llvm-project/commit/8f961399739f539cb0b3c9ac68ca1b62c2a17a80 DIFF: https://github.com/llvm/llvm-project/commit/8f961399739f539cb0b3c9ac68ca1b62c2a17a80.diff

Re: [clang] 8527c1e - Added constraints on cl-options.cu test

Oh no, the warning is a red herring. The problem is I'm doing a 32-bit build and the triple is nvptx-nvidia-cuda, not nvptx64-nvidia-cuda. f8e1fc20cb3 should fix. On Mon, Apr 6, 2020 at 3:54 PM Hans Wennborg wrote: > > I'm seeing this failure when trying to build the Windows package for >

[clang] ab1fad8 - [analyzer] StdLibraryFunctionsChecker: Add test for function with default parameter

Author: Gabor Marton Date: 2020-04-06T17:08:58+02:00 New Revision: ab1fad8a3a8b8e3264c34448205061add013b8d7 URL: https://github.com/llvm/llvm-project/commit/ab1fad8a3a8b8e3264c34448205061add013b8d7 DIFF: https://github.com/llvm/llvm-project/commit/ab1fad8a3a8b8e3264c34448205061add013b8d7.diff

[PATCH] D75181: [AArch64] Handle BTI/PAC in case of generated functions.

danielkiss updated this revision to Diff 255347. danielkiss added a reviewer: tamas.petz. danielkiss added a comment. Fix review comments from Tamas. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75181/new/ https://reviews.llvm.org/D75181 Files: clang/lib/CodeGen/CGCall.cpp

[clang] 1c92448 - [OPENMP]Fix PR45439: `omp for collapse(2) ordered(2)` generates invalid

Author: Alexey Bataev Date: 2020-04-06T12:07:43-04:00 New Revision: 1c924486564461810903603542ffc2d7db204dde URL: https://github.com/llvm/llvm-project/commit/1c924486564461810903603542ffc2d7db204dde DIFF: https://github.com/llvm/llvm-project/commit/1c924486564461810903603542ffc2d7db204dde.diff

[PATCH] D76384: Move FPFeatures from BinaryOperator bitfields to Trailing storage

mibintc added a comment. It seems like the macro's in StmtVisitor.h only work if CAO and BinaryOperator are separate classes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76384/new/ https://reviews.llvm.org/D76384

[PATCH] D77548: clang-format: [JS] handle pseudo-keywords.

krasimir accepted this revision. krasimir added a comment. This revision is now accepted and ready to land. Looks good! The linter suggests a few formatting fixes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77548/new/

[PATCH] D77507: [clangd] Fix HitMapping assertion in Tokens.cpp

sammccall added a comment. Thanks for tracking this down. Unfortunately I don't think removing the assertion is enough, the code doesn't handle this case correctly. Comment at: clang/unittests/Tooling/Syntax/TokensTest.cpp:487 )"}, + // Baseline case, bugz:

[PATCH] D75917: Expose llvm fence instruction as clang intrinsic

sameerds added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:13651 + llvm::getConstantStringInfo(Scope, scp); + SSID = getLLVMContext().getOrInsertSyncScopeID(scp); + saiislam wrote: > sameerds wrote: > > This seems to be creating a new

[PATCH] D77551: [analyzer] Fix NSErrorChecker false positives

vsavchenko created this revision. vsavchenko added reviewers: NoQ, dcoughlin. Herald added subscribers: cfe-commits, ASDenysPetrov, martong, Charusso, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a project: clang. NSErrorChecker

[PATCH] D76211: OpenMP Metadirective with user defined condition

tomdeakin added a comment. Herald added a subscriber: yaxunl. Is there an update on this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76211/new/ https://reviews.llvm.org/D76211 ___ cfe-commits

[PATCH] D77379: [FPEnv] Use single enum to represent rounding mode

rjmccall added a reviewer: scanon. rjmccall added inline comments. Comment at: llvm/include/llvm/ADT/FloatingPointMode.h:26 +/// assigned to the rounding modes must agree with the values used by FLT_ROUNDS +/// (C11, 5.2.4.2.2p8). +enum class RoundingMode : int8_t {

[PATCH] D77520: Treat default values in LangOptions.def in the scope of enums

sepavloff abandoned this revision. sepavloff added a comment. Thank you, Reid! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77520/new/ https://reviews.llvm.org/D77520 ___ cfe-commits mailing list

[PATCH] D77545: Represent FP options in AST by special Expression node

rjmccall added a comment. The goal here seems to be to avoid the need to store pragma state in operator expressions. As I mentioned in another review, I'm not sure how directly interesting that goal is if we can avoid memory overhead in the common case. Storing pragma state in operators

[PATCH] D77028: Speed up deferred diagnostic emitter

yaxunl updated this revision to Diff 255315. yaxunl marked an inline comment as done. yaxunl retitled this revision from "[NFC] Refactor DeferredDiagsEmitter and skip redundant visit" to "Speed up deferred diagnostic emitter". yaxunl edited the summary of this revision. yaxunl added a comment.

[PATCH] D77548: clang-format: [JS] handle pseudo-keywords.

mprobst created this revision. mprobst added a reviewer: krasimir. Herald added a project: clang. Herald added a subscriber: cfe-commits. The previous change in https://reviews.llvm.org/D77311 attempted to detect more C++ keywords. However it also precisely detected all JavaScript keywords.

[PATCH] D77540: [PATCH] [ARM]: Armv8.6-a Matrix Mul Asm and Intrinsics Support

LukeGeeson added a comment. build failures related to linting, unit tests passing Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77540/new/ https://reviews.llvm.org/D77540 ___ cfe-commits mailing list

Re: [clang-tools-extra] 9e1af17 - [OpenMP][FIX] Add missing cmake dependence needed after 931c0cd713ee

On 4/6/20 9:06 AM, Roman Lebedev wrote: This seems suspicious. Agreed, especially since this is also not the only place. I was hoping to unblock the builders with this. Does clang-reorder-fields actually explicitly needs something from FrontendOpenMP? If not, it looks like there dependency

[PATCH] D76932: [AIX] emit .extern and .weak directive linkage

jasonliu added a comment. Thanks for splitting the test case. I think it helps a lot for reading and maintainability. Comment at: llvm/lib/CodeGen/AsmPrinter/AsmPrinter.cpp:1490 continue; GlobalValue::VisibilityTypes V = F.getVisibility(); + This

[PATCH] D77410: [analyzer] StdLibraryFunctionsChecker: match signature based on FunctionDecl

martong marked 2 inline comments as done. martong added a comment. In D77410#1963288 , @Szelethus wrote: > LGTM! Maybe its worth glancing over the rest of the code (comments in > particular) whether anything would be outdated by this change. Yeah,

[PATCH] D77209: [Syntax] Add mapping from spelled to expanded tokens for TokenBuffer

gribozavr2 added inline comments. Comment at: clang/lib/Tooling/Syntax/Tokens.cpp:264 + auto *FrontMapping = mappingStartingBeforeSpelled(File, ()); + unsigned SpelledFrontI = () - File.SpelledTokens.data(); + unsigned ExpandedBegin; hlopko wrote: >

[PATCH] D76818: [clang-tidy] Add check llvmlibc-implementation-in-namespace.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Comment at: clang-tools-extra/clang-tidy/llvmlibc/ImplementationInNamespaceCheck.cpp:21 + Finder->addMatcher( +

[PATCH] D77507: [clangd] Fix HitMapping assertion in Tokens.cpp

vabridgers added a comment. Thank you for the comments. I'll keep looking at this to find a proper fix, but any hints you may have would be greatly appreciated (debugging tips, strategies, areas of code to focus on). This code is new to me, so I may not be as efficient at tracking this down as

[PATCH] D77058: [Clang] Add llvm.loop.unroll.disable to loops with -fno-unroll-loops.

tejohnson accepted this revision. tejohnson added a comment. This revision is now accepted and ready to land. yep, LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77058/new/ https://reviews.llvm.org/D77058

[PATCH] D76384: Move FPFeatures from BinaryOperator bitfields to Trailing storage

rjmccall added a comment. I would guess that some visitor still has a `VisitCompoundAssignOperator` implementation, and that the behavior of `VisitBinAssign` happens to do what's needed for it. You basically have two options: - Keep a `VisitCompoundAssignOperator` around in `StmtVisitor` for

[PATCH] D75917: Expose llvm fence instruction as clang intrinsic

JonChesterfield added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:13651 + llvm::getConstantStringInfo(Scope, scp); + SSID = getLLVMContext().getOrInsertSyncScopeID(scp); + sameerds wrote: > saiislam wrote: > > sameerds wrote: > > >

[PATCH] D77414: [OpenMP] Add match_{all,any,none} declare variant selector extensions.

mikerice accepted this revision. mikerice added a comment. This revision is now accepted and ready to land. Looks okay to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77414/new/ https://reviews.llvm.org/D77414

[PATCH] D77028: Speed up deferred diagnostic emitter

yaxunl marked 2 inline comments as done. yaxunl added inline comments. Comment at: clang/lib/Sema/Sema.cpp:1558 +// visited before. +if (Done.count(FD)) + return; rjmccall wrote: > `insert` returns whether it changed the set, so you can combine this

Re: [clang] 8527c1e - Added constraints on cl-options.cu test

I'm seeing this failure when trying to build the Windows package for http://llvm.org/builds (yes, it's been a while). Not sure why it hasn't been on the bots (maybe the Windows bots don't build the nvptx target). Anyway, the error comes from "nocudalib" not being a valid clang-cl option. Is it

Re: [clang-tools-extra] 9e1af17 - [OpenMP][FIX] Add missing cmake dependence needed after 931c0cd713ee

This seems suspicious. Does clang-reorder-fields actually explicitly needs something from FrontendOpenMP? If not, it looks like there dependency is missing elsewhere, or there's wrong layering. On Mon, Apr 6, 2020 at 5:03 PM Johannes Doerfert via cfe-commits wrote: > > > Author: Johannes

Re: [clang-tools-extra] 9e1af17 - [OpenMP][FIX] Add missing cmake dependence needed after 931c0cd713ee

On Mon, Apr 6, 2020 at 5:23 PM Johannes Doerfert wrote: > > On 4/6/20 9:06 AM, Roman Lebedev wrote: > > This seems suspicious. > > > Agreed, especially since this is also not the only place. > > I was hoping to unblock the builders with this. > > > Does clang-reorder-fields actually explicitly

[PATCH] D76612: [Matrix] Add draft specification for matrix support in Clang.

fhahn updated this revision to Diff 255341. fhahn added a comment. Update standard conversion wording as suggested by @rjmccall Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76612/new/ https://reviews.llvm.org/D76612 Files:

[PATCH] D77507: [clangd] Fix HitMapping assertion in Tokens.cpp

sammccall added a comment. Oh dear, this seems like a design bug. TokenBuffer only attempts to record "top-level" expansions, i.e. `FOO(BAR(BAZ))` will record the expansion of FOO, and say the tokens `FOO ( BAR ( BAZ ) )` were expanded into `some other thing` in an essentially-opaque way. The

[PATCH] D77499: [ASTMatchers] Matchers that take enumerations args provide hints with invalid arguments

njames93 added inline comments. Comment at: clang/lib/ASTMatchers/Dynamic/Marshallers.cpp:16-17 +if (Item.equals_lower(Search)) { + if (Item.equals(Search)) +return Item.str(); + MaxEditDistance = 1; aaron.ballman wrote: > Is this case

[PATCH] D77257: Clean up usages of asserting vector getters in Type

ctetreau updated this revision to Diff 255390. ctetreau added a comment. Address code review issues Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77257/new/ https://reviews.llvm.org/D77257 Files: clang/lib/CodeGen/CGAtomic.cpp

[PATCH] D77252: [OpenMP] Try to find an existing base for `omp begin/end declare variant`

mikerice accepted this revision. mikerice added a comment. This revision is now accepted and ready to land. LGTM. I did run the math_cpp11 tests. I don't have a cuda environment so it was probably of limited value. I didn't see any failures that seemed related to this during the compiles.

[PATCH] D77229: [Analyzer][WIP] Avoid handling of LazyCompundVals in IteratorModeling

NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/ExprEngineCXX.cpp:127 + const auto *Init = ICC->getCXXCtorInitializer(); + return getObjectUnderConstruction(State, Init, LCtx); +} baloghadamsoftware wrote: > This does not find

[PATCH] D77551: [analyzer] Fix NSErrorChecker false positives

Szelethus added inline comments. Comment at: clang/test/Analysis/SpecialFunctionsCFError.cpp:2 +// RUN: %clang_analyze_cc1 -analyzer-checker=core,osx.coreFoundation.CFError \ +// RUN: -analyzer-store=region -verify %s + NoQ wrote: > `-analyzer-store=region` is

[PATCH] D64321: [OpenCL] Change diagnostic for function declaration

svenvh abandoned this revision. svenvh added a comment. Abandoning after an offline discussion with @Anastasia. Overloading is not a feature of OpenCL C in the first place so adding complexity to Clang isn't really justifiable. Repository: rC Clang CHANGES SINCE LAST ACTION

[PATCH] D75917: Expose llvm fence instruction as clang intrinsic

sameerds requested changes to this revision. sameerds added inline comments. This revision now requires changes to proceed. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:13651 + llvm::getConstantStringInfo(Scope, scp); + SSID =

[PATCH] D77551: [analyzer] Fix NSErrorChecker false positives

vsavchenko marked an inline comment as done. vsavchenko added a comment. In D77551#1964441 , @NoQ wrote: > Looks great, thanks! Do you already have commit access or should i commit > this for you? Thanks :-) No, I don't have commit access

[PATCH] D76725: [clangd] Build ASTs only with fresh preambles or after building a new preamble

kadircet updated this revision to Diff 255425. kadircet marked 10 inline comments as done. kadircet added a comment. - Address comments and rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76725/new/ https://reviews.llvm.org/D76725 Files:

[PATCH] D75917: Expose llvm fence instruction as clang intrinsic

JonChesterfield added inline comments. Comment at: clang/test/CodeGenHIP/builtin_memory_fence.cpp:9 + // CHECK: fence syncscope("workgroup") seq_cst + __builtin_memory_fence(__ATOMIC_SEQ_CST, "workgroup"); + JonChesterfield wrote: > sameerds wrote: > >

[PATCH] D76725: [clangd] Build ASTs only with fresh preambles or after building a new preamble

kadircet marked an inline comment as done. kadircet added inline comments. Comment at: clang-tools-extra/clangd/TUScheduler.cpp:224 + std::vector CIDiags, WantDiagnostics WantDiags) { // Make possibly expensive copy while not holding the lock. +Request Req

[PATCH] D77451: Accept -x cu to indicate language is CUDA, transfer CUDA language flag to header-file arguments

tra added a reviewer: sammccall. tra added a comment. Please add some more details to the bug description. This change is to make clangd work when compilation database sees CUDA sources compiled with nvcc. NVCC uses different options that should be properly translated. This patch only deals

[clang] 427c1dc - [ASTMatchers] Matchers that take enumerations args provide hints with invalid arguments

Author: Nathan James Date: 2020-04-06T20:00:30+01:00 New Revision: 427c1dc4f4248ec71e32a8f3832a4e6258446672 URL: https://github.com/llvm/llvm-project/commit/427c1dc4f4248ec71e32a8f3832a4e6258446672 DIFF: https://github.com/llvm/llvm-project/commit/427c1dc4f4248ec71e32a8f3832a4e6258446672.diff

[PATCH] D75682: [Analyzer][StreamChecker] Introduction of stream error handling.

Szelethus added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Checkers/Checkers.td:455 +def StreamTesterChecker : Checker<"StreamTester">, + HelpText<"Add test functions to StreamChecker for test and debugging purposes.">, NoQ wrote: > This

[PATCH] D75917: Expose llvm fence instruction as clang intrinsic

JonChesterfield added inline comments. Comment at: clang/test/CodeGenHIP/builtin_memory_fence.cpp:1 // REQUIRES: amdgpu-registered-target // RUN: %clang_cc1 %s -x hip -emit-llvm -O0 -o - \ Codegen test should be under CodeGen and/or CodeGenCXX Repository:

[PATCH] D77571: Add ClangTidy check to find calls to NSInvocation methods under ARC that don't have proper object argument lifetimes.

benhamilton accepted this revision. benhamilton added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clang-tidy/objc/NsinvocationArgumentLifetimeCheck.cpp:71-73 + // Currently there is no way to directly get the source range for

[PATCH] D77309: [clangd] Get rid of ASTWorker::getCurrentFileInputs

kadircet updated this revision to Diff 255435. kadircet added a comment. - Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77309/new/ https://reviews.llvm.org/D77309 Files: clang-tools-extra/clangd/TUScheduler.cpp Index:

[clang-tools-extra] 549e87f - [clangd] Fix bad include

Author: Kadir Cetinkaya Date: 2020-04-06T21:36:54+02:00 New Revision: 549e87f3d04bbae91bc7bc38609ce7073e2c8a6d URL: https://github.com/llvm/llvm-project/commit/549e87f3d04bbae91bc7bc38609ce7073e2c8a6d DIFF:

[clang] b36c19b - [AST] Remove DeclCXX.h dep on ASTContext.h

Author: Reid Kleckner Date: 2020-04-06T10:09:01-07:00 New Revision: b36c19bc4f2110a8e33f8d93751ef28b6dcd0292 URL: https://github.com/llvm/llvm-project/commit/b36c19bc4f2110a8e33f8d93751ef28b6dcd0292 DIFF: https://github.com/llvm/llvm-project/commit/b36c19bc4f2110a8e33f8d93751ef28b6dcd0292.diff

[PATCH] D77028: Speed up deferred diagnostic emitter

rjmccall added inline comments. Comment at: clang/lib/Sema/Sema.cpp:1558 +// visited before. +if (Done.count(FD)) + return; yaxunl wrote: > rjmccall wrote: > > `insert` returns whether it changed the set, so you can combine this check > > with the

[PATCH] D77551: [analyzer] Fix NSErrorChecker false positives

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Looks great, thanks! Do you already have commit access or should i commit this for you? Comment at: clang/test/Analysis/SpecialFunctionsCFError.cpp:2 +// RUN: %clang_analyze_cc1

[PATCH] D77499: [ASTMatchers] Matchers that take enumerations args provide hints with invalid arguments

njames93 updated this revision to Diff 255387. njames93 marked 4 inline comments as done. njames93 added a comment. - Added test cases and addressed nits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77499/new/ https://reviews.llvm.org/D77499

[PATCH] D77305: [Analyzer][VLASize] Support multi-dimensional arrays.

balazske updated this revision to Diff 255388. balazske added a comment. Added comments and test for extent. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77305/new/ https://reviews.llvm.org/D77305 Files:

[PATCH] D77058: [Clang] Add llvm.loop.unroll.disable to loops with -fno-unroll-loops.

Meinersbur added a comment. Note that loop-metadata is best-effort only and may be forgotten in the optimization pipeline. Do we also need an equivalent to `-Xclang -disable-O0-optnone`? Personally, I don't like to the `optnone` approach: There have been many post on llvm-dev using `clang

[PATCH] D76782: [CodeGenObjC] Fix a crash when attempting to copy a zero-sized bit-field in a non-trivial C struct

erik.pilkington updated this revision to Diff 255385. erik.pilkington marked 3 inline comments as done. erik.pilkington added a comment. Don't bother including zero length bit-fields in the mangling of the copy/destroy helpers. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76782/new/

[PATCH] D77570: [clang][CodeComplete] Dont perform fallback completion for incomplete member ref

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added a project: clang. Herald added a subscriber: cfe-commits. Clang performs expression based completion whenever it can't figure out base of a member reference expression. It might be quite confusing in cases like

[PATCH] D77028: Speed up deferred diagnostic emitter

This revision was automatically updated to reflect the committed changes. yaxunl marked an inline comment as done. Closed by commit rG2c31aa2de13a: Speed up deferred diagnostic emitter (authored by yaxunl). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang] 9b1e4a8 - [analyzer] Fix NSErrorChecker false positives on constructors.

Author: Artem Dergachev Date: 2020-04-06T20:33:38+03:00 New Revision: 9b1e4a8218b7fcb8900d0382704fdb4e38b52eb0 URL: https://github.com/llvm/llvm-project/commit/9b1e4a8218b7fcb8900d0382704fdb4e38b52eb0 DIFF:

[clang] 2ddd332 - [analyzer] Fix scan-build and exploded-graph-rewriter tests on Windows.

Author: Artem Dergachev Date: 2020-04-06T20:33:37+03:00 New Revision: 2ddd3325c4d7ab47b62a9fe72a0d1c1d8ec7f9d7 URL: https://github.com/llvm/llvm-project/commit/2ddd3325c4d7ab47b62a9fe72a0d1c1d8ec7f9d7 DIFF:

Re: [clang] 8527c1e - Added constraints on cl-options.cu test

On Mon, Apr 6, 2020 at 7:36 PM Artem Belevich wrote: > > Yup 32-bit vis 64-bit does dis trip linux tests, too some time back. We ended > up passing explicit target triples to avoid host architecture leaking into > the test. > > On a side note, shouldn't we pass -nocudalib via /clang: ? Yes,

[clang] 0731132 - [clang][CodeComplete] Dont perform fallback completion for incomplete member ref

Author: Kadir Cetinkaya Date: 2020-04-06T20:08:24+02:00 New Revision: 0731132888a0219179fdb4303cd690a6687cc130 URL: https://github.com/llvm/llvm-project/commit/0731132888a0219179fdb4303cd690a6687cc130 DIFF:

[PATCH] D77499: [ASTMatchers] Matchers that take enumerations args provide hints with invalid arguments

This revision was automatically updated to reflect the committed changes. Closed by commit rG427c1dc4f424: [ASTMatchers] Matchers that take enumerations args provide hints with invalid… (authored by njames93). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D76725: [clangd] Build ASTs only with fresh preambles or after building a new preamble

This revision was automatically updated to reflect the committed changes. Closed by commit rGc31367e95ce1: [clangd] Build ASTs only with fresh preambles or after building a new preamble (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D76125: [clangd] Decouple preambleworker from astworker, NFCI

This revision was automatically updated to reflect the committed changes. Closed by commit rG276a95bdf27c: [clangd] Decouple preambleworker from astworker, NFCI (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76125/new/

[PATCH] D77503: [ASTMatchers] Fixed CastKind being parsed incorrectly for dynamic matchers

njames93 updated this revision to Diff 255440. njames93 added a comment. - Added support for giving suggestions on invalid inputs Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77503/new/ https://reviews.llvm.org/D77503 Files:

[PATCH] D76304: [clangd] Update TUStatus api to accommodate preamble thread

This revision was automatically updated to reflect the committed changes. Closed by commit rG6b85032c95be: [clangd] Update TUStatus api to accommodate preamble thread (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76304/new/

[PATCH] D77571: Add ClangTidy check to find calls to NSInvocation methods under ARC that don't have proper object argument lifetimes.

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/clang-tidy/objc/NsinvocationArgumentLifetimeCheck.cpp:35 + +constexpr StringRef WeakText = "__weak"; +constexpr StringRef StrongText = "__strong"; Please use static instead of anonymous

[PATCH] D77534: [clangd] DefineOutline: removes static token from static CXXMethodDecl

kadircet added inline comments. Comment at: clang-tools-extra/clangd/refactor/tweaks/DefineOutline.cpp:242 - if (FD->isVirtualAsWritten()) { -SourceRange SpecRange{FD->getBeginLoc(), FD->getLocation()}; -bool HasErrors = true; - -// Clang allows duplicating

RE: [clang] b670ab7 - recommit 1b978ddba05c [CUDA][HIP][OpenMP] Emit deferred diagnostics by a post-parsing AST travese

[AMD Official Use Only - Internal Distribution Only] commit 2c31aa2de13a23a00ced87123b92e905f2929c7b should fix this. Thanks. Sam -Original Message- From: Liu, Yaxun (Sam) Sent: Sunday, April 5, 2020 12:20 PM To: Joerg Sonnenberger ; Yaxun Liu Cc: cfe-commits@lists.llvm.org Subject:

Re: [clang] 8527c1e - Added constraints on cl-options.cu test

Yup 32-bit vis 64-bit does dis trip linux tests, too some time back. We ended up passing explicit target triples to avoid host architecture leaking into the test. On a side note, shouldn't we pass -nocudalib via /clang: ? On Mon, Apr 6, 2020 at 7:05 AM Hans Wennborg wrote: > Oh no, the warning

[PATCH] D71124: [RISCV] support clang driver to select cpu

khchen added a comment. @lenary (Sorry for the very late reply...) In D71124#1829998 , @lenary wrote: > In D71124#1792216 , @khchen wrote: > > > The problem is how `-mcpu` interact with explicitly specified

[PATCH] D77570: [clang][CodeComplete] Dont perform fallback completion for incomplete member ref

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. It'd be nice to suppress the fallback more directly, but this is pretty clear. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77570/new/

  1   2   3   4   >