[PATCH] D79394: [clang][codegen] Refactor argument loading in function prolog. NFC.

hliao created this revision. hliao added reviewers: rjmccall, kerbowa, yaxunl. Herald added a project: clang. Herald added a subscriber: cfe-commits. hliao added a child revision: D79395: [clang][codegen] Hoist parameter attribute setting in function prolog.. - Skip copying function arguments

[PATCH] D79395: [clang][codegen] Hoist parameter attribute setting in function prolog.

hliao updated this revision to Diff 262011. hliao added a comment. Add dependency. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79395/new/ https://reviews.llvm.org/D79395 Files: clang/lib/CodeGen/CGCall.cpp

[PATCH] D79213: [hip] Add noalias on restrict qualified coerced hip pointers

hliao added a comment. I hoisted parameter attributes preparation in D79395 , which depends on D79394 , a cleanup to make that hoist more straight-forward. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D79395: [clang][codegen] Hoist parameter attribute setting in function prolog.

hliao created this revision. hliao added reviewers: rjmccall, kerbowa, yaxunl. Herald added subscribers: cfe-commits, nhaehnle, jvesely. Herald added a project: clang. hliao updated this revision to Diff 262011. hliao added a comment. hliao added a parent revision: D79394: [clang][codegen]

[PATCH] D74668: [Clang][BPF] implement __builtin_btf_type_id() builtin function

anakryiko added a comment. what's the use case for flag==0 (no relocation)? why using built-in at all in such case? Also flag==1 means relocate to local BTF ID or remote (kernel) BTF ID? Do you plan to add flag=2 as well to cover both cases? Or am I misunderstanding the meaning of this flag?

[PATCH] D79380: [clang-tidy] In TransformerClangTidyCheck, support option SourceNamingStyle.

gribozavr2 accepted this revision. gribozavr2 added a comment. This revision is now accepted and ready to land. LGTM, but I don't understand why this option is called "SourceNamingStyle". Existing ClangTidy checkers call it "IncludeStyle". Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D78843: [clangd] Remove unused bits after 67b2dbd5a33583. NFC

sammccall abandoned this revision. sammccall added a comment. Obsoleted by D79313 (Sorry for ignoring this!) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78843/new/ https://reviews.llvm.org/D78843

[PATCH] D79313: [clangd] NFC: Cleanup unused headers and libraries

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Thanks for picking this up! Comment at: clang-tools-extra/clangd/index/dex/dexp/CMakeLists.txt:2 include_directories(${CMAKE_CURRENT_SOURCE_DIR}/../../../)

[PATCH] D78743: [clangd] Preserve line information while build PreamblePatch

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/Preamble.cpp:321 llvm::raw_string_ostream Patch(PP.PatchContents); + Patch << llvm::formatv("#line 0 \"{0}\"\n",

[PATCH] D79401: [clang-format] [PR45639] clang-format splits up the brackets of C++17 attribute [[ ]] when used with the first parameter

MyDeveloperDay created this revision. MyDeveloperDay added reviewers: krasimir, sammccall, mitchell-stellar. MyDeveloperDay added projects: clang, clang-format. https://bugs.llvm.org/show_bug.cgi?id=45639 clang-format incorrectly splits the `[[` in a long argument list void

[PATCH] D79397: [clang] Fix an uint32_t overflow in large preamble.

This revision was automatically updated to reflect the committed changes. Closed by commit rG4f8d9722b499: [clang] Fix an uint32_t overflow in large preamble. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79397/new/

[PATCH] D79397: [clang] Fix an uint32_t overflow in large preamble.

hokein created this revision. hokein added a reviewer: sammccall. Herald added a project: clang. I was surprised to see the LocalOffset can exceed uint32_t, but it does happen and lead to crashes in one of our internal huge TU with a large preamble. with this patch, the crash is gone.

[clang] 4f8d972 - [clang] Fix an uint32_t overflow in large preamble.

Author: Haojian Wu Date: 2020-05-05T10:36:34+02:00 New Revision: 4f8d9722b4992272c0e1b33d57fc20bbd93269af URL: https://github.com/llvm/llvm-project/commit/4f8d9722b4992272c0e1b33d57fc20bbd93269af DIFF: https://github.com/llvm/llvm-project/commit/4f8d9722b4992272c0e1b33d57fc20bbd93269af.diff

[PATCH] D79397: [clang] Fix an uint32_t overflow in large preamble.

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Thanks for tracking this down! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79397/new/ https://reviews.llvm.org/D79397

[PATCH] D79276: [FileCheck] Support comment directives

jhenderson added inline comments. Comment at: llvm/docs/CommandGuide/FileCheck.rst:57 + By default, FileCheck ignores any occurrence in ``match-filename`` of any check + prefix if it is preceded on the same line by "``COM:``" or "``RUN:``". See the + section `The "COM:"

[PATCH] D78573: [Clang][Sema] Capturing section type conflicts between #pragma clang section and section attributes

pratlucas added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78573/new/ https://reviews.llvm.org/D78573 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D78740: [clangd] Handle PresumedLocations in IncludeCollector

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. LG, Just readability stuff. Comment at: clang-tools-extra/clangd/Headers.cpp:39 SrcMgr::CharacteristicKind FileKind) override { -if

[PATCH] D79313: [clangd] NFC: Cleanup unused headers and libraries

kbobyrev updated this revision to Diff 262036. kbobyrev marked an inline comment as done. kbobyrev added a comment. Make it possible for dexp to include generated headers again. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79313/new/

[PATCH] D78660: [SemaObjC] Add a warning for dictionary literals with duplicate keys

bendjones accepted this revision. bendjones marked an inline comment as done. bendjones added a comment. This revision is now accepted and ready to land. This addresses what we had an issue with on the tin. I’ll defer to @rjmccall for the specifics at the clang level. Comment

[PATCH] D79358: [analyzer] CERT: STR37-C

Szelethus added a reviewer: martong. Szelethus added a comment. Herald added a subscriber: rnkovacs. Adding @martong, because I fear that this is colliding with StdLibraryFunctionsChecker. The warnings added here seem to be, in essence, identical to D73898 .

[PATCH] D75169: [ARM] Enforcing calling convention for half-precision FP arguments and returns for big-endian AArch32

pratlucas added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75169/new/ https://reviews.llvm.org/D75169 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] aed6bd6 - Reland D78750: [SveEmitter] Add builtins for svdupq and svdupq_lane

Author: Sander de Smalen Date: 2020-05-05T10:42:11+01:00 New Revision: aed6bd6f4293c07ca4c55bf49943943f4425794b URL: https://github.com/llvm/llvm-project/commit/aed6bd6f4293c07ca4c55bf49943943f4425794b DIFF:

[clang-tools-extra] 07f8ca6 - [clangd] NFC: Cleanup unused headers and libraries

Author: Kirill Bobyrev Date: 2020-05-05T11:46:28+02:00 New Revision: 07f8ca6ab19b853436e554ebb6a1888cafbda16b URL: https://github.com/llvm/llvm-project/commit/07f8ca6ab19b853436e554ebb6a1888cafbda16b DIFF:

[PATCH] D79334: [clang-tidy]: Add cert-str34-c alias for bugprone-signed-char-misuse.

ztamas updated this revision to Diff 262046. ztamas added a comment. CertSTR34C -> DiagnoseSignedUnsignedCharComparisons Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79334/new/ https://reviews.llvm.org/D79334 Files:

[PATCH] D79388: [clang-format] Fix AlignConsecutive on PP blocks

MyDeveloperDay accepted this revision. MyDeveloperDay added a subscriber: VelocityRa. MyDeveloperDay added a comment. This revision is now accepted and ready to land. I'm struggling with the simplicity of your solution ;-) (that's a compliment!) I've pulled this patch and built it locally. It

[PATCH] D79334: [clang-tidy]: Add cert-str34-c alias for bugprone-signed-char-misuse.

ztamas marked 3 inline comments as done. ztamas added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/SignedCharMisuseCheck.h:41 const std::string CharTypdefsToIgnoreList; + const bool CertSTR34C; }; aaron.ballman wrote: > I'd prefer a

[PATCH] D79160: [AST] Preserve the type in RecoveryExprs for broken function calls.

hokein updated this revision to Diff 262044. hokein marked 4 inline comments as done. hokein added a comment. address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79160/new/ https://reviews.llvm.org/D79160 Files:

[PATCH] D79000: [clang-format] C# property formatting can be controlled by config options

MyDeveloperDay added a comment. In D79000#2009813 , @jbcoe wrote: > public int Style2 > { get; set } > > > appears in MS examples > https://docs.microsoft.com/en-us/dotnet/csharp/programming-guide/classes-and-structs/properties > > public int

[PATCH] D71239: [clang-format] Fix ObjC keywords following try/catch getting split.

MyDeveloperDay added a comment. bool FormatTokenLexer::tryMergeAtTry() { if (Tokens.size() < 2) return false; auto = *(Tokens.end() - 2); auto = *(Tokens.end() - 1); if (!At->is(tok::at) || !String->is(tok::try)) return false; At->Tok.setKind(tok::try);

[PATCH] D68569: [clang-format] Also look for .{ext}.clang-format file

MyDeveloperDay requested changes to this revision. MyDeveloperDay added a comment. This revision now requires changes to proceed. Can we abandon this review now we have the style=file:? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68569/new/

[PATCH] D75791: [clang-format] Added new option IndentExternBlock

MyDeveloperDay added a comment. You need to regenerate the ClangFormatStyleOption.rst file using docs/tools/dump_format_style.py Comment at: clang/include/clang/Format/Format.h:965 bool AfterExternBlock; +enum ExternBlock { + /// Break extern blocks before the

[PATCH] D79313: [clangd] NFC: Cleanup unused headers and libraries

This revision was automatically updated to reflect the committed changes. Closed by commit rG07f8ca6ab19b: [clangd] NFC: Cleanup unused headers and libraries (authored by kbobyrev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79313/new/

[PATCH] D77148: [analyzer] ApiModeling: Add buffer size arg constraint with multiplier involved

martong marked 3 inline comments as done. martong added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp:229-234 BufferSizeConstraint(ArgNo BufArgN, ArgNo SizeArgN) : ValueConstraint(BufArgN), SizeArgN(SizeArgN) {} +

[PATCH] D79035: [clang][AIX] Implement ABIInfo and TargetCodeGenInfo for AIX

Xiangling_L added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:4317 + if (isAggregateTypeForABI(RetTy)) +return getNaturalAlignIndirect(RetTy); + jasonliu wrote: > Xiangling_L wrote: > > This method uses the ABI alignment of the given

[PATCH] D79265: Let normalize() for posix style convert backslash to slash unconditionally.

This revision was automatically updated to reflect the committed changes. Closed by commit rG8fc7a907b93a: Let normalize() for posix style convert backslash to slash unconditionally. (authored by thakis). Herald added a project: clang. Changed prior to commit:

[PATCH] D78827: Add support for #pragma clang fp reassociate(fast|off) -- floating point control of associative math transformations

scanon added a comment. > I don't think the C standard is likely to ever bless reassociative FP math > with an expression-local restriction. Steve, do you actually think that would > be a useful optimization mode? I think it's pretty unlikely that C would do this, as well. It is plausibly a

[PATCH] D78969: [clang][OpenMP] Fix getNDSWDS for aarch64.

This revision was automatically updated to reflect the committed changes. Closed by commit rG4fa13a3dac1e: [clang][OpenMP] Fix getNDSWDS for aarch64. (authored by fpetrogalli). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78969/new/

[PATCH] D78118: [analyzer] StdLibraryFunctionsChecker: Add option to display loaded summaries

Szelethus added a comment. It would be nice to have a user-facing option that lists the functions this checker is **capable** of modeling in another patch :) Comment at: clang/include/clang/StaticAnalyzer/Checkers/Checkers.td:299 + "DisplayLoadedSummaries", +

[PATCH] D79232: [analyzer] Refactor range inference for symbolic expressions

vsavchenko updated this revision to Diff 262170. vsavchenko added a comment. Add clarification on infeasible ranges in bitwise tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79232/new/ https://reviews.llvm.org/D79232 Files:

[PATCH] D79431: [analyzer] StdLibraryFunctionsChecker: Add better diagnostics

Szelethus added a comment. Sure, this is an improvement because we display more information, but I'd argue that it isn't really a more readable warning message :) How about th argument to the call to - cannot be represented with a character - is a null pointer - ... , which violates the

[PATCH] D68049: Propeller: Clang options for basic block sections

tmsriram added a comment. @rsmith Ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68049/new/ https://reviews.llvm.org/D68049 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D79417: Don't assert about missing profile info in createProfileWeightsForLoop

thakis accepted this revision. thakis added a comment. This revision is now accepted and ready to land. Could there be a test for this? Or is that difficult? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79417/new/ https://reviews.llvm.org/D79417

[PATCH] D79431: [analyzer] StdLibraryFunctionsChecker: Add better diagnostics

martong created this revision. martong added reviewers: Szelethus, NoQ, baloghadamsoftware, balazske, steakhal. Herald added subscribers: cfe-commits, ASDenysPetrov, Charusso, gamesh411, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, xazax.hun, whisperity. Herald added a

[PATCH] D79417: Don't assert about missing profile info in createProfileWeightsForLoop

thakis added a comment. Fair enough :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79417/new/ https://reviews.llvm.org/D79417 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D78190: Add Bfloat IR type

stuij added a comment. So are we happy with the patch as it is? Anybody else wants to LGTM? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78190/new/ https://reviews.llvm.org/D78190 ___ cfe-commits

[PATCH] D78190: Add Bfloat IR type

stuij added a comment. In D78190#2020701 , @stuij wrote: > In D78190#2018685 , @fpetrogalli > wrote: > > > 3. Do you need those changes in the Hexagon and x86 backend? Could they be > > submitted separately, with

[PATCH] D79417: Don't assert about missing profile info in createProfileWeightsForLoop

This revision was automatically updated to reflect the committed changes. Closed by commit rG55b9b11fea3e: Dont assert about missing profile info in createProfileWeightsForLoop (authored by hans). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D79432: [analyzer] StdLibraryFunctionsChecker: Add summaries for libc

martong created this revision. martong added reviewers: Szelethus, NoQ, baloghadamsoftware, balazske, steakhal. Herald added subscribers: cfe-commits, ASDenysPetrov, Charusso, gamesh411, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, xazax.hun, whisperity. Herald added a

[PATCH] D78827: Add support for #pragma clang fp reassociate(fast|off) -- floating point control of associative math transformations

rjmccall added a comment. The reason we call FP contraction "fast" instead of "on" when it's cross-statement is because "on" is supposed to be consistent with the C language rules, whereas "fast" is stronger. There's no analogous situation with reassociation; I don't think the C standard is

[clang] 8fc7a90 - Let normalize() for posix style convert backslash to slash unconditionally.

Author: Nico Weber Date: 2020-05-05T13:54:55-04:00 New Revision: 8fc7a907b93a8e9eef96e872f8f926db3ebfe9b6 URL: https://github.com/llvm/llvm-project/commit/8fc7a907b93a8e9eef96e872f8f926db3ebfe9b6 DIFF: https://github.com/llvm/llvm-project/commit/8fc7a907b93a8e9eef96e872f8f926db3ebfe9b6.diff

[PATCH] D79434: [analyzer] Generalize bitwise AND rules for ranges

vsavchenko added a comment. Here is a little proof I've put together (using Z3): https://gist.github.com/SavchenkoValeriy/2355170159ce1febd27498c36ea22149 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79434/new/ https://reviews.llvm.org/D79434

[PATCH] D79336: [analyzer] Generalize bitwise OR rules for ranges

vsavchenko updated this revision to Diff 262171. vsavchenko added a comment. Fix clang-format issue Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79336/new/ https://reviews.llvm.org/D79336 Files:

[PATCH] D79432: [analyzer] StdLibraryFunctionsChecker: Add summaries for libc

Szelethus added a comment. There a couple functional lines commented out, and we need more tests, so I take that the patch is a proof of concept for now? Because its pretty cool if so. :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79432/new/

[PATCH] D77954: [CUDA][HIP] Fix host/device based overload resolution

tra added a comment. It appears that re-landed b46b1a916d44216f0c70de55ae2123eb9de69027 has created another compilation regression. I don't have a simple reproducer yet, so here's the error message for now:

[PATCH] D79276: [FileCheck] Support comment directives

jdenny updated this revision to Diff 262185. jdenny added a comment. My last update accidentally included D79375 . This strips it back out. Sorry about that. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79276/new/ https://reviews.llvm.org/D79276

[PATCH] D74668: [Clang][BPF] implement __builtin_btf_type_id() builtin function

anakryiko added a comment. In D74668#2020554 , @yonghong-song wrote: > In D74668#2019558 , @anakryiko wrote: > > > what's the use case for flag==0 (no relocation)? why using built-in at all > > in such case? Also

[PATCH] D79276: [FileCheck] Support comment directives

jdenny updated this revision to Diff 262141. jdenny marked 14 inline comments as done. jdenny added a comment. Applied most reviewer comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79276/new/ https://reviews.llvm.org/D79276 Files: clang/test/CodeGen/default-address-space.c

[PATCH] D78655: [HIP] Add -fhip-lambda-host-device

tra added a comment. > I agree with Richard that just making lambdas HD by default in all modes > seems like the right rule. Ack. Let's give it a try. I'll test this on our code and see what falls out. Stay tuned. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78655/new/

[PATCH] D74572: [BPF] preserve debuginfo types for builtin __builtin__btf_type_id()

yonghong-song updated this revision to Diff 262140. yonghong-song edited the summary of this revision. yonghong-song added a comment. change buitin flag to the following spec: flag == 0: a local relocation against bpf_prog BTF change flag == 1: a remote relocation against kernel

[PATCH] D77148: [analyzer] ApiModeling: Add buffer size arg constraint with multiplier involved

Szelethus accepted this revision. Szelethus added a comment. This revision is now accepted and ready to land. LGTM! Comment at: clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp:1041 + EvalCallAsPure) +

[PATCH] D79276: [FileCheck] Support comment directives

jdenny added inline comments. Comment at: llvm/lib/Support/FileCheck.cpp:1928 static const char *DefaultCheckPrefixes[] = {"CHECK"}; +static const char *DefaultCommentPrefixes[] = {"COM", "RUN"}; jhenderson wrote: > Similar to what I mentioned in D79375,

[PATCH] D78190: Add Bfloat IR type

stuij added a comment. In D78190#2018685 , @fpetrogalli wrote: > 1. Shouldn't we test also that the parser is happy with the following > expressions? Added. Thanks. > 2. Would it make sense to to split this patch into 2 separate patches? One > that

[PATCH] D79417: Don't assert about missing profile info in createProfileWeightsForLoop

hans added a comment. In D79417#2020607 , @thakis wrote: > Could there be a test for this? Or is that difficult? I think it would be a bit of a pain, which is why I skipped it. It also wouldn't be a very interesting test, just "don't assert here",

[PATCH] D78660: [SemaObjC] Add a warning for dictionary literals with duplicate keys

rjmccall accepted this revision. rjmccall added a comment. Anyway, LGTM. Comment at: clang/lib/Sema/SemaExprObjC.cpp:948 +checkOneKey(IntegralKeys, Result.Val.getInt(), Loc); + } +} erik.pilkington wrote: > bendjones wrote: > > rjmccall wrote:

[PATCH] D79430: [analyzer] StdLibraryFunctionsChecker: Add LazyRanges to support type dependent Max

martong created this revision. martong added reviewers: Szelethus, NoQ, baloghadamsoftware, balazske, steakhal. Herald added subscribers: cfe-commits, ASDenysPetrov, Charusso, gamesh411, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, xazax.hun, whisperity. Herald added a

[PATCH] D79354: [clang-format] [PR34574] Handle [[nodiscard]] attribute in class declaration

krasimir added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:2401 // The actual identifier can be a nested name specifier, and in macros // it is often token-pasted. while (FormatTok->isOneOf(tok::identifier, tok::coloncolon, tok::hashhash,

[PATCH] D79354: [clang-format] [PR34574] Handle [[nodiscard]] attribute in class declaration

krasimir added a comment. I have an example where this goes wrong in ObjC (modulo indentation): struct Stuff stuff[] = {

[clang] 55b9b11 - Don't assert about missing profile info in createProfileWeightsForLoop

Author: Hans Wennborg Date: 2020-05-05T18:59:00+02:00 New Revision: 55b9b11fea3e18b6826c39842bc43877d9eb57fd URL: https://github.com/llvm/llvm-project/commit/55b9b11fea3e18b6826c39842bc43877d9eb57fd DIFF: https://github.com/llvm/llvm-project/commit/55b9b11fea3e18b6826c39842bc43877d9eb57fd.diff

[PATCH] D79118: Implement _ExtInt ABI for all ABIs in Clang, enable type for ABIs

rjmccall added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:4938 +if (EIT->getNumBits() > 128) + return getNaturalAlignIndirect(Ty, /*ByVal=*/true); + erichkeane wrote: > rjmccall wrote: > > rjmccall wrote: > > > erichkeane wrote: > > >

[PATCH] D79433: [analyzer] StdLibraryFunctionsChecker: Add summaries for POSIX

martong created this revision. martong added reviewers: Szelethus, NoQ, baloghadamsoftware, balazske, steakhal. Herald added subscribers: cfe-commits, ASDenysPetrov, Charusso, gamesh411, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, xazax.hun, whisperity. Herald added a

[PATCH] D79434: [analyzer] Generalize bitwise AND rules for ranges

vsavchenko updated this revision to Diff 262158. vsavchenko added a comment. Add parent change Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79434/new/ https://reviews.llvm.org/D79434 Files:

[PATCH] D79434: [analyzer] Generalize bitwise AND rules for ranges

vsavchenko created this revision. vsavchenko added reviewers: NoQ, dcoughlin. vsavchenko added a project: clang. Herald added subscribers: cfe-commits, ASDenysPetrov, martong, Charusso, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. vsavchenko

[PATCH] D79395: [clang][codegen] Hoist parameter attribute setting in function prolog.

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79395/new/ https://reviews.llvm.org/D79395

[PATCH] D79236: [docs] Regenerate DiagnosticsReference.rst

rsandifo-arm reclaimed this revision. rsandifo-arm added a comment. OK, thanks! Reclaiming and reopening the revision in that case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79236/new/ https://reviews.llvm.org/D79236

[PATCH] D79336: [analyzer] Generalize bitwise OR rules for ranges

vsavchenko updated this revision to Diff 262163. vsavchenko added a comment. Fix few things here and there Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79336/new/ https://reviews.llvm.org/D79336 Files:

[PATCH] D79394: [clang][codegen] Refactor argument loading in function prolog. NFC.

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Oh, yes, if `Fn->getArg(n)` is no longer an `O(n)` linked-list walk, then this seems like a great change. I see that that happened... slightly over three years ago. Hooray for legacies.

[PATCH] D79035: [clang][AIX] Implement ABIInfo and TargetCodeGenInfo for AIX

ZarkoCA added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:4368 + + return emitVoidPtrVAArg(CGF, VAListAddr, Ty, /*Indirect*/ false, TypeInfo, + SlotSize, /*AllowHigher*/ true); Is there a reason why Indirect is set to

[PATCH] D79414: [clang-format] C# always regards && as a binary operator

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. LGTM, thank you Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79414/new/ https://reviews.llvm.org/D79414

[PATCH] D78869: clang-format: Add ControlStatementsExceptForEachMacros option to SpaceBeforeParens

MyDeveloperDay added a comment. In D78869#2019933 , @DaanDeMeyer wrote: > (I don't have commit access so it'd be great if someone could merge this for > me, at least that's how my other contributions have been handled) You really should think about

[PATCH] D79414: [clang-format] C# always regards && as a binary operator

jbcoe created this revision. jbcoe added reviewers: krasimir, MyDeveloperDay. jbcoe added a project: clang-format. Herald added a project: clang. Herald added a subscriber: cfe-commits. MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready

[PATCH] D78444: Perform ActOnConversionDeclarator after looking for any virtual functions it overrides

rdwampler added a comment. Ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78444/new/ https://reviews.llvm.org/D78444 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D79380: [clang-tidy] In TransformerClangTidyCheck, support option SourceNamingStyle.

ymandel added a comment. In D79380#2020135 , @gribozavr2 wrote: > > It's only effect is to determine how a given file is related to header > > files, specifically how to determine that a header "corresponds" to a the > > file being examined -- that is,

[PATCH] D79388: [clang-format] Fix AlignConsecutive on PP blocks

MyDeveloperDay added a comment. In D79388#2019985 , @JakeMerdichAMD wrote: > @MyDeveloperDay, you're right about what this issue addresses: it surprised > me a lot when an unrelated edit caused something to 'randomly' add spaces > elsewhere, since it's

[PATCH] D78546: Enable bugprone-argument-comments check in llvm.

hokein added a comment. In D78546#2005306 , @sammccall wrote: > > LLVM code style encourages this > > Not very strongly, it just says it can be helpful (and tells you how to do it > if you do it). So I'm wary of making it mandatory in cases where it

[PATCH] D79358: [analyzer] CERT: STR37-C

Szelethus added a comment. I'm afraid so. The patch otherwise looked really clean, sorry to ruin the day! :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79358/new/ https://reviews.llvm.org/D79358

[PATCH] D78190: Add Bfloat IR type

fpetrogalli accepted this revision. fpetrogalli added a comment. Hi @stuij, thank you for adding the vector tests. I can say the patch LGTM now :) Francesco Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78190/new/ https://reviews.llvm.org/D78190

[PATCH] D79426: [clangd] Change PreambleOnlyAction with content truncation

kadircet updated this revision to Diff 262132. kadircet added a comment. - Add test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79426/new/ https://reviews.llvm.org/D79426 Files: clang-tools-extra/clangd/Preamble.cpp

[PATCH] D79118: Implement _ExtInt ABI for all ABIs in Clang, enable type for ABIs

erichkeane updated this revision to Diff 262093. erichkeane added a comment. Extracted out a function for PPC64's coerce to array. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79118/new/ https://reviews.llvm.org/D79118 Files: clang/lib/Basic/Targets/AArch64.h

[PATCH] D79118: Implement _ExtInt ABI for all ABIs in Clang, enable type for ABIs

erichkeane marked an inline comment as done. erichkeane added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:4938 +if (EIT->getNumBits() > 128) + return getNaturalAlignIndirect(Ty, /*ByVal=*/true); + rjmccall wrote: > rjmccall wrote: > >

[PATCH] D78660: [SemaObjC] Add a warning for dictionary literals with duplicate keys

erik.pilkington marked an inline comment as done. erik.pilkington added inline comments. Comment at: clang/lib/Sema/SemaExprObjC.cpp:948 +checkOneKey(IntegralKeys, Result.Val.getInt(), Loc); + } +} bendjones wrote: > rjmccall wrote: > > Does

[PATCH] D79415: [analyzer][MalloChecker] When modeling realloc-like functions, don't early return if the argument is symbolic

Szelethus created this revision. Szelethus added reviewers: NoQ, balazske, martong, baloghadamsoftware, vsavchenko, xazax.hun, dcoughlin. Szelethus added a project: clang. Herald added subscribers: cfe-commits, ASDenysPetrov, steakhal, Charusso, gamesh411, dkrupp, donat.nagy, mikhail.ramalho,

[PATCH] D79336: [analyzer] Generalize bitwise OR rules for ranges

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Math looks good to me :) Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:388 + /// it will return the range [x_0, y_N]. + static Range roughen(RangeSet

[PATCH] D79414: [clang-format] C# always regards && as a binary operator

This revision was automatically updated to reflect the committed changes. Closed by commit rG047898c9aa1d: [clang-format] C# always regards as a binary operator (authored by Jonathan Coe jb...@google.com). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D79380: [clang-tidy] In TransformerClangTidyCheck, support option IncludeStyle.

This revision was automatically updated to reflect the committed changes. Closed by commit rGc5b1a0352535: [clang-tidy] In TransformerClangTidyCheck, support option IncludeStyle. (authored by ymandel). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D79423: [analyzer][NFC] StdLibraryFunctionsChecker: Add empty Signatures

martong created this revision. martong added reviewers: Szelethus, NoQ, baloghadamsoftware, balazske, steakhal. Herald added subscribers: cfe-commits, ASDenysPetrov, Charusso, gamesh411, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, xazax.hun, whisperity. Herald added a

[PATCH] D79265: Let normalize() for posix style convert backslash to slash unconditionally.

compnerd accepted this revision. compnerd added a comment. This revision is now accepted and ready to land. Seems reasonable, especially since none of the other tests break. I don't fully remember the reason for the special case, and if it ever turns up, we can address it then. CHANGES SINCE

[PATCH] D79388: [clang-format] Fix AlignConsecutive on PP blocks

MyDeveloperDay added a comment. In D79388#2020320 , @JakeMerdichAMD wrote: > Sure, I'll get started on that. It mainly comes from charging headfirst into > the edge cases, but I think I have a decent grasp of clang-format internals > now, and I'm

[PATCH] D77066: [analyzer] ApiModeling: Add buffer size arg constraint

martong added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77066/new/ https://reviews.llvm.org/D77066 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] 684dc1b - Elaborate more on --rocm-path flag.

Author: Matt Arsenault Date: 2020-05-05T09:33:18-04:00 New Revision: 684dc1bebe5cb70cfd27923940f9f8cba4f13195 URL: https://github.com/llvm/llvm-project/commit/684dc1bebe5cb70cfd27923940f9f8cba4f13195 DIFF:

[PATCH] D79388: [clang-format] Fix AlignConsecutive on PP blocks

JakeMerdichAMD added a comment. Sure, I'll get started on that. It mainly comes from charging headfirst into the edge cases, but I think I have a decent grasp of clang-format internals now, and I'm definitely interested in both contributing to and reviewing for it. Repository: rG LLVM

  1   2   3   >