[PATCH] D79744: clang: Add address space to indirect abi info and use it for kernels

rjmccall added a comment. I don't understand why `noalias` is even a concern if the whole buffer passed to the kernel is read-only. `noalias` is primarily about proving non-interference, but if you can tell IR that the buffer is read-only, that's a much more powerful statement. Regardless,

[PATCH] D77491: [Sema] Introduce BuiltinAttr, per-declaration builtin-ness

tambre updated this revision to Diff 264447. tambre marked 3 inline comments as done. tambre added a comment. Fix adding BuiltinAttr in C++ mode. Update one test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77491/new/

[PATCH] D79744: clang: Add address space to indirect abi info and use it for kernels

jdoerfert added a comment. Drive by, I haven't read the entire history. In D79744#2040208 , @rjmccall wrote: > I don't understand why `noalias` is even a concern if the whole buffer passed > to the kernel is read-only. `noalias` is primarily about

[clang] 0ee46e8 - [nfc] test commit

Author: faisal vali Date: 2020-05-16T15:08:30-05:00 New Revision: 0ee46e857d81ea815e5b11d266c0c118a2c2e714 URL: https://github.com/llvm/llvm-project/commit/0ee46e857d81ea815e5b11d266c0c118a2c2e714 DIFF: https://github.com/llvm/llvm-project/commit/0ee46e857d81ea815e5b11d266c0c118a2c2e714.diff

[PATCH] D79655: [WebAssembly] Handle exception specifications

thakis added a comment. The revert broke check-clang on several bots, e.g. here http://lab.llvm.org:8011/builders/clang-ppc64be-linux-lnt/builds/38159 Can you take a look please? The tree's been red all of today due to this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D76077: [ARM] Add __bf16 as new Bfloat16 C Type

stuij marked 4 inline comments as done. stuij added a comment. @LukeGeeson: you're already mentioned :) See the commits tab on this review. But Simon Tatham needs a mention as well. I shall add him. Comment at: clang/docs/LanguageExtensions.rst:518 +Clang supports three

[PATCH] D79919: [Driver] Pass -plugin-opt=O2 for -Os -Oz and -plugin-opt=O1 for -Og

xbolva00 added a comment. Great! Maybe worth to add a release note that -Os works with LTO? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79919/new/ https://reviews.llvm.org/D79919 ___ cfe-commits

[clang] 49c9a68 - The release notes for ObjCBreakBeforeNestedBlockParam was placed between the release note for IndentCaseBlocks and its example code

Author: mydeveloperday Date: 2020-05-16T18:52:13+01:00 New Revision: 49c9a68d7fc62aabdf4d625fcb2954555496772b URL: https://github.com/llvm/llvm-project/commit/49c9a68d7fc62aabdf4d625fcb2954555496772b DIFF:

[PATCH] D80046: [StackSafety] Make full LTO to attach metadata if MTE is enabled

efriedma added a comment. If I'm understanding this correctly, the stack-safe metadata on allocas is both produced and consumed at LTO-time. So at the point where the stack-safe metadata would be produced, we can compute whether any later passes will query it. Given that, why do you need a

[PATCH] D79322: [FEnv] Small fixes to implementation of flt.rounds

craig.topper added inline comments. Comment at: llvm/test/CodeGen/RISCV/flt-rounds.ll:23 +; RV64I-NEXT:sd ra, 8(sp) +; RV64I-NEXT:call __flt_rounds +; RV64I-NEXT:ld ra, 8(sp) sepavloff wrote: > lenary wrote: > > I'm interested to understand how this

[clang] 32870a8 - Expose IRGen API to add the default IR attributes to a function definition.

Author: John McCall Date: 2020-05-16T14:44:54-04:00 New Revision: 32870a84d9a40ea682e22a24b5f0d1a218c3b062 URL: https://github.com/llvm/llvm-project/commit/32870a84d9a40ea682e22a24b5f0d1a218c3b062 DIFF: https://github.com/llvm/llvm-project/commit/32870a84d9a40ea682e22a24b5f0d1a218c3b062.diff

[clang] accd9af - Revert "[nfc] test commit"

Author: faisal vali Date: 2020-05-16T15:12:04-05:00 New Revision: accd9af838b071ff6e8ba4ff3c99a2542cd0ce25 URL: https://github.com/llvm/llvm-project/commit/accd9af838b071ff6e8ba4ff3c99a2542cd0ce25 DIFF: https://github.com/llvm/llvm-project/commit/accd9af838b071ff6e8ba4ff3c99a2542cd0ce25.diff

[PATCH] D75791: [clang-format] Added new option IndentExternBlock

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. LGTM just drop the `Noindent` it will encourage inconsistency people can read the manual (plus you don't check it in the tests) Comment at:

[PATCH] D77491: [Sema] Introduce BuiltinAttr, per-declaration builtin-ness

rjmccall added a comment. @rsmith This is a big enough architectural change that I'd appreciate your sign-off on the basic approach. Comment at: clang/lib/Sema/SemaDecl.cpp:3759 unsigned BuiltinID; - if (Old->isImplicit() && (BuiltinID = Old->getBuiltinID())) { + bool

[clang] bc98dc1 - Try to heal bots after https://reviews.llvm.org/D79655

Author: Nico Weber Date: 2020-05-16T20:32:58-04:00 New Revision: bc98dc12d8382b45ff9beed82236c9274f4435ff URL: https://github.com/llvm/llvm-project/commit/bc98dc12d8382b45ff9beed82236c9274f4435ff DIFF: https://github.com/llvm/llvm-project/commit/bc98dc12d8382b45ff9beed82236c9274f4435ff.diff

[PATCH] D77221: [AVR] Rework MCU family detection to support more AVR MCUs

dylanmckay added a comment. @aykevl > A thought: should the AVR family be included in the target triple? Like > avr5-unknown-unknown (similar to armv6m-none-eabi, armv7m-none-eabi, etc). > The different variations do sometimes change the architecture in > incompatible ways, such as with the

[clang] 3735505 - Fix a few doc typos to cycle bots.

Author: Nico Weber Date: 2020-05-16T20:38:28-04:00 New Revision: 3735505e4ffd0117de93d344fc0549151a205d11 URL: https://github.com/llvm/llvm-project/commit/3735505e4ffd0117de93d344fc0549151a205d11 DIFF: https://github.com/llvm/llvm-project/commit/3735505e4ffd0117de93d344fc0549151a205d11.diff

[PATCH] D79754: [OpenMP][AMDGCN] Support OpenMP offloading for AMDGCN architecture - Part 1

sameerds added inline comments. Comment at: clang/lib/AST/Decl.cpp:3221 +!hasAttr()) || + Context.getTargetInfo().getTriple().isAMDGCN()) && !(BuiltinID == Builtin::BIprintf || BuiltinID == Builtin::BImalloc)) sameerds wrote: > This seems

[PATCH] D80061: [WebAssembly] Handle exception specifications

aheejin updated this revision to Diff 264466. aheejin added a comment. - Add missing `-` after `-o` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80061/new/ https://reviews.llvm.org/D80061 Files: clang/docs/DiagnosticsReference.rst

[PATCH] D79655: [WebAssembly] Handle exception specifications

thakis added inline comments. Comment at: clang/test/CodeGenCXX/wasm-eh.cpp:387 +// RUN: %clang_cc1 %s -triple wasm32-unknown-unknown -fms-extensions -fexceptions -fcxx-exceptions -fwasm-exceptions -target-feature +exception-handling -emit-llvm -std=c++11 2>&1 | FileCheck %s

[PATCH] D75791: [clang-format] Added new option IndentExternBlock

MarcusJohnson91 marked an inline comment as done. MarcusJohnson91 added a comment. Removed the lowercase Noindent case, that was a last minute addition I thought might make it a tad easier to work with, but you're right I didn't even test it, and honestly adding that complexity is just

[PATCH] D79744: clang: Add address space to indirect abi info and use it for kernels

rjmccall added a comment. In D79744#2040348 , @jdoerfert wrote: > Drive by, I haven't read the entire history. > > In D79744#2040208 , @rjmccall wrote: > > > I don't understand why `noalias` is even a concern if

[PATCH] D79655: [WebAssembly] Handle exception specifications

aheejin marked an inline comment as done. aheejin added inline comments. Comment at: clang/test/CodeGenCXX/wasm-eh.cpp:387 +// RUN: %clang_cc1 %s -triple wasm32-unknown-unknown -fms-extensions -fexceptions -fcxx-exceptions -fwasm-exceptions -target-feature

[PATCH] D80061: [WebAssembly] Handle exception specifications

aheejin updated this revision to Diff 264461. aheejin added a comment. - Add missing -o Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80061/new/ https://reviews.llvm.org/D80061 Files: clang/docs/DiagnosticsReference.rst

[PATCH] D75791: [clang-format] Added new option IndentExternBlock

MarcusJohnson91 updated this revision to Diff 264462. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75791/new/ https://reviews.llvm.org/D75791 Files: clang/docs/ClangFormatStyleOptions.rst clang/docs/ReleaseNotes.rst clang/include/clang/Format/Format.h

[PATCH] D78491: Avoid relying on address space zero default parameter in llvm/IR

dylanmckay added a comment. Herald added a project: LLVM. I really like the idea behind this patch, but I suspect there is a better way to go about it. The only drawbacks to upstreaming this patch as-is is the idea that because it is implemented as a compiler define directive, it effectively

[PATCH] D79744: clang: Add address space to indirect abi info and use it for kernels

jdoerfert added a comment. In D79744#2040380 , @rjmccall wrote: > In D79744#2040348 , @jdoerfert wrote: > > > Drive by, I haven't read the entire history. > > > > In D79744#2040208

[PATCH] D79655: [WebAssembly] Handle exception specifications

aheejin added a comment. This is very strange. I haven't committed a file called wasm-eh.ll. (There is a file called wasm-eh.cpp, which existed for more than a year now.) Also there's no wasm-eh.ll in LLVM repo now either. I wonder how this happened..? Also I can't reproduce the bug in my

[PATCH] D80061: [WebAssembly] Handle exception specifications

aheejin created this revision. aheejin added a reviewer: dschuff. Herald added subscribers: cfe-commits, sunfish, jgravelle-google, sbc100. Herald added a project: clang. aheejin edited the summary of this revision. aheejin updated this revision to Diff 264423. aheejin added a comment. - rst file

[PATCH] D80061: [WebAssembly] Handle exception specifications

aheejin added a comment. This is an improved version of D79655 . The warning now can be suppressed by `-Wno-wasm-exception-spec`. To do this, we needed a diagnostic group. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D80061: [WebAssembly] Handle exception specifications

aheejin updated this revision to Diff 264423. aheejin added a comment. - rst file fix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80061/new/ https://reviews.llvm.org/D80061 Files: clang/docs/DiagnosticsReference.rst

[PATCH] D79655: [WebAssembly] Handle exception specifications

aheejin added a comment. Committed and reverted this. Resubmitted this in D80061 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79655/new/ https://reviews.llvm.org/D79655

[PATCH] D75791: [clang-format] Added new option IndentExternBlock

MarcusJohnson91 marked 3 inline comments as done. MarcusJohnson91 added a comment. I've fixed all of your comments as well as fixed the tests. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75791/new/ https://reviews.llvm.org/D75791 ___

[PATCH] D75791: [clang-format] Added new option IndentExternBlock

MarcusJohnson91 updated this revision to Diff 264439. MarcusJohnson91 added a comment. Removed forgotten comment from control logic of UnwrappedLineParser CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75791/new/ https://reviews.llvm.org/D75791 Files:

[PATCH] D75791: [clang-format] Added new option IndentExternBlock

MarcusJohnson91 updated this revision to Diff 264438. MarcusJohnson91 edited the summary of this revision. MarcusJohnson91 added a comment. Did everything you asked and did a littl bit of my own cleanup as well. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75791/new/

[PATCH] D79744: clang: Add address space to indirect abi info and use it for kernels

arsenm added a comment. In D79744#2035283 , @rjmccall wrote: > > A completely different approach: OpenMP has to solve some very similar > problems and just lowers them completely in the frontend; have you considered > just doing that? Kernels need

[PATCH] D77491: [Sema] Introduce BuiltinAttr, per-declaration builtin-ness

tambre updated this revision to Diff 264441. tambre added a comment. Herald added a reviewer: aaron.ballman. Rework builtin declaration handling. Introduce BuiltinAttr. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77491/new/