[PATCH] D80362: [WebAssembly] Warn on exception spec only when Wasm EH is used

2020-05-21 Thread Heejin Ahn via Phabricator via cfe-commits
aheejin updated this revision to Diff 265432. aheejin added a comment. - Fix warning message Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80362/new/ https://reviews.llvm.org/D80362 Files: clang/docs/DiagnosticsReference.rst

[PATCH] D80295: [Sema] Diagnose static data members in classes nested in unnamed classes

2020-05-21 Thread John McCall via Phabricator via cfe-commits
rjmccall added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:6904 << Name << RD->getTagKind(); Invalid = true; +} else if (RD->isLocalClass()) { This diagnostic actually ignores the tag kind that passed down to it,

[PATCH] D76791: [Matrix] Implement matrix index expressions ([][]).

2020-05-21 Thread John McCall via Phabricator via cfe-commits
rjmccall added a comment. Sorry for the slow review; I'm getting crushed with review requests. Comment at: clang/lib/AST/Expr.cpp:3859 + + auto *SubscriptE = dyn_cast(this); + return SubscriptE You need to `IgnoreParens()` here. Comment

[PATCH] D71739: [AssumeBundles] Use operand bundles to encode alignment assumptions

2020-05-21 Thread John McCall via Phabricator via cfe-commits
rjmccall added a comment. Is there a good reason for this to use the same `llvm.assume` intrinsic as before? Are there restrictions about what assumptions can be combined on a single intrinsic call? There can only be one bundle of a particular name on an instruction, right?

[PATCH] D57890: [analyzer] Fix in self assignment checker

2020-05-21 Thread Balogh , Ádám via Phabricator via cfe-commits
baloghadamsoftware added a comment. Herald added subscribers: ASDenysPetrov, martong, steakhal. I think you can create a unit test for this: create a pre-call checker that checks for the assignment operator and asserts that we are not in top level. Create a test code with a simple class without

[PATCH] D80366: [Analyzer] Add `getReturnValueUnderConstruction()` to `CallEvent`

2020-05-21 Thread Balogh , Ádám via Phabricator via cfe-commits
baloghadamsoftware created this revision. baloghadamsoftware added reviewers: NoQ, Szelethus. baloghadamsoftware added a project: clang. Herald added subscribers: ASDenysPetrov, martong, steakhal, Charusso, gamesh411, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, xazax.hun,

[PATCH] D69987: [RISCV] Assemble/Disassemble v-ext instructions.

2020-05-21 Thread Ferran Pallarès Roca via Phabricator via cfe-commits
fpallares added inline comments. Comment at: llvm/lib/Target/RISCV/AsmParser/RISCVAsmParser.cpp:2283 + unsigned Src2Reg = Inst.getOperand(1).getReg(); + if (DestReg == Src2Reg) +return Error(Loc, "The destination vector register group cannot overlap"

[PATCH] D80362: [WebAssembly] Warn on exception spec only when Wasm EH is used

2020-05-21 Thread Heejin Ahn via Phabricator via cfe-commits
aheejin created this revision. aheejin added a reviewer: dschuff. Herald added subscribers: cfe-commits, sunfish, jgravelle-google, sbc100. Herald added a project: clang. In D80061 we added warning for exception specifications with types (such as `throw(int)`),

[PATCH] D78938: Fixing all comparisons for C++20 compilation.

2020-05-21 Thread David Stone via Phabricator via cfe-commits
davidstone added inline comments. Herald added a subscriber: sstefan1. Comment at: llvm/include/llvm/ADT/DirectedGraph.h:97 + } + friend bool operator!=(const NodeType , const NodeType ) { !(M == N); } Missing `return` Repository: rG LLVM Github Monorepo

[PATCH] D80360: [PCH] Support writing BuiltinBitCastExprs to PCHs

2020-05-21 Thread hyd-dev via Phabricator via cfe-commits
hyd-dev updated this revision to Diff 265436. hyd-dev added a comment. Format the test `builtin-bit-cast.cpp`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80360/new/ https://reviews.llvm.org/D80360 Files: clang/include/clang/AST/ExprCXX.h

[PATCH] D80317: [SYCL] Prohibit arithmetic operations for incompatible pointers

2020-05-21 Thread John McCall via Phabricator via cfe-commits
rjmccall added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:10090 // if both are pointers check if operation is valid wrt address spaces - if (S.getLangOpts().OpenCL && isLHSPointer && isRHSPointer) { + if ((S.getLangOpts().OpenCL ||

[clang] c2c36c4 - [clang][index] Fix a crash for accessing a null field decl.

2020-05-21 Thread Haojian Wu via cfe-commits
Author: Haojian Wu Date: 2020-05-21T09:47:36+02:00 New Revision: c2c36c4f4b69ade6d8610b1dc98ff9f02c94320d URL: https://github.com/llvm/llvm-project/commit/c2c36c4f4b69ade6d8610b1dc98ff9f02c94320d DIFF: https://github.com/llvm/llvm-project/commit/c2c36c4f4b69ade6d8610b1dc98ff9f02c94320d.diff

[PATCH] D80360: [PCH] Support writing BuiltinBitCastExprs to PCHs

2020-05-21 Thread hyd-dev via Phabricator via cfe-commits
hyd-dev created this revision. hyd-dev added reviewers: erik.pilkington, rsmith. hyd-dev added a project: clang. Herald added subscribers: cfe-commits, dexonsmith. hyd-dev edited the summary of this revision. hyd-dev edited the summary of this revision. D62825

[PATCH] D80323: [SVE] Eliminate calls to default-false VectorType::get() from Clang

2020-05-21 Thread John McCall via Phabricator via cfe-commits
rjmccall added a comment. I'm sympathetic to wanting to get rid of the boolean flag, but this is a really invasive change for pretty minimal benefit. Why not leave `VectorType::get` as meaning a non-scalable vector type and come up with a different method name to get a scalable vector?

[PATCH] D80344: [Windows SEH]: HARDWARE EXCEPTION HANDLING (MSVC option -EHa)

2020-05-21 Thread Ten Tzen via Phabricator via cfe-commits
tentzen updated this revision to Diff 265442. tentzen added a comment. fixed formats Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80344/new/ https://reviews.llvm.org/D80344 Files: clang/include/clang/AST/Stmt.h

[PATCH] D79921: [OPENMP] Fix mixture of omp and clang pragmas

2020-05-21 Thread ISHIGURO, Hiroshi via Phabricator via cfe-commits
hishiguro updated this revision to Diff 265450. hishiguro added a comment. Thank you for your comment. I updated source. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79921/new/ https://reviews.llvm.org/D79921 Files: clang/lib/CodeGen/CGStmtOpenMP.cpp

[PATCH] D77802: [analyzer] Improved RangeSet::Negate support of unsigned ranges

2020-05-21 Thread Valeriy Savchenko via Phabricator via cfe-commits
vsavchenko added a comment. @NoQ @ASDenysPetrov I will rebase my changes - no worries :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77802/new/ https://reviews.llvm.org/D77802 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D78099: [analyzer][RetainCount] Tie diagnostics to osx.cocoa.RetainCount rather then RetainCountBase, for the most part

2020-05-21 Thread Gabor Marton via Phabricator via cfe-commits
martong requested changes to this revision. martong added a comment. This revision now requires changes to proceed. Found a small mistake that should be corrected, then will be good to me. Comment at:

[PATCH] D80371: [clang-tidy] Fix potential assert in use-noexcept check

2020-05-21 Thread Nathan James via Phabricator via cfe-commits
njames93 created this revision. njames93 added reviewers: aaron.ballman, alexfh, gribozavr2. Herald added subscribers: cfe-commits, xazax.hun. Herald added a project: clang. Fix a potential assert in use-noexcept check if there is an issue getting the `TypeSourceInfo` as well as a small clean

[clang] eeff1a9 - [analyzer][CallAndMessage][NFC] Split up checkPreCall

2020-05-21 Thread Kirstóf Umann via cfe-commits
Author: Kirstóf Umann Date: 2020-05-21T12:54:56+02:00 New Revision: eeff1a970a6bb09d3c046313e229e2871929cd63 URL: https://github.com/llvm/llvm-project/commit/eeff1a970a6bb09d3c046313e229e2871929cd63 DIFF: https://github.com/llvm/llvm-project/commit/eeff1a970a6bb09d3c046313e229e2871929cd63.diff

[PATCH] D77846: [analyzer][CallAndMessage][NFC] Split up checkPreCall

2020-05-21 Thread Kristóf Umann via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGeeff1a970a6b: [analyzer][CallAndMessage][NFC] Split up checkPreCall (authored by Szelethus). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77846/new/

[PATCH] D46665: [Itanium] Emit type info names with external linkage.

2020-05-21 Thread Louis Dionne via Phabricator via cfe-commits
ldionne added a comment. Herald added subscribers: mstorsjo, dexonsmith. Note: this commit was re-reverted in commit bbb2655de0049f8e6cf4482702aa616011c851c1 Author: Richard Smith Date: Mon May 21 20:10:54 2018 + Revert r332028; see PR37545 for details. llvm-svn:

[PATCH] D47092: downgrade strong type info names to weak_odr linkage

2020-05-21 Thread Louis Dionne via Phabricator via cfe-commits
ldionne added a comment. I'm revisiting http://llvm.org/PR37398 as it looks like a pretty serious bug to me. I read http://llvm.org/D46665, this patch and http://llvm.org/PR37545, and my understanding is that this patch supersedes @EricWF 's original patch http://llvm.org/D46665. The only

[PATCH] D80018: [Analyzer][StreamChecker] Added check for "indeterminate file position".

2020-05-21 Thread Balázs Kéri via Phabricator via cfe-commits
balazske marked 4 inline comments as done. balazske added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StreamChecker.cpp:107 + /// This value applies to all error states in ErrorState except FEOF. + /// An EOF+indeterminate state is the same as EOF state. +

[PATCH] D80366: [Analyzer] Add `getReturnValueUnderConstruction()` to `CallEvent`

2020-05-21 Thread Kristóf Umann via Phabricator via cfe-commits
Szelethus added a comment. I think adding a better getter to `StackFrameContext` would make the patch a tad nicer, but other than that, I don't have much to add to this patch, unfortunately :) The code looks nice and we definitely need something like this. Comment at:

[PATCH] D77846: [analyzer][CallAndMessage][NFC] Split up checkPreCall

2020-05-21 Thread Balázs Kéri via Phabricator via cfe-commits
balazske accepted this revision. balazske added a comment. This revision is now accepted and ready to land. Looks good. Not sure if it work in all cases after the `MallocChecker` problems but we can fix problems if any later. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77846/new/

[PATCH] D77802: [analyzer] Improved RangeSet::Negate support of unsigned ranges

2020-05-21 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ accepted this revision. NoQ added a subscriber: vsavchenko. NoQ added a comment. This revision is now accepted and ready to land. Looks fantastic, thanks! I guess let's race with @vsavchenko on whoever commits first :p CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77802/new/

[PATCH] D77474: [analyzer][MallocChecker] Make NewDeleteLeaks depend on DynamicMemoryModeling rather than NewDelete

2020-05-21 Thread Gabor Marton via Phabricator via cfe-commits
martong added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/PathSensitive/CheckerContext.h:194 + const ProgramPointTag *Tag = nullptr) { +// Say this 3 times fast. +State = State ? State : getState(); I like the

[PATCH] D80374: [Clang] Enable KF and KC mode for [_Complex] __float128

2020-05-21 Thread Nemanja Ivanovic via Phabricator via cfe-commits
nemanjai created this revision. nemanjai added reviewers: rjmccall, rsmith, PowerPC, hfinkel. Herald added subscribers: dexonsmith, kbarton. Herald added a reviewer: aaron.ballman. Herald added a project: clang. The headers provided with recent GNU toolchains for PPC have code that includes

[PATCH] D80369: [DebugInfo] Remove decl subprograms from 'retainedTypes:'

2020-05-21 Thread Djordje Todorovic via Phabricator via cfe-commits
djtodoro created this revision. djtodoro added reviewers: dblaikie, aprantl, vsk. djtodoro added projects: LLVM, debug-info. Herald added a project: clang. Herald added a subscriber: cfe-commits. After the D70350 , the `retainedTypes:` isn't being used for the

[PATCH] D80018: [Analyzer][StreamChecker] Added check for "indeterminate file position".

2020-05-21 Thread Kristóf Umann via Phabricator via cfe-commits
Szelethus added a subscriber: NoQ. Szelethus added a comment. I have more questions than actual objections, but here we go! The patch looks nice overall, we just need to iron a few things out ahead of time. Comment at: clang/lib/StaticAnalyzer/Checkers/StreamChecker.cpp:107 +

[PATCH] D80018: [Analyzer][StreamChecker] Added check for "indeterminate file position".

2020-05-21 Thread Kristóf Umann via Phabricator via cfe-commits
Szelethus added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StreamChecker.cpp:107 + /// This value applies to all error states in ErrorState except FEOF. + /// An EOF+indeterminate state is the same as EOF state. + bool FilePositionIndeterminate = false;

[PATCH] D80300: [Driver] Add DEFAULT_DYLD_PREFIX and DEFAULT_RPATH to complement DEFAULT_SYSROOT

2020-05-21 Thread Nemanja Ivanovic via Phabricator via cfe-commits
nemanjai accepted this revision. nemanjai added subscribers: tstellar, brad, craig.topper, joerg. nemanjai added a comment. This revision is now accepted and ready to land. Thank you for sorting this out. I think it is quite useful to be able to configure the compiler to use complete

[PATCH] D80018: [Analyzer][StreamChecker] Added check for "indeterminate file position".

2020-05-21 Thread Kristóf Umann via Phabricator via cfe-commits
Szelethus added inline comments. Comment at: clang/test/Analysis/stream-error.c:182 +} else { + fwrite(Buf, 1, 10, F); // expected-warning {{might be 'indeterminate'}} +} Szelethus wrote: > Here the user checked whether F is in eof or in ferror, and

[PATCH] D80251: [X86] Update some av512 shift intrinsics to use "unsigned int" parameter instead of int to match Intel documentaiton

2020-05-21 Thread Craig Topper via Phabricator via cfe-commits
craig.topper added a comment. In D80251#2049418 , @RKSimon wrote: > Can we add -Wsign-conversion checks to the tests? That was mentioned on > PR45931 I can. Will that do anything other than show that my test_* functions were updated to match the new

[PATCH] D80404: [OPENMP50]Initial support for use_device_addr clause.

2020-05-21 Thread Alexey Bataev via Phabricator via cfe-commits
ABataev created this revision. ABataev added a reviewer: jdoerfert. Herald added subscribers: llvm-commits, sstefan1, arphaman, guansong, yaxunl. Herald added projects: clang, LLVM. Added parsing/sema analysis/serialization support for use_device_addr clauses. Repository: rG LLVM Github

[PATCH] D76420: Prevent IR-gen from emitting consteval declarations

2020-05-21 Thread Richard Smith - zygoloid via Phabricator via cfe-commits
rsmith accepted this revision. rsmith marked an inline comment as done. rsmith added a comment. This revision is now accepted and ready to land. Thanks! Looks good. I'd like to eventually get to a point where every `ConstantExpr` that reaches code generation has `hasAPValueResult()` return

[clang] 9d23b50 - [PS4] Enable relaxed relocations by default

2020-05-21 Thread Ben Dunbobbin via cfe-commits
Author: Ben Dunbobbin Date: 2020-05-21T23:05:44+01:00 New Revision: 9d23b5025d5f6614a2b2b1b6fc19997f0fb69138 URL: https://github.com/llvm/llvm-project/commit/9d23b5025d5f6614a2b2b1b6fc19997f0fb69138 DIFF: https://github.com/llvm/llvm-project/commit/9d23b5025d5f6614a2b2b1b6fc19997f0fb69138.diff

[PATCH] D80416: [RFC][OpenCL] Set fp contract flag on -cl-mad-enable

2020-05-21 Thread Matt Arsenault via Phabricator via cfe-commits
arsenm added a comment. The langref wording makes me think this isn't quite right. This depends on your definition of floating point contraction. I've always assumed it meant allow FMA, potentially increasing precision. Is contracting into something less precise allowed? If not, that's

[PATCH] D71726: Let clang atomic builtins fetch add/sub support floating point types

2020-05-21 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl updated this revision to Diff 265606. yaxunl marked 2 inline comments as done. yaxunl edited the summary of this revision. yaxunl added a reviewer: tra. yaxunl added a comment. check supported fp atomics by bits. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71726/new/

[PATCH] D79895: Add a new warning to warn when passing uninitialized variables as const reference parameters to a function

2020-05-21 Thread Zequan Wu via Phabricator via cfe-commits
zequanwu updated this revision to Diff 265605. zequanwu marked 2 inline comments as done. zequanwu added a comment. rename parameter `uses` to `um` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79895/new/ https://reviews.llvm.org/D79895 Files:

[clang] a30d411 - Set traversal explicitly where needed in tests

2020-05-21 Thread Stephen Kelly via cfe-commits
Author: Stephen Kelly Date: 2020-05-21T22:34:38+01:00 New Revision: a30d411629d5425dedb0dadd616d0faabb611798 URL: https://github.com/llvm/llvm-project/commit/a30d411629d5425dedb0dadd616d0faabb611798 DIFF: https://github.com/llvm/llvm-project/commit/a30d411629d5425dedb0dadd616d0faabb611798.diff

[PATCH] D71726: Let clang atomic builtins fetch add/sub support floating point types

2020-05-21 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl marked 3 inline comments as done. yaxunl added inline comments. Comment at: clang/include/clang/Basic/TargetInfo.h:1418 + /// Whether floating point atomic fetch add/sub is supported. + virtual bool isFPAtomicFetchAddSubSupported() const { return false; } +

[clang] f85aedc - Make the ExprMutationAnalyzer explicit about how it traverses the AST

2020-05-21 Thread Stephen Kelly via cfe-commits
Author: Stephen Kelly Date: 2020-05-21T22:34:38+01:00 New Revision: f85aedc167cde76bdb47b7814f873cfb40ad3ed8 URL: https://github.com/llvm/llvm-project/commit/f85aedc167cde76bdb47b7814f873cfb40ad3ed8 DIFF: https://github.com/llvm/llvm-project/commit/f85aedc167cde76bdb47b7814f873cfb40ad3ed8.diff

[PATCH] D79895: Add a new warning to warn when passing uninitialized variables as const reference parameters to a function

2020-05-21 Thread Zequan Wu via Phabricator via cfe-commits
zequanwu added inline comments. Comment at: clang/lib/Sema/AnalysisBasedWarnings.cpp:1590-1600 +// flush all const reference uses diags +for (const auto : constRefUses) { + const VarDecl *vd = P.first; + const MappedType = P.second; + + UsesVec *vec =

[PATCH] D77177: [Analyzer][WebKit] RefCntblBaseVirtualDtorChecker & shared utils

2020-05-21 Thread Jan Korous via Phabricator via cfe-commits
jkorous added a comment. In D77177#2049805 , @thakis wrote: > This breaks the build everywhere (e.g. > http://45.33.8.238/linux/18283/step_4.txt) and has been in for over an hour. > Please watch bots after landing. (I think changes that are created more

[PATCH] D80409: [MS ABI] Add mangled type for template integer argument

2020-05-21 Thread Zequan Wu via Phabricator via cfe-commits
zequanwu created this revision. zequanwu added a reviewer: thakis. zequanwu added a project: clang. Herald added a subscriber: cfe-commits. To differentiate different types of template integer arguments, as MSVC does. Bug filed here: https://bugs.llvm.org/show_bug.cgi?id=45969 which is caused by

[PATCH] D80417: Fix Darwin 'constinit thread_local' variables.

2020-05-21 Thread James Y Knight via Phabricator via cfe-commits
jyknight created this revision. jyknight added a reviewer: rjmccall. Herald added a project: clang. Herald added a subscriber: cfe-commits. Unlike other platforms using ItaniumCXXABI, Darwin does not allow the creation of a thread-wrapper function for a variable in the TU of users. Because of

[PATCH] D80421: [Mips] use correct ld.so for musl soft float

2020-05-21 Thread Joe Holden via Phabricator via cfe-commits
joewholden created this revision. Herald added subscribers: cfe-commits, atanasyan, arichardson, sdardis. Herald added a project: clang. This patch attempts to fix the dynamic linker path for mips64-sf, I'm not entirely familiar with the llvm structure so I am unsure if this is the best way but

[PATCH] D80222: Replace Clang's createRuntimeFunction with the definitions in OMPKinds.def

2020-05-21 Thread Johannes Doerfert via Phabricator via cfe-commits
jdoerfert added a subscriber: fghanim. jdoerfert added inline comments. Comment at: llvm/include/llvm/Frontend/OpenMP/OMPKinds.def:244 -// TODO: Replace this with the real size_t type -#define __OMP_SIZE_TYPE(NAME) OMP_TYPE(NAME, Type::getInt64Ty(Ctx)) +#define

[PATCH] D80126: Add documentation URL records to the .dia format and expose them via libclang

2020-05-21 Thread Owen Voorhees via Phabricator via cfe-commits
owenv updated this revision to Diff 265592. owenv added a comment. - Update a few comments - Simplify test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80126/new/ https://reviews.llvm.org/D80126 Files: clang/include/clang-c/Index.h

[PATCH] D80126: Add documentation URL records to the .dia format and expose them via libclang

2020-05-21 Thread Owen Voorhees via Phabricator via cfe-commits
owenv marked an inline comment as done. owenv added a comment. @jkorous I'd like to add support for urls in clang-emitted diagnostics too, but I can't really commit to a timeframe for getting that done atm. I'm hoping to have some time to work on it in the next few weeks.

[PATCH] D79842: [clang][Driver] Correct tool search path priority

2020-05-21 Thread Nick Desaulniers via Phabricator via cfe-commits
nickdesaulniers added inline comments. Comment at: clang/lib/Driver/Driver.cpp:4730 + return std::string(P.str()); + } } else { style nit: are the `{}` on the `for` necessary? Comment at:

[PATCH] D80301: [yaml][clang-tidy] Fix new line YAML serialization

2020-05-21 Thread Matthias Gehre via Phabricator via cfe-commits
mgehre added a comment. Thanks for doing this! I didn't work on the YAML parser before, so I cannot give formal approval. Comment at: llvm/lib/Support/YAMLTraits.cpp:904 + std::string ) { + Val.clear(); + size_t CurrentPos = 0;

[PATCH] D80126: Add documentation URL records to the .dia format and expose them via libclang

2020-05-21 Thread Owen Voorhees via Phabricator via cfe-commits
owenv marked an inline comment as done. owenv added inline comments. Comment at: clang/lib/Frontend/SerializedDiagnosticReader.cpp:323 + // A documentation URL has an ID and path size. + if (Record.size() != 2) +return SDError::MalformedDiagnosticRecord;

[PATCH] D79895: Add a new warning to warn when passing uninitialized variables as const reference parameters to a function

2020-05-21 Thread Arthur Eubanks via Phabricator via cfe-commits
aeubanks accepted this revision. aeubanks added a comment. This revision is now accepted and ready to land. One last nit, otherwise lgtm. But I'm not super familiar with this area, it'd be good to get another review from somebody more familiar. Comment at:

[clang] e36076e - [clang] Add nomerge function attribute to clang

2020-05-21 Thread Zequan Wu via cfe-commits
Author: Zequan Wu Date: 2020-05-21T17:07:39-07:00 New Revision: e36076ee3a2ebc6013372d9b71e6bb09e8612366 URL: https://github.com/llvm/llvm-project/commit/e36076ee3a2ebc6013372d9b71e6bb09e8612366 DIFF: https://github.com/llvm/llvm-project/commit/e36076ee3a2ebc6013372d9b71e6bb09e8612366.diff

[PATCH] D79980: [PS4] Enable relaxed relocations by default

2020-05-21 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG9d23b5025d5f: [PS4] Enable relaxed relocations by default (authored by Ben Dunbobbin ben_dunbob...@sn.scee.net). Herald added a project: clang. Herald added a subscriber: cfe-commits. Changed prior to

[clang] b0a0f01 - Revert "Add nomerge function attribute to clang"

2020-05-21 Thread Zequan Wu via cfe-commits
Author: Zequan Wu Date: 2020-05-21T16:13:18-07:00 New Revision: b0a0f01bc175b4c444052f871a89421889f8b5ce URL: https://github.com/llvm/llvm-project/commit/b0a0f01bc175b4c444052f871a89421889f8b5ce DIFF: https://github.com/llvm/llvm-project/commit/b0a0f01bc175b4c444052f871a89421889f8b5ce.diff

[clang] 307e853 - Add nomerge function attribute to clang

2020-05-21 Thread Zequan Wu via cfe-commits
Author: Zequan Wu Date: 2020-05-21T15:28:27-07:00 New Revision: 307e85395485e1eff9533b2d7952b16f33ceae38 URL: https://github.com/llvm/llvm-project/commit/307e85395485e1eff9533b2d7952b16f33ceae38 DIFF: https://github.com/llvm/llvm-project/commit/307e85395485e1eff9533b2d7952b16f33ceae38.diff

[PATCH] D80294: Add support for vmsumudm

2020-05-21 Thread Amy Kwan via Phabricator via cfe-commits
amyk added inline comments. Comment at: llvm/lib/Target/PowerPC/PPCInstrAltivec.td:1365 +// Vector Multiply-Sum +def VMSUMUDM : VA1a_Int_Ty3<35, "vmsumudm", int_ppc_altivec_vmsumudm, Maybe we can put this definition near the other VMSUM instructions? Since

[PATCH] D72534: Change default traversal in AST Matchers to ignore invisible nodes

2020-05-21 Thread Stephen Kelly via Phabricator via cfe-commits
steveire updated this revision to Diff 265626. steveire added a comment. Touch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72534/new/ https://reviews.llvm.org/D72534 Files: clang/docs/ReleaseNotes.rst

[PATCH] D80362: [WebAssembly] Warn on exception spec only when Wasm EH is used

2020-05-21 Thread Heejin Ahn via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG48acac362938: [WebAssembly] Warn on exception spec only when Wasm EH is used (authored by aheejin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80362/new/

[PATCH] D79121: Add nomerge statement attribute to clang

2020-05-21 Thread Zequan Wu via Phabricator via cfe-commits
zequanwu updated this revision to Diff 265648. zequanwu retitled this revision from "Add nomerge function attribute to clang" to "Add nomerge statement attribute to clang". zequanwu edited the summary of this revision. zequanwu added a comment. update test case. CHANGES SINCE LAST ACTION

[PATCH] D80039: [NFC, StackSafety] LTO tests for MTE and StackSafety

2020-05-21 Thread Evgenii Stepanov via Phabricator via cfe-commits
eugenis accepted this revision. eugenis added a comment. This revision is now accepted and ready to land. LGTM, but the comments at the start of each run are confusing - they describe the desired, not the current state. Maybe move FIXME on the same line? Repository: rG LLVM Github Monorepo

[PATCH] D79830: Add support of __builtin_expect_with_probability

2020-05-21 Thread Zhi Zhuang via Phabricator via cfe-commits
LukeZhuang updated this revision to Diff 265598. LukeZhuang added a comment. **Updated: 05/21/2020** 1. add assertion after evaluate probability 2. remove value dependent check in SemaChecking 3. add test case handling value-dependent template CHANGES SINCE LAST ACTION

[PATCH] D66564: [clang-tidy] new altera struct pack align check

2020-05-21 Thread Eugene Zelenko via Phabricator via cfe-commits
Eugene.Zelenko added a comment. In D66564#2049664 , @ffrankies wrote: > @Eugene.Zelenko Just checking in, is there anything I missed regarding what > we need to do for these checks? It'll be good idea to ping reviewers. Repository: rG LLVM Github

[PATCH] D79830: Add support of __builtin_expect_with_probability

2020-05-21 Thread Zhi Zhuang via Phabricator via cfe-commits
LukeZhuang marked 8 inline comments as done. LukeZhuang added a comment. In D79830#2049582 , @erichkeane wrote: > FYI: I'm more of a clang contributor, so I'm unable to review the LLVM code, > hopefully someone will come along who can check on that.

[PATCH] D80369: WIP: [DebugInfo] Remove decl subprograms from 'retainedTypes:'

2020-05-21 Thread David Blaikie via Phabricator via cfe-commits
dblaikie added a comment. In D80369#2048932 , @djtodoro wrote: > Still have test failing: > > Clang :: Modules/DebugInfoTransitiveImport.m > Clang :: Modules/ModuleDebugInfo.cpp > Clang :: Modules/ModuleDebugInfo.m > > > I haven't looked into the

[clang] 54e91a3 - Reland "[Analyzer][WebKit] RefCntblBaseVirtualDtorChecker"

2020-05-21 Thread Jan Korous via cfe-commits
Author: Jan Korous Date: 2020-05-21T16:41:00-07:00 New Revision: 54e91a3c701040d9d2e467bd483c197073b2c5e4 URL: https://github.com/llvm/llvm-project/commit/54e91a3c701040d9d2e467bd483c197073b2c5e4 DIFF: https://github.com/llvm/llvm-project/commit/54e91a3c701040d9d2e467bd483c197073b2c5e4.diff

[clang] 48acac3 - [WebAssembly] Warn on exception spec only when Wasm EH is used

2020-05-21 Thread Heejin Ahn via cfe-commits
Author: Heejin Ahn Date: 2020-05-21T17:08:35-07:00 New Revision: 48acac36293805cef10b448d49d336da7db7bfa9 URL: https://github.com/llvm/llvm-project/commit/48acac36293805cef10b448d49d336da7db7bfa9 DIFF: https://github.com/llvm/llvm-project/commit/48acac36293805cef10b448d49d336da7db7bfa9.diff

[PATCH] D72531: Set traversal explicitly where needed in tests

2020-05-21 Thread Stephen Kelly via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGa30d411629d5: Set traversal explicitly where needed in tests (authored by stephenkelly). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72531/new/

[PATCH] D72532: Make the ExprMutationAnalyzer explicit about how it traverses the AST

2020-05-21 Thread Stephen Kelly via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGf85aedc167cd: Make the ExprMutationAnalyzer explicit about how it traverses the AST (authored by stephenkelly). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D80412: Summary: [Lexer] Fix invalid suffix diagnostic for fixed-point literals

2020-05-21 Thread Arthi via Phabricator via cfe-commits
nagart created this revision. nagart added a reviewer: ebevhan. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D80412 Files: clang/include/clang/Basic/DiagnosticLexKinds.td

[PATCH] D50078: clang-format: support aligned nested conditionals formatting

2020-05-21 Thread Steven Johnson via Phabricator via cfe-commits
srj added a comment. I think the new formatting is unquestionably better than the old formatting. But... This change means that the output from clang-format-11 can't be made compatible with older versions of clang-format, which is also unfortunate. IMHO it should be a goal to have "breaking"

[PATCH] D80362: [WebAssembly] Warn on exception spec only when Wasm EH is used

2020-05-21 Thread Heejin Ahn via Phabricator via cfe-commits
aheejin updated this revision to Diff 265645. aheejin added a comment. Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80362/new/ https://reviews.llvm.org/D80362 Files: clang/lib/CodeGen/CGException.cpp

[PATCH] D80294: Add support for vmsumudm

2020-05-21 Thread Ahsan Saghir via Phabricator via cfe-commits
saghir marked an inline comment as done. saghir added inline comments. Comment at: llvm/lib/Target/PowerPC/PPCInstrAltivec.td:1365 +// Vector Multiply-Sum +def VMSUMUDM : VA1a_Int_Ty3<35, "vmsumudm", int_ppc_altivec_vmsumudm, amyk wrote: > Maybe we can put

[PATCH] D69764: [clang-format] Add Left/Right Const fixer capability

2020-05-21 Thread Stephen Kelly via Phabricator via cfe-commits
steveire added a comment. I like the approach of using clang-format to implement this. It's much faster than a `clang-tidy` approach. The broader C++ community has already chosen `East`/`West` and it has momentum. If you choose `Left`/`Right` now, you will get pressure to add `East`/`West` in

[PATCH] D80416: [RFC][OpenCL] Set fp contract flag on -cl-mad-enable

2020-05-21 Thread Anastasia Stulova via Phabricator via cfe-commits
Anastasia marked an inline comment as done. Anastasia added inline comments. Comment at: clang/test/CodeGenOpenCL/relaxed-fpmath.cl:21 +float fused_mad(float a, float b, float c) { + // NORMAL: @llvm.fmuladd.f32 + // FAST: fmul fast float I don't find this

[PATCH] D80415: [AIX] Add '-bcdtors:all:0:s' to linker to gather static init functions

2020-05-21 Thread Steven Wan via Phabricator via cfe-commits
stevewan created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. stevewan added reviewers: hubert.reinterpretcast, Xiangling_L, ZarkoCA, daltenty. On AIX, add '-bcdtors:all:0:s' to linker implicitly through driver, so that we can collect all static

[PATCH] D80416: [RFC][OpenCL] Set fp contract flag on -cl-mad-enable

2020-05-21 Thread Anastasia Stulova via Phabricator via cfe-commits
Anastasia created this revision. Anastasia added reviewers: rjmccall, arsenm. Herald added subscribers: ebevhan, yaxunl, wdng. Anastasia marked an inline comment as done. Anastasia added inline comments. Anastasia retitled this revision from "[RCF][OpenCL] Set fp contract flag on -cl-mad-enable"

[PATCH] D72959: Relative VTables ABI on Fuchsia

2020-05-21 Thread John McCall via Phabricator via cfe-commits
rjmccall added a comment. Otherwise LGTM. Comment at: clang/lib/CodeGen/CGVTables.cpp:633 + llvm::Module = CGM.getModule(); + llvm::SmallString<16> componentName(globalVal->getName()); + `componentName` seems to no longer be used meaningfully. in this

[PATCH] D79800: [Sema] Remove default values for arguments prior to a parameter pack if the pack is used

2020-05-21 Thread Arthur O'Dwyer via Phabricator via cfe-commits
Quuxplusone added inline comments. Comment at: clang/test/CXX/drs/dr7xx.cpp:225 template void f(int i = 0, T ...args) {} void ff() { f(); } Is this even supposed to compile? The only valid specializations of `f` require `T...` to be an empty pack, which

[PATCH] D80222: Replace Clang's createRuntimeFunction with the definitions in OMPKinds.def

2020-05-21 Thread Fady Ghanim via Phabricator via cfe-commits
fghanim added inline comments. Comment at: llvm/include/llvm/Frontend/OpenMP/OMPKinds.def:244 -// TODO: Replace this with the real size_t type -#define __OMP_SIZE_TYPE(NAME) OMP_TYPE(NAME, Type::getInt64Ty(Ctx)) +#define __OMP_SIZE_TYPE(NAME) OMP_TYPE(NAME,

[PATCH] D79800: [Sema] Remove default values for arguments prior to a parameter pack if the pack is used

2020-05-21 Thread John McCall via Phabricator via cfe-commits
rjmccall added a comment. I wrote this comment but apparently never submitted it on Phabricator, sorry. Comment at: clang/lib/Sema/SemaTemplateInstantiateDecl.cpp:1987 + +if (Function->getNumParams() >= NumTemplatedParams) { + unsigned FirstDefault = 0;

[PATCH] D79921: [OPENMP] Fix mixture of omp and clang pragmas

2020-05-21 Thread KAWASHIMA Takahiro via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGac2c5af67f03: [OPENMP] Fix mixture of omp and clang pragmas (authored by hishiguro, committed by kawashima-fj). Changed prior to commit: https://reviews.llvm.org/D79921?vs=265450=265667#toc

[PATCH] D79800: [Sema] Remove default values for arguments prior to a parameter pack if the pack is used

2020-05-21 Thread Raul Tambre via Phabricator via cfe-commits
tambre added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79800/new/ https://reviews.llvm.org/D79800 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D80366: [Analyzer] Add `getReturnValueUnderConstruction()` to `CallEvent`

2020-05-21 Thread Balogh , Ádám via Phabricator via cfe-commits
baloghadamsoftware marked an inline comment as done. baloghadamsoftware added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/CallEvent.cpp:552 + + Index = StackFrame->getIndex(); + Szelethus wrote: > This mustn't be serious.

[clang] ac2c5af - [OPENMP] Fix mixture of omp and clang pragmas

2020-05-21 Thread KAWASHIMA Takahiro via cfe-commits
Author: ISHIGURO, Hiroshi Date: 2020-05-22T12:53:37+09:00 New Revision: ac2c5af67f036ec810556372b16548ae9b663f36 URL: https://github.com/llvm/llvm-project/commit/ac2c5af67f036ec810556372b16548ae9b663f36 DIFF:

[clang] 4cd696f - [X86] Allow avx512vp2intersect to be used with __builtin_cpu_supports.

2020-05-21 Thread Craig Topper via cfe-commits
Author: Craig Topper Date: 2020-05-21T21:54:54-07:00 New Revision: 4cd696f92fde5fa0bc570ca059e0f1ce7344c807 URL: https://github.com/llvm/llvm-project/commit/4cd696f92fde5fa0bc570ca059e0f1ce7344c807 DIFF: https://github.com/llvm/llvm-project/commit/4cd696f92fde5fa0bc570ca059e0f1ce7344c807.diff

[PATCH] D80362: [WebAssembly] Warn on exception spec only when Wasm EH is used

2020-05-21 Thread Derek Schuff via Phabricator via cfe-commits
dschuff accepted this revision. dschuff added a comment. This revision is now accepted and ready to land. otherwise LGTM Comment at: clang/docs/DiagnosticsReference.rst:14018

[clang] f7c7e8a - [Analyzer][WebKit] RefCntblBaseVirtualDtorChecker

2020-05-21 Thread Jan Korous via cfe-commits
Author: Jan Korous Date: 2020-05-21T11:54:49-07:00 New Revision: f7c7e8a523f56b0ed1b14c0756ba4e5d1ccb48d2 URL: https://github.com/llvm/llvm-project/commit/f7c7e8a523f56b0ed1b14c0756ba4e5d1ccb48d2 DIFF: https://github.com/llvm/llvm-project/commit/f7c7e8a523f56b0ed1b14c0756ba4e5d1ccb48d2.diff

[PATCH] D66564: [clang-tidy] new altera struct pack align check

2020-05-21 Thread Frank Derry Wanye via Phabricator via cfe-commits
ffrankies added a comment. @Eugene.Zelenko Just checking in, is there anything I missed regarding what we need to do for these checks? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66564/new/ https://reviews.llvm.org/D66564

[PATCH] D79972: [OpenMP5.0] map item can be non-contiguous for target update

2020-05-21 Thread Chi Chun Chen via Phabricator via cfe-commits
cchen updated this revision to Diff 265562. cchen added a comment. Herald added a subscriber: sstefan1. Remove redundant code Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79972/new/ https://reviews.llvm.org/D79972 Files:

[PATCH] D79972: [OpenMP5.0] map item can be non-contiguous for target update

2020-05-21 Thread Chi Chun Chen via Phabricator via cfe-commits
cchen added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79972/new/ https://reviews.llvm.org/D79972 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D77177: [Analyzer][WebKit] RefCntblBaseVirtualDtorChecker & shared utils

2020-05-21 Thread Jan Korous via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGf7c7e8a523f5: [Analyzer][WebKit] RefCntblBaseVirtualDtorChecker (authored by jkorous). Herald added a project: clang. Herald added a subscriber: cfe-commits. Changed prior to commit:

[PATCH] D71726: Let clang atomic builtins fetch add/sub support floating point types

2020-05-21 Thread Louis Dionne via Phabricator via cfe-commits
ldionne added inline comments. Comment at: clang/test/CodeGen/atomic-ops.c:296 + // CHECK: fsub + return __atomic_sub_fetch(p, 1.0, memory_order_relaxed); +} yaxunl wrote: > ldionne wrote: > > Sorry if that's a dumb question, but I'm a bit confused: `p` is a

[PATCH] D80222: Replace Clang's createRuntimeFunction with the definitions in OMPKinds.def

2020-05-21 Thread Joseph Huber via Phabricator via cfe-commits
jhuber6 marked 2 inline comments as done. jhuber6 added inline comments. Comment at: llvm/include/llvm/Frontend/OpenMP/OMPIRBuilder.h:203 + static Function *getOrCreateRuntimeFunction(Module , + omp::RuntimeFunction FnID);

[PATCH] D80317: [SYCL] Prohibit arithmetic operations for incompatible pointers

2020-05-21 Thread John McCall via Phabricator via cfe-commits
rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/include/clang/AST/Type.h:1069 + /// qualifiers. + bool isAddressSpaceOverlapping(const QualType ) const { +Qualifiers Q = getQualifiers();

[PATCH] D80315: Fix CC1 command line options mapping into fast-math flags.

2020-05-21 Thread Anastasia Stulova via Phabricator via cfe-commits
Anastasia added inline comments. Comment at: clang/test/CodeGenOpenCL/relaxed-fpmath.cl:14 // FINITE: fdiv nnan ninf float - // UNSAFE: fdiv nnan nsz float + // UNSAFE: fdiv reassoc nsz arcp afn float // MAD: fdiv float michele.scandale wrote: > This

  1   2   >