[PATCH] D80237: [hip] Ensure pointer in struct argument has proper `addrspacecast`.

2020-05-22 Thread Michael Liao via Phabricator via cfe-commits
hliao marked an inline comment as done. hliao added a comment. In D80237#2051887 , @rjmccall wrote: > `addrspacecast` might be a real conversion. I feel like this is really going > well beyond what argument coercion should be expected to do, and we need

[PATCH] D80251: [X86] Update some av512 shift intrinsics to use "unsigned int" parameter instead of int to match Intel documentaiton

2020-05-22 Thread Craig Topper via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG1b02db52b79e: [X86] Update some av512 shift intrinsics to use unsigned int parameter… (authored by craig.topper). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D80237: [hip] Ensure pointer in struct argument has proper `addrspacecast`.

2020-05-22 Thread Michael Liao via Phabricator via cfe-commits
hliao added a comment. In D80237#2051918 , @rjmccall wrote: > In D80237#2051909 , @hliao wrote: > > > In D80237#2051887 , @rjmccall > > wrote: > > > > > `addrspacecast`

[PATCH] D80237: [hip] Ensure pointer in struct argument has proper `addrspacecast`.

2020-05-22 Thread John McCall via Phabricator via cfe-commits
rjmccall added a comment. Okay. Can you explain why we need to coerce in the first place, though? Especially if the representation is the same, why is your target-lowering requiring parameters to be coerced to involve pointers in a different address space? Repository: rG LLVM Github

[PATCH] D76793: [Matrix] Implement + and - operators for MatrixType.

2020-05-22 Thread John McCall via Phabricator via cfe-commits
rjmccall added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:11989 + else +return false; + I would suggest checking some preconditions and then just calling `PrepareScalarCast`. You should allow implicit conversions from class types, which

[PATCH] D80417: Fix Darwin 'constinit thread_local' variables.

2020-05-22 Thread Hubert Tong via Phabricator via cfe-commits
hubert.reinterpretcast added subscribers: rsmith, hubert.reinterpretcast. hubert.reinterpretcast added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:4145 + // referenced directly, without calling the thread-wrapper, so the linkage + // must not be changed. +

[clang] 1b02db5 - [X86] Update some av512 shift intrinsics to use "unsigned int" parameter instead of int to match Intel documentation

2020-05-22 Thread Craig Topper via cfe-commits
Author: Craig Topper Date: 2020-05-22T20:12:57-07:00 New Revision: 1b02db52b79e01f038775f59193a49850a34184d URL: https://github.com/llvm/llvm-project/commit/1b02db52b79e01f038775f59193a49850a34184d DIFF: https://github.com/llvm/llvm-project/commit/1b02db52b79e01f038775f59193a49850a34184d.diff

[PATCH] D79744: clang: Add address space to indirect abi info and use it for kernels

2020-05-22 Thread John McCall via Phabricator via cfe-commits
rjmccall added a comment. In D79744#2047482 , @arsenm wrote: > In D79744#2040731 , @rjmccall wrote: > > > In D79744#2040434 , @jdoerfert > > wrote: > > > > > In

[PATCH] D79800: [Sema] Remove default values for arguments prior to a parameter pack if the pack is used

2020-05-22 Thread John McCall via Phabricator via cfe-commits
rjmccall added inline comments. Comment at: clang/test/CXX/drs/dr7xx.cpp:225 template void f(int i = 0, T ...args) {} void ff() { f(); } Quuxplusone wrote: > Is this even supposed to compile? The only valid specializations of `f` > require `T...` to be an

[PATCH] D80423: [analyzer] SATestBuild.py: Refactor and add type annotations

2020-05-22 Thread Valeriy Savchenko via Phabricator via cfe-commits
vsavchenko updated this revision to Diff 265682. vsavchenko added a comment. Fix update diffs Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80423/new/ https://reviews.llvm.org/D80423 Files: clang/utils/analyzer/SATestAdd.py

[PATCH] D65050: [SemaTemplate] Mark a function type as dependent when its parameter list contains pack expansion

2020-05-22 Thread S. B. Tam via Phabricator via cfe-commits
cpplearner updated this revision to Diff 265683. cpplearner added a comment. rebase & ping @rsmith CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65050/new/ https://reviews.llvm.org/D65050 Files: clang/lib/AST/Type.cpp clang/test/SemaTemplate/alias-templates.cpp Index:

[PATCH] D80424: [analyzer] SATestUtils.py: Refactor and add type annotations

2020-05-22 Thread Valeriy Savchenko via Phabricator via cfe-commits
vsavchenko updated this revision to Diff 265680. vsavchenko added a comment. Modify forgotten parts Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80424/new/ https://reviews.llvm.org/D80424 Files: clang/utils/analyzer/SATestBuild.py

[PATCH] D80424: [analyzer] SATestUtils.py: Refactor and add type annotations

2020-05-22 Thread Valeriy Savchenko via Phabricator via cfe-commits
vsavchenko created this revision. vsavchenko added reviewers: NoQ, dcoughlin. Herald added subscribers: cfe-commits, ASDenysPetrov, Charusso, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a project: clang. vsavchenko updated this

[PATCH] D79800: [Sema] Remove default values for arguments prior to a parameter pack if the pack is used

2020-05-22 Thread Arthur O'Dwyer via Phabricator via cfe-commits
Quuxplusone added inline comments. Comment at: clang/test/CXX/drs/dr7xx.cpp:225 template void f(int i = 0, T ...args) {} void ff() { f(); } rjmccall wrote: > Quuxplusone wrote: > > Is this even supposed to compile? The only valid specializations of `f` > >

[PATCH] D80423: [analyzer] SATestBuild.py: Refactor and add type annotations

2020-05-22 Thread Valeriy Savchenko via Phabricator via cfe-commits
vsavchenko created this revision. vsavchenko added reviewers: NoQ, dcoughlin. Herald added subscribers: cfe-commits, ASDenysPetrov, Charusso, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a project: clang. SATest scripts should be

[PATCH] D80003: [clang][clang-scan-deps] Add a mode that can compute overhead in duplicated module builds

2020-05-22 Thread Daniel Grumberg via Phabricator via cfe-commits
dang updated this revision to Diff 265676. dang added a comment. Rebase this on top of the new AST Signature patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80003/new/ https://reviews.llvm.org/D80003 Files:

[PATCH] D80344: [Windows SEH]: HARDWARE EXCEPTION HANDLING (MSVC option -EHa)

2020-05-22 Thread Ten Tzen via Phabricator via cfe-commits
tentzen updated this revision to Diff 265672. tentzen added a comment. avoid lint warnings and lint hang on Windows Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80344/new/ https://reviews.llvm.org/D80344 Files: clang/include/clang/AST/Stmt.h

[PATCH] D80366: [Analyzer] Add `getReturnValueUnderConstruction()` to `CallEvent`

2020-05-22 Thread Balázs Kéri via Phabricator via cfe-commits
balazske added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/PathSensitive/CallEvent.h:435 + /// If the call returns a C++ record type then the region of its return value + // can be retrieved from its construction context. + Optional

[PATCH] D80421: [Mips] use correct ld.so for musl soft float

2020-05-22 Thread Simon Atanasyan via Phabricator via cfe-commits
atanasyan added a reviewer: atanasyan. atanasyan added a comment. 1. Please include as much context as possible with your diff. This instruction helps to do that. 2. Such patch needs test case(s). Maybe it's

[PATCH] D69764: [clang-format] Add Left/Right Const fixer capability

2020-05-22 Thread MyDeveloperDay via Phabricator via cfe-commits
MyDeveloperDay added a comment. In D69764#2050226 , @steveire wrote: > I like the approach of using clang-format to implement this. It's much faster > than a `clang-tidy` approach. > > The broader C++ community has already chosen `East`/`West` and it

[PATCH] D80279: [libclang] Extend clang_Cursor_Evaluate().

2020-05-22 Thread Christian Kandeler via Phabricator via cfe-commits
ckandeler added a comment. Thanks for the quick review. I don't have commit access, so can someone please commit it for me? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80279/new/ https://reviews.llvm.org/D80279

[PATCH] D80079: [clang-format] [NFC] isCpp() is inconsistently used to mean both C++ and Objective C, add language specific isXXX() functions

2020-05-22 Thread MyDeveloperDay via Phabricator via cfe-commits
MyDeveloperDay updated this revision to Diff 265684. MyDeveloperDay added a comment. Switch to new function name suggestions CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80079/new/ https://reviews.llvm.org/D80079 Files: clang/include/clang/Format/Format.h

[PATCH] D80425: Fix LLVM/Clang builds with mingw toolchain

2020-05-22 Thread Tobias Hieta via Phabricator via cfe-commits
thieta created this revision. Herald added subscribers: llvm-commits, cfe-commits, mstorsjo, dexonsmith, mgorny. Herald added projects: clang, LLVM. These are a collection of small fixes to make LLVM/Clang build with a clang+mingw toolchain to target Windows. The three commits address the

[PATCH] D80428: [clang] Optimize getFileIDLocal

2020-05-22 Thread Marco Elver via Phabricator via cfe-commits
melver created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. - Avoid bit operations to compute Offset by removing bitfields. On 64-bit architectures, SLocEntry's size is unchanged. - Provide branch-prediction hints to compiler to generate better code.

[PATCH] D50078: clang-format: support aligned nested conditionals formatting

2020-05-22 Thread Francois Ferrand via Phabricator via cfe-commits
Typz added a comment. In D50078#2050623 , @MyDeveloperDay wrote: > I get the point about Opt In, and if we are going to add an option it needs > to go in ASAP otherwise too many people will then start complaining it was on > by default before. > > To

[PATCH] D80366: [Analyzer] Add `getReturnValueUnderConstruction()` to `CallEvent`

2020-05-22 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/ExprEngineCXX.cpp:112 +Optional ExprEngine::retrieveFromConstructionContext( +ProgramStateRef State, const LocationContext *LCtx, Please instead re-use the code that computes the object

[clang] 99b94f2 - [analyzer] LoopUnrolling: fix crash when a parameter is a loop counter.

2020-05-22 Thread Artem Dergachev via cfe-commits
Author: Artem Dergachev Date: 2020-05-22T16:14:48+03:00 New Revision: 99b94f29ac5dbbce0585d16f631359a66f279ea4 URL: https://github.com/llvm/llvm-project/commit/99b94f29ac5dbbce0585d16f631359a66f279ea4 DIFF:

[PATCH] D80416: [RFC][OpenCL] Set fp contract flag on -cl-mad-enable

2020-05-22 Thread Anastasia Stulova via Phabricator via cfe-commits
Anastasia added a comment. In D80416#2050250 , @arsenm wrote: > The langref wording makes me think this isn't quite right. This depends on > your definition of floating point contraction. I've always assumed it meant > allow FMA, potentially increasing

[PATCH] D80427: [analyzer] SumTimerInfo.py: Partially modernize

2020-05-22 Thread Valeriy Savchenko via Phabricator via cfe-commits
vsavchenko created this revision. vsavchenko added reviewers: NoQ, dcoughlin. Herald added subscribers: cfe-commits, ASDenysPetrov, Charusso, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a project: clang. Repository: rG LLVM

[PATCH] D80294: Add support for vmsumudm

2020-05-22 Thread Nemanja Ivanovic via Phabricator via cfe-commits
nemanjai accepted this revision. nemanjai added a comment. This revision is now accepted and ready to land. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80294/new/ https://reviews.llvm.org/D80294 ___ cfe-commits mailing list

[clang] aede24e - [PowerPC] Treat 'Z' inline asm constraint as a true memory constraint

2020-05-22 Thread Nemanja Ivanovic via cfe-commits
Author: Nemanja Ivanovic Date: 2020-05-22T07:59:21-05:00 New Revision: aede24ecaa08db806fb173faf2de9cff95df8cee URL: https://github.com/llvm/llvm-project/commit/aede24ecaa08db806fb173faf2de9cff95df8cee DIFF:

[clang] e95ee30 - [SYCL] Prohibit arithmetic operations for incompatible pointers

2020-05-22 Thread Alexey Bader via cfe-commits
Author: Alexey Bader Date: 2020-05-22T13:43:24+03:00 New Revision: e95ee300c0530158d86430fd82ffabd36262e862 URL: https://github.com/llvm/llvm-project/commit/e95ee300c0530158d86430fd82ffabd36262e862 DIFF: https://github.com/llvm/llvm-project/commit/e95ee300c0530158d86430fd82ffabd36262e862.diff

[clang] 4902ca6 - [analyzer] SATestBuild.py: Refactor and add type annotations

2020-05-22 Thread Valeriy Savchenko via cfe-commits
Author: Valeriy Savchenko Date: 2020-05-22T13:51:58+03:00 New Revision: 4902ca6da49b10dbc62e8e02109bf84ce96c94b5 URL: https://github.com/llvm/llvm-project/commit/4902ca6da49b10dbc62e8e02109bf84ce96c94b5 DIFF:

[clang] 5a9aff1 - [analyzer] SATestUpdateDiffs.py: Refactor and add type annotations

2020-05-22 Thread Valeriy Savchenko via cfe-commits
Author: Valeriy Savchenko Date: 2020-05-22T13:51:58+03:00 New Revision: 5a9aff12ff3bc68109f41930ec296b7a19cbe76c URL: https://github.com/llvm/llvm-project/commit/5a9aff12ff3bc68109f41930ec296b7a19cbe76c DIFF:

[clang] 7cebfa4 - [analyzer] SATestUtils.py: Refactor and add type annotations

2020-05-22 Thread Valeriy Savchenko via cfe-commits
Author: Valeriy Savchenko Date: 2020-05-22T13:51:58+03:00 New Revision: 7cebfa4e069265a146186e90bfa0a36135bf8aba URL: https://github.com/llvm/llvm-project/commit/7cebfa4e069265a146186e90bfa0a36135bf8aba DIFF:

[clang] 475d120 - [analyzer] SumTimerInfo.py: Partially modernize

2020-05-22 Thread Valeriy Savchenko via cfe-commits
Author: Valeriy Savchenko Date: 2020-05-22T13:51:58+03:00 New Revision: 475d1202837071959f3f69d3512c820538d81543 URL: https://github.com/llvm/llvm-project/commit/475d1202837071959f3f69d3512c820538d81543 DIFF:

[PATCH] D80423: [analyzer] SATestBuild.py: Refactor and add type annotations

2020-05-22 Thread Valeriy Savchenko via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG4902ca6da49b: [analyzer] SATestBuild.py: Refactor and add type annotations (authored by vsavchenko). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D80424: [analyzer] SATestUtils.py: Refactor and add type annotations

2020-05-22 Thread Valeriy Savchenko via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG7cebfa4e0692: [analyzer] SATestUtils.py: Refactor and add type annotations (authored by vsavchenko). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D80427: [analyzer] SumTimerInfo.py: Partially modernize

2020-05-22 Thread Valeriy Savchenko via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG475d12028370: [analyzer] SumTimerInfo.py: Partially modernize (authored by vsavchenko). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80427/new/

[PATCH] D80426: [analyzer] SATestUpdateDiffs.py: Refactor and add type annotations

2020-05-22 Thread Valeriy Savchenko via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG5a9aff12ff3b: [analyzer] SATestUpdateDiffs.py: Refactor and add type annotations (authored by vsavchenko). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D77474: [analyzer][MallocChecker] Make NewDeleteLeaks depend on DynamicMemoryModeling rather than NewDelete

2020-05-22 Thread Kristóf Umann via Phabricator via cfe-commits
Szelethus updated this revision to Diff 265709. Szelethus marked 7 inline comments as done. Szelethus added a comment. Fix according to reviewer comments! Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77474/new/ https://reviews.llvm.org/D77474 Files:

[PATCH] D77474: [analyzer][MallocChecker] Make NewDeleteLeaks depend on DynamicMemoryModeling rather than NewDelete

2020-05-22 Thread Kristóf Umann via Phabricator via cfe-commits
Szelethus added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/PathSensitive/CheckerContext.h:195 +// Say this 3 times fast. +State = State ? State : getState(); +addTransition(State, generateSink(State, getPredecessor()));

[PATCH] D79754: [OpenMP][AMDGCN] Support OpenMP offloading for AMDGCN architecture - Part 1

2020-05-22 Thread Saiyedul Islam via Phabricator via cfe-commits
saiislam updated this revision to Diff 265716. saiislam added a comment. Herald added a subscriber: sstefan1. Added test case to show treatment of specific functions as builtins or functions on the device Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] bf897e6 - Remove superfluous semicolon to stop Wpedantic warning. NFCI.

2020-05-22 Thread Simon Pilgrim via cfe-commits
Author: Simon Pilgrim Date: 2020-05-22T12:05:56+01:00 New Revision: bf897e6ea122c07b8848133beee749fd96895c14 URL: https://github.com/llvm/llvm-project/commit/bf897e6ea122c07b8848133beee749fd96895c14 DIFF: https://github.com/llvm/llvm-project/commit/bf897e6ea122c07b8848133beee749fd96895c14.diff

[clang] 733505a - Replace dyn_cast<> with isa<> to fix unused variable warning. NFCI.

2020-05-22 Thread Simon Pilgrim via cfe-commits
Author: Simon Pilgrim Date: 2020-05-22T12:05:56+01:00 New Revision: 733505abf471b66458a9eab24521dba9a4b6239e URL: https://github.com/llvm/llvm-project/commit/733505abf471b66458a9eab24521dba9a4b6239e DIFF: https://github.com/llvm/llvm-project/commit/733505abf471b66458a9eab24521dba9a4b6239e.diff

[PATCH] D80426: [analyzer] SATestUpdateDiffs.py: Refactor and add type annotations

2020-05-22 Thread Valeriy Savchenko via Phabricator via cfe-commits
vsavchenko created this revision. vsavchenko added reviewers: NoQ, dcoughlin. Herald added subscribers: cfe-commits, ASDenysPetrov, Charusso, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a project: clang. vsavchenko added a parent

[PATCH] D50078: clang-format: support aligned nested conditionals formatting

2020-05-22 Thread MyDeveloperDay via Phabricator via cfe-commits
MyDeveloperDay added a comment. I get the point about Opt In, and if we are going to add an option it needs to go in ASAP otherwise too many people will then start complaining it was on by default before. To be honest I think the question is do we consider this a bug or a feature, because we

[PATCH] D80425: Fix LLVM/Clang builds with mingw toolchain

2020-05-22 Thread Martin Storsjö via Phabricator via cfe-commits
mstorsjo added a comment. Super-nitpick: If you want to capitalize mingw, it's MinGW (minimalist gnu for windows)  But as that's rather annoying to type, the all-lowercase version is quite fine as well. Comment at: clang/tools/libclang/CMakeLists.txt:71 + list(APPEND LIBS

[PATCH] D80423: [analyzer] SATestBuild.py: Refactor and add type annotations

2020-05-22 Thread Valeriy Savchenko via Phabricator via cfe-commits
vsavchenko updated this revision to Diff 265691. vsavchenko added a comment. Fix code review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80423/new/ https://reviews.llvm.org/D80423 Files: clang/utils/analyzer/SATestAdd.py

[PATCH] D80423: [analyzer] SATestBuild.py: Refactor and add type annotations

2020-05-22 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Nice! I guess next time it'd be easier to review if you split up style changes from structural changes. Comment at: clang/utils/analyzer/SATestBuild.py:276 -AllCheckers =

[PATCH] D80424: [analyzer] SATestUtils.py: Refactor and add type annotations

2020-05-22 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Sure thanks! Comment at: clang/utils/analyzer/SATestUtils.py:47 +root, ext = os.path.splitext(file_name) +return ext in (".i", ".ii", ".c", ".cpp", ".m", "")

[PATCH] D80427: [analyzer] SumTimerInfo.py: Partially modernize

2020-05-22 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. This one's straightforward too. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80427/new/ https://reviews.llvm.org/D80427

[PATCH] D77542: [PowerPC] Treat 'Z' inline asm constraint as a true memory constraint

2020-05-22 Thread Nemanja Ivanovic via Phabricator via cfe-commits
nemanjai marked an inline comment as done. nemanjai added inline comments. Comment at: clang/test/CodeGen/ppc64-inline-asm.c:50 +// CHECK-LABEL: void @testZwOff(i8* %addr, i64 %off) +// CHEC: %[[VAL:[^ ]+]] = getelementptr i8, i8* %addr, i64 %off +// CHEC: call void asm

[PATCH] D71739: [AssumeBundles] Use operand bundles to encode alignment assumptions

2020-05-22 Thread Tyker via Phabricator via cfe-commits
Tyker added a comment. In D71739#2048409 , @rjmccall wrote: > Is there a good reason for this to use the same `llvm.assume` intrinsic as > before? thee hasn't been any discussion i am aware of on this topic. but personally i think keeping the same

[PATCH] D79842: [clang][Driver] Correct tool search path priority

2020-05-22 Thread David Spickett via Phabricator via cfe-commits
DavidSpickett updated this revision to Diff 265694. DavidSpickett added a comment. - Addressed comments from nickdesaulniers Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79842/new/ https://reviews.llvm.org/D79842 Files:

[PATCH] D79842: [clang][Driver] Correct tool search path priority

2020-05-22 Thread David Spickett via Phabricator via cfe-commits
DavidSpickett added a comment. Comments on cfe-dev (http://lists.llvm.org/pipermail/cfe-dev/2020-May/065432.html) also in favour of removing the default triple lookup. I tend to agree but think it makes more sense to land this first and address it in a follow up. Repository: rG LLVM Github

[PATCH] D80317: [SYCL] Prohibit arithmetic operations for incompatible pointers

2020-05-22 Thread Alexey Bader via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGe95ee300c053: [SYCL] Prohibit arithmetic operations for incompatible pointers (authored by bader). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80317/new/

[PATCH] D80286: [Analyzer] Allow creation of stack frame for functions without definition

2020-05-22 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. This looks straightforward, thanks! Comment at: clang/test/Analysis/explain-svals.cpp:97 void test_6() { - clang_analyzer_explain(conjure_S()); // expected-warning-re^lazily

[PATCH] D80416: [RFC][OpenCL] Set fp contract flag on -cl-mad-enable

2020-05-22 Thread Anastasia Stulova via Phabricator via cfe-commits
Anastasia marked an inline comment as done. Anastasia added inline comments. Comment at: clang/test/CodeGenOpenCL/relaxed-fpmath.cl:21 +float fused_mad(float a, float b, float c) { + // NORMAL: @llvm.fmuladd.f32 + // FAST: fmul fast float Anastasia wrote: >

[PATCH] D80416: [RFC][OpenCL] Set fp contract flag on -cl-mad-enable

2020-05-22 Thread Anastasia Stulova via Phabricator via cfe-commits
Anastasia marked an inline comment as done. Anastasia added inline comments. Comment at: clang/test/CodeGenOpenCL/relaxed-fpmath.cl:21 +float fused_mad(float a, float b, float c) { + // NORMAL: @llvm.fmuladd.f32 + // FAST: fmul fast float Anastasia wrote: > I

[PATCH] D80428: [clang] Optimize getFileIDLocal

2020-05-22 Thread Marco Elver via Phabricator via cfe-commits
melver updated this revision to Diff 265717. melver added a comment. Extra unlikely hint. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80428/new/ https://reviews.llvm.org/D80428 Files: clang/include/clang/Basic/SourceManager.h

[PATCH] D80416: [RFC][OpenCL] Set fp contract flag on -cl-mad-enable

2020-05-22 Thread Matt Arsenault via Phabricator via cfe-commits
arsenm added a comment. I think the contract flag needs clarification. I would interpret an instruction with only a contract flag as meaning allow precision increasing FMA formation, and contract+afn to mean combining while reducing precision CHANGES SINCE LAST ACTION

[PATCH] D80366: [Analyzer] Add `getReturnValueUnderConstruction()` to `CallEvent`

2020-05-22 Thread Kristóf Umann via Phabricator via cfe-commits
Szelethus added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/CallEvent.cpp:552 + + Index = StackFrame->getIndex(); + baloghadamsoftware wrote: > Szelethus wrote: > > This mustn't be serious. `StackFrameContext::getIndex()` has **no > > comments**

[PATCH] D80461: HIP: Try to deal with more llvm package layouts

2020-05-22 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl accepted this revision. yaxunl added a comment. This revision is now accepted and ready to land. LGTM. Thanks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80461/new/ https://reviews.llvm.org/D80461 ___ cfe-commits mailing list

[PATCH] D77491: [Sema] Introduce BuiltinAttr, per-declaration builtin-ness

2020-05-22 Thread John McCall via Phabricator via cfe-commits
rjmccall added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:8880 + } +} + tambre wrote: > rjmccall wrote: > > Hmm. I'm concerned about not doing any sort of semantic compatibility > > check here before we assign the function special

[PATCH] D80417: Fix Darwin 'constinit thread_local' variables.

2020-05-22 Thread John McCall via Phabricator via cfe-commits
rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/lib/CodeGen/CodeGenModule.cpp:4145 + // referenced directly, without calling the thread-wrapper, so the linkage + // must not be changed. + //

[PATCH] D80237: [hip] Ensure pointer in struct argument has proper `addrspacecast`.

2020-05-22 Thread John McCall via Phabricator via cfe-commits
rjmccall added a comment. In D80237#2051909 , @hliao wrote: > In D80237#2051887 , @rjmccall wrote: > > > `addrspacecast` might be a real conversion. I feel like this is really > > going well beyond what argument

[PATCH] D80369: [DebugInfo][CallSites] Remove decl subprograms from 'retainedTypes:'

2020-05-22 Thread Djordje Todorovic via Phabricator via cfe-commits
djtodoro added a comment. In D80369#2050022 , @dblaikie wrote: > In D80369#2048932 , @djtodoro wrote: > > > Still have test failing: > > > > Clang :: Modules/DebugInfoTransitiveImport.m > > Clang ::

[PATCH] D80079: [clang-format] [NFC] isCpp() is inconsistently used to mean both C++ and Objective C, add language specific isXXX() functions

2020-05-22 Thread Krasimir Georgiev via Phabricator via cfe-commits
krasimir added a comment. Just some thoughts. I agree that `Style.isJavaScript()` is nicer than `Style.Language == FormatStyle::LK_JavaScript`, but overall the tradeoffs about adding convenience methods are not clear to me. C++/ObjC/ObjC++ is special -- because ObjC++ exists I think it is

[PATCH] D80425: Fix LLVM/Clang builds with mingw toolchain

2020-05-22 Thread Tobias Hieta via Phabricator via cfe-commits
thieta marked 5 inline comments as done. thieta added inline comments. Comment at: clang/tools/libclang/CMakeLists.txt:71 + list(APPEND LIBS ${CMAKE_DL_LIBS}) endif() mstorsjo wrote: > If you say this is the same way it's done elsewhere, then sure - although

[PATCH] D79754: [OpenMP][AMDGCN] Support OpenMP offloading for AMDGCN architecture - Part 1

2020-05-22 Thread Saiyedul Islam via Phabricator via cfe-commits
saiislam marked 19 inline comments as done. saiislam added inline comments. Comment at: clang/lib/AST/Decl.cpp:3227 + !(BuiltinID == Builtin::BIprintf || BuiltinID == Builtin::BImalloc)) +return 0; + sameerds wrote: > sameerds wrote: > > This needs a

[PATCH] D80171: [analyzer] LoopUnrolling: fix crash when a parameter is a loop counter

2020-05-22 Thread Artem Dergachev via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG99b94f29ac5d: [analyzer] LoopUnrolling: fix crash when a parameter is a loop counter. (authored by dergachev.a). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D80436: [clang][docs] Document additional bits of libc that -ffreestanding envs must provide

2020-05-22 Thread Jon Roelofs via Phabricator via cfe-commits
jroelofs created this revision. jroelofs added reviewers: jyknight, echristo. Herald added a project: clang. Herald added a subscriber: cfe-commits. See also discussion following: http://lists.llvm.org/pipermail/llvm-dev/2012-May/050098.html Repository: rG LLVM Github Monorepo

[PATCH] D80369: [DebugInfo][CallSites] Remove decl subprograms from 'retainedTypes:'

2020-05-22 Thread Djordje Todorovic via Phabricator via cfe-commits
djtodoro updated this revision to Diff 265722. djtodoro retitled this revision from "WIP: [DebugInfo] Remove decl subprograms from 'retainedTypes:'" to "[DebugInfo][CallSites] Remove decl subprograms from 'retainedTypes:'". djtodoro added a comment. -Remove the decls only in the case of

[PATCH] D80079: [clang-format] [NFC] isCpp() is inconsistently used to mean both C++ and Objective C, add language specific isXXX() functions

2020-05-22 Thread Jake Merdich via Phabricator via cfe-commits
JakeMerdichAMD added a comment. I'm a fan of the 'like' helpers, but I'm not entirely convinced that having helpers for languages covered by the 'like' is a bad thing-- it just needs to be very explicit that you do mean only that language. For example, an 'isObjCOnly()' would hint to reviewers

[PATCH] D77542: [PowerPC] Treat 'Z' inline asm constraint as a true memory constraint

2020-05-22 Thread Nemanja Ivanovic via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGaede24ecaa08: [PowerPC] Treat Z inline asm constraint as a true memory constraint (authored by nemanjai). Changed prior to commit: https://reviews.llvm.org/D77542?vs=255291=265730#toc Repository: rG

[PATCH] D76791: [Matrix] Implement matrix index expressions ([][]).

2020-05-22 Thread Florian Hahn via Phabricator via cfe-commits
fhahn updated this revision to Diff 265728. fhahn marked 4 inline comments as done. fhahn added a comment. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. In D76791#2048387 , @rjmccall wrote: > Sorry for the slow review; I'm getting

[PATCH] D80222: Replace Clang's createRuntimeFunction with the definitions in OMPKinds.def

2020-05-22 Thread Joseph Huber via Phabricator via cfe-commits
jhuber6 marked an inline comment as done. jhuber6 added inline comments. Comment at: llvm/include/llvm/Frontend/OpenMP/OMPKinds.def:244 -// TODO: Replace this with the real size_t type -#define __OMP_SIZE_TYPE(NAME) OMP_TYPE(NAME, Type::getInt64Ty(Ctx)) +#define

[PATCH] D80294: Add support for vmsumudm

2020-05-22 Thread Amy Kwan via Phabricator via cfe-commits
amyk accepted this revision. amyk added a comment. Thanks for explaining. This LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80294/new/ https://reviews.llvm.org/D80294 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D80439: Replace separator in OpenMP variant name mangling.

2020-05-22 Thread Lukas Sommer via Phabricator via cfe-commits
LukasSommerTu created this revision. LukasSommerTu added reviewers: jdoerfert, Hahnfeld. LukasSommerTu added projects: OpenMP, clang. Herald added subscribers: cfe-commits, sstefan1, guansong, yaxunl. Nvidia PTX does not allow `.` to appear in identifiers, so OpenMP variant mangling now uses `$`

[PATCH] D80371: [clang-tidy] Fix potential assert in use-noexcept check

2020-05-22 Thread Nathan James via Phabricator via cfe-commits
njames93 added a comment. Figured out the actual cause of this bug, `getExceptionSpecRange()` returns a null range if the function has an unknown return type undefined_type throws() throw(); This is the tidy output (where assertions are disabled) warning: dynamic exception specification

[PATCH] D79675: [OpenMP][OMPBuilder] Adding Privatization Requirements to OMPIRBuilder

2020-05-22 Thread Johannes Doerfert via Phabricator via cfe-commits
jdoerfert added a comment. In D79675#2047154 , @fghanim wrote: > In D79675#2045826 , @jdoerfert wrote: > > > In D79675#2045563 , @fghanim wrote: > > > > > So this whole

[PATCH] D80344: [Windows SEH]: HARDWARE EXCEPTION HANDLING (MSVC option -EHa)

2020-05-22 Thread Aaron Smith via Phabricator via cfe-commits
asmith added inline comments. Comment at: clang/lib/CodeGen/CGDecl.cpp:2003 +// : Under -EHa, Invoke llvm.eha.scope.begin() right after +// Ctor is emitted and EHStack.pushCleanup Nit - remove name Comment at:

[PATCH] D80440: [OpenCL] Prevent fused mul and add by default

2020-05-22 Thread Anastasia Stulova via Phabricator via cfe-commits
Anastasia created this revision. Anastasia added reviewers: rjmccall, arsenm. Herald added subscribers: ebevhan, yaxunl, wdng. Currently, clang will generate fused operation `fmuladd` for expressions like `a*b+c`. However, I can't find anything in the spec that explains this behavior. But clang

[PATCH] D80416: [RFC][OpenCL] Set fp contract flag on -cl-mad-enable

2020-05-22 Thread Anastasia Stulova via Phabricator via cfe-commits
Anastasia marked an inline comment as done. Anastasia added inline comments. Comment at: clang/test/CodeGenOpenCL/relaxed-fpmath.cl:21 +float fused_mad(float a, float b, float c) { + // NORMAL: @llvm.fmuladd.f32 + // FAST: fmul fast float Anastasia wrote: >

[PATCH] D80344: [Windows SEH]: HARDWARE EXCEPTION HANDLING (MSVC option -EHa)

2020-05-22 Thread Roman Lebedev via Phabricator via cfe-commits
lebedev.ri added a comment. This should likely be at least 3 patches: llvm middle-end, llvm codegen, clang. Langref changes missing for new intrinsics. Please post all patches with full context (`-U9`) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D80425: Fix LLVM/Clang builds with mingw toolchain

2020-05-22 Thread Mateusz Mikuła via Phabricator via cfe-commits
mati865 added inline comments. Comment at: clang/tools/libclang/CMakeLists.txt:71 + list(APPEND LIBS ${CMAKE_DL_LIBS}) endif() thieta wrote: > mstorsjo wrote: > > If you say this is the same way it's done elsewhere, then sure - although I > > have no idea

[PATCH] D80251: [X86] Update some av512 shift intrinsics to use "unsigned int" parameter instead of int to match Intel documentaiton

2020-05-22 Thread Simon Pilgrim via Phabricator via cfe-commits
RKSimon accepted this revision. RKSimon added a comment. This revision is now accepted and ready to land. In D80251#2049975 , @craig.topper wrote: > In D80251#2049418 , @RKSimon wrote: > > > Can we add

[PATCH] D80415: [AIX] Add '-bcdtors:all:0:s' to linker to gather static init functions

2020-05-22 Thread Zarko Todorovski via Phabricator via cfe-commits
ZarkoCA added inline comments. Comment at: clang/test/Driver/aix-ld.cpp:3 +// // RUN: %clang++ -no-canonical-prefixes %s -### -o %t.o 2>&1 \ +// // RUN: -Wl,-bnocdtors \ +// // RUN: -target powerpc-ibm-aix7.1.0.0 \ formatting, align with the line

[PATCH] D80415: [AIX] Add '-bcdtors:all:0:s' to linker to gather static init functions

2020-05-22 Thread Zarko Todorovski via Phabricator via cfe-commits
ZarkoCA added inline comments. Comment at: clang/test/Driver/aix-ld.cpp:1 +// Check powerpc-ibm-aix7.1.0.0, 32-bit. 'bcdtors' and Arguemnt order. +// // RUN: %clang++ -no-canonical-prefixes %s -### -o %t.o 2>&1 \ s/Arguemnt/Argument/ Comment

[clang] 3a1f0c6 - Fix mistake made while rebasing

2020-05-22 Thread Stephen Kelly via cfe-commits
Author: Stephen Kelly Date: 2020-05-23T01:26:30+01:00 New Revision: 3a1f0c6bd1e09b6fd081ad83bb67228de83ac9b4 URL: https://github.com/llvm/llvm-project/commit/3a1f0c6bd1e09b6fd081ad83bb67228de83ac9b4 DIFF: https://github.com/llvm/llvm-project/commit/3a1f0c6bd1e09b6fd081ad83bb67228de83ac9b4.diff

[clang] 64356b6 - Add missing unit test

2020-05-22 Thread Stephen Kelly via cfe-commits
Author: Stephen Kelly Date: 2020-05-23T01:29:39+01:00 New Revision: 64356b6d94eac13780cc36ea12053d61a027561e URL: https://github.com/llvm/llvm-project/commit/64356b6d94eac13780cc36ea12053d61a027561e DIFF: https://github.com/llvm/llvm-project/commit/64356b6d94eac13780cc36ea12053d61a027561e.diff

[PATCH] D80463: Debug Info: Mark os_log helper functions as artificial

2020-05-22 Thread Adrian Prantl via Phabricator via cfe-commits
aprantl created this revision. aprantl added reviewers: vsk, ahatanak, JDevlieghere, friss. aprantl added a project: debug-info. Herald added a subscriber: dexonsmith. aprantl edited the summary of this revision. The os_log helper functions are linkonce_odr and supposed to be uniqued across TUs,

[PATCH] D80462: Fix floating point math function attributes definition.

2020-05-22 Thread Michele Scandale via Phabricator via cfe-commits
michele.scandale created this revision. michele.scandale added reviewers: rjmccall, mibintc. Herald added a project: clang. Herald added a subscriber: cfe-commits. With the support for changing the state of floating point optimizations within a code block, we need to make sure that the function

[PATCH] D80369: [DebugInfo][CallSites] Remove decl subprograms from 'retainedTypes:'

2020-05-22 Thread David Blaikie via Phabricator via cfe-commits
dblaikie added a comment. In D80369#2051681 , @aprantl wrote: > In D80369#2051278 , @dblaikie wrote: > > > @aprantl can you check here? I've attached two IR files for the > > ModuleDebugInfo.m test, before/after

[PATCH] D80464: [CUDA] Missing __syncthreads intrinsic in __clang_cuda_device_functions.h

2020-05-22 Thread Boris Staletic via Phabricator via cfe-commits
bstaletic created this revision. bstaletic added a reviewer: aprantl. Herald added subscribers: cfe-commits, yaxunl. Herald added a project: clang. Seems like the `__syncthreads` is missing from the `clang/lib/Headers/__clang_cuda_device_functions.h` file. To be honest, I don't know much about

[PATCH] D73037: Add a way to set traversal mode in clang-query

2020-05-22 Thread Stephen Kelly via Phabricator via cfe-commits
steveire updated this revision to Diff 265826. steveire added a comment. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73037/new/ https://reviews.llvm.org/D73037 Files: clang-tools-extra/clang-query/Query.cpp

[PATCH] D72534: Change default traversal in AST Matchers to ignore invisible nodes

2020-05-22 Thread Stephen Kelly via Phabricator via cfe-commits
steveire updated this revision to Diff 265827. steveire added a comment. Touch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72534/new/ https://reviews.llvm.org/D72534 Files: clang/docs/ReleaseNotes.rst

[PATCH] D80463: Debug Info: Mark os_log helper functions as artificial

2020-05-22 Thread Vedant Kumar via Phabricator via cfe-commits
vsk accepted this revision. vsk added a comment. This revision is now accepted and ready to land. Thanks, lgtm! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80463/new/ https://reviews.llvm.org/D80463 ___ cfe-commits mailing list

[PATCH] D80374: [Clang] Enable KF and KC mode for [_Complex] __float128

2020-05-22 Thread John McCall via Phabricator via cfe-commits
rjmccall added a comment. Would you mind separating these two patches? They don't seem have any interdependencies. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80374/new/ https://reviews.llvm.org/D80374

  1   2   >