[PATCH] D77644: [clangd] Handle additional includes while parsing ASTs

kadircet updated this revision to Diff 266174. kadircet added a comment. - Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77644/new/ https://reviews.llvm.org/D77644 Files: clang-tools-extra/clangd/CodeComplete.cpp

[PATCH] D80547: [clang-format] Fix an ObjC regression introduced with new [[likely]][[unlikely]] support in if/else clauses

curdeius added a comment. Minor remarks. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:2346 +// look to see if we have [[ by looking ahead if +// its not then rewind to the original position Nit: shouldn't comments be "Full phrases."?

[clang] ff2743b - [libTooling] In Transformer, allow atomic changes to span multiple files.

Author: Yitzhak Mandelbaum Date: 2020-05-26T09:17:35-04:00 New Revision: ff2743bf047deac7ef6cc6c3efd30ff05e55b2ad URL: https://github.com/llvm/llvm-project/commit/ff2743bf047deac7ef6cc6c3efd30ff05e55b2ad DIFF:

[PATCH] D77644: [clangd] Handle additional includes while parsing ASTs

kadircet updated this revision to Diff 266215. kadircet added a comment. - Fix windows build bots in the face of `#import` directives Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77644/new/ https://reviews.llvm.org/D77644 Files:

[PATCH] D79945: [Sema] Comparison of pointers to complete and incomplete types

pestctrl updated this revision to Diff 266214. pestctrl added a comment. Forgot to add a comma >_< Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79945/new/ https://reviews.llvm.org/D79945 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td

[PATCH] D80300: [Driver] Add DEFAULT_DYLD_PREFIX and DEFAULT_RPATH to complement DEFAULT_SYSROOT

hubert.reinterpretcast added a comment. @joerg, are you okay with this patch landing? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80300/new/ https://reviews.llvm.org/D80300 ___ cfe-commits mailing

[PATCH] D80018: [Analyzer][StreamChecker] Added check for "indeterminate file position".

balazske marked an inline comment as done. balazske added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StreamChecker.cpp:857-868 +// FEof and other states are possible. +// The path with FEof is the one that can continue. +// For this reason a

[PATCH] D80144: [clang-format] @lefticus just taught the world how to use [[unlikely]] but we forgot to teach clang-format

krasimir added a comment. In D80144#2054451 , @MyDeveloperDay wrote: > Will this help? D80547: [clang-format] Fix an ObjC regression introduced with > new [[likely]][[unlikely]] support in if/else clauses > This is

[PATCH] D79961: [PGO] Fix computation of fuction Hash

serge-sans-paille updated this revision to Diff 266184. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79961/new/ https://reviews.llvm.org/D79961 Files: clang/docs/ReleaseNotes.rst clang/lib/CodeGen/CodeGenPGO.cpp clang/test/Profile/Inputs/c-counter-overflows.proftext

[PATCH] D79992: [clangd] Patch PP directives to use stale preambles while building ASTs

kadircet updated this revision to Diff 266186. kadircet added a comment. - Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79992/new/ https://reviews.llvm.org/D79992 Files: clang-tools-extra/clangd/Preamble.cpp

[PATCH] D79961: [PGO] Fix computation of fuction Hash

serge-sans-paille updated this revision to Diff 266188. serge-sans-paille marked an inline comment as done. serge-sans-paille added a comment. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Update version bump parts CHANGES SINCE LAST ACTION

[PATCH] D80239: [libTooling] In Transformer, allow atomic changes to span multiple files.

ymandel updated this revision to Diff 266190. ymandel marked an inline comment as done. ymandel added a comment. Herald added subscribers: llvm-commits, dmgreen. Herald added a project: LLVM. adds fixme comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D80239: [libTooling] In Transformer, allow atomic changes to span multiple files.

ymandel updated this revision to Diff 266191. ymandel added a comment. fixes rebase mistake in previous diff Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80239/new/ https://reviews.llvm.org/D80239 Files:

[PATCH] D80547: [clang-format] Fix an ObjC regression introduced with new [[likely]][[unlikely]] support in if/else clauses

MyDeveloperDay marked an inline comment as done. MyDeveloperDay added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:2348 +// its not then rewind to the original position +bool UnwrappedLineParser::tryToParseAttribute() { + unsigned StoredPosition =

[PATCH] D76791: [Matrix] Implement matrix index expressions ([][]).

fhahn updated this revision to Diff 266205. fhahn marked 7 inline comments as done. fhahn added a comment. Address John's latest comments, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76791/new/ https://reviews.llvm.org/D76791 Files:

[PATCH] D76791: [Matrix] Implement matrix index expressions ([][]).

fhahn added inline comments. Comment at: clang/include/clang/AST/Expr.h:2648 +/// MatrixSubscriptExpr - Matrix subscript expression for the MatrixType +/// extension. +class MatrixSubscriptExpr : public Expr { rjmccall wrote: > Oh, that's interesting. So you've

[PATCH] D79400: [CMAKE] Fix build failure when source directory is read only

pdhaliwal updated this revision to Diff 266172. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79400/new/ https://reviews.llvm.org/D79400 Files: llvm/cmake/modules/AddLLVM.cmake Index: llvm/cmake/modules/AddLLVM.cmake

[PATCH] D80554: [DebugInfo] Use SplitTemplateClosers (foo >) in DWARF too

sammccall created this revision. sammccall added reviewers: dblaikie, labath. Herald added subscribers: cfe-commits, aprantl. Herald added a project: clang. D76801 caused some regressions in debuginfo compatibility by changing how certain functions were named.

[PATCH] D79796: Sketch support for generating CC1 command line from CompilerInvocation

dang marked 5 inline comments as done. dang added inline comments. Comment at: clang/include/clang/Frontend/CompilerInvocation.h:156 /// \param [out] Res - The resulting invocation. + /// \param [in] CommandLineArgs - Array of argument strings, this should not + /// contain

[PATCH] D69764: [clang-format] Add East/West Const fixer capability

aaron.ballman added inline comments. Comment at: clang/lib/Format/EastWestConstFixer.cpp:139 + return (Tok->isSimpleTypeSpecifier() || + Tok->isOneOf(tok::kw_volatile, tok::kw_auto)); +} Do you need to look for `restrict` here as well as `volatile`?

[PATCH] D76801: [AST] Print a> without extra spaces in C++11 or later.

sammccall added a comment. In D76801#2052270 , @dyung wrote: > Hi, we noticed an issue with the GDB test suite that was bisected back to > this change and I have put the details in PR46052. Can you take a look? Sorry this never got clearly resolved. I

[PATCH] D79711: [ARM] Add poly64_t on AArch32.

labrinea added a comment. > Should poly128_t be available on AArch32 too? I don't see anything in the > ACLE version you linked restricting it to AArch64 only, and the intrinsics > reference has a number of intrinsics available for both ISAs using it. It should but it is not that simple. The

[PATCH] D80547: [clang-format] Fix an ObjC regression introduced with new [[likely]][[unlikely]] support in if/else clauses

MyDeveloperDay updated this revision to Diff 266231. MyDeveloperDay added a comment. Add more tests and check if a ';' follows the final ]] CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80547/new/ https://reviews.llvm.org/D80547 Files: clang/lib/Format/UnwrappedLineParser.cpp

[PATCH] D69778: Make -fmodules-codegen and -fmodules-debuginfo work also with precompiled headers

aganea added a comment. In D69778#2035805 , @llunak wrote: > @aganea Have you tried how this version of the patch affects PR44953? If not, > could you please try? I've applied the patch, I don't see the issue raised in PR44953 anymore. However as

[PATCH] D79830: Add support of __builtin_expect_with_probability

erichkeane added a comment. Additionally, it seems you're missing SEMA tests. Please add those. Those tests should also make sure that the diagnostics still work with dependent values. Comment at: clang/include/clang/Basic/Builtins.def:567 BUILTIN(__builtin_expect,

[PATCH] D80548: [Analyzer][NFC] Remove the SubEngine interface

baloghadamsoftware created this revision. baloghadamsoftware added reviewers: NoQ, Szelethus, martong, balazske. baloghadamsoftware added a project: clang. Herald added subscribers: ASDenysPetrov, steakhal, Charusso, gamesh411, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet,

[PATCH] D79711: [ARM] Add poly64_t on AArch32.

ostannard added a comment. Should `poly128_t` be available on AArch32 too? I don't see anything in the ACLE version you linked restricting it to AArch64 only, and the intrinsics reference has a number of intrinsics available for both ISAs using it. Comment at:

[PATCH] D69764: [clang-format] Add East/West Const fixer capability

sammccall added a comment. Thanks @MyDeveloperDay for hammering on on these bugs and @steveire for finding them! There's still obviously some risk here but as long as this is opt-in for a major release or two (i.e. not turned on in built-in styles, any remaining bugs should get flushed out.

[PATCH] D80295: [Sema] Diagnose more cases of static data members in local or unnamed classes

This revision was automatically updated to reflect the committed changes. Closed by commit rG6c906f7785da: [Sema] Diagnose more cases of static data members in local or unnamed classes (authored by john.brawn). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

Re: [PATCH] D69764: [clang-format] Add East/West Const fixer capability

I prefer east/west, but I think there's a terminology that is uncontroversial (left/right) and one that is controversial. It's also clear to me that it's better to have only one set of terms (aliases are only fine for backwards compatibility). Left/Right won, I think. On Tue, May 26, 2020 at 1:55

[PATCH] D80198: [clangd] locateMacroAt handles patched macros

kadircet updated this revision to Diff 266187. kadircet added a comment. - Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80198/new/ https://reviews.llvm.org/D80198 Files: clang-tools-extra/clangd/Headers.cpp

[PATCH] D80239: [libTooling] In Transformer, allow atomic changes to span multiple files.

ymandel marked 2 inline comments as done. ymandel added a comment. Thanks for the review. Comment at: clang/lib/Tooling/Transformer/Transformer.cpp:65 - for (const auto : Case.AddedIncludes) { -auto = I.first; -switch (I.second) { -case

[PATCH] D80023: [clang-tidy] Add abseil-string-find-str-contains checker.

tdl-g updated this revision to Diff 266207. tdl-g added a comment. Fixed length of visual separator. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80023/new/ https://reviews.llvm.org/D80023 Files:

[PATCH] D80023: [clang-tidy] Add abseil-string-find-str-contains checker.

tdl-g marked 4 inline comments as done. tdl-g added a comment. Thanks again, addressed all comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/abseil-string-find-str-contains.cpp:2 +// RUN: %check_clang_tidy %s abseil-string-find-str-contains %t -- \ +// RUN:

[PATCH] D80547: [clang-format] Fix an ObjC regression introduced with new [[likely]][[unlikely]] support in if/else clauses

aaron.ballman added a comment. In D80547#2054763 , @MyDeveloperDay wrote: > Handle more complex nested ObjC calls > Rename function to tryParseSimpleAttributes (not supporting full capability > as yet) > Use RAII object to reset the TokenPosition >

[clang] 6c906f7 - [Sema] Diagnose more cases of static data members in local or unnamed classes

Author: John Brawn Date: 2020-05-26T13:29:59+01:00 New Revision: 6c906f7785dad3a1dea5357cfde0762952c2a2bd URL: https://github.com/llvm/llvm-project/commit/6c906f7785dad3a1dea5357cfde0762952c2a2bd DIFF: https://github.com/llvm/llvm-project/commit/6c906f7785dad3a1dea5357cfde0762952c2a2bd.diff

[PATCH] D80531: [clang-tidy]: Added modernize-replace-disallow-copy-and-assign-macro

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/modernize-replace-disallow-copy-and-assign-macro.rst:23 + private: + - DISALLOW_COPY_AND_ASSIGN(Foo); + + Foo(const Foo &) = delete; I think two code snippets would

[PATCH] D79796: Sketch support for generating CC1 command line from CompilerInvocation

dang updated this revision to Diff 266195. dang added a comment. Address some code review comments and sketch support for options that take a single value. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79796/new/ https://reviews.llvm.org/D79796

[PATCH] D80547: [clang-format] Fix an ObjC regression introduced with new [[likely]][[unlikely]] support in if/else clauses

MyDeveloperDay updated this revision to Diff 266192. MyDeveloperDay added a comment. Check for null Tok Fix up comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80547/new/ https://reviews.llvm.org/D80547 Files: clang/lib/Format/UnwrappedLineParser.cpp

[PATCH] D80239: [libTooling] In Transformer, allow atomic changes to span multiple files.

This revision was automatically updated to reflect the committed changes. Closed by commit rGff2743bf047d: [libTooling] In Transformer, allow atomic changes to span multiple files. (authored by ymandel). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D80547: [clang-format] Fix an ObjC regression introduced with new [[likely]][[unlikely]] support in if/else clauses

krasimir added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:2348 +// its not then rewind to the original position +bool UnwrappedLineParser::tryToParseAttribute() { + unsigned StoredPosition = Tokens->getPosition(); MyDeveloperDay

[PATCH] D80547: [clang-format] Fix an ObjC regression introduced with new [[likely]][[unlikely]] support in if/else clauses

MyDeveloperDay updated this revision to Diff 266204. MyDeveloperDay added a comment. Handle more complex nested ObjC calls Rename function to tryParseSimpleAttributes (not supporting full capability as yet) Use RAII object to reset the TokenPosition utilize the fact that Objective calls

[PATCH] D80293: [clangd] Run PreambleThread in async mode behind a flag

kadircet updated this revision to Diff 266201. kadircet edited the summary of this revision. kadircet added a comment. - Rebase and update comments on block until idle. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80293/new/

[PATCH] D79961: [PGO] Fix computation of fuction Hash

hans accepted this revision. hans added a comment. lgtm CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79961/new/ https://reviews.llvm.org/D79961 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D79930: [clangd] Add buildPreamble to TestTU

kadircet updated this revision to Diff 266202. kadircet added a comment. - Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79930/new/ https://reviews.llvm.org/D79930 Files: clang-tools-extra/clangd/unittests/PreambleTests.cpp

[PATCH] D80548: [Analyzer][NFC] Remove the SubEngine interface

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. I absolutely buy this. If somebody is to ever implement another `ExprEngine`, dealing with the lack of a convenient virtual interface will definitely be a negligible problem for them.

[PATCH] D79754: [OpenMP][AMDGCN] Support OpenMP offloading for AMDGCN architecture - Part 1

saiislam updated this revision to Diff 266171. saiislam marked 2 inline comments as done. saiislam added a comment. Shifted test cases in openmp-offload-gpu.c for better visual segmentation. Updated device function test case to be more accurate. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D79400: [CMAKE] Fix build failure when source directory is read only

pdhaliwal added a comment. > 3. Another way is to gracefully handle the file write error, for which I > don't think there is a portable way. (which @scott.linder also suggested) I have found the portable way to do this. So cmake provides a command-line tool `touch` (doc

[PATCH] D80536: [clang-tidy][modernize-loop-convert] Make loop var type human readable

zinovy.nis created this revision. zinovy.nis added reviewers: angelgarcia, alexfh. zinovy.nis added a project: clang-tools-extra. Herald added subscribers: cfe-commits, xazax.hun. Herald added a project: clang. zinovy.nis edited the summary of this revision. Without this patch

[PATCH] D79426: [clangd] Change PreambleOnlyAction with content truncation

This revision was automatically updated to reflect the committed changes. Closed by commit rG34e39eb2adc2: [clangd] Change PreambleOnlyAction with content truncation (authored by kadircet). Changed prior to commit: https://reviews.llvm.org/D79426?vs=262132=266107#toc Repository: rG LLVM

[PATCH] D80521: [clangd] Make use of SourceOrder to find first initializer in DefineOutline

This revision was automatically updated to reflect the committed changes. Closed by commit rGeeedbd033612: [clangd] Make use of SourceOrder to find first initializer in DefineOutline (authored by kadircet). Changed prior to commit: https://reviews.llvm.org/D80521?vs=266027=266106#toc

[clang] 61f72dd - [FPEnv] Small fixes to implementation of flt.rounds

Author: Serge Pavlov Date: 2020-05-26T13:19:01+07:00 New Revision: 61f72dd8ace7c4bea1ae74d9734d2b02946b4898 URL: https://github.com/llvm/llvm-project/commit/61f72dd8ace7c4bea1ae74d9734d2b02946b4898 DIFF: https://github.com/llvm/llvm-project/commit/61f72dd8ace7c4bea1ae74d9734d2b02946b4898.diff

[PATCH] D79322: [FEnv] Small fixes to implementation of flt.rounds

This revision was automatically updated to reflect the committed changes. Closed by commit rG61f72dd8ace7: [FPEnv] Small fixes to implementation of flt.rounds (authored by sepavloff). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79322/new/

[clang-tools-extra] 1abb883 - [clangd] Don't traverse the AST within uninteresting files during indexing

Author: Sam McCall Date: 2020-05-26T10:27:28+02:00 New Revision: 1abb883a048153c83a4e11070219d23f362e7377 URL: https://github.com/llvm/llvm-project/commit/1abb883a048153c83a4e11070219d23f362e7377 DIFF: https://github.com/llvm/llvm-project/commit/1abb883a048153c83a4e11070219d23f362e7377.diff

[PATCH] D80198: [clangd] locateMacroAt handles patched macros

kadircet updated this revision to Diff 266111. kadircet marked 10 inline comments as done. kadircet added a comment. - Extract preamble-patch location translation to a helper: - Migrate usage in include collector - Make preamble patch header name part of the check. - Handle macro ids in

[clang] 98cad55 - [Clang][AArch64] Capturing proper pointer alignment for Neon vld1 intrinsicts

Author: Lucas Prates Date: 2020-05-26T10:09:35+01:00 New Revision: 98cad555e29187a03e2bc3db5780762981913902 URL: https://github.com/llvm/llvm-project/commit/98cad555e29187a03e2bc3db5780762981913902 DIFF: https://github.com/llvm/llvm-project/commit/98cad555e29187a03e2bc3db5780762981913902.diff

[PATCH] D80531: [clang-tidy]: Added modernize-replace-disallow-copy-and-assign-macro

njames93 added a comment. In D80531#2053969 , @kwk wrote: > @Eugene.Zelenko thank you for the review. I've fixed all places that you've > mentioned. And have a question about one thing in particular. See inline. > > Do you by any chance know why

[PATCH] D80018: [Analyzer][StreamChecker] Added check for "indeterminate file position".

balazske marked an inline comment as done. balazske added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StreamChecker.cpp:107 + /// This value applies to all error states in ErrorState except FEOF. + /// An EOF+indeterminate state is the same as EOF state. +

[PATCH] D80198: [clangd] locateMacroAt handles patched macros

kadircet added inline comments. Comment at: clang-tools-extra/clangd/Preamble.cpp:133 + auto DecompLoc = SM.getDecomposedLoc(DirectiveRange.getBegin()); + DirectiveLine = SM.getLineNumber(DecompLoc.first, DecompLoc.second); + auto SpaceBefore =

[PATCH] D80296: [clangd] Don't traverse the AST within uninteresting files during indexing

This revision was automatically updated to reflect the committed changes. Closed by commit rG1abb883a0481: [clangd] Dont traverse the AST within uninteresting files during indexing (authored by sammccall). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D71199: [clang-tidy] New check cppcoreguidelines-prefer-member-initializer

baloghadamsoftware updated this revision to Diff 266117. baloghadamsoftware added a comment. Updated according to the comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71199/new/ https://reviews.llvm.org/D71199 Files:

[PATCH] D80198: [clangd] locateMacroAt handles patched macros

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Looks great, ship it! Comment at: clang-tools-extra/clangd/Preamble.cpp:154 +OS << "\\\n" << std::string(TargetColumn, ' '); +// Decrement because returned

[PATCH] D79961: [PGO] Fix computation of fuction Hash

hans added a comment. In D79961#2053806 , @serge-sans-paille wrote: > Bump the version number to be compatible with existing profdata, in a similar > fashion to v1/v2 transition. Did you forget to include some files? I don't see the bump anywhere.

[PATCH] D71199: [clang-tidy] New check cppcoreguidelines-prefer-member-initializer

baloghadamsoftware marked 7 inline comments as done. baloghadamsoftware added inline comments. Comment at: clang-tools-extra/clang-tidy/cppcoreguidelines/PreferMemberInitializerCheck.cpp:126-128 + const auto *Body = dyn_cast_or_null(Ctor->getBody()); + if (!Body) +return;

[PATCH] D80540: Add support for binary operators in Syntax Trees

eduucaldas created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. eduucaldas added a reviewer: gribozavr2. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D80540 Files: clang/include/clang/Tooling/Syntax/Nodes.h

[PATCH] D78933: [analyzer] RangeConstraintManager optimizations in comparison expressions

ASDenysPetrov added a comment. @xazax.hun, any thoughts? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78933/new/ https://reviews.llvm.org/D78933 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D80198: [clangd] locateMacroAt handles patched macros

kadircet updated this revision to Diff 266128. kadircet marked 4 inline comments as done. kadircet added a comment. - Add tests for preamble-patch translation logic Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80198/new/

[PATCH] D80541: Terminate early for DS_Error

kongyi created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Otherwise clang will continue running after printing the diagnostic, causing failures later in other modes, or maybe even finish successfully. Repository: rG LLVM Github Monorepo

[PATCH] D79961: [PGO] Fix computation of fuction Hash

serge-sans-paille updated this revision to Diff 266133. serge-sans-paille added a comment. With v3 version + Make cast explicit CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79961/new/ https://reviews.llvm.org/D79961 Files: clang/docs/ReleaseNotes.rst

[PATCH] D79721: [Clang][AArch64] Capturing proper pointer alignment for Neon vld1 intrinsicts

This revision was automatically updated to reflect the committed changes. Closed by commit rG98cad555e291: [Clang][AArch64] Capturing proper pointer alignment for Neon vld1 intrinsicts (authored by pratlucas). Changed prior to commit: https://reviews.llvm.org/D79721?vs=263188=266138#toc

[PATCH] D79961: [PGO] Fix computation of fuction Hash

serge-sans-paille added a comment. @hans updated! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79961/new/ https://reviews.llvm.org/D79961 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D80531: [clang-tidy]: Added modernize-replace-disallow-copy-and-assign-macro

kwk planned changes to this revision. kwk added a comment. Thank you @njames93 for the review. I'm implementing what you wrote. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80531/new/ https://reviews.llvm.org/D80531

[PATCH] D80018: [Analyzer][StreamChecker] Added check for "indeterminate file position".

Szelethus added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StreamChecker.cpp:107 + /// This value applies to all error states in ErrorState except FEOF. + /// An EOF+indeterminate state is the same as EOF state. + bool FilePositionIndeterminate = false;

[PATCH] D80144: [clang-format] @lefticus just taught the world how to use [[unlikely]] but we forgot to teach clang-format

krasimir added a comment. In D80144#2053543 , @MyDeveloperDay wrote: > maybe for now we just do > > if (FormatTok->is(tok::l_square) && !Style.isObjC()) > parseSquare(); > I tried this, however FormatTest.cpp's verifyFormat is picky and

[PATCH] D79995: [clang] [MinGW] Fix libunwind extension

mati865 added a comment. @mstorsjo @rnk will away since June CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79995/new/ https://reviews.llvm.org/D79995 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] 3785eb8 - Add support for binary operators in Syntax Trees

Author: Eduardo Caldas Date: 2020-05-26T12:25:58+02:00 New Revision: 3785eb83af4161bd52ed993ef3a2184c998071e6 URL: https://github.com/llvm/llvm-project/commit/3785eb83af4161bd52ed993ef3a2184c998071e6 DIFF:

[PATCH] D80540: Add support for binary operators in Syntax Trees

This revision was automatically updated to reflect the committed changes. Closed by commit rG3785eb83af41: Add support for binary operators in Syntax Trees (authored by eduucaldas, committed by gribozavr). Changed prior to commit: https://reviews.llvm.org/D80540?vs=266121=266155#toc

[PATCH] D80531: [clang-tidy]: Added modernize-replace-disallow-copy-and-assign-macro

kwk updated this revision to Diff 266148. kwk marked 4 inline comments as done. kwk added a comment. - Wrap RUN lines - Use CamelCase variable name - Simplify access to options - Make check options const - Use two-line placeholder - Automate placement of semicolon at the end Repository: rG

[PATCH] D80531: [clang-tidy]: Added modernize-replace-disallow-copy-and-assign-macro

kwk marked 2 inline comments as done. kwk added a comment. @njames93 I've implemented everything you've mentioned. This simplified a lot. Comment at: clang-tools-extra/docs/clang-tidy/checks/modernize-replace-disallow-copy-and-assign-macro.rst:41 + +.. option::

[PATCH] D71199: [clang-tidy] New check cppcoreguidelines-prefer-member-initializer

baloghadamsoftware updated this revision to Diff 266151. baloghadamsoftware marked an inline comment as done. baloghadamsoftware added a comment. Fix from `CPlusPlus2a` to `CPlusPlus20` after rebase. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71199/new/

[PATCH] D80428: [clang] Optimize SourceManager::getFileIDLocal [WIP]

melver abandoned this revision. melver added a comment. More background: https://github.com/ClangBuiltLinux/linux/issues/1032 This approach likely doesn't yield too much benefit. Too much variability is observed when compiling Clang with either Clang or GCC. Since Nick has a better proposal at

[PATCH] D74387: [OpenMP][SYCL] Improve diagnosing of unsupported types usage

Fznamznon added a comment. The tests are failing because calling function with unsupported type in arguments/return value is diagnosed as well, i.e. : double math(float f, double d, long double ld) { ... } // `ld` is not used inside the `math` function #pragma omp target map(r) { r +=

[PATCH] D69764: [clang-format] Add East/West Const fixer capability

MyDeveloperDay updated this revision to Diff 266360. MyDeveloperDay added a comment. rebase with master CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69764/new/ https://reviews.llvm.org/D69764 Files: clang/docs/ClangFormatStyleOptions.rst clang/docs/ReleaseNotes.rst

[PATCH] D75938: [DO NOT MERGE] X86 Mitigate for Load Value Injection (LVI)--All Code

sconstab abandoned this revision. sconstab added a comment. Changes have been merged. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75938/new/ https://reviews.llvm.org/D75938 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D80450: [CUDA][HIP] Fix implicit HD function resolution

yaxunl updated this revision to Diff 266366. yaxunl added a comment. Fix test. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80450/new/ https://reviews.llvm.org/D80450 Files: clang/lib/Sema/SemaOverload.cpp clang/test/SemaCUDA/function-overload.cu Index:

[PATCH] D80590: [WIP][OPENMP] Fix assertion error for using alignas with OpenMP directive

cchen updated this revision to Diff 266370. cchen added a comment. Add test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80590/new/ https://reviews.llvm.org/D80590 Files: clang/lib/Sema/SemaOpenMP.cpp clang/test/OpenMP/sema_alignas.cpp

[PATCH] D69764: [clang-format] Add East/West Const fixer capability

steveire added a comment. In D69764#2056104 , @rsmith wrote: > I'm uncomfortable about `clang-format` performing this transformation at all. > Generally, clang-format only makes changes that are guaranteed to preserve > the meaning of the source

[PATCH] D80344: [Windows SEH]: HARDWARE EXCEPTION HANDLING (MSVC -EHa) - Part 1

tentzen updated this revision to Diff 266374. tentzen added a comment. update LangRef.rst for new intrinsics Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80344/new/ https://reviews.llvm.org/D80344 Files: clang/include/clang/AST/Stmt.h

[PATCH] D60620: [HIP] Support target id by --offload-arch

yaxunl marked an inline comment as done. yaxunl added inline comments. Comment at: clang/lib/Driver/ToolChains/HIP.cpp:121-123 + auto Pos = SubArchName.find_first_of("+-"); + if (Pos != SubArchName.npos) +SubArchName = SubArchName.substr(0, Pos); tra

[PATCH] D71739: [AssumeBundles] Use operand bundles to encode alignment assumptions

jdoerfert added a comment. I think the code looks good, we should make the test changes clearer, see below. Comment at: clang/test/CodeGen/align_value.cpp:7 double & z __attribute__((align_value(128 { }; -// CHECK: define void @_Z3fooPdS_Rd(double* align 64 %x,

[PATCH] D80532: [NFC] Fix formatting for the 'aix-ld.c' test case.

This revision was automatically updated to reflect the committed changes. Closed by commit rGa924dac44f31: [NFC] Fix formatting for the aix-ld.c test case. (authored by stevewan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80532/new/

[PATCH] D80055: Diagnose union tail padding

rsmith added a comment. In D80055#2055151 , @jfb wrote: > I was wondering if any of the tests were surprising to you, or if the > behavior described was as expected? I've highlighted one case where the test expectation doesn't match the standard

[PATCH] D80020: [PowerPC] Add support for -mcpu=pwr10 in both clang and llvm

amyk accepted this revision. amyk added a comment. This LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80020/new/ https://reviews.llvm.org/D80020 ___ cfe-commits mailing list

[PATCH] D77474: [analyzer][MallocChecker] Make NewDeleteLeaks depend on DynamicMemoryModeling rather than NewDelete

This revision was automatically updated to reflect the committed changes. Closed by commit rGefd1a8e66eaa: [analyzer][MallocChecker] Make NewDeleteLeaks depend on DynamicMemoryModeling… (authored by Szelethus). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D79895: Add a new warning to warn when passing uninitialized variables as const reference parameters to a function

zequanwu added a comment. @rsmith Are you okay with this patch? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79895/new/ https://reviews.llvm.org/D79895 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D79721: [Clang][AArch64] Capturing proper pointer alignment for Neon vld1 intrinsicts

efriedma added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:10331 +auto Alignment = CGM.getNaturalPointeeTypeAlignment( +E->getArg(0)->IgnoreParenCasts()->getType()); Ops[0] = Builder.CreateBitCast(Ops[0], llvm::PointerType::getUnqual(VTy));

[PATCH] D80409: [MS ABI] Add mangled type for auto template parameter whose argument kind is Integeral

zequanwu updated this revision to Diff 266339. zequanwu added a comment. Add `19.20` version. Only add mangled type for version 19. 20 or later to be abi-compatible with https://godbolt.org/z/Bhc__A CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80409/new/

[PATCH] D79721: [Clang][AArch64] Capturing proper pointer alignment for Neon vld1 intrinsicts

efriedma added a comment. This caused https://bugs.llvm.org/show_bug.cgi?id=46084 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79721/new/ https://reviews.llvm.org/D79721 ___ cfe-commits mailing list

[PATCH] D69764: [clang-format] Add East/West Const fixer capability

rsmith added a comment. I'm uncomfortable about `clang-format` performing this transformation at all. Generally, clang-format only makes changes that are guaranteed to preserve the meaning of the source program, and does not make changes that are only heuristically likely to be

[PATCH] D80369: [DebugInfo][CallSites] Remove decl subprograms from 'retainedTypes:'

aprantl added a comment. There's a cute diagram of the interaction: https://github.com/apple/llvm-project/blob/1fda14a45e23c41ac661c20a248a7fa4b102230d/lldb/source/Symbol/SwiftASTContext.cpp#L3020 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80369/new/ https://reviews.llvm.org/D80369

  1   2   3   >