[PATCH] D79895: Add a new warning to warn when passing uninitialized variables as const reference parameters to a function

2020-06-04 Thread Sylvestre Ledru via Phabricator via cfe-commits
sylvestre.ledru added a comment. @zequanwu could you please update the release notes? thanks https://github.com/llvm/llvm-project/blob/master/clang/docs/ReleaseNotes.rst Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79895/new/

[PATCH] D80941: [PowerPC][Power10] Implement Count Leading/Trailing Zeroes Builtins under bit Mask in LLVM/Clang

2020-06-04 Thread Amy Kwan via Phabricator via cfe-commits
amyk updated this revision to Diff 268470. amyk added a comment. Revert back to the initial implementation of the patch. Thanks Nemanja for clarifying. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80941/new/ https://reviews.llvm.org/D80941

[PATCH] D62922: [WebAssembly] Implement "Reactor" mode

2020-06-04 Thread Dan Gohman via Phabricator via cfe-commits
sunfish marked an inline comment as done. sunfish added inline comments. Comment at: clang/test/Driver/wasm-toolchain.c:116 +// CHECK-COMMAND: clang{{.*}}" "-cc1" {{.*}} "-o" "[[temp:[^"]*]]" +// CHECK-COMMAND: wasm-ld{{.*}}" "crt1.o" "[[temp]]" "-lc"

[clang] 9ca5a6d - [OPENMP]Fix PR46146: Do not consider globalized variables as NRVO candidates.

2020-06-04 Thread Alexey Bataev via cfe-commits
Author: Alexey Bataev Date: 2020-06-04T12:33:25-04:00 New Revision: 9ca5a6d3b523688be8b4c2315482297fa943c777 URL: https://github.com/llvm/llvm-project/commit/9ca5a6d3b523688be8b4c2315482297fa943c777 DIFF: https://github.com/llvm/llvm-project/commit/9ca5a6d3b523688be8b4c2315482297fa943c777.diff

[clang-tools-extra] 6271b96 - [clang-tidy][modernize-loop-convert] Make loop var type human readable

2020-06-04 Thread Zinovy Nis via cfe-commits
Author: Zinovy Nis Date: 2020-06-04T19:51:45+03:00 New Revision: 6271b96bef479882cf43397941a4c95aa9f47403 URL: https://github.com/llvm/llvm-project/commit/6271b96bef479882cf43397941a4c95aa9f47403 DIFF: https://github.com/llvm/llvm-project/commit/6271b96bef479882cf43397941a4c95aa9f47403.diff

[PATCH] D62922: [WebAssembly] Implement "Reactor" mode

2020-06-04 Thread Bjorn Pettersson via Phabricator via cfe-commits
bjope added inline comments. Comment at: clang/test/Driver/wasm-toolchain.c:116 +// CHECK-COMMAND: clang{{.*}}" "-cc1" {{.*}} "-o" "[[temp:[^"]*]]" +// CHECK-COMMAND: wasm-ld{{.*}}" "crt1.o" "[[temp]]" "-lc" "{{.*[/\\]}}libclang_rt.builtins-wasm32.a" "-o" "a.out" +

[PATCH] D80932: [SYCL] Make default address space a superset of OpenCL address spaces.

2020-06-04 Thread Victor Lomuller via Phabricator via cfe-commits
Naghasan added a comment. In D80932#2072064 , @Anastasia wrote: > In D80932#2071321 , @bader wrote: > > > In D80932#2068863 , @Anastasia > > wrote: > > > > > > > > > > > >

[PATCH] D81150: Use libClangTesting in the unittest for AST matchers

2020-06-04 Thread Marcel Hlopko via Phabricator via cfe-commits
hlopko accepted this revision. hlopko added a comment. This revision is now accepted and ready to land. Nice! :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81150/new/ https://reviews.llvm.org/D81150

[PATCH] D81157: Propose naming principle for NodeRole and apply it

2020-06-04 Thread Dmitri Gribenko via Phabricator via cfe-commits
gribozavr2 added inline comments. Comment at: clang/include/clang/Tooling/Syntax/Nodes.h:94 /// a binary expression'. Used for implementing accessors. +// How to name NodeRole: +// If the child node is a token/keyword, end its name with 'Token'/'Keyword' I'd

[PATCH] D77168: Add a flag to debug automatic variable initialization

2020-06-04 Thread JF Bastien via Phabricator via cfe-commits
jfb added a comment. Can you add a test for the diagnostic firing after the correct number of initializations? This should include a few types of auto-init, including VLAs. Comment at: clang/include/clang/Basic/DiagnosticDriverKinds.td:489 +

[PATCH] D81150: Use libClangTesting in the unittest for AST matchers

2020-06-04 Thread Dmitri Gribenko via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGb5fc1deb5ba1: Use libClangTesting in the unittest for AST matchers (authored by gribozavr). Changed prior to commit: https://reviews.llvm.org/D81150?vs=268440=268495#toc Repository: rG LLVM Github

[PATCH] D80887: [clang-tidy] ignore builtin varargs from pro-type-vararg-check

2020-06-04 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, thank you for the fixes! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80887/new/ https://reviews.llvm.org/D80887

[clang] e82e388 - [Doc] update ReleaseNotes with new warning note.

2020-06-04 Thread via cfe-commits
Author: ZequanWu Date: 2020-06-04T09:45:04-07:00 New Revision: e82e388a493345d8287175f884b34c3f38f71057 URL: https://github.com/llvm/llvm-project/commit/e82e388a493345d8287175f884b34c3f38f71057 DIFF: https://github.com/llvm/llvm-project/commit/e82e388a493345d8287175f884b34c3f38f71057.diff

[PATCH] D81169: [clangd] Improve hover on arguments to function call

2020-06-04 Thread Adam Czachorowski via Phabricator via cfe-commits
adamcz created this revision. adamcz added a reviewer: kadircet. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. In cases like: foo(a, ^b); We now additionally show the name and type of the parameter to foo that

[PATCH] D81083: [Clang] Allow "vector_size" applied to Booleans

2020-06-04 Thread Simon Moll via Phabricator via cfe-commits
simoll updated this revision to Diff 268488. simoll added a comment. - Improved documentation for the size argument of vector_size. - Rebased Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81083/new/ https://reviews.llvm.org/D81083 Files:

[clang] b5fc1de - Use libClangTesting in the unittest for AST matchers

2020-06-04 Thread Dmitri Gribenko via cfe-commits
Author: Dmitri Gribenko Date: 2020-06-04T17:40:39+02:00 New Revision: b5fc1deb5ba1f3cd432ecb8b86c2536470463163 URL: https://github.com/llvm/llvm-project/commit/b5fc1deb5ba1f3cd432ecb8b86c2536470463163 DIFF:

[PATCH] D80804: [AMDGPU] Introduce Clang builtins to be mapped to AMDGCN atomic inc/dec intrinsics

2020-06-04 Thread Matt Arsenault via Phabricator via cfe-commits
arsenm added inline comments. Comment at: clang/include/clang/Basic/BuiltinsAMDGPU.def:62-63 BUILTIN(__builtin_amdgcn_fence, "vUicC*", "n") +BUILTIN(__builtin_amdgcn_atomic_inc, "iiD*iUicC*", "n") +BUILTIN(__builtin_amdgcn_atomic_dec, "iiD*iUicC*", "n") My

[PATCH] D81168: Add support for id-expression in SyntaxTree

2020-06-04 Thread Eduardo Caldas via Phabricator via cfe-commits
eduucaldas added a subscriber: gribozavr2. eduucaldas marked an inline comment as done. eduucaldas added inline comments. Comment at: clang/unittests/Tooling/Syntax/TreeTest.cpp:829 +| | | | | `-:: +| | | | `-TypeSpecifier +| | | | |-S Perhaps we

[PATCH] D80947: Add to the Coding Standard our that single-line bodies omit braces

2020-06-04 Thread Hubert Tong via Phabricator via cfe-commits
hubert.reinterpretcast accepted this revision. hubert.reinterpretcast added a comment. This revision is now accepted and ready to land. This LGTM. I believe we have not heard back from @arsenm on the response to some of their comments though. Comment at:

[PATCH] D81083: [Clang] Allow "vector_size" applied to Booleans

2020-06-04 Thread Simon Moll via Phabricator via cfe-commits
simoll marked an inline comment as done. simoll added inline comments. Comment at: clang/docs/LanguageExtensions.rst:473 +architectures. The size parameter of a boolean vector type is the number of +bits in the vector (for all non-bool vectors, the number refers to the number

[clang] 62305f6 - Rename arrow -> arrowToken for unified naming

2020-06-04 Thread Dmitri Gribenko via cfe-commits
Author: Eduardo Caldas Date: 2020-06-04T16:12:16+02:00 New Revision: 62305f6db4ed642c6b2b005dcb7951eb38342dca URL: https://github.com/llvm/llvm-project/commit/62305f6db4ed642c6b2b005dcb7951eb38342dca DIFF:

[clang] 9520bf1 - [clang-format] Update GoogleStyle for C# code to match Google's internal C# style guide

2020-06-04 Thread Jonathan Coe via cfe-commits
Author: Jonathan Coe Date: 2020-06-04T15:48:00+01:00 New Revision: 9520bf146dd3baae8608755d7de0855db4664c77 URL: https://github.com/llvm/llvm-project/commit/9520bf146dd3baae8608755d7de0855db4664c77 DIFF: https://github.com/llvm/llvm-project/commit/9520bf146dd3baae8608755d7de0855db4664c77.diff

[PATCH] D80735: [OpenMP][NFC] Reuse OMPIRBuilder `struct ident_t` handling in Clang

2020-06-04 Thread Joseph Huber via Phabricator via cfe-commits
jhuber6 added a comment. Here's one of the stack traces. Calling `InternalOMPBuilder.initialize()` is what triggers it to start failing, which is confusing because all that function does is initialize the named types from OMPConstants, which should be working or else the old solution wouldn't

[PATCH] D80900: [clangd] Use different FS in PreambleThread

2020-06-04 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet added a comment. In D80900#2071207 , @sammccall wrote: > That makes sense. However I don't think that contract is conceptually that > great, having the ideas of "threadsafe FS" and "maybe-context-aware FS" > coupled together is... weird. The

[PATCH] D79895: Add a new warning to warn when passing uninitialized variables as const reference parameters to a function

2020-06-04 Thread Zequan Wu via Phabricator via cfe-commits
zequanwu added a comment. In D79895#2073698 , @sylvestre.ledru wrote: > @zequanwu could you please update the release notes? thanks > https://github.com/llvm/llvm-project/blob/master/clang/docs/ReleaseNotes.rst Done. Repository: rG LLVM Github

[PATCH] D80536: [clang-tidy][modernize-loop-convert] Make loop var type human readable

2020-06-04 Thread Zinovy Nis via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG6271b96bef47: [clang-tidy][modernize-loop-convert] Make loop var type human readable (authored by zinovy.nis). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D81168: Add support for id-expression in SyntaxTree

2020-06-04 Thread Dmitri Gribenko via Phabricator via cfe-commits
gribozavr2 added inline comments. Comment at: clang/unittests/Tooling/Syntax/TreeTest.cpp:815 +| | `-UnknownExpression +| | `-s +| `-; This part does not seem to appear in the source. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D80936: [OPENMP]Fix PR46146: Do not consider globalized variables as NRVO candidates.

2020-06-04 Thread Alexey Bataev via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG9ca5a6d3b523: [OPENMP]Fix PR46146: Do not consider globalized variables as NRVO candidates. (authored by ABataev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D81157: Propose naming principle for NodeRole and apply it

2020-06-04 Thread Dmitri Gribenko via Phabricator via cfe-commits
gribozavr2 added inline comments. Comment at: clang/include/clang/Tooling/Syntax/Nodes.h:124 IfStatement_thenStatement, IfStatement_elseKeyword, IfStatement_elseStatement, eduucaldas wrote: > gribozavr2 wrote: > > Shouldn't `elseKeyword` have no prefix?

[PATCH] D81150: Use libClangTesting in the unittest for AST matchers

2020-06-04 Thread Nathan James via Phabricator via cfe-commits
njames93 added inline comments. Comment at: clang/unittests/ASTMatchers/ASTMatchersTest.h:62 +inline ArrayRef langCxx11OrLater() { + static std::vector Result = {Lang_CXX11, Lang_CXX14, Lang_CXX17, + Lang_CXX20}; Bit

[PATCH] D80752: [AArch64]: BFloat MatMul Intrinsics

2020-06-04 Thread Luke Geeson via Phabricator via cfe-commits
LukeGeeson updated this revision to Diff 268520. LukeGeeson added a comment. - used `update_cc_test_checks.py` to generate correct checks CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80752/new/ https://reviews.llvm.org/D80752 Files: clang/include/clang/Basic/arm_neon.td

[PATCH] D80887: [clang-tidy] ignore builtin varargs from pro-type-vararg-check

2020-06-04 Thread Nathan James via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGe21c3f223a35: [clang-tidy] ignore builtin varargs from pro-type-vararg-check (authored by njames93). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D81157: Propose naming principle for NodeRole and apply it

2020-06-04 Thread Eduardo Caldas via Phabricator via cfe-commits
eduucaldas updated this revision to Diff 268519. eduucaldas added a comment. fixed Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81157/new/ https://reviews.llvm.org/D81157 Files: clang/include/clang/Tooling/Syntax/Nodes.h

[PATCH] D81157: Propose naming principle for NodeRole and apply it

2020-06-04 Thread Eduardo Caldas via Phabricator via cfe-commits
eduucaldas updated this revision to Diff 268517. eduucaldas added a comment. `ArrowToken`, `ExternKeyword` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81157/new/ https://reviews.llvm.org/D81157 Files:

[PATCH] D80735: [OpenMP][NFC] Reuse OMPIRBuilder `struct ident_t` handling in Clang

2020-06-04 Thread Joseph Huber via Phabricator via cfe-commits
jhuber6 added a comment. The failure message is pretty much always this assertion as far as I can tell clang-11: /home/jhuber/Documents/llvm-project/llvm/lib/IR/Instructions.cpp:439: void llvm::CallInst::init(llvm::FunctionType*, llvm::Value*, llvm::ArrayRef, llvm::ArrayRef >, const

[PATCH] D81155: Rename arrow -> arrowToken for unified naming

2020-06-04 Thread Dmitri Gribenko via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG62305f6db4ed: Rename arrow - arrowToken for unified naming (authored by eduucaldas, committed by gribozavr). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D69987: [RISCV] Assemble/Disassemble v-ext instructions.

2020-06-04 Thread Hsiangkai Wang via Phabricator via cfe-commits
HsiangKai added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69987/new/ https://reviews.llvm.org/D69987 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D80735: [OpenMP][NFC] Reuse OMPIRBuilder `struct ident_t` handling in Clang

2020-06-04 Thread Johannes Doerfert via Phabricator via cfe-commits
jdoerfert added a comment. In D80735#2073639 , @jhuber6 wrote: > The failure message is pretty much always this assertion as far as I can tell > > clang-11: > /home/jhuber/Documents/llvm-project/llvm/lib/IR/Instructions.cpp:439: void >

[PATCH] D81168: Add support for id-expression in SyntaxTree

2020-06-04 Thread Eduardo Caldas via Phabricator via cfe-commits
eduucaldas created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. eduucaldas added a subscriber: gribozavr2. eduucaldas marked an inline comment as done. eduucaldas added inline comments. eduucaldas marked an inline comment as not done.

[PATCH] D62922: [WebAssembly] Implement "Reactor" mode

2020-06-04 Thread Bjorn Pettersson via Phabricator via cfe-commits
bjope added inline comments. Comment at: clang/test/Driver/wasm-toolchain.c:116 +// CHECK-COMMAND: clang{{.*}}" "-cc1" {{.*}} "-o" "[[temp:[^"]*]]" +// CHECK-COMMAND: wasm-ld{{.*}}" "crt1.o" "[[temp]]" "-lc" "{{.*[/\\]}}libclang_rt.builtins-wasm32.a" "-o" "a.out" +

[clang-tools-extra] e21c3f2 - [clang-tidy] ignore builtin varargs from pro-type-vararg-check

2020-06-04 Thread Nathan James via cfe-commits
Author: Nathan James Date: 2020-06-04T17:58:23+01:00 New Revision: e21c3f223a3537df0d9d02fce5038b3d7b98ab52 URL: https://github.com/llvm/llvm-project/commit/e21c3f223a3537df0d9d02fce5038b3d7b98ab52 DIFF: https://github.com/llvm/llvm-project/commit/e21c3f223a3537df0d9d02fce5038b3d7b98ab52.diff

[PATCH] D80725: [Analyzer][StreamChecker] Updated initialization of BugType's.

2020-06-04 Thread Balázs Kéri via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG0bfd70bdad7e: [Analyzer][StreamChecker] Updated initialization of BugTypes. (authored by balazske). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80725/new/

[clang] 0bfd70b - [Analyzer][StreamChecker] Updated initialization of BugType's.

2020-06-04 Thread Balázs Kéri via cfe-commits
Author: Balázs Kéri Date: 2020-06-04T16:06:07+02:00 New Revision: 0bfd70bdad7e4ac22d96503fa78a5dd55d4b430e URL: https://github.com/llvm/llvm-project/commit/0bfd70bdad7e4ac22d96503fa78a5dd55d4b430e DIFF: https://github.com/llvm/llvm-project/commit/0bfd70bdad7e4ac22d96503fa78a5dd55d4b430e.diff

[PATCH] D80699: [Analyzer][StreamChecker] Add check for pointer escape.

2020-06-04 Thread Balázs Kéri via Phabricator via cfe-commits
balazske updated this revision to Diff 268459. balazske added a comment. Using range-based for loop. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80699/new/ https://reviews.llvm.org/D80699 Files:

[PATCH] D62922: [WebAssembly] Implement "Reactor" mode

2020-06-04 Thread Bjorn Pettersson via Phabricator via cfe-commits
bjope added inline comments. Comment at: clang/test/Driver/wasm-toolchain.c:116 +// CHECK-COMMAND: clang{{.*}}" "-cc1" {{.*}} "-o" "[[temp:[^"]*]]" +// CHECK-COMMAND: wasm-ld{{.*}}" "crt1.o" "[[temp]]" "-lc" "{{.*[/\\]}}libclang_rt.builtins-wasm32.a" "-o" "a.out" +

[PATCH] D81083: [Clang] Allow "vector_size" applied to Booleans

2020-06-04 Thread Sam Elliott via Phabricator via cfe-commits
lenary added inline comments. Comment at: clang/docs/LanguageExtensions.rst:473 +architectures. The size parameter of a boolean vector type is the number of +bits in the vector (for all non-bool vectors, the number refers to the number +of bytes in the vector).

[PATCH] D74025: [clangd] Add the missing elaborated types in FindTarget.

2020-06-04 Thread Jeff Trull via Phabricator via cfe-commits
jaafar added a comment. I'm very happy this fix exists. I see it's in master, but not in 10.0.0 or 10.0.1-rc1 either. Is there any chance it can be released? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74025/new/ https://reviews.llvm.org/D74025

[PATCH] D81168: Add support for id-expression in SyntaxTree

2020-06-04 Thread Eduardo Caldas via Phabricator via cfe-commits
eduucaldas updated this revision to Diff 268503. eduucaldas marked an inline comment as done. eduucaldas added a comment. . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81168/new/ https://reviews.llvm.org/D81168 Files:

[PATCH] D81157: Propose naming principle for NodeRole and apply it

2020-06-04 Thread Eduardo Caldas via Phabricator via cfe-commits
eduucaldas added inline comments. Comment at: clang/include/clang/Tooling/Syntax/Nodes.h:94 /// a binary expression'. Used for implementing accessors. +// How to name NodeRole: +// If the child node is a token/keyword, end its name with 'Token'/'Keyword'

[PATCH] D81168: Add support for id-expression in SyntaxTree

2020-06-04 Thread Eduardo Caldas via Phabricator via cfe-commits
eduucaldas added inline comments. Comment at: clang/unittests/Tooling/Syntax/TreeTest.cpp:829 +| | | | | `-:: +| | | | `-TypeSpecifier +| | | | |-S eduucaldas wrote: > Perhaps we shouldn't differ between specifiers as that is semantical >

[PATCH] D77168: Add a flag to debug automatic variable initialization

2020-06-04 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay added a comment. In D77168#2070334 , @llozano wrote: > In D77168#2070083 , @MaskRay wrote: > > > In D77168#2070049 , @jcai19 wrote: > > > > > In D77168#2069783

[PATCH] D81157: Propose naming principle for NodeRole and apply it

2020-06-04 Thread Eduardo Caldas via Phabricator via cfe-commits
eduucaldas updated this revision to Diff 268502. eduucaldas marked 2 inline comments as done. eduucaldas added a comment. Fix cout, add explanation Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81157/new/ https://reviews.llvm.org/D81157 Files:

[PATCH] D81163: [AST][RecoveryExpr] Preserve the AST for invalid conditions.

2020-06-04 Thread Haojian Wu via Phabricator via cfe-commits
hokein created this revision. hokein added a reviewer: sammccall. Herald added a project: clang. Tested with enabling "-frecovery-ast", only 1 failure, which is an improvement of secondary diagnostic. -- error: 'error' diagnostics seen but not expected: File

[PATCH] D79715: [clang-format] Update GoogleStyle for C# code to match Google's internal C# style guide

2020-06-04 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG9520bf146dd3: [clang-format] Update GoogleStyle for C# code to match Googles internal C#… (authored by Jonathan Coe jb...@google.com). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D79781: [OpenCL] Add cl_khr_extended_subgroup extensions

2020-06-04 Thread Piotr Fusik via Phabricator via cfe-commits
PiotrFusik marked 2 inline comments as done. PiotrFusik added inline comments. Comment at: clang/lib/Headers/opencl-c.h:15594 +int __ovld sub_group_elect(void); +int __ovld sub_group_non_uniform_all( int predicate ); +int __ovld sub_group_non_uniform_any( int

[PATCH] D81173: [clangd] Change ParseInputs to store FSProvider rather than VFS

2020-06-04 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, javed.absar, ilya-biryukov. Herald added a project: clang. This ensures ParseInputs provides a read-only access to FS. Repository: rG LLVM

[PATCH] D81122: Reland: Use -fdebug-compilation-dir to form absolute paths in coverage mappings

2020-06-04 Thread Keith Smiley via Phabricator via cfe-commits
keith updated this revision to Diff 268510. keith added a comment. Update relative paths to include the leading ./ This makes these remappings more analogous to lldb's source remapping, and makes using `-path-equivalence` with `llvm-cov` more familiar. Repository: rG LLVM Github Monorepo

[PATCH] D81157: Propose naming principle for NodeRole and apply it

2020-06-04 Thread Dmitri Gribenko via Phabricator via cfe-commits
gribozavr2 added inline comments. Comment at: clang/include/clang/Tooling/Syntax/Nodes.h:110 +/// BinaryOperatorExpression_leftHandSide can only appear as a child of a +/// BinaryOperatorExpression node.end with `NodeKind_` of the parent enum class NodeRole : uint8_t {

[PATCH] D69987: [RISCV] Assemble/Disassemble v-ext instructions.

2020-06-04 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay added a comment. Drive-by comment: the clang side change isn't tightly coupled with the LLVM side changes. It should be a separate patch. Comment at: llvm/test/MC/RISCV/rvv/add.s:1 +# RUN: llvm-mc -triple=riscv64 -show-encoding --mattr=+experimental-v < %s \ +# RUN:

[PATCH] D81157: Propose naming principle for NodeRole and apply it

2020-06-04 Thread Dmitri Gribenko via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG42f6fec3878d: Propose naming principle for NodeRole and apply it (authored by eduucaldas, committed by gribozavr). Changed prior to commit: https://reviews.llvm.org/D81157?vs=268519=268543#toc

[clang] 714e84b - [SemaOverload] Use iterator_range to iterate over VectorTypes (NFC).

2020-06-04 Thread Florian Hahn via cfe-commits
Author: Florian Hahn Date: 2020-06-04T20:47:16+01:00 New Revision: 714e84be4615d6e1195f2798c0c3c8c54017dd5f URL: https://github.com/llvm/llvm-project/commit/714e84be4615d6e1195f2798c0c3c8c54017dd5f DIFF: https://github.com/llvm/llvm-project/commit/714e84be4615d6e1195f2798c0c3c8c54017dd5f.diff

[clang] bd1c03d - [OPENMP50]Codegen for inscan reductions in worksharing directives.

2020-06-04 Thread Alexey Bataev via cfe-commits
Author: Alexey Bataev Date: 2020-06-04T16:29:33-04:00 New Revision: bd1c03d7b7c8bdd80b534cf2fa956c36a2f8249f URL: https://github.com/llvm/llvm-project/commit/bd1c03d7b7c8bdd80b534cf2fa956c36a2f8249f DIFF: https://github.com/llvm/llvm-project/commit/bd1c03d7b7c8bdd80b534cf2fa956c36a2f8249f.diff

[PATCH] D81176: [HIP] Add default header and include path

2020-06-04 Thread Artem Belevich via Phabricator via cfe-commits
tra accepted this revision. tra added a comment. This revision is now accepted and ready to land. Thank you for the patch. This will make my life a lot easier. There are a few nits, but it's LGTM in general. Do I understand it correctly that for detection of HIP installation all we need is to

[PATCH] D72778: [Matrix] Add __builtin_matrix_transpose to Clang.

2020-06-04 Thread Florian Hahn via Phabricator via cfe-commits
fhahn updated this revision to Diff 268569. fhahn added a comment. Ping. Simplified code and update tests to use more targeted check lines. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72778/new/ https://reviews.llvm.org/D72778 Files:

[PATCH] D81138: [SemaOverload] Use iterator_range to iterate over VectorTypes (NFC).

2020-06-04 Thread Florian Hahn via Phabricator via cfe-commits
fhahn added a comment. In D81138#2074313 , @rjmccall wrote: > Thanks, LGTM. (But you can use QualType by value.) Thanks, changed in the committed version. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D81169: [clangd] Improve hover on arguments to function call

2020-06-04 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet marked an inline comment as done. kadircet added a comment. thanks! that looks really useful, especially knowing when a parameter is being passed as a ref/val. Comment at: clang-tools-extra/clangd/Hover.cpp:292 +void fillParam(const ParmVarDecl *PVD,

[PATCH] D81188: [RISCV] Support experimental v extensions.

2020-06-04 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay added inline comments. Comment at: clang/test/Driver/riscv-arch.c:364 + +// RUN: %clang -target riscv32-unknown-elf -march=rv32iv -### %s \ +// RUN: -fsyntax-only 2>&1 | FileCheck -check-prefix=RV32-EXPERIMENTAL-V-NOFLAG %s For the RUN lines, I'd prefer

[PATCH] D81192: [OPENMP]Fix PR45854: prevent code movement out of the critical region.

2020-06-04 Thread Alexey Bataev via Phabricator via cfe-commits
ABataev created this revision. ABataev added reviewers: jdoerfert, mikerice. Herald added subscribers: llvm-commits, sstefan1, jfb, guansong, hiraditya, yaxunl. Herald added projects: clang, LLVM. Need to emit memory barriers upon enter/exit to/from critical region to prevent code movement.

[PATCH] D80802: [RISCV] Upgrade RVV MC to v0.9.

2020-06-04 Thread Evandro Menezes via Phabricator via cfe-commits
evandro added a comment. Again, the `clang` part should be split in another patch and be made a child of D81188 . Comment at: llvm/lib/Target/RISCV/AsmParser/RISCVAsmParser.cpp:297 +LMUL_F8 = 5, +LMUL_F4 = 6, +LMUL_F2 = 7

[PATCH] D75181: [AArch64] Handle BTI/PAC in case of generated functions.

2020-06-04 Thread Daniel Kiss via Phabricator via cfe-commits
danielkiss added a comment. depends on D80791 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75181/new/ https://reviews.llvm.org/D75181 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D80743: (PR46111) Desugar Elaborated types in Deduction Guides.

2020-06-04 Thread Richard Smith - zygoloid via Phabricator via cfe-commits
rsmith added a comment. In D80743#2074121 , @erichkeane wrote: > @rsmith I think this implements what you've suggested? Yes, thanks. > This seems to 'work' for a small subset of works, but it doesn't properly > register the typedef to the

[PATCH] D79948: [OPENMP50]Codegen for inscan reductions in worksharing directives.

2020-06-04 Thread Alexey Bataev via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGbd1c03d7b7c8: [OPENMP50]Codegen for inscan reductions in worksharing directives. (authored by ABataev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D81192: [OPENMP]Fix PR45854: prevent code movement out of the critical region.

2020-06-04 Thread Mike Rice via Phabricator via cfe-commits
mikerice added a comment. Is it possible to have the same problem with other directives, like 'omp single' or 'omp master'? I haven't seen any test fail for those yet though. Comment at: llvm/include/llvm/Frontend/OpenMP/OMPIRBuilder.h:357 ///should be called. +

[PATCH] D80301: [yaml][clang-tidy] Fix new line YAML serialization

2020-06-04 Thread Dmitry Polukhin via Phabricator via cfe-commits
DmitryPolukhin updated this revision to Diff 268583. DmitryPolukhin added a comment. Apply suggested changes with string split Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80301/new/ https://reviews.llvm.org/D80301 Files:

[PATCH] D81192: [OPENMP]Fix PR45854: prevent code movement out of the critical region.

2020-06-04 Thread Alexey Bataev via Phabricator via cfe-commits
ABataev added a comment. In D81192#2074677 , @mikerice wrote: > Is it possible to have the same problem with other directives, like 'omp > single' or 'omp master'? I haven't seen any test fail for those yet though. I rather doubt. The main problem

[PATCH] D79835: [Fuchsia] Rely on linker switch rather than dead code ref for profile runtime

2020-06-04 Thread Petr Hosek via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGd51054217403: [Fuchsia] Rely on linker switch rather than dead code ref for profile runtime (authored by phosek). Changed prior to commit: https://reviews.llvm.org/D79835?vs=267336=268591#toc

[PATCH] D81192: [OPENMP]Fix PR45854: prevent code movement out of the critical region.

2020-06-04 Thread Alexey Bataev via Phabricator via cfe-commits
ABataev updated this revision to Diff 268592. ABataev added a comment. Rebase and fixes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81192/new/ https://reviews.llvm.org/D81192 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp

[PATCH] D81115: [PowerPC] Do not special case Darwin on PowerPC in target cpu handling

2020-06-04 Thread Hubert Tong via Phabricator via cfe-commits
hubert.reinterpretcast accepted this revision. hubert.reinterpretcast added a comment. This revision is now accepted and ready to land. LGTM; thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81115/new/ https://reviews.llvm.org/D81115

[PATCH] D81192: [OPENMP]Fix PR45854: prevent code movement out of the critical region.

2020-06-04 Thread Alexey Bataev via Phabricator via cfe-commits
ABataev added a comment. In D81192#2074732 , @jdoerfert wrote: > I doubt this is the right fix. I'll take a closer look. I believe, the issue is caused by the new attributes for kmpc_critical/kmpc_end_critical functions. They are marked as

[PATCH] D81122: Reland: Use -fdebug-compilation-dir to form absolute paths in coverage mappings

2020-06-04 Thread Keith Smiley via Phabricator via cfe-commits
keith added a comment. FYI I actually removed that piece this morning since I felt like since this now supports `-path-equivalence=.,foo` which is the "expected" behavior from lldb, that was "good enough". lmk if you want me to add it back! Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D81150: Use libClangTesting in the unittest for AST matchers

2020-06-04 Thread Dmitri Gribenko via Phabricator via cfe-commits
gribozavr2 marked an inline comment as done. gribozavr2 added inline comments. Comment at: clang/unittests/ASTMatchers/ASTMatchersTest.h:62 +inline ArrayRef langCxx11OrLater() { + static std::vector Result = {Lang_CXX11, Lang_CXX14, Lang_CXX17, +

[PATCH] D81180: AST Matchers test: use arrays instead of vectors

2020-06-04 Thread Dmitri Gribenko via Phabricator via cfe-commits
gribozavr created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. gribozavr2 added a reviewer: njames93. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D81180 Files: clang/unittests/ASTMatchers/ASTMatchersTest.h Index:

[PATCH] D81138: [SemaOverload] Use iterator_range to iterate over VectorTypes (NFC).

2020-06-04 Thread John McCall via Phabricator via cfe-commits
rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Thanks, LGTM. (But you can use QualType by value.) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81138/new/

[PATCH] D81138: [SemaOverload] Use iterator_range to iterate over VectorTypes (NFC).

2020-06-04 Thread Florian Hahn via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG714e84be4615: [SemaOverload] Use iterator_range to iterate over VectorTypes (NFC). (authored by fhahn). Changed prior to commit: https://reviews.llvm.org/D81138?vs=268408=268572#toc Repository: rG

[PATCH] D80932: [SYCL] Make default address space a superset of OpenCL address spaces.

2020-06-04 Thread Anastasia Stulova via Phabricator via cfe-commits
Anastasia added a comment. In D80932#2073542 , @Naghasan wrote: > In D80932#2072064 , @Anastasia wrote: > > > In D80932#2071321 , @bader wrote: > > > > > In D80932#2068863

[PATCH] D79830: Add support of __builtin_expect_with_probability

2020-06-04 Thread Richard Smith - zygoloid via Phabricator via cfe-commits
rsmith added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:10804-10807 + "probability of __builtin_expect_with_probability must be constant " + "floating-point expression">; +def err_probability_out_of_range : Error< + "probability of

[PATCH] D80752: [AArch64]: BFloat MatMul Intrinsics

2020-06-04 Thread Mikhail Maltsev via Phabricator via cfe-commits
miyuki accepted this revision. miyuki added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80752/new/ https://reviews.llvm.org/D80752 ___ cfe-commits mailing list

[clang] 42f6fec - Propose naming principle for NodeRole and apply it

2020-06-04 Thread Dmitri Gribenko via cfe-commits
Author: Eduardo Caldas Date: 2020-06-04T20:08:35+02:00 New Revision: 42f6fec3878d708f2791ab0be3a060b07dac9d76 URL: https://github.com/llvm/llvm-project/commit/42f6fec3878d708f2791ab0be3a060b07dac9d76 DIFF:

[PATCH] D81188: [RISCV] Support experimental v extensions.

2020-06-04 Thread Hsiangkai Wang via Phabricator via cfe-commits
HsiangKai created this revision. HsiangKai added reviewers: MaskRay, rogfer01. Herald added subscribers: cfe-commits, evandro, luismarques, apazos, sameer.abuasal, pzheng, s.egerton, lenary, Jim, benna, psnobl, jocewei, PkmX, rkruppe, the_o, brucehoult, MartinMosbeck, edward-jones, zzheng,

[PATCH] D69987: [RISCV] Assemble/Disassemble v-ext instructions.

2020-06-04 Thread Hsiangkai Wang via Phabricator via cfe-commits
HsiangKai added a comment. In D69987#2074265 , @MaskRay wrote: > Drive-by comment: the clang side change isn't tightly coupled with the LLVM > side changes. It should be a separate patch. Create https://reviews.llvm.org/D81188 for clang side change.

[PATCH] D80730: [OPENMP50]Codegen for use_device_addr clauses.

2020-06-04 Thread Alexey Bataev via Phabricator via cfe-commits
ABataev updated this revision to Diff 268587. ABataev added a comment. Rebase and fixes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80730/new/ https://reviews.llvm.org/D80730 Files: clang/lib/AST/OpenMPClause.cpp

[PATCH] D81192: [OPENMP]Fix PR45854: prevent code movement out of the critical region.

2020-06-04 Thread Johannes Doerfert via Phabricator via cfe-commits
jdoerfert added a comment. I doubt this is the right fix. I'll take a closer look. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81192/new/ https://reviews.llvm.org/D81192 ___ cfe-commits mailing list

[PATCH] D81115: [PowerPC] Do not special case Darwin on PowerPC in target cpu handling

2020-06-04 Thread Steven Wan via Phabricator via cfe-commits
stevewan updated this revision to Diff 268588. stevewan added a comment. Reduce the nested 'if' and reorder it to prefer the more likely case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81115/new/ https://reviews.llvm.org/D81115 Files:

[PATCH] D80450: [CUDA][HIP] Fix implicit HD function resolution

2020-06-04 Thread Yaxun Liu via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG263390d4f5f2: [CUDA][HIP] Fix implicit HD function resolution (authored by yaxunl). Herald added a project: clang. Changed prior to commit: https://reviews.llvm.org/D80450?vs=266366=268590#toc

[clang] d510542 - [Fuchsia] Rely on linker switch rather than dead code ref for profile runtime

2020-06-04 Thread Petr Hosek via cfe-commits
Author: Petr Hosek Date: 2020-06-04T14:25:19-07:00 New Revision: d51054217403b47f452619e11318bd214749a845 URL: https://github.com/llvm/llvm-project/commit/d51054217403b47f452619e11318bd214749a845 DIFF: https://github.com/llvm/llvm-project/commit/d51054217403b47f452619e11318bd214749a845.diff

[clang] f9ea86e - [Docs] Add the entry for `Advanced builds` in UserGuide.rst

2020-06-04 Thread Yuanfang Chen via cfe-commits
Author: Yuanfang Chen Date: 2020-06-04T14:52:51-07:00 New Revision: f9ea86eaa1a3ba18973666c4de56dfde8d488574 URL: https://github.com/llvm/llvm-project/commit/f9ea86eaa1a3ba18973666c4de56dfde8d488574 DIFF: https://github.com/llvm/llvm-project/commit/f9ea86eaa1a3ba18973666c4de56dfde8d488574.diff

[clang] 263390d - [CUDA][HIP] Fix implicit HD function resolution

2020-06-04 Thread Yaxun Liu via cfe-commits
Author: Yaxun (Sam) Liu Date: 2020-06-04T16:54:52-04:00 New Revision: 263390d4f5f23967a31af09eb6e0c12e633d6104 URL: https://github.com/llvm/llvm-project/commit/263390d4f5f23967a31af09eb6e0c12e633d6104 DIFF:

[PATCH] D81176: [HIP] Add default header and include path

2020-06-04 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl created this revision. yaxunl added a reviewer: tra. Herald added subscribers: kerbowa, mgorny, nhaehnle, jvesely. To support std::complex and some other standard C/C++ functions in HIP device code, they need to be forced to be `__host__ __device__` functions by pragmas. This is done by

[PATCH] D80896: [clang-tidy][misc-redundant-expression] Support for CXXFoldExpr

2020-06-04 Thread Zinovy Nis via Phabricator via cfe-commits
zinovy.nis updated this revision to Diff 268527. zinovy.nis added a comment. Simplify test. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80896/new/ https://reviews.llvm.org/D80896 Files: clang-tools-extra/clang-tidy/misc/RedundantExpressionCheck.cpp

[PATCH] D81131: [DebugInfo] Fix assertion for extern void type

2020-06-04 Thread David Blaikie via Phabricator via cfe-commits
dblaikie added a comment. Patches without tests shouldn't be approved - and at least the usual/rough metric I use for patch approval is (most often - unless I'm reviewing the work of the code owner in any area who wants a second opinion, etc) - I approve it if I'd be willing to commit a

  1   2   3   >