[PATCH] D81168: Add support for DeclRefExpr in SyntaxTree, by generating IdExpressions

eduucaldas marked 6 inline comments as done. eduucaldas added inline comments. Comment at: clang/lib/Tooling/Syntax/BuildTree.cpp:618 + Builder.foldNode(Builder.getRange(it.getLocalSourceRange()), NS, nullptr); + Builder.markChild(NS, syntax::NodeRole::Unknown); +}

[PATCH] D81168: Add support for DeclRefExpr in SyntaxTree, by generating IdExpressions

eduucaldas updated this revision to Diff 269422. eduucaldas edited the summary of this revision. eduucaldas added a comment. Answering simple comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81168/new/ https://reviews.llvm.org/D81168 Files:

[PATCH] D81168: Add support for DeclRefExpr in SyntaxTree, by generating IdExpressions

eduucaldas updated this revision to Diff 269423. eduucaldas added a comment. nswering simple comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81168/new/ https://reviews.llvm.org/D81168 Files: clang/include/clang/Tooling/Syntax/Nodes.h cl

[PATCH] D81390: [KernelAddressSanitizer] Make globals constructors compatible with kernel [v2]

melver added a comment. In D81390#2081067 , @nathanchance wrote: > I do not know enough about KASAN enough to review this patch but I can say > that against mainline at > https://git.kernel.org/linus/af7b4801030c07637840191c69eb666917e4135d, there > ap

[PATCH] D81168: Add support for DeclRefExpr in SyntaxTree, by generating IdExpressions

gribozavr2 added inline comments. Comment at: clang/include/clang/Tooling/Syntax/Nodes.h:209 +/// qualified-id: +/// nested-name-specifier template_opt unqualified-id +class IdExpression final : public Expression { Please add a TODO for the accessor for the 'te

[PATCH] D80669: [analyzer] LoopWidening: fix crash by avoiding aliased references invalidation

AbbasSabra added a comment. Gentle reminder Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80669/new/ https://reviews.llvm.org/D80669 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://list

[PATCH] D81380: [clangd] Don't produce snippets when completion location is followed by parenthesis

kbobyrev added inline comments. Comment at: clang-tools-extra/clangd/CodeComplete.cpp:1283 + Recorder->CCSema->getSourceManager(), Recorder->CCSema->LangOpts); + HasParenthesisAfter = NextToken->getKind() == tok::l_paren; auto Style = getFormatStyleForFile(Se

[PATCH] D81380: [clangd] Don't produce snippets when completion location is followed by parenthesis

kbobyrev updated this revision to Diff 269430. kbobyrev marked 9 inline comments as done. kbobyrev added a comment. Make sure snippets are omitted only in the function/method/constructor calls for safety and extend the testset. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

[PATCH] D81351: [clangd] Parse std::make_unique, and emit template diagnostics at expansion.

hokein accepted this revision. hokein added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/Diagnostics.cpp:692 +LastDiagWasOriginalError = +Info.getDiags()->getDiagnosticIDs()->isDefaultMappingAsError( +

[PATCH] D72705: [analyzer] Added new checker 'alpha.unix.ErrorReturn'.

martong added a comment. In D72705#2041779 , @balazske wrote: > I can make comparisons if more functions are added to the checker, `fputs` > only is not sufficient. Yes, you cannot measure just with fputs, similar thing happened to me with StdCLibraryF

[PATCH] D81061: [Analyzer][VLASizeChecker] Fix problem with zero index assumption.

balazske marked 2 inline comments as done. balazske added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/VLASizeChecker.cpp:130-131 +// At least check for zero again. +// Assume that this is a more exact fact than the previous assumptions +

[PATCH] D79912: Assignment and Inc/Dec operators wouldn't register as a mutation when Implicit Paren Casts were present

njames93 added a comment. In D79912#2081402 , @Tridacnid wrote: > Awesome. I don't have commit access, https://llvm.org/docs/Phabricator.html > says I just need to ask here and someone will pick it up. Let me know if > there's anything else I need to do.

[PATCH] D75665: [analyzer] On-demand parsing capability for CTU

gamesh411 updated this revision to Diff 269439. gamesh411 added a comment. Extend index file format Update documentation Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75665/new/ https://reviews.llvm.org/D75665 Files: clang/docs/analyzer/user-doc

[clang] 3323a62 - [Matrix] Add __builtin_matrix_transpose to Clang.

Author: Florian Hahn Date: 2020-06-09T10:14:37+01:00 New Revision: 3323a628ec821b8b75d3b60bf1510931f97d3883 URL: https://github.com/llvm/llvm-project/commit/3323a628ec821b8b75d3b60bf1510931f97d3883 DIFF: https://github.com/llvm/llvm-project/commit/3323a628ec821b8b75d3b60bf1510931f97d3883.diff

[clang] 7117066 - [clang-format] Brace breaking for C# lambdas

Author: Jonathan Coe Date: 2020-06-09T10:20:01+01:00 New Revision: 7117066bd6182f53ec9f97d2e5e81de27c2e0db0 URL: https://github.com/llvm/llvm-project/commit/7117066bd6182f53ec9f97d2e5e81de27c2e0db0 DIFF: https://github.com/llvm/llvm-project/commit/7117066bd6182f53ec9f97d2e5e81de27c2e0db0.diff

[PATCH] D81380: [clangd] Don't produce snippets when completion location is followed by parenthesis

sammccall added inline comments. Comment at: clang-tools-extra/clangd/CodeComplete.cpp:1712 +SemaCCS, QueryScopes, *Inserter, FileName, CCContextKind, Opts, +/*GenerateSnippets=*/!IsUsingDeclaration && !HasParenthesisAfter); else sa

[PATCH] D81428: [ARM] Moving CMSE handling of half arguments and return to the backend

pratlucas updated this revision to Diff 269452. pratlucas added a comment. Moving the clean-up of the Clang-side handling to a separate patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81428/new/ https://reviews.llvm.org/D81428 Files: llvm/l

[PATCH] D81380: [clangd] Don't produce snippets when completion location is followed by parenthesis

sammccall accepted this revision. sammccall marked 2 inline comments as done. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/CodeComplete.cpp:1283 + Recorder->CCSema->getSourceManager(), Recorder->CC

[PATCH] D81451: [ARM][Clang] Removing lowering of half-precision FP arguments and returns from Clang's CodeGen

pratlucas created this revision. Herald added subscribers: cfe-commits, danielkiss, dmgreen, kristof.beyls. Herald added a project: clang. pratlucas added a parent revision: D81428: [ARM] Moving CMSE handling of half arguments and return to the backend. pratlucas added reviewers: rjmccall, chill,

[PATCH] D81452: [AST] RecoveryAST options should only be enabled for C++ only.

hokein created this revision. hokein added a reviewer: sammccall. Herald added a project: clang. The flag should be off for non-c++ files even there is a "-frecovery-ast" in the commandline. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D81452 Files: clang/lib/Frontend/Compi

[PATCH] D75169: [ARM] Supporting lowering of half-precision FP arguments and returns in AArch32's backend

pratlucas updated this revision to Diff 269450. pratlucas added a comment. Splitting the patch into two parts: one for introducing the half-precision handling into AArch32's backend and one for removing the existing coercion of those arguments from Clang. Repository: rG LLVM Github Monorepo C

[PATCH] D80941: [PowerPC][Power10] Implement Count Leading/Trailing Zeroes Builtins under bit Mask in LLVM/Clang

nemanjai accepted this revision. nemanjai added a comment. This revision is now accepted and ready to land. LGTM. Thanks Amy. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80941/new/ https://reviews.llvm.org/D80941 __

[PATCH] D80421: [Mips] use correct ld.so for musl soft float

joewholden added a comment. This is actually wrong anyway Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80421/new/ https://reviews.llvm.org/D80421 ___ cfe-commits mailing list cfe-commits@lists.llvm.or

[PATCH] D72778: [Matrix] Add __builtin_matrix_transpose to Clang.

This revision was automatically updated to reflect the committed changes. Closed by commit rG3323a628ec82: [Matrix] Add __builtin_matrix_transpose to Clang. (authored by fhahn). Changed prior to commit: https://reviews.llvm.org/D72778?vs=269050&id=269463#toc Repository: rG LLVM Github Monore

[PATCH] D81394: [clang-format] Brace breaking for C# lambdas

This revision was automatically updated to reflect the committed changes. Closed by commit rG7117066bd618: [clang-format] Brace breaking for C# lambdas (authored by Jonathan Coe ). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81394

[clang] 29353e6 - [analyzer] LoopWidening: fix crash by avoiding aliased references invalidation

Author: Abbas Sabra Date: 2020-06-09T12:55:54+03:00 New Revision: 29353e69d25c0f13cd2704ce2269af464d0751a8 URL: https://github.com/llvm/llvm-project/commit/29353e69d25c0f13cd2704ce2269af464d0751a8 DIFF: https://github.com/llvm/llvm-project/commit/29353e69d25c0f13cd2704ce2269af464d0751a8.diff L

[clang] 813734d - [Analyzer] Add `getReturnValueUnderConstruction()` to `CallEvent`

Author: Adam Balogh Date: 2020-06-09T12:08:56+02:00 New Revision: 813734dad7e8b526c39806d1a88820b1f0706fb1 URL: https://github.com/llvm/llvm-project/commit/813734dad7e8b526c39806d1a88820b1f0706fb1 DIFF: https://github.com/llvm/llvm-project/commit/813734dad7e8b526c39806d1a88820b1f0706fb1.diff L

[clang] 98db1f9 - [Analyzer] [NFC] Parameter Regions

Author: Adam Balogh Date: 2020-06-09T12:08:56+02:00 New Revision: 98db1f990fc273adc1ae36d4ce97ce66fd27ac30 URL: https://github.com/llvm/llvm-project/commit/98db1f990fc273adc1ae36d4ce97ce66fd27ac30 DIFF: https://github.com/llvm/llvm-project/commit/98db1f990fc273adc1ae36d4ce97ce66fd27ac30.diff L

[clang] 5419a31 - [Analyzer] Allow creation of stack frame for functions without definition

Author: Adam Balogh Date: 2020-06-09T12:08:57+02:00 New Revision: 5419a3121522fe1251d52c7f1fb790d68581e549 URL: https://github.com/llvm/llvm-project/commit/5419a3121522fe1251d52c7f1fb790d68581e549 DIFF: https://github.com/llvm/llvm-project/commit/5419a3121522fe1251d52c7f1fb790d68581e549.diff L

[PATCH] D81380: [clangd] Don't produce snippets when completion location is followed by parenthesis

kbobyrev added inline comments. Comment at: clang-tools-extra/clangd/CodeComplete.cpp:1715 +CCContextKind, Opts, !IsUsingDeclaration, +NextTokenKind); else sammccall wrote: > now you've got the "should we gen

[PATCH] D81380: [clangd] Don't produce snippets when completion location is followed by parenthesis

kbobyrev updated this revision to Diff 269464. kbobyrev marked 4 inline comments as done. kbobyrev added a comment. Address most comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81380/new/ https://reviews.llvm.org/D81380 Files: clang-tool

[PATCH] D72778: [Matrix] Add __builtin_matrix_transpose to Clang.

fhahn added a comment. In D72778#2080928 , @rjmccall wrote: > Yeah, that's fine. Thank you very much John! I filed https://bugs.llvm.org/show_bug.cgi?id=46251 to keep track of the initializer support, with a note on enabling the commented out test. R

[PATCH] D81444: Make the diagnostic-missing-prototypes put the suggested `static` in front of `const` if exists.

gribozavr2 added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:14252 + FD->getReturnType().isConstQualified()) +return FD->getReturnTypeSourceRange().getBegin().getLocWithOffset( +/*strlen("const ")=*/-6); Could

[PATCH] D81452: [AST] RecoveryAST options should only be enabled for C++ only.

sammccall added a comment. Hmm - why? I thought the idea with the explicit `-frecovery-ast` flag was that we could turn it on even when it's not stable. Isn't the idea that one day it will be stable for C, but not yet? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://r

[PATCH] D80669: [analyzer] LoopWidening: fix crash by avoiding aliased references invalidation

vsavchenko added a comment. Done, sorry for taking so long! Thank you for your work! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80669/new/ https://reviews.llvm.org/D80669 ___ cfe-commits mailing lis

[PATCH] D75169: [ARM] Supporting lowering of half-precision FP arguments and returns in AArch32's backend

pratlucas updated this revision to Diff 269466. pratlucas added a comment. Formatting patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75169/new/ https://reviews.llvm.org/D75169 Files: llvm/include/llvm/CodeGen/TargetLowering.h llvm/lib/Co

[PATCH] D81380: [clangd] Don't produce snippets when completion location is followed by parenthesis

kbobyrev updated this revision to Diff 269471. kbobyrev marked 2 inline comments as done. kbobyrev added a comment. Don't split the snippet omitting logic between the builder and its caller. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81380/new/

[PATCH] D81347: Make ASTFileSignature an array of 20 uint8_t instead of 5 uint32_t

dang updated this revision to Diff 269468. dang marked an inline comment as done. dang added a comment. Address @aprantl's comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81347/new/ https://reviews.llvm.org/D81347 Files: clang/include/cla

[PATCH] D80522: [Analyzer] [NFC] Parameter Regions

This revision was automatically updated to reflect the committed changes. Closed by commit rG98db1f990fc2: [Analyzer] [NFC] Parameter Regions (authored by baloghadamsoftware). Changed prior to commit: https://reviews.llvm.org/D80522?vs=268131&id=269477#toc Repository: rG LLVM Github Monorepo

[PATCH] D80286: [Analyzer] Allow creation of stack frame for functions without definition

This revision was automatically updated to reflect the committed changes. Closed by commit rG5419a3121522: [Analyzer] Allow creation of stack frame for functions without definition (authored by baloghadamsoftware). Changed prior to commit: https://reviews.llvm.org/D80286?vs=266036&id=269478#toc

[PATCH] D81347: Make ASTFileSignature an array of 20 uint8_t instead of 5 uint32_t

dang updated this revision to Diff 269473. dang marked 3 inline comments as done. dang added a comment. Fix bug Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81347/new/ https://reviews.llvm.org/D81347 Files: clang/include/clang/Basic/Module.h

[PATCH] D80669: [analyzer] LoopWidening: fix crash by avoiding aliased references invalidation

This revision was automatically updated to reflect the committed changes. Closed by commit rG29353e69d25c: [analyzer] LoopWidening: fix crash by avoiding aliased references invalidation (authored by AbbasSabra, committed by vsavchenko). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[PATCH] D80366: [Analyzer] Add `getReturnValueUnderConstruction()` to `CallEvent`

This revision was automatically updated to reflect the committed changes. baloghadamsoftware marked an inline comment as done. Closed by commit rG813734dad7e8: [Analyzer] Add `getReturnValueUnderConstruction()` to `CallEvent` (authored by baloghadamsoftware). Changed prior to commit: https://r

[clang] 658af94 - [clangd] Parse std::make_unique, and emit template diagnostics at expansion.

Author: Sam McCall Date: 2020-06-09T12:47:27+02:00 New Revision: 658af9435071d5da017c1d65298bdea19ec095e1 URL: https://github.com/llvm/llvm-project/commit/658af9435071d5da017c1d65298bdea19ec095e1 DIFF: https://github.com/llvm/llvm-project/commit/658af9435071d5da017c1d65298bdea19ec095e1.diff LO

[PATCH] D81455: [clang][NFC] Generate the {Type,ArrayType,UnaryExprOrType,Expression}Traits enumerations from TokenKinds.def...

riccibruno created this revision. riccibruno added a reviewer: aaron.ballman. riccibruno added a project: clang. Herald added subscribers: sstefan1, mgorny. Herald added a reviewer: jdoerfert. riccibruno marked an inline comment as done. riccibruno added inline comments. riccibruno marked 2 inline

[PATCH] D81455: [clang][NFC] Generate the {Type,ArrayType,UnaryExprOrType,Expression}Traits enumerations from TokenKinds.def...

riccibruno marked an inline comment as done. riccibruno added inline comments. Comment at: clang/include/clang/Basic/TokenKinds.def:65 +#endif #ifndef ALIAS #define ALIAS(X,Y,Z) It is slightly unfortunate to have to use both `UNARY_EXPR_OR_TYPE_TRAIT` and `CXX

[PATCH] D81351: [clangd] Parse std::make_unique, and emit template diagnostics at expansion.

sammccall marked 6 inline comments as done. sammccall added inline comments. Comment at: clang-tools-extra/clangd/Diagnostics.cpp:738 + vlog("Dropped diagnostic: {0}: {1}", LastDiag->File, LastDiag->Message); +LastDiag.reset(); + }); hokein wrote: > sha

[PATCH] D81351: [clangd] Parse std::make_unique, and emit template diagnostics at expansion.

sammccall updated this revision to Diff 269479. sammccall marked 2 inline comments as done. sammccall added a comment. review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81351/new/ https://reviews.llvm.org/D81351 Files: clang-tools-ex

[PATCH] D81347: Make ASTFileSignature an array of 20 uint8_t instead of 5 uint32_t

dang added inline comments. Comment at: clang/include/clang/Basic/Module.h:29 #include "llvm/ADT/iterator_range.h" +#include #include aprantl wrote: > Can you move the code that depends on algorithm into a .cpp file? That code is the call to `std::copy` in th

[PATCH] D81455: [clang][NFC] Generate the {Type,ArrayType,UnaryExprOrType,Expression}Traits enumerations from TokenKinds.def...

riccibruno marked 2 inline comments as done. riccibruno added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:6008 def ext_sizeof_alignof_void_type : Extension< - "invalid application of '%sub{select_unary_expr_or_type_trait_kind}0' " - "to a void

[PATCH] D81254: [analyzer] Produce symbolic values for C-array elements

ASDenysPetrov updated this revision to Diff 269481. ASDenysPetrov added a comment. Added more tests changing an array element. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81254/new/ https://reviews.llvm.org/D81254 Files: clang/lib/StaticAnalyzer/Core/RegionStore.cpp clang/test/An

[PATCH] D81254: [analyzer] Produce symbolic values for C-array elements

ASDenysPetrov marked an inline comment as done. ASDenysPetrov added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/RegionStore.cpp:1709 if (!O.getRegion()) -return UnknownVal(); +return svalBuilder.getRegionValueSymbolVal(R); NoQ wrote: >

[PATCH] D81351: [clangd] Parse std::make_unique, and emit template diagnostics at expansion.

This revision was automatically updated to reflect the committed changes. Closed by commit rG658af9435071: [clangd] Parse std::make_unique, and emit template diagnostics at expansion. (authored by sammccall). Changed prior to commit: https://reviews.llvm.org/D81351?vs=269479&id=269486#toc Repo

[PATCH] D81424: Driver: Accept multiple --config options if filenames are the same

sepavloff accepted this revision. sepavloff added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81424/new/ https://reviews.llvm.org/D81424

[PATCH] D81422: Change filecheck default to dump input on failure

aartbik accepted this revision. aartbik added a comment. This revision is now accepted and ready to land. Yes, assuming nobody remembers an adverse side-effect, I think this change will help debugging future failures. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://re

[PATCH] D81380: [clangd] Don't produce snippets when completion location is followed by parenthesis

sammccall accepted this revision. sammccall marked an inline comment as done. sammccall added a comment. Ship it! Comment at: clang-tools-extra/clangd/CodeComplete.cpp:1715 +CCContextKind, Opts, !IsUsingDeclaration, +NextTokenKind

[PATCH] D80784: [clangd][NFC] Explode ReceivedPreamble into a CV

kadircet updated this revision to Diff 269487. kadircet marked 2 inline comments as done. kadircet added a comment. - Make distinction between PreambleCV and RequestsCV clearer. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80784/new/ https://revie

[PATCH] D81422: Change filecheck default to dump input on failure

mehdi_amini updated this revision to Diff 269385. mehdi_amini marked 3 inline comments as done. mehdi_amini added a comment. Herald added a subscriber: delcypher. Fix more tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81422/new/ https://revie

[PATCH] D81422: Change filecheck default to dump input on failure

jpienaar accepted this revision. jpienaar added a comment. I think this is a good default given it provides very useful info in failure case. For cases where folks expect it to fail + don't want it logged, then setting never (if that is a concern) seems better behavior IMHO. Repository: rG L

[PATCH] D81422: Change filecheck default to dump input on failure

mehdi_amini updated this revision to Diff 269342. mehdi_amini added a comment. Herald added subscribers: Sanitizers, cfe-commits, msifontes, jurahul, Kayjukh, frgossen, grosul1, Joonsoo, stephenneuendorffer, liufengdb, aartbik, lucyrfox, mgester, arpith-jacob, csigg, nicolasvasilache, antiagainst

[PATCH] D81422: Change filecheck default to dump input on failure

jdenny added a comment. Also, please grep for `FILECHECK_DUMP_INPUT_ON_FAILURE`. There are a few more occurrences to remove from the repo. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81422/new/ https://reviews.llvm.org/D81422 ___

[PATCH] D81422: Change filecheck default to dump input on failure

mehdi_amini added a comment. In D81422#2080758 , @probinson wrote: > I don't remember the exact reasoning but I believe it had something to do > with bot logs? @jdenny or @thopre might remember. It'd be interesting to hear about it: having the bot log

[PATCH] D81422: Change filecheck default to dump input on failure

thopre accepted this revision. thopre added a comment. In D81422#2080758 , @probinson wrote: > I don't remember the exact reasoning but I believe it had something to do > with bot logs? @jdenny or @thopre might remember. I guess -dump-input just follow

[PATCH] D81422: Change filecheck default to dump input on failure

eugenis accepted this revision. eugenis added a comment. This would help debugging sanitizer failures on the bots a lot. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81422/new/ https://reviews.llvm.org/D81422 ___

[PATCH] D81422: Change filecheck default to dump input on failure

jdenny added inline comments. Comment at: llvm/utils/FileCheck/FileCheck.cpp:117 - "FILECHECK_DUMP_INPUT_ON_FAILURE environment variable.\n" - "This option is deprecated in favor of -dump-input=fail.\n")); Please mention in the patch sum

Re: [clang] 4e3d462 - Fix undefined behaviour when trying to deref nullptr.

Yes, it was revealed by the tests in ubsan testbot. Best regards, Alexey Bataev > 8 июня 2020 г., в 21:10, David Blaikie написал(а): > > Is this covered by existing tests? > >> On Thu, Jun 4, 2020 at 2:52 PM Alexey Bataev via cfe-commits >> wrote: >> >> >> Author: Alexey Bataev >> Date: 20

[PATCH] D81422: Change filecheck default to dump input on failure

jdenny added a comment. In D81422#2080861 , @mehdi_amini wrote: > In D81422#2080758 , @probinson wrote: > > > I don't remember the exact reasoning but I believe it had something to do > > with bot logs? @jdenny or

[PATCH] D81422: Change filecheck default to dump input on failure

mehdi_amini added inline comments. Comment at: llvm/test/FileCheck/dump-input-enable.txt:78 ; Check no -dump-input, which defaults to never. ;-- jdenny wrote: > Are the tests in this section passing for you now

[clang] 0cd4d47 - [clang][StaticAnalyzer] Fix unused variable warning for debug builds

Author: Kadir Cetinkaya Date: 2020-06-09T13:35:41+02:00 New Revision: 0cd4d47cfef09c9486173af149f171ff3c137367 URL: https://github.com/llvm/llvm-project/commit/0cd4d47cfef09c9486173af149f171ff3c137367 DIFF: https://github.com/llvm/llvm-project/commit/0cd4d47cfef09c9486173af149f171ff3c137367.dif

[PATCH] D81452: [AST] RecoveryAST options should only be enabled for C++ only.

hokein abandoned this revision. hokein added a comment. In D81452#2081838 , @sammccall wrote: > Hmm - why? > I thought the idea with the explicit `-frecovery-ast` flag was that we could > turn it on even when it's not stable. > Isn't the idea that one d

[PATCH] D81395: [AST][RecoveryExpr] Preserve the invalid "undef_var" initializer.

hokein marked an inline comment as done. hokein added inline comments. Comment at: clang/include/clang/Sema/Sema.h:3899 + /// Rebuild the given Expr with the TypoExpr degraded to RecoveryExpr. + ExprResult rebuildTypoExprs(Expr *TypoExpr); sammccall wrote: >

[PATCH] D81456: [clangd] Get rid of WantDiagnostics::Yes

kadircet created this revision. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, javed.absar, ilya-biryukov. Herald added a project: clang. kadircet added a reviewer: sammccall. This is an extension clangd provides in LSP layer and to embedders of ClangdServer. Curren

[PATCH] D81408: [builtins] Improve compatibility with 16 bit targets

atrosinenko added inline comments. Comment at: compiler-rt/lib/builtins/fp_lib.h:49 -static __inline int rep_clz(rep_t a) { return __builtin_clz(a); } +static __inline int rep_clz(rep_t a) { return clzsi(a); } efriedma wrote: > MaskRay wrote: > > atrosinenko

[PATCH] D79972: [OpenMP5.0] map item can be non-contiguous for target update

ABataev added a comment. Do you have a test for mapping of something like `arr[0][:n]`, where the base is an array subscript and the remaining part is an array section? Comment at: clang/include/clang/AST/OpenMPClause.h:4680-4681 +: AssociatedExpressionNonContiguousPr(

[PATCH] D80900: [clangd] Use different FS in PreambleThread

kadircet abandoned this revision. kadircet added a comment. we've went with D81173 instead. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80900/new/ https://reviews.llvm.org/D80900 __

[clang-tools-extra] 348364b - [clangd] Don't produce snippets when completion location is followed by parenthesis

Author: Kirill Bobyrev Date: 2020-06-09T13:59:29+02:00 New Revision: 348364bffd379e291501dc49b192cdd2adf83811 URL: https://github.com/llvm/llvm-project/commit/348364bffd379e291501dc49b192cdd2adf83811 DIFF: https://github.com/llvm/llvm-project/commit/348364bffd379e291501dc49b192cdd2adf83811.diff

[PATCH] D81459: [SveEmitter] Add SVE tuple types and builtins for svundef.

sdesmalen created this revision. sdesmalen added reviewers: c-rhodes, david-arm, ctetreau, efriedma. Herald added a subscriber: tschuett. Herald added a reviewer: rengolin. Herald added a project: clang. This patch adds new SVE types to Clang that describe tuples of SVE vectors. For example `svint

[PATCH] D80522: [Analyzer] [NFC] Parameter Regions

teemperor added a comment. This introduced a compiler warning: /Users/teemperor/1llvm/llvm-project/clang/include/clang/StaticAnalyzer/Core/PathSensitive/MemRegion.h:1102:23: warning: 'getDecl' overrides a member function but is not marked 'override' [-Winconsistent-missing-override] cons

[PATCH] D80366: [Analyzer] Add `getReturnValueUnderConstruction()` to `CallEvent`

thakis added a comment. Hello, this breaks check-clang everywhere, e.g. http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast/builds/69062/steps/test-check-all/logs/FAIL%3A%20Clang-Unit%3A%3ATestReturnValueUnderConstructionChecker.ReturnValueUnderConstructionChecker Please

[PATCH] D81380: [clangd] Don't produce snippets when completion location is followed by parenthesis

This revision was automatically updated to reflect the committed changes. Closed by commit rG348364bffd37: [clangd] Don't produce snippets when completion location is followed by… (authored by kbobyrev). Changed prior to commit: https://reviews.llvm.org/D81380?vs=269471&id=269501#toc Repositor

[clang] e22ace8 - [Analyzer] Fix buildbot failure caused by commit `rG813734dad7e8b526c39806d1a88820b1f0706fb1`

Author: Adam Balogh Date: 2020-06-09T14:50:27+02:00 New Revision: e22ace8ba2b060e983d7cc2a76d00d6ef3816177 URL: https://github.com/llvm/llvm-project/commit/e22ace8ba2b060e983d7cc2a76d00d6ef3816177 DIFF: https://github.com/llvm/llvm-project/commit/e22ace8ba2b060e983d7cc2a76d00d6ef3816177.diff L

[clang] cb9191c - [OPENMP]Improve code readability, NFC.

Author: Alexey Bataev Date: 2020-06-09T08:50:36-04:00 New Revision: cb9191c0424b9112bf93a3526bcabbe87cd35a92 URL: https://github.com/llvm/llvm-project/commit/cb9191c0424b9112bf93a3526bcabbe87cd35a92 DIFF: https://github.com/llvm/llvm-project/commit/cb9191c0424b9112bf93a3526bcabbe87cd35a92.diff

[PATCH] D81462: [SveEmitter] Add builtins for svtbl2

sdesmalen created this revision. sdesmalen added reviewers: david-arm, efriedma, c-rhodes. Herald added a subscriber: tschuett. Herald added a project: clang. sdesmalen added a parent revision: D81459: [SveEmitter] Add SVE tuple types and builtins for svundef.. Repository: rG LLVM Github Monore

[PATCH] D81408: [builtins] Improve compatibility with 16 bit targets

aykevl added a comment. I tested this patch against my local testing system to make sure it didn't break anything, and I get the same number of failures (most of which are due to a missing complex.h file, which is unrelated). So it looks fine from my point of view, although I know not enough ab

[PATCH] D80366: [Analyzer] Add `getReturnValueUnderConstruction()` to `CallEvent`

baloghadamsoftware added a comment. In D80366#2082100 , @thakis wrote: > Hello, this breaks check-clang everywhere, e.g. > http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast/builds/69062/steps/test-check-all/logs/FAIL%3A%20Clang-

[PATCH] D81439: [X86] Move CPUKind enum from clang to llvm/lib/Support. NFCI

erichkeane added inline comments. Comment at: clang/lib/Basic/Targets/X86.h:132 protected: - /// Enumeration of all of the X86 CPUs supported by Clang. - /// - /// Each enumeration represents a particular CPU supported by Clang. These - /// loosely correspond to the options

[PATCH] D81464: [SveEmitter] Add builtins to insert/extract subvectors from tuples (svget/svset)

sdesmalen created this revision. Herald added subscribers: cfe-commits, tschuett. Herald added a project: clang. sdesmalen added a parent revision: D81459: [SveEmitter] Add SVE tuple types and builtins for svundef.. For example: svint32_t svget4(svint32x4_t tuple, uint64_t imm_index) returns

[PATCH] D81463: [SveEmitter] Add builtins for tuple creation (svcreate2/svcreate3/etc)

sdesmalen created this revision. Herald added a subscriber: tschuett. Herald added a project: clang. sdesmalen added a parent revision: D81459: [SveEmitter] Add SVE tuple types and builtins for svundef.. The svcreate builtins allow constructing a tuple from individual vectors, e.g. svint32x2_t

[PATCH] D81351: [clangd] Parse std::make_unique, and emit template diagnostics at expansion.

thakis added a comment. Breaks tests on windows: http://45.33.8.238/win/17229/step_9.txt Please take a look and revert if it takes a while to fix. (Might just be the usual delayed template parsing thing.) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D81467: [clang-format] Microsoft style fixes for C# properties

jbcoe created this revision. jbcoe added reviewers: krasimir, MyDeveloperDay. jbcoe added a project: clang-format. Herald added a project: clang. Herald added a subscriber: cfe-commits. krasimir accepted this revision. krasimir added a comment. This revision is now accepted and ready to land. Than

[PATCH] D81467: [clang-format] Microsoft style fixes for C# properties

krasimir accepted this revision. krasimir added a comment. This revision is now accepted and ready to land. Thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81467/new/ https://reviews.llvm.org/D81467 _

[PATCH] D80917: [OpenMP][AMDGCN] Support OpenMP offloading for AMDGCN architecture - Part 2

saiislam updated this revision to Diff 269519. saiislam marked an inline comment as done. saiislam added a comment. 1. Corrected return type of getGridValue to unsigned 2. Fixed GridValues assert issue 3. Edited comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://

[PATCH] D80366: [Analyzer] Add `getReturnValueUnderConstruction()` to `CallEvent`

thakis added a comment. > Thank you, I think I fixed it now. I worked on it for hours, because it > involved lots of git branch changes and the the rebuild was slow. Thanks for the fix! If you notice that fixing a bot will take more than a few minutes, please revert the commit while you work on

[PATCH] D80944: Add begin source location for the attributed statement created from PragmaLoopHint decorated loop

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM aside from a minor nit. Comment at: clang/lib/Parse/ParseStmt.cpp:2189 + + assert(!Attrs.Range.getBegin().isValid()); + Attrs.Range.setBegin(StartLoc); You can use `isInvalid()` here ra

[PATCH] D74025: [clangd] Add the missing elaborated types in FindTarget.

hokein added a comment. In D74025#2076704 , @jaafar wrote: > Thank you. I'm trying to balance stability with getting the fixes I need and > so have been avoiding the "bleeding edge". I find that unfortunately the > newest code tends to be "unstable", as

[clang] 53298b8 - [Analyzer] Remove warning caused by commit `rG98db1f990fc2`

Author: Adam Balogh Date: 2020-06-09T15:40:42+02:00 New Revision: 53298b8c8d74d0064c673db18addfe973b544dbb URL: https://github.com/llvm/llvm-project/commit/53298b8c8d74d0064c673db18addfe973b544dbb DIFF: https://github.com/llvm/llvm-project/commit/53298b8c8d74d0064c673db18addfe973b544dbb.diff L

[clang] 665dbe9 - Revert "[clangd] Parse std::make_unique, and emit template diagnostics at expansion."

Author: Sam McCall Date: 2020-06-09T15:42:22+02:00 New Revision: 665dbe91f2ed97796691f3608db7e28519f43978 URL: https://github.com/llvm/llvm-project/commit/665dbe91f2ed97796691f3608db7e28519f43978 DIFF: https://github.com/llvm/llvm-project/commit/665dbe91f2ed97796691f3608db7e28519f43978.diff LO

[clang] 54f9ddd - [Analyzer] Remove warning caused by commit `rGe22ace8ba2b0`

Author: Adam Balogh Date: 2020-06-09T15:46:15+02:00 New Revision: 54f9ddd8064125c0343980433546709e7dbf4593 URL: https://github.com/llvm/llvm-project/commit/54f9ddd8064125c0343980433546709e7dbf4593 DIFF: https://github.com/llvm/llvm-project/commit/54f9ddd8064125c0343980433546709e7dbf4593.diff L

Re: [PATCH] D81351: [clangd] Parse std::make_unique, and emit template diagnostics at expansion.

I've reverted it... Had written the trivial fix to the test but actually this should work - a delayed templates in the preamble and eager templates in the main file is what we use in production on windows. This seems like a clang bug, maybe an interaction with skip function bodies. On Tue, Jun 9,

[clang] f22b072 - [clang-format] Microsoft style fixes for C# properties

Author: Jonathan Coe Date: 2020-06-09T14:50:34+01:00 New Revision: f22b0727fe767cc8da5e0c59f4e957a05472ffa7 URL: https://github.com/llvm/llvm-project/commit/f22b0727fe767cc8da5e0c59f4e957a05472ffa7 DIFF: https://github.com/llvm/llvm-project/commit/f22b0727fe767cc8da5e0c59f4e957a05472ffa7.diff

  1   2   3   >