[PATCH] D81718: [Analyzer][NFC] Add methods `getReturnObject()` and `getArgObject()` to `CallEvent`

baloghadamsoftware added a comment. In D81718#2096540 , @NoQ wrote: > In D81718#2095965 , > @baloghadamsoftware wrote: > > > Your test case unfortunately does not test what you want, because raw > > pointers are

[PATCH] D81641: [SYCL][OpenMP] Implement thread-local storage restriction

Fznamznon added a comment. Seems that `test/OpenMP/nvptx_target_codegen.cpp` is completely not formatted. If I apply suggestion from pre-merge checks, this will look like a big unrelated to this patch change and it will contradict with the whole file style. Repository: rG LLVM Github

[PATCH] D80880: [clang] [MinGW] Link kernel32 once after the last instance of msvcrt

This revision was automatically updated to reflect the committed changes. Closed by commit rGbeeed368b602: [clang] [MinGW] Link kernel32 once after the last instance of msvcrt (authored by mstorsjo). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D81794: [clang] Don't emit warn_cxx_ms_struct when MSBitfields is enabled globally

This revision was automatically updated to reflect the committed changes. Closed by commit rG7b3fe9699277: [clang] Dont emit warn_cxx_ms_struct when MSBitfields is enabled globally (authored by mstorsjo). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D81718: [Analyzer][NFC] Add methods `getReturnObject()` and `getArgObject()` to `CallEvent`

baloghadamsoftware added a comment. > It tests exactly what i want: the correctness of your code in //this very > patch// that was written to handle //this very case// for which you never > even bothered figuring out the correct solution but you already wrote //a > large amount of code//

[PATCH] D80880: [clang] [MinGW] Link kernel32 once after the last instance of msvcrt

mstorsjo added a comment. In D80880#2066938 , @amccarth wrote: > Yowza. Mingw still links against MSVCRT?! Sorry, I missed this comment earlier - that I see that I want to reply to. Traditionally, mingw still links against the OS private msvcrt.dll

[PATCH] D81795: [clang] Enable -mms-bitfields by default for mingw targets

This revision was automatically updated to reflect the committed changes. Closed by commit rGe3fd9dc9734c: [clang] Enable -mms-bitfields by default for mingw targets (authored by mstorsjo). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81795/new/

[PATCH] D81761: [analyzer] Force dependency checkers to be hidden

balazske added a comment. My observation is, if there is an example checker, it should be really "example" and not "test". (The "custom" is probably good to rename to "test" but not the "example".) (The names of these files look not good too: A **CheckerOptionHandling.cpp** contains an example

[PATCH] D81462: [SveEmitter] Add builtins for svtbl2

This revision was automatically updated to reflect the committed changes. Closed by commit rGe51c1d06a992: [SveEmitter] Add builtins for svtbl2 (authored by sdesmalen). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81462/new/

[clang] 564821a - [www] Update cxx_dr_status page for recent fixes.

Author: Richard Smith Date: 2020-06-16T23:56:45-07:00 New Revision: 564821ad65b6dae0c23f23ddcdfb997a0c5aab66 URL: https://github.com/llvm/llvm-project/commit/564821ad65b6dae0c23f23ddcdfb997a0c5aab66 DIFF: https://github.com/llvm/llvm-project/commit/564821ad65b6dae0c23f23ddcdfb997a0c5aab66.diff

[clang] 02fccc2 - Revert "DR458: Search template parameter scopes in the right order."

Author: Richard Smith Date: 2020-06-16T23:53:44-07:00 New Revision: 02fccc26cf6af22c07fb81ff3aa69abd77850028 URL: https://github.com/llvm/llvm-project/commit/02fccc26cf6af22c07fb81ff3aa69abd77850028 DIFF: https://github.com/llvm/llvm-project/commit/02fccc26cf6af22c07fb81ff3aa69abd77850028.diff

[PATCH] D81995: [xray] Option to omit the function index

ianlevesque created this revision. ianlevesque added reviewers: dberris, MaskRay, johnislarry. Herald added subscribers: llvm-commits, Sanitizers, cfe-commits, arphaman, hiraditya. Herald added projects: clang, Sanitizers, LLVM. Add a flag to omit the xray_fn_idx to cut size overhead and

[clang] e51c1d0 - [SveEmitter] Add builtins for svtbl2

Author: Sander de Smalen Date: 2020-06-17T09:41:38+01:00 New Revision: e51c1d06a9922c3b6ce4b8b2e74126870ade1491 URL: https://github.com/llvm/llvm-project/commit/e51c1d06a9922c3b6ce4b8b2e74126870ade1491 DIFF:

[clang] beeed36 - [clang] [MinGW] Link kernel32 once after the last instance of msvcrt

Author: Martin Storsjö Date: 2020-06-17T09:37:07+03:00 New Revision: beeed368b60252178f66ab117d8a96ecdc35f60e URL: https://github.com/llvm/llvm-project/commit/beeed368b60252178f66ab117d8a96ecdc35f60e DIFF:

[clang] 7b3fe96 - [clang] Don't emit warn_cxx_ms_struct when MSBitfields is enabled globally

Author: Martin Storsjö Date: 2020-06-17T09:37:07+03:00 New Revision: 7b3fe969927731c69ba4d8a428442e1e191f49b5 URL: https://github.com/llvm/llvm-project/commit/7b3fe969927731c69ba4d8a428442e1e191f49b5 DIFF:

[clang] e3fd9dc - [clang] Enable -mms-bitfields by default for mingw targets

Author: Martin Storsjö Date: 2020-06-17T09:37:07+03:00 New Revision: e3fd9dc9734c5775dc6824d0a839702e8d43e7f6 URL: https://github.com/llvm/llvm-project/commit/e3fd9dc9734c5775dc6824d0a839702e8d43e7f6 DIFF:

[PATCH] D81407: [Analyzer][StreamChecker] Add note tags for file opening.

balazske updated this revision to Diff 271291. balazske marked 2 inline comments as done. balazske added a comment. Corrected command line arguments in tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81407/new/ https://reviews.llvm.org/D81407

[PATCH] D81995: [xray] Option to omit the function index

dberris accepted this revision. dberris added a comment. This revision is now accepted and ready to land. LGTM Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81995/new/ https://reviews.llvm.org/D81995

[clang-tools-extra] af3d824 - [clangd] Depend on llvm-config for lit tests

Author: Kadir Cetinkaya Date: 2020-06-17T10:40:16+02:00 New Revision: af3d82453410ff80fab71f1dd9e222ffb6cd5925 URL: https://github.com/llvm/llvm-project/commit/af3d82453410ff80fab71f1dd9e222ffb6cd5925 DIFF:

[PATCH] D75229: [clang-tidy] Add signal-in-multithreaded-program check

gamesh411 added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/SignalInMultithreadedProgramCheck.h:23 +/// Finds ``signal`` function calls when the program is multithreaded. It +/// founds a program multithreaded when it finds at least one function call +///

[PATCH] D80981: [AST] Fix a crash on accessing a class without definition in constexpr function context.

hokein marked an inline comment as done. hokein added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:4320 +if (!RD->hasDefinition()) + return APValue(); APValue Struct(APValue::UninitStruct(), RD->getNumBases(), rsmith wrote: > hokein

[PATCH] D81787: [clang] Fix the serialization of LambdaExpr and the bogus mutation in LambdaExpr::getBody

riccibruno marked 4 inline comments as done. riccibruno added inline comments. Comment at: clang/include/clang/AST/ExprCXX.h:2012-2017 + Stmt *getBody() const { return getStoredStmts()[capture_size()]; } + + /// Retrieve the \p CompoundStmt representing the body of the lambda.

[PATCH] D80681: [clang][SourceManager] cache Macro Expansions

kadircet added a comment. In D80681#2096886 , @nickdesaulniers wrote: > Heh, those were painstakingly written in markdown by hand, using > `CC="/usr/bin/time -v clang"` to test. The weren't statistically significant > (N=1), nor were they

[PATCH] D75229: [clang-tidy] Add signal-in-multithreaded-program check

gamesh411 added a comment. Minor nits inline. Good job, I am not entitled to accept it, but LGTM! Comment at: clang-tools-extra/clang-tidy/bugprone/SignalInMultithreadedProgramCheck.h:23 +/// Finds ``signal`` function calls when the program is multithreaded. It +/// founds a

[PATCH] D81998: [clangd][NFC] Rename FSProvider and getFileSystem

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Clangd uses FSProvider to get threadsafe views into file systems. This patch changes naming to make

[PATCH] D81641: [SYCL][OpenMP] Implement thread-local storage restriction

bader added a comment. In D81641#2097433 , @Fznamznon wrote: > Seems that `test/OpenMP/nvptx_target_codegen.cpp` is completely not > formatted. If I apply suggestion from pre-merge checks, this will look like a > big unrelated to this patch change and

[clang] 34ee254 - [OPENMP50]Codegen for scan directive in for simd regions.

Author: Alexey Bataev Date: 2020-06-17T08:43:17-04:00 New Revision: 34ee2549a72c2947fb3f6677fbe8ad97da100011 URL: https://github.com/llvm/llvm-project/commit/34ee2549a72c2947fb3f6677fbe8ad97da100011 DIFF: https://github.com/llvm/llvm-project/commit/34ee2549a72c2947fb3f6677fbe8ad97da100011.diff

[PATCH] D82002: [clangd] Drop FS usage in ClangTidyOpts

kadircet updated this revision to Diff 271342. kadircet added a comment. - Accept an inner opt provider instead to enable wrapping other types of providers. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82002/new/ https://reviews.llvm.org/D82002

[PATCH] D81920: [clangd] Change FSProvider::getFileSystem to take CurrentWorkingDirectory

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/ClangdServer.cpp:323 +format::DefaultFallbackStyle, Code, +

[PATCH] D79842: [clang][Driver] Correct tool search path priority

DavidSpickett marked 2 inline comments as done. DavidSpickett added inline comments. Comment at: clang/test/Driver/program-path-priority.c:22 +/// No gccs at all, nothing is found +// RUN: env "PATH=" %t/clang -### -target notreal-none-elf %s 2>&1 \ +// RUN: | FileCheck

[PATCH] D81967: [clang-tools-extra] Prevent linking to duplicate .a libs and dylib

sammccall added a comment. I'm afraid I don't really understand how this fix works, so my questions might be silly. Thanks for fixing things! Comment at: clang-tools-extra/clangd/CMakeLists.txt:105 + +clang_target_link_libraries(clangDaemon + PRIVATE This

[PATCH] D75169: [ARM] Supporting lowering of half-precision FP arguments and returns in AArch32's backend

ostannard accepted this revision. ostannard added a comment. This revision is now accepted and ready to land. I don't think it makes sense to make `f16` legal for targets which don't have any arithmetic operations on it, since that would be contrary to the definition of "legal". I'd also expect

[PATCH] D81718: [Analyzer][NFC] Add methods `getReturnObject()` and `getArgObject()` to `CallEvent`

baloghadamsoftware added a comment. I am really sorry to tell that, but now I began adding support for raw pointers as iterators (I will upload them in a separate patch when fully ready) and then tried your test. It passes, the error is found using this particular patch. So please tell me what

[PATCH] D81641: [SYCL][OpenMP] Implement thread-local storage restriction

Fznamznon updated this revision to Diff 271327. Fznamznon edited the summary of this revision. Fznamznon added a comment. Rebased. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81641/new/ https://reviews.llvm.org/D81641 Files:

[PATCH] D81998: [clangd][NFC] Rename FSProvider and getFileSystem

kadircet updated this revision to Diff 271330. kadircet added a comment. - Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81998/new/ https://reviews.llvm.org/D81998 Files: clang-tools-extra/clangd/ClangdLSPServer.cpp

[PATCH] D81920: [clangd] Change FSProvider::getFileSystem to take CurrentWorkingDirectory

kadircet added inline comments. Comment at: clang-tools-extra/clangd/ClangdServer.cpp:187 +Opts.ClangTidyOpts = +GetClangTidyOptions(*FSProvider.getFileSystem("."), File); Opts.SuggestMissingIncludes = SuggestMissingIncludes; sammccall wrote: >

[PATCH] D81920: [clangd] Change FSProvider::getFileSystem to take CurrentWorkingDirectory

kadircet updated this revision to Diff 271328. kadircet added a comment. - Provide two overloads to make implicit string -> StringRef conversion possible. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81920/new/ https://reviews.llvm.org/D81920

[PATCH] D81975: [clangd] Add command line option for ClangTidyConfig

sammccall added a comment. Good/bad news on timing here... I'd like to introduce a config system (user config file, but also eventually in-project `.clangd` files, extensible over LSP etc). It'll provide a generic way to apply different config to different files. And it'll be YAML files on disk

[PATCH] D81953: [clang-tidy] warnings-as-error no longer exits with ErrorCount

aaron.ballman added a comment. In D81953#2096635 , @njames93 wrote: > In D81953#2096388 , @aaron.ballman > wrote: > > > LGTM unless @jroelofs has a reason why the code was originally written that > > way, but can

[PATCH] D81967: [clang-tools-extra] Prevent linking to duplicate .a libs and dylib

mgorny added a comment. Ok, I don't think this failure is due to my changes but I've proposed a solution as D82001 anyway. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81967/new/ https://reviews.llvm.org/D81967

[PATCH] D82004: [clang-tidy][NFC] Remove the double look-up on IncludeInserter

njames93 created this revision. njames93 added reviewers: klimek, gribozavr2, aaron.ballman, alexfh. Herald added subscribers: cfe-commits, xazax.hun. Herald added a project: clang. Refactor out the double lookup in `IncludeInserter` when trying to get the `IncludeSorter` for a specified

[PATCH] D81718: [Analyzer][NFC] Add methods `getReturnObject()` and `getArgObject()` to `CallEvent`

NoQ added a comment. > These functions are not called at all by your tests! Of course they aren't. Because they're dead code. You just introduced them and haven't called them yet. But that code is taken and re-used from the checker. And the code in the checker has the problem. And after you

[PATCH] D81641: [SYCL][OpenMP] Implement thread-local storage restriction

This revision was automatically updated to reflect the committed changes. Closed by commit rG0bdcd95bf20f: [SYCL][OpenMP] Implement thread-local storage restriction (authored by Fznamznon, committed by bader). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D81478: [OPENMP50]Codegen for scan directives in parallel for regions.

ABataev marked an inline comment as done. ABataev added inline comments. Comment at: clang/lib/CodeGen/CGStmtOpenMP.cpp:3627 + emitScanBasedDirective(CGF, S, NumIteratorsGen, FirstGen, SecondGen); +} else { + OMPCancelStackRAII CancelRegion(CGF, OMPD_parallel_for,

[clang-tools-extra] df9a51d - Remove global std::strings. NFCI.

Author: Benjamin Kramer Date: 2020-06-17T14:29:42+02:00 New Revision: df9a51dab3512f61d7f26c16fd1358bf99c266e1 URL: https://github.com/llvm/llvm-project/commit/df9a51dab3512f61d7f26c16fd1358bf99c266e1 DIFF:

[PATCH] D81407: [Analyzer][StreamChecker] Add note tags for file opening.

Szelethus accepted this revision. Szelethus marked 2 inline comments as done. Szelethus added a comment. This revision is now accepted and ready to land. Yay! Getting so close to enabling this by default. I'm a big fan of your work on this checker. Comment at:

[PATCH] D82002: [clangd] Drop FS usage in ClangTidyOpts

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Depends on D81998 Repository: rG LLVM Github Monorepo

[PATCH] D81761: [analyzer] Force dependency checkers to be hidden

Szelethus added a comment. In D81761#2097561 , @balazske wrote: > My observation is, if there is an example checker, it should be really > "example" and not "test". (The "custom" is probably good to rename to "test" > but not the "example".) (The names

[PATCH] D81975: [clangd] Add command line option for ClangTidyConfig

njames93 added a comment. Gotta say it's not hugely pressing. The reason for it is clangd lets you specify some checks to run but it doesn't let you specify the options for those checks. Effectively forcing each project to require a .clang-tidy configuration file if you want to use checks where

[clang] 0bdcd95 - [SYCL][OpenMP] Implement thread-local storage restriction

Author: Mariya Podchishchaeva Date: 2020-06-17T14:36:00+03:00 New Revision: 0bdcd95bf20f159a2512aff1ef032bec52039bf6 URL: https://github.com/llvm/llvm-project/commit/0bdcd95bf20f159a2512aff1ef032bec52039bf6 DIFF:

[clang] 93cd411 - [NFC] Run clang-format on clang/test/OpenMP/nvptx_target_codegen.cpp

Author: Alexey Bader Date: 2020-06-17T13:04:01+03:00 New Revision: 93cd4115799cefa698833ca7a2f1899243d94c77 URL: https://github.com/llvm/llvm-project/commit/93cd4115799cefa698833ca7a2f1899243d94c77 DIFF: https://github.com/llvm/llvm-project/commit/93cd4115799cefa698833ca7a2f1899243d94c77.diff

[PATCH] D81678: Introduce partialinit attribute at call sites for stricter poison analysis

efriedma added a comment. In terms of the C++ API, we definitely want to provide an API phrased positively in terms of individual arguments, so transforms don't have to deal with inverted logic. In terms of the actual internal memory representation, or textual IR, maybe we can be a bit more

[PATCH] D81958: [clangd] Add library to semantically strip flags by name.

adamcz added inline comments. Comment at: clang-tools-extra/clangd/CompileCommands.cpp:256 + case Option::RemainingArgsClass: +return {1, 0}; + case Option::RemainingArgsJoinedClass: nit: could you replace 1 with some constant value with

[PATCH] D79842: [clang][Driver] Correct tool search path priority

DavidSpickett updated this revision to Diff 271345. DavidSpickett added a comment. Moved pipe (|) to end of the first lines to make it clearer that there's a continuation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79842/new/

[clang] 5bf0858 - Return "[InstCombine] Simplify compare of Phi with constant inputs against a constant"

Author: Sam Parker Date: 2020-06-17T11:38:59+01:00 New Revision: 5bf0858c0b4cb5237fa4bf0cf58a76ec5076ef5a URL: https://github.com/llvm/llvm-project/commit/5bf0858c0b4cb5237fa4bf0cf58a76ec5076ef5a DIFF: https://github.com/llvm/llvm-project/commit/5bf0858c0b4cb5237fa4bf0cf58a76ec5076ef5a.diff

[PATCH] D81422: Change filecheck default to dump input on failure

arsenm added a comment. I would also expect a simple command line flag to llvm-lit to be able to control this, rather than having to set an environment variable Comment at: mlir/test/mlir-tblgen/op-format-spec.td:1 -// RUN: mlir-tblgen -gen-op-decls

[PATCH] D81678: Introduce partialinit attribute at call sites for stricter poison analysis

aqjune added a comment. In D81678#2091089 , @eugenis wrote: > Positive attribute sounds good to me (frozen is not a bad name), but the > tests update change is going to be huge. Any concerns about IR size bloat? > The attribute will apply to the

[PATCH] D81422: Change filecheck default to dump input on failure

mehdi_amini marked an inline comment as done. mehdi_amini added a comment. In D81422#2096643 , @arsenm wrote: > I would also expect a simple command line flag to llvm-lit to be able to > control this, rather than having to set an environment variable

[PATCH] D81886: [AMDGPU] Add gfx1030 target

foad added inline comments. Comment at: llvm/docs/AMDGPUUsage.rst:266-267 names. + ``gfx1030`` ``amdgcn`` dGPU - xnack *TBA* +

[PATCH] D81678: Introduce partialinit attribute at call sites for stricter poison analysis

guiand added a comment. In D81678#2097081 , @aqjune wrote: > To minimize diff, what about additionally introducing a function-level > attribute such as `args_frozen` stating that all arguments are frozen. (e.g > `define void @f(i32 x, i32 y)

[PATCH] D81920: [clangd] Change FSProvider::getFileSystem to take CurrentWorkingDirectory

kadircet updated this revision to Diff 271312. kadircet marked 2 inline comments as done. kadircet added a comment. - Change signature to llvm::Optional to accomodate call sites that don't want to cd Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D81407: [Analyzer][StreamChecker] Add note tags for file opening.

NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StreamChecker.cpp:406 +const ExplodedNode *StreamChecker::getAcquisitionSite(const ExplodedNode *N, + SymbolRef StreamSym, Ok, so this

[PATCH] D82016: [clang-format] [PR462254] fix indentation of default and break correctly in whitesmiths style

MyDeveloperDay created this revision. MyDeveloperDay added reviewers: krasimir, JakeMerdichAMD, curdeius, jbcoe, timwoj. MyDeveloperDay added projects: clang, clang-format. https://bugs.llvm.org/show_bug.cgi?id=46254 In ‘clang-format’, when using "BreakBeforeBraces: Whitesmiths". In a ‘switch’

[PATCH] D81407: [Analyzer][StreamChecker] Add note tags for file opening.

NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StreamChecker.cpp:406 +const ExplodedNode *StreamChecker::getAcquisitionSite(const ExplodedNode *N, + SymbolRef StreamSym, NoQ wrote:

[PATCH] D82002: [clangd] Drop FS usage in ClangTidyOpts

sammccall added inline comments. Comment at: clang-tools-extra/clangd/ClangdServer.h:46 -/// to allow reading tidy configs from the VFS used for parsing. -using ClangTidyOptionsBuilder = std::function; Hmm, I like the idea of avoiding a custom type and just

[PATCH] D74166: [AIX][Frontend] Static init implementation for AIX considering no priority

jasonliu added inline comments. Comment at: clang/lib/CodeGen/CGDeclCXX.cpp:708 +" based on strong external symbols"); + GlobalUniqueModuleId = GlobalUniqueModuleId.substr(1); +} Correct me if I'm wrong... `GlobalUniqueModuleId` will always

[PATCH] D81967: [clang-tools-extra] Prevent linking to duplicate .a libs and dylib

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Thanks! I understand the clangd stuff better now, and scanning through the other changes they seem to be the same pattern. LGTM Comment at:

[PATCH] D81964: [clangd] Make use of preamble bounds from the patch inside ReplayPreamble

This revision was automatically updated to reflect the committed changes. Closed by commit rG4317ee27bd64: [clangd] Make use of preamble bounds from the patch inside ReplayPreamble (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D81478: [OPENMP50]Codegen for scan directives in parallel for regions.

jdoerfert added inline comments. Comment at: clang/lib/CodeGen/CGStmtOpenMP.cpp:3627 + emitScanBasedDirective(CGF, S, NumIteratorsGen, FirstGen, SecondGen); +} else { + OMPCancelStackRAII CancelRegion(CGF, OMPD_parallel_for, S.hasCancel()); ABataev

[PATCH] D81972: [NFC] Cleanup of EmitCXXGlobalInitFunc() and EmitCXXGlobalDtorFunc()

jasonliu added inline comments. Comment at: clang/lib/CodeGen/CGDeclCXX.cpp:596 } + // Include the filename in the symbol name. Including "sub_" matches gcc jasonliu wrote: > I think this patch is missing what @hubert.reinterpretcast mentioned in >

[PATCH] D82019: [OPENMP]Fix PR46357: Do not allow types declarations in pragmas.

jdoerfert added reviewers: dreachem, kkwli0, trws. jdoerfert added a comment. Hm, does the standard say this is not allowed? I can see that we don't want it but I'm not 100% certain here. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82019/new/

[PATCH] D72782: [Matrix] Add __builtin_matrix_column_store to Clang.

fhahn updated this revision to Diff 271401. fhahn added a comment. Ping :) Rebased and applied feedback from D72781 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72782/new/ https://reviews.llvm.org/D72782

[PATCH] D82026: [OPENMP50]Allow nonmonotonic modifier for all schedule kinds.

ABataev created this revision. ABataev added a reviewer: jdoerfert. Herald added subscribers: sstefan1, guansong, yaxunl. Herald added a project: clang. According to OpenMP 5.0, nonmonotonic modifier can be used with all schedule kinds, not only dynamic and guided as in OpenMP 4.5. Repository:

[PATCH] D82019: [OPENMP]Fix PR46357: Do not allow types declarations in pragmas.

ABataev added a comment. In D82019#2098509 , @jdoerfert wrote: > Hm, does the standard say this is not allowed? I can see that we don't want > it but I'm not 100% certain here. It does not say anything specific, but I don't think it is a good idea to

[clang-tools-extra] c76edaa - [clang-tidy] Prune dead code. NFC.

Author: Benjamin Kramer Date: 2020-06-17T21:16:59+02:00 New Revision: c76edaabddea8a9b077859fcfa4d1465b7ce6a46 URL: https://github.com/llvm/llvm-project/commit/c76edaabddea8a9b077859fcfa4d1465b7ce6a46 DIFF:

[PATCH] D79675: [OpenMP][OMPBuilder] Adding Privatization Requirements to OMPIRBuilder

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LGTM. Thanks a lot! Sorry for the delay in reviewing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79675/new/

[PATCH] D81970: [Clang][Driver] Remove gold linker support for PS4 toolchain

This revision was automatically updated to reflect the committed changes. Closed by commit rG2956cc50f340: [Clang][Driver] Remove gold linker support for PS4 toolchain (authored by ychen). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81970/new/

[PATCH] D81478: [OPENMP50]Codegen for scan directives in parallel for regions.

ABataev marked an inline comment as done. ABataev added inline comments. Comment at: clang/lib/CodeGen/CGStmtOpenMP.cpp:3627 + emitScanBasedDirective(CGF, S, NumIteratorsGen, FirstGen, SecondGen); +} else { + OMPCancelStackRAII CancelRegion(CGF, OMPD_parallel_for,

[PATCH] D81967: [clang-tools-extra] Prevent linking to duplicate .a libs and dylib

This revision was automatically updated to reflect the committed changes. Closed by commit rGd4f298c8206b: [clang-tools-extra] Prevent linking to duplicate .a libs and dylib (authored by mgorny). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D81463: [SveEmitter] Add builtins for tuple creation (svcreate2/svcreate3/etc)

efriedma accepted this revision. efriedma added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81463/new/ https://reviews.llvm.org/D81463 ___ cfe-commits mailing list

[PATCH] D82004: [clang-tidy][NFC] Remove the double look-up on IncludeInserter

This revision was automatically updated to reflect the committed changes. Closed by commit rG08c83ed75752: [clang-tidy][NFC] Remove the double look-up on IncludeInserter (authored by njames93). Changed prior to commit: https://reviews.llvm.org/D82004?vs=271334=271432#toc Repository: rG LLVM

[PATCH] D79796: Sketch support for generating CC1 command line from CompilerInvocation

dang updated this revision to Diff 271392. dang added a comment. Fixed a couple of bugs. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79796/new/ https://reviews.llvm.org/D79796 Files: clang/include/clang/Driver/CC1Options.td

[PATCH] D81970: [Clang][Driver] Remove gold linker support for PS4 toolchain

ychen updated this revision to Diff 271394. ychen added a comment. - address comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81970/new/ https://reviews.llvm.org/D81970 Files: clang/lib/Driver/ToolChains/PS4CPU.cpp

[PATCH] D79167: [SVE][CodeGen] Legalisation of vsetcc with scalable types

kmclaughlin updated this revision to Diff 271391. kmclaughlin retitled this revision from "[SVE][CodeGen] Legalise scalable vector types for vsetcc & vselect" to "[SVE][CodeGen] Legalisation of vsetcc with scalable types". kmclaughlin edited the summary of this revision. kmclaughlin added a

[PATCH] D82029: [Coroutines] Ensure co_await promise.final_suspend() does not throw

lxfind created this revision. lxfind added reviewers: lewissbaker, modocache. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch addresses https://bugs.llvm.org/show_bug.cgi?id=46256 The spec of coroutine requires that the expression co_­await

[PATCH] D78903: [Driver] Add option -fproc-stat-report

aganea added inline comments. Comment at: clang/lib/Driver/Driver.cpp:3782 + = Cmd.getProcessStatistics(); + if (ProcStat) { +if (PrintProcessStat) { sepavloff wrote: > aganea wrote: > > In the case where `!ProcStat`, I am wondering if we

[PATCH] D81998: [clangd][NFC] Rename FSProvider and getFileSystem

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/support/ThreadsafeFS.h:31 + virtual ~ThreadsafeFS() = default; + /// Obtain a vfs::FileSystem with an arbitrary initial

[PATCH] D77493: [clang-tidy] Add do-not-refer-atomic-twice check

abelkocsis added a comment. Would you give me some feedback according to this checker? Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77493/new/ https://reviews.llvm.org/D77493 ___ cfe-commits mailing

[PATCH] D75229: [clang-tidy] Add signal-in-multithreaded-program check

abelkocsis updated this revision to Diff 271414. abelkocsis added a comment. Fixes on description and documentation Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75229/new/ https://reviews.llvm.org/D75229 Files: asd.diff

[PATCH] D82011: [clangd] Don't mangle workdir-relevant driver path in compile commands

sammccall marked an inline comment as done. sammccall added inline comments. Comment at: clang-tools-extra/clangd/CompileCommands.cpp:141 +// Let's hope it's not a symlink. +if (llvm::any_of(Driver, + [](char C) { return

[PATCH] D81998: [clangd][NFC] Rename FSProvider and getFileSystem

sammccall added inline comments. Comment at: clang-tools-extra/clangd/unittests/TestFS.h:34 // A VFS provider that returns TestFSes containing a provided set of files. -class MockFSProvider : public FileSystemProvider { +class MockFSProvider : public ThreadsafeFS { public:

[PATCH] D82024: [clangd] Rename FSProvider to TFS in case of ThreadsafeFS

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/unittests/ParsedASTTests.cpp:252 TEST(ParsedASTTest, CanBuildInvocationWithUnknownArgs) { MockFSProvider FSProvider;

[PATCH] D82024: [clangd] Rename FSProvider to TFS in case of ThreadsafeFS

sammccall added a comment. (I'm also happy to zap a few of these as a followup) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82024/new/ https://reviews.llvm.org/D82024 ___ cfe-commits mailing list

[PATCH] D82004: [clang-tidy][NFC] Remove the double look-up on IncludeInserter

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82004/new/ https://reviews.llvm.org/D82004

[PATCH] D82016: [clang-format] [PR462254] fix indentation of default and break correctly in whitesmiths style

curdeius accepted this revision. curdeius added a comment. Great! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82016/new/ https://reviews.llvm.org/D82016 ___ cfe-commits mailing list

[PATCH] D79167: [SVE][CodeGen] Legalisation of vsetcc with scalable types

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. Is it possible to write tests for this that don't result in a "max" or "min" operation? Or does that fail for some other reason? Otherwise LGTM. CHANGES SINCE LAST ACTION

[PATCH] D81736: [openmp] Base of tablegen generated OpenMP common declaration

jdenny added a comment. This patch looks like a good idea to me. Thanks. In D81736#2090419 , @clementval wrote: > @jdoerfert Some tests in clang relies on the position of the specific enum in > the declaration. TableGen is sorting the records so the

[PATCH] D75229: [clang-tidy] Add signal-in-multithreaded-program check

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/clang-tidy/cert/CERTTidyModule.cpp:88 // C checkers // CON Please use //check// here. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION

[clang] 2956cc5 - [Clang][Driver] Remove gold linker support for PS4 toolchain

Author: Yuanfang Chen Date: 2020-06-17T09:45:14-07:00 New Revision: 2956cc50f3405ae32c8c6d6e2c63fe8cb6456fa2 URL: https://github.com/llvm/llvm-project/commit/2956cc50f3405ae32c8c6d6e2c63fe8cb6456fa2 DIFF: https://github.com/llvm/llvm-project/commit/2956cc50f3405ae32c8c6d6e2c63fe8cb6456fa2.diff

[clang-tools-extra] 08c83ed - [clang-tidy][NFC] Remove the double look-up on IncludeInserter

Author: Nathan James Date: 2020-06-17T19:48:34+01:00 New Revision: 08c83ed75752169bdf27df8f5ea5978c53f2e258 URL: https://github.com/llvm/llvm-project/commit/08c83ed75752169bdf27df8f5ea5978c53f2e258 DIFF: https://github.com/llvm/llvm-project/commit/08c83ed75752169bdf27df8f5ea5978c53f2e258.diff

  1   2   3   >