[PATCH] D79755: Implement constexpr BinaryOperator for vector types

2020-06-18 Thread Simon Pilgrim via Phabricator via cfe-commits
RKSimon edited reviewers, added: efriedma; removed: eli.friedman. RKSimon added a comment. Any frontend people got any comments on this? I'm keen to see constexpr vector support added but know next to nothing about the frontend. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79755/new/

[clang] ada4c9d - [ARM][Clang] Removing lowering of half-precision FP arguments and returns from Clang's CodeGen

2020-06-18 Thread Lucas Prates via cfe-commits
Author: Lucas Prates Date: 2020-06-18T13:17:07+01:00 New Revision: ada4c9dc4a63160b6b3cfd5965884c6cce2a405c URL: https://github.com/llvm/llvm-project/commit/ada4c9dc4a63160b6b3cfd5965884c6cce2a405c DIFF: https://github.com/llvm/llvm-project/commit/ada4c9dc4a63160b6b3cfd5965884c6cce2a405c.diff

[clang] 92d8ad0 - [HIP] Fix rocm not found on rocm3.5

2020-06-18 Thread Yaxun Liu via cfe-commits
Author: Yaxun (Sam) Liu Date: 2020-06-18T08:40:09-04:00 New Revision: 92d8ad02e92fed3884169ba5d98056fe4fa5660d URL: https://github.com/llvm/llvm-project/commit/92d8ad02e92fed3884169ba5d98056fe4fa5660d DIFF:

[clang] d8c612b - Make matrix-type-builtins.m pass also on platforms where the type is 'unsigned long long'

2020-06-18 Thread Hans Wennborg via cfe-commits
Author: Hans Wennborg Date: 2020-06-18T14:06:55+02:00 New Revision: d8c612b7eabcc7ec399fad533d5beefa4ae08ac9 URL: https://github.com/llvm/llvm-project/commit/d8c612b7eabcc7ec399fad533d5beefa4ae08ac9 DIFF: https://github.com/llvm/llvm-project/commit/d8c612b7eabcc7ec399fad533d5beefa4ae08ac9.diff

[clang] eb4c758 - [Matrix] Pass darwin tripe to SeamObjc test to fix windows bot failure.

2020-06-18 Thread Florian Hahn via cfe-commits
Author: Florian Hahn Date: 2020-06-18T13:35:03+01:00 New Revision: eb4c758fe4b60ae3779d3e9401d00ee1450ae41b URL: https://github.com/llvm/llvm-project/commit/eb4c758fe4b60ae3779d3e9401d00ee1450ae41b DIFF: https://github.com/llvm/llvm-project/commit/eb4c758fe4b60ae3779d3e9401d00ee1450ae41b.diff

[PATCH] D72781: [Matrix] Add __builtin_matrix_column_load to Clang.

2020-06-18 Thread Florian Hahn via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG934bcaf10b57: [Matrix] Add __builtin_matrix_column_load to Clang. (authored by fhahn). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72781/new/

[PATCH] D81464: [SveEmitter] Add builtins to insert/extract subvectors from tuples (svget/svset)

2020-06-18 Thread Sander de Smalen via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG4ea8e27a642c: [SveEmitter] Add builtins to insert/extract subvectors from tuples (svget/svset) (authored by sdesmalen). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D74166: [AIX][Frontend] Static init implementation for AIX considering no priority

2020-06-18 Thread Xiangling Liao via Phabricator via cfe-commits
Xiangling_L updated this revision to Diff 271668. Xiangling_L added a comment. Fix the previous bad version; CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74166/new/ https://reviews.llvm.org/D74166 Files: clang/include/clang/AST/Mangle.h clang/lib/AST/ItaniumMangle.cpp

[PATCH] D81676: [MSP430] Align the toolchain definition with the TI's msp430-gcc v8.3.1

2020-06-18 Thread Anatoly Trosinenko via Phabricator via cfe-commits
atrosinenko updated this revision to Diff 271670. atrosinenko added a comment. Fix test once again (replace more literal slashes with regex). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81676/new/ https://reviews.llvm.org/D81676 Files:

[PATCH] D81304: [llvm][SveEmitter] Emit the bfloat version of `svld1ro`.

2020-06-18 Thread Ties Stuij via Phabricator via cfe-commits
stuij added inline comments. Comment at: clang/test/CodeGen/aarch64-sve-intrinsics/acle_sve_ld1ro-bfloat.c:1 +// RUN: %clang_cc1 -D__ARM_FEATURE_SVE_MATMUL_FP64 -D__ARM_FEATURE_BF16_SCALAR_ARITHMETIC -D__ARM_FEATURE_SVE -triple aarch64-none-linux-gnu -target-feature +sve

[PATCH] D82087: AMDGPU/clang: Add builtins for llvm.amdgcn.ballot

2020-06-18 Thread Matt Arsenault via Phabricator via cfe-commits
arsenm created this revision. arsenm added reviewers: yaxunl, rampitec, b-sumner, foad, nhaehnle. Herald added subscribers: kerbowa, t-tye, tpr, dstuttard, wdng, jvesely, kzhuravl. I wasn't sure what the best strategy was for the wave size difference. I went for an explicit, enforced builtin for

[PATCH] D82029: [Coroutines] Ensure co_await promise.final_suspend() does not throw

2020-06-18 Thread Brian Gesiak via Phabricator via cfe-commits
modocache added a reviewer: junparser. modocache added a subscriber: junparser. modocache added a comment. Excellent, thank you! The test failures on the diff appear to be legitimate, they reproduce for me when I apply this patch to my local checkout and run `ninja check-clang`. Could you take

[clang] 934bcaf - [Matrix] Add __builtin_matrix_column_load to Clang.

2020-06-18 Thread Florian Hahn via cfe-commits
Author: Florian Hahn Date: 2020-06-18T10:47:55+01:00 New Revision: 934bcaf10b57fc199d9b15722ea50f65a791ca4e URL: https://github.com/llvm/llvm-project/commit/934bcaf10b57fc199d9b15722ea50f65a791ca4e DIFF: https://github.com/llvm/llvm-project/commit/934bcaf10b57fc199d9b15722ea50f65a791ca4e.diff

[PATCH] D81678: Introduce partialinit attribute at call sites for stricter poison analysis

2020-06-18 Thread Evgenii Stepanov via Phabricator via cfe-commits
eugenis added a comment. In D81678#2099444 , @efriedma wrote: > So I guess we've discussed the following alternatives so far: > > 1. Attach the "frozen" attribute everywhere; this makes the textual IR > generated by clang messy, and likely bloats memory

[PATCH] D81678: Introduce partialinit attribute at call sites for stricter poison analysis

2020-06-18 Thread Gui Andrade via Phabricator via cfe-commits
guiand added a comment. Adding the function attribute turns out to have other challenges. Specifically, we don't want to have transforms remove a `frozen` from a parameter and then have to go through and update all the other parameters. This might happen if the function is marked with

[PATCH] D81886: [AMDGPU] Add gfx1030 target

2020-06-18 Thread Stanislav Mekhanoshin via Phabricator via cfe-commits
rampitec marked an inline comment as done. rampitec added inline comments. Comment at: llvm/docs/AMDGPUUsage.rst:266-267 names. + ``gfx1030`` ``amdgcn`` dGPU - xnack

[PATCH] D81678: Introduce partialinit attribute at call sites for stricter poison analysis

2020-06-18 Thread Eli Friedman via Phabricator via cfe-commits
efriedma added a comment. So I guess we've discussed the following alternatives so far: 1. Attach the "frozen" attribute everywhere; this makes the textual IR generated by clang messy, and likely bloats memory usage (not sure by how much). 2. Invert the meaning of the attribute; this makes

[PATCH] D75169: [ARM] Supporting lowering of half-precision FP arguments and returns in AArch32's backend

2020-06-18 Thread Lucas Prates via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGa255931c4055: [ARM] Supporting lowering of half-precision FP arguments and returns in… (authored by pratlucas). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D81428: [ARM] Moving CMSE handling of half arguments and return to the backend

2020-06-18 Thread Lucas Prates via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG92ad6d57c218: [ARM] Moving CMSE handling of half arguments and return to the backend (authored by pratlucas). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D81451: [ARM][Clang] Removing lowering of half-precision FP arguments and returns from Clang's CodeGen

2020-06-18 Thread Lucas Prates via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGada4c9dc4a63: [ARM][Clang] Removing lowering of half-precision FP arguments and returns from… (authored by pratlucas). Changed prior to commit: https://reviews.llvm.org/D81451?vs=269453=271677#toc

[PATCH] D81408: [builtins] Improve compatibility with 16 bit targets

2020-06-18 Thread Anatoly Trosinenko via Phabricator via cfe-commits
atrosinenko updated this revision to Diff 271671. atrosinenko added a comment. Rebase onto working upstream commit to (hopefully) make tests pass for my patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81408/new/

[PATCH] D80753: [clang-tidy] remove duplicate fixes of alias checkers

2020-06-18 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM aside from a few small nits, but please wait a bit for @njames93 in case they have final thoughts. Comment at:

[PATCH] D82086: [AST][RecoveryExpr] Fix a crash: don't attach error-type base specifiers.

2020-06-18 Thread Haojian Wu via Phabricator via cfe-commits
hokein created this revision. hokein added a reviewer: sammccall. Herald added a project: clang. hokein edited the summary of this revision. otherwise we'll run into code path which expects a good base specifiers, and lead to crashes. The crash only occurs in template instantiations (in

[PATCH] D81787: [clang] Fix the serialization of LambdaExpr and the bogus mutation in LambdaExpr::getBody

2020-06-18 Thread Bruno Ricci via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. riccibruno marked an inline comment as done. Closed by commit rG05843dc6ab97: [clang] Fix the serialization of LambdaExpr and the bogus mutation in… (authored by riccibruno). Changed prior to commit:

[PATCH] D81713: [HIP] Fix rocm not found on rocm3.5

2020-06-18 Thread Yaxun Liu via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG92d8ad02e92f: [HIP] Fix rocm not found on rocm3.5 (authored by yaxunl). Herald added a project: clang. Changed prior to commit: https://reviews.llvm.org/D81713?vs=270298=271689#toc Repository: rG

[PATCH] D81786: [clang][utils] Modify make-ast-dump-check.sh to generate AST serialization dump tests

2020-06-18 Thread Bruno Ricci via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGc7350a3bab14: [clang][utils] Modify make-ast-dump-check.sh to generate AST serialization dump… (authored by riccibruno). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D81407: [Analyzer][StreamChecker] Add note tags for file opening.

2020-06-18 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StreamChecker.cpp:406 +const ExplodedNode *StreamChecker::getAcquisitionSite(const ExplodedNode *N, + SymbolRef StreamSym, balazske

[PATCH] D72782: [Matrix] Add __builtin_matrix_column_store to Clang.

2020-06-18 Thread Florian Hahn via Phabricator via cfe-commits
fhahn updated this revision to Diff 271617. fhahn added a comment. Rebased after recent changes landed upstream. Will commit shortly Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72782/new/ https://reviews.llvm.org/D72782 Files:

[PATCH] D81946: [WIP][RISCV] Enable multilib support even without a detected GCC install

2020-06-18 Thread Simon Cook via Phabricator via cfe-commits
simoncook added a comment. Thanks for this Ed. I've tried building a toolchain with it and noticed a couple of things: 1. Printing the set of multilibs doesn't provide a default, I think that should still be defined and printed with `-print-multi-libs` 2. There's a slight path finding issue if

[PATCH] D81168: Add support for DeclRefExpr in SyntaxTree, by generating IdExpressions

2020-06-18 Thread Eduardo Caldas via Phabricator via cfe-commits
eduucaldas updated this revision to Diff 271620. eduucaldas marked 7 inline comments as done. eduucaldas added a comment. - cleanup for upstreaming - better coverage for unqualified-id - Better coverage for qualified-id - Finish implementing unqualified-id. Repository: rG LLVM Github Monorepo

[PATCH] D81168: Add support for DeclRefExpr in SyntaxTree, by generating IdExpressions

2020-06-18 Thread Eduardo Caldas via Phabricator via cfe-commits
eduucaldas marked an inline comment as not done. eduucaldas added inline comments. Comment at: clang/include/clang/Tooling/Syntax/Nodes.h:190 +return N->kind() == NodeKind::NameSpecifier; + } +}; gribozavr2 wrote: > Should there be getters for various parts

[clang] 4ea8e27 - [SveEmitter] Add builtins to insert/extract subvectors from tuples (svget/svset)

2020-06-18 Thread Sander de Smalen via cfe-commits
Author: Sander de Smalen Date: 2020-06-18T11:06:16+01:00 New Revision: 4ea8e27a642c6f97ca69cd39bbe44f7366870f6c URL: https://github.com/llvm/llvm-project/commit/4ea8e27a642c6f97ca69cd39bbe44f7366870f6c DIFF:

[clang] b5e082e - [Matrix] Add __builtin_matrix_column_store to Clang.

2020-06-18 Thread Florian Hahn via cfe-commits
Author: Florian Hahn Date: 2020-06-18T11:39:02+01:00 New Revision: b5e082e7289197bf82c9a28c6336b51d7999b419 URL: https://github.com/llvm/llvm-project/commit/b5e082e7289197bf82c9a28c6336b51d7999b419 DIFF: https://github.com/llvm/llvm-project/commit/b5e082e7289197bf82c9a28c6336b51d7999b419.diff

[PATCH] D82081: [z/OS] Add binary format goff and operating system zos to the triple

2020-06-18 Thread Kai Nacke via Phabricator via cfe-commits
Kai created this revision. Kai added reviewers: uweigand, yusra.syeda, kbarton, eli.friedman, MaskRay, hubert.reinterpretcast, cor3ntin, ldionne, tahonermann, simoll, kaz7, stuij. Herald added subscribers: llvm-commits, cfe-commits, dexonsmith, hiraditya. Herald added projects: clang, LLVM. Adds

[clang] 05843dc - [clang] Fix the serialization of LambdaExpr and the bogus mutation in LambdaExpr::getBody

2020-06-18 Thread Bruno Ricci via cfe-commits
Author: Bruno Ricci Date: 2020-06-18T13:37:24+01:00 New Revision: 05843dc6ab97a00cbde7aa4f08bf3692eb83109d URL: https://github.com/llvm/llvm-project/commit/05843dc6ab97a00cbde7aa4f08bf3692eb83109d DIFF: https://github.com/llvm/llvm-project/commit/05843dc6ab97a00cbde7aa4f08bf3692eb83109d.diff

[clang] c7350a3 - [clang][utils] Modify make-ast-dump-check.sh to generate AST serialization dump tests

2020-06-18 Thread Bruno Ricci via cfe-commits
Author: Bruno Ricci Date: 2020-06-18T13:37:29+01:00 New Revision: c7350a3bab14eb633f39a949f85ac0e690cd9b4d URL: https://github.com/llvm/llvm-project/commit/c7350a3bab14eb633f39a949f85ac0e690cd9b4d DIFF: https://github.com/llvm/llvm-project/commit/c7350a3bab14eb633f39a949f85ac0e690cd9b4d.diff

[clang] 403f953 - [CodeView] Add full repro to LF_BUILDINFO record

2020-06-18 Thread Alexandre Ganea via cfe-commits
Author: Alexandre Ganea Date: 2020-06-18T09:17:15-04:00 New Revision: 403f9537924b8910ed4f741ed96c61f5e657915b URL: https://github.com/llvm/llvm-project/commit/403f9537924b8910ed4f741ed96c61f5e657915b DIFF:

[clang] 108560e - Try to remove the acle_sve_adda.s file that's breaking tests

2020-06-18 Thread Hans Wennborg via cfe-commits
Author: Hans Wennborg Date: 2020-06-18T11:59:53+02:00 New Revision: 108560e58c41fc70341d763b941a0d6c24c4d3a9 URL: https://github.com/llvm/llvm-project/commit/108560e58c41fc70341d763b941a0d6c24c4d3a9 DIFF: https://github.com/llvm/llvm-project/commit/108560e58c41fc70341d763b941a0d6c24c4d3a9.diff

[PATCH] D78903: [Driver] Add option -fproc-stat-report

2020-06-18 Thread Serge Pavlov via Phabricator via cfe-commits
sepavloff updated this revision to Diff 271648. sepavloff added a comment. Updated patch according to reviewer's notes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78903/new/ https://reviews.llvm.org/D78903 Files: clang/docs/UsersManual.rst

[clang] 89ea0b0 - [MC] Pass down argv0 & cc1 cmd-line to the back-end and store in MCTargetOptions

2020-06-18 Thread Alexandre Ganea via cfe-commits
Author: Alexandre Ganea Date: 2020-06-18T09:17:14-04:00 New Revision: 89ea0b05207d45c145fb525df554b3b986ae379b URL: https://github.com/llvm/llvm-project/commit/89ea0b05207d45c145fb525df554b3b986ae379b DIFF:

[clang] a45409d - [Clang] Move clang::Job::printArg to llvm::sys::printArg. NFCI.

2020-06-18 Thread Alexandre Ganea via cfe-commits
Author: Alexandre Ganea Date: 2020-06-18T09:17:13-04:00 New Revision: a45409d8855a1e4538990507ef25e9b51c090193 URL: https://github.com/llvm/llvm-project/commit/a45409d8855a1e4538990507ef25e9b51c090193 DIFF:

[PATCH] D81168: Add support for DeclRefExpr in SyntaxTree, by generating IdExpressions

2020-06-18 Thread Eduardo Caldas via Phabricator via cfe-commits
eduucaldas updated this revision to Diff 271630. eduucaldas added a comment. Fix mistake on getting SourceRange for template-id Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81168/new/ https://reviews.llvm.org/D81168 Files:

[PATCH] D72782: [Matrix] Add __builtin_matrix_column_store to Clang.

2020-06-18 Thread Florian Hahn via Phabricator via cfe-commits
fhahn marked an inline comment as done. fhahn added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:10792 def err_builtin_matrix_pointer_arg: Error< - "%select{first|second}0 argument must be a pointer to a valid matrix element type">; + "%0

[PATCH] D81168: Add support for DeclRefExpr in SyntaxTree, by generating IdExpressions

2020-06-18 Thread Dmitri Gribenko via Phabricator via cfe-commits
gribozavr2 added inline comments. Comment at: clang/include/clang/Tooling/Syntax/Nodes.h:187 +/// A sequence of these specifiers make a `nested-name-specifier` +class NameSpecifier final : public Tree { Could you provide examples or a grammar quote in the

[PATCH] D72782: [Matrix] Add __builtin_matrix_column_store to Clang.

2020-06-18 Thread Florian Hahn via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGb5e082e72891: [Matrix] Add __builtin_matrix_column_store to Clang. (authored by fhahn). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72782/new/

[PATCH] D81304: [llvm][SveEmitter] Emit the bfloat version of `svld1ro`.

2020-06-18 Thread Sander de Smalen via Phabricator via cfe-commits
sdesmalen added inline comments. Comment at: clang/test/CodeGen/aarch64-sve-intrinsics/acle_sve_ld1ro-bfloat.c:1 +// RUN: %clang_cc1 -D__ARM_FEATURE_SVE_MATMUL_FP64 -D__ARM_FEATURE_BF16_SCALAR_ARITHMETIC -D__ARM_FEATURE_SVE -triple aarch64-none-linux-gnu -target-feature +sve

[PATCH] D81972: [NFC] Cleanup of EmitCXXGlobalInitFunc() and EmitCXXGlobalDtorFunc()

2020-06-18 Thread Xiangling Liao via Phabricator via cfe-commits
Xiangling_L updated this revision to Diff 271661. Xiangling_L marked 2 inline comments as done. Xiangling_L added a comment. Address comments; CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81972/new/ https://reviews.llvm.org/D81972 Files: clang/lib/CodeGen/CGDeclCXX.cpp Index:

[PATCH] D81003: [clang] SequenceChecker: Also visit default arguments and default initializers.

2020-06-18 Thread Bruno Ricci via Phabricator via cfe-commits
riccibruno updated this revision to Diff 271659. riccibruno added a comment. - Remove a left-over FIXME in the tests. - Use a `%select` in the diagnostic. - Pack `AdditionalSourceLocationData` into two `unsigned`s. - Simplify the chain walking code in `checkUsage`. - Mark the patch as needing

[PATCH] D81407: [Analyzer][StreamChecker] Add note tags for file opening.

2020-06-18 Thread Kristóf Umann via Phabricator via cfe-commits
Szelethus added a comment. Balázs, could you please add the checker option within this patch? If we find that the option works well (removes a lot of useless reports) I'd be happy to help implement that uniqueing pass. CmdLineOption, Comment at:

[PATCH] D74166: [AIX][Frontend] Static init implementation for AIX considering no priority

2020-06-18 Thread Xiangling Liao via Phabricator via cfe-commits
Xiangling_L updated this revision to Diff 271664. Xiangling_L marked an inline comment as done. Xiangling_L added a comment. Adjust the patch corresponding to D81972 ; CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74166/new/

[PATCH] D78903: [Driver] Add option -fproc-stat-report

2020-06-18 Thread Serge Pavlov via Phabricator via cfe-commits
sepavloff updated this revision to Diff 271665. sepavloff added a comment. Updated patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78903/new/ https://reviews.llvm.org/D78903 Files: clang/docs/UsersManual.rst

[PATCH] D79477: [clang-tidy] Add --use-color command line option and UseColor option to control colors in diagnostics

2020-06-18 Thread hyd-dev via Phabricator via cfe-commits
hyd-dev added a comment. **Ping?** CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79477/new/ https://reviews.llvm.org/D79477 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D82089: [clang-tidy] modernize-loop-convert reverse iteration support

2020-06-18 Thread Nathan James via Phabricator via cfe-commits
njames93 created this revision. njames93 added reviewers: alexfh, Eugene.Zelenko, angelgarcia, aaron.ballman, klimek. Herald added subscribers: cfe-commits, xazax.hun. Herald added a project: clang. Enables support for transforming loops of the form for (auto I = Cont.rbegin(), E =

[PATCH] D80833: [CodeView] Add full repro to LF_BUILDINFO record

2020-06-18 Thread Alexandre Ganea via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG403f9537924b: [CodeView] Add full repro to LF_BUILDINFO record (authored by aganea). Changed prior to commit: https://reviews.llvm.org/D80833?vs=268906=271698#toc Repository: rG LLVM Github Monorepo

[PATCH] D81599: [analyzer] SATest: Add 5 more projects for testing

2020-06-18 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ added a comment. Like in D81592 , we should take a look at enabling assertions. If this boils down to `-DCMAKE_BUILD_TYPE=Debug` then so be it(?) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81599/new/

[PATCH] D81571: [analyzer] SATest: Add initial docker infrastructure

2020-06-18 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ added inline comments. Comment at: clang/utils/analyzer/Dockerfile:15 +# test system dependencies +RUN apt-get update && apt-get install -y \ +git \ NoQ wrote: > Maybe put `apt-get update` on a separate line? > > Also i think you mentioned offline that

[PATCH] D81600: [analyzer] SATest: Fix package versions for test dependencies

2020-06-18 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Yes please! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81600/new/ https://reviews.llvm.org/D81600

[PATCH] D81601: [analyzer] SATest: Use logger in single-threaded mode as well

2020-06-18 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ added inline comments. Comment at: clang/utils/analyzer/SATestBuild.py:650 Logger = logging.getLogger(test_info.project.name) LOCAL.stdout = StreamToLogger(Logger, logging.INFO) Now that you have a global `Logger`, is this

[PATCH] D81596: [analyzer] SATest: Do not re-run CMake in Docker if not needed

2020-06-18 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Yeet! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81596/new/ https://reviews.llvm.org/D81596 ___

[PATCH] D81595: [analyzer] SATest: Make main script Python2 compatible

2020-06-18 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Woohoo! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81595/new/ https://reviews.llvm.org/D81595 ___

[PATCH] D81598: [analyzer] SATest: Add an easy option to connect to docker for debugging

2020-06-18 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ added inline comments. Comment at: clang/utils/analyzer/entrypoint.py:23 +while True: +sleep(3600) + I request comments (: Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81598/new/

[PATCH] D82092: [analyzer] Handle `\l` symbol in Windows specific file paths in exploded-graph-rewriter

2020-06-18 Thread Valeriy Savchenko via Phabricator via cfe-commits
vsavchenko added a comment. Even though it doesn't seem that necessary, I would still vote to comply with `clang-format` in tests as well. Other then that looks good to me! Additionally, I want to make a note that we are not really working hard on keeping all the scripts and the analyzer

[PATCH] D81592: [analyzer] SATest: Add a set of initial projects for testing

2020-06-18 Thread Valeriy Savchenko via Phabricator via cfe-commits
vsavchenko marked an inline comment as done. vsavchenko added inline comments. Comment at: clang/utils/analyzer/projects/box2d/run_static_analyzer.cmd:1 +cmake . -DCMAKE_BUILD_TYPE=Release -Bbuild -GNinja +cmake --build build NoQ wrote: > Is there a flag to

[PATCH] D79249: [NOT FOR REVIEW] Experimental support for zero-or-trap behavior foruninitialized variables.

2020-06-18 Thread Johannes Doerfert via Phabricator via cfe-commits
jdoerfert added a comment. FWIW, I tried to solve something similar the other day. My solution sketch looked like this: https://godbolt.org/z/bRQPjd The idea would be that we teach DSE (and others) to remove the `llvm.undef.init` intrinsic if the location is overwritten. In the example above

[PATCH] D81598: [analyzer] SATest: Add an easy option to connect to docker for debugging

2020-06-18 Thread Valeriy Savchenko via Phabricator via cfe-commits
vsavchenko marked an inline comment as done. vsavchenko added inline comments. Comment at: clang/utils/analyzer/entrypoint.py:23 +while True: +sleep(3600) + NoQ wrote: > I request comments (: Yeah, I guess it can be quite confusing when you read only

[PATCH] D80753: [clang-tidy] remove duplicate fixes of alias checkers

2020-06-18 Thread Nathan James via Phabricator via cfe-commits
njames93 accepted this revision. njames93 added a comment. LG, I have nothing else to add here. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80753/new/ https://reviews.llvm.org/D80753 ___ cfe-commits mailing list

[clang] b4c7a75 - Don't require shell in clang/test/CodeGen/aarch64-sve-intrinsics/acle_sve_adda.c

2020-06-18 Thread Hans Wennborg via cfe-commits
Author: Hans Wennborg Date: 2020-06-18T17:21:48+02:00 New Revision: b4c7a7542f482b4e1ac1d3936314fafd30b3b8db URL: https://github.com/llvm/llvm-project/commit/b4c7a7542f482b4e1ac1d3936314fafd30b3b8db DIFF: https://github.com/llvm/llvm-project/commit/b4c7a7542f482b4e1ac1d3936314fafd30b3b8db.diff

Re: [clang] eb4c758 - [Matrix] Pass darwin tripe to SeamObjc test to fix windows bot failure.

2020-06-18 Thread Hans Wennborg via cfe-commits
Thanks! I see it also fails on ARM (http://lab.llvm.org:8011/builders/clang-cmake-armv8-lld/builds/4438), so my sneaky change to fix the test (d8c612b7eabcc7ec399fad533d5beefa4ae08ac9) was not enough. On Thu, Jun 18, 2020 at 2:36 PM Florian Hahn via cfe-commits wrote: > > > Author: Florian Hahn

[PATCH] D82081: [z/OS] Add binary format goff and operating system zos to the triple

2020-06-18 Thread Tom Honermann via Phabricator via cfe-commits
tahonermann added a comment. @Kai, I'm afraid I won't be able to assist much in reviews of most z/OS related patches (due to lack of time and lack of expertise with various parts of z/OS), but please do copy me on anything related to source and execution character set encoding or conversions,

[PATCH] D81311: [RFC] LangRef: Define byref parameter attribute

2020-06-18 Thread Matt Arsenault via Phabricator via cfe-commits
arsenm updated this revision to Diff 271732. arsenm retitled this revision from "[RFC] LangRef: Define inmem parameter attribute" to "[RFC] LangRef: Define byref parameter attribute". arsenm added a comment. Rename to byref. Specify more explicitly this is for the ABI, and should not be

[libunwind] 2d865cc - unwind: EHABISectionIterator `operator!=`, constify `operator-`

2020-06-18 Thread Saleem Abdulrasool via cfe-commits
Author: Saleem Abdulrasool Date: 2020-06-18T08:54:34-07:00 New Revision: 2d865ccbd8c47fe94af04a6cffd02c45a24e2ffb URL: https://github.com/llvm/llvm-project/commit/2d865ccbd8c47fe94af04a6cffd02c45a24e2ffb DIFF:

[PATCH] D82086: [AST][RecoveryExpr] Fix a crash: don't attach error-type base specifiers.

2020-06-18 Thread Haojian Wu via Phabricator via cfe-commits
hokein marked an inline comment as done. hokein added inline comments. Comment at: clang/test/SemaCXX/invalid-template-base-specifier.cpp:6 +template +struct Crash : decltype(Foo(T())) { // expected-error {{no matching function for call to 'Foo'}} + Crash(){};

[PATCH] D81254: [analyzer] Produce symbolic values for C-array elements

2020-06-18 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ added a comment. Here are some examples: void test1(int *a, int index1, int index2) { int x = a[index1]; a[index2] = 0; int y = a[index1]; // In reality we don't know but after your patch // we're confident that this is "TRUE". clang_analyzer_eval(x == y); }

[PATCH] D82092: [analyzer] Handle `\l` symbol in Windows specific file paths in exploded-graph-rewriter

2020-06-18 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ added inline comments. Comment at: clang/utils/analyzer/exploded-graph-rewriter.py:383 +# when directory name starts with the letter `l`. +if sys.platform == 'win32': +# Find all `\l` (like `,\l`, `}\l`, `[\l`) except `\\l`,

[PATCH] D82092: [analyzer] Handle `\l` symbol in Windows specific file paths in exploded-graph-rewriter

2020-06-18 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ added a comment. Nice catch! Comment at: clang/utils/analyzer/exploded-graph-rewriter.py:383 +# when directory name starts with the letter `l`. +if sys.platform == 'win32': +# Find all `\l` (like `,\l`, `}\l`, `[\l`) except `\\l`,

[PATCH] D74166: [AIX][Frontend] Static init implementation for AIX considering no priority

2020-06-18 Thread Jason Liu via Phabricator via cfe-commits
jasonliu added inline comments. Comment at: clang/lib/CodeGen/CGDeclCXX.cpp:345 +// rarely. +Weights = nullptr; + } else if (Kind == GuardKind::VariableGuard && !D->isLocalVarDecl()) { Do we need to change/complicate the interface for this function,

[PATCH] D82092: [analyzer] Handle `\l` symbol in Windows specific file paths in exploded-graph-rewriter

2020-06-18 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ added a comment. In D82092#2100973 , @vsavchenko wrote: > Additionally, I want to make a note that we are not really working hard on > keeping all the scripts and the analyzer itself to be fully functional on > Windows. Yup. See also D76768

[clang-tools-extra] 850bb88 - [clang-tidy] RenamerClangTidy group redecls into 1 warning.

2020-06-18 Thread Nathan James via cfe-commits
Author: Nathan James Date: 2020-06-18T15:50:16+01:00 New Revision: 850bb889a56ccf3252792c6d3db59542e94753ae URL: https://github.com/llvm/llvm-project/commit/850bb889a56ccf3252792c6d3db59542e94753ae DIFF: https://github.com/llvm/llvm-project/commit/850bb889a56ccf3252792c6d3db59542e94753ae.diff

[PATCH] D80712: [SVE] Add checks for no warnings in SVE tests

2020-06-18 Thread Nico Weber via Phabricator via cfe-commits
thakis added inline comments. Comment at: clang/test/CodeGen/aarch64-sve-intrinsics/acle_sve_adda.c:3 // RUN: %clang_cc1 -D__ARM_FEATURE_SVE -DSVE_OVERLOADED_FORMS -triple aarch64-none-linux-gnu -target-feature +sve -fallow-half-arguments-and-returns -S -O1 -Werror -Wall

[PATCH] D82059: [clang-tidy] RenamerClangTidy group redecls into 1 warning.

2020-06-18 Thread Nathan James via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG850bb889a56c: [clang-tidy] RenamerClangTidy group redecls into 1 warning. (authored by njames93). Changed prior to commit: https://reviews.llvm.org/D82059?vs=271509=271722#toc Repository: rG LLVM

[PATCH] D82089: [clang-tidy] modernize-loop-convert reverse iteration support

2020-06-18 Thread Nathan James via Phabricator via cfe-commits
njames93 updated this revision to Diff 271723. njames93 marked 4 inline comments as done. njames93 added a comment. Address reviewer comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82089/new/ https://reviews.llvm.org/D82089 Files:

[PATCH] D81601: [analyzer] SATest: Use logger in single-threaded mode as well

2020-06-18 Thread Valeriy Savchenko via Phabricator via cfe-commits
vsavchenko marked an inline comment as done. vsavchenko added inline comments. Comment at: clang/utils/analyzer/SATestBuild.py:650 Logger = logging.getLogger(test_info.project.name) LOCAL.stdout = StreamToLogger(Logger, logging.INFO)

[PATCH] D79755: Implement constexpr BinaryOperator for vector types

2020-06-18 Thread Erich Keane via Phabricator via cfe-commits
erichkeane updated this revision to Diff 271713. erichkeane marked 9 inline comments as done. erichkeane added a comment. @AaronBallman's suggestions. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79755/new/ https://reviews.llvm.org/D79755 Files: clang/lib/AST/ExprConstant.cpp

[PATCH] D81571: [analyzer] SATest: Add initial docker infrastructure

2020-06-18 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ added inline comments. Comment at: clang/utils/analyzer/Dockerfile:10 + +# newer CMake is required by LLVM +RUN wget -O - https://apt.kitware.com/keys/kitware-archive-latest.asc 2>/dev/null | gpg --dearmor - | tee /etc/apt/trusted.gpg.d/kitware.gpg >/dev/null

[PATCH] D81592: [analyzer] SATest: Add a set of initial projects for testing

2020-06-18 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ added inline comments. Comment at: clang/utils/analyzer/.dockerignore:2 +./projects \ No newline at end of file NO NeWlINE At EnD oF fILE Comment at: clang/utils/analyzer/projects/box2d/run_static_analyzer.cmd:1 +cmake .

[PATCH] D81572: [analyzer] SATest: Add convenience 'docker' command

2020-06-18 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Yay! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81572/new/ https://reviews.llvm.org/D81572 ___

[PATCH] D79477: [clang-tidy] Add --use-color command line option and UseColor option to control colors in diagnostics

2020-06-18 Thread hyd-dev via Phabricator via cfe-commits
hyd-dev added a comment. I don't have commit access. @njames93 Could you please commit it for me (`hyd-dev `)? Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79477/new/ https://reviews.llvm.org/D79477 ___ cfe-commits mailing list

[PATCH] D82019: [OPENMP]Fix PR46357: Do not allow types declarations in pragmas.

2020-06-18 Thread Johannes Doerfert via Phabricator via cfe-commits
jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. I agree it is not a good idea. Let's hope no one will complain :) LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82019/new/

[PATCH] D82026: [OPENMP50]Allow nonmonotonic modifier for all schedule kinds.

2020-06-18 Thread Johannes Doerfert via Phabricator via cfe-commits
jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82026/new/ https://reviews.llvm.org/D82026

[PATCH] D81478: [OPENMP50]Codegen for scan directives in parallel for regions.

2020-06-18 Thread Johannes Doerfert via Phabricator via cfe-commits
jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LGTM and cleaner than my sketch, thanks a lot :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81478/new/ https://reviews.llvm.org/D81478

[PATCH] D78903: [Driver] Add option -fproc-stat-report

2020-06-18 Thread Alexandre Ganea via Phabricator via cfe-commits
aganea accepted this revision. aganea added a comment. This revision is now accepted and ready to land. Thanks again for the changes @sepavloff! Looks good to me! You might wait a bit before commiting, if there are further comments. Comment at: clang/lib/Driver/Driver.cpp:3806

[PATCH] D81593: [analyzer] SATest: Make docker interfaces transparent

2020-06-18 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Yay transparency. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81593/new/ https://reviews.llvm.org/D81593

[PATCH] D77658: [analyzer] StdLibraryFunctionsChecker: Add sanity checks for constraints

2020-06-18 Thread Gabor Marton via Phabricator via cfe-commits
martong added a comment. In D77658#2065174 , @MaskRay wrote: > `arc` adds many unneeded tags from Phabricator. You can drop `Reviewers:` > `Subscribers:` `Tags:` and the text `Summary:` with the following script: > > arcfilter () { > arc amend >

[PATCH] D79477: [clang-tidy] Add --use-color command line option and UseColor option to control colors in diagnostics

2020-06-18 Thread Nathan James via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGd9b8aada8288: [clang-tidy] Add --use-color command line option and UseColor option to control… (authored by hyd-dev, committed by njames93). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D81912: [AST] Dump containsErrors bit for the Type.

2020-06-18 Thread Haojian Wu via Phabricator via cfe-commits
hokein updated this revision to Diff 271733. hokein added a comment. address comment: emit the error-bit with color. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81912/new/ https://reviews.llvm.org/D81912 Files:

[PATCH] D27651: [clang-format] Even with AlignConsecutiveDeclarations, PointerAlignment: Right should keep *s and to the right

2020-06-18 Thread Mikhail Brusnikin via Phabricator via cfe-commits
ambroyz added a comment. topic, please, don't die CHANGES SINCE LAST ACTION https://reviews.llvm.org/D27651/new/ https://reviews.llvm.org/D27651 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D82103: [analyzer] Remove forbidden characters from a SourceLocation filename for a graph dump on Windows

2020-06-18 Thread Denys Petrov via Phabricator via cfe-commits
ASDenysPetrov created this revision. ASDenysPetrov added reviewers: Charusso, NoQ. ASDenysPetrov added a project: clang. Herald added subscribers: cfe-commits, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Windows forbidden file path characters

[PATCH] D82102: [AST][RecoveryExpr] Populate the error-bit from template arguments to TemplateSepcializationType.

2020-06-18 Thread Haojian Wu via Phabricator via cfe-commits
hokein created this revision. hokein added a reviewer: sammccall. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D82102 Files: clang/lib/AST/Type.cpp clang/test/SemaCXX/invalid-template-base-specifier.cpp Index:

[PATCH] D81972: [NFC] Cleanup of EmitCXXGlobalInitFunc() and EmitCXXGlobalDtorFunc()

2020-06-18 Thread Hubert Tong via Phabricator via cfe-commits
hubert.reinterpretcast accepted this revision. hubert.reinterpretcast added a comment. LGTM; thanks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81972/new/ https://reviews.llvm.org/D81972 ___ cfe-commits mailing list

[PATCH] D79755: Implement constexpr BinaryOperator for vector types

2020-06-18 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:2699 +RHSValue.getInt(), Result); + assert(LHSValue.getKind() == APValue::Float && "SHhuld be no other options"); + return

  1   2   3   >