[PATCH] D82141: [sve][acle] Add SVE BFloat16 extensions.

2020-06-19 Thread Sander de Smalen via Phabricator via cfe-commits
sdesmalen added inline comments. Comment at: clang/include/clang/Basic/arm_sve.td:494 +let ArchGuard = "defined(__ARM_FEATURE_SVE_BF16)" in { + def SVBFDOT : SInst<"svbfdot[_{0}]", "dd$$", "f", MergeNone, "aarch64_sve_bfdot">; + def SVBFMLALB : SInst<"svbfmlalb[_{0}]",

[PATCH] D82103: [analyzer] Remove forbidden characters from a SourceLocation filename for a graph dump on Windows

2020-06-19 Thread Denys Petrov via Phabricator via cfe-commits
ASDenysPetrov updated this revision to Diff 271971. ASDenysPetrov added a comment. Fixed clang-format. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82103/new/ https://reviews.llvm.org/D82103 Files: clang/include/clang/Basic/JsonSupport.h

[PATCH] D82092: [analyzer] Handle `\l` symbol in Windows specific file paths in exploded-graph-rewriter

2020-06-19 Thread Denys Petrov via Phabricator via cfe-commits
ASDenysPetrov updated this revision to Diff 271968. ASDenysPetrov added a comment. Fixed clang-format. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82092/new/ https://reviews.llvm.org/D82092 Files: clang/test/Analysis/exploded-graph-rewriter/l_directory_from_l/win_file_macros.cpp

[PATCH] D82169: Don't install clang-import-test

2020-06-19 Thread Alexander Richardson via Phabricator via cfe-commits
arichardson created this revision. arichardson added reviewers: spyffe, bruno, lhames, v.g.vassilev, loladiro. Herald added subscribers: cfe-commits, dexonsmith, mgorny. Herald added a project: clang. I have been trying to reduce the installed size of our CHERI toolchain and noticed that this

[PATCH] D82157: Fix crash on `user defined literals`

2020-06-19 Thread Eduardo Caldas via Phabricator via cfe-commits
eduucaldas created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Given an UserDefinedLiteral `1.2_w`: Problem: Lexer generates one Token for the literal, but ClangAST references two source locations Fix: Ignore the operator and interpret it as the

[PATCH] D82162: [clang-tidy] RenamerClangTidy wont emit fixes in scratch space

2020-06-19 Thread Nathan James via Phabricator via cfe-commits
njames93 created this revision. njames93 added reviewers: aaron.ballman, alexfh, gribozavr2. Herald added subscribers: cfe-commits, xazax.hun. Herald added a project: clang. Prevent fixes being displayed if usages are found in the scratch buffer. See Fix-It hints are being generated in the

[PATCH] D81404: [AArch64] Add clang command line support for -mharden-sls=

2020-06-19 Thread Kristof Beyls via Phabricator via cfe-commits
kristof.beyls marked 2 inline comments as done. kristof.beyls added inline comments. Comment at: clang/lib/Driver/ToolChains/Arch/AArch64.cpp:229 + Scope.split(Opts, ","); + for (int I = 0, E = Opts.size(); I != E; ++I) { +StringRef Opt = Opts[I].trim();

[PATCH] D81408: [builtins] Improve compatibility with 16 bit targets

2020-06-19 Thread Anatoly Trosinenko via Phabricator via cfe-commits
atrosinenko added a comment. Ping. Those flaky test failures seems to be due to `ld.lld` being not built from source as part of testing `compiler-rt/`-only patches. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81408/new/

[PATCH] D82157: Fix crash on `user defined literals`

2020-06-19 Thread Eduardo Caldas via Phabricator via cfe-commits
eduucaldas updated this revision to Diff 271980. eduucaldas added a comment. Why does this work? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82157/new/ https://reviews.llvm.org/D82157 Files: clang/lib/Tooling/Syntax/BuildTree.cpp

[PATCH] D81998: [clangd][NFC] Rename FSProvider and getFileSystem

2020-06-19 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet updated this revision to Diff 271979. kadircet marked 4 inline comments as done. kadircet added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81998/new/ https://reviews.llvm.org/D81998 Files:

[PATCH] D82092: [analyzer] Handle `\l` symbol in string literals in exploded-graph-rewriter

2020-06-19 Thread Denys Petrov via Phabricator via cfe-commits
ASDenysPetrov marked an inline comment as done. ASDenysPetrov added inline comments. Comment at: clang/utils/analyzer/exploded-graph-rewriter.py:432 .replace('|', '\\|') +s = re.sub(r'(?', s) if self._gray_mode: This makes the

[PATCH] D81975: [clangd] Add command line option for ClangTidyConfig

2020-06-19 Thread Nathan James via Phabricator via cfe-commits
njames93 updated this revision to Diff 272009. njames93 added a comment. Small rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81975/new/ https://reviews.llvm.org/D81975 Files: clang-tools-extra/clangd/test/clang-tidy-config.test

[PATCH] D82092: [analyzer] Handle `\l` symbol in string literals in exploded-graph-rewriter

2020-06-19 Thread Denys Petrov via Phabricator via cfe-commits
ASDenysPetrov updated this revision to Diff 272007. ASDenysPetrov added a comment. Expanded the patch for all platforms. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82092/new/ https://reviews.llvm.org/D82092 Files:

[PATCH] D82081: [z/OS] Add binary format goff and operating system zos to the triple

2020-06-19 Thread Kai Nacke via Phabricator via cfe-commits
Kai marked 4 inline comments as done. Kai added inline comments. Comment at: llvm/include/llvm/Support/TargetRegistry.h:518 +case Triple::GOFF: + report_fatal_error("GOFF MCObjectStreamer not implemented yet."); } hubert.reinterpretcast wrote: >

[PATCH] D82081: [z/OS] Add binary format goff and operating system zos to the triple

2020-06-19 Thread Kai Nacke via Phabricator via cfe-commits
Kai updated this revision to Diff 272010. Kai added a comment. - Relative order is now consistently GOFF before XCOFF - llvm_report_fatal() now follows guideline - Updated formatting CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82081/new/ https://reviews.llvm.org/D82081 Files:

[PATCH] D74166: [AIX][Frontend] Static init implementation for AIX considering no priority

2020-06-19 Thread Xiangling Liao via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Xiangling_L marked an inline comment as done. Closed by commit rG22337bfe7d87: [AIX][Frontend] Static init implementation for AIX considering no priority (authored by Xiangling_L). Changed prior to commit:

[PATCH] D82178: [AArch64][SVE] Guard svbfloat16_t with feature macro in ACLE

2020-06-19 Thread Sander de Smalen via Phabricator via cfe-commits
sdesmalen added inline comments. Comment at: clang/utils/TableGen/SveEmitter.cpp:1091 + OS << "#if defined(__ARM_FEATURE_SVE_BF16)\n"; + OS << "typedef __SVBFloat16_t svbfloat16_t;\n"; + OS << "#endif\n\n"; Can you also add an error if

[PATCH] D82089: [clang-tidy] modernize-loop-convert reverse iteration support

2020-06-19 Thread Nathan James via Phabricator via cfe-commits
njames93 updated this revision to Diff 272034. njames93 added a comment. Add documentation about the include style optione Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82089/new/ https://reviews.llvm.org/D82089 Files:

[PATCH] D81923: [clang-tidy] Add modernize-use-ranges check.

2020-06-19 Thread Nathan James via Phabricator via cfe-commits
njames93 updated this revision to Diff 272033. njames93 added a comment. - Updated Docs and set HandleReverseRanges default to false Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81923/new/ https://reviews.llvm.org/D81923 Files:

[PATCH] D82136: [AIX] Default AIX to using -fno-use-cxa-atexit

2020-06-19 Thread Xiangling Liao via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Xiangling_L marked 2 inline comments as done. Closed by commit rG3f2e61c1fe42: [AIX] Default AIX to using -fno-use-cxa-atexit (authored by Xiangling_L). Herald added a project: clang. Herald added a subscriber: cfe-commits.

[PATCH] D81949: [clang-tidy] Extend InheritParentConfig to CommandLineConfig

2020-06-19 Thread Nathan James via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG4836188ad9b3: [clang-tidy] Extend InheritParentConfig to CommandLineConfig (authored by njames93). Changed prior to commit: https://reviews.llvm.org/D81949?vs=271134=272004#toc Repository: rG LLVM

[clang] 22337bf - [AIX][Frontend] Static init implementation for AIX considering no priority

2020-06-19 Thread Xiangling Liao via cfe-commits
Author: Xiangling Liao Date: 2020-06-19T08:27:07-04:00 New Revision: 22337bfe7d87f9bf2b072ec7fe9165f7b9e2d793 URL: https://github.com/llvm/llvm-project/commit/22337bfe7d87f9bf2b072ec7fe9165f7b9e2d793 DIFF:

[PATCH] D82089: [clang-tidy] modernize-loop-convert reverse iteration support

2020-06-19 Thread Nathan James via Phabricator via cfe-commits
njames93 updated this revision to Diff 272030. njames93 added a comment. - Set and store the IncludeStyle Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82089/new/ https://reviews.llvm.org/D82089 Files:

[PATCH] D82178: [AArch64][SVE] Guard svbfloat16_t with feature macro in ACLE

2020-06-19 Thread Cullen Rhodes via Phabricator via cfe-commits
c-rhodes created this revision. c-rhodes added reviewers: sdesmalen, efriedma, stuij, fpetrogalli. Herald added subscribers: cfe-commits, danielkiss, psnobl, rkruppe, kristof.beyls, tschuett. Herald added a reviewer: rengolin. Herald added a project: clang. sdesmalen added inline comments.

[clang-tools-extra] d2fcc58 - [clangd] Drop usage of PreambleStatCache in scanPreamble

2020-06-19 Thread Kadir Cetinkaya via cfe-commits
Author: Kadir Cetinkaya Date: 2020-06-19T12:36:49+02:00 New Revision: d2fcc586223c522098df7a627e87a6a6c8381fbe URL: https://github.com/llvm/llvm-project/commit/d2fcc586223c522098df7a627e87a6a6c8381fbe DIFF:

[PATCH] D82024: [clangd] Rename FSProvider to TFS in case of ThreadsafeFS

2020-06-19 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet updated this revision to Diff 271988. kadircet added a comment. - Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82024/new/ https://reviews.llvm.org/D82024 Files: clang-tools-extra/clangd/ClangdLSPServer.cpp

[PATCH] D81998: [clangd][NFC] Rename FSProvider and getFileSystem

2020-06-19 Thread Sam McCall via Phabricator via cfe-commits
sammccall accepted this revision. sammccall added a comment. Thanks for this, and sympathies for inevitable merge conflicts. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81998/new/ https://reviews.llvm.org/D81998

[PATCH] D81719: [clangd] Drop usage of PreambleStatCache in scanPreamble

2020-06-19 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet updated this revision to Diff 271993. kadircet added a comment. - Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81719/new/ https://reviews.llvm.org/D81719 Files: clang-tools-extra/clangd/Preamble.cpp Index:

[clang-tools-extra] a3b7934 - [clangd] Don't mangle workdir-relevant driver path in compile commands

2020-06-19 Thread Sam McCall via cfe-commits
Author: Sam McCall Date: 2020-06-19T13:46:55+02:00 New Revision: a3b793401255cc91cbfaa5360e0940678bf86d1d URL: https://github.com/llvm/llvm-project/commit/a3b793401255cc91cbfaa5360e0940678bf86d1d DIFF: https://github.com/llvm/llvm-project/commit/a3b793401255cc91cbfaa5360e0940678bf86d1d.diff

[clang] bb48005 - [NFC] Make AST_BLOCK_HASH test more robust with downstream changes

2020-06-19 Thread Daniel Grumberg via cfe-commits
Author: Daniel Grumberg Date: 2020-06-19T09:41:15+01:00 New Revision: bb480056602daab86fbcd6aac5c6bc92ce350bb3 URL: https://github.com/llvm/llvm-project/commit/bb480056602daab86fbcd6aac5c6bc92ce350bb3 DIFF:

[PATCH] D81285: [builtins] Change si_int to int in some helper declarations

2020-06-19 Thread Anatoly Trosinenko via Phabricator via cfe-commits
atrosinenko updated this revision to Diff 271963. atrosinenko added a comment. Replaced `native_int` by plain `int`, as @aykevl suggested. On one hand, I have no specific preference for using some descriptive name such as `native_int`, `default_int`, etc. (that should suggest it was chosen

[PATCH] D81407: [Analyzer][StreamChecker] Add note tags for file opening.

2020-06-19 Thread Kristóf Umann via Phabricator via cfe-commits
Szelethus added a comment. I see where you're coming from @NoQ. What do you think, @balazske? I think there is is still value in this implementation as a //debug// option to gather data, so that we don't invest a lot of time creating a robust infrastructure for an idea that might not work out.

[PATCH] D81998: [clangd][NFC] Rename FSProvider and getFileSystem

2020-06-19 Thread Kadir Cetinkaya via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG0628705efaf7: [clangd][NFC] Rename FSProvider and getFileSystem (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81998/new/

[PATCH] D82024: [clangd] Rename FSProvider to TFS in case of ThreadsafeFS

2020-06-19 Thread Kadir Cetinkaya via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG8d654df5b982: [clangd] Rename FSProvider to TFS in case of ThreadsafeFS (authored by kadircet). Changed prior to commit: https://reviews.llvm.org/D82024?vs=271988=271996#toc Repository: rG LLVM

[PATCH] D81719: [clangd] Drop usage of PreambleStatCache in scanPreamble

2020-06-19 Thread Kadir Cetinkaya via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGd2fcc586223c: [clangd] Drop usage of PreambleStatCache in scanPreamble (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81719/new/

[PATCH] D81920: [clangd] Change FSProvider::getFileSystem to take CurrentWorkingDirectory

2020-06-19 Thread Kadir Cetinkaya via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG2dc2e47e3cb7: [clangd] Change FSProvider::getFileSystem to take CurrentWorkingDirectory (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang-tools-extra] 3bd7acf - [clangd] Use drop_front instead of consume_front to get rid of a redundant check

2020-06-19 Thread Kadir Cetinkaya via cfe-commits
Author: Kadir Cetinkaya Date: 2020-06-19T14:13:08+02:00 New Revision: 3bd7acf2e55801208700663d428ec37f694fb8a4 URL: https://github.com/llvm/llvm-project/commit/3bd7acf2e55801208700663d428ec37f694fb8a4 DIFF:

[PATCH] D82092: [analyzer] Handle `\l` symbol in Windows specific file paths in exploded-graph-rewriter

2020-06-19 Thread Denys Petrov via Phabricator via cfe-commits
ASDenysPetrov marked an inline comment as done. ASDenysPetrov added a comment. In D82092#2100973 , @vsavchenko wrote: > Even though it doesn't seem that necessary, I would still vote to comply with > `clang-format` in tests as well. Yes, I just forgot

[PATCH] D82011: [clangd] Don't mangle workdir-relevant driver path in compile commands

2020-06-19 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet added inline comments. Comment at: clang-tools-extra/clangd/CompileCommands.cpp:141 +// Let's hope it's not a symlink. +if (llvm::any_of(Driver, + [](char C) { return llvm::sys::path::is_separator(C); })) sammccall wrote: >

[clang] 3f2e61c - [AIX] Default AIX to using -fno-use-cxa-atexit

2020-06-19 Thread Xiangling Liao via cfe-commits
Author: Xiangling Liao Date: 2020-06-19T08:27:07-04:00 New Revision: 3f2e61c1fe42e5b790096d6962f6bc2de6ee00ce URL: https://github.com/llvm/llvm-project/commit/3f2e61c1fe42e5b790096d6962f6bc2de6ee00ce DIFF:

[clang] d3b7528 - [clang][test][NFC] Also test for serialization in AST dump tests, part 1/n.

2020-06-19 Thread Bruno Ricci via cfe-commits
Author: Bruno Ricci Date: 2020-06-19T13:40:20+01:00 New Revision: d3b752845df0331348dad48000fc8b82afb3de5b URL: https://github.com/llvm/llvm-project/commit/d3b752845df0331348dad48000fc8b82afb3de5b DIFF: https://github.com/llvm/llvm-project/commit/d3b752845df0331348dad48000fc8b82afb3de5b.diff

[clang] 70f952b - [clang][utils] Also match "col:" when looking for the end of builtins

2020-06-19 Thread Bruno Ricci via cfe-commits
Author: Bruno Ricci Date: 2020-06-19T13:40:20+01:00 New Revision: 70f952bebe38f8117e6ce8986cd39f735b7b3d69 URL: https://github.com/llvm/llvm-project/commit/70f952bebe38f8117e6ce8986cd39f735b7b3d69 DIFF: https://github.com/llvm/llvm-project/commit/70f952bebe38f8117e6ce8986cd39f735b7b3d69.diff

[clang-tools-extra] 4836188 - [clang-tidy] Extend InheritParentConfig to CommandLineConfig

2020-06-19 Thread Nathan James via cfe-commits
Author: Nathan James Date: 2020-06-19T12:02:19+01:00 New Revision: 4836188ad9b3334b0c1e055d45ccaa54ed797e4b URL: https://github.com/llvm/llvm-project/commit/4836188ad9b3334b0c1e055d45ccaa54ed797e4b DIFF: https://github.com/llvm/llvm-project/commit/4836188ad9b3334b0c1e055d45ccaa54ed797e4b.diff

[PATCH] D82081: [z/OS] Add binary format goff and operating system zos to the triple

2020-06-19 Thread Kai Nacke via Phabricator via cfe-commits
Kai updated this revision to Diff 272023. Kai added a comment. - In Triple.cpp: Keep list of binary formats sorted - In Triple.cpp: Use isOSzOS() for check CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82081/new/ https://reviews.llvm.org/D82081 Files:

[PATCH] D80981: [AST] Fix a crash on accessing a class without definition in constexpr function context.

2020-06-19 Thread Haojian Wu via Phabricator via cfe-commits
hokein updated this revision to Diff 272018. hokein marked an inline comment as done. hokein added a comment. Update per Richard's comment: do the error check in getDefaultInitValue, and modify every caller of it to support the error handling. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D81930: [AArch64] Add -mmark-bti-property flag.

2020-06-19 Thread Daniel Kiss via Phabricator via cfe-commits
danielkiss updated this revision to Diff 272024. danielkiss retitled this revision from "[AArch64] Add -mbti flag." to "[AArch64] Add -mmark-bti-property flag.". danielkiss edited the summary of this revision. danielkiss added a comment. Rename the flag to -mmark-bti-property CHANGES SINCE

[clang-tools-extra] c3b4486 - [NFC] Simplify IncludeInsertions appending to diagnostics

2020-06-19 Thread Nathan James via cfe-commits
Author: Nathan James Date: 2020-06-19T13:22:49+01:00 New Revision: c3b4486a57f6105bd5d96ec2e736f567aa4a0e35 URL: https://github.com/llvm/llvm-project/commit/c3b4486a57f6105bd5d96ec2e736f567aa4a0e35 DIFF: https://github.com/llvm/llvm-project/commit/c3b4486a57f6105bd5d96ec2e736f567aa4a0e35.diff

[PATCH] D80981: [AST] Fix a crash on accessing a class without definition in constexpr function context.

2020-06-19 Thread Haojian Wu via Phabricator via cfe-commits
hokein updated this revision to Diff 272019. hokein added a comment. cleanup the debug code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80981/new/ https://reviews.llvm.org/D80981 Files: clang/lib/AST/ExprConstant.cpp

[PATCH] D80981: [AST] Fix a crash on accessing a class without definition in constexpr function context.

2020-06-19 Thread Haojian Wu via Phabricator via cfe-commits
hokein added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:4320 +if (!RD->hasDefinition()) + return APValue(); APValue Struct(APValue::UninitStruct(), RD->getNumBases(), rsmith wrote: > hokein wrote: > > rsmith wrote: > > > hokein

[PATCH] D81285: [builtins] Change si_int to int in some helper declarations

2020-06-19 Thread Ayke via Phabricator via cfe-commits
aykevl added a comment. In D81285#2102948 , @atrosinenko wrote: > On renaming fixed width integer types to their traditional names: I would > prefer sending such patch afterwards, it would probably be as simple as just > running `sed --in-place` several

[clang-tools-extra] 0628705 - [clangd][NFC] Rename FSProvider and getFileSystem

2020-06-19 Thread Kadir Cetinkaya via cfe-commits
Author: Kadir Cetinkaya Date: 2020-06-19T12:12:03+02:00 New Revision: 0628705efaf7345c82887aeb61bb9bf1e06e5dd9 URL: https://github.com/llvm/llvm-project/commit/0628705efaf7345c82887aeb61bb9bf1e06e5dd9 DIFF:

[clang-tools-extra] 2dc2e47 - [clangd] Change FSProvider::getFileSystem to take CurrentWorkingDirectory

2020-06-19 Thread Kadir Cetinkaya via cfe-commits
Author: Kadir Cetinkaya Date: 2020-06-19T12:12:02+02:00 New Revision: 2dc2e47e3cb73d1adf40b42d0560af4d77e6e828 URL: https://github.com/llvm/llvm-project/commit/2dc2e47e3cb73d1adf40b42d0560af4d77e6e828 DIFF:

[clang-tools-extra] 8d654df - [clangd] Rename FSProvider to TFS in case of ThreadsafeFS

2020-06-19 Thread Kadir Cetinkaya via cfe-commits
Author: Kadir Cetinkaya Date: 2020-06-19T12:12:03+02:00 New Revision: 8d654df5b982c97f54aab75852b9150a2bff3634 URL: https://github.com/llvm/llvm-project/commit/8d654df5b982c97f54aab75852b9150a2bff3634 DIFF:

[PATCH] D81998: [clangd][NFC] Rename FSProvider and getFileSystem

2020-06-19 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet added inline comments. Comment at: clang-tools-extra/clangd/unittests/TestFS.h:36 public: - // Prevent name hiding caused by the overload below. - using FileSystemProvider::getFileSystem; - IntrusiveRefCntPtr getFileSystem() const { return buildTestFS(Files,

[PATCH] D82024: [clangd] Rename FSProvider to TFS in case of ThreadsafeFS

2020-06-19 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet updated this revision to Diff 271985. kadircet marked 2 inline comments as done. kadircet added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82024/new/ https://reviews.llvm.org/D82024 Files:

[PATCH] D81975: [clangd] Add command line option for ClangTidyConfig

2020-06-19 Thread Nathan James via Phabricator via cfe-commits
njames93 abandoned this revision. njames93 added a comment. Abandoned in favour of the proposed clangd-config . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81975/new/ https://reviews.llvm.org/D81975

[PATCH] D82011: [clangd] Don't mangle workdir-relevant driver path in compile commands

2020-06-19 Thread Sam McCall via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGa3b793401255: [clangd] Dont mangle workdir-relevant driver path in compile commands (authored by sammccall). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D82126: [libTooling] Change Transformer's `cat` to handle some cases of text in macros.

2020-06-19 Thread Yitzhak Mandelbaum via Phabricator via cfe-commits
ymandel added a comment. In D82126#2103772 , @tdl-g wrote: > LGTM. I found the change description confusing, since it talks about the > selection() stencil but the code is all about the cat() stencil. I realize > (now) that the former is deprecated in

[PATCH] D82029: [Coroutines] Ensure co_await promise.final_suspend() does not throw

2020-06-19 Thread Xun Li via Phabricator via cfe-commits
lxfind updated this revision to Diff 272109. lxfind added a comment. Addressed comments: Updated error message, and sorted notes. The tests are kept unchanged. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82029/new/

[PATCH] D79910: [x86][seses] Add clang flag; Use lvi-cfi with seses

2020-06-19 Thread Zola Bridges via Phabricator via cfe-commits
zbrid added inline comments. Comment at: llvm/lib/Target/X86/X86SpeculativeExecutionSideEffectSuppression.cpp:90 + const X86Subtarget = MF.getSubtarget(); + if (!Subtarget.useSpeculativeExecutionSideEffectSuppression() && +

[PATCH] D79910: [x86][seses] Add clang flag; Use lvi-cfi with seses

2020-06-19 Thread Zola Bridges via Phabricator via cfe-commits
zbrid updated this revision to Diff 272105. zbrid marked an inline comment as done. zbrid added a comment. Update Clang Command Ref with automated tool Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79910/new/ https://reviews.llvm.org/D79910

[PATCH] D82126: [libTooling] Change Transformer's `cat` to handle some cases of text in macros.

2020-06-19 Thread Yitzhak Mandelbaum via Phabricator via cfe-commits
ymandel added a comment. Tests show that this breaks the test for the clang tidy `abseil-string-find-str-contains`. Curious if this is a desirable change in behavior (in which case I'll update your test file) or the wrong behavior:

[PATCH] D82181: [clang-format] indent in chained conditionals when AlignOperands:DontAlign

2020-06-19 Thread Krasimir Georgiev via Phabricator via cfe-commits
krasimir created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. TODO Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D82181 Files: clang/lib/Format/ContinuationIndenter.cpp Index: clang/lib/Format/ContinuationIndenter.cpp

[PATCH] D80753: [clang-tidy] remove duplicate fixes of alias checkers

2020-06-19 Thread Daniel via Phabricator via cfe-commits
Daniel599 updated this revision to Diff 272052. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80753/new/ https://reviews.llvm.org/D80753 Files: clang-tools-extra/clang-tidy/ClangTidy.cpp clang-tools-extra/clang-tidy/ClangTidyDiagnosticConsumer.cpp

[PATCH] D80753: [clang-tidy] remove duplicate fixes of alias checkers

2020-06-19 Thread Daniel via Phabricator via cfe-commits
Daniel599 marked 3 inline comments as done. Daniel599 added a comment. I fixed all as your comments suggested, thanks :) If this patch is ready, can someone commit it on my behalf please? (I don't have write permissions) Thank you. CHANGES SINCE LAST ACTION

[PATCH] D82182: [AArch64][SVE] Add bfloat16 support to perm and select intrinsics

2020-06-19 Thread Cullen Rhodes via Phabricator via cfe-commits
c-rhodes created this revision. c-rhodes added reviewers: sdesmalen, efriedma, stuij, david-arm, fpetrogalli, kmclaughlin. Herald added subscribers: danielkiss, psnobl, rkruppe, hiraditya, kristof.beyls, tschuett. Herald added projects: clang, LLVM. Added for following intrinsics: - zip1,

[PATCH] D81385: Fix libdl linking for libclang in standalone mode

2020-06-19 Thread Michał Górny via Phabricator via cfe-commits
mgorny added a comment. Ping. It'd be nice to have this fixed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81385/new/ https://reviews.llvm.org/D81385 ___ cfe-commits mailing list

[PATCH] D80301: [yaml][clang-tidy] Fix new line YAML serialization

2020-06-19 Thread Dmitry Polukhin via Phabricator via cfe-commits
DmitryPolukhin added a comment. It looks like there is no support for the proposed solution so I found alternative solution that might be even better. We can use double quotation `"` for multiline strings. It solves problem because in case of double quotation LLVM escapes new line like `\n` so

[PATCH] D82187: [AArch64][SVE] ACLE: Add bfloat16 to struct load/stores.

2020-06-19 Thread Sander de Smalen via Phabricator via cfe-commits
sdesmalen marked 2 inline comments as done. sdesmalen added inline comments. Comment at: clang/include/clang/Basic/AArch64SVEACLETypes.def:69 -SVE_VECTOR_TYPE("__SVBFloat16_t", "__SVBFloat16_t", SveBFloat16, SveBFloat16Ty, 8, 16, false, false, true)

[PATCH] D81407: [Analyzer][StreamChecker] Add note tags for file opening.

2020-06-19 Thread Balázs Kéri via Phabricator via cfe-commits
balazske added a comment. So for this patch it would be OK to have the uniqueing location as it is now. A next large change can be to add the global resource leak report uniqueing feature, this changes anyway more existing checkers (including this one). (Still I want to finish other

[PATCH] D81736: [openmp] Base of tablegen generated OpenMP common declaration

2020-06-19 Thread Valentin Clement via Phabricator via cfe-commits
clementval added a comment. @jdoerfert @jdenny Should we wait until Monday to go ahead with this patch? I have several other patches that will follow this one. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81736/new/

[PATCH] D82186: [AArch64][SVE] Add bfloat16 support to svlen intrinsic

2020-06-19 Thread Cullen Rhodes via Phabricator via cfe-commits
c-rhodes added inline comments. Comment at: clang/test/CodeGen/aarch64-sve-intrinsics/acle_sve_len.c:2 // REQUIRES: aarch64-registered-target -// RUN: %clang_cc1 -D__ARM_FEATURE_SVE -triple aarch64-none-linux-gnu -target-feature +sve -fallow-half-arguments-and-returns -S -O1

[PATCH] D81736: [openmp] Base of tablegen generated OpenMP common declaration

2020-06-19 Thread Joel E. Denny via Phabricator via cfe-commits
jdenny accepted this revision. jdenny added a comment. This revision is now accepted and ready to land. In D81736#2103822 , @clementval wrote: > @jdoerfert @jdenny Should we wait until Monday to go ahead with this patch? I > have several other patches

[PATCH] D82182: [AArch64][SVE] Add bfloat16 support to perm and select intrinsics

2020-06-19 Thread David Sherwood via Phabricator via cfe-commits
david-arm accepted this revision. david-arm added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82182/new/ https://reviews.llvm.org/D82182

[PATCH] D82179: Move TestClangConfig into libClangTesting and use it in AST Matchers tests

2020-06-19 Thread Dmitri Gribenko via Phabricator via cfe-commits
gribozavr created this revision. Herald added subscribers: cfe-commits, sstefan1, jfb. Herald added a reviewer: jdoerfert. Herald added a project: clang. gribozavr2 added a reviewer: ymandel. gribozavr2 edited the summary of this revision. Previously, AST Matchers tests were using a custom way to

[PATCH] D78899: [Driver] Add callback to Command execution

2020-06-19 Thread Serge Pavlov via Phabricator via cfe-commits
sepavloff updated this revision to Diff 272047. sepavloff added a comment. Rebased patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78899/new/ https://reviews.llvm.org/D78899 Files: clang/include/clang/Driver/Compilation.h

[PATCH] D82178: [AArch64][SVE] Guard svbfloat16_t with feature macro in ACLE

2020-06-19 Thread Cullen Rhodes via Phabricator via cfe-commits
c-rhodes updated this revision to Diff 272043. c-rhodes added a comment. Changes: - Error if `__ARM_FEATURE_BF16_SCALAR_ARITHMETIC` not defined when defining `__ARM_FEATURE_SVE_BF16`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82178/new/ https://reviews.llvm.org/D82178 Files:

[PATCH] D81407: [Analyzer][StreamChecker] Add note tags for file opening.

2020-06-19 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ added a comment. In D81407#2102951 , @Szelethus wrote: > That could be helped additionally by creating a distinct `LeakBugReport`, > derived from `PathSensitiveBugReport`, that would take non-optional uniqueing > lambda to find the `ExplodedNode`

[PATCH] D82188: [clang-tidy] Reworked enum options handling(again)

2020-06-19 Thread Nathan James via Phabricator via cfe-commits
njames93 created this revision. njames93 added reviewers: aaron.ballman, alexfh, gribozavr2. Herald added subscribers: cfe-commits, arphaman, kbarton, xazax.hun, nemanjai. Herald added a project: clang. Following on from D77085 , I was never happy with the

[PATCH] D82186: [AArch64][SVE] Add bfloat16 support to svlen intrinsic

2020-06-19 Thread Cullen Rhodes via Phabricator via cfe-commits
c-rhodes created this revision. c-rhodes added reviewers: sdesmalen, efriedma, david-arm, fpetrogalli, stuij. Herald added subscribers: danielkiss, psnobl, rkruppe, kristof.beyls, tschuett. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D82186

[PATCH] D82178: [AArch64][SVE] Guard svbfloat16_t with feature macro in ACLE

2020-06-19 Thread Francesco Petrogalli via Phabricator via cfe-commits
fpetrogalli added inline comments. Comment at: clang/utils/TableGen/SveEmitter.cpp:1092 + OS << "#if !defined(__ARM_FEATURE_BF16_SCALAR_ARITHMETIC)\n"; + OS << "#error \"__ARM_FEATURE_BF16_SCALAR_ARITHMETIC must be defined when " +"__ARM_FEATURE_SVE_BF16 is

[PATCH] D82187: [AArch64][SVE] ACLE: Add bfloat16 to struct load/stores.

2020-06-19 Thread Sander de Smalen via Phabricator via cfe-commits
sdesmalen created this revision. sdesmalen added reviewers: stuij, efriedma, c-rhodes, fpetrogalli. Herald added subscribers: llvm-commits, lldb-commits, cfe-commits, danielkiss, psnobl, rkruppe, hiraditya, kristof.beyls, tschuett. Herald added projects: clang, LLDB, LLVM. sdesmalen added a

[PATCH] D82185: [Analyzer][WIP] Handle pointer implemented as iterators in iterator checkers

2020-06-19 Thread Balogh , Ádám via Phabricator via cfe-commits
baloghadamsoftware marked an inline comment as done. baloghadamsoftware added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/IteratorModeling.cpp:256 + SVal SubVal = State->getSVal(UO->getSubExpr(), C.getLocationContext()); + SVal Result = State->getSVal(UO,

[PATCH] D82185: [Analyzer][WIP] Handle pointer implemented as iterators in iterator checkers

2020-06-19 Thread Balogh , Ádám via Phabricator via cfe-commits
baloghadamsoftware created this revision. baloghadamsoftware added reviewers: NoQ, Szelethus, martong, gamesh411. baloghadamsoftware added a project: clang. Herald added subscribers: ASDenysPetrov, steakhal, Charusso, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, xazax.hun,

[PATCH] D81592: [analyzer] SATest: Add a set of initial projects for testing

2020-06-19 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ added inline comments. Comment at: clang/utils/analyzer/projects/box2d/run_static_analyzer.cmd:1 +cmake . -DCMAKE_BUILD_TYPE=Release -Bbuild -GNinja +cmake --build build vsavchenko wrote: > NoQ wrote: > > Is there a flag to enable assertions or something

[PATCH] D81601: [analyzer] SATest: Use logger in single-threaded mode as well

2020-06-19 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Aha ok nvm then! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81601/new/ https://reviews.llvm.org/D81601

[PATCH] D81571: [analyzer] SATest: Add initial docker infrastructure

2020-06-19 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Ok then! Comment at: clang/utils/analyzer/entrypoint.py:31 + +CMAKE_COMMAND = "cmake -G Ninja -DCMAKE_BUILD_TYPE=Release " \ +"-DCMAKE_INSTALL_PREFIX=/analyzer

[PATCH] D82092: [analyzer] Handle `\l` symbol in string literals in exploded-graph-rewriter

2020-06-19 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. I see what you did here! Great! Comment at: clang/test/Analysis/exploded-graph-rewriter/l_name_starts_with_l.cpp:25 + +// This test is passed if exploded_graph_rewriter handles

[PATCH] D82103: [analyzer] Remove forbidden characters from a SourceLocation filename for a graph dump on Windows

2020-06-19 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ added inline comments. Comment at: clang/utils/analyzer/exploded-graph-rewriter.py:383 +# when directory name starts with the letter `l`. +if sys.platform == 'win32': +# Find all `\l` (like `,\l`, `}\l`, `[\l`) except `\\l`,

[PATCH] D82081: [z/OS] Add binary format goff and operating system zos to the triple

2020-06-19 Thread Hubert Tong via Phabricator via cfe-commits
hubert.reinterpretcast accepted this revision. hubert.reinterpretcast added a comment. This revision is now accepted and ready to land. LGTM with minor nits. Comment at: llvm/lib/Bitcode/Writer/BitcodeWriter.cpp:4732 + case Triple::GOFF: +llvm_unreachable("GOFF is not yet

[PATCH] D82182: [AArch64][SVE] Add bfloat16 support to perm and select intrinsics

2020-06-19 Thread Francesco Petrogalli via Phabricator via cfe-commits
fpetrogalli added inline comments. Comment at: clang/include/clang/Basic/arm_sve.td:1115 +let ArchGuard = "defined(__ARM_FEATURE_SVE_BF16)" in { +def SVREV_BF16: SInst<"svrev[_{d}]","dd", "b", MergeNone, "aarch64_sve_rev">; nit: could create a

[PATCH] D82199: [clang-format] restore indent in conditionals AlignOperands is DontAlign

2020-06-19 Thread Krasimir Georgiev via Phabricator via cfe-commits
krasimir created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. krasimir edited the summary of this revision. After D50078 , we're experiencing unexpected un-indent using a style combining `AlignOperands: DontAlign` with

[PATCH] D67321: Respect CLANG_LINK_CLANG_DYLIB=ON in libclang and c-index-test

2020-06-19 Thread Michał Górny via Phabricator via cfe-commits
mgorny added a comment. Ping. The current state is that c-index-test crashes for us, and I'd like to see it fixed for 10.0.1. I have a patch of my own but it doesn't handle all that `_static` magic, so I guess this one's better. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D80025: [ASTMatcher] Correct memoization bug ignoring direction (descendants or ancestors)

2020-06-19 Thread Loïc Joly via Phabricator via cfe-commits
loic-joly-sonarsource added a comment. Can someone with write access merge this please? Thank you! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80025/new/ https://reviews.llvm.org/D80025 ___ cfe-commits mailing list

[PATCH] D82186: [AArch64][SVE] Add bfloat16 support to svlen intrinsic

2020-06-19 Thread Francesco Petrogalli via Phabricator via cfe-commits
fpetrogalli added inline comments. Comment at: clang/test/CodeGen/aarch64-sve-intrinsics/acle_sve_len.c:2 // REQUIRES: aarch64-registered-target -// RUN: %clang_cc1 -D__ARM_FEATURE_SVE -triple aarch64-none-linux-gnu -target-feature +sve -fallow-half-arguments-and-returns -S

[PATCH] D82181: [clang-format] indent in chained conditionals when AlignOperands:DontAlign

2020-06-19 Thread Krasimir Georgiev via Phabricator via cfe-commits
krasimir updated this revision to Diff 272084. krasimir added a comment. - add a regression test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82181/new/ https://reviews.llvm.org/D82181 Files: clang/unittests/Format/FormatTest.cpp Index:

[PATCH] D82187: [AArch64][SVE] ACLE: Add bfloat16 to struct load/stores.

2020-06-19 Thread Francesco Petrogalli via Phabricator via cfe-commits
fpetrogalli added inline comments. Comment at: clang/include/clang/Basic/AArch64SVEACLETypes.def:69 -SVE_VECTOR_TYPE("__SVBFloat16_t", "__SVBFloat16_t", SveBFloat16, SveBFloat16Ty, 8, 16, false, false, true) +SVE_VECTOR_TYPE("__SVBFloat16_t", "__SVBFloat16_t", SveBFloat16,

[PATCH] D82184: [MSP430] Update register names

2020-06-19 Thread Anatoly Trosinenko via Phabricator via cfe-commits
atrosinenko created this revision. atrosinenko added reviewers: echristo, rjmccall, krisb, mskvortsov, pftbest. Herald added a subscriber: hiraditya. Herald added projects: clang, LLVM. When writing a unit test on replacing standard epilogue sequences with `BR __mspabi_func_epilog_`, by manually

[PATCH] D82122: [analyzer][Liveness][RFC][NFC] Propose to turn statement liveness into expression liveness

2020-06-19 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ added a comment. I think you're right, this entire thing only makes sense for expressions. I think `Environment` occasionally carries values of `ReturnStmt`s (by which it means values of their sub-expressions) but even then liveness analysis doesn't need to be aware of that flex. > no lit

[PATCH] D82126: [libTooling] Change `selection` stencil to handle some cases of text in macros.

2020-06-19 Thread Tom Lokovic via Phabricator via cfe-commits
tdl-g added a comment. LGTM. I found the change description confusing, since it talks about the selection() stencil but the code is all about the cat() stencil. I realize (now) that the former is deprecated in favor of the latter. But the change description is still confusing. Repository:

  1   2   >