[PATCH] D82561: [analyzer][CrossTU] Lower CTUImportThreshold default value

2020-06-26 Thread Gabor Marton via Phabricator via cfe-commits
martong accepted this revision. martong added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/AnalyzerOptions.def:324 "for import when inlining functions during CTU analysis. " "Lowering this threshold can alleviate the

[PATCH] D82631: [AST][RecoveryAST] Avoid spurious 'missing typename' diagnostic when the NNS contains errors.

2020-06-26 Thread Haojian Wu via Phabricator via cfe-commits
hokein created this revision. hokein added a reviewer: sammccall. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D82631 Files: clang/include/clang/AST/NestedNameSpecifier.h clang/lib/AST/NestedNameSpecifier.cpp clang/lib/Sema/SemaDecl.cpp

[PATCH] D82629: [libclang] Fix crash when visiting a captured VLA.

2020-06-26 Thread Christian Kandeler via Phabricator via cfe-commits
ckandeler created this revision. ckandeler added a reviewer: milianw. Herald added subscribers: cfe-commits, arphaman. Herald added a project: clang. When a variable-length array is being captured in a lambda, the AST contains two captures, the first one having a null init expression. Visiting

[PATCH] D82373: [CodeComplete] Tweak code completion for `typename`.

2020-06-26 Thread Kadir Cetinkaya via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG834c71829cc2: [CodeComplete] Tweak code completion for `typename`. (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82373/new/

[clang] edcfef8 - [AArch64][SVE] Add bfloat16 support to store intrinsics

2020-06-26 Thread Kerry McLaughlin via cfe-commits
Author: Kerry McLaughlin Date: 2020-06-26T11:05:56+01:00 New Revision: edcfef8fee134cf98e0e812a6569c4900045d31c URL: https://github.com/llvm/llvm-project/commit/edcfef8fee134cf98e0e812a6569c4900045d31c DIFF:

[PATCH] D82617: Disable GCC's -Woverloaded-virtual, which has false positives.

2020-06-26 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. LGTM, thanks! This was also my final plan after investigating in https://reviews.llvm.org/D81920, but then I forgot ... Comment at: clang/CMakeLists.txt:398 + if

[PATCH] D82606: [clangd] Config: config struct propagated through Context

2020-06-26 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet added a comment. Thanks, LGTM. Just a question around the order of config vs other mangling. Comment at: clang-tools-extra/clangd/CompileCommands.cpp:187 + // FIXME: remove const_cast once unique_function is const-compatible. + for (auto :

[PATCH] D82561: [analyzer][CrossTU] Lower CTUImportThreshold default value

2020-06-26 Thread Balázs Kéri via Phabricator via cfe-commits
balazske added a comment. In D82561#2115578 , @xazax.hun wrote: > The analyzer inlines small functions within a TU regardless of the > thresholds. I think it would be sensible to do the same across TUs in the > case we don't do this already. That

[PATCH] D82626: [CodeComplete] Tweak completion for else.

2020-06-26 Thread Nathan James via Phabricator via cfe-commits
njames93 created this revision. njames93 added reviewers: sammccall, kadircet. Herald added a project: clang. Herald added a subscriber: cfe-commits. If an `if` statement uses braces for its `then` block, suggest braces for the `else` and `else if` completion blocks, Otherwise don't suggest

[PATCH] D82620: [clang-format] Preserve whitespace in selected macros

2020-06-26 Thread Marek Kurdej via Phabricator via cfe-commits
curdeius added inline comments. Comment at: clang/docs/ClangFormatStyleOptions.rst:2706 + + For example: STRINGIZE + Shouldn't there be a configuration example like what's in `ForEachMacros` doc? ``` In the .clang-format configuration file, this can be

[PATCH] D82598: [analyzer][Liveness][NFC] Get rid of statement liveness, because such a thing doesn't exist

2020-06-26 Thread Gábor Horváth via Phabricator via cfe-commits
xazax.hun added a comment. In D82598#2115656 , @NoQ wrote: > > We could just kill all subexpr at the end of the full expression > > I suspect that it would be pretty bad if you, say, kill the condition of the > `if`-statement before picking the branch.

[PATCH] D82535: [CodeComplete] Add code completion for using alias.

2020-06-26 Thread liu hui via Phabricator via cfe-commits
lh123 updated this revision to Diff 273631. lh123 added a comment. Rebase to head. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82535/new/ https://reviews.llvm.org/D82535 Files: clang/lib/Sema/SemaCodeComplete.cpp

[PATCH] D82561: [analyzer][CrossTU] Lower CTUImportThreshold default value

2020-06-26 Thread Gábor Horváth via Phabricator via cfe-commits
xazax.hun added a comment. In D82561#2116194 , @gamesh411 wrote: > In D82561#2116091 , @balazske wrote: > > > That means perform a get CTU definition if the TU to be imported (where the > > function comes from) is

[PATCH] D82470: [OpenMP][IRBuilder] Support nested parallel regions

2020-06-26 Thread Anchu Rajendran S via Phabricator via cfe-commits
anchu-rajendran added a comment. Herald added a subscriber: rogfer01. The change looks good to me. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82470/new/ https://reviews.llvm.org/D82470 ___

[PATCH] D82199: [clang-format] restore indent in conditionals when AlignOperands is DontAlign

2020-06-26 Thread Krasimir Georgiev via Phabricator via cfe-commits
krasimir marked an inline comment as done. krasimir added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:6287 + Style.BreakBeforeTernaryOperators = false; + verifyFormat("int x = aaa ? aa :\n" + "

[PATCH] D82636: Work around a bug in MSVC in the syntax tree test

2020-06-26 Thread Dmitri Gribenko via Phabricator via cfe-commits
gribozavr created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. gribozavr2 added reviewers: eduucaldas, vvereschaka. MSVC does not handle raw string literals with embedded double quotes correctly. I switched the affected test case to use regular string

[clang] ae47d15 - Remove "rm -f" workaround in acle_sve_adda.c

2020-06-26 Thread David Sherwood via cfe-commits
Author: David Sherwood Date: 2020-06-26T08:16:40+01:00 New Revision: ae47d158a096abad43d8f9056518d83b66c5a4b7 URL: https://github.com/llvm/llvm-project/commit/ae47d158a096abad43d8f9056518d83b66c5a4b7 DIFF:

[clang] 12665f2 - [X86] Make XSAVEC/XSAVEOPT/XSAVES properly depend on XSAVE in both the frontend and the backend.

2020-06-26 Thread Craig Topper via cfe-commits
Author: Craig Topper Date: 2020-06-26T00:14:58-07:00 New Revision: 12665f28129a7aefc635dc36d6fe0ad26583dd8a URL: https://github.com/llvm/llvm-project/commit/12665f28129a7aefc635dc36d6fe0ad26583dd8a DIFF: https://github.com/llvm/llvm-project/commit/12665f28129a7aefc635dc36d6fe0ad26583dd8a.diff

[PATCH] D82535: [CodeComplete] Add code completion for using alias.

2020-06-26 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet requested changes to this revision. kadircet added a comment. This revision now requires changes to proceed. this seems to be failing to merge, could you rebase on top of head? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82535/new/

[PATCH] D82345: [sve][acle] Implement some of the C intrinsics for brain float.

2020-06-26 Thread Cullen Rhodes via Phabricator via cfe-commits
c-rhodes added a comment. @fpetrogalli thanks for updating! I have a few more comments, sorry I missed a few things yesterday Comment at: clang/include/clang/Basic/arm_sve.td:725-727 + def NAME : SInst; + let ArchGuard = "defined(__ARM_FEATURE_SVE_BF16)" in { +def

[PATCH] D82578: [AArch64][SVE2] Guard while intrinsics on scalar bfloat feature macro

2020-06-26 Thread Sander de Smalen via Phabricator via cfe-commits
sdesmalen accepted this revision. sdesmalen added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82578/new/ https://reviews.llvm.org/D82578 ___ cfe-commits mailing list

[PATCH] D82312: Add `CharLiteral` to SyntaxTree

2020-06-26 Thread Dmitri Gribenko via Phabricator via cfe-commits
gribozavr2 added a comment. @vvereschaka Sorry about that. It looks like a bug in MSVC. I implemented a workaround in https://reviews.llvm.org/D82636 -- please review if you have time. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82312/new/

[PATCH] D82448: [AArch64][SVE] Add bfloat16 support to store intrinsics

2020-06-26 Thread Kerry McLaughlin via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGedcfef8fee13: [AArch64][SVE] Add bfloat16 support to store intrinsics (authored by kmclaughlin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82448/new/

[PATCH] D82606: [clangd] Config: config struct propagated through Context

2020-06-26 Thread Sam McCall via Phabricator via cfe-commits
sammccall marked an inline comment as done. sammccall added inline comments. Comment at: clang-tools-extra/clangd/CompileCommands.cpp:187 + // FIXME: remove const_cast once unique_function is const-compatible. + for (auto : const_cast(Config::current()).CompileFlags.Edits) +

[PATCH] D82313: [OpenCL] Reject block arguments

2020-06-26 Thread Anastasia Stulova via Phabricator via cfe-commits
Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82313/new/ https://reviews.llvm.org/D82313 ___ cfe-commits mailing

[PATCH] D82312: Add `CharLiteral` to SyntaxTree

2020-06-26 Thread Eduardo Caldas via Phabricator via cfe-commits
eduucaldas added a comment. In D82312#2116028 , @vvereschaka wrote: > Hello Eduardo, > > sorry, but one of your these commits break the clang unit tests on the > following builders: > > -

[PATCH] D79773: [clang-format] Improve clang-formats handling of concepts

2020-06-26 Thread Marek Kurdej via Phabricator via cfe-commits
curdeius added inline comments. Comment at: clang/include/clang/Format/Format.h:533 + /// If ``true``, always break before concept declarations + bool AlwaysBreakBeforeConceptDeclarations; It would be nice to have an example here in the doc.

[PATCH] D82501: [sve][acle] Add reinterpret intrinsics for brain float.

2020-06-26 Thread David Sherwood via Phabricator via cfe-commits
david-arm accepted this revision. david-arm added a comment. This revision is now accepted and ready to land. Can you remove the duplicate tests before submitting? Otherwise LGTM! Comment at: llvm/test/CodeGen/AArch64/sve-bitcast-bfloat.ll:8 + +define @bitcast_bfloat_to_i8(

[PATCH] D82497: [Clang][SourceManager] optimize getFileIDLocal()

2020-06-26 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet added a comment. For the record: http://llvm-compile-time-tracker.com/compare.php?from=ed8184b7814df4310dbad065a9a1c3bb8f3bfa86=408efffbe4a52bae05f1677a47eb3ccfd5cdc1d3=instructions https://photos.app.goo.gl/fJUS5jrMaJjvvmo1A Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D82498: [SourceManager] don't check invalid param of getLocalSLocEntry()

2020-06-26 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks, lgtm! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82498/new/ https://reviews.llvm.org/D82498

[clang-tools-extra] 1a30eab - Prevent unused error when assertions are disabled.

2020-06-26 Thread Tres Popp via cfe-commits
Author: Tres Popp Date: 2020-06-26T10:12:04+02:00 New Revision: 1a30eab413cefb18e733ef6aec42dc04a4a76592 URL: https://github.com/llvm/llvm-project/commit/1a30eab413cefb18e733ef6aec42dc04a4a76592 DIFF: https://github.com/llvm/llvm-project/commit/1a30eab413cefb18e733ef6aec42dc04a4a76592.diff

[PATCH] D71491: [ubsan] Check implicit casts in ObjC for-in statements

2020-06-26 Thread Akira Hatanaka via Phabricator via cfe-commits
ahatanak added inline comments. Comment at: clang/lib/CodeGen/CGObjC.cpp:1856 + Selector IsKindOfClassSel = C.Selectors.getSelector( + llvm::array_lengthof(IsKindOfClassII), [0]); + CallArgList IsKindOfClassArgs; Can you use `GetUnarySelector`

[clang] 834c718 - [CodeComplete] Tweak code completion for `typename`.

2020-06-26 Thread Kadir Cetinkaya via cfe-commits
Author: Kadir Cetinkaya Date: 2020-06-26T10:32:12+02:00 New Revision: 834c71829cc2e22841bf75e86b988c46252c70dc URL: https://github.com/llvm/llvm-project/commit/834c71829cc2e22841bf75e86b988c46252c70dc DIFF:

[PATCH] D82561: [analyzer][CrossTU] Lower CTUImportThreshold default value

2020-06-26 Thread Endre Fülöp via Phabricator via cfe-commits
gamesh411 added a comment. In D82561#2116091 , @balazske wrote: > In D82561#2115578 , @xazax.hun wrote: > > > The analyzer inlines small functions within a TU regardless of the > > thresholds. I think it would be

[PATCH] D81676: [MSP430] Align the toolchain definition with the TI's msp430-gcc v8.3.1

2020-06-26 Thread Anatoly Trosinenko via Phabricator via cfe-commits
atrosinenko added a comment. Meanwhile, msp430-gcc v9.2.0 was released on Jun 12. Will recheck against the new version slightly later. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D82317: [Clang/Test]: Update tests where `noundef` attribute is necessary

2020-06-26 Thread Gui Andrade via Phabricator via cfe-commits
guiand updated this revision to Diff 273570. guiand retitled this revision from "[Clang/Test]: Update tests where `frozen` attribute is necessary" to "[Clang/Test]: Update tests where `noundef` attribute is necessary". guiand edited the summary of this revision. guiand added a comment. Herald

[PATCH] D81678: Introduce noundef attribute at call sites for stricter poison analysis

2020-06-26 Thread Gui Andrade via Phabricator via cfe-commits
guiand marked an inline comment as done. guiand added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:2082 + const Type *RetTyPtr = RetTy.getTypePtr(); + if (!RetTy->isVoidType() && !RetTyPtr->isRecordType() && + RetAI.getKind() != ABIArgInfo::Indirect) {

[PATCH] D53891: [LTO] Add option to enable LTOUnit splitting, and disable unless needed

2020-06-26 Thread Hans Wennborg via Phabricator via cfe-commits
hans added a comment. Herald added a subscriber: hiraditya. Would be possible to add some documentation for this flag? From a quick search it's not clear to me what it does and when one is supposed to use it. Repository: rL LLVM CHANGES SINCE LAST ACTION

[PATCH] D82642: [clangd] Run formatting operations asynchronously.

2020-06-26 Thread Sam McCall via Phabricator via cfe-commits
sammccall created this revision. sammccall added a reviewer: kbobyrev. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. They don't need ASTs or anything, so they should still run immediately. These were sync

[PATCH] D82470: [OpenMP][IRBuilder] Support nested parallel regions

2020-06-26 Thread Sourabh Singh Tomar via Phabricator via cfe-commits
SouraVX added a comment. Overall this seems great Thanks! I have one minor concern: This patch seems to do 2 things: Support for nested parallel regions(which was crashing earlier) and some infrastructure change(introducing AllocBuilder..). I'm not sure of this, but is it possible to separate

[PATCH] D82623: [sve][acle] Enable feature macros for SVE ACLE extensions.

2020-06-26 Thread Sander de Smalen via Phabricator via cfe-commits
sdesmalen added a comment. Hi @fpetrogalli , I see the patch is still missing a few tests to `clang/test/Preprocessor/aarch64-target-features.c`. Not specifically to be done in this patch, but we'll also needs changes to make sure that the bfloat macros are set for armv8.6 (e.g.

[PATCH] D73187: [AST] Add fixed-point division constant evaluation.

2020-06-26 Thread Bevin Hansson via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG94e8ec631dda: [AST] Add fixed-point division constant evaluation. (authored by ebevhan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73187/new/

[PATCH] D73188: [AST] Improve overflow diagnostics for fixed-point constant evaluation.

2020-06-26 Thread Bevin Hansson via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG474177c05381: [AST] Improve overflow diagnostics for fixed-point constant evaluation. (authored by ebevhan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D73189: [AST] Fix certain consteval assignment and comma operator issues with fixed-point types.

2020-06-26 Thread Bevin Hansson via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGda2f852e1913: [AST] Fix certain consteval assignment and comma operator issues with fixed… (authored by ebevhan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D73186: [AST] Add fixed-point multiplication constant evaluation.

2020-06-26 Thread Bevin Hansson via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG53f5c8b4a14c: [AST] Add fixed-point multiplication constant evaluation. (authored by ebevhan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73186/new/

[PATCH] D73185: [AST] Add fixed-point subtraction constant evaluation.

2020-06-26 Thread Bevin Hansson via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGeccf7fc7b31a: [AST] Add fixed-point subtraction constant evaluation. (authored by ebevhan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73185/new/

[PATCH] D82362: Move default module cache from system temporary directory

2020-06-26 Thread David Zarzycki via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGbb26838ceffb: [clang driver] Move default module cache from system temporary directory (authored by davezarzycki). Changed prior to commit: https://reviews.llvm.org/D82362?vs=272655=273674#toc

[PATCH] D82646: [MSP430] Align the _Complex ABI with current msp430-gcc

2020-06-26 Thread Anatoly Trosinenko via Phabricator via cfe-commits
atrosinenko created this revision. atrosinenko added reviewers: krisb, awygle, pftbest. Herald added a project: clang. Assembler output is checked against msp430-gcc 9.2.0.50 from TI. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D82646 Files:

[PATCH] D81869: Modify FPFeatures to use delta not absolute settings to solve PCH compatibility problems

2020-06-26 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl added a comment. Would you please add the following lit test F12245277: diff.pch.txt If you change FastMath, FiniteMathOnly and UnsafeFPMath to COMPATIBLE_LANGOPT, the test should pass. Comment at:

[PATCH] D82650: [HIP] Set default FP_CONTRACT to ON

2020-06-26 Thread Daniil Fukalov via Phabricator via cfe-commits
dfukalov created this revision. dfukalov added reviewers: yaxunl, b-sumner, rampitec. Herald added subscribers: cfe-commits, Anastasia. Herald added a project: clang. With the FAST default FP_CONTRACT mode' setting for `func(float a, float b, float c) { return a + b * c; }` FE generates pair

[clang] bb26838 - [clang driver] Move default module cache from system temporary directory

2020-06-26 Thread David Zarzycki via cfe-commits
Author: David Zarzycki Date: 2020-06-26T07:46:03-04:00 New Revision: bb26838ceffb5feaa18186f55f7525a08084899e URL: https://github.com/llvm/llvm-project/commit/bb26838ceffb5feaa18186f55f7525a08084899e DIFF:

[clang] f0bab78 - Triple.h - reduce Twine.h include to forward declarations. NFC.

2020-06-26 Thread Simon Pilgrim via cfe-commits
Author: Simon Pilgrim Date: 2020-06-26T13:06:57+01:00 New Revision: f0bab7875e78e01c149d12302dcc4b6d4c43e25c URL: https://github.com/llvm/llvm-project/commit/f0bab7875e78e01c149d12302dcc4b6d4c43e25c DIFF: https://github.com/llvm/llvm-project/commit/f0bab7875e78e01c149d12302dcc4b6d4c43e25c.diff

[PATCH] D82391: [AArch64][SVE] Add bfloat16 support to svext intrinsic

2020-06-26 Thread Cullen Rhodes via Phabricator via cfe-commits
c-rhodes updated this revision to Diff 273685. c-rhodes added a comment. Changes: - Add tests for bfloat bitcast patterns. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82391/new/ https://reviews.llvm.org/D82391 Files: clang/include/clang/Basic/arm_sve.td

[PATCH] D82184: [MSP430] Update register names

2020-06-26 Thread Anton Korobeynikov via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGcb56fa2196c5: [MSP430] Update register names (authored by atrosinenko, committed by asl). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82184/new/

[PATCH] D81408: [builtins] Improve compatibility with 16 bit targets

2020-06-26 Thread Anton Korobeynikov via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGa4e8f7fe3f38: [builtins] Improve compatibility with 16 bit targets (authored by atrosinenko, committed by asl). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D81678: Introduce noundef attribute at call sites for stricter poison analysis

2020-06-26 Thread Gui Andrade via Phabricator via cfe-commits
guiand updated this revision to Diff 273558. guiand added a comment. Made DetermineNoUndef more robust Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81678/new/ https://reviews.llvm.org/D81678 Files: clang/include/clang/Basic/CodeGenOptions.def

[PATCH] D82578: [AArch64][SVE2] Guard while intrinsics on scalar bfloat feature macro

2020-06-26 Thread Cullen Rhodes via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGd45cf9105b5a: [AArch64][SVE2] Guard while intrinsics on scalar bfloat feature macro (authored by c-rhodes). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 474177c - [AST] Improve overflow diagnostics for fixed-point constant evaluation.

2020-06-26 Thread Bevin Hansson via cfe-commits
Author: Bevin Hansson Date: 2020-06-26T13:38:11+02:00 New Revision: 474177c05381a6eb2971e67753481b5efc78d848 URL: https://github.com/llvm/llvm-project/commit/474177c05381a6eb2971e67753481b5efc78d848 DIFF: https://github.com/llvm/llvm-project/commit/474177c05381a6eb2971e67753481b5efc78d848.diff

[clang] eccf7fc - [AST] Add fixed-point subtraction constant evaluation.

2020-06-26 Thread Bevin Hansson via cfe-commits
Author: Bevin Hansson Date: 2020-06-26T13:38:11+02:00 New Revision: eccf7fc7b31a00823a0fe6c782ef312b3ba743c4 URL: https://github.com/llvm/llvm-project/commit/eccf7fc7b31a00823a0fe6c782ef312b3ba743c4 DIFF: https://github.com/llvm/llvm-project/commit/eccf7fc7b31a00823a0fe6c782ef312b3ba743c4.diff

[clang] da2f852 - [AST] Fix certain consteval assignment and comma operator issues with fixed-point types.

2020-06-26 Thread Bevin Hansson via cfe-commits
Author: Bevin Hansson Date: 2020-06-26T13:38:11+02:00 New Revision: da2f852e1913a16a1c6940ce3d3e47158ae5ba0e URL: https://github.com/llvm/llvm-project/commit/da2f852e1913a16a1c6940ce3d3e47158ae5ba0e DIFF: https://github.com/llvm/llvm-project/commit/da2f852e1913a16a1c6940ce3d3e47158ae5ba0e.diff

[clang] 53f5c8b - [AST] Add fixed-point multiplication constant evaluation.

2020-06-26 Thread Bevin Hansson via cfe-commits
Author: Bevin Hansson Date: 2020-06-26T13:38:11+02:00 New Revision: 53f5c8b4a14c2ef89d44062a3a045be064bdc0e7 URL: https://github.com/llvm/llvm-project/commit/53f5c8b4a14c2ef89d44062a3a045be064bdc0e7 DIFF: https://github.com/llvm/llvm-project/commit/53f5c8b4a14c2ef89d44062a3a045be064bdc0e7.diff

[clang] 94e8ec6 - [AST] Add fixed-point division constant evaluation.

2020-06-26 Thread Bevin Hansson via cfe-commits
Author: Bevin Hansson Date: 2020-06-26T13:38:11+02:00 New Revision: 94e8ec631dda98639930c3fcf6b84148cd58cd59 URL: https://github.com/llvm/llvm-project/commit/94e8ec631dda98639930c3fcf6b84148cd58cd59 DIFF: https://github.com/llvm/llvm-project/commit/94e8ec631dda98639930c3fcf6b84148cd58cd59.diff

[clang] cb56fa2 - [MSP430] Update register names

2020-06-26 Thread Anton Korobeynikov via cfe-commits
Author: Anatoly Trosinenko Date: 2020-06-26T15:32:07+03:00 New Revision: cb56fa2196c5d80ce72e8e8f6ee2a7ac80acca77 URL: https://github.com/llvm/llvm-project/commit/cb56fa2196c5d80ce72e8e8f6ee2a7ac80acca77 DIFF:

[clang] d45cf91 - [AArch64][SVE2] Guard while intrinsics on scalar bfloat feature macro

2020-06-26 Thread Cullen Rhodes via cfe-commits
Author: Cullen Rhodes Date: 2020-06-26T10:25:42Z New Revision: d45cf9105b5a88ed03382ffbbfcd54b461f1bb23 URL: https://github.com/llvm/llvm-project/commit/d45cf9105b5a88ed03382ffbbfcd54b461f1bb23 DIFF: https://github.com/llvm/llvm-project/commit/d45cf9105b5a88ed03382ffbbfcd54b461f1bb23.diff

[PATCH] D70411: [analyzer] CERT STR rule checkers: STR31-C

2020-06-26 Thread Balogh , Ádám via Phabricator via cfe-commits
baloghadamsoftware added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Checkers/Checkers.td:859 + +def Str31cChecker : Checker<"31c">, + HelpText<"SEI CERT checker of rules defined in STR31-C">, Maybe we could have more descriptive names for

[PATCH] D70411: [analyzer] CERT STR rule checkers: STR31-C

2020-06-26 Thread Balogh , Ádám via Phabricator via cfe-commits
baloghadamsoftware added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/CMakeLists.txt:21 CastValueChecker.cpp + cert/StrChecker.cpp CheckObjCDealloc.cpp Are there so many things common among checkers for SEI CERT string rules that the

[PATCH] D80932: [SYCL] Make default address space a superset of OpenCL address spaces.

2020-06-26 Thread Alexey Bader via Phabricator via cfe-commits
bader added a comment. In D80932#2085848 , @Anastasia wrote: > In D80932#2083185 , @bader wrote: > > > In D80932#2080631 , @Anastasia > > wrote: > > > > > > @Anastasia, if

[PATCH] D81869: Modify FPFeatures to use delta not absolute settings to solve PCH compatibility problems

2020-06-26 Thread Melanie Blower via Phabricator via cfe-commits
mibintc added a comment. In D81869#2116752 , @yaxunl wrote: > Would you please add the following lit test > > F12245277: diff.pch.txt > > If you change FastMath, FiniteMathOnly and UnsafeFPMath to >

[PATCH] D80681: [clang][SourceManager] cache Macro Expansions

2020-06-26 Thread Nick Desaulniers via Phabricator via cfe-commits
nickdesaulniers added inline comments. Comment at: clang/lib/Basic/SourceManager.cpp:901 // across FileID lookups. if (!LocalSLocEntryTable[MiddleIndex].isExpansion()) LastFileIDLookup = Res; nickdesaulniers wrote: > oh, this case here

[PATCH] D82690: [clang][SourceManager] cache Macro Expansions pt.2

2020-06-26 Thread Nick Desaulniers via Phabricator via cfe-commits
nickdesaulniers created this revision. nickdesaulniers added a reviewer: kadircet. Herald added a project: clang. Herald added a subscriber: cfe-commits. nickdesaulniers added a comment. Alternatively, I could revert dffc1420451f674

[PATCH] D82690: [clang][SourceManager] cache Macro Expansions pt.2

2020-06-26 Thread Nick Desaulniers via Phabricator via cfe-commits
nickdesaulniers added a comment. Alternatively, I could revert dffc1420451f674 , and reland with this hunk? That way if a revert is necessary in the future, it's only one. Also so that before/after metrics are together and

[clang] 2b00cac - [darwin][driver] NFC, split addStartObjectFileArgs into multiple functions

2020-06-26 Thread Alex Lorenz via cfe-commits
Author: Alex Lorenz Date: 2020-06-26T17:15:37-07:00 New Revision: 2b00cacb2835d11cab6f71466604b7b1bdd46a8d URL: https://github.com/llvm/llvm-project/commit/2b00cacb2835d11cab6f71466604b7b1bdd46a8d DIFF: https://github.com/llvm/llvm-project/commit/2b00cacb2835d11cab6f71466604b7b1bdd46a8d.diff

[clang] 253988f - [darwin][driver] Do not link with libarclite when building for Apple Silicon macOS

2020-06-26 Thread Alex Lorenz via cfe-commits
Author: Alex Lorenz Date: 2020-06-26T17:15:37-07:00 New Revision: 253988f0f400201adb094d0f81d2c0c3fac94f4f URL: https://github.com/llvm/llvm-project/commit/253988f0f400201adb094d0f81d2c0c3fac94f4f DIFF: https://github.com/llvm/llvm-project/commit/253988f0f400201adb094d0f81d2c0c3fac94f4f.diff

[PATCH] D81672: [Driver] When forcing a crash print the bug report message

2020-06-26 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay accepted this revision. MaskRay added a comment. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81672/new/ https://reviews.llvm.org/D81672 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D82314: [Coroutines] Optimize the lifespan of temporary co_await object

2020-06-26 Thread Xun Li via Phabricator via cfe-commits
lxfind added a comment. In D82314#2117543 , @lewissbaker wrote: > > There are still room for improvements, in particular, GCC has a 4K frame > > for this function. > > I think GCC having a smaller coroutine frame is probably because it does not > yet

[PATCH] D82617: Disable GCC's -Woverloaded-virtual, which has false positives.

2020-06-26 Thread David Blaikie via Phabricator via cfe-commits
dblaikie added a comment. In D82617#2117441 , @sammccall wrote: > In D82617#2117086 , @Quuxplusone > wrote: > > > FWIW, I think the example you gave is **correct** for GCC to warn on. > > > Everything the warning

[clang] d298acd - [X86] Don't disable xsave when avx is disabled. Implicitly enable xsave with avx is enabled and xsave wasn't explciitly disabled

2020-06-26 Thread Craig Topper via cfe-commits
Author: Craig Topper Date: 2020-06-26T16:45:44-07:00 New Revision: d298acde828f4abc5e7c82ba1f6092890d910097 URL: https://github.com/llvm/llvm-project/commit/d298acde828f4abc5e7c82ba1f6092890d910097 DIFF: https://github.com/llvm/llvm-project/commit/d298acde828f4abc5e7c82ba1f6092890d910097.diff

[PATCH] D82694: [clang-shlib] Don't link with static clang libraries

2020-06-26 Thread Tom Stellard via Phabricator via cfe-commits
tstellar created this revision. tstellar added a reviewer: smeenai. Herald added subscribers: cfe-commits, mgorny. Herald added a project: clang. If we are building static libraries we don't need to link them into clang-shlib, since clang-shlib already has all the individual object files linked

[PATCH] D82617: Disable GCC's -Woverloaded-virtual, which has false positives.

2020-06-26 Thread David Blaikie via Phabricator via cfe-commits
dblaikie added a comment. In D82617#2118253 , @sammccall wrote: > In D82617#2118118 , @dblaikie wrote: > > > In D82617#2117441 , @sammccall > > wrote: > > > > > In

[PATCH] D82696: [darwin][driver] isMacosxVersionLT should check against the minimum supported OS version

2020-06-26 Thread Alex Lorenz via Phabricator via cfe-commits
arphaman created this revision. arphaman added reviewers: steven_wu, dexonsmith. Herald added subscribers: llvm-commits, ributzka, jkorous, hiraditya. Herald added a project: LLVM. This change ensures that the Darwin driver doesn't add unsupported libraries to the link invocation when linking

[PATCH] D81736: [openmp] Base of tablegen generated OpenMP common declaration

2020-06-26 Thread Valentin Clement via Phabricator via cfe-commits
clementval marked an inline comment as done. clementval added a comment. In D81736#2117858 , @thakis wrote: > This seems to cause build errors sometimes when buildling libclang. Maybe > there are more missing dependencies? Example failure: >

[PATCH] D82617: Disable GCC's -Woverloaded-virtual, which has false positives.

2020-06-26 Thread Sam McCall via Phabricator via cfe-commits
sammccall added a comment. In D82617#2118118 , @dblaikie wrote: > In D82617#2117441 , @sammccall wrote: > > > In D82617#2117086 , @Quuxplusone > > wrote: > > > > > FWIW, I

[PATCH] D82699: [driver][arm64] Set target CPU to A12 for compiler invocations that target Apple Silicon

2020-06-26 Thread Alex Lorenz via Phabricator via cfe-commits
arphaman added a comment. @t.p.northover @ab I noticed that the use of "apple-a12" doesn't infer the right target features when we're passing in a11 or older, so that's why my test file has the `INFER-A12` separate line. Do you think this is a bug? This is decided here: else if ((A =

[PATCH] D82699: [driver][arm64] Set target CPU to A12 for compiler invocations that target Apple Silicon

2020-06-26 Thread Alex Lorenz via Phabricator via cfe-commits
arphaman created this revision. arphaman added reviewers: ab, t.p.northover, dexonsmith. Herald added subscribers: llvm-commits, danielkiss, ributzka, jkorous, kristof.beyls. Herald added projects: clang, LLVM. arphaman added a comment. @t.p.northover @ab I noticed that the use of "apple-a12"

[clang-tools-extra] c19e82c - [Docs] Fix typo and test git commit access. NFC.

2020-06-26 Thread via cfe-commits
Author: lh123 Date: 2020-06-27T13:35:59+08:00 New Revision: c19e82c6b38b74c56d595cb69582b7c3727762b5 URL: https://github.com/llvm/llvm-project/commit/c19e82c6b38b74c56d595cb69582b7c3727762b5 DIFF: https://github.com/llvm/llvm-project/commit/c19e82c6b38b74c56d595cb69582b7c3727762b5.diff LOG:

[PATCH] D82677: [Clang] Handle AIX Include management in the driver

2020-06-26 Thread Hubert Tong via Phabricator via cfe-commits
hubert.reinterpretcast added a comment. Where are the test cases? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82677/new/ https://reviews.llvm.org/D82677 ___ cfe-commits mailing list

[PATCH] D82620: [clang-format] Preserve whitespace in selected macros

2020-06-26 Thread Marek Kurdej via Phabricator via cfe-commits
curdeius accepted this revision. curdeius added a comment. LGTM. Thank you for taking my comments into account. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82620/new/ https://reviews.llvm.org/D82620

[clang] 8cce7af - [SourceManager] don't check invalid param of getLocalSLocEntry()

2020-06-26 Thread Nick Desaulniers via cfe-commits
Author: Nick Desaulniers Date: 2020-06-26T10:22:26-07:00 New Revision: 8cce7af090bd011f6371dec34dfcab494cc74c46 URL: https://github.com/llvm/llvm-project/commit/8cce7af090bd011f6371dec34dfcab494cc74c46 DIFF:

[PATCH] D82501: [sve][acle] Add reinterpret intrinsics for brain float.

2020-06-26 Thread Francesco Petrogalli via Phabricator via cfe-commits
fpetrogalli added a comment. Ops, I accidentally removed the C tests... I'll revert, add the tests and recommit. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82501/new/ https://reviews.llvm.org/D82501

[PATCH] D82677: [Clang] Handle AIX Include management in the driver

2020-06-26 Thread Shuhong Liu via Phabricator via cfe-commits
ShuhongL updated this revision to Diff 273819. ShuhongL retitled this revision from "[AIX] Modify AIX customized clang driver toolchain to include AIX system headers in search path" to "[Clang] Handle AIX Include management in the driver". ShuhongL edited the summary of this revision.

[PATCH] D82617: Disable GCC's -Woverloaded-virtual, which has false positives.

2020-06-26 Thread Arthur O'Dwyer via Phabricator via cfe-commits
Quuxplusone added a comment. > what would be really useful is to clarify your position on whether the > warning in clang is delivering value I have no special information on that. Clearly someone thought it was adding value when they added it (way back in 2009;

[PATCH] D82431: [PowerPC][Power10] Implement Test LSB by Byte Builtins in LLVM/Clang

2020-06-26 Thread Lei Huang via Phabricator via cfe-commits
lei accepted this revision as: lei. lei added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82431/new/ https://reviews.llvm.org/D82431 ___ cfe-commits mailing list

[PATCH] D82345: [sve][acle] Implement some of the C intrinsics for brain float.

2020-06-26 Thread Francesco Petrogalli via Phabricator via cfe-commits
fpetrogalli marked an inline comment as done. fpetrogalli added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64SVEInstrInfo.td:426-427 + let Predicates = [HasSVE, HasBF16] in { +def : Pat<(nxv8bf16 (AArch64dup (bf16 FPR16:$src))), + (DUP_ZZI_H

[PATCH] D80681: [clang][SourceManager] cache Macro Expansions

2020-06-26 Thread Nick Desaulniers via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGdffc1420451f: [clang][SourceManager] cache Macro Expansions (authored by nickdesaulniers). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80681/new/

[PATCH] D82485: Add tests for sequences of callbacks that RecursiveASTVisitor produces

2020-06-26 Thread Dmitri Gribenko via Phabricator via cfe-commits
gribozavr2 added a comment. > Now, in all the test cases we are calling the default implementation. We are > not surfacing that WalkUpFrom can not walk up. I think we are. The log of callbacks called from the default implementation is indented to the right, so we clearly see what the default

[PATCH] D82485: Add tests for sequences of callbacks that RecursiveASTVisitor produces

2020-06-26 Thread Dmitri Gribenko via Phabricator via cfe-commits
gribozavr updated this revision to Diff 273835. gribozavr added a comment. Unified recordCallback and recordDefaultImplementation into one call. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82485/new/ https://reviews.llvm.org/D82485 Files:

[PATCH] D82663: [CodeGen] Have CodeGen for fixed-point unsigned with padding emit signed operations.

2020-06-26 Thread Bevin Hansson via Phabricator via cfe-commits
ebevhan updated this revision to Diff 273762. ebevhan added a comment. Fixed some broken CHECK lines. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82663/new/ https://reviews.llvm.org/D82663 Files: clang/include/clang/Basic/FixedPoint.h

[PATCH] D78655: [CUDA][HIP] Let non-caputuring lambda be host device

2020-06-26 Thread Michael Liao via Phabricator via cfe-commits
hliao added a comment. In D78655#2117216 , @pfultz2 wrote: > > Now, back to the specifics of your example. I'm still not 100% sure I > > understand what the problem is. Can you boil down the use case to an > > example on godbolt? > > I dont have a

[PATCH] D82665: [AArch64][SVE] Add bfloat16 to outstanding tuple vector intrinsics

2020-06-26 Thread Cullen Rhodes via Phabricator via cfe-commits
c-rhodes created this revision. c-rhodes added reviewers: sdesmalen, kmclaughlin, fpetrogalli. Herald added subscribers: danielkiss, psnobl, rkruppe, kristof.beyls, tschuett. Herald added a reviewer: efriedma. Herald added projects: clang, LLVM. - svget2/3/4 - svset2/3/4 - svcreate2/3/4 -

[PATCH] D82498: [SourceManager] don't check invalid param of getLocalSLocEntry()

2020-06-26 Thread Nick Desaulniers via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG8cce7af090bd: [SourceManager] dont check invalid param of getLocalSLocEntry() (authored by nickdesaulniers). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

  1   2   3   >