[PATCH] D81917: [clang-tidy] For `run-clang-tidy.py` escape the paths that are used for analysis.

2020-07-02 Thread Andi via Phabricator via cfe-commits
Abpostelnicu added a comment. In D81917#2127690 , @njames93 wrote: > In D81917#2127477 , @Abpostelnicu > wrote: > > > @njames93 wdyt if we add another parameter to distinguish if we want to use > > regex or not,

[PATCH] D82738: [clang] Fix a null-NSS-access crash in DependentNameType.

2020-07-02 Thread Sam McCall via Phabricator via cfe-commits
sammccall accepted this revision. sammccall added a subscriber: rsmith. sammccall added a comment. This revision is now accepted and ready to land. Yeah, I think you're right, and this small version of the patch seems good. > if the arg is a DeclRefExpr (no typo correction), we'll never into

[PATCH] D71199: [clang-tidy] New check cppcoreguidelines-prefer-member-initializer

2020-07-02 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/cppcoreguidelines-prefer-member-initializer-assignment.cpp:29 +public: + Simple2() : n (0) { +x = 0.0; baloghadamsoftware wrote: > aaron.ballman wrote: > >

[clang] 8c5133f - [clang] Fix a null-NSS-access crash in DependentNameType.

2020-07-02 Thread Haojian Wu via cfe-commits
Author: Haojian Wu Date: 2020-07-02T14:58:32+02:00 New Revision: 8c5133f1855767a16a6045777bed4652bd114d84 URL: https://github.com/llvm/llvm-project/commit/8c5133f1855767a16a6045777bed4652bd114d84 DIFF: https://github.com/llvm/llvm-project/commit/8c5133f1855767a16a6045777bed4652bd114d84.diff

[clang] 4cf24cb - [NFC][clang] Add missing VALIDATE_DIAG_SIZE()

2020-07-02 Thread via cfe-commits
Author: Whisperity Date: 2020-07-02T14:14:57+02:00 New Revision: 4cf24cb868b9fe9e65d2e4b27b8ec5fd5d5fb599 URL: https://github.com/llvm/llvm-project/commit/4cf24cb868b9fe9e65d2e4b27b8ec5fd5d5fb599 DIFF: https://github.com/llvm/llvm-project/commit/4cf24cb868b9fe9e65d2e4b27b8ec5fd5d5fb599.diff

[clang] db4d5f7 - [analyzer][StdLibraryFunctionsChecker] Add POSIX file handling functions

2020-07-02 Thread Gabor Marton via cfe-commits
Author: Gabor Marton Date: 2020-07-02T14:28:05+02:00 New Revision: db4d5f7048a26a7708821e46095742aecfd8ba46 URL: https://github.com/llvm/llvm-project/commit/db4d5f7048a26a7708821e46095742aecfd8ba46 DIFF: https://github.com/llvm/llvm-project/commit/db4d5f7048a26a7708821e46095742aecfd8ba46.diff

[PATCH] D81315: [analyzer] Warning for default constructed unique pointer dereferences

2020-07-02 Thread Nithin VR via Phabricator via cfe-commits
vrnithinkumar updated this revision to Diff 275076. vrnithinkumar marked 14 inline comments as done. vrnithinkumar added a comment. Herald added a subscriber: mgorny. - Created a new checker for smart point derference diagnostic - Moved checking part to this checker - Kept all the modeling in

[PATCH] D81315: [analyzer] Warning for default constructed unique pointer dereferences

2020-07-02 Thread Nithin VR via Phabricator via cfe-commits
vrnithinkumar marked 2 inline comments as done. vrnithinkumar added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Checkers/Checkers.td:574 -def SmartPtrModeling: Checker<"SmartPtr">, +def SmartPtrModeling: Checker<"SmartPtrModeling">, HelpText<"Model

[PATCH] D82288: [analyzer][StdLibraryFunctionsChecker] Add POSIX file handling functions

2020-07-02 Thread Gabor Marton via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGdb4d5f7048a2: [analyzer][StdLibraryFunctionsChecker] Add POSIX file handling functions (authored by martong). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D81315: [analyzer] Warning for default constructed unique pointer dereferences

2020-07-02 Thread Nithin VR via Phabricator via cfe-commits
vrnithinkumar added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Checkers/Checkers.td:577-583 + CheckerOptions<[ +CmdLineOption, + ]>, Szelethus wrote: > NoQ wrote: > > Szelethus wrote: > > > This goes against D81750 -- Sorry for not

[PATCH] D82944: [clangd] Switch FindSymbolsTests to use TestTU

2020-07-02 Thread Kadir Cetinkaya via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG37cc3ee8c555: [clangd] Switch FindSymbolsTests to use TestTU (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82944/new/

[PATCH] D81169: [clangd] Improve hover on arguments to function call

2020-07-02 Thread Adam Czachorowski via Phabricator via cfe-commits
adamcz updated this revision to Diff 275073. adamcz added a comment. Final review comment + rebase on top of HEAD Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81169/new/ https://reviews.llvm.org/D81169 Files: clang-tools-extra/clangd/Hover.cpp

[PATCH] D82948: [Driver][ARM] Disable unsupported features when nofp arch extension is used

2020-07-02 Thread Victor Campos via Phabricator via cfe-commits
vhscampos marked 2 inline comments as done. vhscampos added inline comments. Comment at: clang/lib/Driver/ToolChains/Arch/ARM.cpp:292-297 + auto checkFPDisabledInArchName = [](const StringRef ) { +SmallVector Split; +ArchName.split(Split, '+', -1, false); +return

[PATCH] D81678: Introduce noundef attribute at call sites for stricter poison analysis

2020-07-02 Thread Gui Andrade via Phabricator via cfe-commits
guiand updated this revision to Diff 274895. guiand added a comment. Addressed comments, added test for indirect calls Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81678/new/ https://reviews.llvm.org/D81678 Files:

[PATCH] D83009: [clang][Serialization] Don't duplicate the body of LambdaExpr during deserialization

2020-07-02 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83009/new/ https://reviews.llvm.org/D83009 ___ cfe-commits mailing list

[PATCH] D82930: [HIP] Fix rocm detection

2020-07-02 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl marked an inline comment as done. yaxunl added inline comments. Comment at: clang/lib/Driver/ToolChains/AMDGPU.cpp:167 +llvm::ErrorOr> VersionFile = +FS.getBufferForFile(BinPath + "/.hipVersion"); +if (!VersionFile) arsenm wrote: > arsenm

[PATCH] D81456: [clangd] Get rid of WantDiagnostics::Yes

2020-07-02 Thread Sam McCall via Phabricator via cfe-commits
sammccall added inline comments. Comment at: clang-tools-extra/clangd/ClangdLSPServer.cpp:670 auto Version = DraftMgr.addDraft(File, Params.textDocument.version, Contents); - Server->addDocument(File, Contents, encodeVersion(Version), -

[PATCH] D82921: Removed a RecursiveASTVisitor feature to visit operator kinds with different methods

2020-07-02 Thread Dmitri Gribenko via Phabricator via cfe-commits
gribozavr updated this revision to Diff 275064. gribozavr added a comment. Added release notes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82921/new/ https://reviews.llvm.org/D82921 Files:

[PATCH] D82436: [clangd] Implement textDocument/foldingRange

2020-07-02 Thread Sam McCall via Phabricator via cfe-commits
sammccall added a comment. I think this looks reasonable, but I'd like to make sure we have a plan going forward otherwise the behavior/assumptions tend to calcify. I think RAV and adding other region types are clear, but maybe we should discuss lines/filtering behavior offline a bit.

[PATCH] D79279: Add overloaded versions of builtin mem* functions

2020-07-02 Thread Erich Keane via Phabricator via cfe-commits
erichkeane added a comment. I just took a look at SemaChecking, the rest I'm not sure I get the intent of the patch sufficiently to understand. Comment at: clang/lib/Sema/SemaChecking.cpp:1442 + enum class MemCheckType { Full, Basic }; + Oh boy... all

[PATCH] D82738: [clang] Fix a null-NSS-access crash in DependentNameType.

2020-07-02 Thread Haojian Wu via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. hokein marked an inline comment as done. Closed by commit rG8c5133f18557: [clang] Fix a null-NSS-access crash in DependentNameType. (authored by hokein). Changed prior to commit:

[clang] f51a319 - [ASTMatchers] Enhanced support for matchers taking Regex arguments

2020-07-02 Thread Nathan James via cfe-commits
Author: Nathan James Date: 2020-07-02T14:52:25+01:00 New Revision: f51a319cacd44819b4fb9fa9f005c2445bcee984 URL: https://github.com/llvm/llvm-project/commit/f51a319cacd44819b4fb9fa9f005c2445bcee984 DIFF: https://github.com/llvm/llvm-project/commit/f51a319cacd44819b4fb9fa9f005c2445bcee984.diff

[PATCH] D81169: [clangd] Improve hover on arguments to function call

2020-07-02 Thread Adam Czachorowski via Phabricator via cfe-commits
adamcz updated this revision to Diff 275104. adamcz marked an inline comment as done. adamcz added a comment. removed some more {} Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81169/new/ https://reviews.llvm.org/D81169 Files:

[PATCH] D80911: AArch64+ARM: make LLVM consider system registers volatile to prevent unsound optimizations.

2020-07-02 Thread Johannes Doerfert via Phabricator via cfe-commits
jdoerfert added a comment. As an alternative, and necessary regardless, we need to teach AA that "no-`nosync`" operations can experience the effects of external things. As long as `llvm.read_register` is not marked `nosync` that should prevent hoisting. Should, because AA doesn't know this

[PATCH] D83048: [LiveDebugValues] 3/4 Add Xclang and CodeGen options for using instr-ref variable locations

2020-07-02 Thread Jeremy Morse via Phabricator via cfe-commits
jmorse created this revision. jmorse added reviewers: aprantl, vsk, probinson, Orlando, StephenTozer, TWeaver, djtodoro. Herald added subscribers: llvm-commits, cfe-commits, hiraditya. Herald added projects: clang, LLVM. jmorse added a parent revision: D83047: [LiveDebugValues] 2/4 Add

[PATCH] D80525: [clangd] Fix crash-bug in preamble indexing when using modules.

2020-07-02 Thread Sam McCall via Phabricator via cfe-commits
sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/unittests/SymbolCollectorTests.cpp:1509 +TEST_F(SymbolCollectorTest, UndefOfModuleMacro) { + auto TU =

[PATCH] D82502: [PowerPC][Power10] Implement Load VSX Vector and Sign Extend and Zero Extend

2020-07-02 Thread Albion Fung via Phabricator via cfe-commits
Conanap marked 2 inline comments as done. Conanap added a comment. Addressed Anil's comments with regards to the test cases Comment at: llvm/test/CodeGen/PowerPC/p10-vsx-builtins.ll:56 + +; CHECK: lxvrdx +; Function Attrs: norecurse nounwind readonly anil9

[PATCH] D83053: [clang-tidy] OptionsView::store specialized on bool

2020-07-02 Thread Nathan James via Phabricator via cfe-commits
njames93 created this revision. njames93 added reviewers: aaron.ballman, alexfh, gribozavr2. Herald added subscribers: cfe-commits, arphaman, kbarton, xazax.hun, nemanjai. Herald added a project: clang. njames93 marked an inline comment as done. njames93 added inline comments. Herald added a

[clang-tools-extra] 37cc3ee - [clangd] Switch FindSymbolsTests to use TestTU

2020-07-02 Thread Kadir Cetinkaya via cfe-commits
Author: Kadir Cetinkaya Date: 2020-07-02T14:25:45+02:00 New Revision: 37cc3ee8c5553ec02c133e80e9ac98f5ffa525d1 URL: https://github.com/llvm/llvm-project/commit/37cc3ee8c5553ec02c133e80e9ac98f5ffa525d1 DIFF:

[PATCH] D83006: [ASTImporter] Add unittest case for friend decl import

2020-07-02 Thread Gabor Marton via Phabricator via cfe-commits
martong accepted this revision. martong added a comment. This revision is now accepted and ready to land. Thanks, looks good! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83006/new/ https://reviews.llvm.org/D83006

[PATCH] D82677: [Clang] Handle AIX Include management in the driver

2020-07-02 Thread Shuhong Liu via Phabricator via cfe-commits
ShuhongL updated this revision to Diff 275111. ShuhongL marked 2 inline comments as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82677/new/ https://reviews.llvm.org/D82677 Files: clang/lib/Driver/ToolChains/AIX.cpp

[PATCH] D83006: [ASTImporter] Add unittest case for friend decl import

2020-07-02 Thread Vince Bridgers via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG59f1bf46f8c2: [ASTImporter] Add unittest case for friend decl import (authored by vabridgers, committed by einvbri vince.a.bridg...@ericsson.com). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D81456: [clangd] Get rid of WantDiagnostics::Yes

2020-07-02 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet planned changes to this revision. kadircet marked an inline comment as done. kadircet added inline comments. Comment at: clang-tools-extra/clangd/ClangdLSPServer.cpp:670 auto Version = DraftMgr.addDraft(File, Params.textDocument.version, Contents); -

[PATCH] D82880: Fix PR35677: UB on __int128_t or __uint128_t template parameters.

2020-07-02 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added inline comments. Comment at: clang/lib/AST/StmtPrinter.cpp:1159 + case BuiltinType::UInt128: +OS << "Ui128"; +break; riccibruno wrote: > riccibruno wrote: > > davidstone wrote: > > > riccibruno wrote: > > > > `i128` and `Ui128` are

[PATCH] D82944: [clangd] Switch FindSymbolsTests to use TestTU

2020-07-02 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet updated this revision to Diff 275069. kadircet marked an inline comment as done. kadircet added a comment. - Get rid of the fixtures Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82944/new/ https://reviews.llvm.org/D82944 Files:

[PATCH] D82706: [ASTMatchers] Enhanced support for matchers taking Regex arguments

2020-07-02 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82706/new/ https://reviews.llvm.org/D82706

[PATCH] D81315: [analyzer] Warning for default constructed unique pointer dereferences

2020-07-02 Thread Kristóf Umann via Phabricator via cfe-commits
Szelethus added a comment. I only looked at the checker naming issue, and that seems to have been resolved perfectly, thanks! :) Comment at: clang/include/clang/StaticAnalyzer/Checkers/Checkers.td:582 + "false", + InAlpha>, + ]>,

[PATCH] D82706: [ASTMatchers] Enhanced support for matchers taking Regex arguments

2020-07-02 Thread Nathan James via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. njames93 marked an inline comment as done. Closed by commit rGf51a319cacd4: [ASTMatchers] Enhanced support for matchers taking Regex arguments (authored by njames93). Repository: rG LLVM Github Monorepo CHANGES SINCE

[clang] 59f1bf4 - [ASTImporter] Add unittest case for friend decl import

2020-07-02 Thread via cfe-commits
Author: Vince Bridgers Date: 2020-07-02T09:26:34-05:00 New Revision: 59f1bf46f8c258b9c784ff921b89fb6cb7a06612 URL: https://github.com/llvm/llvm-project/commit/59f1bf46f8c258b9c784ff921b89fb6cb7a06612 DIFF:

[PATCH] D77062: [analyzer] Improved zero assumption in CStringChecke::assumeZero

2020-07-02 Thread Denys Petrov via Phabricator via cfe-commits
ASDenysPetrov added a comment. @NoQ , just one another ping, since it is near to be closed. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77062/new/ https://reviews.llvm.org/D77062 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D80911: AArch64+ARM: make LLVM consider system registers volatile to prevent unsound optimizations.

2020-07-02 Thread Florian Hahn via Phabricator via cfe-commits
fhahn added reviewers: fhahn, efriedma, hfinkel. fhahn added a comment. This seems similar to the problem described in https://bugs.llvm.org/show_bug.cgi?id=46210 : for intrinsics that are marked as reading memory, we do not account for the fact that the memory could be modified outside of the

[PATCH] D81917: [clang-tidy] For `run-clang-tidy.py` escape the paths that are used for analysis.

2020-07-02 Thread Nathan James via Phabricator via cfe-commits
njames93 added a comment. In D81917#2127477 , @Abpostelnicu wrote: > @njames93 wdyt if we add another parameter to distinguish if we want to use > regex or not, and if not we escape the paths? > Also thank you so much for catching this up! As the

[clang] e4d178a - [clang][Serialization] Don't duplicate the body of LambdaExpr during deserialization

2020-07-02 Thread Bruno Ricci via cfe-commits
Author: Bruno Ricci Date: 2020-07-02T14:13:35+01:00 New Revision: e4d178a75253f0ab8d2b9085087208aa8296 URL: https://github.com/llvm/llvm-project/commit/e4d178a75253f0ab8d2b9085087208aa8296 DIFF: https://github.com/llvm/llvm-project/commit/e4d178a75253f0ab8d2b9085087208aa8296.diff

[PATCH] D83009: [clang][Serialization] Don't duplicate the body of LambdaExpr during deserialization

2020-07-02 Thread Bruno Ricci via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGe4d178a75244: [clang][Serialization] Dont duplicate the body of LambdaExpr during… (authored by riccibruno). Changed prior to commit: https://reviews.llvm.org/D83009?vs=274951=275093#toc Repository:

[PATCH] D83053: [clang-tidy] OptionsView::store specialized on bool

2020-07-02 Thread Nathan James via Phabricator via cfe-commits
njames93 marked an inline comment as done. njames93 added inline comments. Herald added a subscriber: wuzish. Comment at: clang-tools-extra/clang-tidy/cppcoreguidelines/ProBoundsConstantArrayIndexCheck.cpp:31 Options.store(Opts, "GslHeader", GslHeader); -

[PATCH] D82085: [TRE] allow TRE for non-capturing calls.

2020-07-02 Thread Alexey Lapshin via Phabricator via cfe-commits
avl updated this revision to Diff 275123. avl added a comment. rebased. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82085/new/ https://reviews.llvm.org/D82085 Files: llvm/lib/Transforms/Scalar/TailRecursionElimination.cpp

[PATCH] D79719: [AIX] Implement AIX special alignment rule about double/long double

2020-07-02 Thread Xiangling Liao via Phabricator via cfe-commits
Xiangling_L marked an inline comment as done. Xiangling_L added inline comments. Comment at: clang/test/Layout/aix-double-struct-member.cpp:1 +// RUN: %clang_cc1 -emit-llvm-only -triple powerpc-ibm-aix-xcoff \ +// RUN: -fdump-record-layouts -fsyntax-only %s 2>/dev/null | \

[PATCH] D83048: [LiveDebugValues] 3/4 Add Xclang and CodeGen options for using instr-ref variable locations

2020-07-02 Thread Djordje Todorovic via Phabricator via cfe-commits
djtodoro added a comment. Please add a test case for the Driver option (you can take a look into existing ones within `clang/test/Driver/`). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83048/new/ https://reviews.llvm.org/D83048

[PATCH] D82502: [PowerPC][Power10] Implement Load VSX Vector and Sign Extend and Zero Extend

2020-07-02 Thread Albion Fung via Phabricator via cfe-commits
Conanap added a comment. Addressed Lei's comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82502/new/ https://reviews.llvm.org/D82502 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D82502: [PowerPC][Power10] Implement Load VSX Vector and Sign Extend and Zero Extend

2020-07-02 Thread Albion Fung via Phabricator via cfe-commits
Conanap updated this revision to Diff 275124. Conanap marked 4 inline comments as done. Conanap added a comment. Fixed some formatting stuff. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82502/new/ https://reviews.llvm.org/D82502 Files:

[PATCH] D78478: [UpdateTestChecks] Add UTC_ARGS support for update_{llc,cc}_test_checks.py

2020-07-02 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay added subscribers: xbolva00, greened, spatel, lebedev.ri. MaskRay added a comment. The idea look good to me, but I want some opinions on the name `UTC_ARGS` (I can't help associating it with Coordinated Universal Time). Adding some folks who may have opinions: @greened @lebedev.ri

[PATCH] D83061: [OpenMP] Implement TR8 `present` map type modifier in Clang (1/2)

2020-07-02 Thread Joel E. Denny via Phabricator via cfe-commits
jdenny created this revision. jdenny added reviewers: ABataev, jdoerfert, hfinkel, Meinersbur, kkwli0, grokos, sfantao, gtbercea. Herald added subscribers: cfe-commits, sstefan1, guansong, yaxunl. Herald added a project: clang. jdenny added a parent revision: D83057: [OpenMP][NFC] Remove

[PATCH] D83013: [LPM] Port CGProfilePass from NPM to LPM

2020-07-02 Thread Zequan Wu via Phabricator via cfe-commits
zequanwu updated this revision to Diff 275160. zequanwu marked 7 inline comments as done. zequanwu added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D83013: [LPM] Port CGProfilePass from NPM to LPM

2020-07-02 Thread Zequan Wu via Phabricator via cfe-commits
zequanwu updated this revision to Diff 275161. zequanwu added a comment. update. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83013/new/ https://reviews.llvm.org/D83013 Files: clang/lib/CodeGen/BackendUtil.cpp

[PATCH] D79719: [AIX] Implement AIX special alignment rule about double/long double

2020-07-02 Thread Hubert Tong via Phabricator via cfe-commits
hubert.reinterpretcast added inline comments. Comment at: clang/test/Layout/aix-double-struct-member.cpp:1 +// RUN: %clang_cc1 -emit-llvm-only -triple powerpc-ibm-aix-xcoff \ +// RUN: -fdump-record-layouts -fsyntax-only %s 2>/dev/null | \ Xiangling_L wrote:

[PATCH] D82999: [CodeGen] Check the cleanup flag before destructing temporaries created in conditional expressions

2020-07-02 Thread John McCall via Phabricator via cfe-commits
rjmccall added a comment. Please adjust the commit message to be clear that this is about lifetime-extended temporaries; it's not like we got this wrong for all temporaries. Do we need to do anything to ensure that the after-full-expression cleanup is configured conditionally? Repository:

[PATCH] D78478: [UpdateTestChecks] Add UTC_ARGS support for update_{llc,cc}_test_checks.py

2020-07-02 Thread Dávid Bolvanský via Phabricator via cfe-commits
xbolva00 added a comment. >> UTC_ARGS (I can't help associating it with Coordinated Universal Time). Me too. Any suggestions for new name? TCU_ARGS? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78478/new/ https://reviews.llvm.org/D78478

[clang] aa7fd90 - [clang][NFC] Store a pointer to the ASTContext in ASTDumper and TextNodeDumper

2020-07-02 Thread Bruno Ricci via cfe-commits
Author: Bruno Ricci Date: 2020-07-02T19:29:02+01:00 New Revision: aa7fd905e4e1bc510448431da9310e8cf5197523 URL: https://github.com/llvm/llvm-project/commit/aa7fd905e4e1bc510448431da9310e8cf5197523 DIFF: https://github.com/llvm/llvm-project/commit/aa7fd905e4e1bc510448431da9310e8cf5197523.diff

[PATCH] D82677: [Clang] Handle AIX Include management in the driver

2020-07-02 Thread Hubert Tong via Phabricator via cfe-commits
hubert.reinterpretcast added inline comments. Comment at: clang/lib/Driver/ToolChains/AIX.cpp:172 +return; + + const Driver = getDriver(); daltenty wrote: > hubert.reinterpretcast wrote: > > Please investigate the handling of `OPT_nostdlibinc`. > If we are

[PATCH] D80225: [Driver] Recognize -fuse-ld={bfd, gold, lld} but don't prepend "ld." or "ld64." for other values

2020-07-02 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay abandoned this revision. MaskRay added a comment. Abandon in favor of D83015 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80225/new/ https://reviews.llvm.org/D80225

[PATCH] D50229: [ARM][AArch64] Add feature +fp16fml

2020-07-02 Thread Sjoerd Meijer via Phabricator via cfe-commits
SjoerdMeijer marked an inline comment as done. SjoerdMeijer added inline comments. Comment at: test/Driver/aarch64-cpus.c:518 +// RUN: %clang -target aarch64 -march=armv8.4-a -### -c %s 2>&1 | FileCheck -check-prefix=GENERICV84A-NO-FP16FML %s +// GENERICV84A-NO-FP16FML-NOT:

[PATCH] D82502: [PowerPC][Power10] Implement Load VSX Vector and Sign Extend and Zero Extend

2020-07-02 Thread Lei Huang via Phabricator via cfe-commits
lei added inline comments. Comment at: llvm/lib/Target/PowerPC/PPCISelLowering.h:487 +/// Allows utilization of the Load VSX Vector Rightmost Instructions. +LXVRZX + missing `,`? Comment at:

[PATCH] D76342: [OpenMP] Implement '#pragma omp tile'

2020-07-02 Thread Alexey Bataev via Phabricator via cfe-commits
ABataev added a comment. In D76342#2128739 , @Meinersbur wrote: > ping > > @ABataev Have you checked the alternative scheme? Working on it, need a little bit more time. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D82860: Port ObjCMTAction to new option parsing system

2020-07-02 Thread Daniel Grumberg via Phabricator via cfe-commits
dang updated this revision to Diff 275171. dang added a comment. Ensure that `mergeForwardValue` can accept default values whose type doesn't quite match the associated keypath. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82860/new/

[PATCH] D82677: [Clang] Handle AIX Include management in the driver

2020-07-02 Thread Hubert Tong via Phabricator via cfe-commits
hubert.reinterpretcast added inline comments. Comment at: clang/lib/Driver/ToolChains/AIX.cpp:179 + } + addSystemInclude(DriverArgs, CC1Args, "/usr/include"); +} This does not observe `--sysroot`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D82677: [Clang] Handle AIX Include management in the driver

2020-07-02 Thread Hubert Tong via Phabricator via cfe-commits
hubert.reinterpretcast added inline comments. Comment at: clang/lib/Driver/ToolChains/AIX.cpp:172 +return; + + const Driver = getDriver(); Please investigate the handling of `OPT_nostdlibinc`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D83055: [clang][Driver] Fix tool path priority test failure

2020-07-02 Thread David Spickett via Phabricator via cfe-commits
DavidSpickett updated this revision to Diff 275138. DavidSpickett added a comment. - Added check for alternate gcc names in the first test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83055/new/ https://reviews.llvm.org/D83055 Files:

[PATCH] D82964: [clangd] Config: loading and caching config from disk.

2020-07-02 Thread Sam McCall via Phabricator via cfe-commits
sammccall updated this revision to Diff 275165. sammccall added a comment. Try to get the tests to pass on windows. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82964/new/ https://reviews.llvm.org/D82964 Files:

[PATCH] D82502: [PowerPC][Power10] Implement Load VSX Vector and Sign Extend and Zero Extend

2020-07-02 Thread Albion Fung via Phabricator via cfe-commits
Conanap updated this revision to Diff 275159. Conanap added a comment. Fixed a missing comma; ensured it builds. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82502/new/ https://reviews.llvm.org/D82502 Files: clang/lib/Headers/altivec.h

[PATCH] D82502: [PowerPC][Power10] Implement Load VSX Vector and Sign Extend and Zero Extend

2020-07-02 Thread Albion Fung via Phabricator via cfe-commits
Conanap marked an inline comment as done. Conanap added a comment. fixed a missing comma and ensure that it compiles Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82502/new/ https://reviews.llvm.org/D82502

[PATCH] D76342: [OpenMP] Implement '#pragma omp tile'

2020-07-02 Thread Michael Kruse via Phabricator via cfe-commits
Meinersbur added a comment. ping @ABataev Have you checked the alternative scheme? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76342/new/ https://reviews.llvm.org/D76342 ___ cfe-commits mailing

[PATCH] D82677: [Clang] Handle AIX Include management in the driver

2020-07-02 Thread David Tenty via Phabricator via cfe-commits
daltenty requested changes to this revision. daltenty added inline comments. This revision now requires changes to proceed. Comment at: clang/lib/Driver/ToolChains/AIX.cpp:172 +return; + + const Driver = getDriver(); hubert.reinterpretcast wrote: > Please

[clang] fcf4d5e - Revert "[clang][NFC] Store a pointer to the ASTContext in ASTDumper and TextNodeDumper"

2020-07-02 Thread Bruno Ricci via cfe-commits
Author: Bruno Ricci Date: 2020-07-02T19:40:09+01:00 New Revision: fcf4d5e4499a391dff42ea1a096f146db44147b6 URL: https://github.com/llvm/llvm-project/commit/fcf4d5e4499a391dff42ea1a096f146db44147b6 DIFF: https://github.com/llvm/llvm-project/commit/fcf4d5e4499a391dff42ea1a096f146db44147b6.diff

[PATCH] D82677: [Clang] Handle AIX Include management in the driver

2020-07-02 Thread David Tenty via Phabricator via cfe-commits
daltenty accepted this revision. daltenty added a comment. This revision is now accepted and ready to land. LGTM other than minor nit Comment at: clang/test/Driver/aix-toolchain-include.cpp:13 + +// Check powerpc-ibm-aix, 64-bit. +// RUN: %clangxx -### -no-canonical-prefixes

[PATCH] D82948: [Driver][ARM] Disable unsupported features when nofp arch extension is used

2020-07-02 Thread Momchil Velikov via Phabricator via cfe-commits
chill added inline comments. Comment at: clang/lib/Driver/ToolChains/Arch/ARM.cpp:292-297 + auto checkFPDisabledInArchName = [](const StringRef ) { +SmallVector Split; +ArchName.split(Split, '+', -1, false); +return llvm::any_of( +Split, [](const StringRef )

[PATCH] D83055: [clang][Driver] Fix tool path priority test failure

2020-07-02 Thread David Spickett via Phabricator via cfe-commits
DavidSpickett created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This test can fail when the path of the build includes the strings we're checking for. E.g "/gcc" is found in ".../gcc_7.3.0/..." To correct this look for '"' on the end of all matches. So

[PATCH] D83074: [clang] Check ValueDependent instead of InstantiationDependent before executing the align expr for builtin align functions.

2020-07-02 Thread Haojian Wu via Phabricator via cfe-commits
hokein created this revision. hokein added a reviewer: arichardson. Herald added a project: clang. in general, value dependent is a subset of instnatiation dependent. This would allows us to produce diagnostics for the align expression (which is instantiation dependent but not value dependent).

[PATCH] D83071: Add support for options with two flags for controlling the same field.

2020-07-02 Thread Daniel Grumberg via Phabricator via cfe-commits
dang created this revision. dang added a reviewer: Bigcheese. Herald added subscribers: llvm-commits, cfe-commits, dexonsmith. Herald added projects: clang, LLVM. This enables automatically parsing and generating CC1 arguments for options where two flags control the same field, e.g.

[PATCH] D83074: [clang] Check ValueDependent instead of InstantiationDependent before executing the align expr for builtin align functions.

2020-07-02 Thread Alexander Richardson via Phabricator via cfe-commits
arichardson accepted this revision. arichardson added inline comments. This revision is now accepted and ready to land. Comment at: clang/test/SemaCXX/builtin-align-cxx.cpp:40 template void test_incorrect_alignment_without_instatiation(T value) { Could also

[PATCH] D81315: [analyzer] Warning for default constructed unique pointer dereferences

2020-07-02 Thread Nithin VR via Phabricator via cfe-commits
vrnithinkumar marked 4 inline comments as done. vrnithinkumar added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Checkers/Checkers.td:582 + "false", + InAlpha>, + ]>, Szelethus wrote: > Let's `Hide` this in

[PATCH] D83099: Revert "[clangd] Store index in '.clangd/index' instead of '.clangd-index'"

2020-07-02 Thread Sam McCall via Phabricator via cfe-commits
sammccall created this revision. sammccall added reviewers: kadircet, hokein. Herald added subscribers: llvm-commits, cfe-commits, usaxena95, arphaman, omtcyfz, jkorous, MaskRay, ilya-biryukov. Herald added projects: clang, LLVM. This was well-intentioned, but it turns out `.clangd` is the best

[PATCH] D82774: [Power10] Implement Vector Blend Builtins in LLVM/Clang

2020-07-02 Thread Lei Huang via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGca464639a1c9: [PowerPC] Implement Vector Blend Builtins in LLVM/Clang (authored by biplmish, committed by lei). Herald added a project: clang. Herald added a subscriber: cfe-commits. Changed prior to

[PATCH] D83076: Revert AST Matchers default to AsIs mode

2020-07-02 Thread Stephen Kelly via Phabricator via cfe-commits
steveire updated this revision to Diff 275245. steveire added a comment. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83076/new/ https://reviews.llvm.org/D83076 Files: clang-tools-extra/clang-query/Query.cpp

[PATCH] D82800: [OPENMP50] extend array section for stride (Parsing/Sema/AST)

2020-07-02 Thread Chi Chun Chen via Phabricator via cfe-commits
cchen updated this revision to Diff 275196. cchen added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82800/new/ https://reviews.llvm.org/D82800 Files: clang/include/clang-c/Index.h clang/include/clang/AST/ExprOpenMP.h

[PATCH] D82477: [lldb-vscode] Add Support for Module Event

2020-07-02 Thread Greg Clayton via Phabricator via cfe-commits
clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. See inline comments. Changes needed are: - test for eBroadcastBitSymbolsLoaded - add "version" to module info - test all data we expect in module info ('name', 'symbolFilePath',

[PATCH] D82869: [Power10] Implement Vector Permute Extended Builtins in LLVM/Clang

2020-07-02 Thread Lei Huang via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG286073484f7d: [PowerPC]Implement Vector Permute Extended Builtin (authored by biplmish, committed by lei). Herald added a project: clang. Herald added a subscriber: cfe-commits. Changed prior to commit:

[PATCH] D83079: [clang] Default target features implied by `-march` on AArch64.

2020-07-02 Thread Francesco Petrogalli via Phabricator via cfe-commits
fpetrogalli created this revision. fpetrogalli added reviewers: sdesmalen, efriedma, SjoerdMeijer. Herald added subscribers: cfe-commits, danielkiss, kristof.beyls. Herald added a project: clang. This patch is trying to align the interpretation of `-march` on AArch64 to what GCC has, in terms of

[PATCH] D78478: [UpdateTestChecks] Add UTC_ARGS support for update_{llc,cc}_test_checks.py

2020-07-02 Thread Alexander Richardson via Phabricator via cfe-commits
arichardson added a comment. In D78478#2128604 , @MaskRay wrote: > The idea look good to me, but I want some opinions on the name `UTC_ARGS` (I > can't help associating it with Coordinated Universal Time). Adding some folks > who may have opinions:

[PATCH] D83076: Revert AST Matchers default to AsIs mode

2020-07-02 Thread Stephen Kelly via Phabricator via cfe-commits
steveire created this revision. steveire added reviewers: aaron.ballman, klimek. Herald added a project: clang. Herald added a subscriber: cfe-commits. steveire added a reviewer: sammccall. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D83076 Files:

[PATCH] D83088: Introduce CfgTraits abstraction

2020-07-02 Thread Nicolai Hähnle via Phabricator via cfe-commits
nhaehnle created this revision. nhaehnle added reviewers: arsenm, RKSimon, mehdi_amini, courbet. Herald added subscribers: cfe-commits, msifontes, jurahul, Kayjukh, vkmr, grosul1, Joonsoo, stephenneuendorffer, liufengdb, aartbik, lucyrfox, mgester, arpith-jacob, nicolasvasilache, antiagainst,

[PATCH] D82800: [OPENMP50] extend array section for stride (Parsing/Sema/AST)

2020-07-02 Thread Alexey Bataev via Phabricator via cfe-commits
ABataev added inline comments. Comment at: clang/lib/Parse/ParseExpr.cpp:1933 } +if (getLangOpts().OpenMP >= 50 && Tok.is(tok::colon)) { + // Consume ':' Seems to me, it is too broad. According to the standard, it must be allowed only

[PATCH] D82874: Add diagnostic option backing field for -fansi-escape-codes

2020-07-02 Thread Daniel Grumberg via Phabricator via cfe-commits
dang updated this revision to Diff 275187. dang added a comment. Make the tablegen description of the new option more consistent with other flags. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82874/new/ https://reviews.llvm.org/D82874 Files:

[clang] 2860734 - [PowerPC]Implement Vector Permute Extended Builtin

2020-07-02 Thread Lei Huang via cfe-commits
Author: Biplob Mishra Date: 2020-07-02T14:53:18-05:00 New Revision: 286073484f7d36c8d0481be2a2f436f973389f54 URL: https://github.com/llvm/llvm-project/commit/286073484f7d36c8d0481be2a2f436f973389f54 DIFF: https://github.com/llvm/llvm-project/commit/286073484f7d36c8d0481be2a2f436f973389f54.diff

[PATCH] D79773: [clang-format] Improve clang-formats handling of concepts

2020-07-02 Thread MyDeveloperDay via Phabricator via cfe-commits
MyDeveloperDay updated this revision to Diff 275213. MyDeveloperDay added a comment. Still a work in progress but covers I think the case @JohelEGP found. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79773/new/ https://reviews.llvm.org/D79773 Files:

[PATCH] D82085: [TRE] allow TRE for non-capturing calls.

2020-07-02 Thread Alexey Lapshin via Phabricator via cfe-commits
avl added a comment. @efriedma What do you think about current state of this patch? Is it OK? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82085/new/ https://reviews.llvm.org/D82085 ___ cfe-commits

[PATCH] D78478: [UpdateTestChecks] Add UTC_ARGS support for update_{llc,cc}_test_checks.py

2020-07-02 Thread Johannes Doerfert via Phabricator via cfe-commits
jdoerfert added a comment. In D78478#2128926 , @arichardson wrote: > In D78478#2128604 , @MaskRay wrote: > > > The idea look good to me, but I want some opinions on the name `UTC_ARGS` > > (I can't help

[PATCH] D82999: [CodeGen] Check the cleanup flag before destructing lifetime-extended temporaries created in conditional expressions

2020-07-02 Thread Akira Hatanaka via Phabricator via cfe-commits
ahatanak added a comment. After-full-expression cleanup looks fine to me. `pushCleanupAfterFullExpr` sets the flags and saves the values when it's in a conditional branch. I think ideally we shouldn't have to clean up anything in the true expression when the false expression throws, but I

[PATCH] D83057: [OpenMP][NFC] Remove hard-coded line numbers from more tests

2020-07-02 Thread George Rokos via Phabricator via cfe-commits
grokos accepted this revision. grokos added a comment. This revision is now accepted and ready to land. Like D82224 , looks good. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83057/new/

[PATCH] D82822: [OpenMP][FIX] Consistently use OpenMPIRBuilder if requested

2020-07-02 Thread Fady Ghanim via Phabricator via cfe-commits
fghanim added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82822/new/ https://reviews.llvm.org/D82822 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D82999: [CodeGen] Check the cleanup flag before destructing lifetime-extended temporaries created in conditional expressions

2020-07-02 Thread John McCall via Phabricator via cfe-commits
rjmccall added a comment. In D82999#2129031 , @ahatanak wrote: > After-full-expression cleanup looks fine to me. `pushCleanupAfterFullExpr` > sets the flags and saves the values when it's in a conditional branch. > > I think ideally we shouldn't have to

  1   2   >