[PATCH] D83188: [clang-tidy] bugprone-bool-pointer-implicit-conversion doesn't handle members

2020-07-06 Thread Alex Cameron via Phabricator via cfe-commits
tetsuo-cpp created this revision. tetsuo-cpp added reviewers: njames93, MaskRay. tetsuo-cpp added projects: clang, clang-tools-extra. Herald added subscribers: cfe-commits, xazax.hun. Bugzilla: https://bugs.llvm.org/show_bug.cgi?id=45189 This patch is adding support for members to the

[PATCH] D83071: Add support for options with two flags for controlling the same field.

2020-07-06 Thread Daniel Grumberg via Phabricator via cfe-commits
dang updated this revision to Diff 275591. dang marked an inline comment as done. dang added a comment. Address some code review feedback. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83071/new/ https://reviews.llvm.org/D83071 Files:

[PATCH] D83071: Add support for options with two flags for controlling the same field.

2020-07-06 Thread Daniel Grumberg via Phabricator via cfe-commits
dang marked 5 inline comments as done. dang added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:150 -static llvm::Optional normalizeSimpleEnum(OptSpecifier Opt, -unsigned TableIndex,

[PATCH] D83190: [analyzer] Model iterator random incrementation symmetrically

2020-07-06 Thread Endre Fülöp via Phabricator via cfe-commits
gamesh411 created this revision. Herald added subscribers: cfe-commits, ASDenysPetrov, martong, steakhal, Charusso, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun, whisperity. Herald added a reviewer: Szelethus. Herald added a project: clang. In

[clang] df3bda0 - [VE] Correct stack alignment

2020-07-06 Thread Kazushi Marukawa via cfe-commits
Author: Kazushi (Jam) Marukawa Date: 2020-07-06T17:25:29+09:00 New Revision: df3bda047d5abe9190bdd0422270328140556bd4 URL: https://github.com/llvm/llvm-project/commit/df3bda047d5abe9190bdd0422270328140556bd4 DIFF:

[PATCH] D83188: [clang-tidy] bugprone-bool-pointer-implicit-conversion doesn't handle members

2020-07-06 Thread Alex Cameron via Phabricator via cfe-commits
tetsuo-cpp updated this revision to Diff 275592. tetsuo-cpp added a comment. Remove the unnecessary template. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83188/new/ https://reviews.llvm.org/D83188 Files: clang-tools-extra/clang-tidy/bugprone/BoolPointerImplicitConversionCheck.cpp

[clang] bd50cf9 - Fix indentation in FixedPoint.h. NFC.

2020-07-06 Thread Bevin Hansson via cfe-commits
Author: Bevin Hansson Date: 2020-07-06T10:57:21+02:00 New Revision: bd50cf905fa7c0c7caa134301c6ca0658c81eeb1 URL: https://github.com/llvm/llvm-project/commit/bd50cf905fa7c0c7caa134301c6ca0658c81eeb1 DIFF: https://github.com/llvm/llvm-project/commit/bd50cf905fa7c0c7caa134301c6ca0658c81eeb1.diff

[PATCH] D83189: [clangd] More complete fix for hover crashes on invalid record.

2020-07-06 Thread Haojian Wu via Phabricator via cfe-commits
hokein created this revision. hokein added a reviewer: kadircet. Herald added subscribers: usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. We should not call getFieldOffset on invalid record decls. Repository: rG LLVM Github Monorepo

[PATCH] D83190: [analyzer] Model iterator random incrementation symmetrically

2020-07-06 Thread Endre Fülöp via Phabricator via cfe-commits
gamesh411 updated this revision to Diff 275595. gamesh411 added a comment. remove unrelated comment formatting Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83190/new/ https://reviews.llvm.org/D83190 Files:

[PATCH] D82954: Fix crash on overloaded postfix unary operators due to invalid SourceLocation

2020-07-06 Thread Eduardo Caldas via Phabricator via cfe-commits
eduucaldas added inline comments. Comment at: clang/lib/Tooling/Syntax/BuildTree.cpp:188 + case OO_Comma: + case OO_ArrowStar: +return syntax::NodeKind::UnknownExpression; Actually arrow star is treated like a normal binary operator in the [[

[PATCH] D83154: clang: Add -fcoverage-prefix-map

2020-07-06 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay added a comment. -fdebug-prefix-map does not make sense to me because coverage is not debug info. I am on the fence whether we need -fcoverage-prefix-map. I created https://gcc.gnu.org/bugzilla/show_bug.cgi?id=96092 (Should --coverage respect -ffile-prefix-map?)

[PATCH] D83263: [WIP] Clang crashed while checking for deletion of copy and move ctors

2020-07-06 Thread Richard Smith - zygoloid via Phabricator via cfe-commits
rsmith added inline comments. Comment at: clang/lib/Sema/SemaDeclCXX.cpp:9733 return true; return false; }; This is not the right fallback answer if the class is a dependent type -- we don't yet know if there's a non-deleted copy or move

[clang-tools-extra] 0196600 - [clang-tidy] Fix incorrect default option in fc3c693b61

2020-07-06 Thread Nathan James via cfe-commits
Author: Nathan James Date: 2020-07-06T14:44:03+01:00 New Revision: 01966003674d49e06632495fec2a5a7b3fd58a80 URL: https://github.com/llvm/llvm-project/commit/01966003674d49e06632495fec2a5a7b3fd58a80 DIFF: https://github.com/llvm/llvm-project/commit/01966003674d49e06632495fec2a5a7b3fd58a80.diff

[clang] 5689b38 - Removed a RecursiveASTVisitor feature to visit operator kinds with different methods

2020-07-06 Thread Dmitri Gribenko via cfe-commits
Author: Dmitri Gribenko Date: 2020-07-06T13:38:01+02:00 New Revision: 5689b38c6a4220cc5f6ba68a56486229b10071bf URL: https://github.com/llvm/llvm-project/commit/5689b38c6a4220cc5f6ba68a56486229b10071bf DIFF:

[clang] 8e750b1 - Make RecursiveASTVisitor call WalkUpFrom for operators when the data recursion queue is absent

2020-07-06 Thread Dmitri Gribenko via cfe-commits
Author: Dmitri Gribenko Date: 2020-07-06T13:38:01+02:00 New Revision: 8e750b1f0a2b6b5174dc49adf20e6f863c28e3cd URL: https://github.com/llvm/llvm-project/commit/8e750b1f0a2b6b5174dc49adf20e6f863c28e3cd DIFF:

[clang] 7349479 - RecursiveASTVisitor: don't call WalkUp unnecessarily in post-order traversal

2020-07-06 Thread Dmitri Gribenko via cfe-commits
Author: Dmitri Gribenko Date: 2020-07-06T13:38:01+02:00 New Revision: 7349479f2244c32c0184ca545af04adb171c8077 URL: https://github.com/llvm/llvm-project/commit/7349479f2244c32c0184ca545af04adb171c8077 DIFF:

[clang] c19c6b1 - Make RecursiveASTVisitor call WalkUpFrom for unary and binary operators in post-order traversal mode

2020-07-06 Thread Dmitri Gribenko via cfe-commits
Author: Dmitri Gribenko Date: 2020-07-06T13:38:01+02:00 New Revision: c19c6b1722e5f71200c09cdb096245b98f03dce0 URL: https://github.com/llvm/llvm-project/commit/c19c6b1722e5f71200c09cdb096245b98f03dce0 DIFF:

[clang] b295607 - [analyzer][NFC] Don't allow dependency checkers to emit diagnostics

2020-07-06 Thread Kirstóf Umann via cfe-commits
Author: Kirstóf Umann Date: 2020-07-06T14:51:37+02:00 New Revision: b2956076976cd0f435c46257f7cf9a0e5376d0fa URL: https://github.com/llvm/llvm-project/commit/b2956076976cd0f435c46257f7cf9a0e5376d0fa DIFF: https://github.com/llvm/llvm-project/commit/b2956076976cd0f435c46257f7cf9a0e5376d0fa.diff

[clang] cfd6b4b - [analyzer] Don't allow hidden checkers to emit diagnostics

2020-07-06 Thread Kirstóf Umann via cfe-commits
Author: Kirstóf Umann Date: 2020-07-06T15:34:51+02:00 New Revision: cfd6b4b811aa8bb193f744264e36e83de4bb3650 URL: https://github.com/llvm/llvm-project/commit/cfd6b4b811aa8bb193f744264e36e83de4bb3650 DIFF: https://github.com/llvm/llvm-project/commit/cfd6b4b811aa8bb193f744264e36e83de4bb3650.diff

[clang] cd9a241 - [clang] Fix the incorrect dependence bits for DependentExtIntType.

2020-07-06 Thread Haojian Wu via cfe-commits
Author: Haojian Wu Date: 2020-07-06T16:42:56+02:00 New Revision: cd9a241f165013902fc060ace88c66e402c7767a URL: https://github.com/llvm/llvm-project/commit/cd9a241f165013902fc060ace88c66e402c7767a DIFF: https://github.com/llvm/llvm-project/commit/cd9a241f165013902fc060ace88c66e402c7767a.diff

[clang] 690ff37 - [analyzer] Force dependency checkers to be hidden

2020-07-06 Thread Kirstóf Umann via cfe-commits
Author: Kirstóf Umann Date: 2020-07-06T13:05:45+02:00 New Revision: 690ff37a286991f142584f25842e50c6cb23aba6 URL: https://github.com/llvm/llvm-project/commit/690ff37a286991f142584f25842e50c6cb23aba6 DIFF: https://github.com/llvm/llvm-project/commit/690ff37a286991f142584f25842e50c6cb23aba6.diff

[clang] 0547040 - [SemaCXX] Fix false positive of -Wuninitialized-const-reference in empty function body.

2020-07-06 Thread Zequan Wu via cfe-commits
Author: Zequan Wu Date: 2020-07-06T10:52:05-07:00 New Revision: 054704082b461418d3dac3a379792cdaf52d40b3 URL: https://github.com/llvm/llvm-project/commit/054704082b461418d3dac3a379792cdaf52d40b3 DIFF: https://github.com/llvm/llvm-project/commit/054704082b461418d3dac3a379792cdaf52d40b3.diff

[PATCH] D82087: AMDGPU/clang: Add builtins for llvm.amdgcn.ballot

2020-07-06 Thread Matt Arsenault via Phabricator via cfe-commits
arsenm added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82087/new/ https://reviews.llvm.org/D82087 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] bfdafa3 - [FPEnv][Clang][Driver] Failing tests are now expected failures.

2020-07-06 Thread Kevin P. Neal via cfe-commits
Author: Kevin P. Neal Date: 2020-07-06T14:20:49-04:00 New Revision: bfdafa32a0fa4b2745627fe57dd253db10ac3fcf URL: https://github.com/llvm/llvm-project/commit/bfdafa32a0fa4b2745627fe57dd253db10ac3fcf DIFF: https://github.com/llvm/llvm-project/commit/bfdafa32a0fa4b2745627fe57dd253db10ac3fcf.diff

[clang] 2b35511 - [FPEnv][Clang][Driver] Failing tests are now expected failures only on PowerPC

2020-07-06 Thread Kevin P. Neal via cfe-commits
Author: Kevin P. Neal Date: 2020-07-06T14:44:06-04:00 New Revision: 2b35511350454dd22997f129ee529e3fdb129ac2 URL: https://github.com/llvm/llvm-project/commit/2b35511350454dd22997f129ee529e3fdb129ac2 DIFF: https://github.com/llvm/llvm-project/commit/2b35511350454dd22997f129ee529e3fdb129ac2.diff

[clang] 39d2ae0 - [FPEnv][Clang][Driver] Disable constrained floating point on targets lacking support.

2020-07-06 Thread Kevin P. Neal via cfe-commits
Author: Kevin P. Neal Date: 2020-07-06T13:32:49-04:00 New Revision: 39d2ae0afb2312a15e4d15a0855b35b4e1c49fc4 URL: https://github.com/llvm/llvm-project/commit/39d2ae0afb2312a15e4d15a0855b35b4e1c49fc4 DIFF: https://github.com/llvm/llvm-project/commit/39d2ae0afb2312a15e4d15a0855b35b4e1c49fc4.diff

[PATCH] D80952: [FPEnv][Clang][Driver] Disable constrained floating point on targets lacking support.

2020-07-06 Thread Kevin P. Neal via Phabricator via cfe-commits
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG39d2ae0afb23: [FPEnv][Clang][Driver] Disable constrained floating point on targets lacking… (authored by kpn). Changed

[PATCH] D83013: [LPM] Port CGProfilePass from NPM to LPM

2020-07-06 Thread Alina Sbirlea via Phabricator via cfe-commits
asbirlea added a comment. In D83013#2132088 , @aeubanks wrote: > In D83013#2132070 , @echristo wrote: > > > Adding Chandler and Alina here as well. > > > > In general, I don't think that this is such a great idea.

[PATCH] D82800: [OPENMP50] extend array section for stride (Parsing/Sema/AST)

2020-07-06 Thread Chi Chun Chen via Phabricator via cfe-commits
cchen marked an inline comment as done. cchen added inline comments. Comment at: clang/lib/Parse/ParseExpr.cpp:1933 } +if (getLangOpts().OpenMP >= 50 && Tok.is(tok::colon)) { + // Consume ':' cchen wrote: > ABataev wrote: > > Seems to

[PATCH] D80952: [FPEnv][Clang][Driver] Disable constrained floating point on targets lacking support.

2020-07-06 Thread Nico Weber via Phabricator via cfe-commits
thakis added a comment. This seems to break tests everywhere, eg http://45.33.8.238/linux/22152/step_7.txt or http://lab.llvm.org:8011/builders/clang-x86_64-debian-new-pass-manager-fast/builds/11251 Please take a look and revert if the fix takes a while. Repository: rG LLVM Github Monorepo

[PATCH] D80952: [FPEnv][Clang][Driver] Disable constrained floating point on targets lacking support.

2020-07-06 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay added a comment. Note also that @arsenm is still a blocking reviewer. It is generally expected that all feedback is acknowledged. @kpn you should probably wait for @arsenm to explicitly clear the blocker. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D80952: [FPEnv][Clang][Driver] Disable constrained floating point on targets lacking support.

2020-07-06 Thread Kevin P. Neal via Phabricator via cfe-commits
kpn added a comment. Already on it. I hope I got it now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80952/new/ https://reviews.llvm.org/D80952 ___ cfe-commits mailing list

[PATCH] D83084: DomTree: Remove the releaseMemory() method

2020-07-06 Thread David Blaikie via Phabricator via cfe-commits
dblaikie added a comment. @arsenm - if you can, please include some text whenever approving a patch via phabricator, otherwise no email indicating approval is sent to the mailing lists (which makes auditing reviews difficult) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D83013: [LPM] Port CGProfilePass from NPM to LPM

2020-07-06 Thread Zequan Wu via Phabricator via cfe-commits
zequanwu updated this revision to Diff 275763. zequanwu added a comment. Delete `enable-npm-call-graph-profile` option for NPM, using `enable-call-graph-profile` for both LPM and NPM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83013/new/

[PATCH] D82425: [SemaCXX] Fix false positive of -Wuninitialized-const-reference in empty function body.

2020-07-06 Thread Zequan Wu via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG054704082b46: [SemaCXX] Fix false positive of -Wuninitialized-const-reference in empty… (authored by zequanwu). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D82317: [Clang/Test]: Update tests where `noundef` attribute is necessary

2020-07-06 Thread Gui Andrade via Phabricator via cfe-commits
guiand updated this revision to Diff 275771. guiand added a comment. Another wave of test updates Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82317/new/ https://reviews.llvm.org/D82317 Files: clang/test/ARCMT/objcmt-instancetype.m

[PATCH] D82904: [clang-tidy] Warn pointer captured in async block

2020-07-06 Thread Nathan James via Phabricator via cfe-commits
njames93 added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/BugproneTidyModule.cpp:121 "bugprone-narrowing-conversions"); +CheckFactories.registerCheck("bugprone-no-escape"); CheckFactories.registerCheck( aaron.ballman

[PATCH] D82728: [clang] Add -Wsuggest-override

2020-07-06 Thread David Blaikie via Phabricator via cfe-commits
dblaikie added a comment. Generally Clang tries to avoid stylistic warnings like this (& they are left to be addressed by tools like clang-tidy), hence why -Winconsistent-missing-override was implemented that way (the presence of at least one "override" being a signal the user intended to use

[clang] 7308e14 - [clang] Fix modules build after D82585

2020-07-06 Thread Raphael Isemann via cfe-commits
Author: Raphael Isemann Date: 2020-07-06T17:51:53+02:00 New Revision: 7308e1432624f02d4e652ffa70e40d0eaa89fdb3 URL: https://github.com/llvm/llvm-project/commit/7308e1432624f02d4e652ffa70e40d0eaa89fdb3 DIFF:

[clang] e80b81d - [Support] Fix formatted_raw_ostream for UTF-8

2020-07-06 Thread Oliver Stannard via cfe-commits
Author: Oliver Stannard Date: 2020-07-06T16:18:15+01:00 New Revision: e80b81d1cbf85dcd427759369978afdb48f0998f URL: https://github.com/llvm/llvm-project/commit/e80b81d1cbf85dcd427759369978afdb48f0998f DIFF:

[clang-tools-extra] 254b016 - [clangd] More complete fix for hover crashes on invalid record.

2020-07-06 Thread Haojian Wu via cfe-commits
Author: Haojian Wu Date: 2020-07-06T17:12:39+02:00 New Revision: 254b016c6561e4ec4d145b81c4d0aaf3d2c7fca6 URL: https://github.com/llvm/llvm-project/commit/254b016c6561e4ec4d145b81c4d0aaf3d2c7fca6 DIFF: https://github.com/llvm/llvm-project/commit/254b016c6561e4ec4d145b81c4d0aaf3d2c7fca6.diff

[clang] cf0b3af - [clang][utils] make-ast-dump-check.sh: strip line and column numbers when generating serialization tests

2020-07-06 Thread Bruno Ricci via cfe-commits
Author: Bruno Ricci Date: 2020-07-06T16:52:35+01:00 New Revision: cf0b3affed47811b02127383c7eec27285ac35a3 URL: https://github.com/llvm/llvm-project/commit/cf0b3affed47811b02127383c7eec27285ac35a3 DIFF: https://github.com/llvm/llvm-project/commit/cf0b3affed47811b02127383c7eec27285ac35a3.diff

[clang-tools-extra] fc3c693 - [clang-tidy] Added alias llvm-else-after-return.

2020-07-06 Thread Nathan James via cfe-commits
Author: Nathan James Date: 2020-07-06T14:39:03+01:00 New Revision: fc3c693b617fc5fde8939a3aec7e7372ace07693 URL: https://github.com/llvm/llvm-project/commit/fc3c693b617fc5fde8939a3aec7e7372ace07693 DIFF: https://github.com/llvm/llvm-project/commit/fc3c693b617fc5fde8939a3aec7e7372ace07693.diff

[PATCH] D82740: [libclang]: check validity before visiting Stmt node

2020-07-06 Thread Jan Korous via Phabricator via cfe-commits
jkorous added a comment. @milianw I just approved https://reviews.llvm.org/D82629 - I feel like that patch is addressing the core issue. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82740/new/ https://reviews.llvm.org/D82740

[PATCH] D82629: [libclang] Fix crash when visiting a captured VLA.

2020-07-06 Thread Jan Korous via Phabricator via cfe-commits
jkorous added a comment. @ckandeler do you have commit access or do you want me to land the patch? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82629/new/ https://reviews.llvm.org/D82629 ___

[PATCH] D79719: [AIX] Implement AIX special alignment rule about double/long double

2020-07-06 Thread Hubert Tong via Phabricator via cfe-commits
hubert.reinterpretcast added inline comments. Comment at: clang/lib/AST/RecordLayoutBuilder.cpp:666 + /// HasNonEmptyBaseClass - Whether the class has any non-empty class (in the + /// sense of (C++11 [meta.unary.prop])) as base. + bool HasNonEmptyBaseClass;

[clang] 3c7e8d6 - Fix sdk version test to use 99.99.99 as a max dummy version instead of 10.99.99.

2020-07-06 Thread Amara Emerson via cfe-commits
Author: Amara Emerson Date: 2020-07-06T16:53:12-07:00 New Revision: 3c7e8d6d0eb0660fb8fbae98c3e49ca059943416 URL: https://github.com/llvm/llvm-project/commit/3c7e8d6d0eb0660fb8fbae98c3e49ca059943416 DIFF: https://github.com/llvm/llvm-project/commit/3c7e8d6d0eb0660fb8fbae98c3e49ca059943416.diff

[PATCH] D83008: Fix ItaniumRecordLayoutBuilder so that is grabs the correct bases class offsets from the external source

2020-07-06 Thread Shafik Yaghmour via Phabricator via cfe-commits
shafik updated this revision to Diff 275865. shafik added a comment. Adding a second test that is not arm64 specific. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83008/new/ https://reviews.llvm.org/D83008 Files: clang/lib/AST/RecordLayoutBuilder.cpp

[PATCH] D83008: Fix ItaniumRecordLayoutBuilder so that is grabs the correct bases class offsets from the external source

2020-07-06 Thread Shafik Yaghmour via Phabricator via cfe-commits
shafik added a comment. In D83008#2131776 , @teemperor wrote: > Thanks for tracking this down, this is a really nasty bug... > > The fix itself is obviously fine, but I think I'm out of the loop regarding > the testing strategy. We talked about adding a

[PATCH] D83263: [WIP] Clang crashed while checking for deletion of copy and move ctors

2020-07-06 Thread Vy Nguyen via Phabricator via cfe-commits
oontvoo updated this revision to Diff 275866. oontvoo added a comment. add test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83263/new/ https://reviews.llvm.org/D83263 Files: clang/lib/Sema/SemaDeclCXX.cpp

[clang] 916e2ca - Revert "[FPEnv][Clang][Driver] Disable constrained floating point on targets lacking support."

2020-07-06 Thread Kevin P. Neal via cfe-commits
Author: Kevin P. Neal Date: 2020-07-06T14:57:45-04:00 New Revision: 916e2ca99785d34db73945940923a487efad32ad URL: https://github.com/llvm/llvm-project/commit/916e2ca99785d34db73945940923a487efad32ad DIFF: https://github.com/llvm/llvm-project/commit/916e2ca99785d34db73945940923a487efad32ad.diff

[PATCH] D82791: [lit] Improve lit's output with default settings and --verbose.

2020-07-06 Thread Julian Lettner via Phabricator via cfe-commits
yln added a comment. The changes here are for text printed for failing tests, right? And `showAllOutput` is orthogonal and just shows everything even for non-failing tests? Comment at: llvm/utils/lit/lit/OutputSettings.py:34 +ONLY_FAILING_COMMAND =

[PATCH] D82904: [clang-tidy] Warn pointer captured in async block

2020-07-06 Thread Ellis Hoag via Phabricator via cfe-commits
ellis marked an inline comment as done. ellis added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/BugproneTidyModule.cpp:82 "bugprone-bool-pointer-implicit-conversion"); -CheckFactories.registerCheck( -"bugprone-branch-clone"); +

[PATCH] D83183: [clang] Rework how and when APValues are dumped

2020-07-06 Thread Bruno Ricci via Phabricator via cfe-commits
riccibruno updated this revision to Diff 275783. riccibruno added a comment. Make `dumpAPValueChildren` a private member function and remove `TextNodeDumper::getOS`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83183/new/

[PATCH] D82904: [clang-tidy] Warn pointer captured in async block

2020-07-06 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/BugproneTidyModule.cpp:82 "bugprone-bool-pointer-implicit-conversion"); -CheckFactories.registerCheck( -"bugprone-branch-clone"); +

[PATCH] D82800: [OPENMP50] extend array section for stride (Parsing/Sema/AST)

2020-07-06 Thread Alexey Bataev via Phabricator via cfe-commits
ABataev added inline comments. Comment at: clang/lib/Parse/ParseExpr.cpp:1933 } +if (getLangOpts().OpenMP >= 50 && Tok.is(tok::colon)) { + // Consume ':' cchen wrote: > cchen wrote: > > ABataev wrote: > > > Seems to me, it is too broad.

[PATCH] D82791: [lit] Improve lit's output with default settings and --verbose.

2020-07-06 Thread Varun Gandhi via Phabricator via cfe-commits
varungandhi-apple marked 2 inline comments as done. varungandhi-apple added a comment. Thanks for the review, it's a big patch.  I'm a bit busy at the moment, I will respond to the other comments later this week or sometime next week. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang] 16d83c3 - [WebAssembly] Added 64-bit memory.grow/size/copy/fill

2020-07-06 Thread Wouter van Oortmerssen via cfe-commits
Author: Wouter van Oortmerssen Date: 2020-07-06T12:49:50-07:00 New Revision: 16d83c395a1f8660fc583a66e1927a5c433fbbe1 URL: https://github.com/llvm/llvm-project/commit/16d83c395a1f8660fc583a66e1927a5c433fbbe1 DIFF:

[PATCH] D82821: [WebAssembly] Added 64-bit memory.grow/size/init/copy/fill

2020-07-06 Thread Wouter van Oortmerssen via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG16d83c395a1f: [WebAssembly] Added 64-bit memory.grow/size/copy/fill (authored by aardappel). Herald added a project: clang. Herald added a subscriber: cfe-commits. Changed prior to commit:

[PATCH] D82728: [clang] Add -Wsuggest-override

2020-07-06 Thread Arthur O'Dwyer via Phabricator via cfe-commits
Quuxplusone added a comment. In D82728#2133720 , @dblaikie wrote: > (the presence of at least one "override" being a signal the user intended to > use override and missed some [...] I'm in favor of `-Wsuggest-override`, and would definitely use it if

[PATCH] D83178: [clangd] Send EOF before resetting diagnostics consumer

2020-07-06 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet added a comment. Yeah concerns around header-guard checks are real (and likely to be annoying), so will wait for D78038 . I suppose we can split that into multiple patches, and at least land the bit around preserving conditional stack at the end of

[PATCH] D69318: [analyzer] Add SufficientSizeArrayIndexingChecker

2020-07-06 Thread Endre Fülöp via Phabricator via cfe-commits
gamesh411 updated this revision to Diff 275625. gamesh411 added a comment. make single bug-type fix checker registration Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69318/new/ https://reviews.llvm.org/D69318 Files:

[PATCH] D83178: [clangd] Send EOF before resetting diagnostics consumer

2020-07-06 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet updated this revision to Diff 275627. kadircet added a comment. - Add unittest to DiagnosticsTest via llvm-include-order Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83178/new/ https://reviews.llvm.org/D83178 Files:

[PATCH] D81676: [MSP430] Align the toolchain definition with the TI's msp430-gcc v9.2.0

2020-07-06 Thread Kristina Bessonova via Phabricator via cfe-commits
krisb added a comment. Thank you! LGTM, except some minor nits below. Comment at: clang/lib/Driver/ToolChains/MSP430.cpp:154 + SmallString<128> MultilibInclude(GCCInstallation.getInstallPath()); + llvm::sys::path::append(MultilibInclude, "include"); I'd

[PATCH] D76291: [Support] Fix formatted_raw_ostream for UTF-8

2020-07-06 Thread Kristof Beyls via Phabricator via cfe-commits
kristof.beyls accepted this revision. kristof.beyls added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76291/new/ https://reviews.llvm.org/D76291

[PATCH] D80301: [yaml][clang-tidy] Fix multiline YAML serialization

2020-07-06 Thread Dmitry Polukhin via Phabricator via cfe-commits
DmitryPolukhin added a comment. @njames93 and @aaron.ballman - please take a look to this diff. Multiline replacements in YAML are broken and cannot be applied correctly. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80301/new/

[PATCH] D83099: [clangd] Store index in '.cache/clangd/index' instead of '.clangd/index'

2020-07-06 Thread Sam McCall via Phabricator via cfe-commits
sammccall updated this revision to Diff 275645. sammccall retitled this revision from "Revert "[clangd] Store index in '.clangd/index' instead of '.clangd-index'"" to "[clangd] Store index in '.cache/clangd/index' instead of '.clangd/index'". sammccall edited the summary of this revision.

[PATCH] D81761: [analyzer] Force dependency checkers to be hidden

2020-07-06 Thread Kristóf Umann via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG690ff37a2869: [analyzer] Force dependency checkers to be hidden (authored by Szelethus). Changed prior to commit: https://reviews.llvm.org/D81761?vs=274466=275651#toc Repository: rG LLVM Github

[PATCH] D83206: [PATCH] [ARM] Add Cortex-A78 and Cortex-X1 Support for Clang and LLVM

2020-07-06 Thread Mikhail Maltsev via Phabricator via cfe-commits
miyuki added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64Subtarget.h:72 +ThunderX3T110, +CortexX1, +CortexA78 I think the new CPUs should be grouped with other Cortex-A CPUs. Comment at:

[PATCH] D82663: [CodeGen] Have CodeGen for fixed-point unsigned with padding emit signed operations.

2020-07-06 Thread Bevin Hansson via Phabricator via cfe-commits
ebevhan updated this revision to Diff 275657. ebevhan added a comment. Rebased. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82663/new/ https://reviews.llvm.org/D82663 Files: clang/include/clang/Basic/FixedPoint.h

[PATCH] D82921: Removed a RecursiveASTVisitor feature to visit operator kinds with different methods

2020-07-06 Thread Dmitri Gribenko via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG5689b38c6a42: Removed a RecursiveASTVisitor feature to visit operator kinds with different… (authored by gribozavr). Changed prior to commit: https://reviews.llvm.org/D82921?vs=275064=275663#toc

[PATCH] D83212: [Fixed Point] Add fixed-point shift operations and consteval.

2020-07-06 Thread Bevin Hansson via Phabricator via cfe-commits
ebevhan created this revision. ebevhan added reviewers: rjmccall, leonardchan, bjope. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D83212 Files: clang/include/clang/Basic/FixedPoint.h

[PATCH] D82442: [Coroutines] Warning if the return type of coroutine_handle::address is not void*

2020-07-06 Thread Bruno Ricci via Phabricator via cfe-commits
riccibruno added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:10531 +def warn_coroutine_handle_address_invalid_return_type : Warning < + "return type of 'coroutine_handle<>::address should be 'void*' (have %0) in order to get capability with

[PATCH] D83209: Factor out call to EXTRACTOR in generateCC1CommandLine

2020-07-06 Thread Daniel Grumberg via Phabricator via cfe-commits
dang created this revision. dang added a reviewer: Bigcheese. Herald added subscribers: llvm-commits, cfe-commits, dexonsmith. Herald added projects: clang, LLVM. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D83209 Files: clang/include/clang/Driver/Options.td

[PATCH] D83211: Factor out call to EXTRACTOR in generateCC1CommandLine

2020-07-06 Thread Daniel Grumberg via Phabricator via cfe-commits
dang created this revision. dang added a reviewer: Bigcheese. Herald added subscribers: cfe-commits, dexonsmith. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D83211 Files: clang/lib/Frontend/CompilerInvocation.cpp Index:

[PATCH] D83190: [analyzer] Model iterator random incrementation symmetrically

2020-07-06 Thread Balogh , Ádám via Phabricator via cfe-commits
baloghadamsoftware added a comment. Nice work, but please implement this feature also for non-pointer iterators for the matter of consistence. Comment at: clang/lib/StaticAnalyzer/Checkers/IteratorModeling.cpp:279 +// or on the RHS (eg.: 1 + it). Both cases are modeled. +

[PATCH] D82365: [Power10] Implement Vector Insert Builtins in LLVM/Clang

2020-07-06 Thread Lei Huang via Phabricator via cfe-commits
lei added inline comments. Comment at: clang/test/CodeGen/builtins-ppc-p10vector.c:12 +// RUN: -target-cpu pwr10 -triple powerpc64le-unknown-unknown -emit-llvm %s \ +// RUN: -o - | FileCheck %s -check-prefix=CHECK-LE + biplmish wrote: > lei wrote: > > I just

[PATCH] D82547: [Debugify] Expose debugify (original mode) as CC1 option

2020-07-06 Thread Djordje Todorovic via Phabricator via cfe-commits
djtodoro marked 2 inline comments as done. djtodoro added inline comments. Comment at: clang/lib/CodeGen/BackendUtil.cpp:855 +class ClangCustomPassManager : public legacy::PassManager { +public: vsk wrote: > Please factor out OptCustomPassManager from opt and

[PATCH] D83223: [clang-tidy] Header guard check can skip past license comment

2020-07-06 Thread Nathan James via Phabricator via cfe-commits
njames93 created this revision. njames93 added reviewers: aaron.ballman, alexfh, bkramer, gribozavr2. Herald added subscribers: cfe-commits, xazax.hun. Herald added a project: clang. Add an option for header guard derived checks to control whether to skip past a license comment when adding a

[PATCH] D81750: [analyzer] Don't allow hidden checkers to emit diagnostics

2020-07-06 Thread Kristóf Umann via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGcfd6b4b811aa: [analyzer] Dont allow hidden checkers to emit diagnostics (authored by Szelethus). Changed prior to commit: https://reviews.llvm.org/D81750?vs=270447=275697#toc Repository: rG LLVM

[PATCH] D82425: [SemaCXX] Fix false positive of -Wuninitialized-const-reference in empty function body.

2020-07-06 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM despite my enduring sadness that Boost elected to use this totally bizarre approach to silencing unused variable diagnostics when far better-supported options have existed

[PATCH] D83223: [clang-tidy] Header guard check can skip past license comment

2020-07-06 Thread Nathan James via Phabricator via cfe-commits
njames93 marked an inline comment as done. njames93 added inline comments. Comment at: clang-tools-extra/clang-tidy/utils/HeaderGuard.cpp:313 continue; - + StringRef Opening = AddNewLine == NewLineInsertions::None ? "#ifndef " + :

[PATCH] D80242: [Clang] implement -fno-eliminate-unused-debug-types

2020-07-06 Thread Nick Desaulniers via Phabricator via cfe-commits
nickdesaulniers added a comment. Bumping for review Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80242/new/ https://reviews.llvm.org/D80242 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D83224: [clangd] Move clang-tidy check modifications into ClangdServer

2020-07-06 Thread Nathan James via Phabricator via cfe-commits
njames93 added a comment. Do you think there should be a hidden command line option to disable disabling blacklisted checks, purely to prevent hindering attempts to fix these problematic checks. Comment at: clang-tools-extra/clangd/ClangdServer.cpp:115 +// either due to

[PATCH] D82585: [analyzer][NFC] Move the data structures from CheckerRegistry to the Core library

2020-07-06 Thread Raphael Isemann via Phabricator via cfe-commits
teemperor added a comment. Fixed here to get the bot running again: https://github.com/llvm/llvm-project/commit/7308e1432624f02d4e652ffa70e40d0eaa89fdb3 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82585/new/ https://reviews.llvm.org/D82585

[PATCH] D82954: Fix crash on overloaded postfix unary operators due to invalid SourceLocation

2020-07-06 Thread Dmitri Gribenko via Phabricator via cfe-commits
gribozavr2 added inline comments. Comment at: clang/lib/Tooling/Syntax/BuildTree.cpp:118 +syntax::NodeKind getOperatorNodeKind(const CXXOperatorCallExpr ) { + switch (E.getOperator()) { eduucaldas wrote: > # Where to put this logic? > The pro of having this

[PATCH] D82611: [SemaObjC] Add a warning for @selector expressions that potentially refer to objc_direct methods

2020-07-06 Thread Erik Pilkington via Phabricator via cfe-commits
erik.pilkington added a comment. In D82611#2125868 , @MadCoder wrote: > So the risk with that one is that if someone had say the `-didSomething` > direct selector and that some UIKit/Apple SDK API now adds this as a thing > that you use with

[PATCH] D82118: [clang][module] Improve incomplete-umbrella warning

2020-07-06 Thread Zixu Wang via Phabricator via cfe-commits
zixuw added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82118/new/ https://reviews.llvm.org/D82118 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D79719: [AIX] Implement AIX special alignment rule about double/long double

2020-07-06 Thread Hubert Tong via Phabricator via cfe-commits
hubert.reinterpretcast added inline comments. Comment at: clang/lib/AST/ASTContext.cpp:2409 +const RecordDecl *RD = RT->getDecl(); +return std::max(ABIAlign, static_cast(toBits( + getASTRecordLayout(RD).PreferredAlignment)));

[PATCH] D79719: [AIX] Implement AIX special alignment rule about double/long double

2020-07-06 Thread Hubert Tong via Phabricator via cfe-commits
hubert.reinterpretcast added inline comments. Comment at: clang/lib/AST/RecordLayoutBuilder.cpp:1885 + Context.getBaseElementType(CTy->getElementType()) + ->getAs()) +if (BTy->getKind() == BuiltinType::Double || Xiangling_L

[PATCH] D82611: [SemaObjC] Add a warning for @selector expressions that potentially refer to objc_direct methods

2020-07-06 Thread Erik Pilkington via Phabricator via cfe-commits
erik.pilkington updated this revision to Diff 275759. erik.pilkington marked 3 inline comments as done. erik.pilkington added a comment. Add an off-by-default variant of this warning. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82611/new/ https://reviews.llvm.org/D82611 Files:

[PATCH] D82800: [OPENMP50] extend array section for stride (Parsing/Sema/AST)

2020-07-06 Thread Chi Chun Chen via Phabricator via cfe-commits
cchen marked 8 inline comments as done. cchen added inline comments. Comment at: clang/lib/Parse/ParseExpr.cpp:1933 } +if (getLangOpts().OpenMP >= 50 && Tok.is(tok::colon)) { + // Consume ':' ABataev wrote: > Seems to me, it is too

[PATCH] D83071: Add support for options with two flags for controlling the same field.

2020-07-06 Thread Daniel Grumberg via Phabricator via cfe-commits
dang marked an inline comment as done. dang added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:3931-3932 if (((FLAGS)::CC1Option) && \ (ALWAYS_EMIT || EXTRACTOR(this->KEYPATH) != DEFAULT_VALUE)) {

[PATCH] D82904: [clang-tidy] Warn pointer captured in async block

2020-07-06 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/BugproneTidyModule.cpp:82 "bugprone-bool-pointer-implicit-conversion"); -CheckFactories.registerCheck( -"bugprone-branch-clone"); +

[PATCH] D83242: [RFC][BPF] support expr with typedef type for FIELD_EXISTENCE reloc

2020-07-06 Thread Yonghong Song via Phabricator via cfe-commits
yonghong-song created this revision. yonghong-song added reviewers: anakryiko, ast. Herald added subscribers: llvm-commits, cfe-commits, hiraditya. Herald added projects: clang, LLVM. [The patch needs more work e.g. to create proper test, to be agreed on interface, etc.] This patch added

[PATCH] D83254: [X86] Enabled a bunch of 64-bit Interlocked* functions intrinsics on 32-bit Windows to match recent MSVC

2020-07-06 Thread Craig Topper via Phabricator via cfe-commits
craig.topper created this revision. craig.topper added reviewers: RKSimon, spatel, rnk, erichkeane. Herald added a subscriber: jfb. This enables

[PATCH] D81751: [SemaObjC] Fix a -Wobjc-signed-char-bool false-positive with binary conditional operator

2020-07-06 Thread Erik Pilkington via Phabricator via cfe-commits
erik.pilkington added a reviewer: ahatanak. erik.pilkington added a comment. Ping! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81751/new/ https://reviews.llvm.org/D81751 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D83250: [clang] Enable errors for undefined TARGET_OS_ macros in Darwin driver

2020-07-06 Thread Zixu Wang via Phabricator via cfe-commits
zixuw updated this revision to Diff 275821. zixuw added a comment. Add a test case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83250/new/ https://reviews.llvm.org/D83250 Files: clang/lib/Driver/ToolChains/Darwin.cpp

[PATCH] D78655: [CUDA][HIP] Let lambda be host device by default

2020-07-06 Thread Artem Belevich via Phabricator via cfe-commits
tra added inline comments. Comment at: clang/lib/Sema/SemaLambda.cpp:1783 + + if (LangOpts.CUDA && LangOpts.CUDAIsDevice) +CUDACheckLambdaCapture(CallOperator, From); yaxunl wrote: > tra wrote: > > I would expect Sema-level diags to be produced

[PATCH] D82930: [HIP] Fix rocm detection

2020-07-06 Thread Matt Arsenault via Phabricator via cfe-commits
arsenm added inline comments. Comment at: clang/lib/Driver/ToolChains/AMDGPU.cpp:167 +llvm::ErrorOr> VersionFile = +FS.getBufferForFile(BinPath + "/.hipVersion"); +if (!VersionFile) yaxunl wrote: > arsenm wrote: > > arsenm wrote: > > > yaxunl

  1   2   3   >