[PATCH] D82659: Fix missing build dependency on omp_gen.

2020-07-08 Thread Michele Scandale via Phabricator via cfe-commits
michele.scandale added a comment. In D82659#2136999 , @clementval wrote: > Looks good but just one question ... When clang is built as standalone it > does not build the OpenMP part inside Clang? I haven't seen any code to avoid > compiling the OpenMP

[PATCH] D82739: Improve heuristic resolution of dependent types in TargetFinder

2020-07-08 Thread Nathan Ridge via Phabricator via cfe-commits
nridge updated this revision to Diff 276322. nridge added a comment. Improve patch split Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82739/new/ https://reviews.llvm.org/D82739 Files: clang-tools-extra/clangd/FindTarget.cpp

[PATCH] D83371: [clangd] Factor out some helper functions related to heuristic resolution in TargetFinder

2020-07-08 Thread Nathan Ridge via Phabricator via cfe-commits
nridge updated this revision to Diff 276321. nridge added a comment. Improve patch split Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83371/new/ https://reviews.llvm.org/D83371 Files: clang-tools-extra/clangd/FindTarget.cpp Index:

[PATCH] D83201: [AST][RecoveryExpr] Fix the value category for recovery expr.

2020-07-08 Thread Haojian Wu via Phabricator via cfe-commits
hokein added inline comments. Comment at: clang/lib/Sema/SemaOverload.cpp:12944 + Fn->getBeginLoc(), RParenLoc, SubExprs, + ReturnType.isNull() + ? ReturnType sammccall wrote: > here we're splitting the type (e.g. int&&) into a type + VK, and

[PATCH] D83233: [clangd] Enable reading config from files by default.

2020-07-08 Thread Haojian Wu via Phabricator via cfe-commits
hokein accepted this revision. hokein added a comment. looks like you didn't upload the latest version. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83233/new/ https://reviews.llvm.org/D83233 ___

[PATCH] D69318: [analyzer] Add SufficientSizeArrayIndexingChecker

2020-07-08 Thread Endre Fülöp via Phabricator via cfe-commits
gamesh411 marked 7 inline comments as done. gamesh411 added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/SufficientSizeArrayIndexingChecker.cpp:27 +: public Checker> { + mutable std::unique_ptr BT; + balazske wrote: > The bug type can be

[PATCH] D83374: [analyzer][tests] Fix zip unpacking

2020-07-08 Thread Valeriy Savchenko via Phabricator via cfe-commits
vsavchenko created this revision. vsavchenko added reviewers: NoQ, xazax.hun. Herald added subscribers: cfe-commits, ASDenysPetrov, Charusso, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware. Herald added a project: clang. Repository: rG LLVM

[PATCH] D80873: [clang][cmake] Force CMAKE_LINKER for multistage build in case of BOOTSTRAP_LLVM_ENABLE_LLD and MSVC

2020-07-08 Thread Petr Hosek via Phabricator via cfe-commits
phosek added inline comments. Comment at: clang/CMakeLists.txt:751 + if(BOOTSTRAP_LLVM_ENABLE_LLD) +if(MSVC AND NOT BOOTSTRAP_CMAKE_SYSTEM_NAME) + set(${CLANG_STAGE}_LINKER -DCMAKE_LINKER=${LLVM_RUNTIME_OUTPUT_INTDIR}/lld-link.exe) I don't understand

[PATCH] D82805: [clang] Fix a crash on passing C structure of incompatible type to function with reference parameter

2020-07-08 Thread Aleksandr Platonov via Phabricator via cfe-commits
ArcsinX added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82805/new/ https://reviews.llvm.org/D82805 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D69318: [analyzer] Add SufficientSizeArrayIndexingChecker

2020-07-08 Thread Endre Fülöp via Phabricator via cfe-commits
gamesh411 updated this revision to Diff 276346. gamesh411 added a comment. apply review suggestions Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69318/new/ https://reviews.llvm.org/D69318 Files:

[PATCH] D82739: Improve heuristic resolution of dependent types in TargetFinder

2020-07-08 Thread Nathan Ridge via Phabricator via cfe-commits
nridge updated this revision to Diff 276320. nridge added a comment. Split patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82739/new/ https://reviews.llvm.org/D82739 Files: clang-tools-extra/clangd/FindTarget.cpp

[PATCH] D83371: [clangd] Factor out some helper functions related to heuristic resolution in TargetFinder

2020-07-08 Thread Nathan Ridge via Phabricator via cfe-commits
nridge created this revision. nridge added a reviewer: hokein. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Two helpers are introduced: - Some of the logic previously in TargetFinder::Visit*() methods is

[PATCH] D82739: Improve heuristic resolution of dependent types in TargetFinder

2020-07-08 Thread Nathan Ridge via Phabricator via cfe-commits
nridge marked an inline comment as done. nridge added a comment. In D82739#2133155 , @hokein wrote: > looks like we use this heuristic for go-to-def, I think we might want to use > it in more places, e.g. libindex (for xrefs), sema code completion (so

[PATCH] D83201: [AST][RecoveryExpr] Fix the value category for recovery expr.

2020-07-08 Thread Haojian Wu via Phabricator via cfe-commits
hokein updated this revision to Diff 276325. hokein marked an inline comment as done. hokein added a comment. address comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83201/new/ https://reviews.llvm.org/D83201 Files:

[PATCH] D83079: [clang][aarch64] Generate preprocessor macros for -march=armv8.6a+sve.

2020-07-08 Thread Sander de Smalen via Phabricator via cfe-commits
sdesmalen added inline comments. Comment at: clang/lib/Driver/ToolChains/Arch/AArch64.cpp:369 + if (llvm::is_contained(Features, "+v8.6a")) { +if (!llvm::is_contained(Features, "-i8mm") && +!llvm::is_contained(Features, "+noi8mm")) Is this correct

[PATCH] D81315: [analyzer] Warning for default constructed unique pointer dereferences

2020-07-08 Thread Nithin VR via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG20e271a98de5: [analyzer] Warning for default constructed unique_ptr dereference (authored by vrnithinkumar). Changed prior to commit: https://reviews.llvm.org/D81315?vs=275434=276327#toc Repository:

[clang] 20e271a - [analyzer] Warning for default constructed unique_ptr dereference

2020-07-08 Thread Nithin Vadukkumchery Rajendrakumar via cfe-commits
Author: Nithin Vadukkumchery Rajendrakumar Date: 2020-07-08T09:51:02+02:00 New Revision: 20e271a98de5609e22766e56f9c374b150f06982 URL: https://github.com/llvm/llvm-project/commit/20e271a98de5609e22766e56f9c374b150f06982 DIFF:

[PATCH] D81315: [analyzer] Warning for default constructed unique pointer dereferences

2020-07-08 Thread Nithin VR via Phabricator via cfe-commits
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG20e271a98de5: [analyzer] Warning for default constructed unique_ptr dereference (authored by vrnithinkumar). Changed

[PATCH] D82954: Fix crash on overloaded postfix unary operators due to invalid SourceLocation

2020-07-08 Thread Eduardo Caldas via Phabricator via cfe-commits
eduucaldas updated this revision to Diff 276344. eduucaldas marked 4 inline comments as done. eduucaldas added a comment. answering minor comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82954/new/ https://reviews.llvm.org/D82954 Files:

[PATCH] D82954: Fix crash on overloaded postfix unary operators due to invalid SourceLocation

2020-07-08 Thread Eduardo Caldas via Phabricator via cfe-commits
eduucaldas added inline comments. Comment at: clang/unittests/Tooling/Syntax/TreeTest.cpp:2192 R"cpp( +class osstream {}; struct X { gribozavr2 wrote: > I don't think we need a separate class to show the left shift operator. The > declaration below can

[PATCH] D82739: Improve heuristic resolution of dependent types in TargetFinder

2020-07-08 Thread Nathan Ridge via Phabricator via cfe-commits
nridge added a comment. Split out the refactoring into D83371 which this depends on now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82739/new/ https://reviews.llvm.org/D82739

[PATCH] D79773: [clang-format] Improve clang-formats handling of concepts

2020-07-08 Thread Johel Ernesto Guerrero Peña via Phabricator via cfe-commits
JohelEGP added a comment. Ah, that makes sense. The very definition of Allman is to always break before braces. I suppose I'll need to use `BreakBeforeBraces: Custom` and `BraceWrapping:`. I did some testing and noticed that the weird format comes with any of these: BreakBeforeBraces:

[clang] cfcf8e1 - [analyzer] Silence gcc -Wparentheses warning [NFC]

2020-07-08 Thread Mikael Holmen via cfe-commits
Author: Mikael Holmen Date: 2020-07-08T10:23:59+02:00 New Revision: cfcf8e17ef537686e03c58921a10593a2b0c4a3d URL: https://github.com/llvm/llvm-project/commit/cfcf8e17ef537686e03c58921a10593a2b0c4a3d DIFF: https://github.com/llvm/llvm-project/commit/cfcf8e17ef537686e03c58921a10593a2b0c4a3d.diff

[PATCH] D83174: Teach AttachPreviousImpl to inherit MSInheritanceAttr attribute

2020-07-08 Thread Vaibhav Garg via Phabricator via cfe-commits
gargvaibhav64 updated this revision to Diff 276351. gargvaibhav64 edited the summary of this revision. gargvaibhav64 added a comment. I incorporated the changes CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83174/new/ https://reviews.llvm.org/D83174 Files:

[PATCH] D83373: [analyzer][tests] Make test interruption safe

2020-07-08 Thread Valeriy Savchenko via Phabricator via cfe-commits
vsavchenko created this revision. vsavchenko added reviewers: NoQ, dcoughlin, xazax.hun. Herald added subscribers: cfe-commits, ASDenysPetrov, Charusso, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware. Herald added a project: clang. Repository:

[PATCH] D78478: [UpdateTestChecks] Add UTC_ARGS support for update_{llc,cc}_test_checks.py

2020-07-08 Thread Alexander Richardson via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGa80afc032859: [UpdateTestChecks] Add UTC_ARGS support for update_{llc,cc}_test_checks.py (authored by arichardson). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] a80afc0 - [UpdateTestChecks] Add UTC_ARGS support for update_{llc,cc}_test_checks.py

2020-07-08 Thread Alex Richardson via cfe-commits
Author: Alex Richardson Date: 2020-07-08T11:00:10+01:00 New Revision: a80afc032859ebe65af283f76b38a0f5921b683f URL: https://github.com/llvm/llvm-project/commit/a80afc032859ebe65af283f76b38a0f5921b683f DIFF:

[PATCH] D83201: [AST][RecoveryExpr] Fix the value category for recovery expr.

2020-07-08 Thread Haojian Wu via Phabricator via cfe-commits
hokein added inline comments. Comment at: clang/lib/Sema/SemaOverload.cpp:12944 + Fn->getBeginLoc(), RParenLoc, SubExprs, + ReturnType.isNull() + ? ReturnType sammccall wrote: > hokein wrote: > > sammccall wrote: > > > here we're splitting the

[PATCH] D83201: [AST][RecoveryExpr] Fix the value category for recovery expr.

2020-07-08 Thread Haojian Wu via Phabricator via cfe-commits
hokein updated this revision to Diff 276379. hokein marked 3 inline comments as done. hokein added a comment. address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83201/new/ https://reviews.llvm.org/D83201 Files:

[PATCH] D82157: Fix crash on `user defined literals`

2020-07-08 Thread Dmitri Gribenko via Phabricator via cfe-commits
gribozavr2 added a comment. > Fix crash on `user defined literals` WDYT: Implement support for user defined literals (which also fixes a crash) > Given an UserDefinedLiteral 1.2_w: > Problem: Lexer generates one Token for the literal, but ClangAST > references two source locations > Fix:

[PATCH] D83286: [analyzer][solver] Track symbol disequalities

2020-07-08 Thread Valeriy Savchenko via Phabricator via cfe-commits
vsavchenko added a comment. In D83286#2138734 , @ASDenysPetrov wrote: > Did you take into account that e.g. `a > b` also is a disequality. It is a very good point! I didn't take them into account (yet?) because they make the implementation a bit

[PATCH] D83301: [clang-tidy] More strict on matching the standard memset function in memset-usage check.

2020-07-08 Thread Haojian Wu via Phabricator via cfe-commits
hokein updated this revision to Diff 276405. hokein added a comment. add parameterCountIs(3). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83301/new/ https://reviews.llvm.org/D83301 Files:

[PATCH] D82954: Fix crash on overloaded postfix unary operators due to invalid SourceLocation

2020-07-08 Thread Dmitri Gribenko via Phabricator via cfe-commits
gribozavr2 added inline comments. Comment at: clang/unittests/Tooling/Syntax/TreeTest.cpp:2192 R"cpp( +class osstream {}; struct X { eduucaldas wrote: > gribozavr2 wrote: > > I don't think we need a separate class to show the left shift operator. The >

[clang] 96a5cff - [AST][RecoveryExpr] Fix the value category for recovery expr.

2020-07-08 Thread Haojian Wu via cfe-commits
Author: Haojian Wu Date: 2020-07-08T13:55:07+02:00 New Revision: 96a5cfff208d8e86a598e64412d9ef5dde0f9c9e URL: https://github.com/llvm/llvm-project/commit/96a5cfff208d8e86a598e64412d9ef5dde0f9c9e DIFF: https://github.com/llvm/llvm-project/commit/96a5cfff208d8e86a598e64412d9ef5dde0f9c9e.diff

[PATCH] D83201: [AST][RecoveryExpr] Fix the value category for recovery expr.

2020-07-08 Thread Haojian Wu via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG96a5cfff208d: [AST][RecoveryExpr] Fix the value category for recovery expr. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83201/new/

[PATCH] D82954: Fix crash on overloaded postfix unary operators due to invalid SourceLocation

2020-07-08 Thread Dmitri Gribenko via Phabricator via cfe-commits
gribozavr2 added inline comments. Comment at: clang/unittests/Tooling/Syntax/TreeTest.cpp:2192 R"cpp( +class osstream {}; struct X { eduucaldas wrote: > gribozavr2 wrote: > > eduucaldas wrote: > > > gribozavr2 wrote: > > > > I don't think we need a

[PATCH] D82547: [Debugify] Expose debugify (original mode) as CC1 option

2020-07-08 Thread Djordje Todorovic via Phabricator via cfe-commits
djtodoro updated this revision to Diff 276398. djtodoro added a comment. - Rebase on top of D83391 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82547/new/ https://reviews.llvm.org/D82547 Files: clang/include/clang/Basic/CodeGenOptions.def

[PATCH] D83008: Fix ItaniumRecordLayoutBuilder so that is grabs the correct bases class offsets from the external source

2020-07-08 Thread Shafik Yaghmour via Phabricator via cfe-commits
shafik added inline comments. Comment at: clang/lib/AST/RecordLayoutBuilder.cpp:2197 // least as many of them as possible). return RD->isTrivial() && RD->isCXX11StandardLayout(); } teemperor wrote: > See here for the POD check that we might get

[PATCH] D82954: Fix crash on overloaded postfix unary operators due to invalid SourceLocation

2020-07-08 Thread Eduardo Caldas via Phabricator via cfe-commits
eduucaldas updated this revision to Diff 276411. eduucaldas marked 2 inline comments as done. eduucaldas added a comment. minor fix comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82954/new/ https://reviews.llvm.org/D82954 Files:

[PATCH] D83386: clang: Don't show a trailing space with --version when not built from the repo

2020-07-08 Thread Sylvestre Ledru via Phabricator via cfe-commits
sylvestre.ledru created this revision. sylvestre.ledru added reviewers: thakis, hans. Herald added a project: clang. Reported here: https://bugs.llvm.org/show_bug.cgi?id=38998#c15 Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D83386 Files: clang/lib/Basic/Version.cpp

[PATCH] D82954: Fix crash on overloaded postfix unary operators due to invalid SourceLocation

2020-07-08 Thread Eduardo Caldas via Phabricator via cfe-commits
eduucaldas marked 2 inline comments as done. eduucaldas added inline comments. Comment at: clang/unittests/Tooling/Syntax/TreeTest.cpp:2192 R"cpp( +class osstream {}; struct X { gribozavr2 wrote: > eduucaldas wrote: > > gribozavr2 wrote: > > > I don't

[PATCH] D83286: [analyzer][solver] Track symbol disequalities

2020-07-08 Thread Denys Petrov via Phabricator via cfe-commits
ASDenysPetrov added a comment. @vsavchenko > if a != b and b == C where C is a constant, a != C Did you take into account that e.g. `a > b` also is a disequality. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83286/new/

[PATCH] D79842: [clang][Driver] Correct tool search path priority

2020-07-08 Thread David Spickett via Phabricator via cfe-commits
DavidSpickett added a comment. Right, I see the issue. The code that gets the default triple name (https://reviews.llvm.org/D13340?id=36227#inline-108606) looks up the one you have in cmake, not the actual default which you get in --version. We could "fix" this by doing so when we make the

[PATCH] D82659: Fix missing build dependency on omp_gen.

2020-07-08 Thread Valentin Clement via Phabricator via cfe-commits
clementval added a comment. In D82659#2138228 , @michele.scandale wrote: > In D82659#2136999 , @clementval > wrote: > > > Looks good but just one question ... When clang is built as standalone it > > does not

[PATCH] D83301: [clang-tidy] More strict on matching the standard memset function in memset-usage check.

2020-07-08 Thread Haojian Wu via Phabricator via cfe-commits
hokein added a comment. In D83301#2137140 , @njames93 wrote: > If you want to be super explicit. Why not add `parameterCountIs(3)`? good idea. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83301/new/

[PATCH] D78655: [CUDA][HIP] Let lambda be host device by default

2020-07-08 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl updated this revision to Diff 276417. yaxunl added a comment. revised by Artem's comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78655/new/ https://reviews.llvm.org/D78655 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td clang/include/clang/Sema/Sema.h

[PATCH] D81003: [clang] SequenceChecker: Also visit default arguments and default initializers.

2020-07-08 Thread Bruno Ricci via Phabricator via cfe-commits
riccibruno added a comment. @rsmith I have modified this patch to address your comment above (we should track where default argument(s) and/or default member initializer(s) were used). You accepted this originally but I would like to make sure that you are happy with the updated patch. I was

[PATCH] D81583: Update SystemZ ABI to handle C++20 [[no_unique_address]] attribute

2020-07-08 Thread Ulrich Weigand via Phabricator via cfe-commits
uweigand marked 6 inline comments as done. uweigand added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:521 + // [[no_unique_address]] attribute (since C++20). Those do count + // as empty according to the Itanium ABI. This property is currently + // only

[clang] bbea4d5 - clang: Don't show a trailing space with --version when not built from the repo

2020-07-08 Thread Sylvestre Ledru via cfe-commits
Author: Sylvestre Ledru Date: 2020-07-08T14:02:02+02:00 New Revision: bbea4d5e6b82a683dccaa8f4916e2a44f5dd3490 URL: https://github.com/llvm/llvm-project/commit/bbea4d5e6b82a683dccaa8f4916e2a44f5dd3490 DIFF:

[PATCH] D83386: clang: Don't show a trailing space with --version when not built from the repo

2020-07-08 Thread Sylvestre Ledru via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGbbea4d5e6b82: clang: Dont show a trailing space with --version when not built from the repo (authored by sylvestre.ledru). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D73242: [WPD/LowerTypeTests] Delay lowering/removal of type tests until after ICP

2020-07-08 Thread Eugene Leviant via Phabricator via cfe-commits
evgeny777 accepted this revision. evgeny777 added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73242/new/ https://reviews.llvm.org/D73242 ___ cfe-commits mailing list

[PATCH] D80514: [clang-tidy] modernize-use-trailing-return-type support for C++20 concepts and decltype

2020-07-08 Thread Bernhard Manfred Gruber via Phabricator via cfe-commits
bernhardmgruber added a comment. Ping. Is there anything I am not seeing here that you still would like me to do? I feel like you are waiting for something obvious from my side :S. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80514/new/ https://reviews.llvm.org/D80514

[PATCH] D82938: [clangd] Implement path and URI translation for remote index

2020-07-08 Thread Kirill Bobyrev via Phabricator via cfe-commits
kbobyrev marked 2 inline comments as done. kbobyrev added inline comments. Comment at: clang-tools-extra/clangd/unittests/remote/MarshallingTests.cpp:25 +const char *unittestURIToFilesystem(const char *UnittestURI, +llvm::UniqueStringSaver )

[PATCH] D82381: [analyzer] Introduce small improvements to the solver infra

2020-07-08 Thread Valeriy Savchenko via Phabricator via cfe-commits
vsavchenko marked 3 inline comments as done. vsavchenko added a comment. Hi @ASDenysPetrov no problem at all! Thanks for taking your time and checking it. Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:367-378 +RangeSet

[PATCH] D82756: Port some floating point options to new option marshalling infrastructure

2020-07-08 Thread Anastasia Stulova via Phabricator via cfe-commits
Anastasia added inline comments. Comment at: clang/include/clang/Driver/Options.td:1176 +defm reciprocal_math : OptInFFlag< "reciprocal-math", "Allow division operations to be reassociated", "", "", [], "LangOpts->AllowRecip">; +def fapprox_func : Flag<["-"], "fapprox-func">,

[PATCH] D83055: [clang][Driver] Fix tool path priority test failure

2020-07-08 Thread David Spickett via Phabricator via cfe-commits
DavidSpickett updated this revision to Diff 276406. DavidSpickett added a subscriber: stevewan. DavidSpickett added a comment. - Write to cmake and clang's default triple to also fix failure reported by @stevewan. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D83008: Fix ItaniumRecordLayoutBuilder so that is grabs the correct bases class offsets from the external source

2020-07-08 Thread Raphael Isemann via Phabricator via cfe-commits
teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. LGTM, thanks for the patch! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83008/new/ https://reviews.llvm.org/D83008 ___

[PATCH] D82954: Fix crash on overloaded postfix unary operators due to invalid SourceLocation

2020-07-08 Thread Dmitri Gribenko via Phabricator via cfe-commits
gribozavr2 accepted this revision. gribozavr2 added inline comments. Comment at: clang/lib/Tooling/Syntax/BuildTree.cpp:820 + // A postfix unary operator is declared as taking two operands. The + // second operand is used to differ from its prefix counterpart. In the +

[PATCH] D81583: Update SystemZ ABI to handle C++20 [[no_unique_address]] attribute

2020-07-08 Thread Ulrich Weigand via Phabricator via cfe-commits
uweigand updated this revision to Diff 276414. uweigand added a comment. Handle array of empty records correctly. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81583/new/ https://reviews.llvm.org/D81583 Files: clang/lib/CodeGen/TargetInfo.cpp clang/test/CodeGen/systemz-abi.cpp

[PATCH] D78478: [UpdateTestChecks] Add UTC_ARGS support for update_{llc,cc}_test_checks.py

2020-07-08 Thread Alexander Richardson via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGa80afc032859: [UpdateTestChecks] Add UTC_ARGS support for update_{llc,cc}_test_checks.py (authored by arichardson). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D82781: [OpenCL] Fix missing address space deduction in template variables

2020-07-08 Thread Ole Strohm via Phabricator via cfe-commits
olestrohm updated this revision to Diff 276369. olestrohm marked an inline comment as done. olestrohm added a comment. I've removed the comments calling for a fix because I no longer feel that this approach needs that. Given the code that already exists, and without changing too much of it,

[PATCH] D83013: [LPM] Port CGProfilePass from NPM to LPM

2020-07-08 Thread Hans Wennborg via Phabricator via cfe-commits
hans added a comment. In D83013#2137607 , @MaskRay wrote: > `Opts.getProfileUse() != CodeGenOptions::ProfileNone ` in > > Opts.CallGraphProfile = Opts.getProfileUse() != CodeGenOptions::ProfileNone > && >

[PATCH] D82781: [OpenCL] Fix missing address space deduction in template variables

2020-07-08 Thread Anastasia Stulova via Phabricator via cfe-commits
Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82781/new/ https://reviews.llvm.org/D82781 ___ cfe-commits mailing

[PATCH] D82547: [Debugify] Expose debugify (original mode) as CC1 option

2020-07-08 Thread Djordje Todorovic via Phabricator via cfe-commits
djtodoro marked an inline comment as done. djtodoro added inline comments. Comment at: clang/lib/CodeGen/BackendUtil.cpp:855 +class ClangCustomPassManager : public legacy::PassManager { +public: djtodoro wrote: > vsk wrote: > > Please factor out

[PATCH] D83071: Add support for options with two flags for controlling the same field.

2020-07-08 Thread Daniel Grumberg via Phabricator via cfe-commits
dang updated this revision to Diff 276400. dang added a comment. Split into two macro kinds. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83071/new/ https://reviews.llvm.org/D83071 Files: clang/include/clang/Driver/Options.td

[PATCH] D83362: Fix warning caused by __builtin_expect_with_probability was not handled in places such as constant folding

2020-07-08 Thread Erich Keane via Phabricator via cfe-commits
erichkeane added inline comments. Comment at: clang/test/Sema/builtin-expect-with-probability.cpp:12 + } +} // should not emit warn "control may reach end of non-void function" here since expr is constantly true, so the "if(__bui..)" should be constantly true condition and

[PATCH] D82157: Fix crash on `user defined literals`

2020-07-08 Thread Eduardo Caldas via Phabricator via cfe-commits
eduucaldas updated this revision to Diff 276361. eduucaldas added a comment. Reflect fix on RecursiveASTVisitor Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82157/new/ https://reviews.llvm.org/D82157 Files:

[PATCH] D83201: [AST][RecoveryExpr] Fix the value category for recovery expr.

2020-07-08 Thread Sam McCall via Phabricator via cfe-commits
sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/AST/ExprClassification.cpp:147 + case Expr::RecoveryExprClass: +return ClassifyExprValueKind(Lang, E, E->getValueKind());

[PATCH] D82938: [clangd] Implement path and URI translation for remote index

2020-07-08 Thread Kirill Bobyrev via Phabricator via cfe-commits
kbobyrev updated this revision to Diff 276366. kbobyrev marked 12 inline comments as done. kbobyrev added a comment. Store progress. Still WIP. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82938/new/ https://reviews.llvm.org/D82938 Files:

[PATCH] D82381: [analyzer] Introduce small improvements to the solver infra

2020-07-08 Thread Denys Petrov via Phabricator via cfe-commits
ASDenysPetrov added a comment. Hi @vsavchenko , sorry for the late review. Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:367-378 +RangeSet RangeSet::Delete(BasicValueFactory , Factory , + const llvm::APSInt ) const { +

[PATCH] D83206: [PATCH] [ARM] Add Cortex-A78 and Cortex-X1 Support for Clang and LLVM

2020-07-08 Thread Luke Geeson via Phabricator via cfe-commits
LukeGeeson updated this revision to Diff 276383. LukeGeeson marked 2 inline comments as done. LukeGeeson added a comment. Addressed Mikhail's feedback: Sorted CPU lists accordingly CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83206/new/ https://reviews.llvm.org/D83206 Files:

[PATCH] D82646: [MSP430] Align the _Complex ABI with current msp430-gcc

2020-07-08 Thread Anton Korobeynikov via Phabricator via cfe-commits
asl added inline comments. Comment at: clang/test/CodeGen/msp430-abi-complex.c:8 + +void complex_float_arg_first(float _Complex x, int n) { +// CHECK-LABEL: @complex_float_arg_first What's about Complex Int? Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D83206: [PATCH] [ARM] Add Cortex-A78 and Cortex-X1 Support for Clang and LLVM

2020-07-08 Thread Dave Green via Phabricator via cfe-commits
dmgreen added a comment. I would expect this to be very similar to https://reviews.llvm.org/rG8bf99f1e6f0f9b426d6060361ea6d9d47c1868d1, but some parts seems to be missing. Can you make sure that everything is included and in a sensible order. Comment at:

[PATCH] D82954: Fix crash on overloaded postfix unary operators due to invalid SourceLocation

2020-07-08 Thread Eduardo Caldas via Phabricator via cfe-commits
eduucaldas updated this revision to Diff 276408. eduucaldas marked an inline comment as done. eduucaldas added a comment. Switch to `TraverseCXXOperatorCallExpr` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82954/new/

[PATCH] D83008: Fix ItaniumRecordLayoutBuilder so that is grabs the correct bases class offsets from the external source

2020-07-08 Thread Shafik Yaghmour via Phabricator via cfe-commits
shafik updated this revision to Diff 276407. shafik added a comment. Moved from shell test CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83008/new/ https://reviews.llvm.org/D83008 Files: clang/lib/AST/RecordLayoutBuilder.cpp lldb/test/API/lang/cpp/alignas_base_class/Makefile

[PATCH] D83055: [clang][Driver] Fix tool path priority test failures

2020-07-08 Thread David Spickett via Phabricator via cfe-commits
DavidSpickett added a comment. For the record my logic here is that I could change the tool names to use the same name as --version. However that will break whatever mips toolchain needed this code in the first place. (https://reviews.llvm.org/D13340?id=36227#inline-108606) This default

[PATCH] D81583: Update SystemZ ABI to handle C++20 [[no_unique_address]] attribute

2020-07-08 Thread Ulrich Weigand via Phabricator via cfe-commits
uweigand marked 2 inline comments as done. uweigand added a comment. In D81583#2137277 , @efriedma wrote: > I'm tempted to say this is a bugfix for the implementation of > no_unique_address, and just fix it globally for all ABIs. We're never going > to

[PATCH] D78655: [CUDA][HIP] Let lambda be host device by default

2020-07-08 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl marked 3 inline comments as done. yaxunl added inline comments. Comment at: clang/lib/Sema/SemaCUDA.cpp:757-759 + // In host compilation, deferred diagnostics are only emitted for functions + // which are sure to be emitted on host side since there is no reliable + //

[PATCH] D83371: [clangd] Factor out some helper functions related to heuristic resolution in TargetFinder

2020-07-08 Thread Haojian Wu via Phabricator via cfe-commits
hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. thanks, looks good. Comment at: clang-tools-extra/clangd/FindTarget.cpp:64 +// resolves it to a CXXRecordDecl in which we can try name lookup. +CXXRecordDecl

[clang-tools-extra] a15d798 - [clangd] Improve serialization error messages. NFC

2020-07-08 Thread Sam McCall via cfe-commits
Author: Sam McCall Date: 2020-07-08T17:31:40+02:00 New Revision: a15d798594ae340b037efec2cdba5ec77221e7e7 URL: https://github.com/llvm/llvm-project/commit/a15d798594ae340b037efec2cdba5ec77221e7e7 DIFF: https://github.com/llvm/llvm-project/commit/a15d798594ae340b037efec2cdba5ec77221e7e7.diff

[PATCH] D82381: [analyzer] Introduce small improvements to the solver infra

2020-07-08 Thread Denys Petrov via Phabricator via cfe-commits
ASDenysPetrov added a comment. @vsavchenko Thank you. Despite of all of my nits, LGTM! Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:367-378 +RangeSet RangeSet::Delete(BasicValueFactory , Factory , + const llvm::APSInt ) const {

[clang] 1ba6fb9 - [clang] Fix a crash when passing a C structure of incompatible type to a function with a reference parameter.

2020-07-08 Thread Bruno Ricci via cfe-commits
Author: Aleksandr Platonov Date: 2020-07-08T16:57:54+01:00 New Revision: 1ba6fb9293967de21ae33be10603bf5ae0ce1c96 URL: https://github.com/llvm/llvm-project/commit/1ba6fb9293967de21ae33be10603bf5ae0ce1c96 DIFF:

[PATCH] D82805: [clang] Fix a crash on passing C structure of incompatible type to function with reference parameter

2020-07-08 Thread Bruno Ricci via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG1ba6fb929396: [clang] Fix a crash when passing a C structure of incompatible type to a… (authored by ArcsinX, committed by riccibruno). Changed prior to commit:

[clang] 3fa989d - DomTree: remove explicit use of DomTreeNodeBase::iterator

2020-07-08 Thread Nicolai Hähnle via cfe-commits
Author: Nicolai Hähnle Date: 2020-07-08T18:18:49+02:00 New Revision: 3fa989d4fd6b854209ba4e950d96b91d6d5797b4 URL: https://github.com/llvm/llvm-project/commit/3fa989d4fd6b854209ba4e950d96b91d6d5797b4 DIFF:

[PATCH] D83087: DomTree: remove explicit use of DomTreeNodeBase::iterator

2020-07-08 Thread Nicolai Hähnle via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG3fa989d4fd6b: DomTree: remove explicit use of DomTreeNodeBase::iterator (authored by nhaehnle). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83087/new/

[PATCH] D78655: [CUDA][HIP] Let lambda be host device by default

2020-07-08 Thread Artem Belevich via Phabricator via cfe-commits
tra accepted this revision. tra added a comment. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78655/new/ https://reviews.llvm.org/D78655 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D83211: Factor out call to EXTRACTOR in generateCC1CommandLine

2020-07-08 Thread Daniel Grumberg via Phabricator via cfe-commits
dang updated this revision to Diff 276466. dang added a comment. Rebase on top of latest changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83211/new/ https://reviews.llvm.org/D83211 Files: clang/lib/Frontend/CompilerInvocation.cpp Index:

[PATCH] D83364: [PowerPC][Power10] Implement Instruction definition and MC Tests for Load and Store VSX Vector with Zero or Sign Extend

2020-07-08 Thread Amy Kwan via Phabricator via cfe-commits
amyk accepted this revision as: amyk. amyk added a comment. This revision is now accepted and ready to land. This LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83364/new/ https://reviews.llvm.org/D83364

[PATCH] D83315: Turn arcmt-* options into a single option

2020-07-08 Thread Daniel Grumberg via Phabricator via cfe-commits
dang updated this revision to Diff 276438. dang added a comment. Instead of using a Separate option kind (-arcmt-action action) use a Joined kind (-arcmt-action=*) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83315/new/

[PATCH] D82739: Improve heuristic resolution of dependent types in TargetFinder

2020-07-08 Thread Haojian Wu via Phabricator via cfe-commits
hokein added a comment. In D82739#2138260 , @nridge wrote: > In D82739#2133155 , @hokein wrote: > > > looks like we use this heuristic for go-to-def, I think we might want to > > use it in more places, e.g.

[PATCH] D83087: DomTree: remove explicit use of DomTreeNodeBase::iterator

2020-07-08 Thread Nicolai Hähnle via Phabricator via cfe-commits
nhaehnle added a comment. In D83087#2134881 , @kuhar wrote: > modulo accidental formatting changes. I'm not aware of any. Some line breaks changed because "const_iterator" is longer than "iterator". Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D83402: ParsedAttrInfo: Change spelling to use StringRef instead of const char*

2020-07-08 Thread Marco Biasini via Phabricator via cfe-commits
biasmv created this revision. biasmv added reviewers: aaron.ballman, nikic. Herald added a project: clang. Herald added a subscriber: cfe-commits. Store available spellings for attributes as a StringRef instead of a naked const char*. On my machine, this seems to be slightly beneficial for

[PATCH] D83405: Factor out EXTRACTOR call

2020-07-08 Thread Daniel Grumberg via Phabricator via cfe-commits
dang created this revision. Herald added subscribers: cfe-commits, dexonsmith. Herald added a project: clang. Depends on D83071 Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D83405 Files: clang/lib/Frontend/CompilerInvocation.cpp Index:

[PATCH] D81583: Update SystemZ ABI to handle C++20 [[no_unique_address]] attribute

2020-07-08 Thread Ulrich Weigand via Phabricator via cfe-commits
uweigand added a comment. In D81583#2138127 , @qiucf wrote: > Thanks for this patch! > > If I understand correctly, only `isEmptyRecord`/`isEmptyField` and places > checking any field is zero bit-width may need change for this? Since >

[PATCH] D83079: [clang][aarch64] Generate preprocessor macros for -march=armv8.6a+sve.

2020-07-08 Thread Francesco Petrogalli via Phabricator via cfe-commits
fpetrogalli marked 2 inline comments as done. fpetrogalli added inline comments. Comment at: clang/lib/Driver/ToolChains/Arch/AArch64.cpp:369 + if (llvm::is_contained(Features, "+v8.6a")) { +if (!llvm::is_contained(Features, "-i8mm") && +

[clang-tools-extra] 69c22ed - [clangd] Enable reading config from files behind a flag

2020-07-08 Thread Sam McCall via cfe-commits
Author: Sam McCall Date: 2020-07-08T16:48:01+02:00 New Revision: 69c22edb7d30983f1bb9d21154e427ebcc5f699c URL: https://github.com/llvm/llvm-project/commit/69c22edb7d30983f1bb9d21154e427ebcc5f699c DIFF: https://github.com/llvm/llvm-project/commit/69c22edb7d30983f1bb9d21154e427ebcc5f699c.diff

[PATCH] D83233: [clangd] Enable reading config from files by default.

2020-07-08 Thread Sam McCall via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. sammccall marked an inline comment as done. Closed by commit rG69c22edb7d30: [clangd] Enable reading config from files behind a flag (authored by sammccall). Changed prior to commit:

[PATCH] D83364: [PowerPC][Power10] Implement Instruction definition and MC Tests for Load and Store VSX Vector with Zero or Sign Extend

2020-07-08 Thread Kamau Bridgeman via Phabricator via cfe-commits
kamaub accepted this revision. kamaub added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83364/new/ https://reviews.llvm.org/D83364 ___ cfe-commits mailing list

[clang] 6aab27b - [OpenMPIRBuilder][Fix] Move llvm::omp::types to OpenMPIRBuilder.

2020-07-08 Thread via cfe-commits
Author: sstefan1 Date: 2020-07-08T17:23:55+02:00 New Revision: 6aab27ba851f132f01ea8e87f92243918dc23cfd URL: https://github.com/llvm/llvm-project/commit/6aab27ba851f132f01ea8e87f92243918dc23cfd DIFF: https://github.com/llvm/llvm-project/commit/6aab27ba851f132f01ea8e87f92243918dc23cfd.diff

[clang] 7a7d50e - [clang][NFC] Also test for serialization in test/AST/ast-dump-APValue-*

2020-07-08 Thread Bruno Ricci via cfe-commits
Author: Bruno Ricci Date: 2020-07-08T16:39:11+01:00 New Revision: 7a7d50e1f0d84c701fd2aa1b84a73a3e194fb91a URL: https://github.com/llvm/llvm-project/commit/7a7d50e1f0d84c701fd2aa1b84a73a3e194fb91a DIFF: https://github.com/llvm/llvm-project/commit/7a7d50e1f0d84c701fd2aa1b84a73a3e194fb91a.diff

  1   2   3   >