[PATCH] D82157: Fix crash on `user defined literals`

2020-07-09 Thread Eduardo Caldas via Phabricator via cfe-commits
eduucaldas updated this revision to Diff 276637. eduucaldas marked 4 inline comments as done. eduucaldas added a comment. Add support for {Integer,Float,Char,String}UserDefinedLiteral Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82157/new/

[PATCH] D82157: Fix crash on `user defined literals`

2020-07-09 Thread Eduardo Caldas via Phabricator via cfe-commits
eduucaldas updated this revision to Diff 276638. eduucaldas added a comment. workaround size_t Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82157/new/ https://reviews.llvm.org/D82157 Files: clang/include/clang/Testing/TestClangConfig.h

[PATCH] D82938: [clangd] Implement path and URI translation for remote index

2020-07-09 Thread Kirill Bobyrev via Phabricator via cfe-commits
kbobyrev updated this revision to Diff 276646. kbobyrev added a comment. Rebase on top of master Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82938/new/ https://reviews.llvm.org/D82938 Files: clang-tools-extra/clangd/index/dex/dexp/Dexp.cpp

[PATCH] D77493: [clang-tidy] Add do-not-refer-atomic-twice check

2020-07-09 Thread Whisperity via Phabricator via cfe-commits
whisperity added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/DoNotReferAtomicTwiceCheck.cpp:38 + diag(MatchedRef->getExprLoc(), + "Do not refer to '%0' atomic variable twice in an expression") + << MatchedVar->getName();

[clang] 397c682 - Fix MSVC "not all control paths return a value" warning. NFC.

2020-07-09 Thread Simon Pilgrim via cfe-commits
Author: Simon Pilgrim Date: 2020-07-09T11:06:39+01:00 New Revision: 397c68202a990c80a71de2816cee413cd5b5865e URL: https://github.com/llvm/llvm-project/commit/397c68202a990c80a71de2816cee413cd5b5865e DIFF: https://github.com/llvm/llvm-project/commit/397c68202a990c80a71de2816cee413cd5b5865e.diff

[PATCH] D83215: [AST][RecoveryExpr] Clarify the documentation of RecoveryExpr.

2020-07-09 Thread Haojian Wu via Phabricator via cfe-commits
hokein updated this revision to Diff 276700. hokein marked 4 inline comments as done. hokein added a comment. refine the doc based on the review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83215/new/ https://reviews.llvm.org/D83215

[PATCH] D82938: [clangd] Implement path and URI translation for remote index

2020-07-09 Thread Kirill Bobyrev via Phabricator via cfe-commits
kbobyrev marked an inline comment as done. kbobyrev added inline comments. Comment at: clang-tools-extra/clangd/index/remote/marshalling/Marshalling.cpp:64 + if (ParsedURI->scheme() != "file") { +elog("Can not parse URI with scheme other than \"file\" {0}", URI); +

[PATCH] D81583: Update SystemZ ABI to handle C++20 [[no_unique_address]] attribute

2020-07-09 Thread Ulrich Weigand via Phabricator via cfe-commits
uweigand updated this revision to Diff 276650. uweigand added a comment. Drop AllowNoUniqueAddress parameter; address review comment. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81583/new/ https://reviews.llvm.org/D81583 Files: clang/lib/CodeGen/TargetInfo.cpp

[PATCH] D83407: [analyzer][StdLibraryFunctionsChecker] Add POSIX networking functions

2020-07-09 Thread Balázs Kéri via Phabricator via cfe-commits
balazske added a comment. Are not some functions missing from the list (`shutdown`, `sockatmark`, `socket`) (these come from )? And `getnameinfo` comes from with many other functions that are not added. Comment at:

[PATCH] D83436: [clangd] Fix error handling in config.yaml parsing.

2020-07-09 Thread Sam McCall via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGf36518637d7d: [clangd] Fix error handling in config.yaml parsing. (authored by sammccall). Changed prior to commit: https://reviews.llvm.org/D83436?vs=276574=276660#toc Repository: rG LLVM Github

[clang-tools-extra] f365186 - [clangd] Fix error handling in config.yaml parsing.

2020-07-09 Thread Sam McCall via cfe-commits
Author: Sam McCall Date: 2020-07-09T10:20:18+02:00 New Revision: f36518637d7dfe5f8e619db1bd65dc90c92b5afa URL: https://github.com/llvm/llvm-project/commit/f36518637d7dfe5f8e619db1bd65dc90c92b5afa DIFF: https://github.com/llvm/llvm-project/commit/f36518637d7dfe5f8e619db1bd65dc90c92b5afa.diff

[PATCH] D83374: [analyzer][tests] Fix zip unpacking

2020-07-09 Thread Valeriy Savchenko via Phabricator via cfe-commits
vsavchenko added a comment. In D83374#2139505 , @NoQ wrote: > I thought the OS always ignores those? Ok anyway fair enough! I thought so too, but it looks like `glob` works in mysterious ways Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D81676: [MSP430] Align the toolchain definition with the TI's msp430-gcc v9.2.0

2020-07-09 Thread Anatoly Trosinenko via Phabricator via cfe-commits
atrosinenko updated this revision to Diff 276686. atrosinenko added a comment. Just add the test on `-rtlib=compiler-rt` handling as everything other is ready for basic clang_rt.builtins support. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D82938: [clangd] Implement path and URI translation for remote index

2020-07-09 Thread Kirill Bobyrev via Phabricator via cfe-commits
kbobyrev updated this revision to Diff 276692. kbobyrev marked 15 inline comments as done. kbobyrev added a comment. Address post-LGTM round of comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82938/new/ https://reviews.llvm.org/D82938

[PATCH] D81676: [MSP430] Align the toolchain definition with the TI's msp430-gcc v9.2.0

2020-07-09 Thread Anatoly Trosinenko via Phabricator via cfe-commits
atrosinenko updated this revision to Diff 276693. atrosinenko added a comment. Just an automatic rebase to (possibly) fix failing "Apply patch" step. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81676/new/ https://reviews.llvm.org/D81676 Files:

[PATCH] D83419: [clangd] Add error() function for creating formatv-style llvm::Errors. NFC

2020-07-09 Thread Sam McCall via Phabricator via cfe-commits
sammccall added a comment. Honestly, I really dislike names in the style of makeError/createError. My favorite name for this would be Error (i.e. a constructor) but that would involve redesigning it (which is a good idea, but an impossible yak-shave). I guess makeError is still better than the

[PATCH] D82157: Fix crash on `user defined literals`

2020-07-09 Thread Eduardo Caldas via Phabricator via cfe-commits
eduucaldas marked 4 inline comments as done. eduucaldas added inline comments. Comment at: clang/include/clang/Tooling/Syntax/Nodes.h:347-357 +/// Expression for an unkonwn user-defined literal. C++ [lex.ext] +class UnknownUserDefinedLiteralExpression final +: public

[PATCH] D82756: Port some floating point options to new option marshalling infrastructure

2020-07-09 Thread Daniel Grumberg via Phabricator via cfe-commits
dang added inline comments. Comment at: clang/include/clang/Driver/Options.td:1176 +defm reciprocal_math : OptInFFlag< "reciprocal-math", "Allow division operations to be reassociated", "", "", [], "LangOpts->AllowRecip">; +def fapprox_func : Flag<["-"], "fapprox-func">, Group,

[PATCH] D82938: [clangd] Implement path and URI translation for remote index

2020-07-09 Thread Kirill Bobyrev via Phabricator via cfe-commits
kbobyrev updated this revision to Diff 276642. kbobyrev added a comment. Fix formatting on one line. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82938/new/ https://reviews.llvm.org/D82938 Files:

[PATCH] D75229: [clang-tidy] Add signal-in-multithreaded-program check

2020-07-09 Thread Whisperity via Phabricator via cfe-commits
whisperity added a comment. In general, the test files should be cleaned up. Comment at: clang-tools-extra/test/clang-tidy/checkers/bugprone-signal-in-multithreaded-program-config-std::thread.cpp:1 +// RUN: %check_clang_tidy %s bugprone-signal-in-multithreaded-program %t \

[PATCH] D83174: Teach AttachPreviousImpl to inherit MSInheritanceAttr attribute

2020-07-09 Thread Vaibhav Garg via Phabricator via cfe-commits
gargvaibhav64 updated this revision to Diff 276680. gargvaibhav64 marked 3 inline comments as done. gargvaibhav64 added a comment. Added a new attribute instead of using the previous one CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83174/new/ https://reviews.llvm.org/D83174 Files:

[PATCH] D82157: Fix crash on `user defined literals`

2020-07-09 Thread Eduardo Caldas via Phabricator via cfe-commits
eduucaldas updated this revision to Diff 276681. eduucaldas added a comment. Document proposed solution for treating raw literal operators and numeric template operators Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82157/new/

[PATCH] D82157: Fix crash on `user defined literals`

2020-07-09 Thread Dmitri Gribenko via Phabricator via cfe-commits
gribozavr2 added inline comments. Comment at: clang/lib/Tooling/Syntax/BuildTree.cpp:634 +// `SourceLocation`s. As a result one of these nodes has a valid +// `SourceLocation` that doesn't point to a token. +// eduucaldas wrote: > gribozavr2 wrote: >

[PATCH] D83213: [AST][RecoveryExpr] Don't set the instantiation-bit.

2020-07-09 Thread Haojian Wu via Phabricator via cfe-commits
hokein added a comment. I think this depends on how we interpret the instantiation-dependent bit. In clang, it currently has two semantics: 1. an expression (somehow) depends on a template parameter; 2. an expression is dependent; Prior to RecoveryExpression being added, 1 and 2 are equal, so

[PATCH] D83290: [clangd] Enable async preambles by default

2020-07-09 Thread Kadir Cetinkaya via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG1c7c5019a7ad: [clangd] Enable async preambles by default (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83290/new/

[clang-tools-extra] 1c7c501 - [clangd] Enable async preambles by default

2020-07-09 Thread Kadir Cetinkaya via cfe-commits
Author: Kadir Cetinkaya Date: 2020-07-09T10:57:45+02:00 New Revision: 1c7c5019a7adfb16e0449ffb1d0e10631998d854 URL: https://github.com/llvm/llvm-project/commit/1c7c5019a7adfb16e0449ffb1d0e10631998d854 DIFF:

[PATCH] D79437: [clang-tidy] Add fsetpos argument checker

2020-07-09 Thread Whisperity via Phabricator via cfe-commits
whisperity added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/bugprone-fsetpos-argument-check.cpp:1 +// RUN: %check_clang_tidy %s bugprone-fsetpos-argument-check %t + This is a C, not a C++ file, the extension should show it. In

[PATCH] D82157: Fix crash on `user defined literals`

2020-07-09 Thread Eduardo Caldas via Phabricator via cfe-commits
eduucaldas updated this revision to Diff 276678. eduucaldas added a comment. Polishing patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82157/new/ https://reviews.llvm.org/D82157 Files: clang/include/clang/Tooling/Syntax/Nodes.h

[PATCH] D82157: Fix crash on `user defined literals`

2020-07-09 Thread Eduardo Caldas via Phabricator via cfe-commits
eduucaldas added inline comments. Comment at: clang/lib/Tooling/Syntax/BuildTree.cpp:634 +// `SourceLocation`s. As a result one of these nodes has a valid +// `SourceLocation` that doesn't point to a token. +// gribozavr2 wrote: > "The semantic AST

[clang] 9e7fddb - [yaml][clang-tidy] Fix multiline YAML serialization

2020-07-09 Thread Dmitry Polukhin via cfe-commits
Author: Dmitry Polukhin Date: 2020-07-09T02:41:58-07:00 New Revision: 9e7fddbd36f567217255c1df1cb816b79f0250af URL: https://github.com/llvm/llvm-project/commit/9e7fddbd36f567217255c1df1cb816b79f0250af DIFF:

[PATCH] D80301: [yaml][clang-tidy] Fix multiline YAML serialization

2020-07-09 Thread Dmitry Polukhin via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG9e7fddbd36f5: [yaml][clang-tidy] Fix multiline YAML serialization (authored by DmitryPolukhin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80301/new/

[PATCH] D69318: [analyzer] Add SufficientSizeArrayIndexingChecker

2020-07-09 Thread Balázs Kéri via Phabricator via cfe-commits
balazske added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/SufficientSizeArrayIndexingChecker.cpp:27 +: public Checker> { + mutable std::unique_ptr BT; + gamesh411 wrote: > balazske wrote: > > The bug type can be initialized here: > >

[PATCH] D82938: [clangd] Implement path and URI translation for remote index

2020-07-09 Thread Kirill Bobyrev via Phabricator via cfe-commits
kbobyrev updated this revision to Diff 276647. kbobyrev added a comment. Replace Sym in Client response with a more generic name (it can be a reference). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82938/new/ https://reviews.llvm.org/D82938

[PATCH] D83055: [clang][Driver] Fix tool path priority test failures

2020-07-09 Thread David Spickett via Phabricator via cfe-commits
DavidSpickett updated this revision to Diff 276671. DavidSpickett added a comment. - Updated rm/mv command lines to account for $DEFAULT_TRIPLE being the same as %target_triple. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83055/new/

[PATCH] D83215: [AST][RecoveryExpr] Clarify the documentation of RecoveryExpr.

2020-07-09 Thread Haojian Wu via Phabricator via cfe-commits
hokein added inline comments. Comment at: clang/lib/AST/ComputeDependence.cpp:498 ExprDependence clang::computeDependence(RecoveryExpr *E) { - // Mark the expression as value- and instantiation- dependent to reuse - // existing suppressions for dependent code, e.g. avoiding -

[PATCH] D83294: [Fixed Point] Add codegen for fixed-point shifts.

2020-07-09 Thread Bevin Hansson via Phabricator via cfe-commits
ebevhan marked an inline comment as done. ebevhan added inline comments. Comment at: clang/lib/CodeGen/CGExprScalar.cpp:3603-3604 auto ResultFixedSema = Ctx.getFixedPointSemantics(ResultTy); - auto CommonFixedSema = LHSFixedSema.getCommonSemantics(RHSFixedSema, true); +

[PATCH] D83419: [clangd] Add error() function for creating formatv-style llvm::Errors. NFC

2020-07-09 Thread Sam McCall via Phabricator via cfe-commits
sammccall added a comment. In D83419#2140889 , @sammccall wrote: > Honestly, I really dislike names in the style of makeError/createError. Sorry, I should give some reasons here: - not discoverable (`error` is marginally better) - emphasis on

[PATCH] D82938: [clangd] Implement path and URI translation for remote index

2020-07-09 Thread Sam McCall via Phabricator via cfe-commits
sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Rest is just nits, thanks! Comment at: clang-tools-extra/clangd/index/remote/marshalling/Marshalling.cpp:38 +/// provided by the client. +llvm::Optional

[PATCH] D79773: [clang-format] Improve clang-formats handling of concepts

2020-07-09 Thread MyDeveloperDay via Phabricator via cfe-commits
MyDeveloperDay added a subscriber: klimek. MyDeveloperDay added a comment. This issue is caused by the presence of the `;` in the requires clause (`0)>;`) inside the template declaration template requires std::invocable...> struct [[nodiscard]] constant : std::bool_constant <

[PATCH] D80301: [yaml][clang-tidy] Fix multiline YAML serialization

2020-07-09 Thread Dmitry Polukhin via Phabricator via cfe-commits
DmitryPolukhin added a comment. @aaron.ballman - thank you for the review! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80301/new/ https://reviews.llvm.org/D80301 ___ cfe-commits mailing list

[PATCH] D83295: [Analyzer] Hotfix for various crashes in iterator checkers

2020-07-09 Thread Balogh , Ádám via Phabricator via cfe-commits
baloghadamsoftware updated this revision to Diff 276684. baloghadamsoftware edited the summary of this revision. baloghadamsoftware added a comment. Test added for the third fix in this patch. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83295/new/ https://reviews.llvm.org/D83295

[clang-tools-extra] 6a3b10e - [change-namespace][NFC] Clean up joinNamespaces

2020-07-09 Thread Nathan James via cfe-commits
Author: Nathan James Date: 2020-07-09T11:29:49+01:00 New Revision: 6a3b10e294feceb94064f32450de5c068a13dd03 URL: https://github.com/llvm/llvm-project/commit/6a3b10e294feceb94064f32450de5c068a13dd03 DIFF: https://github.com/llvm/llvm-project/commit/6a3b10e294feceb94064f32450de5c068a13dd03.diff

[clang-tools-extra] 93bb994 - [clangd] Implement path and URI translation for remote index

2020-07-09 Thread Kirill Bobyrev via cfe-commits
Author: Kirill Bobyrev Date: 2020-07-09T12:52:55+02:00 New Revision: 93bb9944cb577f0529636dc5acfba16026740962 URL: https://github.com/llvm/llvm-project/commit/93bb9944cb577f0529636dc5acfba16026740962 DIFF:

[PATCH] D82938: [clangd] Implement path and URI translation for remote index

2020-07-09 Thread Kirill Bobyrev via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG93bb9944cb57: [clangd] Implement path and URI translation for remote index (authored by kbobyrev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82938/new/

[PATCH] D82663: [CodeGen] Have CodeGen for fixed-point unsigned with padding emit signed operations.

2020-07-09 Thread Bevin Hansson via Phabricator via cfe-commits
ebevhan added a comment. In D82663#2140507 , @leonardchan wrote: > In D82663#2130355 , @ebevhan wrote: > > > Well, it's not so much as adding the bit, but adding the information that > > the bit exists. That means

[PATCH] D83419: [clangd] Add error() function for creating formatv-style llvm::Errors. NFC

2020-07-09 Thread Haojian Wu via Phabricator via cfe-commits
hokein added a comment. > Sorry, I should give some reasons here: These are sensible reasons. My only (not a strong) concern is that "error" is quite special, we need to be careful to choose it -- note that there is an `error` function in glibc which is used for error-reporting. maybe there

[PATCH] D83478: [OPENMP]Fix compiler crash for target data directive without actual target codegen.

2020-07-09 Thread Alexey Bataev via Phabricator via cfe-commits
ABataev created this revision. ABataev added a reviewer: jdoerfert. Herald added subscribers: sstefan1, guansong, yaxunl. Herald added a project: clang. Need to privatize addresses of the captured variables when trying to emit the body of the target data directive in no target codegen mode.

[PATCH] D83475: [analyzer] Add CTUImportCppThreshold for C++ files

2020-07-09 Thread Kristóf Umann via Phabricator via cfe-commits
Szelethus added a comment. I don't like this solution t much, but I respect the urgency, and since we don't introduce a compatibility issue, I trust we can remove this if we decide to change to TableGen. Post-commit LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D82657: [AST][RecoveryAST] Preserve the type by default for recovery expression.

2020-07-09 Thread Haojian Wu via Phabricator via cfe-commits
hokein updated this revision to Diff 276733. hokein added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82657/new/ https://reviews.llvm.org/D82657 Files: clang/lib/Frontend/CompilerInvocation.cpp

[PATCH] D82800: [OPENMP50] extend array section for stride (Parsing/Sema/AST)

2020-07-09 Thread Alexey Bataev via Phabricator via cfe-commits
ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82800/new/ https://reviews.llvm.org/D82800

[PATCH] D83295: [Analyzer] Hotfix for various crashes in iterator checkers

2020-07-09 Thread Kristóf Umann via Phabricator via cfe-commits
Szelethus added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/IteratorModeling.cpp:275-276 } else if (isRandomIncrOrDecrOperator(OK)) { +if (!BO->getRHS()->getType()->isIntegralOrEnumerationType()) + return; handlePtrIncrOrDecr(C, BO->getLHS(),

[PATCH] D83475: [analyzer] Add CTUImportCppThreshold for C++ files

2020-07-09 Thread Kristóf Umann via Phabricator via cfe-commits
Szelethus added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/AnalyzerOptions.def:48-50 #ifndef ANALYZER_OPTION_DEPENDS_ON_USER_MODE /// Create a new analyzer option, but dont generate a method for it in /// AnalyzerOptions. It's value depends on the

[PATCH] D83286: [analyzer][solver] Track symbol disequalities

2020-07-09 Thread Valeriy Savchenko via Phabricator via cfe-commits
vsavchenko updated this revision to Diff 276729. vsavchenko added a comment. Fix review remarks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83286/new/ https://reviews.llvm.org/D83286 Files:

[PATCH] D79773: [clang-format] Improve clang-formats handling of concepts

2020-07-09 Thread Manuel Klimek via Phabricator via cfe-commits
klimek added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:631-636 + else if (FormatTok->is(tok::arrow)) { +// Following the } we can find a trailing return type arrow +// as part of an implicit conversion constraint. +nextToken(); +

[clang] b444705 - Make helpers static. NFC.

2020-07-09 Thread Benjamin Kramer via cfe-commits
Author: Benjamin Kramer Date: 2020-07-09T13:48:56+02:00 New Revision: b44470547e2ec8a52abb67c3f538ecc49ee27970 URL: https://github.com/llvm/llvm-project/commit/b44470547e2ec8a52abb67c3f538ecc49ee27970 DIFF:

[PATCH] D72705: [analyzer] Added new checker 'alpha.unix.ErrorReturn'.

2020-07-09 Thread Kristóf Umann via Phabricator via cfe-commits
Szelethus added a comment. After reading @martong's comment D72705#2035844 and @balazske's comment D72705#2086994 , I think there is a need to argue across all paths of execution within the function, and as such

[PATCH] D83407: [analyzer][StdLibraryFunctionsChecker] Add POSIX networking functions

2020-07-09 Thread Gabor Marton via Phabricator via cfe-commits
martong added a comment. In D83407#2141075 , @balazske wrote: > Are not some functions missing from the list (`shutdown`, `sockatmark`, > `socket`) (these come from )? And `getnameinfo` comes from > with many other functions that are not added.

[PATCH] D83475: [analyzer] Add CTUImportCppThreshold for C++ files

2020-07-09 Thread Gabor Marton via Phabricator via cfe-commits
martong updated this revision to Diff 276722. martong marked an inline comment as done. martong added a comment. - Remove extra whitespace Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83475/new/ https://reviews.llvm.org/D83475 Files:

[clang] 31b0569 - make -fmodules-codegen and -fmodules-debuginfo work also with PCHs

2020-07-09 Thread Luboš Luňák via cfe-commits
Author: Luboš Luňák Date: 2020-07-09T15:22:26+02:00 New Revision: 31b05692cd33b6dcc39402169b36d895e1aa87f4 URL: https://github.com/llvm/llvm-project/commit/31b05692cd33b6dcc39402169b36d895e1aa87f4 DIFF: https://github.com/llvm/llvm-project/commit/31b05692cd33b6dcc39402169b36d895e1aa87f4.diff

[PATCH] D69778: Make -fmodules-codegen and -fmodules-debuginfo work also with precompiled headers

2020-07-09 Thread Luboš Luňák via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG31b05692cd33: make -fmodules-codegen and -fmodules-debuginfo work also with PCHs (authored by llunak). Changed prior to commit: https://reviews.llvm.org/D69778?vs=263839=276726#toc Repository: rG

[PATCH] D83475: [analyzer] Add CTUImportCppThreshold for C++ files

2020-07-09 Thread Endre Fülöp via Phabricator via cfe-commits
gamesh411 accepted this revision. gamesh411 added a comment. This revision is now accepted and ready to land. It will be interesting to see how different C and C++ projects will prove in terms of AST complexity, and Decl-size, but I understand that for now, these two options are necessary to

[PATCH] D83475: [analyzer] Add CTUImportCppThreshold for C++ files

2020-07-09 Thread Gabor Marton via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGd12d0b73f1c9: [analyzer] Add CTUImportCppThreshold for C++ files (authored by martong). Changed prior to commit: https://reviews.llvm.org/D83475?vs=276722=276727#toc Repository: rG LLVM Github

[clang] d12d0b7 - [analyzer] Add CTUImportCppThreshold for C++ files

2020-07-09 Thread Gabor Marton via cfe-commits
Author: Gabor Marton Date: 2020-07-09T15:36:33+02:00 New Revision: d12d0b73f1c9c3a711c5cc15266a2b493cd712e9 URL: https://github.com/llvm/llvm-project/commit/d12d0b73f1c9c3a711c5cc15266a2b493cd712e9 DIFF: https://github.com/llvm/llvm-project/commit/d12d0b73f1c9c3a711c5cc15266a2b493cd712e9.diff

[PATCH] D83407: [analyzer][StdLibraryFunctionsChecker] Add POSIX networking functions

2020-07-09 Thread Kristóf Umann via Phabricator via cfe-commits
Szelethus added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp:1735-1747 + if (!addToFunctionSummaryMap( + "accept", Summary(ArgTypes{IntTy, *StructSockaddrPtrRestrictTy, +

[PATCH] D83407: [analyzer][StdLibraryFunctionsChecker] Add POSIX networking functions

2020-07-09 Thread Gabor Marton via Phabricator via cfe-commits
martong updated this revision to Diff 276716. martong marked 2 inline comments as done and an inline comment as not done. martong added a comment. - Remove redundant line from test code Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83407/new/

[PATCH] D83362: Fix warning caused by __builtin_expect_with_probability was not handled in places such as constant folding

2020-07-09 Thread Zhi Zhuang via Phabricator via cfe-commits
LukeZhuang added a comment. Hi, could you please help me commit this change? Thank you very much! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83362/new/ https://reviews.llvm.org/D83362 ___ cfe-commits mailing list

[PATCH] D81583: Update SystemZ ABI to handle C++20 [[no_unique_address]] attribute

2020-07-09 Thread Alex Bradbury via Phabricator via cfe-commits
asb added a comment. This LGTM from a RISC-V perspective. I'll likely follow up with a RISC-V test case similar to the SystemZ one post-commit, but given this is really fixing a cross-platform ABI issue this seems non-urgent. Thanks for spotting and addressing this issue. CHANGES SINCE LAST

[PATCH] D83474: Add support for specifying only a denormalizer

2020-07-09 Thread Daniel Grumberg via Phabricator via cfe-commits
dang created this revision. dang added a reviewer: Bigcheese. Herald added subscribers: llvm-commits, cfe-commits, dexonsmith. Herald added projects: clang, LLVM. This commit adds a denormalyzer for optimization level. Depends on D83406 Repository: rG LLVM

[PATCH] D83407: [analyzer][StdLibraryFunctionsChecker] Add POSIX networking functions

2020-07-09 Thread Gabor Marton via Phabricator via cfe-commits
martong updated this revision to Diff 276715. martong added a comment. - Add getRestrictTy Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83407/new/ https://reviews.llvm.org/D83407 Files:

[PATCH] D83475: [analyzer] Add CTUImportCppThreshold for C++ files

2020-07-09 Thread Gabor Marton via Phabricator via cfe-commits
martong created this revision. martong added reviewers: gamesh411, Szelethus. Herald added subscribers: cfe-commits, ASDenysPetrov, steakhal, Charusso, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun, whisperity. Herald added a project: clang. The

[PATCH] D82087: AMDGPU/clang: Add builtins for llvm.amdgcn.ballot

2020-07-09 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl added inline comments. Comment at: clang/lib/Basic/Targets/AMDGPU.cpp:293 +"wavefrontsize32" : "wavefrontsize64"; + Features.insert(std::make_pair(DefaultWaveSizeFeature, true)); +} what's the default wave front size in backend for gfx10*

[PATCH] D83480: Refactored NumericLiteralParser to not require a Preprocessor

2020-07-09 Thread Dmitri Gribenko via Phabricator via cfe-commits
gribozavr created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. We would like to use NumericLiteralParser in the implementation of the syntax tree builder, and plumbing a preprocessor there seems inconvenient and superfluous. Repository: rG LLVM Github

[PATCH] D83475: [analyzer] Add CTUImportCppThreshold for C++ files

2020-07-09 Thread Endre Fülöp via Phabricator via cfe-commits
gamesh411 added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/AnalyzerOptions.def:333 +"for import when inlining functions during CTU analysis of C++ " +"source files. ", 8u) extra

[PATCH] D71124: [RISCV] support clang driver to select cpu

2020-07-09 Thread Kuan Hsu Chen (Zakk) via Phabricator via cfe-commits
khchen planned changes to this revision. khchen marked an inline comment as done. khchen added a comment. BTW, this patch depends on D77030 , which aim to avoid the forcing of any ProcessorModel to have `FeatureRVCHints` feature. But if we decide to keep the

[PATCH] D83295: [Analyzer] Hotfix for various crashes in iterator checkers

2020-07-09 Thread Kristóf Umann via Phabricator via cfe-commits
Szelethus accepted this revision. Szelethus added a comment. LGTM, but if we knowingly a subpar solution, we should make that clear in the surrounding code. I know the followup patch is around the corner, but just to be sure. Comment at:

[PATCH] D83407: [analyzer][StdLibraryFunctionsChecker] Add POSIX networking functions

2020-07-09 Thread Gabor Marton via Phabricator via cfe-commits
martong marked an inline comment as done. martong added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp:1735-1747 + if (!addToFunctionSummaryMap( + "accept", Summary(ArgTypes{IntTy, *StructSockaddrPtrRestrictTy, +

[PATCH] D83213: [AST][RecoveryExpr] Don't set the instantiation-bit.

2020-07-09 Thread Sam McCall via Phabricator via cfe-commits
sammccall added a comment. In D83213#2141387 , @hokein wrote: > I think this depends on how we interpret the instantiation-dependent bit. In > clang, it currently has two semantics: > > 1. an expression (somehow) depends on a template parameter; > 2. an

[PATCH] D82800: [OPENMP50] extend array section for stride (Parsing/Sema/AST)

2020-07-09 Thread Chi Chun Chen via Phabricator via cfe-commits
cchen added a comment. @ABataev , can you commit this patch for me when you have time? Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82800/new/ https://reviews.llvm.org/D82800 ___ cfe-commits

[PATCH] D83419: [clangd] Add error() function for creating formatv-style llvm::Errors. NFC

2020-07-09 Thread Sam McCall via Phabricator via cfe-commits
sammccall added a comment. In D83419#2141433 , @hokein wrote: > > Sorry, I should give some reasons here: > > These are sensible reasons. My only (not a strong) concern is that "error" is > quite special, we need to be careful to choose it -- note that

[PATCH] D82800: [OPENMP50] extend array section for stride (Parsing/Sema/AST)

2020-07-09 Thread Chi Chun Chen via Phabricator via cfe-commits
cchen added a comment. In D82800#2141819 , @ABataev wrote: > In D82800#2141818 , @cchen wrote: > > > @ABataev , can you commit this patch for me when you have time? Thanks. > > > I think you can request commit

[PATCH] D83426: Unbreak Clang standalone build.

2020-07-09 Thread Saleem Abdulrasool via Phabricator via cfe-commits
compnerd accepted this revision. compnerd added a comment. This revision is now accepted and ready to land. Seems reasonable to me, this seems like it would be useful to downstream packagers for Linux distros. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D83407: [analyzer][StdLibraryFunctionsChecker] Add POSIX networking functions

2020-07-09 Thread Gabor Marton via Phabricator via cfe-commits
martong updated this revision to Diff 276759. martong added a comment. - Reuse summaries with accept and other functions when sockaddr is a union of pointers Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83407/new/ https://reviews.llvm.org/D83407

[PATCH] D83407: [analyzer][StdLibraryFunctionsChecker] Add POSIX networking functions

2020-07-09 Thread Kristóf Umann via Phabricator via cfe-commits
Szelethus added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp:1735-1747 + if (!addToFunctionSummaryMap( + "accept", Summary(ArgTypes{IntTy, *StructSockaddrPtrRestrictTy, +

[PATCH] D83362: Fix warning caused by __builtin_expect_with_probability was not handled in places such as constant folding

2020-07-09 Thread Zhi Zhuang via Phabricator via cfe-commits
LukeZhuang added a comment. Thank you very much! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83362/new/ https://reviews.llvm.org/D83362 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] 67422e4 - [MSP430] Align the _Complex ABI with current msp430-gcc

2020-07-09 Thread Anatoly Trosinenko via cfe-commits
Author: Anatoly Trosinenko Date: 2020-07-09T18:28:48+03:00 New Revision: 67422e4294754e08f277b1ba22820487eb76b918 URL: https://github.com/llvm/llvm-project/commit/67422e4294754e08f277b1ba22820487eb76b918 DIFF:

[PATCH] D77493: [clang-tidy] Add do-not-refer-atomic-twice check

2020-07-09 Thread JF Bastien via Phabricator via cfe-commits
jfb added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/bugprone-do-not-refer-atomic-twice.cpp:10 +_Atomic int n2 = ATOMIC_VAR_INIT(0); +_Atomic(int) n3 = ATOMIC_VAR_INIT(0); + Can you cover `std::atomic` as well?

[PATCH] D82646: [MSP430] Align the _Complex ABI with current msp430-gcc

2020-07-09 Thread Anatoly Trosinenko via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG67422e429475: [MSP430] Align the _Complex ABI with current msp430-gcc (authored by atrosinenko). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82646/new/

[PATCH] D83480: Refactored NumericLiteralParser to not require a Preprocessor

2020-07-09 Thread Eduardo Caldas via Phabricator via cfe-commits
eduucaldas accepted this revision. eduucaldas added a comment. This revision is now accepted and ready to land. Additionally, consider applying a similar change to `CharLiteralParser`, for consistency. All the comments are just suggestions. Feel free to land this without answering them.

[clang] 4d4d903 - Fix warning caused by __builtin_expect_with_probability was not handled

2020-07-09 Thread Erich Keane via cfe-commits
Author: Zhi Zhuang Date: 2020-07-09T08:01:33-07:00 New Revision: 4d4d9037670a3537c14092807a717284ea0c4f92 URL: https://github.com/llvm/llvm-project/commit/4d4d9037670a3537c14092807a717284ea0c4f92 DIFF: https://github.com/llvm/llvm-project/commit/4d4d9037670a3537c14092807a717284ea0c4f92.diff

[PATCH] D83490: [cmake] Support running compiler-rt tests in CrossWinToARMLinux.cmake

2020-07-09 Thread Sergej Jaskiewicz via Phabricator via cfe-commits
broadwaylamb created this revision. broadwaylamb added a reviewer: vvereschaka. Herald added subscribers: cfe-commits, danielkiss, kristof.beyls, mgorny, dberris. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D83490 Files:

[PATCH] D83492: [OpenMP] Use common interface to access GPU Grid Values

2020-07-09 Thread Saiyedul Islam via Phabricator via cfe-commits
saiislam created this revision. saiislam added reviewers: jdoerfert, ABataev, JonChesterfield. Herald added subscribers: cfe-commits, sstefan1, guansong, yaxunl, jholewinski. Herald added a project: clang. Use common interface for accessing target specific GPU grid values in NVPTX OpenMP codegen

[PATCH] D82728: [clang] Add -Wsuggest-override

2020-07-09 Thread Logan Smith via Phabricator via cfe-commits
logan-5 added a comment. Feels like a dumb question, but I'm not sure if and how those build failures are related to this patch? They seem to involve completely separate parts of the LLVM project (and `.c` files to boot). Was it that the build was failing for an unrelated reason at the moment

[PATCH] D82436: [clangd] Implement textDocument/foldingRange

2020-07-09 Thread Sam McCall via Phabricator via cfe-commits
sammccall added a comment. Tests :-) Comment at: clang-tools-extra/clangd/Protocol.h:1522 +struct FoldingRange { + unsigned startLine; + llvm::Optional startCharacter; nit: =0 (and on endLine) Comment at:

[PATCH] D83295: [Analyzer] Hotfix for various crashes in iterator checkers

2020-07-09 Thread Endre Fülöp via Phabricator via cfe-commits
gamesh411 added a comment. @Szelethus thanks for being watchful, appreciated c: CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83295/new/ https://reviews.llvm.org/D83295 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D83480: Refactored NumericLiteralParser to not require a Preprocessor

2020-07-09 Thread Dmitri Gribenko via Phabricator via cfe-commits
gribozavr updated this revision to Diff 276740. gribozavr added a comment. Addressed code review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83480/new/ https://reviews.llvm.org/D83480 Files: clang/include/clang/Lex/LiteralSupport.h

[PATCH] D83480: Refactored NumericLiteralParser to not require a Preprocessor

2020-07-09 Thread Dmitri Gribenko via Phabricator via cfe-commits
gribozavr2 added inline comments. Comment at: clang/include/clang/Lex/LiteralSupport.h:57-59 - NumericLiteralParser(StringRef TokSpelling, - SourceLocation TokLoc, - Preprocessor ); eduucaldas wrote: > We don't need

[PATCH] D83362: Fix warning caused by __builtin_expect_with_probability was not handled in places such as constant folding

2020-07-09 Thread Erich Keane via Phabricator via cfe-commits
erichkeane closed this revision. erichkeane added a comment. Gah, misspelled differential revision. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83362/new/ https://reviews.llvm.org/D83362 ___ cfe-commits mailing list

[PATCH] D82767: clang-format: Explicitly use python3

2020-07-09 Thread serge via Phabricator via cfe-commits
serge-sans-paille added a comment. In D82767#2132903 , @MyDeveloperDay wrote: > We may not be consistent across all of LLVM > > $ find . -name '*.py' -print -exec /usr/bin/head -2 {} \; | grep "#!" | > sort | uniq -c > 6 #! /usr/bin/env python

[PATCH] D83295: [Analyzer] Hotfix for various crashes in iterator checkers

2020-07-09 Thread Balogh , Ádám via Phabricator via cfe-commits
baloghadamsoftware marked an inline comment as done. baloghadamsoftware added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/IteratorModeling.cpp:275-276 } else if (isRandomIncrOrDecrOperator(OK)) { +if

[PATCH] D83295: [Analyzer] Hotfix for various crashes in iterator checkers

2020-07-09 Thread Endre Fülöp via Phabricator via cfe-commits
gamesh411 accepted this revision. gamesh411 added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/StaticAnalyzer/Checkers/IteratorModeling.cpp:275-276 } else if (isRandomIncrOrDecrOperator(OK)) { +if

  1   2   3   >