[PATCH] D84494: [Analyzer] Use of BugType in DereferenceChecker (NFC).

2020-07-28 Thread Balázs Kéri via Phabricator via cfe-commits
balazske added inline comments. Comment at: clang/test/Analysis/Inputs/expected-plists/conditional-path-notes.c.plist:270 descriptionDereference of null pointer (loaded from variable x) - categoryLogic error + categoryMemory error typeDereference of null pointer

[PATCH] D84599: [clang-index] Use NamedDecl::getDeclName() instead of NamedDecl::printName in USRGenerator::EmitDeclName

2020-07-28 Thread Bruno Ricci via Phabricator via cfe-commits
riccibruno added a comment. The overloads of `NamedDecl::printName` are in D84658 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84599/new/ https://reviews.llvm.org/D84599

[PATCH] D84602: [MSP430] Expose msp430_builtin calling convention to C code

2020-07-28 Thread Anatoly Trosinenko via Phabricator via cfe-commits
atrosinenko added a comment. In D84602#2176584 , @rjmccall wrote: > Is there only one special calling convention, or is there any chance that > different builtin functions would use different conventions? It depends on how to define "builtin calling

[PATCH] D66035: [WebAssembly] WIP: Add support for reference types

2020-07-28 Thread Paulo Matos via Phabricator via cfe-commits
pmatos added a comment. Related work: https://reviews.llvm.org/D81977 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66035/new/ https://reviews.llvm.org/D66035 ___ cfe-commits mailing list

[PATCH] D84743: [Clang][AMDGCN] Universal device offloading macros header

2020-07-28 Thread Johannes Doerfert via Phabricator via cfe-commits
jdoerfert added reviewers: tra, MaskRay. jdoerfert added subscribers: MaskRay, tra. jdoerfert added a comment. I like this. I hope this is the start of splitting the `__cuda` headers into generic and specific code, right? @tra @MaskRay any objections on the direction?

[PATCH] D84736: [analyzer][RFC] Handle pointer difference of ElementRegion and SymbolicRegion

2020-07-28 Thread Balázs Benics via Phabricator via cfe-commits
steakhal created this revision. steakhal added reviewers: NoQ, vsavchenko, martong, baloghadamsoftware, ASDenysPetrov, xazax.hun, Szelethus. Herald added subscribers: cfe-commits, Charusso, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, whisperity. Herald added a project:

[PATCH] D79147: Switch to using -debug-info-kind=constructor as default (from =limited)

2020-07-28 Thread Russell Gallop via Phabricator via cfe-commits
russell.gallop added a comment. Hi, It looks like is causing one of the debuginfo-tests: llgdb-tests/nrvo-string.cpp to fail, run on Linux. Failure as below. I don't think the debuginfo-tests are run on any bot (but probably should be!). I bisected the failure back to this change. Please

[PATCH] D83961: [Analyzer] Fix bug report source locations in minimal output.

2020-07-28 Thread Balázs Kéri via Phabricator via cfe-commits
balazske added a comment. Then the current solution is good, print always end of the bug path. A change to the bug reporting component was made that caused reported position of bugs to change. New is the end of the path, old is the location set by the checker (`BugReport::getLocation` value).

[PATCH] D84473: Dump Accumulator

2020-07-28 Thread James Henderson via Phabricator via cfe-commits
jhenderson added a comment. Could the llvm-readobj bit be spun off into a separate review, please. As things stand it doesn't have any of its own testing, which should be added at the same time as adding support in the tool itself. The new option is also lacking any documentation in the

[PATCH] D84602: [MSP430] Expose msp430_builtin calling convention to C code

2020-07-28 Thread Anatoly Trosinenko via Phabricator via cfe-commits
atrosinenko added inline comments. Comment at: clang/include/clang/Basic/Attr.td:1465 + let Spellings = [Clang<"msp430_builtin">]; + let Documentation = [Undocumented]; +} aaron.ballman wrote: > No new, undocumented attributes, please. Or is this attribute not

[PATCH] D82898: [clang-tidy] Handled insertion only fixits when determining conflicts.

2020-07-28 Thread Nathan James via Phabricator via cfe-commits
njames93 updated this revision to Diff 281194. njames93 added a comment. Fix new lines in test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82898/new/ https://reviews.llvm.org/D82898 Files:

[PATCH] D77150: [Analyzer] New Option for ContainerModeling: AggressiveEraseModeling

2020-07-28 Thread Kristóf Umann via Phabricator via cfe-commits
Szelethus requested changes to this revision. Szelethus added a comment. This revision now requires changes to proceed. Let me double down -- just because we let some select people know about an option, I still don't think it should be user facing. I'm strongly against the philosophy that a

[PATCH] D84554: Use INTERFACE_COMPILE_OPTIONS to disable -Wsuggest-override for any target that links to gtest

2020-07-28 Thread Pavel Labath via Phabricator via cfe-commits
labath added a comment. In D84554#2176041 , @logan-5 wrote: > In D84554#2175012 , @labath wrote: > >> Could you elaborate on the lldb issue? I'd like to take a look at that... > > It looks like

[PATCH] D84658: [clang] Overload NamedDecl::printName to provide a user-friendly name for unnamed entities

2020-07-28 Thread Bruno Ricci via Phabricator via cfe-commits
riccibruno added a comment. Note that I am planning two improvements as a follow-up to this patch: - For a parameter `(unnamed variable at {{.*}}:: of type )` -> `(unnamed parameter at {{.*}}:: of type )` - For a lambda: - `(unnamed class at {{.*}}::)` -> `(lambda at {{.*}}::)` - For a

[clang] b81fd5a - [clang-format][NFC] Fix a Wdocumentation warning in TokenAnnotator.cpp

2020-07-28 Thread Bruno Ricci via cfe-commits
Author: Bruno Ricci Date: 2020-07-28T10:58:52+01:00 New Revision: b81fd5aeecd8047ef62348b67cab2cf9a1577d8e URL: https://github.com/llvm/llvm-project/commit/b81fd5aeecd8047ef62348b67cab2cf9a1577d8e DIFF: https://github.com/llvm/llvm-project/commit/b81fd5aeecd8047ef62348b67cab2cf9a1577d8e.diff

[PATCH] D84602: [MSP430] Expose msp430_builtin calling convention to C code

2020-07-28 Thread Anatoly Trosinenko via Phabricator via cfe-commits
atrosinenko updated this revision to Diff 281198. atrosinenko added a comment. Fix some review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84602/new/ https://reviews.llvm.org/D84602 Files: clang/include/clang/Basic/Attr.td

[PATCH] D84743: [Clang][AMDGCN] Universal device offloading macros header

2020-07-28 Thread Jon Chesterfield via Phabricator via cfe-commits
JonChesterfield added a reviewer: arsenm. JonChesterfield added a comment. Herald added a subscriber: wdng. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84743/new/ https://reviews.llvm.org/D84743 ___

[PATCH] D81865: [clang] Use string tables for static diagnostic descriptions

2020-07-28 Thread Nathan Froyd via Phabricator via cfe-commits
froydnj added a comment. In D81865#2176589 , @dblaikie wrote: > I believe this falls under the (using cppreference ( > https://en.cppreference.com/w/cpp/language/union ) , since it's a bit easier > to read) UB clause: " It's undefined behavior to read

[PATCH] D84182: [OPENMP]Fix PR46012: declare target pointer cannot be accessed in target region.

2020-07-28 Thread Alexey Bataev via Phabricator via cfe-commits
ABataev added a comment. In D84182#2178560 , @ye-luo wrote: > In D84182#2173578 , @grokos wrote: > >> @ABataev: >> >> After this patch was committed, I tried to run the following example: >> >> #include >> >>

[clang-tools-extra] 7bae318 - [clang-tidy][NFC] Make OptionsView methods as const where missing

2020-07-28 Thread Nathan James via cfe-commits
Author: Nathan James Date: 2020-07-28T14:52:43+01:00 New Revision: 7bae3188e08746566733148a4ceccdb3cf24e93b URL: https://github.com/llvm/llvm-project/commit/7bae3188e08746566733148a4ceccdb3cf24e93b DIFF: https://github.com/llvm/llvm-project/commit/7bae3188e08746566733148a4ceccdb3cf24e93b.diff

[PATCH] D80802: [RISCV] Upgrade RVV MC to v0.9.

2020-07-28 Thread Hsiangkai Wang via Phabricator via cfe-commits
HsiangKai added a comment. Thanks for your review, @fpallares. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80802/new/ https://reviews.llvm.org/D80802 ___ cfe-commits mailing list

[PATCH] D84678: [clang] False line number in a function definition with "void" parameter

2020-07-28 Thread Jaydeep Chauhan via Phabricator via cfe-commits
Jac1494 updated this revision to Diff 281202. Jac1494 added a comment. Addressed @riccibruno comments.Thanks CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84678/new/ https://reviews.llvm.org/D84678 Files: clang/lib/Sema/SemaType.cpp clang/test/Sema/void-argument.cpp Index:

[PATCH] D84182: [OPENMP]Fix PR46012: declare target pointer cannot be accessed in target region.

2020-07-28 Thread Ye Luo via Phabricator via cfe-commits
ye-luo added a comment. In D84182#2173578 , @grokos wrote: > @ABataev: > > After this patch was committed, I tried to run the following example: > > #include > > int *yptr; > > int main() { > int y[10]; > y[1] = 1; > yptr = [0]; >

[PATCH] D83224: [clangd] Move clang-tidy check modifications into ClangdServer

2020-07-28 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet added a comment. In D83224#2133457 , @njames93 wrote: > Do you think there should be a hidden command line option to disable > disabling blacklisted checks, purely to prevent hindering attempts to fix > these problematic checks. I would expect

[PATCH] D84697: [clangd] Use elog instead of llvm::errs, log instead of llvm::outs

2020-07-28 Thread Sam McCall via Phabricator via cfe-commits
sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/index/remote/server/Server.cpp:202 + // Use buffered stream to stderr. + llvm::errs().SetBuffered();

[PATCH] D84534: [AIX] Static init frontend recovery and backend support

2020-07-28 Thread Xiangling Liao via Phabricator via cfe-commits
Xiangling_L updated this revision to Diff 281240. Xiangling_L marked 4 inline comments as done. Xiangling_L added a comment. Created alias for sinit and sterm; Adjusted the testcase accordingly; CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84534/new/ https://reviews.llvm.org/D84534

[PATCH] D84306: [clang-format][NFC] Be more careful about the layout of FormatToken.

2020-07-28 Thread Bruno Ricci via Phabricator via cfe-commits
riccibruno added a comment. In D84306#2177985 , @MyDeveloperDay wrote: > Thank you for the patch, this LGTM, I think this kind of change should help > reduce memory usage and I feel improves the readability. Thanks for your review! Repository: rG

[PATCH] D84453: [clang-tidy] Suppress one unittest on macOS.

2020-07-28 Thread Nathan James via Phabricator via cfe-commits
njames93 added a comment. In D84453#2177665 , @NoQ wrote: > In D84453#2171548 , @njames93 wrote: > >> I was having issues with this test case under macos in D82188 >> . >> It would

[PATCH] D84534: [AIX] Static init frontend recovery and backend support

2020-07-28 Thread Xiangling Liao via Phabricator via cfe-commits
Xiangling_L marked 5 inline comments as done. Xiangling_L added inline comments. Comment at: clang/lib/CodeGen/ItaniumCXXABI.cpp:4609 +// their own llvm.global_dtors entry. +CGM.AddCXXStermFinalizerToGlobalDtor(StermFinalizer, 65535); + else jasonliu

[clang] eb10b06 - [clang] Pass the NamedDecl* instead of the DeclarationName into many diagnostics.

2020-07-28 Thread Bruno Ricci via cfe-commits
Author: Bruno Ricci Date: 2020-07-28T10:30:35+01:00 New Revision: eb10b065f2a870b425dcc2040b9955e0eee464b4 URL: https://github.com/llvm/llvm-project/commit/eb10b065f2a870b425dcc2040b9955e0eee464b4 DIFF: https://github.com/llvm/llvm-project/commit/eb10b065f2a870b425dcc2040b9955e0eee464b4.diff

[clang] f5acd11 - [clang-format][NFC] Be more careful about the layout of FormatToken.

2020-07-28 Thread Bruno Ricci via cfe-commits
Author: Bruno Ricci Date: 2020-07-28T10:30:28+01:00 New Revision: f5acd11d2c0ea228452aa5ed3abbc2c502009d56 URL: https://github.com/llvm/llvm-project/commit/f5acd11d2c0ea228452aa5ed3abbc2c502009d56 DIFF: https://github.com/llvm/llvm-project/commit/f5acd11d2c0ea228452aa5ed3abbc2c502009d56.diff

[PATCH] D84656: [clang] Pass the NamedDecl* instead of the DeclarationName into many diagnostics.

2020-07-28 Thread Bruno Ricci via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGeb10b065f2a8: [clang] Pass the NamedDecl* instead of the DeclarationName into many… (authored by riccibruno). Changed prior to commit:

[PATCH] D84306: [clang-format][NFC] Be more careful about the layout of FormatToken.

2020-07-28 Thread Bruno Ricci via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGf5acd11d2c0e: [clang-format][NFC] Be more careful about the layout of FormatToken. (authored by riccibruno). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] c0bd9fa - [Concepts] Fix ast dump for immediately declared constraint.

2020-07-28 Thread Haojian Wu via cfe-commits
Author: Haojian Wu Date: 2020-07-28T12:10:03+02:00 New Revision: c0bd9fa137c28a3ef833b46b7f9770b060275281 URL: https://github.com/llvm/llvm-project/commit/c0bd9fa137c28a3ef833b46b7f9770b060275281 DIFF: https://github.com/llvm/llvm-project/commit/c0bd9fa137c28a3ef833b46b7f9770b060275281.diff

[PATCH] D66035: [WebAssembly] WIP: Add support for reference types

2020-07-28 Thread Paulo Matos via Phabricator via cfe-commits
pmatos added a comment. There's also this line of work on opaque types that could be potentially interested but seems far from being landed: https://groups.google.com/g/llvm-dev/c/Dw_DYSXGFto/m/OzzK-CkGAwAJ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D84461: [Concepts] Fix ast dump for immediately declared constraint.

2020-07-28 Thread Haojian Wu via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGc0bd9fa137c2: [Concepts] Fix ast dump for immediately declared constraint. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84461/new/

[PATCH] D83088: Introduce CfgTraits abstraction

2020-07-28 Thread Matt Arsenault via Phabricator via cfe-commits
arsenm added inline comments. Comment at: clang/include/clang/Analysis/Analyses/Dominators.h:50 + + // Clang's CFG contains nullpointers for unreachable succesors, e.g. when an + // if statement's condition is always false, it's 'then' branch is represented

[PATCH] D66035: [WebAssembly] WIP: Add support for reference types

2020-07-28 Thread Paulo Matos via Phabricator via cfe-commits
pmatos updated this revision to Diff 281154. pmatos added a comment. Initial implementation of reference types in the WebAssembly backend Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66035/new/ https://reviews.llvm.org/D66035 Files:

[PATCH] D84602: [MSP430] Expose msp430_builtin calling convention to C code

2020-07-28 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added a comment. In D84602#2178328 , @atrosinenko wrote: > In D84602#2176592 , @aaron.ballman > wrote: > >> To be clear, I also don't have a problem with it, but if users aren't >> supposed to be

[PATCH] D84678: [clang] False line number in a function definition with "void" parameter

2020-07-28 Thread Bruno Ricci via Phabricator via cfe-commits
riccibruno added inline comments. Comment at: clang/test/Sema/void-argument.cpp:1 +// RUN: not %clang_cc1 %s 2>&1 | FileCheck %s + Jac1494 wrote: > riccibruno wrote: > > These kinds of tests are typically done with a `-verify` test. See the > > other tests in

[PATCH] D66035: [WebAssembly] WIP: Add support for reference types

2020-07-28 Thread Paulo Matos via Phabricator via cfe-commits
pmatos added a comment. Please ignore my `.gitlab-ci.yml`. That's just an internal change that I got uploaded by mistake. I am looking to see this through and start discussion on this with the goal of landing it. At the moment, for example this test crashes: struct {

[PATCH] D84602: [MSP430] Expose msp430_builtin calling convention to C code

2020-07-28 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/Attr.td:1465 + let Spellings = [Clang<"msp430_builtin">]; + let Documentation = [Undocumented]; +} atrosinenko wrote: > aaron.ballman wrote: > > No new, undocumented attributes, please.

[PATCH] D80917: [OpenMP][AMDGCN] Support OpenMP offloading for AMDGCN architecture - Part 2

2020-07-28 Thread Jon Chesterfield via Phabricator via cfe-commits
JonChesterfield added inline comments. Comment at: llvm/include/llvm/Frontend/OpenMP/OMPGridValues.h:66 + /// for NVPTX. + GV_Warp_Size_32, + /// The number of bits required to represent the max number of threads in warp What's the point of warp_size_32?

[clang] 984cf99 - [clang][NFC] Add some documentation about the use of NamedDecl::getDeclName in diagnostics.

2020-07-28 Thread Bruno Ricci via cfe-commits
Author: Bruno Ricci Date: 2020-07-28T15:39:17+01:00 New Revision: 984cf99055a292b3afe4535c013d38914a3da880 URL: https://github.com/llvm/llvm-project/commit/984cf99055a292b3afe4535c013d38914a3da880 DIFF: https://github.com/llvm/llvm-project/commit/984cf99055a292b3afe4535c013d38914a3da880.diff

[PATCH] D82739: [clangd] Improve heuristic resolution of dependent types in TargetFinder

2020-07-28 Thread Haojian Wu via Phabricator via cfe-commits
hokein added inline comments. Comment at: clang-tools-extra/clangd/FindTarget.cpp:172 std::vector resolveDependentExprToDecls(const Expr *E) { assert(E->isTypeDependent()); if (const auto *ME = dyn_cast(E)) { @nridge, the assertion is not true anymore,

[PATCH] D84743: [Clang][AMDGCN] Universal device offloading macros header

2020-07-28 Thread Saiyedul Islam via Phabricator via cfe-commits
saiislam created this revision. saiislam added reviewers: jdoerfert, ABataev, JonChesterfield. Herald added subscribers: cfe-commits, Anastasia. Herald added a project: clang. Harbormaster failed remote builds in B65994: Diff 281183! Harbormaster returned this revision to the author for changes

[PATCH] D82898: [clang-tidy] Handled insertion only fixits when determining conflicts.

2020-07-28 Thread Nathan James via Phabricator via cfe-commits
njames93 updated this revision to Diff 281200. njames93 added a comment. Replace if/else logic with switches Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82898/new/ https://reviews.llvm.org/D82898 Files:

[PATCH] D84794: Mark override to a function which overrides a virtual one

2020-07-28 Thread Anh Tuyen Tran via Phabricator via cfe-commits
anhtuyen created this revision. anhtuyen added reviewers: kbobyrev, bkramer, sammccall, logan-5. anhtuyen added a project: LLVM. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous. Herald added a project: clang. anhtuyen requested review of this revision. Function

[PATCH] D83722: [PowerPC] Add options to control paired vector memops support

2020-07-28 Thread Baptiste Saleil via Phabricator via cfe-commits
bsaleil updated this revision to Diff 281341. bsaleil added a comment. Update diff so it can be applied to master Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83722/new/ https://reviews.llvm.org/D83722 Files:

[PATCH] D84473: Dump Accumulator

2020-07-28 Thread Kazu Hirata via Phabricator via cfe-commits
kazu added a comment. In D84473#2178167 , @jhenderson wrote: > Could the llvm-readobj bit be spun off into a separate review, please. As > things stand it doesn't have any of its own testing, which should be added at > the same time as adding support in

[PATCH] D84422: [OpenMP] Fix `present` for exit from `omp target data`

2020-07-28 Thread Joel E. Denny via Phabricator via cfe-commits
jdenny marked an inline comment as done. jdenny added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:8843 llvm::Value *, llvm::Value *, -CGOpenMPRuntime::TargetDataInfo ) { +CGOpenMPRuntime::TargetDataInfo , bool ForEndCall = false) { +

[PATCH] D84782: [PGO] Include the mem ops into the function hash.

2020-07-28 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay added inline comments. Comment at: llvm/lib/Transforms/Instrumentation/PGOInstrumentation.cpp:623 // Compute Hash value for the CFG: the lower 32 bits are CRC32 of the index -// value of each BB in the CFG. The higher 32 bits record the number of edges. +// value of

[PATCH] D84782: [PGO] Include the mem ops into the function hash.

2020-07-28 Thread Hiroshi Yamauchi via Phabricator via cfe-commits
yamauchi added inline comments. Comment at: llvm/lib/Transforms/Instrumentation/PGOInstrumentation.cpp:623 // Compute Hash value for the CFG: the lower 32 bits are CRC32 of the index -// value of each BB in the CFG. The higher 32 bits record the number of edges. +// value of

[PATCH] D84767: [OPENMP]Fix PR46824: Global declare target pointer cannot be accessed in target region.

2020-07-28 Thread Ye Luo via Phabricator via cfe-commits
ye-luo added a comment. This patch GPU activities: 96.99% 350.05ms10 35.005ms 1.5680us 350.00ms [CUDA memcpy HtoD] before the July21 change GPU activities: 95.33% 20.317ms 4 5.0793ms 1.6000us 20.305ms [CUDA memcpy HtoD] Still more transfer than it should.

[clang] e22de4e - [DominatorTree] Simplify ChildrenGetter.

2020-07-28 Thread Alina Sbirlea via cfe-commits
Author: Alina Sbirlea Date: 2020-07-28T15:44:20-07:00 New Revision: e22de4e46d1dd1aacc3a7060d24bcbe89908ba6c URL: https://github.com/llvm/llvm-project/commit/e22de4e46d1dd1aacc3a7060d24bcbe89908ba6c DIFF: https://github.com/llvm/llvm-project/commit/e22de4e46d1dd1aacc3a7060d24bcbe89908ba6c.diff

[PATCH] D84713: [DominatorTree] Simplify ChildrenGetter.

2020-07-28 Thread Alina Sbirlea via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe22de4e46d1d: [DominatorTree] Simplify ChildrenGetter. (authored by asbirlea). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 80bd6ae - On Windows build, making the /bigobj flag global , instead of passing it per file.

2020-07-28 Thread Michael Kruse via cfe-commits
Author: Zahira Ammarguellat Date: 2020-07-28T18:04:36-05:00 New Revision: 80bd6ae13ea23d453a1f45d6ccdbfc7d0c877bb0 URL: https://github.com/llvm/llvm-project/commit/80bd6ae13ea23d453a1f45d6ccdbfc7d0c877bb0 DIFF:

[PATCH] D84038: On Windows build, making the /bigobj flag global , instead of passing it per file.

2020-07-28 Thread Michael Kruse via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG80bd6ae13ea2: On Windows build, making the /bigobj flag global , instead of passing it per… (authored by zahiraam, committed by Meinersbur). Herald added projects: clang, LLDB. Herald added subscribers:

[PATCH] D84467: Add support for Branch Coverage in LLVM Source-Based Code Coverage

2020-07-28 Thread Vedant Kumar via Phabricator via cfe-commits
vsk added a comment. I haven't taken a close look at the tests yet, but plan on getting to it soon. I'm not sure whether this is something you've already tried, but for this kind of change, it can be helpful to verify that a stage2 clang self-host with assertions enabled completes

[PATCH] D83115: [Analyzer] Report every bug if only uniqueing location differs.

2020-07-28 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ added a comment. Whoops, i meant to post the comment in https://reviews.llvm.org/rG22a084cfa337d5e5ea90eba5261f7937e28d250b#937772 here. Anyway, i found a crash caused by this patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83115/new/

[PATCH] D84811: [clangd] Add an option to exclude symbols outside of project root from index

2020-07-28 Thread Kirill Bobyrev via Phabricator via cfe-commits
kbobyrev created this revision. kbobyrev added a reviewer: hokein. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous. Herald added a project: clang. kbobyrev requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. This is useful for the remote index:

[PATCH] D84511: Fix update_cc_test_checks.py --llvm-bin after D78478

2020-07-28 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay accepted this revision. MaskRay added a comment. LGTM. Comment at: clang/test/utils/update_cc_test_checks/lit.local.cfg:24 +# works as expected +config.substitutions.append( +('%update_cc_test_checks_llvm_bin', "%s %s %s" % ( vitalybuka wrote: >

[PATCH] D84782: [PGO] Include the mem ops into the function hash.

2020-07-28 Thread David Li via Phabricator via cfe-commits
davidxl added a comment. changes like in llvm/test/Transforms/PGOProfile/PR41279.ll etc can be independently committed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84782/new/ https://reviews.llvm.org/D84782

[PATCH] D84711: [OpenMP] Implement TR8 `present` motion modifier in Clang (1/2)

2020-07-28 Thread Joel E. Denny via Phabricator via cfe-commits
jdenny updated this revision to Diff 281339. jdenny marked 4 inline comments as done. jdenny added a comment. Adjusted logic for rejecting `present` as requested. Rebased. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84711/new/ https://reviews.llvm.org/D84711 Files:

[clang] 389f009 - [NFC] Sema: use checkArgCount instead of custom checking

2020-07-28 Thread JF Bastien via cfe-commits
Author: JF Bastien Date: 2020-07-28T13:41:06-07:00 New Revision: 389f009c5757cf09c0b2d77a15b3b541fb0f2a1c URL: https://github.com/llvm/llvm-project/commit/389f009c5757cf09c0b2d77a15b3b541fb0f2a1c DIFF: https://github.com/llvm/llvm-project/commit/389f009c5757cf09c0b2d77a15b3b541fb0f2a1c.diff

[PATCH] D84711: [OpenMP] Implement TR8 `present` motion modifier in Clang (1/2)

2020-07-28 Thread Alexey Bataev via Phabricator via cfe-commits
ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84711/new/ https://reviews.llvm.org/D84711 ___ cfe-commits mailing list

[PATCH] D84666: [NFC] Sema: use checkArgCount instead of custom checking

2020-07-28 Thread JF Bastien via Phabricator via cfe-commits
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG389f009c5757: [NFC] Sema: use checkArgCount instead of custom checking (authored by jfb). Repository: rG LLVM Github

[PATCH] D84767: [OPENMP]Fix PR46824: Global declare target pointer cannot be accessed in target region.

2020-07-28 Thread Alexey Bataev via Phabricator via cfe-commits
ABataev updated this revision to Diff 281369. ABataev added a comment. Fixed ref count for base pointer + extra test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84767/new/ https://reviews.llvm.org/D84767 Files:

[PATCH] D84782: [PGO] Include the mem ops into the function hash.

2020-07-28 Thread David Li via Phabricator via cfe-commits
davidxl added a comment. We may also need to bump both the raw and index format version with this change. For the profile use side, we also need to keep the hashing scheme of the older version (in profile-use side). More details to come. Many tests can also be enhanced to filter out the hash

[PATCH] D84572: Allow .dSYM's to be directly placed in an alternate directory

2020-07-28 Thread Daniel Sanders via Phabricator via cfe-commits
dsanders updated this revision to Diff 281376. dsanders added a comment. Remove external- prefix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84572/new/ https://reviews.llvm.org/D84572 Files: clang/include/clang/Driver/Options.td

[PATCH] D84794: Mark override to a function which overrides a virtual one

2020-07-28 Thread Kirill Bobyrev via Phabricator via cfe-commits
kbobyrev accepted this revision. kbobyrev added a comment. This revision is now accepted and ready to land. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84794/new/ https://reviews.llvm.org/D84794

[PATCH] D84782: [PGO] Include the mem ops into the function hash.

2020-07-28 Thread Hiroshi Yamauchi via Phabricator via cfe-commits
yamauchi updated this revision to Diff 281407. yamauchi added a comment. Shift the higher 32 bits by 28 bits and add. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84782/new/ https://reviews.llvm.org/D84782 Files:

[PATCH] D84782: [PGO] Include the mem ops into the function hash.

2020-07-28 Thread Hiroshi Yamauchi via Phabricator via cfe-commits
yamauchi added a comment. > Many tests can also be enhanced to filter out the hash details if they are > not part the main test. Done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84782/new/ https://reviews.llvm.org/D84782

[PATCH] D73151: [analyzer] Fix handle leak false positive when the handle dies too early

2020-07-28 Thread Jon Roelofs via Phabricator via cfe-commits
jroelofs added inline comments. Comment at: clang/test/Analysis/fuchsia_handle.cpp:80 + zx_status_t status = zx_channel_create(0, , ); + // expected-note@-1 {{Handle allocated through 2nd parameter}} + if (status == 0) { // expected-note {{Assuming 'status' is equal to 0}}

[PATCH] D82898: [clang-tidy] Handled insertion only fixits when determining conflicts.

2020-07-28 Thread Nathan James via Phabricator via cfe-commits
njames93 updated this revision to Diff 281418. njames93 marked 2 inline comments as done. njames93 added a comment. Remove unreachable after switch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82898/new/ https://reviews.llvm.org/D82898 Files:

[PATCH] D82898: [clang-tidy] Handled insertion only fixits when determining conflicts.

2020-07-28 Thread Nathan James via Phabricator via cfe-commits
njames93 added inline comments. Comment at: clang-tools-extra/clang-tidy/ClangTidyDiagnosticConsumer.cpp:629 Priority = std::make_tuple(Begin, Type, -End, -ErrorSize, ErrorId); - else +return; + case ET_Insert: aaron.ballman wrote: >

[PATCH] D84782: [PGO] Include the mem ops into the function hash.

2020-07-28 Thread Hiroshi Yamauchi via Phabricator via cfe-commits
yamauchi added a comment. In D84782#2180432 , @davidxl wrote: > On version bump --- looks like FrontPGO has been bumping version for hashing > changes while IR PGO had not, so it is ok to leave the version unchanged > (current situation is also

[PATCH] D84782: [PGO] Include the mem ops into the function hash.

2020-07-28 Thread David Li via Phabricator via cfe-commits
davidxl added a comment. Can you split out the test changes and commit it separately? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84782/new/ https://reviews.llvm.org/D84782 ___ cfe-commits mailing

[PATCH] D84511: Fix update_cc_test_checks.py --llvm-bin after D78478

2020-07-28 Thread Vitaly Buka via Phabricator via cfe-commits
vitalybuka added a comment. LGTM as it fixes update_cc_test_checks.py Comment at: llvm/utils/update_cc_test_checks.py:116-126 +def infer_dependent_args(args): + if args.clang is None: +if args.llvm_bin is None: + args.clang = 'clang' +else: + args.clang =

[PATCH] D84782: [PGO] Include the mem ops into the function hash.

2020-07-28 Thread Hiroshi Yamauchi via Phabricator via cfe-commits
yamauchi updated this revision to Diff 281426. yamauchi added a comment. Rebase (converting one more test) and fixing a typo and whitespace. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84782/new/ https://reviews.llvm.org/D84782 Files:

[PATCH] D84743: [Clang][AMDGCN] Universal device offloading macros header

2020-07-28 Thread Artem Belevich via Phabricator via cfe-commits
tra added a comment. I'm not sure it's particularly useful, to be honest. CUDA code still needs to be compatible with NVCC so it can't be used in portable code like TF or other currently used CUDA libraries. It could be useful internally, though, so I'm fine with it for that purpose.

[clang] 394db22 - Revert "Switch to using -debug-info-kind=constructor as default (from =limited)"

2020-07-28 Thread Amy Huang via cfe-commits
Author: Amy Huang Date: 2020-07-28T11:23:59-07:00 New Revision: 394db2259575ef3cac8d3d37836b11eb2373c435 URL: https://github.com/llvm/llvm-project/commit/394db2259575ef3cac8d3d37836b11eb2373c435 DIFF: https://github.com/llvm/llvm-project/commit/394db2259575ef3cac8d3d37836b11eb2373c435.diff

[PATCH] D83997: [os_log] Improve the way we extend the lifetime of objects passed to __builtin_os_log_format

2020-07-28 Thread John McCall via Phabricator via cfe-commits
rjmccall added a comment. In D83997#2169745 , @ahatanak wrote: > The use case for this is a macro in which the call to > `__builtin_os_log_format` that writes to the buffer and the call that uses > the buffer appear in two different statements. For

[PATCH] D84202: [clang][noderef] Enable -Wnoderef warning for CXX C-style casts

2020-07-28 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added a comment. > users can still disable the warning on line granularity with pragmas. This makes me a bit uncomfortable because those pragmas extremely ugly (and not easily portable). Also, this will break code for users who were previously doing something that was explicitly

[PATCH] D81678: Introduce noundef attribute at call sites for stricter poison analysis

2020-07-28 Thread Gui Andrade via Phabricator via cfe-commits
guiand updated this revision to Diff 281311. guiand added a comment. Incorporate C++'s more conservative checks for omitted return values Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81678/new/ https://reviews.llvm.org/D81678 Files:

[PATCH] D84711: [OpenMP] Implement TR8 `present` motion modifier in Clang (1/2)

2020-07-28 Thread Joel E. Denny via Phabricator via cfe-commits
jdenny added inline comments. Comment at: clang/lib/Basic/OpenMPKinds.cpp:73-74 .Default(OMPC_MOTION_MODIFIER_unknown); +if (OpenMPVersion < 51 && Type != OMPC_MOTION_MODIFIER_mapper) + return OMPC_MOTION_MODIFIER_unknown; +return Type;

[PATCH] D84736: [analyzer][RFC] Handle pointer difference of ElementRegion and SymbolicRegion

2020-07-28 Thread Balázs Benics via Phabricator via cfe-commits
steakhal planned changes to this revision. steakhal added a comment. Thank you all for the comments. In D84736#2179828 , @NoQ wrote: > I think the overall idea is correct. So I will keep going in this direction, you can expect the more complex version

[PATCH] D84782: [PGO] Include the mem ops into the function hash.

2020-07-28 Thread Hiroshi Yamauchi via Phabricator via cfe-commits
yamauchi added inline comments. Comment at: llvm/lib/Transforms/Instrumentation/PGOInstrumentation.cpp:660 // information. - FunctionHash = (uint64_t)SIVisitor.getNumOfSelectInsts() << 56 | - (uint64_t)ValueSites[IPVK_IndirectCallTarget].size() << 48 | -

[PATCH] D84658: [clang] Overload NamedDecl::printName to provide a user-friendly name for unnamed entities

2020-07-28 Thread Bruno Ricci via Phabricator via cfe-commits
riccibruno updated this revision to Diff 281373. riccibruno added a comment. Add the forgotten context. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84658/new/ https://reviews.llvm.org/D84658 Files: clang/include/clang/AST/Decl.h

[PATCH] D84414: [RISCV] Support Shadow Call Stack

2020-07-28 Thread Z. Zheng via Phabricator via cfe-commits
zzheng updated this revision to Diff 281377. zzheng added a comment. rebased.. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84414/new/ https://reviews.llvm.org/D84414 Files: clang/lib/Driver/SanitizerArgs.cpp clang/lib/Driver/ToolChain.cpp

[PATCH] D81442: [PowerPC] Add clang options to control MMA support

2020-07-28 Thread Baptiste Saleil via Phabricator via cfe-commits
bsaleil updated this revision to Diff 281381. bsaleil added a comment. Update diff so it can be applied to master. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81442/new/ https://reviews.llvm.org/D81442 Files:

[PATCH] D84713: [DominatorTree] Simplify ChildrenGetter.

2020-07-28 Thread Alina Sbirlea via Phabricator via cfe-commits
asbirlea updated this revision to Diff 281382. asbirlea added a comment. Renamed ChildrenGet to getChildren. The same name only exists in GraphDiff, it's ok to keep a consistent naming. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84713/new/

[clang] 9cf98d2 - PR46637: Fix handling of placeholder types in trailing-return-types.

2020-07-28 Thread Richard Smith via cfe-commits
Author: Richard Smith Date: 2020-07-28T15:54:10-07:00 New Revision: 9cf98d26e7b1204478cc13ae3df44a6843965c11 URL: https://github.com/llvm/llvm-project/commit/9cf98d26e7b1204478cc13ae3df44a6843965c11 DIFF: https://github.com/llvm/llvm-project/commit/9cf98d26e7b1204478cc13ae3df44a6843965c11.diff

[PATCH] D84774: [NewPM][PassInstrument] Add PrintPass callback to StandardInstrumentations

2020-07-28 Thread Yuanfang Chen via Phabricator via cfe-commits
ychen updated this revision to Diff 281399. ychen added a comment. - Update `-debug-pass-manager-verbose` test. Some output should be ignored. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84774/new/ https://reviews.llvm.org/D84774 Files:

[PATCH] D84767: [OPENMP]Fix PR46824: Global declare target pointer cannot be accessed in target region.

2020-07-28 Thread Ye Luo via Phabricator via cfe-commits
ye-luo added a comment. In D84767#2180280 , @ye-luo wrote: > This patch > GPU activities: 96.99% 350.05ms10 35.005ms 1.5680us 350.00ms > [CUDA memcpy HtoD] > before the July21 change > GPU activities: 95.33% 20.317ms 4 5.0793ms

[PATCH] D84782: [PGO] Include the mem ops into the function hash.

2020-07-28 Thread David Li via Phabricator via cfe-commits
davidxl added a comment. On version bump --- looks like FrontPGO has been bumping version for hashing changes while IR PGO had not, so it is ok to leave the version unchanged (current situation is also confusing as the version of IR and FE PGO are mixed). On the other hand, just in case, we

[clang] 69fc33f - Revert "[OpenMP] Implement TR8 `present` motion modifier in Clang (1/2)"

2020-07-28 Thread Joel E. Denny via cfe-commits
Author: Joel E. Denny Date: 2020-07-28T20:30:05-04:00 New Revision: 69fc33f0cd130b02a38d2fc582afc7b0fcd6458a URL: https://github.com/llvm/llvm-project/commit/69fc33f0cd130b02a38d2fc582afc7b0fcd6458a DIFF: https://github.com/llvm/llvm-project/commit/69fc33f0cd130b02a38d2fc582afc7b0fcd6458a.diff

[PATCH] D84782: [PGO] Include the mem ops into the function hash.

2020-07-28 Thread Hiroshi Yamauchi via Phabricator via cfe-commits
yamauchi updated this revision to Diff 281364. yamauchi added a comment. Herald added subscribers: cfe-commits, dexonsmith, steven_wu. Herald added a project: clang. Use JamCRC. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84782/new/

[PATCH] D84782: [PGO] Include the mem ops into the function hash.

2020-07-28 Thread Hiroshi Yamauchi via Phabricator via cfe-commits
yamauchi added inline comments. Comment at: llvm/lib/Transforms/Instrumentation/PGOInstrumentation.cpp:642 // Hash format for context sensitive profile. Reserve 4 bits for other // information. davidxl wrote: > The comment looks stale. I think the 4 bits

[PATCH] D84710: [OpenMP][NFC] Consolidate `to` and `from` clause modifiers

2020-07-28 Thread Joel E. Denny via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa3d1f88fa7da: [OpenMP][NFC] Consolidate `to` and `from` clause modifiers (authored by jdenny). Repository: rG LLVM Github Monorepo CHANGES SINCE

  1   2   3   >