[PATCH] D82317: [Clang/Test]: Update tests where `noundef` attribute is necessary

guiand updated this revision to Diff 282328. guiand added a comment. Rebased; all tests passing again. Removed the change to the `ppc-*mmintrin.c` tests, instead I just use the -disable-noundef-args flag`. Cleaned up typos. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D85077: [clang][Tooling] Optimize addTargetAndMode in case of invalid modes

kadircet created this revision. kadircet added a reviewer: hokein. Herald added a project: clang. Herald added a subscriber: cfe-commits. kadircet requested review of this revision. This skips searching for `target` related flags in the existing args if we don't have a valid target to insert.

[PATCH] D84839: Add document outline symbols from unnamed contexts, e.g. extern "C".

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks, lgtm! let me know if i should land this for you Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84839/new/

[PATCH] D84839: Add document outline symbols from unnamed contexts, e.g. extern "C".

ilya-golovenko added a comment. In D84839#2189120 , @kadircet wrote: > thanks, lgtm! > > let me know if i should land this for you Thank you much for the review. I don't have commit access so could you please land it for me: Ilya Golovenko

[PATCH] D85028: [clangd] Support new/deleta operator in TargetFinder.

njames93 added inline comments. Comment at: clang-tools-extra/clangd/FindTarget.cpp:466-467 + } + void VisitCXXDeleteExpr(const CXXDeleteExpr *CNE) { +Outer.add(CNE->getOperatorDelete(), Flags); + } nit: Repository: rG LLVM Github

[PATCH] D85028: [clangd] Support new/deleta operator in TargetFinder.

kadircet added a comment. please note that this might require special handling for go-to-def. as go-to-def only jumps to canonical decl and in operator new's case the user provided one might not be canonical, whereas the canonical one is likely builtin without a source info. also you have a

[PATCH] D84987: Pass bugreport URL to standalone clang build

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. Verified. I added `CMAKE_PREFIX_PATH` to my `/tmp/RelA/CMakeCache.txt` and invoked `ninja install` (this installed a bunch of unrelated files. I don't know know how to just

[PATCH] D84814: [clang-tidy] readability-identifier-naming checks configs for included files

njames93 updated this revision to Diff 282379. njames93 marked 4 inline comments as done. njames93 added a comment. - Address comments. - Added test case for when this behaviour is disabled. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84814/new/

[PATCH] D85076: [clang][Tooling] Fix addTargetAndModeForProgramName to use correct flag names

kadircet created this revision. kadircet added a reviewer: hokein. Herald added a project: clang. Herald added a subscriber: cfe-commits. kadircet requested review of this revision. The logic was using incorrect flag versions. For example: - `-target=` can't be a prefix, it must be `--target=`.

[PATCH] D84898: [clang-tidy] Add new checker for complex conditions with no meaning

vabridgers added a comment. @njames93, I'll take a crack at implementing a cfe diagnostic for this, see how far I get. Cheers :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84898/new/ https://reviews.llvm.org/D84898

[PATCH] D84600: [Analyzer] Support note tags for smart ptr checker

NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/SmartPtrModeling.cpp:408-412 +SmallString<128> Msg; +llvm::raw_svector_ostream Out(Msg); +TagDetails.trackValidExpr(BR); +TagDetails.explainSmartPtrAction(Out); +

[PATCH] D84898: [clang-tidy] Add new checker for complex conditions with no meaning

njames93 added a comment. In D84898#2184931 , @vabridgers wrote: > I believe all review comments have been address, except for the discussion on > implementing this in the CFE or as a tidy check. Could try firing off an RFC to cfe-dev see if other

[PATCH] D84898: [clang-tidy] Add new checker for complex conditions with no meaning

vabridgers added a comment. Looks like this can be implemented as a warning in the cfe (as @lebedev.ri suggested). I'll probably abandon this review, but will keep it active until I have the alternative cfe warning patch prepared. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D84987: Pass bugreport URL to standalone clang build

MaskRay added a comment. In D84987#2186639 , @mgorny wrote: > In D84987#2186113 , @MaskRay wrote: > >> I am not familiar with the standalone clang build. Can you share a command? > > You install LLVM first, then

[PATCH] D84959: [NewPM][LVI] Abandon LVI after CVP

This revision was automatically updated to reflect the committed changes. Closed by commit rG25af353b0e74: [NewPM][LVI] Abandon LVI after CVP (authored by nikic). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang] 25af353 - [NewPM][LVI] Abandon LVI after CVP

Author: Nikita Popov Date: 2020-08-01T23:47:46+02:00 New Revision: 25af353b0e74907d5d50c8616b885bd1f73a68b3 URL: https://github.com/llvm/llvm-project/commit/25af353b0e74907d5d50c8616b885bd1f73a68b3 DIFF: https://github.com/llvm/llvm-project/commit/25af353b0e74907d5d50c8616b885bd1f73a68b3.diff

[PATCH] D84987: Pass bugreport URL to standalone clang build

mgorny added a comment. Is `RelA` an actual result of `install` target, or just the build tree? I think it needs to be the former. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84987/new/ https://reviews.llvm.org/D84987 ___ cfe-commits

[PATCH] D85084: [modules] Repro for pure virtual base class method crash

andrewjcg created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. andrewjcg requested review of this revision. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D85084 Files: clang/test/Modules/Inputs/set-pure-crash/a.h

[clang] 8dd4e3c - Updated the -I option description.

Author: Andrei Lebedev Date: 2020-08-01T15:54:11-07:00 New Revision: 8dd4e3ceb804a58bcf25e6856fc6fde5e1995a66 URL: https://github.com/llvm/llvm-project/commit/8dd4e3ceb804a58bcf25e6856fc6fde5e1995a66 DIFF:

[PATCH] D84814: [clang-tidy] readability-identifier-naming checks configs for included files

This revision was automatically updated to reflect the committed changes. Closed by commit rG4888c9ce97d8: [clang-tidy] readability-identifier-naming checks configs for included files (authored by njames93). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang-tools-extra] 4888c9c - [clang-tidy] readability-identifier-naming checks configs for included files

Author: Nathan James Date: 2020-08-01T10:35:32+01:00 New Revision: 4888c9ce97d8c20d988212b10f1045e3c4022b8e URL: https://github.com/llvm/llvm-project/commit/4888c9ce97d8c20d988212b10f1045e3c4022b8e DIFF: https://github.com/llvm/llvm-project/commit/4888c9ce97d8c20d988212b10f1045e3c4022b8e.diff

[PATCH] D84814: [clang-tidy] readability-identifier-naming checks configs for included files

njames93 updated this revision to Diff 282380. njames93 added a comment. Fix unpunctuated comment and simplify second check command. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84814/new/ https://reviews.llvm.org/D84814 Files:

[PATCH] D83188: [clang-tidy] bugprone-bool-pointer-implicit-conversion doesn't handle members

tetsuo-cpp added a comment. Friendly ping @njames93. Does this look ok to you? If so, could you please help me with the commit? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83188/new/ https://reviews.llvm.org/D83188 ___ cfe-commits mailing

[PATCH] D85071: [VE] Extend integer arguments and return values smaller than 64 bits

kaz7 created this revision. kaz7 added reviewers: simoll, k-ishizaka. kaz7 added projects: clang, VE. Herald added a subscriber: cfe-commits. kaz7 requested review of this revision. In order to follow NEC Aurora SX VE ABI correctly, change to sign/zero extend integer arguments and return values

[PATCH] D85074: [WebAssembly] Use "signed char" instead of "char" in SIMD intrinsics.

sunfish created this revision. sunfish added a reviewer: tlively. Herald added subscribers: jgravelle-google, sbc100, dschuff. Herald added a project: clang. sunfish requested review of this revision. Herald added a subscriber: aheejin. This allows people to use `int8_t` instead of `char`,

[clang-tools-extra] 9f21947 - [clang-tidy][NFC] Small refactor

Author: Nathan James Date: 2020-08-01T11:04:29+01:00 New Revision: 9f21947a331203ee2579db87f1d1ec22a949e20a URL: https://github.com/llvm/llvm-project/commit/9f21947a331203ee2579db87f1d1ec22a949e20a DIFF: https://github.com/llvm/llvm-project/commit/9f21947a331203ee2579db87f1d1ec22a949e20a.diff

[PATCH] D85033: [clang] Provide a better pretty-printed name for unnamed parameters, lambda classes and lambda captures.

riccibruno updated this revision to Diff 282391. riccibruno edited the summary of this revision. riccibruno added a comment. Don't forget to increment the field iterator in the loop of `maybePrintFieldForLambdaCapture`, and modify the tests to test this. Repository: rG LLVM Github Monorepo