[PATCH] D85016: [clang-format] Add space between method modifier and a tuple return type in C#

krasimir accepted this revision. krasimir added a comment. Thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85016/new/ https://reviews.llvm.org/D85016 ___ cfe-commits mailing list

[PATCH] D63640: [clang] Improve Serialization/Imporing of APValues

Tyker added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:11883-11885 ExprResult Result = ActOnFinishFullExpr(Init, VDecl->getLocation(), /*DiscardedValue*/ false, VDecl->isConstexpr()); rsmith wrote: > This may

[PATCH] D84979: [analyzer][NFC] Refine CStringLength modeling API

balazske added a comment. Really I am still not totally familiar how the checkers work and if it is good to have these function names. I was thinking about any checker that needs a string length information. It could get the data from CStringChecker using a "get" function or test if there is

[PATCH] D77150: [Analyzer] New Option for ContainerModeling: AggressiveEraseModeling

baloghadamsoftware updated this revision to Diff 282642. baloghadamsoftware added a comment. Option made hidden. However, I think we should create a category "advanced" for options which affect the internal modeling. Our users are programmers and the advanced among them should see this option

[PATCH] D85128: [Prototype][SVE] Support arm_sve_vector_bits attribute

tschuett added a comment. Stupid questions. - Is it for convenience? You get arrays, global variables, structs, ... . Vectorization becomes easier ... - Are there any potential performance benefits over scalable vectors? - Is it compatible with GCC? Repository: rG LLVM Github Monorepo

[PATCH] D77229: [Analyzer] Avoid handling of LazyCompundVals in IteratorModeling

baloghadamsoftware updated this revision to Diff 282626. baloghadamsoftware added a comment. Crash Fix: do not retrieve first iterator argument in advance. (It may happen that although argument count is more than zero, there is no argument at all.) CHANGES SINCE LAST ACTION

[PATCH] D85102: [clang] improve diagnostics for misaligned and large atomics

tschuett added a comment. I wanted to save space. I know that the alignment is missing there, but the line is already too long. I have no rights to commit. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85102/new/ https://reviews.llvm.org/D85102

[PATCH] D84246: [clang][LTO] Pass-through remarks options and set auto hotness threshold

weiwang added a comment. still waiting for inputs. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84246/new/ https://reviews.llvm.org/D84246 ___ cfe-commits mailing list

[PATCH] D81242: [StackSafety] Run ThinLTO

tejohnson added a comment. In D81242#2190041 , @vitalybuka wrote: > In D81242#2188467 , @tejohnson wrote: > >> In D81242#2188441 , @vitalybuka >> wrote: >> >>> In

[PATCH] D84540: [CodeGen][ObjC] Mark calls to objc_unsafeClaimAutoreleasedReturnValue as notail on x86-64

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84540/new/ https://reviews.llvm.org/D84540

[PATCH] D44536: Avoid segfault when destructor is not yet known

rjmccall added a comment. Would you like to pick it back up? We laid out an implementation path: we need to track the fact that a delete was of an incomplete class type in the AST and then unconditionally treat such operations as trivial to destroy in IRGen. Repository: rC Clang CHANGES

[PATCH] D85144: [clang] Improve Dumping of APValues

Tyker created this revision. Tyker added reviewers: rsmith, riccibruno. Herald added a project: clang. Herald added a subscriber: cfe-commits. Tyker requested review of this revision. this is required for proper testing of D63640 Repository: rG LLVM Github

[PATCH] D85076: [clang][Tooling] Fix addTargetAndModeForProgramName to use correct flag names

This revision was automatically updated to reflect the committed changes. Closed by commit rG87de54dbb6ef: [clang][Tooling] Fix addTargetAndModeForProgramName to use correct flag names (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 87de54d - [clang][Tooling] Fix addTargetAndModeForProgramName to use correct flag names

Author: Kadir Cetinkaya Date: 2020-08-03T11:46:58+02:00 New Revision: 87de54dbb6efa0fc5e304f94b350a39066bc2759 URL: https://github.com/llvm/llvm-project/commit/87de54dbb6efa0fc5e304f94b350a39066bc2759 DIFF:

[PATCH] D85077: [clang][Tooling] Optimize addTargetAndMode in case of invalid modes

hokein added inline comments. Comment at: clang/lib/Tooling/Tooling.cpp:264 + // No need to search for target args if we don't have a mode to insert. + bool AlreadyHasTarget = !TargetMode.TargetIsValid; bool AlreadyHasMode = false; kadircet wrote: > hokein

[PATCH] D74436: Change clang option -ffp-model=precise to select ffp-contract=on

lebedev.ri requested changes to this revision. lebedev.ri added a comment. This revision now requires changes to proceed. In D74436#2190422 , @fhahn wrote: > IIUC the patch is currently reverted (in > 78654e8511cf16d49f6680d782f3771a767ba942 >

[clang] ed0e4c7 - [clang][ARM] Add name-mangling test for direct __fp16 arguments.

Author: Simon Tatham Date: 2020-08-03T13:30:50+01:00 New Revision: ed0e4c70c99d3afd87fb202ab03bda40512677e7 URL: https://github.com/llvm/llvm-project/commit/ed0e4c70c99d3afd87fb202ab03bda40512677e7 DIFF: https://github.com/llvm/llvm-project/commit/ed0e4c70c99d3afd87fb202ab03bda40512677e7.diff

[PATCH] D85010: [clang][ARM] Add name-mangling test for direct __fp16 arguments.

This revision was automatically updated to reflect the committed changes. Closed by commit rGed0e4c70c99d: [clang][ARM] Add name-mangling test for direct __fp16 arguments. (authored by simon_tatham). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D83190: [analyzer] Model iterator random incrementation symmetrically

baloghadamsoftware added a comment. In D83190#2164361 , @gamesh411 wrote: > I experienced 2 crashes with and without this patch using commit > `1af9fc82132da7c876e8f70c4e986cc9c59010ee` on master: > I have used the clang built on that revision to analyse

[PATCH] D85102: [clang] improve diagnostics for misaligned and large atomics

tschuett updated this revision to Diff 282637. tschuett added a comment. added missing "alignment" CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85102/new/ https://reviews.llvm.org/D85102 Files: clang/include/clang/Basic/DiagnosticFrontendKinds.td

[PATCH] D84782: [PGO] Include the mem ops into the function hash.

MaskRay added a subscriber: hans. MaskRay added a comment. @yamauchi Do we need cd890944ad344b1b8cac58332ab11c9eec6b61e9 and 3d6f53018f845e893ad34f64ff2851a2e5c3ba1d

[PATCH] D63640: [clang] Improve Serialization/Imporing/Dumping of APValues

Tyker updated this revision to Diff 282682. Tyker edited the summary of this revision. Tyker added a comment. Sorry for the delay In D63640#2151016 , @rsmith wrote: > Are we at a point where we can test this now? Yes we can use consteval to test it. so

[PATCH] D84820: [WebAssembly] Implement prototype v128.load{32,64}_zero instructions

tlively updated this revision to Diff 282680. tlively added a comment. - Renumber i32x4.dot_i16x8_s to match V8 as well Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84820/new/ https://reviews.llvm.org/D84820 Files:

[PATCH] D79744: clang: Use byref for aggregate kernel arguments

rjmccall added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:1997 case ABIArgInfo::Ignore: + case ABIArgInfo::IndirectAliased: return false; arsenm wrote: > rjmccall wrote: > > In principle, this can be `inreg` just as much as Indirect

[PATCH] D76604: [Analyzer] Model `size()` member function of containers

baloghadamsoftware updated this revision to Diff 282675. baloghadamsoftware added a comment. Rebased. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76604/new/ https://reviews.llvm.org/D76604 Files: clang/lib/StaticAnalyzer/Checkers/ContainerModeling.cpp

Re: [PATCH] D84703: [clang codegen][AArch64] Use llvm.aarch64.neon.fcvtzs/u where it's necessary

Hey Eli, Looks like this is causing the test-suite build to fail. Can you please take a look. Refer to http://green.lab.llvm.org/green/job/test-suite-verify-machineinstrs-aarch64-O3/8035/consoleFull

[PATCH] D85118: [clang][AArch64] Correct return type of Neon vqmovun intrinsics

efriedma added a comment. Would it be worth looking into improving our general test coverage here? The fact that we don't have any test that verifies the actual signatures of the NEON intrinsics (which could be used to compare against other compilers) seems bad. Repository: rG LLVM Github

[PATCH] D77697: libc++: adjust modulemap for non-modular C

compnerd abandoned this revision. compnerd added a comment. Given that the original motivation here was to help with NetBSD, and the submodule visibility flag handling unblocks NetBSD, I think that I will hold off on this unless some other motivation arises. Repository: rG LLVM Github

[PATCH] D84844: [OpenMP] Ensure testing for versions 4.5, 5.0, and default - Part 1

saiislam updated this revision to Diff 282678. saiislam added a comment. Removed redundant testing for version 5.0 with its version string. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84844/new/ https://reviews.llvm.org/D84844 Files:

[clang] 10851f9 - [analyzer][tests] Fix SATest update functionality

Author: Valeriy Savchenko Date: 2020-08-03T18:21:15+03:00 New Revision: 10851f9db5f7d163135374b8dfc945e1b4a9c7d6 URL: https://github.com/llvm/llvm-project/commit/10851f9db5f7d163135374b8dfc945e1b4a9c7d6 DIFF:

[PATCH] D84303: [analyzer][tests] Fix SATest update functionality

This revision was automatically updated to reflect the committed changes. Closed by commit rG10851f9db5f7: [analyzer][tests] Fix SATest update functionality (authored by vsavchenko). Herald added a subscriber: steakhal. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D85102: [clang] improve diagnostics for misaligned and large atomics

jfb accepted this revision. jfb added inline comments. This revision is now accepted and ready to land. Comment at: clang/test/CodeGen/atomics-sema-alignment.c:43 + Foo bar; + __atomic_load(foo, , __ATOMIC_RELAXED); // expected-warning {{misaligned atomic operation may incur

[PATCH] D81865: [clang] Use string tables for static diagnostic descriptions

froydnj added a comment. Ping for an opinion on the recent discussion of how to move forward with this patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81865/new/ https://reviews.llvm.org/D81865

[PATCH] D83261: [OPENMP]Redesign of OMPExecutableDirective representation.

riccibruno added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:345 Diag(Loc, diag::err_omp_declare_mapper_wrong_var) -<< DMD->getVarName().getAsString(); +<< getOpenMPDeclareMapperVarName(); Diag(D->getLocation(),

[PATCH] D85144: [clang] Improve Dumping of APValues

Tyker updated this revision to Diff 282687. Tyker added a comment. remove unintended code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85144/new/ https://reviews.llvm.org/D85144 Files: clang/include/clang/AST/APValue.h

[PATCH] D85113: [ABI][NFC] Fix the confusion of ByVal and ByRef argument names

atrosinenko created this revision. atrosinenko added reviewers: majnemer, rjmccall, jpienaar. Herald added a project: clang. atrosinenko requested review of this revision. The second argument of getNaturalAlignIndirect() was `bool ByRef`, but the implementation was just delegating to

[PATCH] D75229: [clang-tidy] Add signal-in-multithreaded-program check

whisperity added a comment. In D75229#2189666 , @abelkocsis wrote: > I have managed to improve the checker, but could not set up the test files to > work only in POSIX platforms. Could you help me or show me an example? It's more so that, if I

[PATCH] D74436: Change clang option -ffp-model=precise to select ffp-contract=on

lebedev.ri added a comment. In D74436#2190492 , @lebedev.ri wrote: > <...> And by codegen changes i mostly mean newly-set/now-unset fp fast-math instruction flags. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D85034: [analyzer] Simplify functions SVal::getAsSymbolicExpression and similar ones

vsavchenko added a comment. > Ready! Sorry, I remember, you've already told me. Nothing to be sorry about! It's really not that big of a deal. Thanks again! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85034/new/

[PATCH] D85077: [clang][Tooling] Optimize addTargetAndMode in case of invalid modes

kadircet added inline comments. Comment at: clang/lib/Tooling/Tooling.cpp:264 + // No need to search for target args if we don't have a mode to insert. + bool AlreadyHasTarget = !TargetMode.TargetIsValid; bool AlreadyHasMode = false; hokein wrote: > While

[PATCH] D84136: [clang] Fix visitation of ConceptSpecializationExpr in constrained-parameter

hokein added a subscriber: rsmith. hokein added inline comments. Comment at: clang/include/clang/AST/RecursiveASTVisitor.h:1843 + if (const auto *TC = D->getTypeConstraint()) { +TRY_TO(TraverseStmt(TC->getImmediatelyDeclaredConstraint()));

[PATCH] D85034: [analyzer] Simplify functions SVal::getAsSymbolicExpression and similar ones

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG86e1b73507f3: [analyzer] Simplify function SVal::getAsSymbolicExpression and similar ones (authored by ASDenysPetrov). Repository: rG LLVM Github

[clang] 86e1b73 - [analyzer] Simplify function SVal::getAsSymbolicExpression and similar ones

Author: Denys Petrov Date: 2020-08-03T15:03:35+03:00 New Revision: 86e1b73507f3738f10eefb580d7c5e9adf17c6c0 URL: https://github.com/llvm/llvm-project/commit/86e1b73507f3738f10eefb580d7c5e9adf17c6c0 DIFF: https://github.com/llvm/llvm-project/commit/86e1b73507f3738f10eefb580d7c5e9adf17c6c0.diff

[PATCH] D83717: [clang-tidy] Add check fo SEI CERT item ENV32-C

whisperity added inline comments. Comment at: clang-tools-extra/clang-tidy/cert/ExitHandlerCheck.cpp:33 +bool isExitFunction(StringRef FnName) { + return FnName == "_Exit" || FnName == "exit" || FnName == "quick_exit"; +} aaron.ballman wrote: > Because this

[PATCH] D85077: [clang][Tooling] Optimize addTargetAndMode in case of invalid modes

kadircet updated this revision to Diff 282557. kadircet added a comment. - Rename `AlreadyHas` to `ShouldAdd` (and revert the logic) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85077/new/ https://reviews.llvm.org/D85077 Files:

[PATCH] D82317: [Clang/Test]: Update tests where `noundef` attribute is necessary

jdoerfert resigned from this revision. jdoerfert edited reviewers, added: rsmith, rjmccall; removed: jdoerfert, sscalpone. jdoerfert added subscribers: rjmccall, rsmith. jdoerfert added a comment. Herald added a reviewer: jdoerfert. Herald added a reviewer: jdoerfert. In D82317#2185134

[PATCH] D85118: [clang][AArch64] Correct return type of Neon vqmovun intrinsics

DavidSpickett created this revision. Herald added subscribers: cfe-commits, danielkiss, kristof.beyls. Herald added a project: clang. DavidSpickett requested review of this revision. Neon intrinsics vqmovunh_s16, vqmovuns_s32, vqmovund_s64 should have unsigned return types. See

[PATCH] D85124: [Concepts] Include the found concept decl when dumping the ConceptSpecializationExpr

hokein created this revision. hokein added a reviewer: nridge. Herald added a project: clang. hokein requested review of this revision. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D85124 Files: clang/include/clang/AST/TextNodeDumper.h clang/lib/AST/TextNodeDumper.cpp

[PATCH] D85077: [clang][Tooling] Optimize addTargetAndMode in case of invalid modes

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG76c3ec814dec: [clang][Tooling] Optimize addTargetAndMode in case of invalid modes (authored by kadircet). Repository: rG LLVM Github Monorepo

[clang] 76c3ec8 - [clang][Tooling] Optimize addTargetAndMode in case of invalid modes

Author: Kadir Cetinkaya Date: 2020-08-03T13:58:27+02:00 New Revision: 76c3ec814dec8eef020490b5d3a640d873b5918b URL: https://github.com/llvm/llvm-project/commit/76c3ec814dec8eef020490b5d3a640d873b5918b DIFF:

[PATCH] D85028: [clangd] Support new/deleta operator in TargetFinder.

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks, lgtm! Comment at: clang-tools-extra/clangd/XRefs.cpp:241 auto AddResultDecl = [&](const NamedDecl *D) { +// FIXME: C++ global operator new/delete are

[PATCH] D83717: [clang-tidy] Add check fo SEI CERT item ENV32-C

whisperity added inline comments. Comment at: clang-tools-extra/clang-tidy/cert/ExitHandlerCheck.cpp:64 +/// argument. +void ExitHandlerCheck::registerMatchers(MatchFinder *Finder) { + const auto IsRegisterFunction = What happens if this test is run on C++ code

[PATCH] D74436: Change clang option -ffp-model=precise to select ffp-contract=on

fhahn updated this revision to Diff 282577. fhahn added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74436/new/ https://reviews.llvm.org/D74436 Files: clang/docs/UsersManual.rst clang/lib/Driver/ToolChains/Clang.cpp

[PATCH] D85028: [clangd] Support new/delete operator in TargetFinder.

hokein updated this revision to Diff 282590. hokein marked 2 inline comments as done. hokein added a comment. address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85028/new/ https://reviews.llvm.org/D85028 Files:

[PATCH] D84839: Add document outline symbols from unnamed contexts, e.g. extern "C".

This revision was automatically updated to reflect the committed changes. Closed by commit rGd76057c1fe6a: Add document outline symbols from unnamed contexts, e.g. extern C. (authored by ilya-golovenko, committed by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang-tools-extra] d76057c - Add document outline symbols from unnamed contexts, e.g. extern "C".

Author: Ilya Golovenko Date: 2020-08-03T11:34:56+02:00 New Revision: d76057c1fe6a368e9e422cf586e09fba827c96e1 URL: https://github.com/llvm/llvm-project/commit/d76057c1fe6a368e9e422cf586e09fba827c96e1 DIFF:

[PATCH] D84511: Fix update_cc_test_checks.py --llvm-bin after D78478

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd1007478f19d: Fix update_cc_test_checks.py --llvm-bin after D78478 (authored by arichardson). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D74436: Change clang option -ffp-model=precise to select ffp-contract=on

fhahn reopened this revision. fhahn added a comment. This revision is now accepted and ready to land. IIUC the patch is currently reverted (in 78654e8511cf16d49f6680d782f3771a767ba942 ), due to ~20 llvm-test-suite failures.

[PATCH] D85077: [clang][Tooling] Optimize addTargetAndMode in case of invalid modes

kadircet updated this revision to Diff 282584. kadircet added a comment. - Change bitwise assignment to logical operators, as bitwise operators do not have short-circuting. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85077/new/

[PATCH] D85028: [clangd] Support new/delete operator in TargetFinder.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5191f70ab1f4: [clangd] Support new/deleta operator in TargetFinder. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang-tools-extra] 5191f70 - [clangd] Support new/deleta operator in TargetFinder.

Author: Haojian Wu Date: 2020-08-03T14:10:21+02:00 New Revision: 5191f70ab1f4b0b9225b2e9e11584e199172418c URL: https://github.com/llvm/llvm-project/commit/5191f70ab1f4b0b9225b2e9e11584e199172418c DIFF: https://github.com/llvm/llvm-project/commit/5191f70ab1f4b0b9225b2e9e11584e199172418c.diff

[PATCH] D83717: [clang-tidy] Add check fo SEI CERT item ENV32-C

njames93 added inline comments. Comment at: clang-tools-extra/clang-tidy/cert/ExitHandlerCheck.cpp:33 +bool isExitFunction(StringRef FnName) { + return FnName == "_Exit" || FnName == "exit" || FnName == "quick_exit"; +} whisperity wrote: > aaron.ballman wrote:

[PATCH] D83325: [Sema] Be more thorough when unpacking the AS-qualified pointee for a pointer conversion.

ebevhan added a comment. In D83325#2170813 , @rjmccall wrote: > `removeAddrSpaceQualType` should guarantee that it removes the address space > qualifier; you shouldn't need to do something special here. That means it > needs to iteratively desugar and

[PATCH] D84599: [clang-index] Use NamedDecl::getDeclName() instead of NamedDecl::printName in USRGenerator::EmitDeclName

kadircet added a comment. I can see how this can cause problems with current implementation, but I don't think the proposed solution in here is also solving these problems. For example, `MSGuidDecl`'s DeclName is actually empty (it is the printName overload that makes it meaningful). Hence

[PATCH] D85026: [analyzer] Introduce minor refactoring of SVal::getSubKind function

This revision was automatically updated to reflect the committed changes. Closed by commit rG21fa82d5c63c: [analyzer] Introduce minor refactoring of SVal::getSubKind function (authored by ASDenysPetrov). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 21fa82d - [analyzer] Introduce minor refactoring of SVal::getSubKind function

Author: Denys Petrov Date: 2020-08-03T15:05:08+03:00 New Revision: 21fa82d5c63c30c745d5181889329084ac6d2767 URL: https://github.com/llvm/llvm-project/commit/21fa82d5c63c30c745d5181889329084ac6d2767 DIFF: https://github.com/llvm/llvm-project/commit/21fa82d5c63c30c745d5181889329084ac6d2767.diff

[PATCH] D83717: [clang-tidy] Add check fo SEI CERT item ENV32-C

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/cert/ExitHandlerCheck.cpp:33 +bool isExitFunction(StringRef FnName) { + return FnName == "_Exit" || FnName == "exit" || FnName == "quick_exit"; +} Because this rule applies in C++ as

[PATCH] D83553: [PATCH 3/4][Sema][AArch64] Add codegen for arm_sve_vector_bits attribute

c-rhodes abandoned this revision. c-rhodes added a comment. I've posted a prototype D85128 with an alternative implementation, given it's quite different to this patch I've posted it as a separate patch and am abandoning this one. See new patch for more

[PATCH] D85074: [WebAssembly] Use "signed char" instead of "char" in SIMD intrinsics.

sunfish updated this revision to Diff 282608. sunfish added a comment. - Update clang/test/CodeGen/builtins-wasm.c. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85074/new/ https://reviews.llvm.org/D85074 Files:

[PATCH] D84511: Fix update_cc_test_checks.py --llvm-bin after D78478

arichardson updated this revision to Diff 282563. arichardson added a comment. remove tests and check for empty instead of none Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84511/new/ https://reviews.llvm.org/D84511 Files:

[PATCH] D85115: [update_cc_test_checks.py] Add test for D84511

arichardson created this revision. arichardson added a reviewer: MaskRay. Herald added a project: clang. Herald added a subscriber: cfe-commits. arichardson requested review of this revision. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D85115 Files:

[PATCH] D83717: [clang-tidy] Add check fo SEI CERT item ENV32-C

gamesh411 updated this revision to Diff 282535. gamesh411 added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83717/new/ https://reviews.llvm.org/D83717 Files: clang-tools-extra/clang-tidy/cert/CERTTidyModule.cpp

[PATCH] D78902: [Driver] Add output file to properties of Command

sepavloff added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78902/new/ https://reviews.llvm.org/D78902 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D79719: [AIX] Implement AIX special alignment rule about double/long double

ebevhan added inline comments. Comment at: clang/lib/AST/RecordLayoutBuilder.cpp:1778 -std::pair FieldInfo = - Context.getTypeInfoInChars(D->getType()); -EffectiveFieldSize = FieldSize = FieldInfo.first; It seems that in factoring out this to

[PATCH] D84599: [clang-index] Use NamedDecl::getDeclName() instead of NamedDecl::printName in USRGenerator::EmitDeclName

riccibruno added a comment. (Disclaimer: I am not at all familiar with this code) **A few notes in no particular order**: Some entities with special names should presumably be mangled, but are currently not. Example: namespace special_names { struct S { operator int(); }; int

[PATCH] D79719: [AIX] Implement AIX special alignment rule about double/long double

efriedma added inline comments. Comment at: clang/lib/AST/RecordLayoutBuilder.cpp:1778 -std::pair FieldInfo = - Context.getTypeInfoInChars(D->getType()); -EffectiveFieldSize = FieldSize = FieldInfo.first; ebevhan wrote: > It seems that in factoring

[PATCH] D82562: Implement AVX ABI Warning/error

dmajor added a comment. @erichkeane, could you help me understand what is the action item of these warnings? In Firefox we don't require AVX so our compilations generally don't enable the feature. (A very small number of files do come with AVX versions, mostly in imported media codecs, but

[PATCH] D84820: [WebAssembly] Implement prototype v128.load{32,64}_zero instructions

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGcb327922101b: [WebAssembly] Implement prototype v128.load{32,64}_zero instructions (authored by tlively). Repository: rG LLVM Github Monorepo

[clang] cb32792 - [WebAssembly] Implement prototype v128.load{32,64}_zero instructions

Author: Thomas Lively Date: 2020-08-03T13:54:00-07:00 New Revision: cb327922101b28ea70ec68d7f026da0e5e388eed URL: https://github.com/llvm/llvm-project/commit/cb327922101b28ea70ec68d7f026da0e5e388eed DIFF: https://github.com/llvm/llvm-project/commit/cb327922101b28ea70ec68d7f026da0e5e388eed.diff

[PATCH] D85157: [Sema] Add casting check for integer to fixed point conversions

bjope added inline comments. Comment at: clang/test/Sema/warn-bad-function-cast.c:49 +#ifdef FIXED_POINT + (void)(_Fract) if1(); // no warning +#endif bjope wrote: > bjope wrote: > > This should be added before the line saying `/* All following casts issue > >

[PATCH] D85146: [SyntaxTree] Fix crash on pointer to member function

gribozavr2 accepted this revision. gribozavr2 added inline comments. This revision is now accepted and ready to land. Comment at: clang/unittests/Tooling/Syntax/TreeTest.cpp:4076-4077 + R"cpp( +struct X{ + struct Y{}; +}; Please add spaces before `{`.

[PATCH] D84782: [PGO] Include the mem ops into the function hash.

yamauchi added a comment. In D84782#2191243 , @MaskRay wrote: > @yamauchi Do we need cd890944ad344b1b8cac58332ab11c9eec6b61e9 > and > 3d6f53018f845e893ad34f64ff2851a2e5c3ba1d >

[PATCH] D85144: [clang] Improve Dumping of APValues

riccibruno added inline comments. Comment at: clang/lib/AST/APValue.cpp:539 Out << '[' << Path[I].getAsArrayIndex() << ']'; -ElemTy = Ctx.getAsArrayType(ElemTy)->getElementType(); +ElemTy = cast(ElemTy.getCanonicalType())->getElementType(); }

[PATCH] D85102: [clang] improve diagnostics for misaligned and large atomics

tschuett added a comment. I would appreciate it, if somebody could commit this patch on my behalf. Thorsten Schuett schu...@gmail.com Thanks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85102/new/ https://reviews.llvm.org/D85102 ___

[PATCH] D84572: Allow .dSYM's to be directly placed in an alternate directory

This revision was automatically updated to reflect the committed changes. Closed by commit rG7209f83112db: Allow .dSYMs to be directly placed in an alternate directory (authored by dsanders). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84572/new/

[clang] 7209f83 - Allow .dSYM's to be directly placed in an alternate directory

Author: Daniel Sanders Date: 2020-08-03T13:18:52-07:00 New Revision: 7209f83112db4dbe15d8328705f9d2aff0624fbd URL: https://github.com/llvm/llvm-project/commit/7209f83112db4dbe15d8328705f9d2aff0624fbd DIFF:

[PATCH] D85146: [SyntaxTree] Fix crash on pointer to member function

eduucaldas added a comment. Additionally deleting TraverseParenTypeLoc changes nothing in the tests. I can also investigate that, I can try to come up with a test that makes this Traverse override relevant and if I'm not able, I would remove this override. Comment at:

[PATCH] D75574: RFC: Implement objc_direct_protocol attribute to remove protocol metadata

lanza added a comment. ping @rjmccall. Any update on a timeline for this review process? Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75574/new/ https://reviews.llvm.org/D75574 ___ cfe-commits

[PATCH] D84844: [OpenMP] Ensure testing for versions 4.5 and default - Part 1

jdoerfert added a comment. I think this is good. Let's see if there are objections Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84844/new/ https://reviews.llvm.org/D84844 ___ cfe-commits mailing list

[PATCH] D85144: [clang] Improve Dumping of APValues

riccibruno added a comment. Thanks for finishing this. I don't see why you are adding `dumpPretty`; the point of the `dump` function I added is to dump the `APValue` as the tree-like structure it is. But your `dumpPretty` doesn't do that at all. Instead it is just an alias for `printPretty`.

RE: [PATCH] D84703: [clang codegen][AArch64] Use llvm.aarch64.neon.fcvtzs/u where it's necessary

Committed dca23ed; should be fixed now. -Eli From: Azhar Mohammed Sent: Monday, August 3, 2020 11:01 AM To: Eli Friedman ; Eli Friedman via Phabricator ; Eli Friedman Cc: sander.desma...@arm.com; sjoerd.mei...@arm.com; t.p.northo...@gmail.com; cameron.mcina...@nyu.edu;

[clang] 7cf4603 - Reland D61689 Change -gz and -Wa,--compress-debug-sections to use gABI compression (SHF_COMPRESSED) with integrated assembler

Author: Fangrui Song Date: 2020-08-03T15:12:01-07:00 New Revision: 7cf4603faee366a6e5860b6fdbedadd91872e231 URL: https://github.com/llvm/llvm-project/commit/7cf4603faee366a6e5860b6fdbedadd91872e231 DIFF: https://github.com/llvm/llvm-project/commit/7cf4603faee366a6e5860b6fdbedadd91872e231.diff

[PATCH] D85157: [Sema] Add casting check for integer to fixed point conversions

bjope added inline comments. Comment at: clang/lib/Sema/SemaCast.cpp:2660 return; + if (SrcType->isIntegerType() && DestType->isFixedPointType()) +return; Is this really the intention with the patch? It does match the "summary" above, but isn't the

[PATCH] D85128: [Prototype][SVE] Support arm_sve_vector_bits attribute

efriedma added a comment. Not going to write detailed review comments, but this looks like the right approach in general. One high-level thing to consider: we could still decide that in IR generation, we want to represent VLSTs registers using scalable vector types, like the original patch

[PATCH] D85157: [Sema] Add casting check for integer to fixed point conversions

vabridgers created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. vabridgers requested review of this revision. This change squelches the warning for a cast from integer to fixed point conversions. Repository: rG LLVM Github Monorepo

[PATCH] D84540: [CodeGen][ObjC] Mark calls to objc_unsafeClaimAutoreleasedReturnValue as notail on x86-64

This revision was automatically updated to reflect the committed changes. Closed by commit rG41b1e97b12c1: [CodeGen][ObjC] Mark calls to objc_unsafeClaimAutoreleasedReturnValue as (authored by ahatanak). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 41b1e97 - [CodeGen][ObjC] Mark calls to objc_unsafeClaimAutoreleasedReturnValue as

Author: Akira Hatanaka Date: 2020-08-03T13:25:25-07:00 New Revision: 41b1e97b12c1407e40d8e5081bf1f9cf183934b0 URL: https://github.com/llvm/llvm-project/commit/41b1e97b12c1407e40d8e5081bf1f9cf183934b0 DIFF:

[PATCH] D85146: [SyntaxTree] Fix crash on pointer to member function

eduucaldas created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. eduucaldas requested review of this revision. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D85146 Files: clang/lib/Tooling/Syntax/BuildTree.cpp

[PATCH] D83788: Removed unused variable in clang

dblaikie closed this revision. dblaikie added a comment. In D83788#2183684 , @hiraditya wrote: > Not sure why this didnt get closed after the patch is merged in: > https://reviews.llvm.org/rG4fd91b0f946f49370a3ab33c480a807a3f48b247 The commit didn't

[PATCH] D82562: Implement AVX ABI Warning/error

erichkeane added a comment. In D82562#2191512 , @dmajor wrote: > @erichkeane, could you help me understand what is the action item of these > warnings? > > In Firefox we don't require AVX so our compilations generally don't enable > the feature. (A very

  1   2   >