[PATCH] D87243: [cmake] Centralize LLVM_ENABLE_WARNINGS option

lebedev.ri added a comment. This is not nessesairy correct, at least the clang can be built in standalone mode, not as part of monorepo checkout (i.e. it's `clang/cmakelists.txt` is the root cmakelists, not `llvm/cmakelists.txt`'s) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D87243: [cmake] Centralize LLVM_ENABLE_WARNINGS option

kastiglione added a comment. The `LLVM_ENABLE_WARNINGS` variable is read only within `HandleLLVMOptions.cmake`. Outside declarations/defaults have effect only when `HandleLLVMOptions` is loaded, one way or another. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D83360: [InstSimplify] Remove select ?, undef, X -> X and select ?, X, undef -> X

craig.topper abandoned this revision. craig.topper added a comment. This got replaced by D85765 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83360/new/ https://reviews.llvm.org/D83360

[PATCH] D86699: [SyntaxTree] Ignore implicit non-leaf `CXXConstructExpr`

eduucaldas updated this revision to Diff 290327. eduucaldas marked 3 inline comments as done. eduucaldas added a comment. answer comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86699/new/ https://reviews.llvm.org/D86699 Files:

[PATCH] D87201: [clang-format] Add a option for the position of Java static import

JakeMerdichAMD added inline comments. Comment at: clang/include/clang/Format/Format.h:1705 + /// \endcode + bool JavaStaticImportAfterImport; + bc-lee wrote: > JakeMerdichAMD wrote: > > 3 things here: > > > > 1. Did you mix up the true and false cases? > > 2.

[PATCH] D87256: [clangd] Avoid relations being overwritten in a header shard

nridge created this revision. nridge added a reviewer: hokein. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous. Herald added a project: clang. nridge requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Fixes

[PATCH] D87250: [OpenMP] Fix typo in CodeGenFunction::EmitOMPWorksharingLoop (PR46412)

RKSimon created this revision. RKSimon added reviewers: ABataev, doctorpangloss. Herald added subscribers: guansong, yaxunl. Herald added a project: clang. RKSimon requested review of this revision. Herald added a reviewer: jdoerfert. Herald added a subscriber: sstefan1. Fixes issue noticed by

[PATCH] D86699: [SyntaxTree] Ignore implicit non-leaf `CXXConstructExpr`

eduucaldas updated this revision to Diff 290331. eduucaldas added a comment. - Rename tests - Add FIXMEs for init-declarators Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86699/new/ https://reviews.llvm.org/D86699 Files:

[PATCH] D87250: [OpenMP] Fix typo in CodeGenFunction::EmitOMPWorksharingLoop (PR46412)

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LGTM thx Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87250/new/ https://reviews.llvm.org/D87250

[PATCH] D86089: [flang][driver]Add experimental flang driver and frontend with help screen

awarzynski added a comment. In D86089#2256139 , @richard.barton.arm wrote: > Another random thought that just came to me: what does the new driver do when > you invoke it with no input files or options? I could imagine a few sensible > outcomes (error:

[PATCH] D87218: [builtins] Inline __paritysi2 into __paritydi2 and inline __paritydi2 into __parityti2.

MaskRay added a comment. I think this is correct, but does their performance matter? llvm/IR/RuntimeLibcalls.def do not define them (they cannot be produced by llvm). Targets either emit popcount & 1 or detect the idiom and emit an optimized parity (x86 after PR46954) Repository: rG LLVM

[PATCH] D82725: [PowerPC] Implement Move to VSR Mask builtins in LLVM/Clang

steven.zhang added inline comments. Comment at: llvm/lib/Target/PowerPC/PPCISelLowering.cpp:10054 + + case Intrinsic::ppc_altivec_mtvsrbm: { +// The llvm.ppc.altivec.mtvsrbm intrinsic can correspond to two different Can we handle this inside the .td ? i.e.

[PATCH] D87243: [cmake] Centralize LLVM_ENABLE_WARNINGS option

kastiglione added a comment. @lebedev.ri `clang/CMakeLists.txt` contains `include(HandleLLVMOptions)` for its standalone build, I think this covers the issue you're pointing out Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87243/new/

[PATCH] D87218: [builtins] Inline __paritysi2 into __paritydi2 and inline __paritydi2 into __parityti2.

craig.topper added a comment. In D87218#2259972 , @MaskRay wrote: > I think this is correct, but does their performance matter? > `llvm/IR/RuntimeLibcalls.def` does not define them (they cannot be produced > by llvm). Targets either emit popcount & 1 or

[PATCH] D87257: [clang] Traverse init-captures while indexing

nridge added a reviewer: hokein. nridge added a comment. I did try to add a test to `clang/test/Index/Core/index-source.cpp`, however the output of `c-index-test` does not seem to be changed by adding this reference. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D87257: [clang] Traverse init-captures while indexing

nridge created this revision. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous. Herald added a project: clang. nridge requested review of this revision. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D87257 Files:

[PATCH] D87257: [clang] Traverse init-captures while indexing

nridge updated this revision to Diff 290379. nridge added a comment. Fix typo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87257/new/ https://reviews.llvm.org/D87257 Files: clang-tools-extra/clangd/unittests/XRefsTests.cpp

[PATCH] D86700: [SyntaxTree] Ignore leaf implicit `CXXConstructExpr`

eduucaldas updated this revision to Diff 290328. eduucaldas marked 2 inline comments as done. eduucaldas added a comment. answer comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86700/new/ https://reviews.llvm.org/D86700 Files:

[PATCH] D86699: [SyntaxTree] Ignore implicit non-leaf `CXXConstructExpr`

eduucaldas added inline comments. Comment at: clang/unittests/Tooling/Syntax/BuildTreeTest.cpp:4042 + +TEST_P(SyntaxTreeTest, ExplicitConversion_ZeroArguments) { + if (!GetParam().isCXX()) { gribozavr2 wrote: > This is not a conversion, this is an explicit

[PATCH] D86700: [SyntaxTree] Ignore leaf implicit `CXXConstructExpr`

eduucaldas added inline comments. Comment at: clang/lib/Tooling/Syntax/BuildTree.cpp:1137 +// Ignore the implicit default constructs. +if ((S->getNumArgs() == 0 || isa(S->getArg(0))) && +S->getParenOrBraceRange().isInvalid()) gribozavr2 wrote: >

[PATCH] D85960: [AST][FPEnv] Keep FP options in trailing storage of CastExpr

riccibruno added a comment. > This change allow a CallExpr to have optional FPOptionsOverride object, Should this be `CastExpr` instead? > stored in trailing storage. The implementaion is made similar to the way > used in CallExpr. Nit, but that's not really similar. In the `CallExpr` case the

[PATCH] D87253: [libTooling] Change CDB heuristic to look further for files in a given language.

amosnier accepted this revision. amosnier added a comment. This revision is now accepted and ready to land. I'm not sure I'm supposed to accept a revision, but apparently I'm authorized to do so. And I'm obviously biased since I wrote the bug report. While looking for candidates close to the

[PATCH] D87201: [clang-format] Add a option for the position of Java static import

bc-lee updated this revision to Diff 290381. bc-lee added a comment. Fix the example to match the description. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87201/new/ https://reviews.llvm.org/D87201 Files:

[PATCH] D87253: [libTooling] Change CDB heuristic to look further for files in a given language.

adamcz created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. adamcz requested review of this revision. When looking for compile commands for file of type X, other files of type X will be preferred over files of any other type, regardless of score. However,

[PATCH] D82726: [PowerPC] Implement Vector Count Mask Bits builtins in LLVM/Clang

steven.zhang accepted this revision. steven.zhang added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82726/new/ https://reviews.llvm.org/D82726

[PATCH] D87249: [SyntaxTree] Fix crash on functions with default arguments.

gribozavr2 added a comment. Please also add tests for calls to constructors without arguments and calls to implicit constructors 1 argument, as requested in https://reviews.llvm.org/D86700. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87249/new/

[PATCH] D87218: [builtins] Inline __paritysi2 into __paritydi2 and inline __paritydi2 into __parityti2.

efriedma accepted this revision. efriedma added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87218/new/ https://reviews.llvm.org/D87218 ___ cfe-commits mailing list

[PATCH] D87249: [SyntaxTree] Fix crash on functions with default arguments.

eduucaldas created this revision. eduucaldas added a reviewer: gribozavr2. Herald added a project: clang. Herald added a subscriber: cfe-commits. eduucaldas requested review of this revision. - Do not visit `CXXDefaultArgExpr` - To build `CallArguments` nodes, just go through non-default

[PATCH] D79279: Add overloaded versions of builtin mem* functions

jfb added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79279/new/ https://reviews.llvm.org/D79279 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D86700: [SyntaxTree] Ignore leaf implicit `CXXConstructExpr`

gribozavr2 added inline comments. Comment at: clang/lib/Tooling/Syntax/BuildTree.cpp:1137 +// Ignore the implicit default constructs. +if ((S->getNumArgs() == 0 || isa(S->getArg(0))) && +S->getParenOrBraceRange().isInvalid()) eduucaldas wrote: >

[PATCH] D87218: [builtins] Inline __paritysi2 into __paritydi2 and inline __paritydi2 into __parityti2.

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. LG. Please wait a bit for @efriedma's comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87218/new/ https://reviews.llvm.org/D87218

[PATCH] D86699: [SyntaxTree] Ignore implicit non-leaf `CXXConstructExpr`

gribozavr2 accepted this revision. gribozavr2 added inline comments. Comment at: clang/lib/Tooling/Syntax/BuildTree.cpp:48 +// Ignores the implicit `CXXConstructExpr` for copy/move constructors generated +// by the compiler, as well as in implicit conversions like the one

[PATCH] D86369: [Sema][MSVC] warn at dynamic_cast when /GR- is given

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. LGTM But please add a -triple parameter to the test files, and check the dynamic_cast behavior in each case before committing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D85960: [AST][FPEnv] Keep FP options in trailing storage of CastExpr

rjmccall added a comment. Minor request, but otherwise LGTM. Comment at: clang/lib/Analysis/BodyFarm.cpp:188 + const_cast(Arg), nullptr, VK_RValue, + FPOptionsOverride()); } Can these call

[PATCH] D86089: [flang][driver]Add experimental flang driver and frontend with help screen

awarzynski updated this revision to Diff 290337. awarzynski marked 2 inline comments as done. awarzynski added a comment. - Adddressed comments from @richard.barton.arm - Added FC1Option to ClangFlags (and made other related changes) - Added missing code to check return codes from subcommands

[PATCH] D84599: [Index/USRGeneration] Use NamedDecl::getDeclName() instead of NamedDecl::printName in USRGenerator::EmitDeclName

riccibruno added a comment. To make this patch more acceptable I could also add a `Visit` function for `DecompositionDecl` and `MSGuidDecl` such that the current behaviour is preserved (I won't be able to test it though since these implicit AST nodes are not visited). Repository: rG LLVM

[PATCH] D87218: [builtins] Inline __paritysi2 into __paritydi2 and inline __paritydi2 into __parityti2.

This revision was automatically updated to reflect the committed changes. Closed by commit rG35f708a3c9ff: [builtins] Inline __paritysi2 into __paritydi2 and inline __paritydi2 into… (authored by craig.topper). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D87253: [libTooling] Change CDB heuristic to look further for files in a given language.

adamcz added a reviewer: kadircet. adamcz added a comment. Hey Kadir What do you think about this change? This addresses https://github.com/clangd/clangd/issues/519, but I'm not entirely convinced this is a good idea. Let me know if you have an opinion on this. Repository: rG LLVM Github

[clang] 3e782bf - [Sema][MSVC] warn at dynamic_cast when /GR- is given

Author: Zequan Wu Date: 2020-09-07T16:46:58-07:00 New Revision: 3e782bf8090c80e6d75e62cd52c9ed32715cbcdd URL: https://github.com/llvm/llvm-project/commit/3e782bf8090c80e6d75e62cd52c9ed32715cbcdd DIFF: https://github.com/llvm/llvm-project/commit/3e782bf8090c80e6d75e62cd52c9ed32715cbcdd.diff

[PATCH] D86369: [Sema][MSVC] warn at dynamic_cast when /GR- is given

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3e782bf8090c: [Sema][MSVC] warn at dynamic_cast when /GR- is given (authored by zequanwu). Changed prior to commit:

[PATCH] D66564: [clang-tidy] new altera struct pack align check

ffrankies added a comment. In D66564#2257635 , @aaron.ballman wrote: > In D66564#2256482 , @ffrankies wrote: > >> In D66564#2256424 , @Eugene.Zelenko >> wrote: >> >>> In

[PATCH] D66564: [clang-tidy] new altera struct pack align check

ffrankies updated this revision to Diff 290396. ffrankies added a comment. Rebased, changed import in `StructPackAlignCheck.h` from `../ClangTidy.h` to `../ClangTidyCheck.h` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66564/new/ https://reviews.llvm.org/D66564 Files:

[clang] 7907e55 - [Sema] fix /gr warning test case

Author: Zequan Wu Date: 2020-09-07T20:55:11-07:00 New Revision: 7907e5516a418fec29137beed3ff985f40e04f17 URL: https://github.com/llvm/llvm-project/commit/7907e5516a418fec29137beed3ff985f40e04f17 DIFF: https://github.com/llvm/llvm-project/commit/7907e5516a418fec29137beed3ff985f40e04f17.diff

[PATCH] D87080: [AST] Reduce the size of TemplateArgumentLocInfo.

hokein updated this revision to Diff 290187. hokein marked 2 inline comments as done. hokein added a comment. address review comments: - use PointerUnion - keep the TemplateArgumentLocInfo trivial, allocate from allocator, no deallocation. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D87080: [AST] Reduce the size of TemplateArgumentLocInfo.

hokein updated this revision to Diff 290188. hokein added a comment. format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87080/new/ https://reviews.llvm.org/D87080 Files: clang/include/clang/AST/TemplateBase.h clang/lib/AST/ASTImporter.cpp

[PATCH] D78938: Fixing all comparisons for C++20 compilation.

jhenderson added a comment. Not that I have anything particularly against this, but won't this likely rot fairly rapidly? It's not like LLVM is even on C++17 let alone C++20 yet, so trying to make it work like the latter when it's just going to break again seems a bit like wasted effort to me.

[PATCH] D87081: [analyzer][StdLibraryFunctionsChecker] Elaborate the summary of fread and fwrite

martong added a comment. In D87081#2256636 , @balazske wrote: > This checker will make an additional assumption on `fread` and `fwrite` with > the ReturnValueCondition. There is nothing new in that. This assumption described by the `.Case` has been

[PATCH] D86137: Add ignore-unknown-options flag to clang-format.

MyDeveloperDay added subscribers: sammccall, JDevlieghere, aaron.ballman. MyDeveloperDay added a comment. > Regarding not touching the LLVM support library: I'd love to find a way, but > as clang-format uses the >> operator We need to find some reviewers who look after a wider area of LLVM, if

[PATCH] D87007: [clang-format] Correctly parse function declarations with TypenameMacros

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG05147d330917: [clang-format] Correctly parse function declarations with TypenameMacros (authored by arichardson). Repository: rG LLVM Github

[PATCH] D86091: [cmake] Fix build of attribute plugin example on Windows

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG04ea680a8ccc: [cmake] Fix build of attribute plugin example on Windows (authored by krisb). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D85351: [Analyzer] Fix for `ExprEngine::computeObjectUnderConstruction()` for base and delegating consturctor initializers

Szelethus added a comment. The tests look great, thanks! I still lack the confidence to accept, unfortunately. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85351/new/ https://reviews.llvm.org/D85351 ___ cfe-commits mailing list

[clang] 70523ec - [Sparc] Select the UltraSPARC instruction set with the external assembler

Author: Brad Smith Date: 2020-09-07T02:49:05-04:00 New Revision: 70523ecfaca692bf5d0192e466c34ae7514624ea URL: https://github.com/llvm/llvm-project/commit/70523ecfaca692bf5d0192e466c34ae7514624ea DIFF: https://github.com/llvm/llvm-project/commit/70523ecfaca692bf5d0192e466c34ae7514624ea.diff

[PATCH] D86950: [clang-format] Check that */& after typename macros are pointers/references

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGcd01eec14bc0: [clang-format] Check that */ after typename macros are pointers/references (authored by arichardson). Repository: rG LLVM Github

[PATCH] D86959: [clang-format] Fix formatting of _Atomic() qualifier

This revision was automatically updated to reflect the committed changes. Closed by commit rG56fa7d1dc6a8: [clang-format] Fix formatting of _Atomic() qualifier (authored by arichardson). Changed prior to commit: https://reviews.llvm.org/D86959?vs=289509=290211#toc Repository: rG LLVM Github

[clang] e7bd058 - [clang-format] Allow configuring list of macros that map to attributes

Author: Alex Richardson Date: 2020-09-07T10:09:17+01:00 New Revision: e7bd058c7e2cb2c675a4b78ec770ea725bff8c64 URL: https://github.com/llvm/llvm-project/commit/e7bd058c7e2cb2c675a4b78ec770ea725bff8c64 DIFF:

[PATCH] D86930: [clang-format] Handle typename macros inside cast expressions

This revision was automatically updated to reflect the committed changes. Closed by commit rG8aa3b8da5db2: [clang-format] Handle typename macros inside cast expressions (authored by arichardson). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 9a22eba - [clang-format] Parse __underlying_type(T) as a type

Author: Alex Richardson Date: 2020-09-07T10:09:18+01:00 New Revision: 9a22eba15091ea849fa78c09ac4c9f7260071790 URL: https://github.com/llvm/llvm-project/commit/9a22eba15091ea849fa78c09ac4c9f7260071790 DIFF:

[clang] cd01eec - [clang-format] Check that */& after typename macros are pointers/references

Author: Alex Richardson Date: 2020-09-07T10:09:18+01:00 New Revision: cd01eec14bc045a8616604cadf94dba025090ba5 URL: https://github.com/llvm/llvm-project/commit/cd01eec14bc045a8616604cadf94dba025090ba5 DIFF:

[clang] 05147d3 - [clang-format] Correctly parse function declarations with TypenameMacros

Author: Alex Richardson Date: 2020-09-07T10:09:18+01:00 New Revision: 05147d33091720e2df929d6fea3b0fd2a657ac61 URL: https://github.com/llvm/llvm-project/commit/05147d33091720e2df929d6fea3b0fd2a657ac61 DIFF:

[clang] 8aa3b8d - [clang-format] Handle typename macros inside cast expressions

Author: Alex Richardson Date: 2020-09-07T10:09:17+01:00 New Revision: 8aa3b8da5db2ae73bf536b630915eb9f0ddc15cb URL: https://github.com/llvm/llvm-project/commit/8aa3b8da5db2ae73bf536b630915eb9f0ddc15cb DIFF:

[PATCH] D86782: [clang-format] Allow configuring list of macros that map to attributes

This revision was automatically updated to reflect the committed changes. Closed by commit rGe7bd058c7e2c: [clang-format] Allow configuring list of macros that map to attributes (authored by arichardson). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D86960: [clang-format] Parse __underlying_type(T) as a type

This revision was automatically updated to reflect the committed changes. Closed by commit rG9a22eba15091: [clang-format] Parse __underlying_type(T) as a type (authored by arichardson). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86960/new/

[clang] 56fa7d1 - [clang-format] Fix formatting of _Atomic() qualifier

Author: Alex Richardson Date: 2020-09-07T10:09:18+01:00 New Revision: 56fa7d1dc6a8d23111ff84171036f333cf9cddf2 URL: https://github.com/llvm/llvm-project/commit/56fa7d1dc6a8d23111ff84171036f333cf9cddf2 DIFF:

[PATCH] D87225: [clangd] When finding refs for a template specialization, do not return refs to other specializations

nridge created this revision. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous. Herald added a project: clang. nridge requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Fixes https://github.com/clangd/clangd/issues/515 Repository:

[PATCH] D87080: [AST] Reduce the size of TemplateArgumentLocInfo.

hokein added inline comments. Comment at: clang/include/clang/AST/TemplateBase.h:429 + auto *T = getTemplate(); + T->Ctx->Deallocate(T); +} sammccall wrote: > sammccall wrote: > > this is a no-op, and thus not worth stashing a pointer to Ctx for! >

[clang] b3205e2 - [scan-view] Explicitly use utf-8 in send_string

Author: Tomas Rix Date: 2020-09-07T09:26:38+02:00 New Revision: b3205e2ace4378600dedba0cc5a42b481c4e22c9 URL: https://github.com/llvm/llvm-project/commit/b3205e2ace4378600dedba0cc5a42b481c4e22c9 DIFF: https://github.com/llvm/llvm-project/commit/b3205e2ace4378600dedba0cc5a42b481c4e22c9.diff

[PATCH] D83984: Explicitly use utf-8 in send_string

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb3205e2ace43: [scan-view] Explicitly use utf-8 in send_string (authored by Tomas Rix t...@juniper.net, committed by serge-sans-paille).

[PATCH] D83984: Explicitly use utf-8 in send_string

serge-sans-paille added a comment. Commited on your behalf using what I expect to be your official email address :-) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83984/new/ https://reviews.llvm.org/D83984

[clang] 04ea680 - [cmake] Fix build of attribute plugin example on Windows

Author: Kristina Bessonova Date: 2020-09-07T10:04:32+02:00 New Revision: 04ea680a8ccc4f9a4d7333cd712333960348c35b URL: https://github.com/llvm/llvm-project/commit/04ea680a8ccc4f9a4d7333cd712333960348c35b DIFF:

[PATCH] D77491: [Sema] Introduce BuiltinAttr, per-declaration builtin-ness

rsmith added inline comments. Comment at: clang/lib/Headers/intrin.h:435 #if defined(__i386__) || defined(__x86_64__) -static __inline__ void __DEFAULT_FN_ATTRS -__movsb(unsigned char *__dst, unsigned char const *__src, size_t __n) { +void __DEFAULT_FN_ATTRS __movsb(unsigned

[PATCH] D87081: [analyzer][StdLibraryFunctionsChecker] Elaborate the summary of fread and fwrite

Szelethus added a comment. The patch looks great, in fact, it demonstrates how well thought out your summary crafting machinery is. In D87081#2258579 , @martong wrote: > However, in a similar case with the CallAndMessage Checker, we decided to > list

[PATCH] D87028: [clang-format] Improve heuristic for detecting function declarations

MyDeveloperDay added a comment. Thanks for the patch, I think this looks like a comprehensive improvement, a new nits only Comment at: clang/lib/Format/TokenAnnotator.cpp:2427 + // inside a function this should always be treated as a variable. + return CouldBeTypeList &&

[PATCH] D87118: Add an explicit toggle for the static analyzer in clang-tidy

hans added a comment. Cool! Comment at: clang-tools-extra/CMakeLists.txt:4 +option(CLANG_TIDY_ENABLE_STATIC_ANALYZER + "Include static analyzer checks in clang-tidy" ON) + Should this default to CLANG_ENABLE_STATIC_ANALYZER instead of ON?

[PATCH] D87201: [clang-format] Add a option for the position of Java static import

MyDeveloperDay requested changes to this revision. MyDeveloperDay added a comment. This revision now requires changes to proceed. Thanks for the patch, You need to generate a fill context diff (see Contributing to LLVM) ensure the diff is clang-formatted itself (can't quite tell if it is or

[PATCH] D87028: [clang-format] Improve heuristic for detecting function declarations

arichardson added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:2427 + // inside a function this should always be treated as a variable. + return CouldBeTypeList && Line.Level == 0; } MyDeveloperDay wrote: > how hard would it be to do the

[PATCH] D86699: [SyntaxTree] Ignore implicit non-leaf `CXXConstructExpr`

eduucaldas updated this revision to Diff 290223. eduucaldas added a comment. Add more tests, not extract `IgnoreImplicitConstructorSingleStep` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86699/new/ https://reviews.llvm.org/D86699 Files:

[PATCH] D86699: [SyntaxTree] Ignore implicit non-leaf `CXXConstructExpr`

eduucaldas updated this revision to Diff 290227. eduucaldas added a comment. . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86699/new/ https://reviews.llvm.org/D86699 Files: clang/lib/Tooling/Syntax/BuildTree.cpp

[PATCH] D86700: [SyntaxTree] Ignore leaf implicit `CXXConstructExpr`

eduucaldas updated this revision to Diff 290228. eduucaldas added a comment. . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86700/new/ https://reviews.llvm.org/D86700 Files: clang/lib/Tooling/Syntax/BuildTree.cpp

[PATCH] D84415: [analyzer][StdLibraryFunctionsChecker] Add POSIX pthread handling functions

vsavchenko accepted this revision. vsavchenko added a comment. LGTM! Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84415/new/ https://reviews.llvm.org/D84415 ___ cfe-commits mailing list

[PATCH] D85424: [Analyzer] Crash fix for alpha.cplusplus.IteratorRange

steakhal added a comment. OK, after a few hours of debugging, the test code simplifies to this: // RUN: %clang_analyze_cc1 -std=c++11 -analyzer-checker=core,cplusplus,alpha.cplusplus.IteratorRange -analyzer-config aggressive-binary-operation-simplification=true %s -verify void foo(int

[PATCH] D76590: [Analyzer] Model `empty()` member function of containers

Szelethus added a comment. I'm in favor of most, if not all of the changes, though I will admit that this patch seems pretty cluttered, you are doing a lot of refactoring under the same hood. You're moving, adding, removing and changing helper functions and their invocations. Would be possible

[PATCH] D86778: Extract infrastructure to ignore intermediate expressions into `clang/AST/IgnoreExpr.h`

This revision was automatically updated to reflect the committed changes. Closed by commit rG81aa66f65f50: Extract infrastructure to ignore intermediate expressions into… (authored by eduucaldas). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang-tools-extra] 1a7a2cd - [Ignore Expressions][NFC] Refactor to better use `IgnoreExpr.h` and nits

Author: Eduardo Caldas Date: 2020-09-07T09:32:30Z New Revision: 1a7a2cd7474e6d321120ffe7ca9c52163eb228f0 URL: https://github.com/llvm/llvm-project/commit/1a7a2cd7474e6d321120ffe7ca9c52163eb228f0 DIFF: https://github.com/llvm/llvm-project/commit/1a7a2cd7474e6d321120ffe7ca9c52163eb228f0.diff

[clang] 81aa66f - Extract infrastructure to ignore intermediate expressions into `clang/AST/IgnoreExpr.h`

Author: Eduardo Caldas Date: 2020-09-07T09:32:30Z New Revision: 81aa66f65f504af18982baa078a5f3f7d2aa88fa URL: https://github.com/llvm/llvm-project/commit/81aa66f65f504af18982baa078a5f3f7d2aa88fa DIFF: https://github.com/llvm/llvm-project/commit/81aa66f65f504af18982baa078a5f3f7d2aa88fa.diff

[PATCH] D86880: [Ignore Expressions][NFC] Refactor to better use `IgnoreExpr.h` and nits

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1a7a2cd7474e: [Ignore Expressions][NFC] Refactor to better use `IgnoreExpr.h` and nits (authored by eduucaldas). Changed prior to commit:

[PATCH] D86700: [SyntaxTree] Ignore leaf implicit `CXXConstructExpr`

eduucaldas added inline comments. Comment at: clang/unittests/Tooling/Syntax/BuildTreeTest.cpp:552 [[::n::S s1]]; [[n::S s2]]; } gribozavr2 wrote: > Do we have tests for calling constructors with arguments? > > `n::S s3(1, 2, 3);` > `n::S s3{1, 2, 3};` >

[PATCH] D77491: [Sema] Introduce BuiltinAttr, per-declaration builtin-ness

tambre updated this revision to Diff 290229. tambre marked 3 inline comments as done. tambre added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77491/new/ https://reviews.llvm.org/D77491 Files:

[PATCH] D77491: [Sema] Introduce BuiltinAttr, per-declaration builtin-ness

tambre updated this revision to Diff 290232. tambre marked an inline comment as done. tambre added a comment. Remove now obsolete FIXME. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77491/new/ https://reviews.llvm.org/D77491 Files:

[PATCH] D77491: [Sema] Introduce BuiltinAttr, per-declaration builtin-ness

tambre added a comment. Thanks for the review. All tests still pass, should be good for another round. Comment at: clang/lib/Sema/SemaDecl.cpp:9672-9673 + if (unsigned BuiltinID = II->getBuiltinID()) { +const auto *LinkageDecl = +

[PATCH] D87118: Add an explicit toggle for the static analyzer in clang-tidy

Szelethus added a reviewer: NoQ. Szelethus added a comment. Herald added a subscriber: Charusso. NoQ in particular has been working hard on the common infrastructure in between the static analyzer and clang-tidy, I'll add him :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87118/new/

[PATCH] D87201: [clang-format] Add a option for the position of Java static import

bc-lee updated this revision to Diff 290246. bc-lee added a comment. Modify the comment of Format.h to sync ClangFormatStyleOptions.rst Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87201/new/ https://reviews.llvm.org/D87201 Files:

[PATCH] D86700: [SyntaxTree] Ignore leaf implicit `CXXConstructExpr`

eduucaldas updated this revision to Diff 290224. eduucaldas marked an inline comment as done. eduucaldas added a comment. Add FIXME for `CXXFunctionalCastExpr` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86700/new/

[PATCH] D76590: [Analyzer] Model `empty()` member function of containers

baloghadamsoftware updated this revision to Diff 290248. baloghadamsoftware added a comment. Wrong diff uploaded previously. (Accidentally compared to //master// instead of the prerequisite.) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76590/new/ https://reviews.llvm.org/D76590

[PATCH] D84415: [analyzer][StdLibraryFunctionsChecker] Add POSIX pthread handling functions

Szelethus accepted this revision. Szelethus added a comment. This revision is now accepted and ready to land. @balazske seems to be very involved, he might have some closing words -- from my end, LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D87229: [SyntaxTree] Ignore implicit `CXXFunctionalCastExpr` wrapping constructor

eduucaldas created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. eduucaldas requested review of this revision. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D87229 Files: clang/lib/Tooling/Syntax/BuildTree.cpp

[PATCH] D80878: [clang] Prevent that Decl::dump on a CXXRecordDecl deserialises further declarations.

This revision was automatically updated to reflect the committed changes. Closed by commit rG0478720157f6: [clang] Prevent that Decl::dump on a CXXRecordDecl deserialises further… (authored by teemperor). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG

[clang] 0478720 - [clang] Prevent that Decl::dump on a CXXRecordDecl deserialises further declarations.

Author: Raphael Isemann Date: 2020-09-07T12:31:30+02:00 New Revision: 0478720157f6413fad7595b8eff9c70d2d99b637 URL: https://github.com/llvm/llvm-project/commit/0478720157f6413fad7595b8eff9c70d2d99b637 DIFF:

[PATCH] D80878: [clang] Prevent that Decl::dump on a CXXRecordDecl deserialises further declarations.

riccibruno added a comment. And what if deserialization is forced? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80878/new/ https://reviews.llvm.org/D80878 ___ cfe-commits mailing list

[PATCH] D86632: [Fixed Point] Add codegen for conversion between fixed-point and floating point.

ebevhan updated this revision to Diff 290245. ebevhan added a comment. Added promotion mechanism. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86632/new/ https://reviews.llvm.org/D86632 Files: clang/lib/CodeGen/CGExprScalar.cpp

[PATCH] D76590: [Analyzer] Model `empty()` member function of containers

baloghadamsoftware marked an inline comment as done. baloghadamsoftware added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/ContainerModeling.cpp:36 + void handleAssignment(CheckerContext , const Expr *CE, SVal Cont, +Optional = None)

  1   2   >