[PATCH] D87539: [MinGW][libclang] Allow simultaneous shared and static lib

mstorsjo accepted this revision. mstorsjo added a comment. This revision is now accepted and ready to land. LGTM then! Can apply it a bit later. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87539/new/ https://reviews.llvm.org/D87539

[clang] de044f7 - Revert "[AST][FPEnv] Keep FP options in trailing storage of CastExpr"

Author: Serge Pavlov Date: 2020-09-12T17:06:42+07:00 New Revision: de044f756286edebf86044d5172016d87f49fda0 URL: https://github.com/llvm/llvm-project/commit/de044f756286edebf86044d5172016d87f49fda0 DIFF: https://github.com/llvm/llvm-project/commit/de044f756286edebf86044d5172016d87f49fda0.diff

[PATCH] D87539: [MinGW][libclang] Allow simultaneous shared and static lib

mstorsjo added a comment. In D87539#2269385 , @mati865 wrote: > We had this patch at MSYS2 for years and I'm not aware of any issues with the > static library. > I think the library looks fine: > > $ nm lib/liblibclang.a | grep __imp_ >

[PATCH] D87537: [lld][WebAssembly] Error on import/export of mutable global without `mutable-globals` feature

sbc100 updated this revision to Diff 291380. sbc100 added a comment. Feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87537/new/ https://reviews.llvm.org/D87537 Files: clang/lib/Driver/ToolChains/WebAssembly.cpp

[PATCH] D87539: [MinGW][libclang] Allow simultaneous shared and static lib

mati865 added a comment. Sorry, pasted wrong command. I was curious if import library has it (since static one did not) but in the end neither import nor static library shows any `export`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87539/new/

[PATCH] D85473: [Clang] Add option to allow marking pass-by-value args as noalias.

fhahn added inline comments. Comment at: clang/include/clang/Driver/Options.td:4287-4290 +def fpass_by_value_noalias: Flag<["-"], "fpass-by-value-noalias">, + HelpText<"Allows assuming no references to passed by value escape before " + "transferring execution to the

[clang] 6c8041a - [AST][FPEnv] Keep FP options in trailing storage of CastExpr

Author: Serge Pavlov Date: 2020-09-12T14:30:44+07:00 New Revision: 6c8041aa0ffed827636935e59c489b1e390c8542 URL: https://github.com/llvm/llvm-project/commit/6c8041aa0ffed827636935e59c489b1e390c8542 DIFF: https://github.com/llvm/llvm-project/commit/6c8041aa0ffed827636935e59c489b1e390c8542.diff

[PATCH] D85960: [AST][FPEnv] Keep FP options in trailing storage of CastExpr

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6c8041aa0ffe: [AST][FPEnv] Keep FP options in trailing storage of

[PATCH] D87539: [MinGW][libclang] Allow simultaneous shared and static lib

mati865 added a comment. `bin/llvm-readobj --coff-directives lib/liblibclang.dll.a | grep -i export` shows nothing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87539/new/ https://reviews.llvm.org/D87539

Re: [clang] a8503b8 - [NFC] Remove unused static function

build fails with -DLLVM_ENABLE_WERROR=ON On Fri, 11 Sep 2020 at 23:16, Kristóf Umann wrote: > Yup, unless you this breaks something, I'd really prefer to keep it. > > On Sat, 12 Sep 2020, 03:24 David Blaikie, wrote: > >> LLVM_DUMP_METHOD is meant to be used for annotating functions that might

Re: [clang] a8503b8 - [NFC] Remove unused static function

Yup, unless you this breaks something, I'd really prefer to keep it. On Sat, 12 Sep 2020, 03:24 David Blaikie, wrote: > LLVM_DUMP_METHOD is meant to be used for annotating functions that might > be useful to execute from a debugger to dump data structures, etc - so it's > expected that they'd

[PATCH] D87539: [MinGW][libclang] Allow simultaneous shared and static lib

mati865 added a comment. We had this patch at MSYS2 for years and I'm not aware of any issues with the static library. I think the library looks fine: $ nm lib/liblibclang.a | grep __imp_ U __imp___acrt_iob_func U __imp___acrt_iob_func

[PATCH] D71739: [AssumeBundles] Use operand bundles to encode alignment assumptions

Tyker added a comment. i believe all known issues with this patch have been fixed is it fine to reland ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71739/new/ https://reviews.llvm.org/D71739 ___

[PATCH] D87539: [MinGW][libclang] Allow simultaneous shared and static lib

mstorsjo added a comment. In D87539#2269442 , @mati865 wrote: > `bin/llvm-readobj --coff-directives lib/liblibclang.dll.a | grep -i export` > shows nothing. That's the import library, not the static library. Repository: rG LLVM Github Monorepo

[clang] 9c651c2 - Missing change from previous commit

Author: Serge Pavlov Date: 2020-09-12T15:11:09+07:00 New Revision: 9c651c231f3144f53e13cd0a1747589e1b2edccd URL: https://github.com/llvm/llvm-project/commit/9c651c231f3144f53e13cd0a1747589e1b2edccd DIFF: https://github.com/llvm/llvm-project/commit/9c651c231f3144f53e13cd0a1747589e1b2edccd.diff

[clang] a874d63 - [Clang] Add option to allow marking pass-by-value args as noalias.

Author: Florian Hahn Date: 2020-09-12T14:56:13+01:00 New Revision: a874d63344093752c912d01de60211f65745ea6f URL: https://github.com/llvm/llvm-project/commit/a874d63344093752c912d01de60211f65745ea6f DIFF: https://github.com/llvm/llvm-project/commit/a874d63344093752c912d01de60211f65745ea6f.diff

[PATCH] D85473: [Clang] Add option to allow marking pass-by-value args as noalias.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa874d6334409: [Clang] Add option to allow marking pass-by-value args as noalias. (authored by fhahn). Changed prior to commit:

[clang] d6fadc4 - [gcov] Process .gcda immediately after the accompanying .gcno instead of doing all .gcda after all .gcno

Author: Fangrui Song Date: 2020-09-12T13:53:03-07:00 New Revision: d6fadc49e3d7eb0977bca3ff92bf156bd059fcd4 URL: https://github.com/llvm/llvm-project/commit/d6fadc49e3d7eb0977bca3ff92bf156bd059fcd4 DIFF: https://github.com/llvm/llvm-project/commit/d6fadc49e3d7eb0977bca3ff92bf156bd059fcd4.diff

[PATCH] D87537: [lld][WebAssembly] Error on import/export of mutable global without `mutable-globals` feature

This revision was automatically updated to reflect the committed changes. Closed by commit rG04febd30a8da: [lld][WebAssembly] Error on import/export of mutable global without `mutable… (authored by sbc100). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 04febd3 - [lld][WebAssembly] Error on import/export of mutable global without `mutable-globals` feature

Author: Sam Clegg Date: 2020-09-12T14:28:14-07:00 New Revision: 04febd30a8dab3ff4b6e6032f1a1a9f4725f8267 URL: https://github.com/llvm/llvm-project/commit/04febd30a8dab3ff4b6e6032f1a1a9f4725f8267 DIFF: https://github.com/llvm/llvm-project/commit/04febd30a8dab3ff4b6e6032f1a1a9f4725f8267.diff

[PATCH] D86895: [Modules] Add stats to measure performance of building and loading modules.

aprantl added a comment. This looks like a good idea — people will probably have some options on the names and descriptions of the statistics :-) Comment at: clang/lib/Frontend/CompilerInstance.cpp:60 + +ALWAYS_ENABLED_STATISTIC(NumCompileModule, "Number of compiled

[clang] 7da9419 - [MinGW][libclang] Allow simultaneous shared and static lib

Author: Mateusz Mikuła Date: 2020-09-12T22:03:43+03:00 New Revision: 7da941939902768af25ffa45149695a0a5f15951 URL: https://github.com/llvm/llvm-project/commit/7da941939902768af25ffa45149695a0a5f15951 DIFF:

[clang] bb61304 - [MinGW][clang-shlib] Build by default on MinGW

Author: Mateusz Mikuła Date: 2020-09-12T22:02:31+03:00 New Revision: bb613044b6800b8ccc238232677f905bda423819 URL: https://github.com/llvm/llvm-project/commit/bb613044b6800b8ccc238232677f905bda423819 DIFF:

[PATCH] D87517: [MinGW] Use lib prefix for libraries

This revision was automatically updated to reflect the committed changes. Closed by commit rGcc76965b1908: [MinGW] Use lib prefix for libraries (authored by mati865, committed by mstorsjo). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87517/new/

[PATCH] D87539: [MinGW][libclang] Allow simultaneous shared and static lib

mati865 added a comment. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87539/new/ https://reviews.llvm.org/D87539 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D87201: [clang-format] Add a option for the position of Java static import

JakeMerdichAMD accepted this revision. JakeMerdichAMD added a comment. This revision is now accepted and ready to land. Sorry on the delay, LGTM too. It looks like you're a first time contributor and probably don't have write access to the repo, do you want one of us to push this on your

[PATCH] D87537: [lld][WebAssembly] Error on import/export of mutable global without `mutable-globals` feature

tlively accepted this revision. tlively added a comment. This revision is now accepted and ready to land. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87537/new/ https://reviews.llvm.org/D87537

[PATCH] D87566: [Sema] Permit conversions to arrays of unknown bound

Mordante created this revision. Mordante added reviewers: lvoufo, rsmith. Mordante added a project: clang. Mordante requested review of this revision. This implements C++20's P0388. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D87566 Files: clang/lib/AST/ASTContext.cpp

[PATCH] D87547: [MinGW][clang-shlib] Build by default on MinGW

This revision was automatically updated to reflect the committed changes. Closed by commit rGbb613044b680: [MinGW][clang-shlib] Build by default on MinGW (authored by mati865, committed by mstorsjo). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] cc76965 - [MinGW] Use lib prefix for libraries

Author: Mateusz Mikuła Date: 2020-09-12T22:01:29+03:00 New Revision: cc76965b19085519278bff1052059e03769b71e8 URL: https://github.com/llvm/llvm-project/commit/cc76965b19085519278bff1052059e03769b71e8 DIFF:

[PATCH] D87539: [MinGW][libclang] Allow simultaneous shared and static lib

This revision was automatically updated to reflect the committed changes. Closed by commit rG7da941939902: [MinGW][libclang] Allow simultaneous shared and static lib (authored by mati865, committed by mstorsjo). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

Re: [clang] a8503b8 - [NFC] Remove unused static function

On Sat, Sep 12, 2020 at 1:15 AM Vitaly Buka wrote: > build fails with -DLLVM_ENABLE_WERROR=ON > Oh, I see - it's a -Wunused-function when building with LLVM_ENABLE_DUMP off. Kristof - if/when you want to recommit this, I think the only thing you need to do is make this function not

[PATCH] D86137: Add ignore-unknown-options flag to clang-format.

fodinabor updated this revision to Diff 291405. fodinabor added a comment. Address review comments, copy the help text into docs and add some basic unit tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86137/new/

[PATCH] D87565: [Sema] Improve const_cast conformance to N4261

Mordante created this revision. Mordante added reviewers: rjmccall, rsmith. Mordante added a project: clang. Mordante requested review of this revision. Allows `const_cast`s of similar non-record types. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D87565 Files:

[PATCH] D83154: clang: Add -fcoverage-prefix-map

keith added inline comments. Comment at: clang/lib/CodeGen/CoverageMappingGen.cpp:1334 + llvm::SmallString<256> Path(Filename); + llvm::sys::fs::make_absolute(Path); + llvm::sys::path::remove_dots(Path, /*remove_dot_dot=*/true); rnk wrote: > keith wrote: > >

[PATCH] D87561: [Sema] List conversion validate character array

Mordante created this revision. Mordante added reviewers: lvoufo, rsmith. Mordante added a project: clang. Mordante requested review of this revision. The function `TryListConversion` didn't properly validate the following part of the standard: Otherwise, if the parameter type is a character

[PATCH] D73425: [PPC] Fix platform definitions when compiling FreeBSD powerpc64 as LE

Bdragon28 added a comment. That's fair. Will just use a patch on the FreeBSD side and revisit after 11.0.0 is released. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73425/new/ https://reviews.llvm.org/D73425

[PATCH] D87163: [DSE] Switch to MemorySSA-backed DSE by default.

thakis added a comment. The fix-up breaks tests: http://45.33.8.238/linux/27687/step_12.txt Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87163/new/ https://reviews.llvm.org/D87163 ___ cfe-commits

[PATCH] D87163: [DSE] Switch to MemorySSA-backed DSE by default.

fhahn added a comment. In D87163#2269674 , @thakis wrote: > The fix-up breaks tests: http://45.33.8.238/linux/27687/step_12.txt Thanks, should already be fixed in d85ac6d577ac

[PATCH] D87563: [Sema] Improve overload resolution

Mordante created this revision. Mordante added reviewers: lvoufo, rsmith. Mordante added a project: clang. Mordante requested review of this revision. The overload resolution for initializer lists was incomplete. It did not properly take the number of elements in the target array into account.

[clang] f086e85 - [gcov] Assign names to some types and loaded values used in @__llvm_internal*

Author: Fangrui Song Date: 2020-09-12T22:42:37-07:00 New Revision: f086e85eea94a51eb42115496ac5d24f07bc8791 URL: https://github.com/llvm/llvm-project/commit/f086e85eea94a51eb42115496ac5d24f07bc8791 DIFF: https://github.com/llvm/llvm-project/commit/f086e85eea94a51eb42115496ac5d24f07bc8791.diff

[PATCH] D87201: [clang-format] Add a option for the position of Java static import

bc-lee marked an inline comment as done. bc-lee added a comment. It's okay for some reviewers to make this change on my behalf. Thanks for reviewing this! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87201/new/ https://reviews.llvm.org/D87201

[clang] 0fb2203 - [Docs] Fix --print-supported-cpus option rendering

Author: Travis Finkenauer Date: 2020-09-13T05:26:18Z New Revision: 0fb2203cd6c287e7438b7ac2571645066c63eeb6 URL: https://github.com/llvm/llvm-project/commit/0fb2203cd6c287e7438b7ac2571645066c63eeb6 DIFF: https://github.com/llvm/llvm-project/commit/0fb2203cd6c287e7438b7ac2571645066c63eeb6.diff

[PATCH] D86581: [clang-format] Handle shifts within conditions

Saldivarcher added a comment. @MyDeveloperDay looks like it's in master, thanks for committing for me! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86581/new/ https://reviews.llvm.org/D86581 ___

[PATCH] D85596: [Docs] Fix --print-supported-cpus option rendering

This revision was automatically updated to reflect the committed changes. Closed by commit rG0fb2203cd6c2: [Docs] Fix --print-supported-cpus option rendering (authored by tmfink, committed by mehdi_amini). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION