[PATCH] D87615: [clang][Driver] Force stack realignment on 32-bit Solaris/x86

ro added a comment. In D87615#2271646 , @efriedma wrote: > > X86Subtarget::initSubtargetFeatures claims that that stack is 16-byte aligned > on Solaris; if that's wrong, we should fix it, not force stack realignment. I missed that (my usual issue of

[PATCH] D87629: Thread safety analysis: Improve documentation for ASSERT_CAPABILITY

vasild added inline comments. Comment at: clang/docs/ThreadSafetyAnalysis.rst:452-454 +and terminating or throwing if the capability is not held. Presence of this +annotation causes the analysis to assume the capability is held at the point of +the call. See :ref:`mutexheader`,

[clang] c8ddf27 - Revert "[Sema] Address-space sensitive index check for unbounded arrays"

Author: Chris Hamilton Date: 2020-09-15T01:57:29-05:00 New Revision: c8ddf27ddbbe140d8acbcf1b2d3fdfbba253d02c URL: https://github.com/llvm/llvm-project/commit/c8ddf27ddbbe140d8acbcf1b2d3fdfbba253d02c DIFF:

[PATCH] D87352: Fix typo in doc ClangFormatStyleOptions.rst

MyDeveloperDay requested changes to this revision. MyDeveloperDay added a comment. This revision now requires changes to proceed. I have realized this is the wrong change The actual error is in Format.h clang/docs/ClangFormatStyleOption.rst is generated using the

[PATCH] D87673: [clangd] Don't use zlib when it's unavailable.

ArcsinX added reviewers: sammccall, kadircet, adamcz. ArcsinX added a comment. Unsure about test for this Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87673/new/ https://reviews.llvm.org/D87673 ___

[PATCH] D86137: Add ignore-unknown-options flag to clang-format.

fodinabor updated this revision to Diff 291826. fodinabor marked 9 inline comments as done. fodinabor added a comment. Unit test cleanups. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86137/new/ https://reviews.llvm.org/D86137 Files:

[PATCH] D87673: [clangd] Don't use zlib when it's unavailable.

ArcsinX updated this revision to Diff 291827. ArcsinX added a comment. Fix build Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87673/new/ https://reviews.llvm.org/D87673 Files: clang-tools-extra/clangd/index/Serialization.cpp Index:

[PATCH] D87352: Fix typo in Format.h

YangZhihui added a comment. In D87352#2273349 , @MyDeveloperDay wrote: > I have realized this is the wrong change > > The actual error is in Format.h > > clang/docs/ClangFormatStyleOption.rst is generated using the >

[PATCH] D87615: [clang][Driver] Force stack realignment on 32-bit Solaris/x86

ro added a comment. That claim of 16-byte alignment on Solaris is half-wrong: it's definitely wrong on Solaris, but seems to be true on Illumos. However, there's currently no way to distinguish the two other than checking `uname -v` at runtime in a native compiler. The configure triples

[PATCH] D87615: [X86] Fix stack alignment on 32-bit Solaris/x86

ro updated this revision to Diff 291837. ro added a reviewer: vitalybuka. ro added a comment. Herald added a project: Sanitizers. Herald added a subscriber: Sanitizers. Allow for whitespace differences in `vptr.cpp`. Tested on `amd64-pc-solaris2.11` with the previous `-mstackrealign` patch and

[PATCH] D87470: [Coroutine][Sema] Tighten the lifetime of symmetric transfer returned handle

junparser added a comment. Herald added a subscriber: modimo. @lxfind , could you backport this to branch 11? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87470/new/ https://reviews.llvm.org/D87470 ___

[PATCH] D87615: [X86] Fix stack alignment on 32-bit Solaris/x86

ro updated this revision to Diff 291831. ro retitled this revision from "[clang][Driver] Force stack realignment on 32-bit Solaris/x86" to "[X86] Fix stack alignment on 32-bit Solaris/x86". ro added a comment. Herald added subscribers: llvm-commits, hiraditya. Herald added a project: LLVM. Set

[PATCH] D87673: [clangd] Don't use zlib when it's unavailable.

ArcsinX created this revision. Herald added subscribers: cfe-commits, usaxena95, mstorsjo, kadircet, arphaman, jkorous. Herald added a project: clang. ArcsinX requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Without this patch `clangd` crashes at try to load

[PATCH] D87604: [X86] Convert integer _mm_reduce_* intrinsics to emit llvm.reduction intrinsics (PR47506)

RKSimon added a comment. In D87604#2272211 , @craig.topper wrote: > Longer term should we have a variadic version of this like > __builtin_shufflevector or __builtin_convertvector that can handle any > reduction? Yes, I was looking at what would be

[PATCH] D83814: [clangd] Add Random Forest runtime for code completion.

usaxena95 updated this revision to Diff 291813. usaxena95 added a comment. Fixed namespace. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83814/new/ https://reviews.llvm.org/D83814 Files: clang-tools-extra/clangd/CMakeLists.txt

[PATCH] D87352: Fix typo in doc ClangFormatStyleOptions.rst

YangZhihui added a comment. In D87352#2263416 , @MyDeveloperDay wrote: > LGTM, thank you for doing this.. Thanks, may me you can help me commit it : ) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D87615: [X86] Fix stack alignment on 32-bit Solaris/x86

ro added a subscriber: vitalybuka. ro added a comment. In D87615#2273427 , @ro wrote: > > Tested on `amd64-pc-solaris2.11`. However, compared to the `-mstackrealign` > version > there's one regression that I still need to investigate: > >

[PATCH] D86137: Add ignore-unknown-options flag to clang-format.

fodinabor added a comment. All comments should be adressed now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86137/new/ https://reviews.llvm.org/D86137 ___ cfe-commits mailing list

[PATCH] D87352: Fix typo in Format.h

YangZhihui updated this revision to Diff 291825. YangZhihui retitled this revision from "Fix typo in doc ClangFormatStyleOptions.rst" to "Fix typo in Format.h". CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87352/new/ https://reviews.llvm.org/D87352 Files:

[PATCH] D87590: Backport D79219, D85820, D86134 to 10.0 branch

labath added subscribers: tstellar, labath. labath added a reviewer: tstellar. labath added a comment. @tstellar, who is (was) the release manager for 10.0, can make a definitive call, but our usual modus operandi is to have one point release for each major version. I don't know if this is a

[PATCH] D87352: Fix typo in Format.h

MyDeveloperDay added a comment. Ok almost... so you change the Format.h, then run the docs/tools/clang_format_stype.py and attach both the rst and the .h to the review CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87352/new/ https://reviews.llvm.org/D87352

[PATCH] D87540: [clang-tidy] Fix false positive issue in performance-unnecessary-value-param for arguments being moved in the function body.

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/performance/UnnecessaryValueParamCheck.cpp:66 +bool isPassedToStdMove(const ParmVarDecl , ASTContext ) { + // Check if the parameter has a name, in case of functions like - Can

[PATCH] D86097: [OpenMP][AMDGCN] Generate global variables and attributes for AMDGCN

saiislam added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86097/new/ https://reviews.llvm.org/D86097 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D87450: [clangd] Implement hot index reloading for clangd-index-server

kadircet added a comment. Thanks! Mostly looks good, just couple of nits. Comment at: clang-tools-extra/clangd/index/remote/server/Server.cpp:223 +// whenever they become available. +void hotReload(clangd::SwapIndex *Index, llvm::StringRef IndexPath, +

[PATCH] D87450: [clangd] Implement hot index reloading for clangd-index-server

kbobyrev updated this revision to Diff 291861. kbobyrev marked 5 inline comments as done. kbobyrev added a comment. Address a round of comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87450/new/ https://reviews.llvm.org/D87450 Files:

[PATCH] D87627: [clang-tidy] Fix crash in modernize-use-noexcept on uninstantiated throw class

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/modernize/UseNoexceptCheck.cpp:81 + assert(FnTy && "FunctionProtoType is null."); + if (clang::isUnresolvedExceptionSpec(FnTy->getExceptionSpecType())) + return; No need for the

[PATCH] D86694: [scudo] Allow -fsanitize=scudo on Linux and Windows (WIP, don't land as is)

aganea added a comment. @russell.gallop I see a lots of failing tests when running `ninja check-all` on a Scudo-enabled build (stage 2). Do you see the same thing on your end? ==89136==ERROR: Scudo failed to allocate 0x1 (65536) bytes of memory at address 0x4c0090e00 (error code: 1455)

[PATCH] D87163: [DSE] Switch to MemorySSA-backed DSE by default.

thakis added a comment. It's not blocking us because we added an explicit flag to force this off to our build config for "normal" builds. (We still get the default-on behavior on our bots that build with trunk clang.) But if others are seeing problems with this too, I think it makes sense to

[PATCH] D85607: CfgTraits: add CfgInstructionRef

arsenm accepted this revision. arsenm added a comment. This revision is now accepted and ready to land. Herald added a subscriber: tatianashp. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85607/new/ https://reviews.llvm.org/D85607

[PATCH] D87081: [analyzer][StdLibraryFunctionsChecker] Elaborate the summary of fread and fwrite

martong added a comment. There is a blatant regression we introduced in D87240 . Actually, the test added here could have catched that regression. See https://reviews.llvm.org/D87240#inline-812062 I am putting back the modeling dependency with this patch.

[PATCH] D87607: [clang][aarch64] Support implicit casts between GNU and SVE vectors

c-rhodes added inline comments. Comment at: clang/lib/AST/ASTContext.cpp:8522 + return VT->getElementType().getCanonicalType() == + getBuiltinVectorTypeInfo(BT).ElementType; } efriedma wrote: > We allow casting SVE fixed-width

[PATCH] D87527: [ASTMatchers] Fix `hasBody` for the descendants of `FunctionDecl`

baloghadamsoftware updated this revision to Diff 291901. baloghadamsoftware added a comment. Created another matcher `hasAnyBody`, and updated the documentation of the matchers. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87527/new/ https://reviews.llvm.org/D87527 Files:

[PATCH] D87590: Backport D79219, D85820, D86134 to 10.0 branch

haampie added a comment. Also note that the changes are not likely to be backported to 11 even: https://reviews.llvm.org/rG31e5f7120bdd2f76337686d9d169b1c00e6ee69c#942622 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87590/new/

[PATCH] D87396: Sema: add support for `__attribute__((__swift_bridged_typedef__))`

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM with some test location nits. Comment at: clang/test/SemaObjC/attr-swift_bridged_typedef.m:2 +// RUN: %clang_cc1 -verify -fsyntax-only %s +// RUN: not

[PATCH] D87455: [clang-tidy] performance-unnecessary-copy-initialization: Restrict UnnecessaryCopyInitialization check to variables initialized from free functions without arguments

aaron.ballman closed this revision. aaron.ballman added a comment. In D87455#2271582 , @flx wrote: > Thank you for the review, Aaron! > > I don't have have commit access. Would you mind submitting it? I've commit on your behalf in

[PATCH] D87240: [analyzer][StdLibraryFunctionsChecker] Have proper weak dependencies

martong added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Checkers/Checkers.td:352 HelpText<"Improve modeling of the C standard library functions">, - Dependencies<[CallAndMessageModeling]>, CheckerOptions<[ Umm, we should not have

[PATCH] D87590: Backport D79219, D85820, D86134 to 10.0 branch

haampie added a comment. D86134 should not be added, it was reverted afterwards. What eventually landed was D85820 , which adds a better fix for what D86134 was supposed to solve. Repository:

[PATCH] D87590: Backport D79219, D85820, D86134 to 10.0 branch

labath added a comment. In D87590#2273721 , @haampie wrote: > Also note that the changes are not likely to be backported to 11 even: > https://reviews.llvm.org/rG31e5f7120bdd2f76337686d9d169b1c00e6ee69c#942622. 11.0.0, probably. There's should be enough

[PATCH] D87683: [clang-tidy] Crash fix for bugprone-misplaced-pointer-arithmetic-in-alloc

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87683/new/ https://reviews.llvm.org/D87683

[PATCH] D86532: (Urgent!) [docs][analyzer] Add documentation for alpha.fuchsia.Lock and alpha.core.C11Lock

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. lgtm please commit so this makes it into the release. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86532/new/ https://reviews.llvm.org/D86532

[PATCH] D86533: (Urgent!) [release][docs][analyzer] Add 11.0.0. release notes

hans accepted this revision. hans added a comment. This has probably had enough time for review. Please commit. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86533/new/ https://reviews.llvm.org/D86533 ___ cfe-commits mailing list

[PATCH] D83814: [clangd] Add Random Forest runtime for code completion.

usaxena95 updated this revision to Diff 291909. usaxena95 added a comment. Fixed namespace ending. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83814/new/ https://reviews.llvm.org/D83814 Files: clang-tools-extra/clangd/CMakeLists.txt

[PATCH] D87686: [clang-tidy] Improve documentation on Clangd integration

kbobyrev created this revision. kbobyrev added a reviewer: hokein. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, xazax.hun. Herald added a project: clang. kbobyrev requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. The integration is

[clang-tools-extra] 98e07b5 - Restrict UnnecessaryCopyInitialization check to variables initialized from free functions without arguments

Author: Felix Berger Date: 2020-09-15T08:46:04-04:00 New Revision: 98e07b5596c8692c43770bc4e21a2b19467e35f7 URL: https://github.com/llvm/llvm-project/commit/98e07b5596c8692c43770bc4e21a2b19467e35f7 DIFF: https://github.com/llvm/llvm-project/commit/98e07b5596c8692c43770bc4e21a2b19467e35f7.diff

[PATCH] D87607: [clang][aarch64] Support implicit casts between GNU and SVE vectors

c-rhodes updated this revision to Diff 291891. c-rhodes edited the summary of this revision. c-rhodes added a comment. Added tests for implicit casts between GNU and fixed-length SVE vectors. I was planning to create a separate patch for this but since it's only tests and no functional changes

[PATCH] D86562: [OPENMP][NFC]Release notes for OpenMP in clang (11.x).

ABataev added a comment. In D86562#2274036 , @hans wrote: > Please go ahead and commit. Hi Hans, can you commit it yourself? I have some technical issues and not able to commit it. And I don't know when it is going to be resolved. :( Repository: rG

[PATCH] D87540: [clang-tidy] Fix false positive issue in performance-unnecessary-value-param for arguments being moved in the function body.

riccibruno added inline comments. Comment at: clang-tools-extra/clang-tidy/performance/UnnecessaryValueParamCheck.cpp:74 + // parmVarDecl picked up by this checker. It will be an empty string and will + // lead to an assertion failure when using hasName(std::string) being

[PATCH] D86958: [Docs] Add/update release notes for D71913 (LTO WPD changes)

hans added a comment. Please go ahead and commit to the branch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86958/new/ https://reviews.llvm.org/D86958 ___ cfe-commits mailing list

[PATCH] D86562: [OPENMP][NFC]Release notes for OpenMP in clang (11.x).

hans added a comment. Please go ahead and commit. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86562/new/ https://reviews.llvm.org/D86562 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D87686: [clang-tidy] Improve documentation on Clangd integration

hokein added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/Integrations.rst:5 .. _Clangd: https://clang.llvm.org/extra/clangd.html +.. _is available: https://clangd.llvm.org/installation.html#editor-plugins nit: update to the official website

[PATCH] D87683: [clang-tidy] Crash fix for bugprone-misplaced-pointer-arithmetic-in-alloc

baloghadamsoftware created this revision. baloghadamsoftware added reviewers: gribozavr2, aaron.ballman. baloghadamsoftware added a project: clang-tools-extra. Herald added subscribers: martong, steakhal, gamesh411, Szelethus, dkrupp, rnkovacs, xazax.hun, whisperity. Herald added a project:

[PATCH] D87163: [DSE] Switch to MemorySSA-backed DSE by default.

fhahn added a comment. In D87163#2272749 , @asbirlea wrote: > I'd suggest reverting if the failures are blocking, but we do need a > reproducer so it can be recommitted after a fix is in place. +1, but I think ideally we would have reproducers for the

[PATCH] D87163: [DSE] Switch to MemorySSA-backed DSE by default.

fhahn added a comment. In D87163#2273917 , @thakis wrote: > It's not blocking us because we added an explicit flag to force this off to > our build config for "normal" builds. (We still get the default-on behavior > on our bots that build with trunk

[PATCH] D78902: [Driver] Add output file to properties of Command

sepavloff updated this revision to Diff 291899. sepavloff added a comment. Rebase and ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78902/new/ https://reviews.llvm.org/D78902 Files: clang/include/clang/Driver/Job.h

[PATCH] D87607: [clang][aarch64] Support implicit casts between GNU and SVE vectors

c-rhodes added inline comments. Comment at: clang/test/Sema/attr-arm-sve-vector-bits.c:233-234 +svint64_t to_svint64_t__from_gnu_int32_t(gnu_int32_t x) { return x; } // expected-error-re {{returning 'gnu_int32_t' (vector of {{[0-9]+}} 'int32_t' values) from a function with

[PATCH] D87081: [analyzer][StdLibraryFunctionsChecker] Elaborate the summary of fread and fwrite

This revision was automatically updated to reflect the committed changes. Closed by commit rGa012bc4c42e4: [analyzer][StdLibraryFunctionsChecker] Elaborate the summary of fread and fwrite (authored by martong). Changed prior to commit: https://reviews.llvm.org/D87081?vs=291606=291919#toc

[PATCH] D86533: (Urgent!) [release][docs][analyzer] Add 11.0.0. release notes

hans added a comment. No worries :) Thanks for the notes! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86533/new/ https://reviews.llvm.org/D86533 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D84362: [NFC] Add missing functions to PartialDiagnostic

aaron.ballman added a reviewer: rsmith. aaron.ballman added a subscriber: rsmith. aaron.ballman added a comment. In D84362#2271585 , @tra wrote: > So, the idea here is to do some sort of duck-typing and allow DiagBuilder to > work with both

[PATCH] D87163: [DSE] Switch to MemorySSA-backed DSE by default.

dmajor added a comment. Here is a reduced-ish repro, I can keep poking at it but maybe this is sufficient for you to notice something: https://godbolt.org/z/endf6d. Center pane is old DSE, right pane is new DSE. I highlighted the problem area with a nop at line 56 of the source, and line 59 of

[PATCH] D86694: [scudo] Allow -fsanitize=scudo on Linux and Windows (WIP, don't land as is)

russell.gallop added a comment. In D86694#2273815 , @aganea wrote: > @russell.gallop I see a lots of failing tests when running `ninja check-all` > on a Scudo-enabled build (stage 2). Do you see the same thing on your end? Not a lot but a few, including

[PATCH] D83004: [UpdateCCTestChecks] Include generated functions if asked

greened added a comment. In D83004#2168427 , @jdoerfert wrote: > Due to D82995 I realized we should have a > test of this in `llvm/test/tools/UpdateTestChecks` as well. Do you mean a test for recognizing the option in

[PATCH] D86694: [scudo] Allow -fsanitize=scudo on Linux and Windows (WIP, don't land as is)

cryptoad added a comment. In D86694#2274548 , @russell.gallop wrote: > I guess using scudo as a general purpose allocator that could set a limit on > the number of cores that can be used at once as @aganea found. Would there be > any problem with

[PATCH] D87163: [DSE] Switch to MemorySSA-backed DSE by default.

fhahn added a comment. In D87163#2274549 , @dmajor wrote: > Reduced a bit more: https://godbolt.org/z/j59evK (C++) and > https://godbolt.org/z/8xG688 (IR) -- the store at line 43 of `while.end` has > been removed. Thanks! I reverted the change for now

[PATCH] D83004: [UpdateCCTestChecks] Include generated functions if asked

jdoerfert added a comment. In D83004#2274573 , @greened wrote: > In D83004#2168427 , @jdoerfert wrote: > >> Due to D82995 I realized we should have a >> test of this in

[PATCH] D81930: [AArch64] Add -mmark-bti-property flag.

danielkiss updated this revision to Diff 291922. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81930/new/ https://reviews.llvm.org/D81930 Files: clang/include/clang/Driver/Options.td clang/lib/Driver/ToolChains/Clang.cpp clang/test/Driver/arm64-markbti.S

[PATCH] D76599: Represent FP options in AST by special Statement node

sepavloff abandoned this revision. sepavloff added a comment. FPOptions is now stored in AST objects. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76599/new/ https://reviews.llvm.org/D76599 ___

[PATCH] D77545: Represent FP options in AST by special Expression node

sepavloff abandoned this revision. sepavloff added a comment. FPOptions is now stored in AST objects. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77545/new/ https://reviews.llvm.org/D77545 ___

[PATCH] D86562: [OPENMP][NFC]Release notes for OpenMP in clang (11.x).

hans added a comment. In D86562#2274039 , @ABataev wrote: > In D86562#2274036 , @hans wrote: > >> Please go ahead and commit. > > Hi Hans, can you commit it yourself? I have some technical issues and not > able to

[PATCH] D87532: Sema: add support for `__attribute__((__swift_bridge__))`

compnerd added inline comments. Comment at: clang/include/clang/Basic/Attr.td:2133 +def SwiftBridge : Attr { + let Spellings = [GNU<"swift_bridge">]; aaron.ballman wrote: > Is this a type or a declaration attribute? It looks like a declaration > attribute

[PATCH] D77882: [clang-tidy] Add option to use alpha checkers from clang-analyzer when using `run-clang-tidy.py`

hans added a comment. In D77882#2274570 , @Abpostelnicu wrote: > Has been pushed to the 11.x branch > https://github.com/llvm/llvm-project/commit/1596c2dfd548b21cf33ad3353882ac465d78c1bb Great, that was the missing piece :) Thanks! Repository: rG

[PATCH] D87607: [clang][aarch64] Support implicit casts between GNU and SVE vectors

c-rhodes added inline comments. Comment at: clang/test/Sema/attr-arm-sve-vector-bits.c:233-234 +svint64_t to_svint64_t__from_gnu_int32_t(gnu_int32_t x) { return x; } // expected-error-re {{returning 'gnu_int32_t' (vector of {{[0-9]+}} 'int32_t' values) from a function with

[PATCH] D83814: [clangd] Add Random Forest runtime for code completion.

adamcz added a comment. Looks good to me overall, some minor style comments included ;-) Do we expect this to be a generic model code generator that gets reused for other things? If not, maybe we can hardcode more (like the namespace, class name, etc), but if you think there's other use cases

[PATCH] D86532: (Urgent!) [docs][analyzer] Add documentation for alpha.fuchsia.Lock and alpha.core.C11Lock

This revision was automatically updated to reflect the committed changes. Closed by commit rG7c6f5b7fbf5a: [analyzer] Add documentation for alpha.fuchsia.Lock and alpha.core.C11Lock (authored by Szelethus). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 7c6f5b7 - [analyzer] Add documentation for alpha.fuchsia.Lock and alpha.core.C11Lock

Author: Kristóf Umann Date: 2020-09-15T16:55:44+02:00 New Revision: 7c6f5b7fbf5a9eee7f3ef9192c354d1536a8f1c6 URL: https://github.com/llvm/llvm-project/commit/7c6f5b7fbf5a9eee7f3ef9192c354d1536a8f1c6 DIFF: https://github.com/llvm/llvm-project/commit/7c6f5b7fbf5a9eee7f3ef9192c354d1536a8f1c6.diff

[PATCH] D86694: [scudo] Allow -fsanitize=scudo on Linux and Windows (WIP, don't land as is)

cryptoad added a comment. In D86694#2273815 , @aganea wrote: > If 4.4 TB of virtual pages are mapped in each process (this happens on > startup), then we quickly exaust the 48-bit (256 TB) addressable space with > 72+ programs running (on a 36-core).

[PATCH] D87611: [SystemZ][z/OS] Set aligned allocation unavailable by default for z/OS

fanbo-meng added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:7216 "aligned %select{allocation|deallocation}0 function of type '%1' is only " "available on %2 %3 or newer">; +def err_aligned_allocation_unavailable_on_os : Error<

[PATCH] D86562: [OPENMP][NFC]Release notes for OpenMP in clang (11.x).

ABataev added a comment. In D86562#2274595 , @hans wrote: > In D86562#2274039 , @ABataev wrote: > >> In D86562#2274036 , @hans wrote: >> >>> Please go ahead and commit. >>

[PATCH] D87425: [CodeGen][typeid] Emit typeinfo directly if type is known at compile-time

hans added a comment. >> I think it would be safer to do the change purely as an optimization in >> codegen (maybe we could add a new helper method that could also be used by >> the warning). > > For "optimization in codegen", do you mean optimization after the IR is > generated or like I

[PATCH] D77882: [clang-tidy] Add option to use alpha checkers from clang-analyzer when using `run-clang-tidy.py`

hans added a comment. This seems to have caused https://bugs.llvm.org/show_bug.cgi?id=47512 Can you take a look? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77882/new/ https://reviews.llvm.org/D77882

[PATCH] D87587: [clang-format][PR47290] Make one-line namespaces resistant to FixNamespaceComments, update documentation

MyDeveloperDay added a comment. Firstly let me say thank you for the patch, and taking the time to listen to the reviewers. Please don't be discouraged by my reply/opinon. > a) adding a new option means increasing our maintenance cost by possibly > adding a rarely-used switch (which I also

[clang] 3bc3983 - Fix bot failure after ccb4124a4172

Author: Nemanja Ivanovic Date: 2020-09-15T12:36:47-05:00 New Revision: 3bc3983f229f9277d5bea3692b691f72ab8740dd URL: https://github.com/llvm/llvm-project/commit/3bc3983f229f9277d5bea3692b691f72ab8740dd DIFF:

[PATCH] D86533: (Urgent!) [release][docs][analyzer] Add 11.0.0. release notes

Szelethus added a comment. Sorry for the slack (which is kind of ironic with my attention grabbing title :) ). Landed in rG791b7e9f73e0064153a7c3db8045a7333a8c390c . Thanks everyone! CHANGES SINCE LAST ACTION

[PATCH] D87701: Do not apply calling conventions to MSVC entry points

eandrews created this revision. eandrews added reviewers: rnk, erichkeane. eandrews requested review of this revision. Fix link error for MSVC entry points when calling conventions are specified. MSVC entry points should have default calling convention. https://reviews.llvm.org/D87701 Files:

[PATCH] D77882: [clang-tidy] Add option to use alpha checkers from clang-analyzer when using `run-clang-tidy.py`

Abpostelnicu added a comment. In D77882#2274292 , @hans wrote: > This seems to have caused https://bugs.llvm.org/show_bug.cgi?id=47512 > > Can you take a look? Are you sure? This has been fixed from august in trunk

[PATCH] D87702: [Frontend] Add pragma align natural and sort out pragma pack stack effect

Xiangling_L created this revision. Xiangling_L added reviewers: jasonliu, hubert.reinterpretcast, efriedma, jyknight, rnk, rsmith, aaron.ballman. Herald added subscribers: cfe-commits, dang. Herald added a project: clang. Xiangling_L requested review of this revision. 1. Implementing the natural

[PATCH] D87163: [DSE] Switch to MemorySSA-backed DSE by default.

dmajor added a comment. Reduced a bit more: https://godbolt.org/z/j59evK (C++) and https://godbolt.org/z/8xG688 (IR) -- the store at line 43 of `while.end` has been removed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87163/new/

[PATCH] D72705: [analyzer] Added new checker 'alpha.unix.ErrorReturn'.

balazske added a comment. I am not sure if this checker is worth to further development. A part of the found bugs can be detected with other checkers too, specially if the preconditions of many standard functions are checked (more than what is done now) and by modeling the function calls with

[PATCH] D79432: [analyzer] StdLibraryFunctionsChecker: Add summaries for libc

balazske added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp:1123-1124 + "abs", Summary(ArgTypes{IntTy}, RetType{IntTy}, EvalCallAsPure) + .Case({ArgumentCondition(0, WithinRange, SingleValue(0)), +

[PATCH] D87683: [clang-tidy] Crash fix for bugprone-misplaced-pointer-arithmetic-in-alloc

njames93 added a comment. Please fix the test case first, can't call `operator new(unsigned long, void*)` with an argument of type `void*` The other failures the pre merge bot detected can safely be disregarded Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D87527: [ASTMatchers] Fix `hasBody` for the descendants of `FunctionDecl`

ymandel accepted this revision. ymandel added a comment. Thanks, this looks great! But, can you also please update https://github.com/llvm/llvm-project/blob/master/clang-tools-extra/clang-tidy/modernize/UseEqualsDeleteCheck.cpp#L39, since it depends on the current semantics? CHANGES SINCE

[PATCH] D87683: [clang-tidy] Crash fix for bugprone-misplaced-pointer-arithmetic-in-alloc

baloghadamsoftware added a comment. In D87683#2274569 , @njames93 wrote: > Please fix the test case first, can't call `operator new(unsigned long, > void*)` with an argument of type `void*` > The other failures the pre merge bot detected can safely be

[PATCH] D86097: [OpenMP][AMDGCN] Generate global variables and attributes for AMDGCN

ABataev added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.h:684 const OffloadDeviceGlobalVarEntryInfoActTy ); - private: Restore original formatting Comment at: clang/lib/CodeGen/CGOpenMPRuntime.h:2482-2487

[PATCH] D87652: Sema: add support for `__attribute__((__swift_newtype__))`

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/Attr.td:2179 +def SwiftNewType : InheritableAttr { + let Spellings = [GNU<"swift_newtype">, GNU<"swift_wrapper">]; + let Args = [EnumArgument<"NewtypeKind", "NewtypeKind", We don't ever

[PATCH] D81930: [AArch64] Add -mmark-bti-property flag.

danielkiss marked 4 inline comments as done. danielkiss added a comment. @nickdesaulniers Thanks for the review, comments are addressed. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81930/new/ https://reviews.llvm.org/D81930 ___ cfe-commits

[PATCH] D86958: [Docs] Add/update release notes for D71913 (LTO WPD changes)

tejohnson added a comment. In D86958#2274040 , @hans wrote: > Please go ahead and commit to the branch. Sorry, I thought I already did! Just pushed the commit. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D86694: [scudo] Allow -fsanitize=scudo on Linux and Windows (WIP, don't land as is)

russell.gallop added a comment. In D86694#2274383 , @cryptoad wrote: > In D86694#2273815 , @aganea wrote: > >> If 4.4 TB of virtual pages are mapped in each process (this happens on >> startup), then we quickly

[PATCH] D77882: [clang-tidy] Add option to use alpha checkers from clang-analyzer when using `run-clang-tidy.py`

Abpostelnicu added a comment. Has been pushed to the 11.x branch https://github.com/llvm/llvm-project/commit/1596c2dfd548b21cf33ad3353882ac465d78c1bb Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77882/new/ https://reviews.llvm.org/D77882

[PATCH] D86958: [Docs] Add/update release notes for D71913 (LTO WPD changes)

hans added a comment. I see it now. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86958/new/ https://reviews.llvm.org/D86958 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] a012bc4 - [analyzer][StdLibraryFunctionsChecker] Elaborate the summary of fread and fwrite

Author: Gabor Marton Date: 2020-09-15T16:35:39+02:00 New Revision: a012bc4c42e4408a18e4c4d67306b79c576df961 URL: https://github.com/llvm/llvm-project/commit/a012bc4c42e4408a18e4c4d67306b79c576df961 DIFF: https://github.com/llvm/llvm-project/commit/a012bc4c42e4408a18e4c4d67306b79c576df961.diff

[PATCH] D82598: [analyzer][Liveness][NFC] Get rid of statement liveness, because such a thing doesn't exist

This revision was automatically updated to reflect the committed changes. Closed by commit rGdd1d5488e47d: [analyzer][Liveness][NFC] Get rid of statement liveness, because such a thing… (authored by Szelethus). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

  1   2   >