[PATCH] D66782: SourceManager: Prefer Optional over MemoryBuffer*

shafik added a comment. `ASTImporter` changes looks good. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66782/new/ https://reviews.llvm.org/D66782 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D88929: [OpenMP] Change CMake Configuration to Build for Highest CUDA Architecture by Default

ye-luo requested changes to this revision. ye-luo added inline comments. This revision now requires changes to proceed. Comment at: openmp/libomptarget/deviceRTLs/nvptx/CMakeLists.txt:80 + else() +list(APPEND compute_capabilities ${CMAKE_MATCH_1}) + endif()

[PATCH] D88929: [OpenMP] Change CMake Configuration to Build for Highest CUDA Architecture by Default

jhuber6 added inline comments. Comment at: openmp/libomptarget/deviceRTLs/nvptx/CMakeLists.txt:80 + else() +list(APPEND compute_capabilities ${CMAKE_MATCH_1}) + endif() ye-luo wrote: > 1. Doesn't work right now. Missing comma

[clang] 5a3f6bf - Reapply "[OpenMP][FIX] Verify compatible types for declare variant calls" D88384

Author: Johannes Doerfert Date: 2020-10-07T00:06:51-05:00 New Revision: 5a3f6bfe8a71b94728597aee12a4c36949d5f6af URL: https://github.com/llvm/llvm-project/commit/5a3f6bfe8a71b94728597aee12a4c36949d5f6af DIFF:

[PATCH] D88929: [OpenMP] Change CMake Configuration to Build for Highest CUDA Architecture by Default

ye-luo added a comment. In D88929#2315640 , @JonChesterfield wrote: > An alternative approach is to build the deviceRTL for multiple cuda versions > and then pick whichever one is the best fit when compiling application code. > That has advantages when

[PATCH] D88929: [OpenMP] Change CMake Configuration to Build for Highest CUDA Architecture by Default

jhuber6 updated this revision to Diff 296577. jhuber6 added a comment. Removing redundant call to `find_package`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88929/new/ https://reviews.llvm.org/D88929 Files: clang/CMakeLists.txt

[PATCH] D88929: [OpenMP] Change CMake Configuration to Build for Highest CUDA Architecture by Default

ye-luo added inline comments. Comment at: openmp/libomptarget/deviceRTLs/nvptx/CMakeLists.txt:80 + else() +list(APPEND compute_capabilities ${CMAKE_MATCH_1}) + endif() jhuber6 wrote: > ye-luo wrote: > > 1. Doesn't work right now. Missing comma

[PATCH] D88929: [OpenMP] Change CMake Configuration to Build for Highest CUDA Architecture by Default

ye-luo added inline comments. Comment at: openmp/libomptarget/deviceRTLs/nvptx/CMakeLists.txt:92 foreach(sm ${nvptx_sm_list}) set(CUDA_ARCH ${CUDA_ARCH} -gencode arch=compute_${sm},code=sm_${sm}) endforeach() my point 2 refers to here CUDA_ARCH which

[PATCH] D88491: [ASTContext] Use AllowCXX in all merge*Type methods, strip references

jdoerfert abandoned this revision. jdoerfert added a comment. Changing the assume to a proper exit did the trick for the tests. I recommited D88384 with that minor modification. Apologies for the noise. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D86959: [clang-format] Fix formatting of _Atomic() qualifier

sammccall added a comment. Sorry to be really late here, but this patch regressed some macro definitions like: #define lambda [](const decltype(x) ) {} which now formats as #define lambda [](const decltype(x) & ptr) {} (extra space around ampersand) It looks like the generalization of

[PATCH] D87449: [clang-tidy] Add new check for SEI CERT rule SIG30-C

balazske marked 3 inline comments as done. balazske added inline comments. Comment at: clang-tools-extra/clang-tidy/cert/SignalHandlerCheck.cpp:117-118 +FunctionCallCollector Collector{[](const CallExpr *CE) { + if (isa(CE->getCalleeDecl())) +

[PATCH] D88828: [clangd] Verify the diagnostic code in include-fixer diagnostic tests, NFC.

hokein added a comment. In D88828#2311679 , @kadircet wrote: > LGTM, but can you add some description about why you've decided to do it now > :D yeah, this comes up when I read the code, I think it is easier to spot which diagnostics in the

[PATCH] D84322: [AST][RecoveryExpr] Part3: Suppress spurious "typecheck_cond_expect_scalar" diagnostic

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang/test/AST/ast-dump-recovery.c:75 + + // conditional operator + float f; add to comment: (comparison is invalid)

[clang-tools-extra] 48a82c4 - [clangd] Verify the diagnostic code in include-fixer diagnostic tests, NFC.

Author: Haojian Wu Date: 2020-10-06T11:02:22+02:00 New Revision: 48a82c42457b47936d8e1f4b2af6a1f3cbb6e992 URL: https://github.com/llvm/llvm-project/commit/48a82c42457b47936d8e1f4b2af6a1f3cbb6e992 DIFF: https://github.com/llvm/llvm-project/commit/48a82c42457b47936d8e1f4b2af6a1f3cbb6e992.diff

[PATCH] D88828: [clangd] Verify the diagnostic code in include-fixer diagnostic tests, NFC.

This revision was automatically updated to reflect the committed changes. Closed by commit rG48a82c42457b: [clangd] Verify the diagnostic code in include-fixer diagnostic tests, NFC. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D88833: [clang-tidy] Do not warn on pointer decays in system macros

njames93 added a comment. Can you please upload this diff with full context `-U99` Comment at: clang-tools-extra/clang-tidy/cppcoreguidelines/ProBoundsArrayToPointerDecayCheck.cpp:50 + +AST_MATCHER(ImplicitCastExpr, isArrayToPointerDecay) { + return Node.getCastKind() ==

[PATCH] D88154: Initial support for vectorization using Libmvec (GLIBC vector math library).

venkataramanan.kumar.llvm added a comment. Pinging for review comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88154/new/ https://reviews.llvm.org/D88154 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D88881: [clangd] Add a NewName optional parameter to clangdServer::prepareRename.

sammccall added a comment. Can you add a bit more context to the commit message? And should we expose this as an extension on `textDocument/prepareRename`? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1/new/ https://reviews.llvm.org/D1

[PATCH] D88875: [clangd] Add basic keyword-name-validation in rename.

sammccall added inline comments. Comment at: clang-tools-extra/clangd/refactor/Rename.cpp:124 + + // name validation. + RenameToKeywords, nit: not sure we need a separate section for these, I can imagine at most keyword/conflict/shadow

[PATCH] D88844: [clangd] Add `score` extension to workspace/symbol response.

kadircet accepted this revision. kadircet added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/FindSymbols.cpp:125 +Info.score = Score / Relevance.NameMatch; Top.push({Score, std::move(Info)});

[PATCH] D84322: [AST][RecoveryExpr] Part3: Suppress spurious "typecheck_cond_expect_scalar" diagnostic

hokein added inline comments. Comment at: clang/test/Sema/error-dependence.c:18 + // type is required" is not emitted. + ptr > f ? ptr : f; // expected-error {{invalid operands to binary expression}} +} sammccall wrote: > nit: parens would help me understand

[PATCH] D84322: [AST][RecoveryExpr] Part3: Suppress spurious "typecheck_cond_expect_scalar" diagnostic

hokein updated this revision to Diff 296374. hokein added a comment. rebase and add ast-dump test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84322/new/ https://reviews.llvm.org/D84322 Files: clang/lib/Sema/SemaExpr.cpp

[PATCH] D88881: [clangd] Add a NewName optional parameter to clangdServer::prepareRename.

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/ClangdLSPServer.cpp:797 Server->prepareRename( - Params.textDocument.uri.file(), Params.position, Opts.Rename, +

Re: Upcoming upgrade of LLVM buildbot

Hello everyone, The staging buildbot was up and running for 6 days now, and looks good. Tomorrow at 12:00 PM PDT we will switch the production buildbot to the new version. If you are a bot owner, you do not need to do anything at this point, unless I'll ask you to help. The buildbot will go

[PATCH] D88680: Add ability to turn off -fpch-instantiate-templates in clang-cl

llunak added a comment. LGTM, although I'm not sure if me saying that is enough. I'll commit this in few days if nobody says anything else. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88680/new/ https://reviews.llvm.org/D88680

[clang-tools-extra] 77d3b14 - [clangd] Fix an inconsistent ReasonToReject enum usage, NFC.

Author: Haojian Wu Date: 2020-10-06T10:17:47+02:00 New Revision: 77d3b14458dd2aaafa20e6172a893cf0abab6453 URL: https://github.com/llvm/llvm-project/commit/77d3b14458dd2aaafa20e6172a893cf0abab6453 DIFF: https://github.com/llvm/llvm-project/commit/77d3b14458dd2aaafa20e6172a893cf0abab6453.diff

[PATCH] D54222: [clang-tidy] Add a check to detect returning static locals in public headers

JonasToth added a comment. I am confused now, but richard knows this stuff very well! The patches you referenced showed only cases where the static was defined in an inline-header definition (and templates). Does this make a difference on the semantics? This should be clear before we continue.

[PATCH] D88875: [clangd] Add basic keyword-name-validation in rename.

hokein created this revision. hokein added a reviewer: sammccall. Herald added subscribers: usaxena95, kadircet, arphaman. Herald added a project: clang. hokein requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Repository: rG LLVM Github Monorepo

[PATCH] D88881: [clangd] Add a NewName optional parameter to clangdServer::prepareRename.

hokein created this revision. hokein added a reviewer: sammccall. Herald added subscribers: usaxena95, kadircet, arphaman. Herald added a project: clang. hokein requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. so that our embedders can implement customized

[PATCH] D88844: [clangd] Add `score` extension to workspace/symbol response.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3cb1220709fa: [clangd] Add `score` extension to workspace/symbol response. (authored by sammccall). Changed prior to commit:

[clang-tools-extra] 3cb1220 - [clangd] Add `score` extension to workspace/symbol response.

Author: Sam McCall Date: 2020-10-06T11:57:38+02:00 New Revision: 3cb1220709fa556d4d29ce0e25fd30a16895ae24 URL: https://github.com/llvm/llvm-project/commit/3cb1220709fa556d4d29ce0e25fd30a16895ae24 DIFF: https://github.com/llvm/llvm-project/commit/3cb1220709fa556d4d29ce0e25fd30a16895ae24.diff

[PATCH] D88415: [clangd] Introduce memory usage dumping to TUScheduler, for Preambles and ASTCache

sammccall added inline comments. Comment at: clang-tools-extra/clangd/TUScheduler.cpp:1445 +void TUScheduler::attachMemoryUsage(MemoryTree ) const { + IdleASTs->attachMemoryUsage(*MT.addChild("ast_cahe")); + // Otherwise preambles are stored on disk and we only keep filename

[PATCH] D84226: [AST][RecoveryExpr] Part1: Support dependent binary operator in C for error recovery.

hokein updated this revision to Diff 296367. hokein marked 2 inline comments as done. hokein added a comment. address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84226/new/ https://reviews.llvm.org/D84226 Files:

[clang] 70d9dc8 - [AST][RecoveryExpr] Support dependent binary operator in C for error recovery.

Author: Haojian Wu Date: 2020-10-06T08:53:31+02:00 New Revision: 70d9dc867417ac63fe280ab145776f75a9487f0f URL: https://github.com/llvm/llvm-project/commit/70d9dc867417ac63fe280ab145776f75a9487f0f DIFF: https://github.com/llvm/llvm-project/commit/70d9dc867417ac63fe280ab145776f75a9487f0f.diff

[PATCH] D84226: [AST][RecoveryExpr] Part1: Support dependent binary operator in C for error recovery.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG70d9dc867417: [AST][RecoveryExpr] Support dependent binary operator in C for error recovery. (authored by hokein). Repository: rG LLVM Github

[PATCH] D88472: [clangd] Don't set the Underlying bit on targets of UsingDecls.

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. LG, thanks for all the iterations here. I do want to solve the regression but we can land without that. Comment at: clang-tools-extra/clangd/FindTarget.cpp:345 }

[PATCH] D88680: Add ability to turn off -fpch-instantiate-templates in clang-cl

hans added inline comments. Comment at: clang/test/Driver/pch-instantiate-templates.c:2 +// CL driver test cases +// RUN: %clang_cl -### /Yc /Fpfoo.pch /Fofoo.obj %s 2>&1 | FileCheck --check-prefix=CLANG_CL_YC %s +// RUN: %clang -### --driver-mode=cl /Yc /Fpfoo.pch /Fofoo.obj

[PATCH] D88680: Add ability to turn off -fpch-instantiate-templates in clang-cl

shivanshu3 updated this revision to Diff 296393. shivanshu3 added a comment. Address Hans' comments - Prepend %s with "--" for clang-cl - Remove a redundant test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88680/new/

[PATCH] D87279: [clang] Fix handling of physical registers in inline assembly operands.

jonpa added reviewers: RKSimon, jyu2, t.p.northover, echristo, dylanmckay, aaron.ballman. jonpa added a comment. Herald added a subscriber: pengfei. Ping! Last chance for anyone to speak up about any objections to committing this... CHANGES SINCE LAST ACTION

[PATCH] D88875: [clangd] Add basic keyword-name-validation in rename.

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/ClangdServer.cpp:416 +auto Results = clangd::rename( +{Pos, /*NewName=*/"__clangd_rename_dummy", InpAST->AST,

[PATCH] D88875: [clangd] Add basic keyword-name-validation in rename.

hokein added inline comments. Comment at: clang-tools-extra/clangd/ClangdServer.cpp:416 +auto Results = clangd::rename( +{Pos, /*NewName=*/"__clangd_rename_dummy", InpAST->AST, File, + RenameOpts.AllowCrossFile ? nullptr : Index, RenameOpts});

[PATCH] D88885: [clangd] Disambiguate overloads of std::move for header insertion.

kadircet added inline comments. Comment at: clang-tools-extra/clangd/index/SymbolCollector.cpp:563 if (auto Header = getIncludeHeader(QName, Entry.second)) { +// Hack: there are two std::move() overloads from different headers. +// CanonicalIncludes

[clang] f0a78bd - [AArch64] Correct parameter type for unsigned Neon scalar shift intrinsics

Author: David Spickett Date: 2020-10-06T11:34:58+01:00 New Revision: f0a78bdfdc6d56b25e0081884580b3960a3c2429 URL: https://github.com/llvm/llvm-project/commit/f0a78bdfdc6d56b25e0081884580b3960a3c2429 DIFF:

[PATCH] D88013: [AArch64] Correct parameter type for unsigned Neon scalar shift intrinsics

This revision was automatically updated to reflect the committed changes. Closed by commit rGf0a78bdfdc6d: [AArch64] Correct parameter type for unsigned Neon scalar shift intrinsics (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D88886: [Clang][unittests][NFC] Break up test in Callbacks.cpp

stefanp created this revision. stefanp added a reviewer: nemanjai. Herald added a subscriber: mgorny. Herald added a project: clang. stefanp requested review of this revision. The Callbacks.cpp test was taking a long time to compile on some build bots causing timeouts. This patch splits up that

[PATCH] D88875: [clangd] Add basic keyword-name-validation in rename.

hokein updated this revision to Diff 296438. hokein marked an inline comment as done. hokein added a comment. address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88875/new/ https://reviews.llvm.org/D88875 Files:

[PATCH] D88845: [SystemZ][z/OS] Set default alignment rules for z/OS target

abhina.sreeskantharajan accepted this revision. abhina.sreeskantharajan added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88845/new/ https://reviews.llvm.org/D88845

[clang] 37c74df - Revert "[c++17] Implement P0145R3 during constant evaluation."

Author: Dmitri Gribenko Date: 2020-10-06T15:49:44+02:00 New Revision: 37c74dfe72ecf4e7def22702c5a944682a7865df URL: https://github.com/llvm/llvm-project/commit/37c74dfe72ecf4e7def22702c5a944682a7865df DIFF:

[PATCH] D88831: [clang-tidy] Remove obsolete checker google-runtime-references

This revision was automatically updated to reflect the committed changes. Closed by commit rGd6c9dc3c17e4: [clang-tidy] Remove obsolete checker google-runtime-references (authored by baloghadamsoftware). Changed prior to commit: https://reviews.llvm.org/D88831?vs=296170=296416#toc Repository:

[clang-tools-extra] d6c9dc3 - [clang-tidy] Remove obsolete checker google-runtime-references

Author: Adam Balogh Date: 2020-10-06T14:03:55+02:00 New Revision: d6c9dc3c17e444e007758c01507bb5280532c9f8 URL: https://github.com/llvm/llvm-project/commit/d6c9dc3c17e444e007758c01507bb5280532c9f8 DIFF: https://github.com/llvm/llvm-project/commit/d6c9dc3c17e444e007758c01507bb5280532c9f8.diff

[PATCH] D88875: [clangd] Add basic keyword-name-validation in rename.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8a3cbb1535a9: [clangd] Add basic keyword-name-validation in rename. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang-tools-extra] 8a3cbb1 - [clangd] Add basic keyword-name-validation in rename.

Author: Haojian Wu Date: 2020-10-06T15:47:57+02:00 New Revision: 8a3cbb1535a92dcc0ac3bd8fc64216a465b8506a URL: https://github.com/llvm/llvm-project/commit/8a3cbb1535a92dcc0ac3bd8fc64216a465b8506a DIFF: https://github.com/llvm/llvm-project/commit/8a3cbb1535a92dcc0ac3bd8fc64216a465b8506a.diff

[PATCH] D88737: [AIX] Turn -fdata-sections on by default in Clang

DiggerLin added inline comments. Comment at: clang/test/Driver/aix-data-sections.c:7 +// RUN: | FileCheck %s +// CHECK: "-fdata-sections" may be good to check the whether other OS platform behavior be changed or not? CHANGES SINCE LAST ACTION

[PATCH] D88885: [clangd] Disambiguate overloads of std::move for header insertion.

sammccall added inline comments. Comment at: clang-tools-extra/clangd/index/SymbolCollector.cpp:563 if (auto Header = getIncludeHeader(QName, Entry.second)) { +// Hack: there are two std::move() overloads from different headers. +// CanonicalIncludes

[PATCH] D88814: [clangd] Enable partial namespace matches for workspace symbols

kadircet updated this revision to Diff 296402. kadircet marked 6 inline comments as done. kadircet added a comment. - Perform sub-scope matching rather than substring match for partial namespaces. - Apply a penalty for partially matching namespaces. Repository: rG LLVM Github Monorepo

[PATCH] D88885: [clangd] Disambiguate overloads of std::move for header insertion.

sammccall created this revision. sammccall added a reviewer: kadircet. Herald added subscribers: cfe-commits, usaxena95, arphaman. Herald added a project: clang. sammccall requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Up until now, we relied on matching the

[PATCH] D88814: [clangd] Enable partial namespace matches for workspace symbols

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/FindSymbols.cpp:44 +// Returns true if \p Query can be found as a sub-scope inside \p Scope. +bool

[PATCH] D88886: [Clang][unittests][NFC] Break up test in Callbacks.cpp

stefanp added a comment. Related to this please see Nemanja's comment on https://reviews.llvm.org/D82485. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D6/new/ https://reviews.llvm.org/D6 ___

[clang] 8fa45e1 - Convert diagnostics about multi-character literals from extension to warning

Author: Chuyang Chen Date: 2020-10-06T08:47:17-04:00 New Revision: 8fa45e1fd527269140c4e2a1652fef5500da16fd URL: https://github.com/llvm/llvm-project/commit/8fa45e1fd527269140c4e2a1652fef5500da16fd DIFF: https://github.com/llvm/llvm-project/commit/8fa45e1fd527269140c4e2a1652fef5500da16fd.diff

[PATCH] D87962: [clang] Change the multi-character character constants from extension to implementation-defined.

aaron.ballman closed this revision. aaron.ballman added a comment. In D87962#2313363 , @nomanous wrote: > In D87962#2312617 , @aaron.ballman > wrote: > >> LGTM! Do you need someone to commit on your behalf? > >

[PATCH] D88875: [clangd] Add basic keyword-name-validation in rename.

hokein added inline comments. Comment at: clang-tools-extra/clangd/refactor/Rename.cpp:124 + + // name validation. + RenameToKeywords, sammccall wrote: > nit: not sure we need a separate section for these, I can imagine at most > keyword/conflict/shadow yeah,

[PATCH] D88833: [clang-tidy] Do not warn on pointer decays in system macros

fiesh updated this revision to Diff 296452. fiesh added a comment. Applied changes to address code review Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88833/new/ https://reviews.llvm.org/D88833 Files:

[PATCH] D78902: [Driver] Add output file to properties of Command

sepavloff updated this revision to Diff 296451. sepavloff added a comment. Use MakeArgString to get persistent string Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78902/new/ https://reviews.llvm.org/D78902 Files:

[PATCH] D88680: Add ability to turn off -fpch-instantiate-templates in clang-cl

hans added a comment. I've committed this as 66e4f07198761bbb4dcd55235024c1081ed15c75 so it has a chance to make it into the 11.0.0 release. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D88680: Add ability to turn off -fpch-instantiate-templates in clang-cl

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG66e4f0719876: Add ability to turn off -fpch-instantiate-templates in clang-cl (authored by shivanshu3, committed by hans). Repository: rG LLVM

[clang] 66e4f07 - Add ability to turn off -fpch-instantiate-templates in clang-cl

Author: Shivanshu Goyal Date: 2020-10-06T16:23:23+02:00 New Revision: 66e4f07198761bbb4dcd55235024c1081ed15c75 URL: https://github.com/llvm/llvm-project/commit/66e4f07198761bbb4dcd55235024c1081ed15c75 DIFF:

[PATCH] D88833: [clang-tidy] Do not warn on pointer decays in system macros

fiesh marked 6 inline comments as done. fiesh added a comment. @njames93 Thank you for your review, I hopefully addressed all your points. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88833/new/ https://reviews.llvm.org/D88833

[PATCH] D88886: [Clang][unittests][NFC] Break up test in Callbacks.cpp

gribozavr2 added inline comments. Comment at: clang/unittests/Tooling/RecursiveASTVisitorTests/CallbacksCommon.h:1 + +using namespace clang; Please add a license comment and all necessary includes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D88886: [Clang][unittests][NFC] Break up test in Callbacks.cpp

gribozavr2 accepted this revision. gribozavr2 added a reviewer: gribozavr2. gribozavr2 added a comment. Thank you! LGTM assuming you only moved the tests into separate cpp files (I didn't verify that the text is exactly the same). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D61989: [clang-tidy] enable modernize-concat-nested-namespaces on header files

collinjackson added a comment. Are there any updates on this change? I see there's a comment that hasn't been addressed yet. Is that the only roadblock stopping this from getting merged? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61989/new/

[PATCH] D88905: [Clang] Allow "ext_vector_type" applied to Booleans

simoll created this revision. simoll added reviewers: hfinkel, erichkeane, craig.topper, rsandifo-arm, kaz7, k-ishizaka, rengolin. Herald added subscribers: cfe-commits, pengfei, kristof.beyls. Herald added a project: clang. simoll requested review of this revision. This is the `ext_vector_type`

[clang] 8d2a0c1 - [HIP] NFC Add comments to cmath functions

Author: Aaron En Ye Shi Date: 2020-10-06T15:26:56Z New Revision: 8d2a0c115e245e86bba4ea1c70e6d34b552031a9 URL: https://github.com/llvm/llvm-project/commit/8d2a0c115e245e86bba4ea1c70e6d34b552031a9 DIFF: https://github.com/llvm/llvm-project/commit/8d2a0c115e245e86bba4ea1c70e6d34b552031a9.diff

[PATCH] D87163: [DSE] Switch to MemorySSA-backed DSE by default.

fhahn added a comment. FYI this has been temporarily reverted again roughly a week ago, because there seems to be a mis-compile, that is caused by LLVM introducing invalid lifetime.end calls and exposed by the more powerful DSE, which @asbirlea is currently trying to narrow down. Repository:

[PATCH] D78902: [Driver] Add output file to properties of Command

sepavloff marked an inline comment as done. sepavloff added inline comments. Comment at: clang/lib/Driver/ToolChains/HIP.cpp:135 + Bundler, BundlerArgs, Inputs, + InputInfo(, Output.c_str(; }

[PATCH] D88900: check before accessing possibly null node

danix800 created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. danix800 requested review of this revision. Testcase: (main.cpp) int foo(int i); int main() { int i = 1; while (i-- >= 0) { return 3 / foo(i); } } run with clang

[PATCH] D87528: Enable '#pragma STDC FENV_ACCESS' in frontend cf. D69272 - Work in Progress

sepavloff added a comment. In D87528#2312230 , @mibintc wrote: > For the LIT test clang/test/AST/const-fpfeatures.cpp, currently failing in > this patch, the variables V1 and others are initialized via call to "global > var init" which performs the

[PATCH] D81083: [Clang] Allow "vector_size" applied to Booleans

simoll added a comment. D88905 uses ext_vector_type instead of vector_size following up on @rsmith 's suggestion . The review should continue there. I'll keep D81083 around for

[PATCH] D88154: Initial support for vectorization using Libmvec (GLIBC vector math library).

spatel added a comment. In D88154#2310653 , @venkataramanan.kumar.llvm wrote: > In D88154#2290205 , @abique wrote: > >> Looks good to me. >> Regarding the tests, it seems that you check if auto-vectorization takes

[clang] aa2b593 - [HIP] Restructure hip headers to add cmath

Author: Aaron En Ye Shi Date: 2020-10-06T14:48:53Z New Revision: aa2b593f1495a972a4a592952760ec9d5f7c01f1 URL: https://github.com/llvm/llvm-project/commit/aa2b593f1495a972a4a592952760ec9d5f7c01f1 DIFF: https://github.com/llvm/llvm-project/commit/aa2b593f1495a972a4a592952760ec9d5f7c01f1.diff

[PATCH] D88885: [clangd] Disambiguate overloads of std::move for header insertion.

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. Thanks, LGTM! As you mentioned I believe `std::move` is common enough to deserve the special casing. Comment at: clang-tools-extra/clangd/index/SymbolCollector.cpp:563

[PATCH] D78902: [Driver] Add output file to properties of Command

yaxunl added inline comments. Comment at: clang/include/clang/Driver/Job.h:165 + const llvm::opt::ArgStringList , ArrayRef Inputs, + ArrayRef Outputs); // FIXME: This really shouldn't be copyable, but is currently copied in some Is this

[PATCH] D88929: [OpenMP] Change CMake Configuration to Build for Highest CUDA Architecture by Default

ye-luo added a comment. I just realized that this patch affects clang and libomptarget. I cannot comment on clang. Regarding libomptarget, Could you explain why the detection is not put together with other cuda stuff in `openmp/libomptarget/cmake/Modules/LibomptargetGetDependencies.cmake`

[PATCH] D88754: [clang] Add a test for CGDebugInfo treatment of blocks

scott.linder updated this revision to Diff 296558. scott.linder added a comment. Don't hardcode x86_64-specific offsets Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88754/new/ https://reviews.llvm.org/D88754 Files:

[PATCH] D88929: [OpenMP] Change CMake Configuration to Build for Highest CUDA Architecture by Default

jhuber6 added a comment. In D88929#2315451 , @ye-luo wrote: > I just realized that this patch affects clang and libomptarget. > I cannot comment on clang. Regarding libomptarget, Could you explain why the > detection is not put together with other cuda

[PATCH] D88929: [OpenMP] Change CMake Configuration to Build for Highest CUDA Architecture by Default

ye-luo added a comment. In D88929#2315513 , @jhuber6 wrote: > In D88929#2315451 , @ye-luo wrote: > >> I just realized that this patch affects clang and libomptarget. >> I cannot comment on clang. Regarding

[PATCH] D88929: [OpenMP] Change CMake Configuration to Build for Highest CUDA Architecture by Default

jhuber6 added a comment. In D88929#2315519 , @ye-luo wrote: > Probably not messing with `enable_language(CUDA)` at the moment, just add > `cuda_select_nvcc_arch_flags(CUDA_ARCH_FLAGS)` to >

[PATCH] D88929: [OpenMP] Change CMake Configuration to Build for Highest CUDA Architecture by Default

ye-luo added a comment. In D88929#2315538 , @jhuber6 wrote: > In D88929#2315519 , @ye-luo wrote: > >> Probably not messing with `enable_language(CUDA)` at the moment, just add >>

[PATCH] D84467: Add support for Branch Coverage in LLVM Source-Based Code Coverage

vsk added inline comments. Comment at: clang/lib/CodeGen/CoverageMappingGen.cpp:1169 +createBranchRegion(S->getCond(), BodyCount, + subtractCounters(CondCount, BodyCount)); } If `theWhileStmt->getCond()` is-a BinaryOperator, it would

[PATCH] D88936: [HWAsan][NewPM] Handle hwasan like other sanitizers

aeubanks created this revision. Herald added subscribers: cfe-commits, dexonsmith. Herald added a project: clang. aeubanks requested review of this revision. Move it as an EP callback (-O[123]) or in addSanitizersAtO0. This makes it not run in ThinLTO pre-link (like the other sanitizers), so

[PATCH] D88929: [OpenMP] Change CMake Configuration to Build for Highest CUDA Architecture by Default

JonChesterfield added a comment. An alternative approach is to build the deviceRTL for multiple cuda versions and then pick whichever one is the best fit when compiling application code. That has advantages when building the deviceRTL libraries on a different machine to the one that intends to

[clang] 00d3e6c - [c++17] Implement P0145R3 during constant evaluation.

Author: Richard Smith Date: 2020-10-06T12:30:26-07:00 New Revision: 00d3e6c1b4d0b7879afc6002b72b49ecf755 URL: https://github.com/llvm/llvm-project/commit/00d3e6c1b4d0b7879afc6002b72b49ecf755 DIFF: https://github.com/llvm/llvm-project/commit/00d3e6c1b4d0b7879afc6002b72b49ecf755.diff

Re: [clang] 37c74df - Revert "[c++17] Implement P0145R3 during constant evaluation."

Thanks, fixed and re-committed as 00d3e6c1b4d0b7879afc6002b72b49ecf755. On Tue, 6 Oct 2020 at 06:50, Dmitri Gribenko via cfe-commits < cfe-commits@lists.llvm.org> wrote: > > Author: Dmitri Gribenko > Date: 2020-10-06T15:49:44+02:00 > New Revision: 37c74dfe72ecf4e7def22702c5a944682a7865df > >

[PATCH] D87451: add new option -mignore-xcoff-visibility

daltenty added inline comments. Comment at: clang/docs/ClangCommandLineReference.rst:2622 + +Do not emit any visibility attribute for asm on AIX or give all symbols 'unspecified' visibility in xcoff object file (XCOFF only) + nit: plural. capitalization.

[PATCH] D87853: [SemaTemplate] Stop passing insertion position around during VarTemplate instantiation

bruno added a comment. Ping! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87853/new/ https://reviews.llvm.org/D87853 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D87528: Enable '#pragma STDC FENV_ACCESS' in frontend cf. D69272 - Work in Progress

mibintc updated this revision to Diff 296520. mibintc added a comment. I added a sentence in the clang UserManual pointing out that ffp-model=strict automatically enables FENV_ACCESS. I changed checkFloatingPointResult the way @sepavloff suggested to solve the LIT failure in

[PATCH] D87451: add new option -mignore-xcoff-visibility

daltenty added inline comments. Comment at: llvm/lib/CodeGen/CommandFlags.cpp:339 + "ignore-xcoff-visibility", + cl::desc("Not emit the visibility attribute for asm in AIX OS or give " + "all symbols 'unspecified' visibility in xcoff object file"),

[PATCH] D87451: add new option -mignore-xcoff-visibility

daltenty accepted this revision. daltenty added a comment. This revision is now accepted and ready to land. LGTM, other minor nit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87451/new/ https://reviews.llvm.org/D87451

[PATCH] D54222: [clang-tidy] Add a check to detect returning static locals in public headers

rsmith added a comment. In D54222#2313686 , @JonasToth wrote: > I am confused now, but richard knows this stuff very well! The patches you > referenced showed only cases where the static was defined in an inline-header > definition (and templates). Does

[PATCH] D88814: [clangd] Enable partial namespace matches for workspace symbols

kadircet added inline comments. Comment at: clang-tools-extra/clangd/FindSymbols.cpp:44 +// Returns true if \p Query can be found as a sub-scope inside \p Scope. +bool approximateScopeMatch(llvm::StringRef Scope, sammccall wrote: > I had a little trouble

[clang] 43cd0a9 - [SystemZ][z/OS] Set default alignment rules for z/OS target

Author: Fanbo Meng Date: 2020-10-06T14:21:21-04:00 New Revision: 43cd0a98d1b1cbbbab38591badbe11a995844cf7 URL: https://github.com/llvm/llvm-project/commit/43cd0a98d1b1cbbbab38591badbe11a995844cf7 DIFF: https://github.com/llvm/llvm-project/commit/43cd0a98d1b1cbbbab38591badbe11a995844cf7.diff

  1   2   >