[PATCH] D89529: [clangd][remote] Add Windows paths support

ArcsinX updated this revision to Diff 298869. ArcsinX added a comment. Convert `RemoteIndexRoot` and `LocalIndexRoot` to the POSIX style. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89529/new/ https://reviews.llvm.org/D89529 Files:

[PATCH] D89529: [clangd][remote] Add Windows paths support

ArcsinX added a comment. In D89529#2334517 , @kbobyrev wrote: > The solution would be to just convert to the POSIX path instead of asserting > it. I have updated the patch according to this advice. It seems to me it looks more consistent now, thank you.

[PATCH] D89210: [Sema, CodeGen] Implement [[likely]] and [[unlikely]] in SwitchStmt

Mordante marked 2 inline comments as done. Mordante added a comment. In D89210#2332143 , @aaron.ballman wrote: > LGTM aside from a documentation request, but you may want to wait a few days > before committing in case Richard or John have opinions.

[clang] a2f8407 - [NFC] Fixes a documentation typo.

Author: Mark de Wever Date: 2020-10-18T13:48:48+02:00 New Revision: a2f8407801dcf0c0933f68ab28426928d2ca1fea URL: https://github.com/llvm/llvm-project/commit/a2f8407801dcf0c0933f68ab28426928d2ca1fea DIFF: https://github.com/llvm/llvm-project/commit/a2f8407801dcf0c0933f68ab28426928d2ca1fea.diff

[clang] 2bcda6b - [Sema, CodeGen] Implement [[likely]] and [[unlikely]] in SwitchStmt

Author: Mark de Wever Date: 2020-10-18T13:48:42+02:00 New Revision: 2bcda6bb2896f0f8daf67343edfc64fb226f3e3f URL: https://github.com/llvm/llvm-project/commit/2bcda6bb2896f0f8daf67343edfc64fb226f3e3f DIFF: https://github.com/llvm/llvm-project/commit/2bcda6bb2896f0f8daf67343edfc64fb226f3e3f.diff

[PATCH] D89210: [Sema, CodeGen] Implement [[likely]] and [[unlikely]] in SwitchStmt

This revision was automatically updated to reflect the committed changes. Mordante marked 2 inline comments as done. Closed by commit rG2bcda6bb2896: [Sema, CodeGen] Implement [[likely]] and [[unlikely]] in SwitchStmt (authored by Mordante). Changed prior to commit:

[PATCH] D86559: [Sema, CodeGen] Allow [[likely]] and [[unlikely]] on labels

Mordante planned changes to this revision. Mordante added inline comments. Comment at: clang/lib/Sema/SemaDeclAttr.cpp:6454 +static bool validateLikelihoodAttr(Sema , Decl *D, const ParsedAttr ) { + if (!isa(D)) { aaron.ballman wrote: > Mordante wrote: > >

[PATCH] D89394: clang/Basic: Stop using SourceManager::getBuffer, NFC

nikic added a comment. FYI this showed up as a 1% compile-time regression in terms of instructions retired for `O0-g` builds: https://llvm-compile-time-tracker.com/compare.php?from=32a4ad3b6ce6028a371b028cf06fa5feff9534bf=54c1bcab90102481fe43b73f8547d47446ba2163=instructions Looking at the

[PATCH] D49864: [clang-tidy] The script clang-tidy-diff.py doesn't accept 'pass by' options (--)

janosimas updated this revision to Diff 298865. janosimas added a comment. Here a diff with the rebased code Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D49864/new/ https://reviews.llvm.org/D49864 Files:

[PATCH] D89184: Support complex target features combinations

LiuChen3 added a comment. ping? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89184/new/ https://reviews.llvm.org/D89184 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D80488: Teach `-fsanitize=fuzzer` to respect `-static` and `-static-libstdc++` when adding C++ standard libraries.

chandlerc added a reviewer: vitalybuka. chandlerc marked an inline comment as done. chandlerc added a comment. Ping (and adding some sanitizer folks)? I'd really love to stop building with this local patch Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:754 +

[PATCH] D89297: [clangd] Add a TestWorkspace utility

nridge added a reviewer: kadircet. nridge added a comment. Thanks for the suggestions! I implemented them and it seems to be working well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89297/new/ https://reviews.llvm.org/D89297

[PATCH] D89301: [X86] Add user-level interrupt instructions

pengfei added a comment. You need to add test for macro UINTR in clang/test/Preprocessor/predefined-arch-macros.c for SapphireRapids. Comment at: llvm/docs/ReleaseNotes.rst:117 the target CPU. -* Support for ISA HRESET has been added. +* Support for HRESET and UINTR

[PATCH] D89297: [clangd] Add a TestWorkspace utility

nridge updated this revision to Diff 298926. nridge added a comment. Rework utility as suggested Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89297/new/ https://reviews.llvm.org/D89297 Files:

[PATCH] D89670: [clangd] Store the containing symbol for refs

nridge created this revision. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman. Herald added a project: clang. nridge requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. This is needed to implement call hierarchy. Repository: rG LLVM Github

[PATCH] D88227: [clang-format] Add a SpaceAroundPointerQualifiers style option

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9e27f38354e8: [clang-format] Add a SpaceAroundPointerQualifiers style option (authored by arichardson). Changed prior to commit:

[clang] 9e27f38 - [clang-format] Add a SpaceAroundPointerQualifiers style option

Author: Alex Richardson Date: 2020-10-18T18:17:50+01:00 New Revision: 9e27f38354e850346f5f4e895e44ad3346546d9c URL: https://github.com/llvm/llvm-project/commit/9e27f38354e850346f5f4e895e44ad3346546d9c DIFF:

[PATCH] D89649: Fix __has_unique_object_representations with no_unique_address

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. This looks fine as far as it goes, but it doesn't fix all cases of incorrect behavior of `__has_unique_object_representations` due to `[[no_unique_address]]`. Feel free to either to land this

[PATCH] D89651: [clang-tidy] Add bugprone-suspicious-memory-comparison check

gbencze created this revision. gbencze added reviewers: aaron.ballman, JonasToth, Charusso. gbencze added a project: clang-tools-extra. Herald added subscribers: cfe-commits, xazax.hun, mgorny. Herald added a project: clang. gbencze requested review of this revision. The check warns on suspicious

[PATCH] D89664: [X86] Add missing code in D89102 [X86] Add HRESET instruction.

craig.topper added inline comments. Comment at: llvm/lib/Target/X86/X86.td:770 FeaturePTWRITE, + FeatureHRESET, FeatureTSXLDTRK,

[clang] 389c8d5 - [NFC] Make non-modifying members const.

Author: Mark de Wever Date: 2020-10-18T18:50:21+02:00 New Revision: 389c8d5b20a2ddea84d3b24edd533d5283f96582 URL: https://github.com/llvm/llvm-project/commit/389c8d5b20a2ddea84d3b24edd533d5283f96582 DIFF: https://github.com/llvm/llvm-project/commit/389c8d5b20a2ddea84d3b24edd533d5283f96582.diff

[clang] 79cb179 - PR47870: Properly mangle placeholders for deduced class template

Author: Richard Smith Date: 2020-10-18T13:57:41-07:00 New Revision: 79cb179b149b20e7e1bbfd45d1b5e5b055f3b067 URL: https://github.com/llvm/llvm-project/commit/79cb179b149b20e7e1bbfd45d1b5e5b055f3b067 DIFF: https://github.com/llvm/llvm-project/commit/79cb179b149b20e7e1bbfd45d1b5e5b055f3b067.diff

[PATCH] D89301: [X86] Add user-level interrupt instructions

craig.topper added inline comments. Comment at: llvm/lib/Target/X86/X86InstrInfo.td:320 +def X86testui : SDNode<"X86ISD::TESTUI", + SDTypeProfile<1, 0, [SDTCisVT<0, i32>]>, [SDNPHasChain]>; I think this should have SDNPSideEffect to

[PATCH] D89443: [PowerPC][AIX] Make `__vector [un]signed long` an error

This revision was automatically updated to reflect the committed changes. hubert.reinterpretcast marked an inline comment as done. Closed by commit rG126094485ab9: [PowerPC][AIX] Make `__vector [un]signed long` an error (authored by hubert.reinterpretcast). Changed prior to commit:

[clang] 1260944 - [PowerPC][AIX] Make `__vector [un]signed long` an error

Author: Hubert Tong Date: 2020-10-18T12:39:16-04:00 New Revision: 126094485ab99dac3e6df9c201124d48a1d798ce URL: https://github.com/llvm/llvm-project/commit/126094485ab99dac3e6df9c201124d48a1d798ce DIFF: https://github.com/llvm/llvm-project/commit/126094485ab99dac3e6df9c201124d48a1d798ce.diff

[PATCH] D89664: [X86] Add missing code in D89102 [X86] Add HRESET instruction.

pengfei created this revision. pengfei added reviewers: LuoYuanke, FreddyYe, RKSimon, craig.topper. Herald added subscribers: llvm-commits, cfe-commits, hiraditya. Herald added projects: clang, LLVM. pengfei requested review of this revision. Repository: rG LLVM Github Monorepo

[PATCH] D89649: Fix __has_unique_object_representations with no_unique_address

gbencze created this revision. gbencze added reviewers: rsmith, aaron.ballman. Herald added a project: clang. Herald added a subscriber: cfe-commits. gbencze requested review of this revision. Fix incorrect behavior of __has_unique_object_representations when using the no_unique_address

[clang] 094e9f4 - PR47893: Synthesis of a comparison operator from an 'operator<=>'

Author: Richard Smith Date: 2020-10-18T14:15:12-07:00 New Revision: 094e9f4779eb9b5c6a49014f2f80b8cbb833572f URL: https://github.com/llvm/llvm-project/commit/094e9f4779eb9b5c6a49014f2f80b8cbb833572f DIFF: https://github.com/llvm/llvm-project/commit/094e9f4779eb9b5c6a49014f2f80b8cbb833572f.diff

[clang-tools-extra] 5f88c3b - [clang tidy] Fix SIMDIntrinsicsCheck not storing options

Author: Nathan James Date: 2020-10-18T15:56:39+01:00 New Revision: 5f88c3b6392f54ee0d31f560b1897b8fbc828ee7 URL: https://github.com/llvm/llvm-project/commit/5f88c3b6392f54ee0d31f560b1897b8fbc828ee7 DIFF: https://github.com/llvm/llvm-project/commit/5f88c3b6392f54ee0d31f560b1897b8fbc828ee7.diff

[clang-tools-extra] ce619f6 - [NFC][clang-tidy] Use isInStdNamespace matcher instead of check defined alternatives

Author: Nathan James Date: 2020-10-18T16:02:11+01:00 New Revision: ce619f645f58154fcc1d88e9de81aa7903dd7bc0 URL: https://github.com/llvm/llvm-project/commit/ce619f645f58154fcc1d88e9de81aa7903dd7bc0 DIFF: https://github.com/llvm/llvm-project/commit/ce619f645f58154fcc1d88e9de81aa7903dd7bc0.diff