[PATCH] D90622: clang: Don't assert on no_unique_address fields in @encode()

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90622/new/ https://reviews.llvm.org/D90622 ___ cfe-commits mailing list

[clang] e7c7a19 - [Frontend] Treat .cuh files as CUDA source files

Author: Anatoliy Tomilov Date: 2020-11-12T11:42:53-08:00 New Revision: e7c7a1982632270ae655c7ec8e490ca2c44193a0 URL: https://github.com/llvm/llvm-project/commit/e7c7a1982632270ae655c7ec8e490ca2c44193a0 DIFF:

[PATCH] D91034: [Frontend] Treat CUDA header files as CUDA source files

This revision was automatically updated to reflect the committed changes. Closed by commit rGe7c7a1982632: [Frontend] Treat .cuh files as CUDA source files (authored by tomilov, committed by MaskRay). Herald added a subscriber: cfe-commits. Changed prior to commit:

[PATCH] D91373: [OpenMP5.0] Support more kinds of lvalues in map clauses

jacobdweightman created this revision. jacobdweightman added a reviewer: ABataev. jacobdweightman added a project: OpenMP. Herald added subscribers: cfe-commits, guansong, yaxunl. Herald added a project: clang. jacobdweightman requested review of this revision. Herald added a reviewer: jdoerfert.

[PATCH] D91370: [OPENMP]Fix PR48076: Check map types array before accessing its front.

jhuber6 added a comment. This stops it from crashing Clang, but I'm not sure if it's fixing the underlying problem. When I compile and run this program it crashes in libomptarget. If you get rid of the `float f[50]` in the struct it works as expected. `$ clang++ -fopenmp

[PATCH] D91370: [OPENMP]Fix PR48076: Check map types array before accessing its front.

ABataev added a comment. In D91370#2392107 , @jhuber6 wrote: > This stops it from crashing Clang, but I'm not sure if it's fixing the > underlying problem. When I compile and run this program it crashes in > libomptarget. If you get rid of the `float

[PATCH] D91200: [PowerPC] Prevent the use of MMA with P9 and earlier

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG170e45ae186b: [PowerPC] Prevent the use of MMA with P9 and earlier (authored by bsaleil). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang] 170e45a - [PowerPC] Prevent the use of MMA with P9 and earlier

Author: Baptiste Saleil Date: 2020-11-12T10:36:50-06:00 New Revision: 170e45ae186b3eed16898db933c94a85ac623933 URL: https://github.com/llvm/llvm-project/commit/170e45ae186b3eed16898db933c94a85ac623933 DIFF:

[PATCH] D91366: Serialization: Hoist the check for in-flight diagnostics in ASTReader::getInputFile, NFC

dexonsmith created this revision. dexonsmith added a reviewer: jansvoboda11. Herald added a subscriber: ributzka. dexonsmith requested review of this revision. This logic seems easier to follow without the `Error()` helper, and checking `DiagnosticsEngine::isDiagnosticInFlight` just once up

[clang] b336826 - Non-implicit attribute creation requires a source range; NFC

Author: Aaron Ballman Date: 2020-11-12T10:06:30-08:00 New Revision: b336826c1dd92adabef682f9b013b2e36bce066c URL: https://github.com/llvm/llvm-project/commit/b336826c1dd92adabef682f9b013b2e36bce066c DIFF: https://github.com/llvm/llvm-project/commit/b336826c1dd92adabef682f9b013b2e36bce066c.diff

[PATCH] D91037: [clang-tidy] Fix crash in bugprone-redundant-branch-condition on ExprWithCleanups

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Comment at: clang-tools-extra/test/clang-tidy/checkers/bugprone-redundant-branch-condition.cpp:1092 + // CHECK-MESSAGES: :[[@LINE-1]]:5: warning:

[PATCH] D91370: [OPENMP]Fix PR48076: Check map types array before accessing its front.

jhuber6 accepted this revision. jhuber6 added a comment. This revision is now accepted and ready to land. LGTM then. Any clue what the cause of the other problem is? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91370/new/

[PATCH] D91037: [clang-tidy] Fix crash in bugprone-redundant-branch-condition on ExprWithCleanups

aaron.ballman added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/bugprone-redundant-branch-condition.cpp:1092 + // CHECK-MESSAGES: :[[@LINE-1]]:5: warning: redundant condition 'isSet' [bugprone-redundant-branch-condition] + // CHECK-FIXES:

[PATCH] D91184: [clang-tidy] Merge options inplace instead of copying

This revision was automatically updated to reflect the committed changes. Closed by commit rG06db8f984f1a: [clang-tidy] Merge options inplace instead of copying (authored by njames93). Changed prior to commit: https://reviews.llvm.org/D91184?vs=304237=304892#toc Repository: rG LLVM Github

[PATCH] D71880: [clangd] Implement Decl canonicalization rules for rename

kbobyrev updated this revision to Diff 304893. kbobyrev added a comment. Remove unused header (was added for llvm_unreachable). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71880/new/ https://reviews.llvm.org/D71880 Files:

[clang-tools-extra] 06db8f9 - [clang-tidy] Merge options inplace instead of copying

Author: Nathan James Date: 2020-11-12T18:19:12Z New Revision: 06db8f984f1a31e299af7d9ea584061d244caad6 URL: https://github.com/llvm/llvm-project/commit/06db8f984f1a31e299af7d9ea584061d244caad6 DIFF: https://github.com/llvm/llvm-project/commit/06db8f984f1a31e299af7d9ea584061d244caad6.diff LOG:

[PATCH] D91368: Frontend: Split out addVFSOverlays from createVFSFromCompilerInvocation, NFC

dexonsmith created this revision. dexonsmith added reviewers: JDevlieghere, jansvoboda11, akyrtzi. Herald added a subscriber: ributzka. dexonsmith requested review of this revision. This is a prep patch to reduce noise in a follow-up, which will add another layer.

[PATCH] D91370: [OPENMP]Fix PR48076: Check map types array before accessing its front.

ABataev added a comment. In D91370#2392171 , @jhuber6 wrote: > LGTM then. > > Any clue what the cause of the other problem is? Will investigate it and prepare a new patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D91376: [OPENMP]Fix PR47790: segfault in frontend while parsing Objective-C with OpenMP.

ABataev created this revision. ABataev added a reviewer: jdoerfert. Herald added subscribers: guansong, yaxunl. Herald added a project: clang. ABataev requested review of this revision. Herald added a subscriber: sstefan1. Need to check if the sema is actually finishing a function decl.

[PATCH] D90870: [NFC][NewPM] Reuse PassBuilder callbacks with -O0

ychen accepted this revision. ychen added a comment. This revision is now accepted and ready to land. This is NFC and looks like a nice cleaup. So LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90870/new/ https://reviews.llvm.org/D90870

[PATCH] D91372: Some updates/fixes to the creduce script.

akhuang created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. akhuang requested review of this revision. This was motivated by changes to llvm's `not --crash` disabling symbolization but I ended up removing `not` from the script entirely because it returns

[PATCH] D91037: [clang-tidy] Fix crash in bugprone-redundant-branch-condition on ExprWithCleanups

zinovy.nis added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/bugprone-redundant-branch-condition.cpp:1092 + // CHECK-MESSAGES: :[[@LINE-1]]:5: warning: redundant condition 'isSet' [bugprone-redundant-branch-condition] + // CHECK-FIXES:

[clang] ac523d2 - [FPEnv][Clang][Driver] Use MarshallingInfoFlag for -fexperimental-strict-floating-point

Author: Kevin P. Neal Date: 2020-11-12T12:51:35-05:00 New Revision: ac523d2de51c4119ae6233200af07599d61de1fc URL: https://github.com/llvm/llvm-project/commit/ac523d2de51c4119ae6233200af07599d61de1fc DIFF: https://github.com/llvm/llvm-project/commit/ac523d2de51c4119ae6233200af07599d61de1fc.diff

[PATCH] D88987: [FPEnv][Clang][Driver] Use MarshallingInfoFlag for -fexperimental-strict-floating-point

This revision was automatically updated to reflect the committed changes. Closed by commit rGac523d2de51c: [FPEnv][Clang][Driver] Use MarshallingInfoFlag for -fexperimental-strict… (authored by kpn). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D91037: [clang-tidy] Fix crash in bugprone-redundant-branch-condition on ExprWithCleanups

zinovy.nis marked an inline comment as done. zinovy.nis added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/bugprone-redundant-branch-condition.cpp:1092 + // CHECK-MESSAGES: :[[@LINE-1]]:5: warning: redundant condition 'isSet'

[PATCH] D91367: Serialization: Merge three diagnostics to simplify ASTReader::getInputFile, NFC

dexonsmith created this revision. dexonsmith added a reviewer: jansvoboda11. Herald added a subscriber: ributzka. dexonsmith requested review of this revision. Clean up the logic for `err_fe_{pch,module,ast}_file_modified` to use a `select` like other ASTReader diagnostics. There should be no

[PATCH] D91370: [OPENMP]Fix PR48076: Check map types array before accessing its front.

ABataev created this revision. ABataev added a reviewer: jdoerfert. Herald added subscribers: guansong, yaxunl. Herald added a project: clang. ABataev requested review of this revision. Herald added a subscriber: sstefan1. Need to check if there are map types for the components before trying to

[PATCH] D89869: [OpenCL] Define OpenCL feature macros for all versions

Anastasia added a comment. In D89869#2388499 , @azabaznov wrote: > Addressed all concerns except replacing //__opencl_c_int64 //definition into > header. The reason for this as follows: this macro should be predefined > regardless if clang includes

[PATCH] D90892: [AIX][FE] Support constructor/destructor attribute

Xiangling_L updated this revision to Diff 304896. Xiangling_L added a comment. Fix minor issues in the testcase; CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90892/new/ https://reviews.llvm.org/D90892 Files: clang/lib/CodeGen/CGDeclCXX.cpp clang/lib/CodeGen/CodeGenFunction.h

[PATCH] D89980: [hip] Remove the coercion on aggregate kernel arguments.

arsenm added inline comments. Comment at: clang/test/CodeGenCUDA/amdgpu-kernel-arg-pointer-type.cu:55 struct S { int *x; Should also have a case with a single element struct, which will be treated like a scalar Repository: rG LLVM Github Monorepo

[PATCH] D87188: [InstCombine] Canonicalize SPF to abs intrinc

nikic added a comment. In D87188#2385619 , @spatel wrote: > D90554 / f7eac51b9b > > I think that change makes this patch ready to try again. If we do

[PATCH] D91370: [OPENMP]Fix PR48076: Check map types array before accessing its front.

ABataev added a comment. In D91370#2392171 , @jhuber6 wrote: > LGTM then. > > Any clue what the cause of the other problem is? Could you try your test with the patch from https://reviews.llvm.org/D86119? Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D91380: [clang] Fix an assertion crash in delayed access check.

hokein created this revision. hokein added a reviewer: adamcz. Herald added a project: clang. hokein requested review of this revision. TD-getTemplatedDecl() might not be a DeclContext variant, which can trigger an assertion inside `isa<>`. Repository: rG LLVM Github Monorepo

[PATCH] D91370: [OPENMP]Fix PR48076: Check map types array before accessing its front.

jhuber6 added a comment. In D91370#2392313 , @ABataev wrote: > In D91370#2392310 , @jhuber6 wrote: > >> In D91370#2392267 , @ABataev wrote: >> >>> In D91370#2392171

[PATCH] D91370: [OPENMP]Fix PR48076: Check map types array before accessing its front.

jhuber6 added a comment. In D91370#2392616 , @ABataev wrote: > Could you try this patch: > > diff --git a/clang/lib/CodeGen/CGOpenMPRuntime.cpp > b/clang/lib/CodeGen/CGOpenMPRuntime.cpp > index ce8846140d4..854b7f3e830 100644 > ---

[clang] 3c6b457 - [OPENMP]Fix PR48076: Check map types array before accessing its front.

Author: Alexey Bataev Date: 2020-11-12T12:00:29-08:00 New Revision: 3c6b457bee0c66294637d50bca1cff7231647249 URL: https://github.com/llvm/llvm-project/commit/3c6b457bee0c66294637d50bca1cff7231647249 DIFF: https://github.com/llvm/llvm-project/commit/3c6b457bee0c66294637d50bca1cff7231647249.diff

[PATCH] D91370: [OPENMP]Fix PR48076: Check map types array before accessing its front.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3c6b457bee0c: [OPENMP]Fix PR48076: Check map types array before accessing its front. (authored by ABataev). Repository: rG LLVM Github Monorepo

[PATCH] D91370: [OPENMP]Fix PR48076: Check map types array before accessing its front.

jhuber6 added a comment. In D91370#2392319 , @ABataev wrote: > From libomptarget. It must be different. Could you copy it here? Yeah, I think there's some extra information looking at it again. Target CUDA RTL --> Start initializing CUDA

[PATCH] D91387: [Driver] Support UBSan multilib

phosek created this revision. phosek added reviewers: mcgrathr, leonardchan. Herald added subscribers: cfe-commits, mgorny. Herald added a project: clang. phosek requested review of this revision. This is analogous to the existing ASan multilib. Repository: rG LLVM Github Monorepo

[PATCH] D91376: [OPENMP]Fix PR47790: segfault in frontend while parsing Objective-C with OpenMP.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG07b568a9c8db: [OPENMP]Fix PR47790: segfault in frontend while parsing Objective-C with OpenMP. (authored by ABataev). Repository: rG LLVM Github

[clang] 07b568a - [OPENMP]Fix PR47790: segfault in frontend while parsing Objective-C with OpenMP.

Author: Alexey Bataev Date: 2020-11-12T13:26:11-08:00 New Revision: 07b568a9c8db8e5d4d4af4c766ecfb38145fb0bf URL: https://github.com/llvm/llvm-project/commit/07b568a9c8db8e5d4d4af4c766ecfb38145fb0bf DIFF: https://github.com/llvm/llvm-project/commit/07b568a9c8db8e5d4d4af4c766ecfb38145fb0bf.diff

[PATCH] D91372: Some updates/fixes to the creduce script.

akhuang updated this revision to Diff 304964. akhuang marked an inline comment as done. akhuang added a comment. address comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91372/new/ https://reviews.llvm.org/D91372 Files:

[PATCH] D91387: [Driver] Support UBSan multilib

leonardchan accepted this revision. leonardchan added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91387/new/ https://reviews.llvm.org/D91387

[PATCH] D91372: Some updates/fixes to the creduce script.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0c80b542d38b: Some updates/fixes to the creduce script. (authored by akhuang). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D91389: [MemProf][NewPM] Make memprof passes required

aeubanks created this revision. aeubanks added reviewers: leonardchan, ychen, asbirlea. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. aeubanks requested review of this revision. Just like other sanitizers. Fixes check-memprof under NPM. Repository:

[clang] 0c80b54 - Some updates/fixes to the creduce script.

Author: Amy Huang Date: 2020-11-12T13:40:26-08:00 New Revision: 0c80b542d38b4819809c600e71a6997a9b4e4294 URL: https://github.com/llvm/llvm-project/commit/0c80b542d38b4819809c600e71a6997a9b4e4294 DIFF: https://github.com/llvm/llvm-project/commit/0c80b542d38b4819809c600e71a6997a9b4e4294.diff

[PATCH] D91372: Some updates/fixes to the creduce script.

george.burgess.iv accepted this revision. george.burgess.iv added a comment. This revision is now accepted and ready to land. thanks! Comment at: clang/utils/creduce-clang-crash.py:156 + def skip_function(func_name): +for name in filters: + if name in

[PATCH] D91311: Add new 'preferred_name' attribute.

rsmith updated this revision to Diff 304985. rsmith added a comment. - Remove debugging code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91311/new/ https://reviews.llvm.org/D91311 Files: clang/include/clang/Basic/Attr.td

[PATCH] D91370: [OPENMP]Fix PR48076: Check map types array before accessing its front.

ABataev added a comment. In D91370#2392310 , @jhuber6 wrote: > In D91370#2392267 , @ABataev wrote: > >> In D91370#2392171 , @jhuber6 wrote: >> >>> LGTM then. >>> >>> Any

[PATCH] D91333: [clang][SveEmitter] Fix enum declarations. [NFCI]

fpetrogalli updated this revision to Diff 304941. fpetrogalli added a comment. Improve comment in test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91333/new/ https://reviews.llvm.org/D91333 Files: clang/test/Sema/aarch64-sve-enums.c

[PATCH] D91370: [OPENMP]Fix PR48076: Check map types array before accessing its front.

jhuber6 added a comment. In D91370#2392616 , @ABataev wrote: > Could you try this patch: > > diff --git a/clang/lib/CodeGen/CGOpenMPRuntime.cpp > b/clang/lib/CodeGen/CGOpenMPRuntime.cpp > index ce8846140d4..854b7f3e830 100644 > ---

[PATCH] D91311: Add new 'preferred_name' attribute.

rsmith updated this revision to Diff 304984. rsmith marked 5 inline comments as done. rsmith added a comment. - Address review comments. - Extend libc++ changes to cover . - Bugfixes from further testing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D91370: [OPENMP]Fix PR48076: Check map types array before accessing its front.

ABataev added a comment. In D91370#2392317 , @jhuber6 wrote: > In D91370#2392313 , @ABataev wrote: > >> In D91370#2392310 , @jhuber6 wrote: >> >>> In D91370#2392267

[PATCH] D91337: [clangd] Add missing tests to rename feature

hokein added inline comments. Comment at: clang-tools-extra/clangd/unittests/RenameTests.cpp:203 }; +struct D : B { + void [[f^oo]]() override {} hmm, I'm not sure this is needed, I think it is identical with `C`.

[PATCH] D91361: [AIX][driver] Include crti[_64].o and -bcdtors also for C language link invocations by default

Xiangling_L added inline comments. Comment at: clang/lib/Driver/ToolChains/AIX.cpp:137 -if (D.CCCIsCXX()) +if (D.CCCIsCXX() || D.CCCIsCC()) CmdArgs.push_back(Args.MakeArgString( daltenty wrote: > I think that rather that adding CC, we should

[PATCH] D91258: [clangd] Sanity-check array sizes read from disk before allocating them.

eugenis added a comment. Hi Sam, this patch is failing on the ubsan bot with: [ RUN ] SerializationTest.NoCrashOnBadArraySize /b/sanitizer-x86_64-linux-fast/build/llvm-project/clang-tools-extra/clangd/index/Serialization.cpp:90:26: runtime error: left shift of 127 by 28 places cannot be

[PATCH] D91376: [OPENMP]Fix PR47790: segfault in frontend while parsing Objective-C with OpenMP.

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91376/new/ https://reviews.llvm.org/D91376

[PATCH] D91370: [OPENMP]Fix PR48076: Check map types array before accessing its front.

jhuber6 added a comment. In D91370#2392267 , @ABataev wrote: > In D91370#2392171 , @jhuber6 wrote: > >> LGTM then. >> >> Any clue what the cause of the other problem is? > > Could you try your test with the patch

[PATCH] D90984: Update matchers to be traverse-aware

aaron.ballman added inline comments. Comment at: clang/include/clang/ASTMatchers/ASTMatchers.h:3115 + + if (!Finder->isTraversalAsIs() && (*MatchIt)->isImplicit()) +return false; If the traversal is not `AsIs`, that doesn't mean it's

[clang] 9c504ec - [VE] Disable -fsigaddr option for VE

Author: Kazushi (Jam) Marukawa Date: 2020-11-13T06:22:12+09:00 New Revision: 9c504ec06da636832d03e98581eade3d8f81eb24 URL: https://github.com/llvm/llvm-project/commit/9c504ec06da636832d03e98581eade3d8f81eb24 DIFF:

[PATCH] D91350: [VE] Disable -fsigaddr option for VE

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9c504ec06da6: [VE] Disable -fsigaddr option for VE (authored by kaz7). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D91370: [OPENMP]Fix PR48076: Check map types array before accessing its front.

ABataev added a comment. In D91370#2392641 , @jhuber6 wrote: > In D91370#2392616 , @ABataev wrote: > >> Could you try this patch: >> >> diff --git a/clang/lib/CodeGen/CGOpenMPRuntime.cpp >>

[PATCH] D91029: [clangd] Implement clang-tidy options from config

njames93 updated this revision to Diff 304940. njames93 added a comment. - Small tweaks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91029/new/ https://reviews.llvm.org/D91029 Files: clang-tools-extra/clangd/CMakeLists.txt

[PATCH] D90870: [NFC][NewPM] Reuse PassBuilder callbacks with -O0

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3a7b57b7cad3: [NFC][NewPM] Reuse PassBuilder callbacks with -O0 (authored by aeubanks). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang] 3a7b57b - [NFC][NewPM] Reuse PassBuilder callbacks with -O0

Author: Arthur Eubanks Date: 2020-11-12T12:42:59-08:00 New Revision: 3a7b57b7cad32a4b59700e029d80a06c35f0a1a3 URL: https://github.com/llvm/llvm-project/commit/3a7b57b7cad32a4b59700e029d80a06c35f0a1a3 DIFF:

[PATCH] D91361: [AIX][driver] Include crti[_64].o and -bcdtors also for C language link invocations by default

daltenty added inline comments. Comment at: clang/lib/Driver/ToolChains/AIX.cpp:137 -if (D.CCCIsCXX()) +if (D.CCCIsCXX() || D.CCCIsCC()) CmdArgs.push_back(Args.MakeArgString( I think that rather that adding CC, we should just pull the if and

[PATCH] D91385: [DFSan][NewPM] Handle dfsan under NPM

aeubanks created this revision. aeubanks added reviewers: ychen, leonardchan, asbirlea. Herald added a project: clang. Herald added a subscriber: cfe-commits. aeubanks requested review of this revision. 14/16 check-dfsan tests failed with NPM enabled, now all pass. Repository: rG LLVM Github

[PATCH] D91385: [DFSan][NewPM] Handle dfsan under NPM

aeubanks updated this revision to Diff 304967. aeubanks added a comment. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. make it required, update tests to also use opt-bisect Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D89980: [hip] Remove the coercion on aggregate kernel arguments.

hliao marked an inline comment as done. hliao added inline comments. Comment at: clang/test/CodeGenCUDA/amdgpu-kernel-arg-pointer-type.cu:55 struct S { int *x; arsenm wrote: > Should also have a case with a single element struct, which will be treated >

[PATCH] D89980: [hip] Remove the coercion on aggregate kernel arguments.

hliao updated this revision to Diff 304969. hliao added a comment. Add a test case for the single element struct. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89980/new/ https://reviews.llvm.org/D89980 Files: clang/lib/CodeGen/TargetInfo.cpp

[PATCH] D90194: [Driver] split LangOptions::SSPOff into SSPOFF and SSPUnspecified

void added inline comments. Comment at: clang/include/clang/Basic/LangOptions.h:60 enum GCMode { NonGC, GCOnly, HybridGC }; - enum StackProtectorMode { SSPOff, SSPOn, SSPStrong, SSPReq }; + enum StackProtectorMode { SSPOff, SSPOn, SSPStrong, SSPReq, SSPUnspecified };

[PATCH] D91129: Print source location in the error message when parens are missing around sizeof typename and the expression is inside macro expansion

shivanshu3 updated this revision to Diff 304973. shivanshu3 edited the summary of this revision. shivanshu3 added a comment. Use getFileLoc instead of getExpansionLoc to get the location of error. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D91370: [OPENMP]Fix PR48076: Check map types array before accessing its front.

ABataev added a comment. In D91370#2392342 , @jhuber6 wrote: > In D91370#2392319 , @ABataev wrote: > >> From libomptarget. It must be different. Could you copy it here? > > Yeah, I think there's some extra

[PATCH] D91311: Add new 'preferred_name' attribute.

rsmith added inline comments. Comment at: clang/include/clang/Basic/Attr.td:2367 +def PreferredName : InheritableAttr { + let Spellings = [Clang<"preferred_name">]; + let Subjects = SubjectList<[ClassTmpl]>; aaron.ballman wrote: > This seems like one we should

[PATCH] D90282: [clang-tidy] Add IgnoreShortNames config to identifier naming checks

smhc added a comment. In D90282#2391360 , @aaron.ballman wrote: > In D90282#2391005 , @njames93 wrote: > >> Should this be a NamingStyle option instead. >> `{key:

[PATCH] D78903: [Driver] Add option -fproc-stat-report

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG92d7a84e128a: [Driver] Add option -fproc-stat-report (authored by sepavloff). Herald added a subscriber: dang. Changed prior to commit:

[clang] 92d7a84 - [Driver] Add option -fproc-stat-report

Author: Serge Pavlov Date: 2020-11-13T14:15:42+07:00 New Revision: 92d7a84e128a20cd23e3129dee82c48f1750966a URL: https://github.com/llvm/llvm-project/commit/92d7a84e128a20cd23e3129dee82c48f1750966a DIFF: https://github.com/llvm/llvm-project/commit/92d7a84e128a20cd23e3129dee82c48f1750966a.diff

[PATCH] D90507: Adding DWARF64 clang flag

ayermolo added a subscriber: jansvoboda11. ayermolo added a comment. @jansvoboda11 Can you take a look? The failing test is unrelated it seems. Fails locally even without my change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90507/new/

[PATCH] D91361: [AIX][driver] Include crti[_64].o and -bcdtors also for C language link invocations by default

daltenty added inline comments. Comment at: clang/lib/Driver/ToolChains/AIX.cpp:137 -if (D.CCCIsCXX()) +if (D.CCCIsCXX() || D.CCCIsCC()) CmdArgs.push_back(Args.MakeArgString( Xiangling_L wrote: > daltenty wrote: > > I think that rather that

[PATCH] D91351: [tooling] Implement determinsitic ordering of CompilationDatabasePlugins

nridge added a comment. Thanks for working on this! Comment at: clang/lib/Tooling/CompilationDatabase.cpp:73 CompilationDatabasePluginRegistry::entries()) { +Plugins.emplace_back(Database.getName(), Database.instantiate()); + } A side effect of

[PATCH] D89980: [hip] Remove the coercion on aggregate kernel arguments.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. hliao marked an inline comment as done. Closed by commit rG8920ef06a138: [hip] Remove the coercion on aggregate kernel arguments. (authored by hliao). Repository:

[clang] 8920ef0 - [hip] Remove the coercion on aggregate kernel arguments.

Author: Michael Liao Date: 2020-11-12T21:19:30-05:00 New Revision: 8920ef06a138c46b208fb6471d500261c4b9bacc URL: https://github.com/llvm/llvm-project/commit/8920ef06a138c46b208fb6471d500261c4b9bacc DIFF: https://github.com/llvm/llvm-project/commit/8920ef06a138c46b208fb6471d500261c4b9bacc.diff

[PATCH] D91351: [tooling] Implement determinsitic ordering of CompilationDatabasePlugins

njames93 added inline comments. Comment at: clang/lib/Tooling/CompilationDatabase.cpp:73 CompilationDatabasePluginRegistry::entries()) { +Plugins.emplace_back(Database.getName(), Database.instantiate()); + } nridge wrote: > A side effect of this

[PATCH] D91047: Add a call super attribute plugin example

psionic12 updated this revision to Diff 305011. psionic12 marked an inline comment as done. psionic12 added a comment. fix grammer errors in warning messages and documents Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91047/new/

[PATCH] D91035: [NFC, Refactor] Convert FunctionDefinitionKind from DeclSpech.h to a scoped enum

faisalv updated this revision to Diff 305020. faisalv added a comment. This revision includes the following changes to the initial patch: - revert the bit-field to unsigned from enum (so as to avoid that nettlesome gcc warning) - specified a fixed underlying type of 'unsigned char' for the enum

[PATCH] D91035: [NFC, Refactor] Convert FunctionDefinitionKind from DeclSpech.h to a scoped enum

rsmith added inline comments. Comment at: clang/include/clang/Sema/DeclSpec.h:1762 }; +using FDK = FunctionDefinitionKind; I don't think it's OK to have an initialism like this in the `clang` namespace scope -- generally-speaking, the larger the scope of a

[clang] 7602ef7 - Suppress trailing template arguments equivalent to default arguments

Author: Richard Smith Date: 2020-11-12T21:10:34-08:00 New Revision: 7602ef768b1af99b6184faf6edfc4e06b718c7c5 URL: https://github.com/llvm/llvm-project/commit/7602ef768b1af99b6184faf6edfc4e06b718c7c5 DIFF: https://github.com/llvm/llvm-project/commit/7602ef768b1af99b6184faf6edfc4e06b718c7c5.diff

[PATCH] D91047: Add a call super attribute plugin example

psionic12 marked 5 inline comments as done. psionic12 added inline comments. Comment at: clang/docs/ClangPlugins.rst:117 +Defining CallSuperAttr +=== + aaron.ballman wrote: > aaron.ballman wrote: > > The number of underlines here looks off -- can

[PATCH] D91351: [tooling] Implement determinsitic ordering of CompilationDatabasePlugins

nridge accepted this revision. nridge added a comment. This revision is now accepted and ready to land. Not sure if I'm authorized to approve changes to libTooling, but this LGTM! Comment at: clang/lib/Tooling/CompilationDatabase.cpp:73

[PATCH] D91047: Add a call super attribute plugin example

psionic12 added a comment. I just enabled `LLVM_ENABLE_DOXYGEN` `LLVM_BUILD_DOCS`, and use `make doxygen-clang`, it seems no error with my newest patch, is this > This still appears to be incorrect and will cause build errors for the > documentation. use the same way? Repository: rG LLVM

[PATCH] D89909: [SYCL] Implement SYCL address space attributes handling

sdmitriev added inline comments. Comment at: clang/lib/CodeGen/CGExpr.cpp:4554 + + // Language rules define if it is legal to cast from one address space + // to another, and which address space we should use as a "common bader wrote: > Anastasia

[PATCH] D91330: [clangd] Ensure we test for compatibility of serialized index format

kadircet added a comment. As a side note, I've tested with a clangd-indexer before https://github.com/llvm/llvm-project/commit/71064b02701dd65065dd412fb01afe81ff83f746 and we got the failure (malformed/truncated refs). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D87981: [X86] AMX programming model prototype.

LuoYuanke added inline comments. Comment at: llvm/test/CodeGen/X86/statepoint-fixup-invoke.mir:94 ; CHECK: ADJCALLSTACKDOWN64 0, 0, 0, implicit-def dead $rsp, implicit-def dead $eflags, implicit-def dead $ssp, implicit $rsp, implicit $ssp - ; CHECK: STATEPOINT 0, 0, 1,

[PATCH] D91333: [clang][SveEmitter] Fix enum declarations. [NFCI]

fpetrogalli created this revision. fpetrogalli added reviewers: peterwaller-arm, paulwalker-arm, joechrisellis, efriedma. Herald added subscribers: cfe-commits, kristof.beyls, tschuett. Herald added a reviewer: rengolin. Herald added a project: clang. fpetrogalli requested review of this

[PATCH] D87981: [X86] AMX programming model prototype.

LuoYuanke updated this revision to Diff 304736. LuoYuanke added a comment. Fix clang-tidy. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87981/new/ https://reviews.llvm.org/D87981 Files: clang/include/clang/Basic/BuiltinsX86_64.def

[PATCH] D88987: [FPEnv][Clang][Driver] Use MarshallingInfoFlag for -fexperimental-strict-floating-point

jansvoboda11 accepted this revision. jansvoboda11 added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88987/new/ https://reviews.llvm.org/D88987 ___ cfe-commits mailing list

[PATCH] D91327: [NewPM] Redesign of PreserveCFG Checker

yrouban created this revision. yrouban added reviewers: skatkov, kuhar, asbirlea, fedor.sergeev. Herald added subscribers: cfe-commits, wenlei, steven_wu, hiraditya. Herald added projects: clang, LLVM. yrouban requested review of this revision. Please see the reason for this redesign in the patch

[PATCH] D71880: [clangd] Implement Decl canonicalization rules for rename

hokein added a comment. don't dig into details, first round of comments. I think the scope is a bit ambiguous, my reading is that it 1) removes old clang-rename API usage *and* 2) fixes some existing bugs. I would suggest just scoping it on 1). Comment at:

[clang-tools-extra] 6484aa1 - [clangd] Simplify relations deserialization loop, NFC.

Author: Kadir Cetinkaya Date: 2020-11-12T10:33:39+01:00 New Revision: 6484aa1add41e6483b60ad281b663968c2b68180 URL: https://github.com/llvm/llvm-project/commit/6484aa1add41e6483b60ad281b663968c2b68180 DIFF:

[PATCH] D91330: [clangd] Ensure we test for compatibility of serialized index format

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: cfe-commits, wenlei, usaxena95, arphaman. Herald added a project: clang. kadircet requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Repository: rG LLVM Github

  1   2   >