[PATCH] D91337: [clangd] Add missing tests to rename feature

kbobyrev updated this revision to Diff 305047. kbobyrev marked 4 inline comments as done. kbobyrev added a comment. Address the comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91337/new/ https://reviews.llvm.org/D91337 Files:

[PATCH] D89031: [SVE] Add support to vectorize_width loop pragma for scalable vectors

sdesmalen added a comment. In D89031#2391248 , @SjoerdMeijer wrote: > In D89031#2391160 , @david-arm wrote: > >> Hi @SjoerdMeijer I think that given we now support scalable vectors we >> thought it made sense to

[PATCH] D89909: [SYCL] Implement SYCL address space attributes handling

asavonic added inline comments. Comment at: clang/lib/CodeGen/CGExpr.cpp:4554 + + // Language rules define if it is legal to cast from one address space + // to another, and which address space we should use as a "common sdmitriev wrote: > bader wrote:

[PATCH] D90524: [Driver] Enable getOSLibDir() lib32 workaround for SPARC on Linux

glaubitz added a comment. Ping. It would be nice to get this finally merged so that the testsuite noise finally goes down on the sparc64 Linux worker. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90524/new/ https://reviews.llvm.org/D90524

[PATCH] D91410: [llvm][clang][mlir] Add checks for the return values from Target::createXXX to prevent protential null deref

OikawaKirie created this revision. OikawaKirie added reviewers: serge-sans-paille, ahmedcharles, niravd, echristo, maskray0, pcc, tejohnson, espindola, courbet, andreadb, epastor, enderby, lhames, whchung, ftynse. OikawaKirie added projects: LLVM, clang, MLIR. Herald added subscribers:

[PATCH] D91330: [clangd] Ensure we test for compatibility of serialized index format

kadircet updated this revision to Diff 305100. kadircet added a comment. - Drop comment markers - Make failure print the doc Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91330/new/ https://reviews.llvm.org/D91330 Files:

[PATCH] D90524: [Driver] Enable getOSLibDir() lib32 workaround for SPARC on Linux

ro resigned from this revision. ro added a comment. In D90524#2393353 , @glaubitz wrote: > In D90524#2393319 , @ro wrote: > >> In D90524#2388214 , @glaubitz wrote: >> >>> I

[PATCH] D91337: [clangd] Add missing tests to rename feature

hokein accepted this revision. hokein added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/unittests/RenameTests.cpp:618 + + // Templated method instantiation. + R"cpp( hokein wrote: > nit: we

[PATCH] D91405: [clangd] Assert on varint encoding

kadircet updated this revision to Diff 305094. kadircet marked an inline comment as done. kadircet added a comment. - Increase width of `B` to prevent integer promotion. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91405/new/

[PATCH] D91330: [clangd] Ensure we test for compatibility of serialized index format

kadircet updated this revision to Diff 305096. kadircet added a comment. - Update comments - Query for Bar - Only run with zlib Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91330/new/ https://reviews.llvm.org/D91330 Files:

[PATCH] D91405: [clangd] Assert on varint encoding

sammccall added inline comments. Comment at: clang-tools-extra/clangd/index/Serialization.cpp:94 B = consume8(); + assert((B & ~More) < (1 << (32 - Shift)) && "Invalid varint encoding"); Val |= (B & ~More) << Shift; hmm, actually it's also

[PATCH] D90524: [Driver] Enable getOSLibDir() lib32 workaround for SPARC on Linux

ro added a comment. In D90524#2393366 , @glaubitz wrote: > In D90524#2393320 , @ro wrote: > >> In D90524#2393312 , @glaubitz wrote: >> >>> Ping. It would be nice to get this

[clang] d2d59d2 - Reland [clang][cli] Port ObjCMTAction to new option parsing system

Author: Jan Svoboda Date: 2020-11-13T13:42:54+01:00 New Revision: d2d59d2be9852b620b982c7304de5d9eaca35404 URL: https://github.com/llvm/llvm-project/commit/d2d59d2be9852b620b982c7304de5d9eaca35404 DIFF: https://github.com/llvm/llvm-project/commit/d2d59d2be9852b620b982c7304de5d9eaca35404.diff

[PATCH] D90524: [Driver] Enable getOSLibDir() lib32 workaround for SPARC on Linux

glaubitz added a comment. > ! In D90524#2393635 , @ro wrote: > > I had an extremely hard time researching the history of directory layouts for > my patch D85582 . Do as you like, I'm out > of this. Please feel free to

[PATCH] D91258: [clangd] Sanity-check array sizes read from disk before allocating them.

sammccall added a comment. In D91258#2392646 , @eugenis wrote: > Hi Sam, > > this patch is failing on the ubsan bot with: > > [ RUN ] SerializationTest.NoCrashOnBadArraySize > >

[PATCH] D91337: [clangd] Add missing tests to rename feature

kbobyrev updated this revision to Diff 305070. kbobyrev added a comment. Move the rest of templated cases to appropriate location. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91337/new/ https://reviews.llvm.org/D91337 Files:

[PATCH] D90507: Adding DWARF64 clang flag

jansvoboda11 added a comment. Hi @ayermolo, do you think this might be triggered by D82756 ? (my only upstream patch ATM) Comment at: clang/test/Driver/debug-options.c:377 // NO_DEBUG_UNUSED_TYPES:

[clang-tools-extra] a115248 - [clangd] Add missing tests to rename feature

Author: Kirill Bobyrev Date: 2020-11-13T12:27:40+01:00 New Revision: a1152482826c9a80977871aa46e131ac803c5f44 URL: https://github.com/llvm/llvm-project/commit/a1152482826c9a80977871aa46e131ac803c5f44 DIFF:

[PATCH] D91405: [clangd] Assert on varint encoding

sammccall added inline comments. Comment at: clang-tools-extra/clangd/index/Serialization.cpp:90 B = consume8(); + assert((B & ~More) < (1 << (32 - Shift)) && "Invalid varint encoding"); Val |= (B & ~More) << Shift; I'm fine with an assert,

[PATCH] D91337: [clangd] Add missing tests to rename feature

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa1152482826c: [clangd] Add missing tests to rename feature (authored by kbobyrev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D91330: [clangd] Ensure we test for compatibility of serialized index format

sammccall added a comment. Very nice, thanks for doing this! Comment at: clang-tools-extra/clangd/test/index-serialization/version-is-correct.test:1 +# If this test fails it means there has been a backward incompatilbe change to +# serialization format. Please bump the

[PATCH] D91330: [clangd] Ensure we test for compatibility of serialized index format

sammccall added inline comments. Comment at: clang-tools-extra/clangd/test/index-serialization/version-is-correct.test:15 +# indexing sample.cpp would yield non-trivial values for those. +# RUN: dexp %/S/Inputs/sample.idx -c="find B" | grep Bar + as discussed

[PATCH] D85582: [clang][Driver] Search lib32 on Linux/sparc64 with -m32

ro abandoned this revision. ro added a comment. Herald added a subscriber: pengfei. Superceded by D90524 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85582/new/ https://reviews.llvm.org/D85582

[PATCH] D82860: Port ObjCMTAction to new option parsing system

jansvoboda11 added a comment. Thank you for the heads-up. It seems like Clang 5 didn't like the usage of `static constexpr` member via an instance. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82860/new/ https://reviews.llvm.org/D82860

[PATCH] D90956: [clang][SVE] Activate macro `__ARM_FEATURE_SVE_VECTOR_OPERATORS`.

rengolin accepted this revision. rengolin added a comment. Hi @fpetrogalli, the document is so dense that it took me a while to check the macros and I was still wrong. Either I'm losing my skill to read Arm documents or folks are getting worse at writing them. Giving this is a change that

[PATCH] D91368: Frontend: Split out addVFSOverlays from createVFSFromCompilerInvocation, NFC

jansvoboda11 accepted this revision. jansvoboda11 added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91368/new/ https://reviews.llvm.org/D91368 ___ cfe-commits mailing list

[PATCH] D91295: Frontend: Remove unused parameter from ASTUnit::LoadFromCompilerInvocationAction, NFC

jansvoboda11 added a comment. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91295/new/ https://reviews.llvm.org/D91295 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D91405: [clangd] Assert on varint encoding

kadircet updated this revision to Diff 305055. kadircet added a comment. - Also fix the high byte Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91405/new/ https://reviews.llvm.org/D91405 Files: clang-tools-extra/clangd/index/Serialization.cpp

[PATCH] D91348: [OpenCL] Warn about side effects for unevaluated vec_step arg

svenvh updated this revision to Diff 305058. svenvh added a comment. Add test case for OpenCL. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91348/new/ https://reviews.llvm.org/D91348 Files: clang/lib/Sema/SemaExpr.cpp

[PATCH] D90524: [Driver] Enable getOSLibDir() lib32 workaround for SPARC on Linux

ro added a comment. In D90524#2388214 , @glaubitz wrote: > I think it should be good for merging now. I addressed all remarks. I'm still > convinced that "workaround" is the proper term though. Quite the contrary: the comment you cited // FIXME: This

[PATCH] D90524: [Driver] Enable getOSLibDir() lib32 workaround for SPARC on Linux

glaubitz added a comment. In D90524#2393320 , @ro wrote: > In D90524#2393312 , @glaubitz wrote: > >> Ping. It would be nice to get this finally merged so that the testsuite >> noise finally goes down on the

[PATCH] D91147: AArch64: classify Triple::aarch64_32 as AArch64

t.p.northover added inline comments. Comment at: clang/lib/Driver/ToolChain.cpp:1066 if (getTriple().getArch() == llvm::Triple::x86_64 || - getTriple().isAArch64() || getTriple().isRISCV()) + (getTriple().isAArch64() && getTriple().isArch64Bit()) || +

[PATCH] D91366: Serialization: Hoist the check for in-flight diagnostics in ASTReader::getInputFile, NFC

jansvoboda11 accepted this revision. jansvoboda11 added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91366/new/ https://reviews.llvm.org/D91366 ___ cfe-commits mailing list

[PATCH] D91258: [clangd] Sanity-check array sizes read from disk before allocating them.

kadircet added a comment. oops, this is actually a problem of the test. it is providing an invalid encoding :/ sent out https://reviews.llvm.org/D91405 to fix the issue. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91258/new/

[PATCH] D91405: [clangd] Assert on varint encoding

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, arphaman. Herald added a project: clang. kadircet requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. 5th byte of a varint can't be bigger than

[PATCH] D91147: AArch64: classify Triple::aarch64_32 as AArch64

t.p.northover updated this revision to Diff 305064. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91147/new/ https://reviews.llvm.org/D91147 Files: clang/lib/Driver/ToolChain.cpp clang/test/Driver/frame-pointer-elim.c llvm/include/llvm/ADT/Triple.h

[PATCH] D91367: Serialization: Merge three diagnostics to simplify ASTReader::getInputFile, NFC

jansvoboda11 added a comment. Getting rid of the duplication is definitely nice. I left one inline question about the terminology used. Comment at: clang/include/clang/Basic/DiagnosticSerializationKinds.td:20 "malformed block record in PCH file: '%0'">, DefaultFatal;

[PATCH] D90524: [Driver] Enable getOSLibDir() lib32 workaround for SPARC on Linux

ro added a comment. In D90524#2393312 , @glaubitz wrote: > Ping. It would be nice to get this finally merged so that the testsuite noise > finally goes down on the sparc64 Linux worker. Please be a little more patient: one ping a week is considered

[PATCH] D88905: [Clang] Allow "ext_vector_type" applied to Booleans

simoll added a comment. Any comments for this one? Is this good to go? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88905/new/ https://reviews.llvm.org/D88905 ___ cfe-commits mailing list

[PATCH] D90524: [Driver] Enable getOSLibDir() lib32 workaround for SPARC on Linux

glaubitz added a comment. In D90524#2393319 , @ro wrote: > In D90524#2388214 , @glaubitz wrote: > >> I think it should be good for merging now. I addressed all remarks. I'm >> still convinced that "workaround" is

[PATCH] D90173: [PowerPC] Exploit splat instruction xxsplti32dx in Power10

NeHuang added a comment. Please clang-format the patch to pass pre-merge checks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90173/new/ https://reviews.llvm.org/D90173 ___ cfe-commits mailing list

[PATCH] D90871: [Sema] Fold VLAs to constant arrays in a few more contexts

erik.pilkington added a reviewer: efriedma. erik.pilkington added a comment. Ping! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90871/new/ https://reviews.llvm.org/D90871 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D91442: [clang][Driver] Handle risvc in Baremetal.cpp.

abidh created this revision. abidh added reviewers: asb, jroelofs, manojgupta, clang. Herald added subscribers: cfe-commits, frasercrmck, luismarques, apazos, sameer.abuasal, pzheng, s.egerton, lenary, Jim, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27,

[PATCH] D91442: [clang][Driver] Handle risvc in Baremetal.cpp.

jroelofs accepted this revision. jroelofs added a comment. This revision is now accepted and ready to land. Seems reasonable. I could see someone wanting to use `--gcc-toolchain` to point at the baremetal toolchain for their target, but that's unlikely to work out of the box anyway. I'd love

[PATCH] D91311: Add new 'preferred_name' attribute.

rsmith marked 2 inline comments as done. rsmith added inline comments. Comment at: libcxx/include/iosfwd:188 +#ifdef _LIBCPP_PREFERRED_NAME +template aaron.ballman wrote: > We always define `_LIBCPP_PREFERRED_NAME` so is this actually needed? Thanks, I was

[PATCH] D87928: Provide -fsource-dir flag in Clang

phosek added a comment. Ping? Is it OK to land this? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87928/new/ https://reviews.llvm.org/D87928 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D91035: [NFC, Refactor] Convert FunctionDefinitionKind from DeclSpech.h to a scoped enum

wchilders added inline comments. Comment at: clang/include/clang/Sema/DeclSpec.h:1762 }; +using FDK = FunctionDefinitionKind; aaron.ballman wrote: > rsmith wrote: > > I don't think it's OK to have an initialism like this in the `clang` > > namespace scope --

[PATCH] D91438: [AArch64] Define __ARM_FEATURE_{CRC32,ATOMICS}

chill accepted this revision. chill added a comment. This revision is now accepted and ready to land. LGTM, thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91438/new/ https://reviews.llvm.org/D91438

[PATCH] D91121: [InferAddrSpace] Teach to handle assumed address space.

hliao marked an inline comment as done. hliao added inline comments. Comment at: llvm/lib/Target/AMDGPU/AMDGPUTargetMachine.cpp:533 + auto *Ty = V->getType(); + if (!Ty->isPointerTy() || + Ty->getPointerAddressSpace() != AMDGPUAS::FLAT_ADDRESS) arsenm

[PATCH] D91121: [InferAddrSpace] Teach to handle assumed address space.

hliao updated this revision to Diff 305203. hliao added a comment. Revise the condition check. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91121/new/ https://reviews.llvm.org/D91121 Files:

[PATCH] D91428: Add support for multiple program address spaces

tlively added a comment. I think this is a good direction overall, and I'm glad the code doesn't become any messier with this change. I do think it would be good to also email llvm-dev about this change to get general feedback and make sure it doesn't require a full RFC.

[PATCH] D91389: [MemProf][NewPM] Make memprof passes required

leonardchan accepted this revision. leonardchan added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91389/new/ https://reviews.llvm.org/D91389

[PATCH] D91438: [AArch64] Define __ARM_FEATURE_{CRC32,ATOMICS}

avieira created this revision. Herald added subscribers: cfe-commits, danielkiss, jfb, kristof.beyls. Herald added a project: clang. avieira requested review of this revision. Hi all, This patch implements the definition of __ARM_FEATURE_ATOMICS and fixes the missing definition of

[PATCH] D91367: Serialization: Merge three diagnostics to simplify ASTReader::getInputFile, NFC

dexonsmith updated this revision to Diff 305184. dexonsmith added a comment. Rename to use `ast_` to match https://reviews.llvm.org/D91436. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91367/new/ https://reviews.llvm.org/D91367 Files:

[PATCH] D91330: [clangd] Ensure we test for compatibility of serialized index format

dmajor added a comment. This broke the bots: http://lab.llvm.org:8011/#/builders/109/builds/2682 File "/b/1/clang-x86_64-debian-fast/llvm.obj/tools/clang/tools/extra/clangd/test/lit.site.cfg.py", line 35 config.have_zlib = ^ SyntaxError: invalid syntax

[PATCH] D91436: Serialization: Rename three AST diagnostics, NFC

jansvoboda11 accepted this revision. jansvoboda11 added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91436/new/ https://reviews.llvm.org/D91436 ___ cfe-commits mailing list

[PATCH] D91442: [clang][Driver] Handle risvc in Baremetal.cpp.

jrtc27 added a comment. We use pure LLVM toolchains so improving support for that out of the box is good in my books. However, I do worry this is going to cause friction for a lot of people using LLVM for RISC-V; my understanding is that most use LLVM with a GNU sysroot and binutils, and so

[clang] d87fd09 - Serialization: Hoist the check for in-flight diagnostics in ASTReader::getInputFile, NFC

Author: Duncan P. N. Exon Smith Date: 2020-11-13T13:26:37-05:00 New Revision: d87fd096ac3eb27f376c0182ed5e3034ce240861 URL: https://github.com/llvm/llvm-project/commit/d87fd096ac3eb27f376c0182ed5e3034ce240861 DIFF:

[PATCH] D91366: Serialization: Hoist the check for in-flight diagnostics in ASTReader::getInputFile, NFC

This revision was automatically updated to reflect the committed changes. Closed by commit rGd87fd096ac3e: Serialization: Hoist the check for in-flight diagnostics in ASTReader… (authored by dexonsmith). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D91421: Fix temporary file name on Windows

yaxunl added inline comments. Comment at: clang/lib/Driver/Driver.cpp:4645 + // therefore replace it with '%'. + std::replace(BoundArch.begin(), BoundArch.end(), ':', '%'); +#endif tra wrote: > Windows `cmd` shell uses `%` to reference environment variables.

[PATCH] D91121: [InferAddrSpace] Teach to handle assumed address space.

arsenm added inline comments. Comment at: llvm/include/llvm/CodeGen/BasicTTIImpl.h:227 + Optional getAssumedAddrSpace(const Value *V) const { +return getTLI()->getTargetMachine().getAssumedAddrSpace(V); hliao wrote: > hliao wrote: > > arsenm wrote: > > >

[PATCH] D91385: [DFSan][NewPM] Handle dfsan under NPM

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6e098189db7d: [DFSan][NewPM] Handle dfsan under NPM (authored by aeubanks). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 6e09818 - [DFSan][NewPM] Handle dfsan under NPM

Author: Arthur Eubanks Date: 2020-11-13T13:41:38-08:00 New Revision: 6e098189db7da11bc9c32dd483cd81765804c241 URL: https://github.com/llvm/llvm-project/commit/6e098189db7da11bc9c32dd483cd81765804c241 DIFF:

[clang] b764a62 - Serialization: Rename three AST diagnostics, NFC

Author: Duncan P. N. Exon Smith Date: 2020-11-13T14:09:00-05:00 New Revision: b764a62f02e146bed96cf2231bd1db2d9d4fb72c URL: https://github.com/llvm/llvm-project/commit/b764a62f02e146bed96cf2231bd1db2d9d4fb72c DIFF:

[PATCH] D91436: Serialization: Rename three AST diagnostics, NFC

This revision was automatically updated to reflect the committed changes. Closed by commit rGb764a62f02e1: Serialization: Rename three AST diagnostics, NFC (authored by dexonsmith). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D91387: [Driver] Support UBSan multilib

mcgrathr added inline comments. Comment at: clang/cmake/caches/Fuchsia-stage2.cmake:214-215 + set(RUNTIMES_${target}-unknown-fuchsia+ubsan+noexcept_LLVM_BUILD_COMPILER_RT OFF CACHE BOOL "") +set(RUNTIMES_${target}-unknown-fuchsia+ubsan+noexcept_LLVM_USE_SANITIZER

[clang-tools-extra] 8dc2aa0 - [clangd] Canonicalize LLVM_ENABLE_ZLIB

Author: Kadir Cetinkaya Date: 2020-11-13T18:20:37+01:00 New Revision: 8dc2aa0e412171dad5cdc1aa60a92ddcd3800202 URL: https://github.com/llvm/llvm-project/commit/8dc2aa0e412171dad5cdc1aa60a92ddcd3800202 DIFF:

[PATCH] D91279: [PowerPC] DForm instructions should be preferred when using zero register

NeHuang added inline comments. Comment at: llvm/lib/Target/PowerPC/PPCPreEmitPeephole.cpp:417 + + // should prefer D-form if LXVX / STXVX uses a ZERO or ZERO8 + if (MI.getOpcode() == PPC::LXVX || MI.getOpcode() == PPC::STXVX) { amyk wrote: >

[PATCH] D91330: [clangd] Ensure we test for compatibility of serialized index format

kadircet added a comment. should be fixed with  https://github.com/llvm/llvm-project/commit/8dc2aa0e412171dad5cdc1aa60a92ddcd3800202. please let me know if it doesn't work. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91330/new/

[PATCH] D91367: Serialization: Merge three diagnostics to simplify ASTReader::getInputFile, NFC

jansvoboda11 accepted this revision. jansvoboda11 added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/include/clang/Basic/DiagnosticSerializationKinds.td:20 "malformed block record in PCH file: '%0'">, DefaultFatal; def

[PATCH] D91442: [clang][Driver] Handle risvc in Baremetal.cpp.

abidh added a comment. In D91442#2394513 , @jrtc27 wrote: > We use pure LLVM toolchains so improving support for that out of the box is > good in my books. However, I do worry this is going to cause friction for a > lot of people using LLVM for RISC-V;

[PATCH] D90799: [PowerPC] Add paired vector load and store builtins and intrinsics

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3f78605a8cb1: [PowerPC] Add paired vector load and store builtins and intrinsics (authored by bsaleil). Repository: rG LLVM Github Monorepo

[clang] 3f78605 - [PowerPC] Add paired vector load and store builtins and intrinsics

Author: Baptiste Saleil Date: 2020-11-13T12:35:10-06:00 New Revision: 3f78605a8cb121d005c0ad11cce83cf58be983f2 URL: https://github.com/llvm/llvm-project/commit/3f78605a8cb121d005c0ad11cce83cf58be983f2 DIFF:

[PATCH] D91447: [WebAssembly] Rename atomic.notify and *.atomic.wait

aheejin created this revision. aheejin added a reviewer: tlively. Herald added subscribers: llvm-commits, cfe-commits, wingo, ecnelises, jfb, sunfish, hiraditya, jgravelle-google, sbc100, dschuff. Herald added projects: clang, LLVM. aheejin requested review of this revision. - atomic.notify ->

[PATCH] D91121: [InferAddrSpace] Teach to handle assumed address space.

hliao marked 3 inline comments as done. hliao added inline comments. Comment at: llvm/include/llvm/CodeGen/BasicTTIImpl.h:227 + Optional getAssumedAddrSpace(const Value *V) const { +return getTLI()->getTargetMachine().getAssumedAddrSpace(V); arsenm wrote:

[PATCH] D90188: Add support for attribute 'using_if_exists'

erik.pilkington updated this revision to Diff 305193. erik.pilkington marked 2 inline comments as done. erik.pilkington added a comment. Herald added a subscriber: jdoerfert. Add support for C++11-style attributes on using-declarations. CHANGES SINCE LAST ACTION

[clang] 66b876c - Pass the source range when diagnosing an unknown attribute

Author: Aaron Ballman Date: 2020-11-13T10:29:44-08:00 New Revision: 66b876c014ad57e7d750a2063a4abac6babd8ef1 URL: https://github.com/llvm/llvm-project/commit/66b876c014ad57e7d750a2063a4abac6babd8ef1 DIFF: https://github.com/llvm/llvm-project/commit/66b876c014ad57e7d750a2063a4abac6babd8ef1.diff

[PATCH] D91385: [DFSan][NewPM] Handle dfsan under NPM

leonardchan accepted this revision. leonardchan added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91385/new/ https://reviews.llvm.org/D91385

[PATCH] D66324: clang-misexpect: Profile Guided Validation of Performance Annotations in LLVM

lebedev.ri added a comment. In D66324#2336555 , @lebedev.ri wrote: > In D66324#2336186 , @phosek wrote: > >> I apologize for the late response, I somehow missed the earlier responses. >> We have successfully used

[PATCH] D87188: [InstCombine] Canonicalize SPF to abs intrinc

nikic updated this revision to Diff 305232. nikic added a comment. Rebase. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87188/new/ https://reviews.llvm.org/D87188 Files: clang/test/CodeGen/builtins-wasm.c llvm/lib/Transforms/InstCombine/InstCombineSelect.cpp

[PATCH] D91447: [WebAssembly] Rename atomic.notify and *.atomic.wait

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG902ea588eab8: [WebAssembly] Rename atomic.notify and *.atomic.wait (authored by aheejin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang] 902ea58 - [WebAssembly] Rename atomic.notify and *.atomic.wait

Author: Heejin Ahn Date: 2020-11-13T12:04:48-08:00 New Revision: 902ea588eab849e7254d3bc76abf32d833ac0dd6 URL: https://github.com/llvm/llvm-project/commit/902ea588eab849e7254d3bc76abf32d833ac0dd6 DIFF: https://github.com/llvm/llvm-project/commit/902ea588eab849e7254d3bc76abf32d833ac0dd6.diff

[PATCH] D91455: [XCOFF][AIX] Generate LSDA data and compact unwind section on AIX

jasonliu created this revision. jasonliu added reviewers: xingxue, hubert.reinterpretcast, cebowleratibm, DiggerLin, daltenty. Herald added subscribers: llvm-commits, kbarton, hiraditya, mgorny, nemanjai. Herald added a project: LLVM. jasonliu requested review of this revision. Herald added a

[PATCH] D91417: [IRGen] Add !annotation metadata for auto-init stores.

paquette accepted this revision. paquette added a comment. This revision is now accepted and ready to land. I think this looks reasonable. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91417/new/ https://reviews.llvm.org/D91417

[PATCH] D91295: Frontend: Remove unused parameter from ASTUnit::LoadFromCompilerInvocationAction, NFC

This revision was automatically updated to reflect the committed changes. Closed by commit rGcfde3edeae47: Frontend: Remove unused parameter from ASTUnit… (authored by dexonsmith). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] cfde3ed - Frontend: Remove unused parameter from ASTUnit::LoadFromCompilerInvocationAction, NFC

Author: Duncan P. N. Exon Smith Date: 2020-11-13T17:47:17-05:00 New Revision: cfde3edeae4730aa44642c4835bcfa5a857ea8d4 URL: https://github.com/llvm/llvm-project/commit/cfde3edeae4730aa44642c4835bcfa5a857ea8d4 DIFF:

[PATCH] D91330: [clangd] Ensure we test for compatibility of serialized index format

dmajor added a comment. In D91330#2394415 , @kadircet wrote: > Looks like it is already green at > http://lab.llvm.org:8011/#/builders/109/builds/2693 Yep, I'm seeing the same, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D91330: [clangd] Ensure we test for compatibility of serialized index format

kadircet added a comment. Looks like it is already green at http://lab.llvm.org:8011/#/builders/109/builds/2693 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91330/new/ https://reviews.llvm.org/D91330

[PATCH] D91421: Fix temporary file name on Windows

tra accepted this revision. tra added a comment. This revision is now accepted and ready to land. LGTM overall, nit about the character choice. Comment at: clang/lib/Driver/Driver.cpp:4645 + // therefore replace it with '%'. + std::replace(BoundArch.begin(), BoundArch.end(),

[PATCH] D91448: [WebAssembly] Remove a temporarily added RUN line

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG01d871536940: [WebAssembly] Remove a temporarily added RUN line (authored by aheejin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D90972: [clang-tidy] Install run-clang-tidy.py in bin/ as run-clang-tidy

JonasToth accepted this revision. JonasToth added a comment. LGTM! thanks for fixing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90972/new/ https://reviews.llvm.org/D90972 ___ cfe-commits mailing

[PATCH] D91262: [AArch64][SVE] Allow C-style casts between fixed-size and scalable vectors

c-rhodes added inline comments. Comment at: clang/lib/Sema/SemaCast.cpp:2217-2218 - // Allow reinterpret_casts between vectors of the same size and - // between vectors and integers of the same size. bool destIsVector = DestType->isVectorType(); nit: not

[PATCH] D91448: [WebAssembly] Remove a temporarily added RUN line

tlively accepted this revision. tlively added a comment. This revision is now accepted and ready to land. Wow, that bug is wild! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91448/new/ https://reviews.llvm.org/D91448

[PATCH] D91035: [NFC, Refactor] Convert FunctionDefinitionKind from DeclSpech.h to a scoped enum

wchilders added a comment. Replying to inline comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91035/new/ https://reviews.llvm.org/D91035 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D87928: Provide -fsource-dir flag in Clang

dexonsmith added reviewers: Bigcheese, jansvoboda11, arphaman. dexonsmith added a comment. I missed this before, and it's an interesting problem. I have a few questions: - I'm not clear on the expected interaction between the current working directory of the compiler and `-fsource-dir`. What

[clang] a2f2c2f - Serialization: Merge three diagnostics to simplify ASTReader::getInputFile, NFC

Author: Duncan P. N. Exon Smith Date: 2020-11-13T16:23:04-05:00 New Revision: a2f2c2f3a46351bc5478acd290258d318af2cd88 URL: https://github.com/llvm/llvm-project/commit/a2f2c2f3a46351bc5478acd290258d318af2cd88 DIFF:

[PATCH] D91367: Serialization: Merge three diagnostics to simplify ASTReader::getInputFile, NFC

This revision was automatically updated to reflect the committed changes. Closed by commit rGa2f2c2f3a463: Serialization: Merge three diagnostics to simplify ASTReader::getInputFile, NFC (authored by dexonsmith). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE

[clang] b09154e - [CMake] Explicity set up RPATH for the runtime libs on Win to ARM Linux cross builds.

Author: Vladimir Vereschaka Date: 2020-11-13T14:32:35-08:00 New Revision: b09154ebf95f3120414487ff7388e77393eb58c2 URL: https://github.com/llvm/llvm-project/commit/b09154ebf95f3120414487ff7388e77393eb58c2 DIFF:

[PATCH] D91448: [WebAssembly] Remove a temporarily added RUN line

aheejin created this revision. aheejin added a reviewer: tlively. Herald added subscribers: cfe-commits, wingo, ecnelises, sunfish, jgravelle-google, sbc100, dschuff. Herald added a project: clang. aheejin requested review of this revision. This RUN line was added as a temporary measure to undo

[PATCH] D91311: Add new 'preferred_name' attribute.

rsmith updated this revision to Diff 305222. rsmith added a comment. - Properly disable redundant redeclarations if preferred_name attribute is Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91311/new/ https://reviews.llvm.org/D91311 Files:

  1   2   >