[PATCH] D91596: [PowerPC] [Clang] Fix alignment of 128-bit floating types

qiucf updated this revision to Diff 305692. qiucf added a comment. Use another branch CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91596/new/ https://reviews.llvm.org/D91596 Files: clang/lib/CodeGen/TargetInfo.cpp clang/test/CodeGen/ppc64le-varargs-f128.c Index:

[PATCH] D91601: [clang-tidy] Fix an abseil-redundant-strcat-calls crash on 0-parameter StrCat().

gribozavr2 accepted this revision. gribozavr2 added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clang-tidy/abseil/RedundantStrcatCallsCheck.cpp:51 + if (Call->getNumArgs() == 0) +return; // Remove 'Foo('

[PATCH] D91602: [clang-tidy] Make clang-format and include-order-check coherent

kadircet updated this revision to Diff 305707. kadircet added a comment. - Add gmock header Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91602/new/ https://reviews.llvm.org/D91602 Files: clang-tools-extra/clang-tidy/llvm/IncludeOrderCheck.cpp

[PATCH] D90851: [clang-tidy] Extending bugprone-signal-handler with POSIX functions.

balazske added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/Inputs/Headers/system-header-posix-api.h:1 -//===--- signal.h - Stub header for tests ---*- C++ -*-===// +//===--- system-header-posix-api.h - Stub header for tests

[PATCH] D91601: [clang-tidy] Fix an abseil-redundant-strcat-calls crash on 0-parameter StrCat().

hokein created this revision. hokein added a reviewer: gribozavr2. Herald added a subscriber: xazax.hun. Herald added a project: clang. hokein requested review of this revision. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D91601 Files:

[PATCH] D91592: [ASTMatchers] Fix typo for hasAnyOverloadedOperatorName

keishi created this revision. keishi added a reviewer: aaron.ballman. Herald added a project: clang. Herald added a subscriber: cfe-commits. keishi requested review of this revision. Fix typo for hasAnyOverloadedOperatorName in doc and code comment. Repository: rG LLVM Github Monorepo

[PATCH] D85474: Add -fbinutils-version= to gate ELF features on the specified binutils version

jhenderson added a comment. In D85474#2398858 , @MaskRay wrote: > Sent https://lists.llvm.org/pipermail/llvm-dev/2020-November/146676.html "Add > -fbinutils-version=" (cross posted to cfe-dev) so that more folks can notice > it. > > About "generate code

[PATCH] D89296: [clangd] Call hierarchy (Protocol layer)

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks, LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89296/new/ https://reviews.llvm.org/D89296

[PATCH] D90441: [X86] Add support for vex, vex2, vex3, and evex for MASM

LiuChen3 added a comment. Ping? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90441/new/ https://reviews.llvm.org/D90441 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D91602: [clang-tidy] Make clang-format and include-order-check coherent

kadircet created this revision. kadircet added a reviewer: hokein. Herald added subscribers: cfe-commits, xazax.hun. Herald added a project: clang. kadircet requested review of this revision. LLVM style puts both gtest and gmock to the end of the include list. But llvm-include-order-check was

[clang-tools-extra] 218500d - [clang-tidy] Verify the fixes in abseil-redundant-strcat-calls test, NFC

Author: Haojian Wu Date: 2020-11-17T10:15:29+01:00 New Revision: 218500d823c8f0f43fb9c0d8e2ed5d4dd197785b URL: https://github.com/llvm/llvm-project/commit/218500d823c8f0f43fb9c0d8e2ed5d4dd197785b DIFF: https://github.com/llvm/llvm-project/commit/218500d823c8f0f43fb9c0d8e2ed5d4dd197785b.diff

[clang] 9faedb2 - [Driver] Quote executable in reports generated by -fproc-stat-report

Author: Serge Pavlov Date: 2020-11-17T15:16:09+07:00 New Revision: 9faedb2d7146d29bfd0f601e2a4a90b546cdaf04 URL: https://github.com/llvm/llvm-project/commit/9faedb2d7146d29bfd0f601e2a4a90b546cdaf04 DIFF: https://github.com/llvm/llvm-project/commit/9faedb2d7146d29bfd0f601e2a4a90b546cdaf04.diff

[PATCH] D91596: [PowerPC] [Clang] Fix alignment of 128-bit floating types

qiucf created this revision. qiucf added reviewers: jsji, nemanjai, uweigand, PowerPC, steven.zhang, rjmccall. Herald added subscribers: cfe-commits, shchenz, kbarton. Herald added a project: clang. qiucf requested review of this revision. According to ELF v2 ABI, both IEEE 128-bit and IBM

[PATCH] D90750: [clangd] Introduce ProjectAwareIndex

kadircet added inline comments. Comment at: clang-tools-extra/clangd/index/ProjectAware.cpp:100 + }); + addIndex(std::move(NewIndex)); + return PlaceHolder; sammccall wrote: > from memoize: > > > Concurrent calls for the same key may

[PATCH] D90750: [clangd] Introduce ProjectAwareIndex

kadircet updated this revision to Diff 305695. kadircet marked 5 inline comments as done. kadircet added a comment. - Address comments - Only query the associated index - Use ExternalIndexSpec as the cache key Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D91601: [clang-tidy] Fix an abseil-redundant-strcat-calls crash on 0-parameter StrCat().

This revision was automatically updated to reflect the committed changes. Closed by commit rGaf0d607e7275: [clang-tidy] Fix an abseil-redundant-strcat-calls crash on 0-parameter StrCat(). (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang-tools-extra] af0d607 - [clang-tidy] Fix an abseil-redundant-strcat-calls crash on 0-parameter StrCat().

Author: Haojian Wu Date: 2020-11-17T11:05:24+01:00 New Revision: af0d607e727512775e8dbec1baf7bfa15c7ecb48 URL: https://github.com/llvm/llvm-project/commit/af0d607e727512775e8dbec1baf7bfa15c7ecb48 DIFF: https://github.com/llvm/llvm-project/commit/af0d607e727512775e8dbec1baf7bfa15c7ecb48.diff

[PATCH] D91538: [RFC][OpenCL] Make Tablegen header work with extensions that are not added in clang

Anastasia updated this revision to Diff 305724. Anastasia added a comment. Added full diffs. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91538/new/ https://reviews.llvm.org/D91538 Files: clang/include/clang/Basic/OpenCLExtensions.def clang/lib/Basic/Targets/AMDGPU.h

[clang] 0627140 - [clang][driver] Fix definition/declaration argument name mismatches. NFCI.

Author: Simon Pilgrim Date: 2020-11-17T12:39:45Z New Revision: 0627140cd593e20b89b55e309c35c82ef618190e URL: https://github.com/llvm/llvm-project/commit/0627140cd593e20b89b55e309c35c82ef618190e DIFF: https://github.com/llvm/llvm-project/commit/0627140cd593e20b89b55e309c35c82ef618190e.diff

[clang] d44edfc - [clang][NFC] Use SmallString instead of SmallVector

Author: Nathan James Date: 2020-11-17T13:02:58Z New Revision: d44edfc1094ceece13e30e36dcc4a51b6eeebdaa URL: https://github.com/llvm/llvm-project/commit/d44edfc1094ceece13e30e36dcc4a51b6eeebdaa DIFF: https://github.com/llvm/llvm-project/commit/d44edfc1094ceece13e30e36dcc4a51b6eeebdaa.diff LOG:

[PATCH] D90944: [clang-tidy] implement misc-mt-unsafe

njames93 added a comment. Also can this be ran through clang-tidy, feeling a few naming violations are in here. If you use arc to upload your patches you'll get lint warnings about clang-tidy and clang-format. Comment at:

[PATCH] D90851: [clang-tidy] Extending bugprone-signal-handler with POSIX functions.

aaron.ballman added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/Inputs/Headers/system-header-posix-api.h:1 -//===--- signal.h - Stub header for tests ---*- C++ -*-===// +//===--- system-header-posix-api.h - Stub header for tests

[clang] 6976fef - Update 'note-candiate' functions to skip lambda-conversion-op-overloads

Author: Erich Keane Date: 2020-11-17T05:49:31-08:00 New Revision: 6976fef05b7e5301815baa6cc4af27284e8aceb4 URL: https://github.com/llvm/llvm-project/commit/6976fef05b7e5301815baa6cc4af27284e8aceb4 DIFF: https://github.com/llvm/llvm-project/commit/6976fef05b7e5301815baa6cc4af27284e8aceb4.diff

[PATCH] D91262: [AArch64][SVE] Allow C-style casts between fixed-size and scalable vectors

joechrisellis updated this revision to Diff 305763. joechrisellis marked 7 inline comments as done. joechrisellis added a comment. Address @c-rhodes's and @peterwaller-arm's comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91262/new/

[PATCH] D91410: [llvm][clang][mlir] Add checks for the return values from Target::createXXX to prevent protential null deref

ftynse added a comment. Herald added a subscriber: teijeong. LGTM for the MLIR part Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91410/new/ https://reviews.llvm.org/D91410 ___ cfe-commits mailing list

[PATCH] D91262: [AArch64][SVE] Allow C-style casts between fixed-size and scalable vectors

joechrisellis added inline comments. Comment at: clang/lib/Sema/SemaCast.cpp:2217-2218 - // Allow reinterpret_casts between vectors of the same size and - // between vectors and integers of the same size. bool destIsVector = DestType->isVectorType();

[PATCH] D91410: [llvm][clang][mlir] Add checks for the return values from Target::createXXX to prevent protential null deref

courbet added a comment. LGTM for llvm-exegesis Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91410/new/ https://reviews.llvm.org/D91410 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D91262: [AArch64][SVE] Allow C-style casts between fixed-size and scalable vectors

c-rhodes added inline comments. Comment at: clang/lib/Sema/SemaCast.cpp:2217-2218 - // Allow reinterpret_casts between vectors of the same size and - // between vectors and integers of the same size. bool destIsVector = DestType->isVectorType();

[PATCH] D91602: [clang-tidy] Make clang-format and include-order-check coherent

kadircet added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/llvm-include-order.cpp:1 // RUN: %check_clang_tidy %s llvm-include-order %t -- -- -isystem %S/Inputs/Headers njames93 wrote: > Would it be wise to specify a format style

[PATCH] D91605: [sanitizers] Implement GetTls on Solaris

ro created this revision. ro added reviewers: vitalybuka, MaskRay. ro added a project: Sanitizers. Herald added subscribers: Sanitizers, pengfei, fedor.sergeev, mgorny, jyknight. Herald added a project: clang. ro requested review of this revision. In the initial Solaris ASan port, `GetTls` was

[PATCH] D91122: [clangd] Call hierarchy (XRefs layer, incoming calls)

kadircet added a comment. mostly LG, i haven't looked at the tests yet though. Comment at: clang-tools-extra/clangd/XRefs.cpp:1344 + auto Result = declToHierarchyItem(ND); + if (Result) { +Result->deprecated = ND.isDeprecated(); nit: redundant braces

[PATCH] D72184: [BPF] support atomic instructions

jackmanb added inline comments. Comment at: llvm/lib/Target/BPF/BPFInstrInfo.td:684 + let Inst{47-32} = addr{15-0}; // offset + let Inst{11-8} = val; + let Inst{7-4} = Opc.Value; yonghong-song wrote: > jackmanb wrote: > > jackmanb wrote: > > > jackmanb wrote:

[PATCH] D88394: [Driver][M68k] (Patch 8/8) Add driver support for M68k

rengolin added inline comments. Comment at: clang/include/clang/Driver/Options.td:3125 +foreach i = {0-4} in + def m680#i#0 : Flag<["-"], "m680"#i#"0">, Group; Same question as @RKSimon had below: Shouldn't this cover all models the back-end recognises?

[PATCH] D91429: [OpenCL] Stop opencl-c-base.h leaking extension enabling

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf0c690018ad1: [OpenCL] Stop opencl-c-base.h leaking extension enabling (authored by svenvh). Repository: rG LLVM Github Monorepo CHANGES SINCE

[clang] f0c6900 - [OpenCL] Stop opencl-c-base.h leaking extension enabling

Author: Sven van Haastregt Date: 2020-11-17T12:07:40Z New Revision: f0c690018ad1fb4746da3aca26a443c0f96530fa URL: https://github.com/llvm/llvm-project/commit/f0c690018ad1fb4746da3aca26a443c0f96530fa DIFF: https://github.com/llvm/llvm-project/commit/f0c690018ad1fb4746da3aca26a443c0f96530fa.diff

[PATCH] D89869: [OpenCL] Define OpenCL feature macros for all versions

Anastasia added inline comments. Comment at: clang/include/clang/Basic/OpenCLExtensions.def:100 +// OpenCL features +OPENCLFEAT_INTERNAL(__opencl_c_pipes, 200, ~0U) +OPENCLFEAT_INTERNAL(__opencl_c_generic_address_space, 200, ~0U) azabaznov wrote: > Anastasia

[PATCH] D18914: [clang-tidy] new readability-redundant-inline

chfast added a comment. This check can be useful in other case like this: inline constexpr const int x = 1; where `inline` and `const` are redundant. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D18914/new/ https://reviews.llvm.org/D18914

[PATCH] D90944: [clang-tidy] implement concurrent-mt-unsafe

segoon updated this revision to Diff 305764. segoon retitled this revision from "[clang-tidy] implement misc-mt-unsafe" to "[clang-tidy] implement concurrent-mt-unsafe". segoon added a comment. Herald added subscribers: sstefan1, arphaman. Herald added a reviewer: jdoerfert. - move plugin to

[PATCH] D90944: [clang-tidy] implement concurrent-mt-unsafe

njames93 added a comment. In D90944#2399759 , @segoon wrote: > - move plugin to `concurrent` group While this is definitely a step in the right direction, it should be a separate patch to introduce the new module. After making that, set this to be a

[PATCH] D91610: [clangd] Add OverridenBy Relation to index.

usaxena95 created this revision. Herald added subscribers: cfe-commits, kadircet, arphaman. Herald added a project: clang. usaxena95 requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. This was previously explored in reviews.llvm.org/D69094

[PATCH] D88393: [cfe][M68k] (Patch 7/8) Basic Clang support

rengolin added inline comments. Comment at: clang/lib/Basic/Targets.cpp:314 +default: + return new M68kTargetInfo(Triple, Opts); +} No support for bare-metal? Comment at: clang/lib/Basic/Targets/M68k.cpp:123 +"d0", "d1", "d2",

[PATCH] D91442: [clang][Driver] Handle risvc in Baremetal.cpp.

lenary added a comment. In D91442#2399341 , @abidh wrote: > In D91442#2399200 , @lenary wrote: > >> I'm worried about this change - I *think* it doesn't cover the existing >> behaviour of a baremetal GCC toolchain

[PATCH] D90944: [clang-tidy] implement misc-mt-unsafe

segoon added inline comments. Comment at: clang-tools-extra/clang-tidy/misc/MtUnsafeCheck.cpp:295 + case MtUnsafeCheck::LibcType::Any: +return hasAnyName(anyFunctions); + } lebedev.ri wrote: > return anyOf(hasAnyName(posixFunctions),

[PATCH] D90982: Ignore implicit nodes in IgnoreUnlessSpelledInSource mode

steveire updated this revision to Diff 305767. steveire added a comment. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90982/new/ https://reviews.llvm.org/D90982 Files: clang/docs/ReleaseNotes.rst

[PATCH] D91442: [clang][Driver] Handle risvc in Baremetal.cpp.

jrtc27 added a comment. In D91442#2399750 , @abidh wrote: > In D91442#2399402 , @lenary wrote: > >> In D91442#2399341 , @abidh wrote: >> >>> In D91442#2399200

[PATCH] D91262: [AArch64][SVE] Allow C-style casts between fixed-size and scalable vectors

joechrisellis updated this revision to Diff 305769. joechrisellis added a comment. Address @c-rhodes's comment regarding comment change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91262/new/ https://reviews.llvm.org/D91262 Files:

[PATCH] D91607: [clang][Sparc] Fix __builtin_extract_return_addr etc.

ro created this revision. ro added reviewers: efriedma, brad. Herald added subscribers: atanasyan, fedor.sergeev, kristof.beyls, arichardson, sdardis, jyknight. Herald added a project: clang. ro requested review of this revision. While investigating the failures of `symbolize_pc.cpp` and

[PATCH] D91531: [RFC][OpenCL] Provide mechanisms for defining extension macros

Anastasia updated this revision to Diff 305721. Anastasia added a comment. - Added full diffs. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91531/new/ https://reviews.llvm.org/D91531 Files: clang/include/clang/Basic/OpenCLExtensions.def clang/include/clang/Basic/TargetInfo.h

[PATCH] D91534: [RFC][OpenCL] Add new diagnostic for extension pragma with no effect

Anastasia updated this revision to Diff 305723. Anastasia added a comment. Added full diff. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91534/new/ https://reviews.llvm.org/D91534 Files: clang/docs/DiagnosticsReference.rst clang/include/clang/Basic/DiagnosticParseKinds.td

[PATCH] D91442: [clang][Driver] Handle risvc in Baremetal.cpp.

abidh added a comment. In D91442#2399200 , @lenary wrote: > I'm worried about this change - I *think* it doesn't cover the existing > behaviour of a baremetal GCC toolchain being installed into the same prefix > as clang, and clang automatically picking

[PATCH] D88393: [cfe][M68k] (Patch 7/8) Basic Clang support

RKSimon added inline comments. Comment at: clang/lib/Basic/CMakeLists.txt:78 Targets/Mips.cpp + Targets/M68k.cpp Targets/NVPTX.cpp (sorting) - move after Le64.cpp Comment at: clang/lib/CodeGen/TargetInfo.cpp:8087 + if (const

[PATCH] D91047: Add a call super attribute plugin example

psionic12 added inline comments. Comment at: clang/docs/ClangPlugins.rst:116 +Defining CallSuperAttr +== After a whole day's research of `Sphinx`, I figured out that `ClangPlugins.rst` is the "proto-type" of

[PATCH] D91047: Add a call super attribute plugin example

psionic12 marked an inline comment as done. psionic12 added inline comments. Comment at: clang/test/Frontend/plugin-call-super.cpp:18-19 +struct Derive2 : public Base1, public Base2 { void Test() override { Base1::Test(); Base2::Test();}}; +// BADCALLSUPER: warning: virtual

[PATCH] D78903: [Driver] Add option -fproc-stat-report

sepavloff added a comment. In D78903#2397845 , @tschuett wrote: > Could you add quotation marks around the executable name to make the CSV file > easier to parse? Implemented: rG9faedb2d7146

[PATCH] D91543: [clang-tidy] Improving bugprone-sizeof-expr check.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM aside from a testing request. Comment at: clang-tools-extra/test/clang-tidy/checkers/bugprone-sizeof-expression.cpp:301 + sum += sizeof(PtrArray) /

[clang-tools-extra] 5a9f386 - [clang-tidy] Make clang-format and include-order-check coherent

Author: Kadir Cetinkaya Date: 2020-11-17T14:54:10+01:00 New Revision: 5a9f3867046c4e1c97760e22a505f4d1d788417e URL: https://github.com/llvm/llvm-project/commit/5a9f3867046c4e1c97760e22a505f4d1d788417e DIFF:

[PATCH] D91311: Add new 'preferred_name' attribute.

aaron.ballman added a comment. In D91311#2398526 , @rsmith wrote: > In D91311#2398144 , @ldionne wrote: > >> I think that the fact we need to re declare everything shows how the >> ergonomics would be better if we

[PATCH] D91602: [clang-tidy] Make clang-format and include-order-check coherent

This revision was automatically updated to reflect the committed changes. Closed by commit rG5a9f3867046c: [clang-tidy] Make clang-format and include-order-check coherent (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D91442: [clang][Driver] Handle risvc in Baremetal.cpp.

abidh added a comment. In D91442#2399402 , @lenary wrote: > In D91442#2399341 , @abidh wrote: > >> In D91442#2399200 , @lenary wrote: >> >>> I'm worried about this change -

[PATCH] D91442: [clang][Driver] Handle risvc in Baremetal.cpp.

lenary added a comment. I recall that there is also https://reviews.llvm.org/D68407 which iirc hoped to address using `RISCVToolchain` with Compiler-rt and libunwind - presumably it is not a complete solution, but it might be we want to use some checking of the GCCInstallation (like

[PATCH] D91592: [ASTMatchers] Fix typo for hasAnyOverloadedOperatorName

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Do you need me to commit on your behalf? If so, is `Keishi Hattori ` the correct attribution you'd like me to use? Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D90944: [clang-tidy] implement misc-mt-unsafe

lebedev.ri added inline comments. Comment at: clang-tools-extra/clang-tidy/misc/MtUnsafeCheck.cpp:279-282 + llvm::DenseSet result; + result.insert(std::begin(posixFunctions), std::end(posixFunctions)); + result.insert(std::begin(glibcFunctions), std::end(glibcFunctions)); +

[PATCH] D91626: [clangd] Implement textDocument/implementation.

usaxena95 created this revision. Herald added subscribers: cfe-commits, kadircet, arphaman. Herald added a project: clang. usaxena95 requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D91626 Files:

[PATCH] D91627: [OPENMP] Fix PR47999: correctly map implicit firstprivates in outer tasks.

ABataev created this revision. ABataev added a reviewer: jdoerfert. Herald added subscribers: guansong, yaxunl. Herald added a project: clang. ABataev requested review of this revision. Herald added a subscriber: sstefan1. If the variable is implicitly firstprivatized in the inner task-based

[PATCH] D89869: [OpenCL] Define OpenCL feature macros for all versions

azabaznov added inline comments. Comment at: clang/include/clang/Basic/OpenCLExtensions.def:100 +// OpenCL features +OPENCLFEAT_INTERNAL(__opencl_c_pipes, 200, ~0U) +OPENCLFEAT_INTERNAL(__opencl_c_generic_address_space, 200, ~0U) Anastasia wrote: > Btw I guess

[PATCH] D91442: [clang][Driver] Handle risvc in Baremetal.cpp.

lenary added a comment. I'm worried about this change - I *think* it doesn't cover the existing behaviour of a baremetal GCC toolchain being installed into the same prefix as clang, and clang automatically picking up that baremetal gcc toolchain. What should we expect to do here? This is

[PATCH] D91047: Add a call super attribute plugin example

psionic12 updated this revision to Diff 305725. psionic12 added a comment. use `VerifyDiagnosticConsumer` (-verify) instead of `FileCheck` for syntax only feature test. remove illustration in ClangPlugins.rst (which is not very appropriate) Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D91614: [clang-tidy] Fix a nullptr-access crash in unused-raii-check.

hokein created this revision. hokein added a reviewer: gribozavr2. Herald added a subscriber: xazax.hun. Herald added a project: clang. hokein requested review of this revision. I saw this crash in our internal production, but unfortunately didn't get reproduced testcase, we likely hit this crash

[PATCH] D91625: [clang] Do not crash on pointer wchar_t pointer assignment.

adamcz created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. adamcz requested review of this revision. wchar_t can be signed (thus hasSignedIntegerRepresentation() returns true), but it doesn't have an unsigned type, which would lead to a crash when trying

[PATCH] D91625: [clang] Do not crash on pointer wchar_t pointer assignment.

adamcz updated this revision to Diff 305752. adamcz added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91625/new/ https://reviews.llvm.org/D91625 Files: clang/lib/Sema/SemaExpr.cpp clang/test/SemaCXX/wchar_t.cpp Index:

[PATCH] D91610: [clangd] Add OverridenBy Relation to index.

hokein added a comment. Thanks! I think we need to bump the index version number (in `index/Serialization.cpp`) in order to let the index pick up this change. Comment at: clang-tools-extra/clangd/index/Relation.h:29 /// For an example "A is a base class of B" may be

[PATCH] D90984: Update matchers to be traverse-aware

steveire updated this revision to Diff 305768. steveire added a comment. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90984/new/ https://reviews.llvm.org/D90984 Files: clang/include/clang/ASTMatchers/ASTMatchers.h

[PATCH] D91262: [AArch64][SVE] Allow C-style casts between fixed-size and scalable vectors

joechrisellis added inline comments. Comment at: clang/lib/Sema/SemaCast.cpp:2217-2218 - // Allow reinterpret_casts between vectors of the same size and - // between vectors and integers of the same size. bool destIsVector = DestType->isVectorType();

[PATCH] D91602: [clang-tidy] Make clang-format and include-order-check coherent

njames93 added a comment. Thanks for fixing this, been bugging me for a while. Comment at: clang-tools-extra/test/clang-tidy/checkers/llvm-include-order.cpp:1 // RUN: %check_clang_tidy %s llvm-include-order %t -- -- -isystem %S/Inputs/Headers Would it be

[PATCH] D91610: [clangd] Add OverridenBy Relation to index.

usaxena95 updated this revision to Diff 305727. usaxena95 added a comment. added more tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91610/new/ https://reviews.llvm.org/D91610 Files: clang-tools-extra/clangd/index/Relation.cpp

[PATCH] D90441: [X86] Add support for vex, vex2, vex3, and evex for MASM

pengfei added inline comments. Comment at: clang/lib/AST/Stmt.cpp:795 + SmallVector Pieces; + AsmStr.split(Pieces, "\n\t"); + std::string MSAsmString; Can we always assume the separator is `\n\t`? Comment at:

[PATCH] D91442: [clang][Driver] Handle risvc in Baremetal.cpp.

jrtc27 added a comment. In D91442#2399753 , @jrtc27 wrote: > In D91442#2399750 , @abidh wrote: > >> In D91442#2399402 , @lenary wrote: >> >>> In D91442#2399341

[PATCH] D91628: [SystemZ][NFC] Group SystemZ tests in SystemZ folder

abhina.sreeskantharajan created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. abhina.sreeskantharajan requested review of this revision. This patch creates a SystemZ folder in clang/test/CodeGen to contain systemz-related lit tests. Repository: rG LLVM

[PATCH] D91610: [clangd] Add OverriddenBy Relation to index.

usaxena95 updated this revision to Diff 305787. usaxena95 marked an inline comment as done. usaxena95 added a comment. Add documentation for change in index test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91610/new/

[PATCH] D91630: [Parse] Add parsing support for C++ attributes on using-declarations

aaron.ballman added a comment. Can you mention this change in the release notes? Also, should we document it explicitly in the Language Extensions documentation, or do you think this is too tiny of a feature to warrant that? Comment at:

[PATCH] D91639: Add documentation illustrating use of IgnoreUnlessSpelledInSource

steveire created this revision. steveire added a reviewer: aaron.ballman. Herald added a project: clang. Herald added a subscriber: cfe-commits. steveire requested review of this revision. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D91639 Files:

[PATCH] D72184: [BPF] support atomic instructions

ast added inline comments. Comment at: llvm/lib/Target/BPF/BPFInstrInfo.td:684 + let Inst{47-32} = addr{15-0}; // offset + let Inst{11-8} = val; + let Inst{7-4} = Opc.Value; jackmanb wrote: > yonghong-song wrote: > > jackmanb wrote: > > > jackmanb wrote: > >

[PATCH] D90984: Update matchers to be traverse-aware

steveire updated this revision to Diff 305777. steveire added a comment. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90984/new/ https://reviews.llvm.org/D90984 Files: clang/include/clang/ASTMatchers/ASTMatchers.h

[PATCH] D90984: Update matchers to be traverse-aware

steveire added inline comments. Comment at: clang/include/clang/ASTMatchers/ASTMatchers.h:4083 +return false; + return InnerMatcher.matches(*Arg->IgnoreParenImpCasts(), Finder, Builder); } aaron.ballman wrote: > This probably shouldn't compile given that

[PATCH] D91631: [Matrix] Adjust matrix pointer type for inline asm arguments.

fhahn created this revision. Herald added subscribers: cfe-commits, tschuett. Herald added a project: clang. fhahn requested review of this revision. Matrix types in memory are represented as arrays, but accessed through vector pointers, with the alignment specified on the access operation. For

[PATCH] D91627: [OPENMP] Fix PR47999: correctly map implicit firstprivates in outer tasks.

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91627/new/ https://reviews.llvm.org/D91627

[PATCH] D91543: [clang-tidy] Improving bugprone-sizeof-expr check.

balazske added a comment. This checker has multiple weaknesses. There are more cases when the warnings should not appear (probably if the argument of `sizeof` is a template parameter), or more than one warning is generated for a code construct. The test code could be further improved too (but

[PATCH] D91543: [clang-tidy] Improving bugprone-sizeof-expr check.

aaron.ballman added a comment. In D91543#2400051 , @balazske wrote: > This checker has multiple weaknesses. There are more cases when the warnings > should not appear (probably if the argument of `sizeof` is a template > parameter), or more than one

[PATCH] D91442: [clang][Driver] Handle risvc in Baremetal.cpp.

abidh added a comment. In D91442#2399753 , @jrtc27 wrote: > In D91442#2399750 , @abidh wrote: > >> In D91442#2399402 , @lenary wrote: >> >>> In D91442#2399341

[PATCH] D91442: [clang][Driver] Handle risvc in Baremetal.cpp.

abidh added a comment. In D91442#2399772 , @lenary wrote: > I recall that there is also https://reviews.llvm.org/D68407 which iirc hoped > to address using `RISCVToolchain` with Compiler-rt and libunwind - presumably > it is not a complete solution, but

[PATCH] D91642: [AArch64][SVE] Add tests for VLST -> VLAT lax conversions

joechrisellis created this revision. joechrisellis added a reviewer: fpetrogalli. Herald added subscribers: cfe-commits, psnobl, kristof.beyls, tschuett. Herald added a reviewer: efriedma. Herald added a project: clang. joechrisellis requested review of this revision. These were previously

[PATCH] D90984: Update matchers to be traverse-aware

aaron.ballman added inline comments. Comment at: clang/include/clang/ASTMatchers/ASTMatchers.h:4083 +return false; + return InnerMatcher.matches(*Arg->IgnoreParenImpCasts(), Finder, Builder); } This probably shouldn't compile given that there's no

[PATCH] D91067: [AArch64][SVE] Support implicit lax vector conversions for SVE types

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG23a96b84a8d9: [AArch64][SVE] Support implicit lax vector conversions for SVE types (authored by joechrisellis). Repository: rG LLVM Github

[clang] 23a96b8 - [AArch64][SVE] Support implicit lax vector conversions for SVE types

Author: Joe Ellis Date: 2020-11-17T14:50:17Z New Revision: 23a96b84a8d985b686a4e06dec1f7aebc0cca6c6 URL: https://github.com/llvm/llvm-project/commit/23a96b84a8d985b686a4e06dec1f7aebc0cca6c6 DIFF: https://github.com/llvm/llvm-project/commit/23a96b84a8d985b686a4e06dec1f7aebc0cca6c6.diff LOG:

[PATCH] D91610: [clangd] Add OverridenBy Relation to index.

usaxena95 updated this revision to Diff 305776. usaxena95 marked an inline comment as done. usaxena95 added a comment. Addressed comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91610/new/ https://reviews.llvm.org/D91610 Files:

[PATCH] D91610: [clangd] Add OverriddenBy Relation to index.

usaxena95 updated this revision to Diff 305783. usaxena95 marked 2 inline comments as done. usaxena95 added a comment. s/OverridenBy/OverriddenBy Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91610/new/ https://reviews.llvm.org/D91610 Files:

[PATCH] D91610: [clangd] Add OverriddenBy Relation to index.

usaxena95 added inline comments. Comment at: clang-tools-extra/clangd/index/Relation.h:24 BaseOf, + OverridenBy, }; Quuxplusone wrote: > s/Overriden/Overridden/g Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

Re: [PATCH] D72184: [BPF] support atomic instructions

On 11/17/20 3:23 AM, Brendan Jackman via Phabricator wrote: jackmanb added inline comments. Comment at: llvm/lib/Target/BPF/BPFInstrInfo.td:684 + let Inst{47-32} = addr{15-0}; // offset + let Inst{11-8} = val; + let Inst{7-4} = Opc.Value; yonghong-song

[PATCH] D91610: [clangd] Add OverriddenBy Relation to index.

usaxena95 updated this revision to Diff 305802. usaxena95 added a comment. Typo fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91610/new/ https://reviews.llvm.org/D91610 Files: clang-tools-extra/clangd/index/Relation.cpp

[PATCH] D91410: [llvm][clang][mlir] Add checks for the return values from Target::createXXX to prevent protential null deref

tejohnson added a comment. I was reviewing the llvm/lib/* changes and note that the new checking is a mix of assert (debug or assert enabled compiler only) and fatal errors (both debug and release compilers). Is that intended? If these are not likely due to user input issues, then perhaps they

  1   2   3   >