[PATCH] D92434: [NFC][AMDGPU] AMDGPU code object V4 ABI documentation

kzhuravl accepted this revision. kzhuravl added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92434/new/ https://reviews.llvm.org/D92434

[PATCH] D91659: Allow enum typedefs to be referenced with the 'enum' specifier under MSVC compat mode

shivanshu3 updated this revision to Diff 308803. shivanshu3 retitled this revision from "Allow anonymous enum typedefs to be referenced with the 'enum' specifier under MSVC compat mode" to "Allow enum typedefs to be referenced with the 'enum' specifier under MSVC compat mode". shivanshu3 edited

[PATCH] D92386: [VE] Add standard include path and library path for C++

kaz7 planned changes to this revision. kaz7 added inline comments. Comment at: clang/lib/Driver/ToolChains/VEToolchain.cpp:109 +return; + if (const char *cl_include_dir = getenv("NCC_CPLUS_INCLUDE_PATH")) { +SmallVector Dirs; simoll wrote: > Do we want

[PATCH] D72184: [BPF] support atomic instructions

ast added inline comments. Comment at: llvm/lib/Target/BPF/BPFMIChecking.cpp:199 + unsigned newOpcode; + switch(MI.getOpcode()) { + case BPF::XFADDW32: newOpcode = BPF::XADDW32; break; yonghong-song wrote: > yonghong-song wrote: > > ast wrote: > >

[PATCH] D87216: [NewPM] Support --print-before/after in NPM

aeubanks updated this revision to Diff 308797. aeubanks added a comment. address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87216/new/ https://reviews.llvm.org/D87216 Files: llvm/include/llvm/IR/PassInstrumentation.h

[PATCH] D91297: Frontend: Take VFS and MainFileBuffer by reference in PrecompiledPreamble::CanReuse, NFC

dexonsmith added inline comments. Comment at: clang/include/clang/Frontend/PrecompiledPreamble.h:108 bool CanReuse(const CompilerInvocation , -const llvm::MemoryBuffer *MainFileBuffer, PreambleBounds Bounds, -llvm::vfs::FileSystem *VFS) const;

[PATCH] D91980: [OpenMP] Add initial support for `omp [begin/end] assumes`

jdoerfert updated this revision to Diff 308817. jdoerfert marked an inline comment as done. jdoerfert added a comment. Addressed comments, lambda handling and more Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91980/new/

[PATCH] D91980: [OpenMP] Add initial support for `omp [begin/end] assumes`

jdoerfert marked 6 inline comments as done. jdoerfert added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:3210 + +SmallVector DeclContexts; +DeclContexts.push_back(CurContext); ABataev wrote: > jdoerfert wrote: > > ABataev wrote: > > >

[PATCH] D72184: [BPF] support atomic instructions

ast added inline comments. Comment at: llvm/lib/Target/BPF/BPFMIChecking.cpp:199 + unsigned newOpcode; + switch(MI.getOpcode()) { + case BPF::XFADDW32: newOpcode = BPF::XADDW32; break; With this logic in place Andrii has a point. There is no need

[PATCH] D92444: [CMake][Fuchsia] Install llvm-elfabi

mcgrathr created this revision. mcgrathr added reviewers: leonardchan, haowei. Herald added subscribers: cfe-commits, mgorny. Herald added a project: clang. mcgrathr requested review of this revision. The canonical Fuchsia toolchain configuration installs llvm-elfabi. Repository: rG LLVM

[PATCH] D92445: [PowerPC] Add powerpcle target.

Bdragon28 created this revision. Bdragon28 added reviewers: MaskRay, PowerPC, jhibbits. Bdragon28 added a project: PowerPC. Herald added subscribers: llvm-commits, cfe-commits, dexonsmith, steven.zhang, shchenz, rupprecht, kbarton, hiraditya, krytarowski, arichardson, nemanjai, emaste. Herald

[clang] a417cb0 - [NFC] Add CLangOffloadBundler documentation to Clang index

Author: Tony Date: 2020-12-02T02:47:44Z New Revision: a417cb086209c2a01c2460d3e1ea64453f53c68e URL: https://github.com/llvm/llvm-project/commit/a417cb086209c2a01c2460d3e1ea64453f53c68e DIFF: https://github.com/llvm/llvm-project/commit/a417cb086209c2a01c2460d3e1ea64453f53c68e.diff LOG: [NFC]

[PATCH] D92441: Add CLangOffloadBundler documentation to Clang index

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa417cb086209: [NFC] Add CLangOffloadBundler documentation to Clang index (authored by t-tye). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D92445: [PowerPC] Add powerpcle target.

Bdragon28 added a comment. On FreeBSD, the main use of this will be on the new powerpc64le arch, where we need to build a 32-bit LE bootloader for use with pseries. (it is easier to retarget LLVM than make a cross-endian bootloader, as it would involve rewriting filesystem code etc.) On

[PATCH] D72184: [BPF] support atomic instructions

yonghong-song added inline comments. Comment at: llvm/lib/Target/BPF/BPFMIChecking.cpp:199 + unsigned newOpcode; + switch(MI.getOpcode()) { + case BPF::XFADDW32: newOpcode = BPF::XADDW32; break; ast wrote: > With this logic in place Andrii has a

[PATCH] D88393: [cfe][M68k] (Patch 7/8) Basic Clang support

myhsu added inline comments. Comment at: clang/lib/Basic/Targets.cpp:314 +default: + return new M68kTargetInfo(Triple, Opts); +} rengolin wrote: > No support for bare-metal? currently we don't have any plan for that Comment at:

[PATCH] D87216: [NewPM] Support --print-before/after in NPM

aeubanks added inline comments. Comment at: llvm/lib/Passes/PassBuilder.cpp:449 + // We currently only use these for --print-before/after. + if (PIC && (!printBeforePasses().empty() || !printAfterPasses().empty())) { +#define MODULE_PASS(NAME, CREATE_PASS)

[PATCH] D91659: Allow enum typedefs to be referenced with the 'enum' specifier under MSVC compat mode

shivanshu3 added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:15752-15754 + bool AnonymousEnumEligible = getLangOpts().MSVCCompat && + (Kind == TTK_Enum) && +

[PATCH] D92436: [Time-report] Add a flag -ftime-report={per-pass,per-pass-run} to control the pass timing aggregation

ychen created this revision. ychen added reviewers: efriedma, philip.pfaffe, chandlerc. Herald added subscribers: llvm-commits, cfe-commits, dexonsmith, dang, hiraditya, mgorny. Herald added projects: clang, LLVM. ychen requested review of this revision. Currently, -ftime-report + new pass

[clang] 1f40d60 - Remove CXXBasePaths::found_decls and simplify and modernize its only

Author: Richard Smith Date: 2020-12-01T16:35:03-08:00 New Revision: 1f40d60a3b7f310ff3f77bb8643a27d979a703cb URL: https://github.com/llvm/llvm-project/commit/1f40d60a3b7f310ff3f77bb8643a27d979a703cb DIFF: https://github.com/llvm/llvm-project/commit/1f40d60a3b7f310ff3f77bb8643a27d979a703cb.diff

[PATCH] D92439: Fix missing error for use of 128-bit integer inside SPIR64 device code.

jyu2 created this revision. jyu2 added reviewers: erichkeane, aaron.ballman, Fznamznon, rjmccall, jdoerfert, rsmith. jyu2 added a project: clang. Herald added a subscriber: Anastasia. jyu2 requested review of this revision. Emit error for use of 128-bit integer inside device code had been

[clang-tools-extra] e181a6a - s/instantate/instantiate/ throughout. NFCI.

Author: Arthur O'Dwyer Date: 2020-12-01T22:13:40-05:00 New Revision: e181a6aeddc26ef0512b2dba94db6360ba32f2ff URL: https://github.com/llvm/llvm-project/commit/e181a6aeddc26ef0512b2dba94db6360ba32f2ff DIFF:

[clang] e181a6a - s/instantate/instantiate/ throughout. NFCI.

Author: Arthur O'Dwyer Date: 2020-12-01T22:13:40-05:00 New Revision: e181a6aeddc26ef0512b2dba94db6360ba32f2ff URL: https://github.com/llvm/llvm-project/commit/e181a6aeddc26ef0512b2dba94db6360ba32f2ff DIFF:

[PATCH] D92445: [PowerPC] Add powerpcle target.

Bdragon28 added a comment. In D92445#2427537 , @Bdragon28 wrote: > In D92445#2427438 , @nemanjai wrote: > >> This seems problematic to me for a few reasons: >> >> 1. There is no 32-bit toolchains or libraries for

[PATCH] D92445: [PowerPC] Add powerpcle target.

Bdragon28 added a comment. Regarding things like Altivec and VSX: Altivec should be just fine to run in 32-bit LE. I am undecided as to whether VSX should be banned or not. However that goes, it should be identical in powerpc64 -m32 and powerpc64le -m32. Regarding codegen: CPU capabilities are

[PATCH] D88393: [cfe][M68k] (Patch 7/8) Basic Clang support

myhsu updated this revision to Diff 308866. myhsu marked 3 inline comments as done. myhsu added a comment. - Addressed all the feedbacks - Fixed minor issues that would retrieve the wrong TargetCodeGenInfo instance CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88393/new/

[PATCH] D92361: [trivial-abi] Support types without a copy or move constructor.

ahatanak added a comment. In the following example, should `S1` be passed directly or indirectly? The current patch passes it indirectly. struct __attribute__((trivial_abi)) S0 { S0(); S0(const S0 &) = delete; S0(S0 &&) = delete; int a; }; struct S1 { S0 s0; };

[PATCH] D91756: [CSSPGO] Pseudo probes for function calls.

wmi added inline comments. Comment at: llvm/lib/CodeGen/PseudoProbeInserter.cpp:50 +for (MachineBasicBlock : MF) { + MachineInstr *FirstInstr = nullptr; + for (MachineInstr : MBB) { What is the usage of FirstInstr? Comment at:

[PATCH] D91129: Print source location in the error message when parens are missing around sizeof typename and the expression is inside macro expansion

shivanshu3 updated this revision to Diff 308827. shivanshu3 added a comment. Clang format the test file. Forgot to do it before. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91129/new/ https://reviews.llvm.org/D91129 Files:

[PATCH] D92445: [PowerPC] Add powerpcle target.

Bdragon28 added a comment. In D92445#2427438 , @nemanjai wrote: > This seems problematic to me for a few reasons: > > 1. There is no 32-bit toolchains or libraries for little endian Linux systems > 2. There is no support in the ELFv2 ABI for 32-bit object

[PATCH] D92361: [trivial-abi] Support types without a copy or move constructor.

zoecarver added a comment. > If it is not possible to copy or move the type at all, it is not possible to > copy or move it trivially. This was a bit confusing to me because I think this changed between C++14 and 17. In C++14, a class was trivially copyable if it had no non-trivial copy/move

[PATCH] D91756: [CSSPGO] Pseudo probes for function calls.

hoy updated this revision to Diff 308874. hoy added a comment. Updating D91756 : [CSSPGO] Pseudo probes for function calls. Adding messages for asserts. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91756/new/

[PATCH] D91673: [PGO] Enable preinline and cleanup when optimize for size

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. Thanks, my concerns are addressed, and I believe @xur's are as well. Please wait for his input before landing, though. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 1e91803 - Recommit "[clang][Fuchsia] Add relative-vtables multilib"

Author: Leonard Chan Date: 2020-12-01T17:03:13-08:00 New Revision: 1e91803c671a105f1eabce0e496766b512242f1d URL: https://github.com/llvm/llvm-project/commit/1e91803c671a105f1eabce0e496766b512242f1d DIFF: https://github.com/llvm/llvm-project/commit/1e91803c671a105f1eabce0e496766b512242f1d.diff

[PATCH] D90534: [clang-format] Add new option PenaltyIndentedWhitespace

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1e4d6d1c1ff3: [clang-format] Add new option PenaltyIndentedWhitespace (authored by mnauw). Repository: rG LLVM Github Monorepo CHANGES SINCE

[clang] 1e4d6d1 - [clang-format] Add new option PenaltyIndentedWhitespace

Author: Mark Nauwelaerts Date: 2020-12-01T23:59:44+01:00 New Revision: 1e4d6d1c1ff3f5a4d6e7dda053386ff411fd7de4 URL: https://github.com/llvm/llvm-project/commit/1e4d6d1c1ff3f5a4d6e7dda053386ff411fd7de4 DIFF:

[PATCH] D92441: Add CLangOffloadBundler documentation to Clang index

t-tye created this revision. t-tye added reviewers: kzhuravl, scott.linder, b-sumner, tpr, rampitec, yaxunl, kerbowa. Herald added subscribers: cfe-commits, arphaman. Herald added a project: clang. t-tye requested review of this revision. Change-Id: I1a35bea10861cb5219e0dd13e14a86df56b38825

[PATCH] D83892: [clang][cli] Port CodeGen option flags to new option parsing system

dexonsmith added a comment. I think `DefaultsTo{True,False}` and `InvertedBy{Negative,Positive}Flag` makes the axes clear, it's way better; thanks for thinking this through. Thinking out loud: I'm still a bit resistant to making this keypath-centric. The reason is that `llvm::Option` is a

[PATCH] D91756: [CSSPGO] Pseudo probes for function calls.

hoy updated this revision to Diff 308806. hoy added a comment. Updating D91756 : [CSSPGO] Pseudo probes for function calls. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91756/new/ https://reviews.llvm.org/D91756

[PATCH] D91756: [CSSPGO] Pseudo probes for function calls.

hoy added inline comments. Comment at: llvm/lib/CodeGen/PseudoProbeInserter.cpp:50 +for (MachineBasicBlock : MF) { + MachineInstr *FirstInstr = nullptr; + for (MachineInstr : MBB) { wmi wrote: > What is the usage of FirstInstr? Good patch. It's

[PATCH] D91673: [PGO] Enable preinline and cleanup when optimize for size

zequanwu updated this revision to Diff 308810. zequanwu added a comment. - sync NPM with LPM. - use PreInlineThreshold flag value instead of hardcode number. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91673/new/ https://reviews.llvm.org/D91673

[PATCH] D92361: [trivial-abi] Support types without a copy or move constructor.

rjmccall added a comment. That's an excellent example to study. The fundamental question we are looking to answer is whether a type representationally depends on its address. Absent the `trivial_abi` attribute, the criterion for knowing that it does not is whether it is possible to copy or

[PATCH] D92445: [PowerPC] Add powerpcle target.

nemanjai added a comment. This seems problematic to me for a few reasons: 1. There is no 32-bit toolchains or libraries for little endian Linux systems 2. There is no support in the ELFv2 ABI for 32-bit object mode and there may be a number of places we assume that little endian systems use

[PATCH] D92444: [CMake][Fuchsia] Install llvm-elfabi

haowei accepted this revision. haowei added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92444/new/ https://reviews.llvm.org/D92444 ___

[PATCH] D91756: [CSSPGO] Pseudo probes for function calls.

wmi added inline comments. Comment at: llvm/include/llvm/IR/PseudoProbe.h:33-34 + static uint32_t packProbeData(uint32_t Index, uint32_t Type) { +assert(Index <= 0x); +assert(Type <= 0x7); +return (Index << 3) | (Type << 26) | 0x7; Add assertion

[PATCH] D72184: [BPF] support atomic instructions

yonghong-song added inline comments. Comment at: llvm/lib/Target/BPF/BPFMIChecking.cpp:199 + unsigned newOpcode; + switch(MI.getOpcode()) { + case BPF::XFADDW32: newOpcode = BPF::XADDW32; break; yonghong-song wrote: > ast wrote: > > With this

[PATCH] D92441: Add CLangOffloadBundler documentation to Clang index

kzhuravl accepted this revision. kzhuravl added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92441/new/ https://reviews.llvm.org/D92441

[PATCH] D92445: [PowerPC] Add powerpcle target.

MaskRay added a comment. This patch should be split. I suggest that you create 4 patches. - llvm: triple change - llvm: llvm/Object/ELFObjectFile.h llvm-readobj llvm-objdump - clang - lld Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92445/new/

[PATCH] D92445: [PowerPC] Add powerpcle target.

Bdragon28 added a comment. In D92445#2427439 , @MaskRay wrote: > This patch should be split. I suggest that you create 4 patches. > > - llvm: triple change > - llvm: llvm/Object/ELFObjectFile.h llvm-readobj llvm-objdump > - clang > - lld Can do.

[PATCH] D81958: [clangd] Add library to semantically strip flags by name.

ychen added inline comments. Comment at: clang-tools-extra/clangd/CompileCommands.cpp:356 + HELP, METAVAR, VALUES) \ + if (DriverID::OPT_##ALIAS != DriverID::OPT_INVALID && ALIASARGS == nullptr) \ +

[PATCH] D88220: [C++20] P1825R0: More implicit moves

Quuxplusone added a subscriber: david_stone. Quuxplusone added inline comments. Comment at: clang/test/CXX/class/class.init/class.copy.elision/p3.cpp:22 + return c; +} +#else @rsmith @david_stone (or anyone), what is the status in C++20 of the following test

[PATCH] D92176: Don't use sysroot/include when sysroot is empty.

cjdb added a comment. In D92176#2419011 , @manojgupta wrote: > lgtm but not an expert in this area. Ditto Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92176/new/ https://reviews.llvm.org/D92176

[clang] 79ba796 - [clang-scan-deps] Improve argument parsing to find target object file path.

Author: Sylvain Audi Date: 2020-12-01T15:04:15-05:00 New Revision: 79ba7967f4813445c3ce5624170c19584bbfda72 URL: https://github.com/llvm/llvm-project/commit/79ba7967f4813445c3ce5624170c19584bbfda72 DIFF: https://github.com/llvm/llvm-project/commit/79ba7967f4813445c3ce5624170c19584bbfda72.diff

[PATCH] D92418: [hip] Fix host object creation from fatbin

hliao created this revision. hliao added reviewers: yaxunl, ashi1. Herald added a project: clang. Herald added a subscriber: cfe-commits. hliao requested review of this revision. - `__hip_fatbin` should a symbol in `.hip_fatbin` section. Repository: rG LLVM Github Monorepo

[PATCH] D92363: [HIP] Warn no --offload-arch option

tra added a comment. While I agree that the default GPU choice is not likely to be correct, or usable, for everyone, but the warning seems to be a half-measure. If the default is not usable, then it should not be the default. If it's usable, then we don't need a warning. Having a warning would

[PATCH] D92403: [LSan][RISCV] Enable LSan for RISCV64

luismarques updated this revision to Diff 308737. luismarques added a comment. Fix formatting. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92403/new/ https://reviews.llvm.org/D92403 Files: clang/lib/Driver/ToolChains/Linux.cpp

[PATCH] D92418: [hip] Fix host object creation from fatbin

ashi1 added a comment. Looks good to me, were you able to run staging on this patch? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92418/new/ https://reviews.llvm.org/D92418 ___ cfe-commits mailing list

[PATCH] D91088: [CUDA][HIP] Fix capturing reference to host variable

tra accepted this revision. tra added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Sema/SemaExpr.cpp:1957 +// host variable in a device or host device lambda. +static bool isCapturingReferenceToHostVarInCUDADeviceLambda(Sema , +

[clang] f9eaa46 - Fix erroneous edit in https://github.com/llvm/llvm-project/actions/runs/394499364

Author: Zahira Ammarguellat Date: 2020-12-01T12:34:18-08:00 New Revision: f9eaa4650f5d5948af7050efef9d4098ff7f0ae8 URL: https://github.com/llvm/llvm-project/commit/f9eaa4650f5d5948af7050efef9d4098ff7f0ae8 DIFF:

[PATCH] D92072: [CMake][NewPM] Move ENABLE_EXPERIMENTAL_NEW_PASS_MANAGER into llvm/

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa36bd4c90dcc: [CMake][NewPM] Move ENABLE_EXPERIMENTAL_NEW_PASS_MANAGER into llvm/ (authored by aeubanks). Repository: rG LLVM Github Monorepo

[clang] a36bd4c - [CMake][NewPM] Move ENABLE_EXPERIMENTAL_NEW_PASS_MANAGER into llvm/

Author: Arthur Eubanks Date: 2020-12-01T11:42:17-08:00 New Revision: a36bd4c90dcca82be9b64f65dbd22e921b6485ef URL: https://github.com/llvm/llvm-project/commit/a36bd4c90dcca82be9b64f65dbd22e921b6485ef DIFF:

[PATCH] D92330: [clang-scan-deps] Improve argument parsing to find target object file path.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG79ba7967f481: [clang-scan-deps] Improve argument parsing to find target object file path. (authored by saudi). Repository: rG LLVM Github

[PATCH] D92418: [hip] Fix host object creation from fatbin

hliao added a comment. Even there's no functionality change, the original one breaks the kernel extraction script, which is designed to find the `.hip_fatbin` section. That internal tool is still required to extract kernels from objects generated from RDC linking. Repository: rG LLVM

[PATCH] D92189: [OpenMPIRBuilder] forward arguments as pointers to outlined function

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LGTM, one comment and two nits. Feel free to commit if you agree with the suggestions or come back with concerns. Thanks for working on this and taking the time to fix it like this!

[PATCH] D87216: [NewPM] Support --print-before/after in NPM

jamieschmeiser added a comment. I agree that having the callbacks ask for the names is an improvement as it is cleaner and allows other callbacks to use this feature if desired. Generally, things look good. I have a couple of minor concerns mentioned in the code but I think it would be

[PATCH] D63852: [Clang] Move assembler into a separate file

echristo accepted this revision. echristo added a comment. This revision is now accepted and ready to land. Thanks for the explanation, lgtm. -eric Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63852/new/ https://reviews.llvm.org/D63852

[PATCH] D92408: [clangd] ExtractFunction: disable on regions that sometimes, but not always return.

adamcz created this revision. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman. Herald added a project: clang. adamcz requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. apply() will fail in those cases, so it's better to detect it in prepare()

[PATCH] D92072: [CMake][NewPM] Move ENABLE_EXPERIMENTAL_NEW_PASS_MANAGER into llvm/

rnk added inline comments. Comment at: llvm/include/llvm/Config/llvm-config.h.cmake:95 +/* Define to 1 to enable the experimental new pass manager by default */ +#cmakedefine01 ENABLE_EXPERIMENTAL_NEW_PASS_MANAGER + aeubanks wrote: > rnk wrote: > > This should

[PATCH] D92409: [AST][NFC] Silence GCC warning about multiline comments

rsmith added a comment. Let's just disable this broken GCC warning. IIRC, the corresponding clang warning covers the actual bugs caused by line continuation in comments, and doesn't warn if the next line begins with a `//`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 4eaa024 - APINotes: constify `dump` methods (NFC)

Author: Saleem Abdulrasool Date: 2020-12-01T19:01:06Z New Revision: 4eaa024863f4a86151beb7971301c6ab10a9de01 URL: https://github.com/llvm/llvm-project/commit/4eaa024863f4a86151beb7971301c6ab10a9de01 DIFF: https://github.com/llvm/llvm-project/commit/4eaa024863f4a86151beb7971301c6ab10a9de01.diff

[PATCH] D92413: Argument dependent lookup with class argument is recursing into base classes that haven't been instantiated. This is generating an assertion in DeclTemplate.h. Fix for Bug25668.

cryptoad abandoned this revision. cryptoad added a comment. This is an arc fail on my side Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92413/new/ https://reviews.llvm.org/D92413 ___ cfe-commits

[PATCH] D92406: [OpenCL] Add some more kernel argument tests

svenvh created this revision. svenvh added a reviewer: Anastasia. Herald added a subscriber: yaxunl. Herald added a project: clang. svenvh requested review of this revision. These cases weren't in any of the SemaOpenCL tests yet. Repository: rG LLVM Github Monorepo

[PATCH] D91455: [XCOFF][AIX] Generate LSDA data and compact unwind section on AIX

hubert.reinterpretcast added inline comments. Comment at: llvm/test/CodeGen/PowerPC/aix-exception.ll:108-109 +; ASM: .byte 255 # @LPStart Encoding = omit +; ASM32: .byte 187 # @TType Encoding = +;

[PATCH] D92409: [AST][NFC] Silence GCC warning about multiline comments

thopre created this revision. thopre added reviewers: ABataev, rjmccall, rsmith. Herald added a project: clang. Herald added a subscriber: cfe-commits. thopre requested review of this revision. Herald added a reviewer: jdoerfert. Herald added a subscriber: sstefan1. GCC's -Wcomment warning is

[PATCH] D92409: [AST][NFC] Silence GCC warning about multiline comments

ABataev added a comment. I would just remove this extra symbol. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92409/new/ https://reviews.llvm.org/D92409 ___ cfe-commits mailing list

[PATCH] D91455: [XCOFF][AIX] Generate LSDA data and compact unwind section on AIX

hubert.reinterpretcast added inline comments. Comment at: llvm/lib/CodeGen/AsmPrinter/AIXException.cpp:35 + // unsigned long lsda; /* Pointer to LSDA */ + // unsigned long personality; /* Pointerto the personality routine */ + // } Typo:

[PATCH] D92406: [OpenCL] Add some more kernel argument tests

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks Comment at: clang/test/SemaOpenCL/invalid-kernel-parameters.cl:40 +void no_addrspace_param(global int x) { } // expected-error{{parameter may not be

[PATCH] D92409: [AST][NFC] Silence GCC warning about multiline comments

thopre added a comment. In D92409#2426160 , @ABataev wrote: > I would just remove this extra symbol. But then the example code is no longer copy/pastable. Note that I expect people to copy/paste but it's nice if it looks authentic. Note that I don't

[clang] 3734079 - Argument dependent lookup with class argument is recursing into base

Author: Zahira Ammarguellat Date: 2020-12-01T10:33:12-08:00 New Revision: 37340798ccb00b9c3a53e8a5f1b6430e85870338 URL: https://github.com/llvm/llvm-project/commit/37340798ccb00b9c3a53e8a5f1b6430e85870338 DIFF:

[PATCH] D92072: [CMake][NewPM] Move ENABLE_EXPERIMENTAL_NEW_PASS_MANAGER into llvm/

aeubanks updated this revision to Diff 308713. aeubanks added a comment. Herald added a subscriber: dang. rename to LLVM_ENABLE_NEW_PASS_MANAGER Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92072/new/ https://reviews.llvm.org/D92072 Files:

[PATCH] D92409: [AST][NFC] Silence GCC warning about multiline comments

thopre added a comment. In D92409#2426188 , @rsmith wrote: > Let's just disable this broken GCC warning. IIRC, the corresponding clang > warning covers the actual bugs caused by line continuation in comments, and > doesn't warn if the next line begins

[PATCH] D92413: Argument dependent lookup with class argument is recursing into base classes that haven't been instantiated. This is generating an assertion in DeclTemplate.h. Fix for Bug25668.

cryptoad created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. cryptoad requested review of this revision. Herald added a reviewer: jdoerfert. Herald added a subscriber: sstefan1. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D92413

[PATCH] D85808: [Remarks][2/2] Expand remarks hotness threshold option support in more tools

weiwang added a comment. Ah, I am sorry. Thanks for fixing it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85808/new/ https://reviews.llvm.org/D85808 ___ cfe-commits mailing list

[PATCH] D92041: [clangd] Add hover info for `this` expr

kadircet requested changes to this revision. kadircet added a comment. This revision now requires changes to proceed. In D92041#2424928 , @njames93 wrote: > One last point, is it worth including cv qualifications in the hover info? Yes, I think we should

[PATCH] D91455: [XCOFF][AIX] Generate LSDA data and compact unwind section on AIX

daltenty accepted this revision. daltenty added a comment. This revision is now accepted and ready to land. LGTM Comment at: llvm/lib/CodeGen/AsmPrinter/AIXException.cpp:68 +Per = dyn_cast(F.getPersonalityFn()->stripPointerCasts()); + bool EmitEHBlock = +

[PATCH] D92357: clang/darwin: Don't use response files with ld64

thakis added a comment. In D92357#2426042 , @keith wrote: > I'm a bit worried that without a repro case (outside of the missing newline) > Apple won't get around to fixing this, and in the meantime I'm wondering if > outside of the chromium build system

[PATCH] D92361: [trivial-abi] Support types without a copy or move constructor.

zoecarver updated this revision to Diff 308699. zoecarver added a comment. - Add comment in SemaDeclCXX. - Add tests for non-trivial bases/members. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92361/new/ https://reviews.llvm.org/D92361 Files:

[PATCH] D92072: [CMake][NewPM] Move ENABLE_EXPERIMENTAL_NEW_PASS_MANAGER into llvm/

rnk accepted this revision. rnk added a comment. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92072/new/ https://reviews.llvm.org/D92072 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D92381: [clangd] Extract per-dir CDB cache to its own threadsafe class. NFC

kadircet added inline comments. Comment at: clang-tools-extra/clangd/GlobalCompilationDatabase.cpp:91 + // Whether a new CDB has been loaded but not broadcast yet. + bool Dirty = false; + // Last loaded CDB, meaningful if CachePopulated is set. maybe rename

[PATCH] D92189: [OpenMPIRBuilder] forward arguments as pointers to outlined function

jdoerfert added a comment. While only partially related, can you leave a FIXME saying that more than 15 arguments need to be packed in a structure? Comment at: clang/test/OpenMP/parallel_codegen.cpp:139 // CHECK: call {{.*}}void (%struct.ident_t*, i32, void (i32*,

[PATCH] D90733: Frontend: Sink named pipe logic from CompilerInstance down to FileManager

jansvoboda11 accepted this revision. jansvoboda11 added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90733/new/ https://reviews.llvm.org/D90733 ___ cfe-commits mailing list

[PATCH] D91297: Frontend: Take VFS and MainFileBuffer by reference in PrecompiledPreamble::CanReuse, NFC

jansvoboda11 accepted this revision. jansvoboda11 added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/include/clang/Frontend/PrecompiledPreamble.h:108 bool CanReuse(const CompilerInvocation , -const llvm::MemoryBuffer

[PATCH] D92189: [OpenMPIRBuilder] forward arguments as pointers to outlined function

ftynse planned changes to this revision. ftynse added inline comments. Comment at: llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp:736 "Expected copy/create callback to set replacement value!"); - if (ReplacementValue == ) -return; }

[PATCH] D92357: clang/darwin: Don't use response files with ld64, do use them with ld64.lld.darwinnew

thakis updated this revision to Diff 308684. thakis edited the summary of this revision. thakis added a comment. rebase CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92357/new/ https://reviews.llvm.org/D92357 Files: clang/lib/Driver/ToolChains/Darwin.cpp Index:

[clang-tools-extra] ae7ec47 - [NFC][clang-tidy] Port rename_check.py to Python3

Author: Roman Lebedev Date: 2020-12-01T20:10:19+03:00 New Revision: ae7ec47fc655537ce82c0bfee0b587921663eaff URL: https://github.com/llvm/llvm-project/commit/ae7ec47fc655537ce82c0bfee0b587921663eaff DIFF: https://github.com/llvm/llvm-project/commit/ae7ec47fc655537ce82c0bfee0b587921663eaff.diff

[PATCH] D92189: [OpenMPIRBuilder] forward arguments as pointers to outlined function

llitchev added a comment. In D92189#2425639 , @jdoerfert wrote: > While only partially related, can you leave a FIXME saying that more than 15 > arguments need to be packed in a structure? Yes, the number of varargs that is guarantee to work is 15, if

[PATCH] D83892: [clang][cli] Port CodeGen option flags to new option parsing system

jansvoboda11 added a comment. @Bigcheese brought up that if you wanted to mimic the current logic in `OptInFFlag` that automatically creates the `-cc1` option with my current proposal, you'd need to remember to pass it to the right `Flags` (e.g.: use `NegativeFlag<[CC1Option]>` when using

[PATCH] D92361: [trivial-abi] Support types without a copy or move constructor.

zoecarver added inline comments. Comment at: clang/lib/Sema/SemaDeclCXX.cpp:6416 + if (D->hasAttr()) +return true; + rjmccall wrote: > I don't think we can just unconditionally check for the attribute. The rule > for `trivial_abi` is that it overrides

[clang] b99e2b8 - clang/darwin: Use response files with ld64.lld.darwinnew

Author: Nico Weber Date: 2020-12-01T12:07:56-05:00 New Revision: b99e2b8b14f4ba50f9eb80bd5a2c1824099a7f96 URL: https://github.com/llvm/llvm-project/commit/b99e2b8b14f4ba50f9eb80bd5a2c1824099a7f96 DIFF: https://github.com/llvm/llvm-project/commit/b99e2b8b14f4ba50f9eb80bd5a2c1824099a7f96.diff

[PATCH] D92399: clang/darwin: Use response files with ld64.lld.darwinnew

This revision was automatically updated to reflect the committed changes. Closed by commit rGb99e2b8b14f4: clang/darwin: Use response files with ld64.lld.darwinnew (authored by thakis). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

  1   2   >