[PATCH] D92596: [FPEnv] Correct constrained metadata in fp16-ops-strict.c

mibintc added inline comments. Comment at: clang/lib/CodeGen/CGExprScalar.cpp:2992 // floating point environment in the loop. +//XXX true? llvm::BasicBlock *startBB = Builder.GetInsertBlock(); did you mean to leave this here? (blame shows the fixme

[PATCH] D92257: [clang-format] Add option to control the space at the front of a line comment

MyDeveloperDay added a comment. In D92257#2435899 , @HazardyKnusperkeks wrote: > In D92257#2435701 , @MyDeveloperDay > wrote: > >> Can I assume you need someone to land this for you? > > Yes I do. But I have a

[PATCH] D92257: [clang-format] Add option to control the space at the front of a line comment

HazardyKnusperkeks added a comment. In D92257#2435902 , @MyDeveloperDay wrote: > In D92257#2435899 , > @HazardyKnusperkeks wrote: > >> In D92257#2435701 , @MyDeveloperDay

[PATCH] D92728: [NFC][MSan] Round up OffsetPtr in PoisonMembersgetFieldOffset(layoutStartOffset) for current calleds is expected topoint to the first trivial field or the one which follows non-trivial

vitalybuka created this revision. vitalybuka added reviewers: morehouse, eugenis. vitalybuka requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. ...withoutassumptions about callers. This patch will avoid the need in suchassumptions. Depends

[PATCH] D92257: [clang-format] Add option to control the space at the front of a line comment

lebedev.ri added a comment. In D92257#2435902 , @MyDeveloperDay wrote: > In D92257#2435899 , > @HazardyKnusperkeks wrote: > >> In D92257#2435701 , @MyDeveloperDay >>

[PATCH] D92257: [clang-format] Add option to control the space at the front of a line comment

HazardyKnusperkeks added a comment. In D92257#2435701 , @MyDeveloperDay wrote: > Can I assume you need someone to land this for you? Yes I do. But I have a question, my last change is commited in your name, that means git blame would blame it on you,

[PATCH] D88220: [C++20] P1825R0: More implicit moves

Quuxplusone added a comment. I've found another case that Clang has never handled correctly (and which your patch does not fix)— https://godbolt.org/z/xd8qGW struct Widget {}; struct Frodo { Frodo(Widget&); Frodo(Widget&&) = delete; }; Frodo twelve() { Widget w;

[PATCH] D92733: Fix PR25627 - false positive diagnostics involving implicit-captures in dependent lambda expressions.

faisalv created this revision. faisalv added reviewers: rsmith, aaron.ballman, wchilders, BRevzin. faisalv added a project: clang. faisalv requested review of this revision. This patch attempts to address the following bugs involving lambda-captures: 1.

[PATCH] D90271: [clang][ToolChains] explicitly return LangOptions::StackProtectorMode

SolarAquarion added a comment. You missed a change https://bugs.llvm.org/show_bug.cgi?id=48413 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90271/new/ https://reviews.llvm.org/D90271 ___ cfe-commits

[PATCH] D87974: [Builtin] Add __builtin_zero_non_value_bits.

BillyONeal added a comment. In D87974#2432793 , @zoecarver wrote: > So, it looks like GCC already uses `__builtin_clear_padding` and MSVC already > uses `__builtin_zero_non_value_bits`. This patch (obviously) is currently > implementing

[PATCH] D92257: [clang-format] Add option to control the space at the front of a line comment

krasimir added inline comments. Comment at: clang/docs/ClangFormatStyleOptions.rst:2727 + + * ``unsigned Maximum`` The maximum number of spaces at the start of the comment. + HazardyKnusperkeks wrote: > MyDeveloperDay wrote: > > I'm personally not a massive

[PATCH] D86671: [clang-tidy] Add new case type to check variables with Hungarian notation

dougpuob updated this revision to Diff 309767. dougpuob added a comment. - Improved code review suggestions from @njames93. Including move the IdentifierNamingCheck::HNOption variable to IdentifierNamingCheck::FileStyle::HNOption, use try_emplace() instead of insert() and lookup().

[PATCH] D68410: [AttrDocs] document always_inline

ojeda added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:5498 + +See also `the MSDN Inline docs`_, `the GCC Common Function Attribute docs`_, +and `the GCC Inline docs`_. MSDN is gone now, Microsoft Docs is the new one. Repository: rG

[clang] a2f9221 - [TableGen] Delete 11 unused declarations

Author: Fangrui Song Date: 2020-12-06T13:21:07-08:00 New Revision: a2f922140f5380571fb74179f2bf622b3b925697 URL: https://github.com/llvm/llvm-project/commit/a2f922140f5380571fb74179f2bf622b3b925697 DIFF: https://github.com/llvm/llvm-project/commit/a2f922140f5380571fb74179f2bf622b3b925697.diff

[PATCH] D87188: [InstCombine] Canonicalize SPF to abs intrinc

nikic abandoned this revision. nikic added a comment. This needs someone with access to AArch64 hardware to look into https://reviews.llvm.org/D87188#2281093 to make progress. I don't have any AArch64 hardware, and judging by the time it takes to build cmake on an AArch64 machine in the GCC

[PATCH] D91913: Suppress non-conforming GNU paste extension in all standard-conforming modes

hvdijk added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91913/new/ https://reviews.llvm.org/D91913 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] 192fb1b - [Sema] Delete unused declarations

Author: Fangrui Song Date: 2020-12-06T20:16:00-08:00 New Revision: 192fb1bd8ac6a59fb2efd528038fd13c53e9ff46 URL: https://github.com/llvm/llvm-project/commit/192fb1bd8ac6a59fb2efd528038fd13c53e9ff46 DIFF: https://github.com/llvm/llvm-project/commit/192fb1bd8ac6a59fb2efd528038fd13c53e9ff46.diff

[PATCH] D92006: Refactoring the attrubute plugin example to fit the new API

psionic12 updated this revision to Diff 309813. psionic12 added a comment. Add tests to check if attributes are attached to AST Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92006/new/ https://reviews.llvm.org/D92006 Files:

[PATCH] D90392: [clang-tidy] Omit std::make_unique/make_shared for default initialization.

ckennelly added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90392/new/ https://reviews.llvm.org/D90392 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D92742: [clang] Add support for attribute 'swift_async'

erik.pilkington created this revision. erik.pilkington added reviewers: arphaman, doug.gregor, aaron.ballman. Herald added subscribers: jdoerfert, ributzka, jkorous. erik.pilkington requested review of this revision. This attributes specifies how (or if) a given function or method will be

[clang] 5755522 - Sema.h: delete unused variables/functions/type aliases

Author: Fangrui Song Date: 2020-12-06T20:39:01-08:00 New Revision: 5755522b5a8be69d8a9f3b05c5e7078298d0d581 URL: https://github.com/llvm/llvm-project/commit/5755522b5a8be69d8a9f3b05c5e7078298d0d581 DIFF: https://github.com/llvm/llvm-project/commit/5755522b5a8be69d8a9f3b05c5e7078298d0d581.diff

[PATCH] D91975: [clang-tidy] cppcoreguidelines Narrowing Conversions Check: detect narrowing conversions involving typedefs

gridaphobe marked 2 inline comments as done. gridaphobe added a comment. Herald added a subscriber: shchenz. I've added the non-narrowing tests, are we good to merge? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91975/new/

[PATCH] D92329: [PowerPC][Clang] Remove QPX support

steven.zhang accepted this revision. steven.zhang added a comment. This revision is now accepted and ready to land. LGTM as I grep the whole repo with this patch applied, no QPX any more. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92329/new/

[PATCH] D91821: Fix PR42049 - Crash when parsing bad decltype use within template argument list after name assumed to be a function template

faisalv updated this revision to Diff 309809. faisalv edited the summary of this revision. faisalv added a comment. Per Richard's suggestion, instead of including the cached tokens into the decltype annotation, i revert the cache to match the end of where we think the (broken) decltype

[PATCH] D90392: [clang-tidy] Omit std::make_unique/make_shared for default initialization.

lebedev.ri added a comment. I think the patches description still could use some more words, in particular it still only repeats what the patch does, but not why it does that. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90392/new/

LLVM buildmaster will be updated and restarted tonight

Hello everyone, LLVM buildmaster will be updated and restarted after 7PM PST today. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D92742: [clang] Add support for attribute 'swift_async'

doug.gregor accepted this revision. doug.gregor added a comment. This revision is now accepted and ready to land. This looks good. I went ahead and tested it as part of adoption in Swift's Clang importer, over at https://github.com/apple/swift/pull/34985 CHANGES SINCE LAST ACTION

[PATCH] D92006: Refactoring the attrubute plugin example to fit the new API

psionic12 updated this revision to Diff 309814. psionic12 marked an inline comment as done. psionic12 added a comment. Fix grammar Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92006/new/ https://reviews.llvm.org/D92006 Files: