[PATCH] D91245: [clang-format] Recognize c++ coroutine keywords as unary operator to avoid misleading pointer alignment

MyDeveloperDay added a comment. I don't like seeing users having to use ```// clang-format off``` auto try_sequence = [](int& ref) -> return_ignore { /* clang-format off */ for co_await(int v : return_random_int()) ref = v; /*

[clang] 8b48d24 - [clang-format] Recognize c++ coroutine keywords as unary operator to avoid misleading pointer alignment

Author: Chuanqi Xu Date: 2020-12-15T20:50:46+08:00 New Revision: 8b48d24373204fc2fe6aac1f1f850fa3b6c18445 URL: https://github.com/llvm/llvm-project/commit/8b48d24373204fc2fe6aac1f1f850fa3b6c18445 DIFF: https://github.com/llvm/llvm-project/commit/8b48d24373204fc2fe6aac1f1f850fa3b6c18445.diff

[PATCH] D91245: [clang-format] Recognize c++ coroutine keywords as unary operator to avoid misleading pointer alignment

This revision was automatically updated to reflect the committed changes. Closed by commit rG8b48d2437320: [clang-format] Recognize c++ coroutine keywords as unary operator to avoid… (authored by ChuanqiXu). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang-tools-extra] 965d71c - [clangd] Avoid traversing C:\ -> C: when looking for CDBs

Author: Sam McCall Date: 2020-12-15T13:59:00+01:00 New Revision: 965d71c69acce658e9e3de00b25a351b00937820 URL: https://github.com/llvm/llvm-project/commit/965d71c69acce658e9e3de00b25a351b00937820 DIFF: https://github.com/llvm/llvm-project/commit/965d71c69acce658e9e3de00b25a351b00937820.diff

[PATCH] D1810: [ARM] Fix AArch32 and pre-v8 poly types to be unsigned

bsmith abandoned this revision. bsmith added a comment. Herald added subscribers: danielkiss, kristof.beyls. This change is very old and almost certainly out of date, therefore abandoning. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1810/new/ https://reviews.llvm.org/D1810

[PATCH] D93298: [RISCV] add the MC layer support of Zfinx extension

achieveartificialintelligence created this revision. achieveartificialintelligence added reviewers: HsiangKai, rkruppe, kito-cheng, craig.topper, jrtc27, luismarques. Herald added subscribers: frasercrmck, NickHung, evandro, apazos, sameer.abuasal, pzheng, s.egerton, lenary, Jim, benna, psnobl,

[PATCH] D92039: [-Wcalled-once-parameter] Introduce 'called_once' attribute

vsavchenko updated this revision to Diff 311898. vsavchenko added a comment. Refine conventions for completion handlers Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92039/new/ https://reviews.llvm.org/D92039 Files:

[PATCH] D93164: [AST] Add generator for source location introspection

aaron.ballman added a comment. Do I understand correctly that the workflow is to use the new dumping tool to generate the needed JSON file that then gets used as input to generate_cxx_src_locs.py which creates NodeLocationIntrospection.cpp/.h that then gets used by clang-query (eventually)? So

[PATCH] D93022: [ARM][AArch64] Add Cortex-A78C Support for Clang and LLVM

MarkMurrayARM marked 4 inline comments as done. MarkMurrayARM added a comment. Marked addressed comments as "done". Some debug code has been abandoned. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93022/new/ https://reviews.llvm.org/D93022

[PATCH] D84187: [clang][cli] Port DependencyOutput string based options to new option parsing system

jansvoboda11 updated this revision to Diff 311861. jansvoboda11 added a comment. Rebase, undo unnecessary move of options Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84187/new/ https://reviews.llvm.org/D84187 Files:

[PATCH] D93224: [RFC][analyzer] Use the MacroExpansionContext for macro expansions in plists

martong added inline comments. Comment at: clang/test/Analysis/Inputs/expected-plists/plist-macros-with-expansion.cpp.plist:148 nameSET_PTR_VAR_TO_NULL - expansionptr = 0 + expansionptr =0 martong wrote: > I wonder how much added value do we

[PATCH] D91245: [clang-format] Recognize c++ coroutine keywords as unary operator to avoid misleading pointer alignment

ChuanqiXu added a comment. In D91245#2454504 , @MyDeveloperDay wrote: > Aside: Would you be prepared to take a look at D34225: [clang-format] Teach > clang-format how to handle C++ coroutines > which is pretty much

[PATCH] D91245: [clang-format] Recognize c++ coroutine keywords as unary operator to avoid misleading pointer alignment

ChuanqiXu added a comment. In D91245#2454610 , @MyDeveloperDay wrote: > I don't like seeing users having to use ```// clang-format off``` > > auto try_sequence = [](int& ref) -> return_ignore { > /* clang-format off */ > for

[PATCH] D84668: [clang][cli] Port TargetOpts simple string based options to new option parsing system

jansvoboda11 updated this revision to Diff 311872. jansvoboda11 added a comment. Rebase, undo unnecessary move of options Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84668/new/ https://reviews.llvm.org/D84668 Files:

[PATCH] D93224: [RFC][analyzer] Use the MacroExpansionContext for macro expansions in plists

xazax.hun accepted this revision. xazax.hun added a comment. This revision is now accepted and ready to land. Yay! Deleting code is always nice. Comment at: clang/test/Analysis/Inputs/expected-plists/plist-macros-with-expansion.cpp.plist:148 nameSET_PTR_VAR_TO_NULL -

[PATCH] D92039: [-Wcalled-once-parameter] Introduce 'called_once' attribute

vsavchenko updated this revision to Diff 311903. vsavchenko added a comment. Fix minor things Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92039/new/ https://reviews.llvm.org/D92039 Files:

[PATCH] D93031: Enable fexec-charset option

abhina.sreeskantharajan updated this revision to Diff 311911. abhina.sreeskantharajan added a comment. Thanks for your quick reviews! I haven't addressed all the comments yet but I plan to address all of them. I put up this patch early because it has a few major changes: - moves

[PATCH] D92198: [clangd] Log remote index connectivity status

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. LG with one fix around the atomic Comment at: clang-tools-extra/clangd/index/remote/Client.cpp:49 +auto NewStatus = Channel->GetState(/*try_to_connect=*/false); +

[PATCH] D93227: [clangd] Smarter hover on auto and decltype

sammccall added a comment. Thanks! This seems more consistent with our other hovers, but is going to be better-formatted/more attractive in VSCode. There are a couple of wrinkles I'd like to discuss :-) Brevity --- This is clear and mostly consistent (documentation excepted), but uses

[PATCH] D93301: [flang][driver] Add support for `-c` and `-emit-obj`

awarzynski added a comment. @dang , I would appreciate if you could take a look at the diff in Options.td - you introduced the most recent changes there: https://reviews.llvm.org/D82574. I got a bit confused with the nested `let` statements there. I couldn't find a better way of marking

[PATCH] D92800: [Clang] Make nomerge attribute a function attribute as well as a statement attribute.

aaron.ballman added a comment. In general, I think this is reasonable -- there's a bit more work to be done before it's ready to land, but this is heading in the right direction. Comment at: clang/include/clang/Basic/Attr.td:559 +/// A attribute is either a declaration

[PATCH] D51650: Implement target_clones multiversioning

erichkeane updated this revision to Diff 311890. erichkeane added a comment. Since there seems to be at least a little renewed interest in this from a handful of people lately, I spend the time to rebase this and do some minor cleanup tasks. CHANGES SINCE LAST ACTION

[clang] e2dc306 - [utils] Fix UpdateTestChecks case where 2 runs differ for last label

Author: Mircea Trofin Date: 2020-12-15T07:16:54-08:00 New Revision: e2dc306b1ac71258e6ce40a66e778527f282c355 URL: https://github.com/llvm/llvm-project/commit/e2dc306b1ac71258e6ce40a66e778527f282c355 DIFF: https://github.com/llvm/llvm-project/commit/e2dc306b1ac71258e6ce40a66e778527f282c355.diff

[PATCH] D93078: [utils] Fix UpdateTestChecks case where 2 runs differ for last label

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe2dc306b1ac7: [utils] Fix UpdateTestChecks case where 2 runs differ for last label (authored by mtrofin). Repository: rG LLVM Github Monorepo

[PATCH] D92977: [clangd] Improve hover and goToDefinition on auto and dectype

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGbda7d0af9707: [clangd] Improve goToDefinition on auto and dectype (authored by qchateau, committed by sammccall). Repository: rG LLVM Github

[clang-tools-extra] bda7d0a - [clangd] Improve goToDefinition on auto and dectype

Author: Quentin Chateau Date: 2020-12-15T16:32:22+01:00 New Revision: bda7d0af970718c243d93b22a8449c20156e574f URL: https://github.com/llvm/llvm-project/commit/bda7d0af970718c243d93b22a8449c20156e574f DIFF:

[PATCH] D92751: Precondition isHomogeneousAggregate on isCXX14Aggregate

DavidTruby updated this revision to Diff 311906. DavidTruby added a comment. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Added extra tests for additional conditions and IR -> assembly tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D93301: [flang][driver] Add support for `-c` and `-emit-obj`

awarzynski created this revision. Herald added a reviewer: sscalpone. Herald added a subscriber: dang. awarzynski requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch adds a frontend action for emitting object files. While Flang does

[PATCH] D93223: [RFC][analyzer] Create MacroExpansionContext member in AnalysisConsumer and pass down to the diagnostics consumers

martong added a comment. Looks quite straight-forward other than that new prototype. Comment at: clang/include/clang/Analysis/PathDiagnostic.h:911 +void createHTMLSingleFileDiagnosticConsumer( +PathDiagnosticConsumerOptions DiagOpts, Why do we need this

[PATCH] D93224: [RFC][analyzer] Use the MacroExpansionContext for macro expansions in plists

martong added inline comments. Comment at: clang/test/Analysis/Inputs/expected-plists/plist-macros-with-expansion.cpp.plist:148 nameSET_PTR_VAR_TO_NULL - expansionptr = 0 + expansionptr =0 I wonder how much added value do we have with these

[PATCH] D84190: [clang][cli] Port FrontendOpts simple string based options to new option parsing system

jansvoboda11 updated this revision to Diff 311865. jansvoboda11 added a comment. Rebase, undo unnecessary move of options Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84190/new/ https://reviews.llvm.org/D84190 Files:

[PATCH] D93078: [utils] Fix UpdateTestChecks case where 2 runs differ for last label

mtrofin added a comment. In D93078#2453891 , @pengfei wrote: > LGTM. Thanks. > `update_test_prefix.py` assumes the conflicting output. You may need to > change the expection of it as well. oh yes - made it check the new warning. Thanks! Repository:

[PATCH] D84668: [clang][cli] Port TargetOpts simple string based options to new option parsing system

jansvoboda11 updated this revision to Diff 311915. jansvoboda11 added a comment. Fix: avoid template instantiations Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84668/new/ https://reviews.llvm.org/D84668 Files:

[PATCH] D84669: WIP [clang][cli] Port CodeGenOpts simple string flags to new option parsing system

jansvoboda11 updated this revision to Diff 311919. jansvoboda11 added a comment. Rebase, move options back to their original lines Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84669/new/ https://reviews.llvm.org/D84669 Files:

[PATCH] D93222: [RFC][analyzer] Introduce MacroExpansionContext to libAnalysis

martong added inline comments. Comment at: clang/include/clang/Analysis/MacroExpansionContext.h:82 + MacroExpansionText + getExpandedMacroForLocation(SourceLocation MacroExpansionLoc) const; + `getExpandedText` ? Since what you get back is not a macro anymore.

[PATCH] D84668: Port TargetOpts simple string based options to new option parsing system

jansvoboda11 commandeered this revision. jansvoboda11 added a reviewer: dang. jansvoboda11 added a reviewer: dexonsmith. jansvoboda11 added a comment. Taking over this patch, as Daniel is no longer involved. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang-tools-extra] 92dd077 - Reland [clangd] Extract per-dir CDB cache to its own threadsafe class. NFC

Author: Sam McCall Date: 2020-12-15T14:00:03+01:00 New Revision: 92dd077af1ff89929f5502c6c887358f51d5afc1 URL: https://github.com/llvm/llvm-project/commit/92dd077af1ff89929f5502c6c887358f51d5afc1 DIFF: https://github.com/llvm/llvm-project/commit/92dd077af1ff89929f5502c6c887358f51d5afc1.diff

[PATCH] D93223: [RFC][analyzer] Create MacroExpansionContext member in AnalysisConsumer and pass down to the diagnostics consumers

xazax.hun added inline comments. Comment at: clang/lib/StaticAnalyzer/Frontend/AnalysisConsumer.cpp:129 +Plugins(plugins), Injector(injector), CTU(CI), +MacroExpansions(PP, CI.getLangOpts()) { DigestAnalyzerOptions(); This will always record

[PATCH] D93224: [RFC][analyzer] Use the MacroExpansionContext for macro expansions in plists

steakhal added a comment. Internally we analyzed 16 projects with this patch-stack. No reports were changed! Now we don't crash on macro expansions in our test set, yey. I've checked a few expansions and seemed to be readable enough. Comment at:

[PATCH] D91979: [Clang][Attr] Introduce the `assume` function attribute

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:742 "the argument to %0 has side effects that will be discarded">, - InGroup>; + InGroup; +def warn_assume_attribute_string_unknown : Warning< aaron.ballman

[PATCH] D91819: [PowerPC] Enable paired vector type and intrinsics when MMA is disabled

saghir accepted this revision. saghir added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91819/new/ https://reviews.llvm.org/D91819 ___

[PATCH] D90275: [clang][IR] Add support for leaf attribute

jdoerfert added a comment. In D90275#2453641 , @gulfem wrote: >> This is missing a lang ref entry for `nocallback` and the `attributes.ll` >> test is arguably broken (see below). > > Could you please elaborate on missing lang ref entry? Where that should

[PATCH] D91245: [clang-format] Recognize c++ coroutine keywords as unary operator to avoid misleading pointer alignment

MyDeveloperDay added a comment. not that rare it seems https://github.com/search?q=%22co_return+%28%22=code https://github.com/search?q=%22for+co_await+%28%22=code CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91245/new/ https://reviews.llvm.org/D91245

[PATCH] D93078: [utils] Fix UpdateTestChecks case where 2 runs differ for last label

mtrofin updated this revision to Diff 311896. mtrofin added a comment. update_test_prefix.py change Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93078/new/ https://reviews.llvm.org/D93078 Files:

[PATCH] D90159: [DDG] Data Dependence Graph - DOT printer

bmahjour added a comment. In D90159#2453805 , @Meinersbur wrote: > Can I help fixing the Windows build problem? I think I have a fix (please see the updated patch), but don't have access to a windows machine to verify. Would you be able to try building

[PATCH] D93298: [RISCV] add the MC layer support of Zfinx extension

jrtc27 added a comment. Firstly, please generate your diffs with full context (-U with a sufficiently-large number). Secondly, can we avoid having to do a bunch of duplication with some clever use of multiclasses for F/D/Zfh and pseudos? Though maybe it's small enough that the duplication is

[clang] 8acb5f2 - [clang][driver][NFC] Use StringRef instead of std::string

Author: Nathan James Date: 2020-12-15T16:19:12Z New Revision: 8acb5f2723ecaf0f1904a085ad79d0623cec38f6 URL: https://github.com/llvm/llvm-project/commit/8acb5f2723ecaf0f1904a085ad79d0623cec38f6 DIFF: https://github.com/llvm/llvm-project/commit/8acb5f2723ecaf0f1904a085ad79d0623cec38f6.diff LOG:

[PATCH] D84669: Port CodeGenOpts simple string flags to new option parsing system

jansvoboda11 commandeered this revision. jansvoboda11 added a reviewer: dang. jansvoboda11 added a comment. Taking over this patch, as Daniel is no longer involved. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84669/new/

[PATCH] D93222: [RFC][analyzer] Introduce MacroExpansionContext to libAnalysis

xazax.hun added a comment. Overall looks good to me, I have some minor nits and questions inline. Comment at: clang/lib/Analysis/MacroExpansionContext.cpp:22 +: PP(PP), SM(PP.getSourceManager()), LangOpts(LangOpts) { + class MacroExpansionRangeRecorder : public

[PATCH] D93103: Enable the _ExtInt extension on the BPF Target

erichkeane added a comment. From the CFE's perspective, this is all that should be needed. Is there a BPF code-owner who can test it and see if it is acceptable? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93103/new/

[PATCH] D91974: [PowerPC] Rename the vector pair intrinsics and builtins to replace the _mma_ prefix by _vsx_

saghir accepted this revision. saghir added a comment. LGTM. A minor nit regarding an incomplete comment in `llvm/test/CodeGen/PowerPC/paired-vector-intrinsics.ll` which can be addressed when committing the patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D90159: [DDG] Data Dependence Graph - DOT printer

bmahjour updated this revision to Diff 311897. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90159/new/ https://reviews.llvm.org/D90159 Files: clang/lib/StaticAnalyzer/Core/ExprEngine.cpp llvm/include/llvm/Analysis/CFGPrinter.h

[PATCH] D92854: [flang][driver] Add support for `-fsyntax-only`

awarzynski updated this revision to Diff 311925. awarzynski added a comment. Address comment from @CarolineConcatto + rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92854/new/ https://reviews.llvm.org/D92854 Files:

[PATCH] D92198: [clangd] Log remote index connectivity status

kbobyrev updated this revision to Diff 311937. kbobyrev marked an inline comment as done. kbobyrev added a comment. Remove the race between ConnectionStatus access. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92198/new/

[clang-tools-extra] dcdef5b - [clangd] Log remote index connectivity status

Author: Kirill Bobyrev Date: 2020-12-15T18:29:48+01:00 New Revision: dcdef5b5b3df457566e7faf61e1e5789c42528d1 URL: https://github.com/llvm/llvm-project/commit/dcdef5b5b3df457566e7faf61e1e5789c42528d1 DIFF:

[PATCH] D92977: [clangd] Improve hover and goToDefinition on auto and dectype

sammccall added a comment. I sent you D93314 to extend the getNonReferenceType() a bit... curious what you think Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92977/new/ https://reviews.llvm.org/D92977

[clang] 67a1ffd - [FPEnv] Teach the IRBuilder about invoke's correct use of the strictfp attribute.

Author: Kevin P. Neal Date: 2020-12-15T12:38:10-05:00 New Revision: 67a1ffd88ac08526bb6cfc7b3f607e6668ba1c70 URL: https://github.com/llvm/llvm-project/commit/67a1ffd88ac08526bb6cfc7b3f607e6668ba1c70 DIFF: https://github.com/llvm/llvm-project/commit/67a1ffd88ac08526bb6cfc7b3f607e6668ba1c70.diff

[PATCH] D93134: [FPEnv] Teach the IRBuilder about invoke's correct use of the strictfp attribute.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG67a1ffd88ac0: [FPEnv] Teach the IRBuilder about invokes correct use of the strictfp… (authored by kpn). Repository: rG LLVM Github Monorepo

[clang] 2ec5973 - Revert "[FPEnv] Teach the IRBuilder about invoke's correct use of the strictfp attribute."

Author: Kevin P. Neal Date: 2020-12-15T12:58:47-05:00 New Revision: 2ec5973fddb07e66ae0df7d0aac2cda55387b0bd URL: https://github.com/llvm/llvm-project/commit/2ec5973fddb07e66ae0df7d0aac2cda55387b0bd DIFF: https://github.com/llvm/llvm-project/commit/2ec5973fddb07e66ae0df7d0aac2cda55387b0bd.diff

[PATCH] D92427: [OPENMP51] Add present modifier in defaultmap clause

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92427/new/ https://reviews.llvm.org/D92427 ___

[PATCH] D93325: Add srcloc output to clang-query

steveire created this revision. steveire added a reviewer: aaron.ballman. steveire requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D93325 Files:

[PATCH] D93301: [flang][driver] Add support for `-c` and `-emit-obj`

clementval added inline comments. Comment at: clang/include/clang/Driver/Options.td:4629 -} // let Flags = [CC1Option] +} // let Flags = [CC1Option, NoDriverOption] + Is it intended to modify the SYCL options? Comment at:

[PATCH] D92920: [clang-tidy] Add a diagnostic callback to parseConfiguration

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/ClangTidyOptions.cpp:400 +DiagCallback Handler) { + llvm::yaml::Input Input(Config, nullptr, Handler ? diagHandlerImpl : nullptr, + );

[clang-tools-extra] 0545680 - Reland dcdef5b5b3df457566e7faf61e1e5789c42528d1

Author: Kirill Bobyrev Date: 2020-12-15T20:54:55+01:00 New Revision: 0545680cb870f1ca81198cd8324814543eb79e64 URL: https://github.com/llvm/llvm-project/commit/0545680cb870f1ca81198cd8324814543eb79e64 DIFF:

[PATCH] D92854: [flang][driver] Add support for `-fsyntax-only`

awarzynski added inline comments. Comment at: flang/lib/Frontend/FrontendActions.cpp:87 + defaultKinds, features, ci.allCookedSources()}; + semanticsContext.set_moduleDirectory("."s); + Fortran::semantics::Semantics semantics{ CarolineConcatto wrote: >

[PATCH] D93247: [Sema] Fix a miscompile by retaining array qualifiers when folding VLAs to constant arrays

arphaman accepted this revision. arphaman added a comment. This revision is now accepted and ready to land. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93247/new/ https://reviews.llvm.org/D93247 ___ cfe-commits mailing list

[PATCH] D93079: [OpenMP] Introduce an assumption to ignore possible external callers

jdoerfert added a comment. In D93079#2451782 , @JonChesterfield wrote: > Is this for cases where we are compiling a subset of the target code, i.e. > without link time optimisation? Upstream cannot to LTO on any target code as of now :( > It's

[PATCH] D93206: [AArch64][NEON] Remove undocumented vceqz{,q}_p16, vml{a,s}q_n_f64 intrinsics

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5a2a8369e82c: [AArch64][NEON] Remove undocumented vceqz{,q}_p16, vml{a,s}q_n_f64 intrinsics (authored by joechrisellis). Repository: rG LLVM

[clang] 5a2a836 - [AArch64][NEON] Remove undocumented vceqz{, q}_p16, vml{a,s}q_n_f64 intrinsics

Author: Joe Ellis Date: 2020-12-15T17:19:16Z New Revision: 5a2a8369e82cea9689b0ff60f3e9baa7fc79fbcf URL: https://github.com/llvm/llvm-project/commit/5a2a8369e82cea9689b0ff60f3e9baa7fc79fbcf DIFF: https://github.com/llvm/llvm-project/commit/5a2a8369e82cea9689b0ff60f3e9baa7fc79fbcf.diff LOG:

[PATCH] D92198: [clangd] Log remote index connectivity status

kbobyrev updated this revision to Diff 311939. kbobyrev added a comment. Cleanup includes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92198/new/ https://reviews.llvm.org/D92198 Files: clang-tools-extra/clangd/index/remote/Client.cpp Index:

[clang-tools-extra] 32e7a9c - Revert "[clangd] Log remote index connectivity status"

Author: Kirill Bobyrev Date: 2020-12-15T18:42:42+01:00 New Revision: 32e7a9cab6412cb4bb5add5cb2d48be82e7d9f11 URL: https://github.com/llvm/llvm-project/commit/32e7a9cab6412cb4bb5add5cb2d48be82e7d9f11 DIFF:

[PATCH] D92874: [clangd] Validate clang-tidy Checks in clangd config.

njames93 updated this revision to Diff 311948. njames93 marked 2 inline comments as done. njames93 added a comment. Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92874/new/ https://reviews.llvm.org/D92874 Files:

[PATCH] D91819: [PowerPC] Enable paired vector type and intrinsics when MMA is disabled

bsaleil added inline comments. Comment at: clang/lib/AST/ASTContext.cpp:1427 + if (Target.getTriple().isPPC64() && + Target.hasFeature("paired-vector-memops")) { +if (Target.hasFeature("mma")) { amyk wrote: > Is it better to do `hasFeature()` over

[PATCH] D92733: Fix PR25627 - false positive diagnostics involving implicit-captures in dependent lambda expressions.

wchilders requested changes to this revision. wchilders added a comment. This revision now requires changes to proceed. I'm still "chewing on this", I'm not sure I fully understand the problem well enough to give great "big picture" feedback. In any case, I've left a few comments where I had a

[PATCH] D93314: [clangd] go-to-definition on auto unwraps array/pointer types

qchateau added a comment. Ah good catch, I agree this is the behavior we want. Concerning cases like `unique_ptr`, the only generic behavior I can think of would be to suggest multiple `LocatedSymbol` when `auto` is deduced to a template class: the template class itself, and all its template

[PATCH] D93008: [clang][cli] Do not marshall only CC1Option flags in BoolOption

Bigcheese accepted this revision. Bigcheese added a comment. This revision is now accepted and ready to land. lgtm. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93008/new/ https://reviews.llvm.org/D93008

[PATCH] D92874: [clangd] Validate clang-tidy Checks in clangd config.

njames93 updated this revision to Diff 311926. njames93 added a comment. Address some comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92874/new/ https://reviews.llvm.org/D92874 Files: clang-tools-extra/clangd/ConfigCompile.cpp

[PATCH] D92874: [clangd] Validate clang-tidy Checks in clangd config.

njames93 marked 2 inline comments as done. njames93 added inline comments. Comment at: clang-tools-extra/clangd/ConfigCompile.cpp:26 +#include "../clang-tidy/ClangTidyModuleRegistry.h" #include "CompileCommands.h" sammccall wrote: > This is a pretty weird

[PATCH] D92198: [clangd] Log remote index connectivity status

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGdcdef5b5b3df: [clangd] Log remote index connectivity status (authored by kbobyrev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D92663: [clangd] Add hot-reload of compile_commands.json and compile_flags.txt

adamcz added inline comments. Comment at: clang-tools-extra/clangd/GlobalCompilationDatabase.cpp:206 + auto Stat = FS.status(Path); + if (!Stat || !Stat->isRegularFile()) { +Size = NoFileCached; Here's a fun thought: what if this is a network or otherwise

[PATCH] D92756: [clang-tidy] Support all YAML supported spellings for bools in CheckOptions.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92756/new/ https://reviews.llvm.org/D92756

[PATCH] D93298: [RISCV] add the MC layer support of Zfinx extension

craig.topper added inline comments. Comment at: clang/lib/Basic/Targets/RISCV.h:40 : TargetInfo(Triple), HasM(false), HasA(false), HasF(false), HasD(false), -HasC(false), HasB(false), HasV(false), HasZfh(false) { LongDoubleWidth = 128; We

[clang] 6c365cd - Consider reference, pointer, and pointer-to-member TemplateArguments to be different if they have different types.

Author: Richard Smith Date: 2020-12-15T12:00:57-08:00 New Revision: 6c365cd31e323d2d075573edd927e4f7fb5ec01c URL: https://github.com/llvm/llvm-project/commit/6c365cd31e323d2d075573edd927e4f7fb5ec01c DIFF: https://github.com/llvm/llvm-project/commit/6c365cd31e323d2d075573edd927e4f7fb5ec01c.diff

[PATCH] D84187: Port DependencyOutput string based options to new option parsing system

jansvoboda11 commandeered this revision. jansvoboda11 added a reviewer: dang. jansvoboda11 added a comment. Taking over this patch, as Daniel is no longer involved. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84187/new/

[PATCH] D84190: Port FrontendOpts simple string based options to new option parsing system

jansvoboda11 commandeered this revision. jansvoboda11 added a reviewer: dang. jansvoboda11 added a reviewer: dexonsmith. jansvoboda11 added a comment. Taking over this patch, as Daniel is no longer involved. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang-tools-extra] 5186eda - [clangd] Oops, fix code in #ifdef WIN32

Author: Sam McCall Date: 2020-12-15T14:17:54+01:00 New Revision: 5186eda3269333b2fb38800e9ded2a27ae87f99b URL: https://github.com/llvm/llvm-project/commit/5186eda3269333b2fb38800e9ded2a27ae87f99b DIFF: https://github.com/llvm/llvm-project/commit/5186eda3269333b2fb38800e9ded2a27ae87f99b.diff

[PATCH] D92990: [clangd] Provide suggestions with invalid config keys

sammccall added a subscriber: hokein. sammccall added a comment. Sorry about being slow here. Just a couple of suggestions to avoid cluttering the config parsing bits too much, and IIUC fixits can be removed. Comment at: clang-tools-extra/clangd/ConfigYAML.cpp:211 +

[PATCH] D93296: [clang-format] PR35514 brace-init member initializers in function-try-blocks are not formatted correctly

MyDeveloperDay created this revision. MyDeveloperDay added reviewers: krasimir, curdeius, JakeMerdichAMD, mnem. MyDeveloperDay added projects: clang-format, clang. MyDeveloperDay requested review of this revision. https://bugs.llvm.org/show_bug.cgi?id=35514 Initializer lists with a try-block are

[PATCH] D92874: [clangd] Validate clang-tidy Checks in clangd config.

sammccall added a comment. Thanks! Just some organization nits. Comment at: clang-tools-extra/clangd/ConfigCompile.cpp:26 +#include "../clang-tidy/ClangTidyModuleRegistry.h" #include "CompileCommands.h" This is a pretty weird place to depend on clang-tidy.

[PATCH] D92198: [clangd] Log remote index connectivity status

kbobyrev updated this revision to Diff 311942. kbobyrev added a comment. Cleanup rebase artifact. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92198/new/ https://reviews.llvm.org/D92198 Files: clang-tools-extra/clangd/index/remote/Client.cpp

[PATCH] D93078: [utils] Fix UpdateTestChecks case where 2 runs differ for last label

mtrofin added inline comments. Comment at: llvm/utils/update_analyze_test_checks.py:129 + +common.warn_on_failed_prefixes(func_dict) is_in_function = False pengfei wrote: > Can we move these warn to common.py? Come to think of it, maybe moving it to

[PATCH] D92198: [clangd] Log remote index connectivity status

kbobyrev updated this revision to Diff 311943. kbobyrev added a comment. Actually clean up rebase artifacts. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92198/new/ https://reviews.llvm.org/D92198 Files:

[PATCH] D92990: [clangd] Provide suggestions with invalid config keys

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. LG, thanks! Comment at: clang-tools-extra/clangd/ConfigYAML.cpp:27 +static llvm::Optional +bestGuess(llvm::StringRef Search, (nit: no need for

[PATCH] D92874: [clangd] Validate clang-tidy Checks in clangd config.

njames93 marked 4 inline comments as done. njames93 added inline comments. Comment at: clang-tools-extra/clangd/ConfigCompile.cpp:58 + assert(!Check.contains('*') && "isRegisteredCheck doesn't support globs"); + assert(Check.trim().size() == Check.size() && + "Check

[PATCH] D93134: [FPEnv] Teach the IRBuilder about invoke's correct use of the strictfp attribute.

thakis added a comment. This breaks check-clang: http://45.33.8.238/linux/35362/step_7.txt PTAL, and if it takes a while to fix please revert while you investigate. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93134/new/

[clang-tools-extra] cfa1010 - [clangd] Provide suggestions with invalid config keys

Author: Nathan James Date: 2020-12-15T18:16:17Z New Revision: cfa1010c42429f689186125270dfbad7d6a1c01d URL: https://github.com/llvm/llvm-project/commit/cfa1010c42429f689186125270dfbad7d6a1c01d DIFF: https://github.com/llvm/llvm-project/commit/cfa1010c42429f689186125270dfbad7d6a1c01d.diff LOG:

[PATCH] D92990: [clangd] Provide suggestions with invalid config keys

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGcfa1010c4242: [clangd] Provide suggestions with invalid config keys (authored by njames93). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D92761: [clang][AArch64][SVE] Avoid going through memory for VLAT <-> VLST casts

c-rhodes accepted this revision. c-rhodes added a comment. This revision is now accepted and ready to land. Left a couple of nits but mostly LGTM, cheers Comment at: clang/lib/CodeGen/CGExprScalar.cpp:2025-2051 // Perform VLAT <-> VLST bitcast through memory. if

[clang] ef40d52 - Adding a test case that I accidentally dropped from 27ea7d0a6e0dc51e0214707bcc265fa6f9dc9bc6

Author: Aaron Ballman Date: 2020-12-15T14:56:44-05:00 New Revision: ef40d5233b8b6f82927128c5b255cdc3aed9021d URL: https://github.com/llvm/llvm-project/commit/ef40d5233b8b6f82927128c5b255cdc3aed9021d DIFF: https://github.com/llvm/llvm-project/commit/ef40d5233b8b6f82927128c5b255cdc3aed9021d.diff

[PATCH] D72241: [clang-tidy] new altera single work item barrier check

aaron.ballman added a comment. In D72241#2449426 , @ffrankies wrote: > @aaron.ballman Thank you! If there are no further comments, could you please > commit this on my behalf? My GitHub username is ffrankies > . I'd be

  1   2   3   >