[PATCH] D94961: [OpenMP] Add OpenMP offloading toolchain skeleton for AMDGPU

JonChesterfield added a comment. This patch was written, roughly, by: - copying the known-working openmp driver from rocm into the trunk source tree - deleting lots of stuff that didn't look necessary - deleting some stuff that is broadly necessary, but the specifics are up for debate The idea

[clang] 2c4f6be - [SystemZ][z/OS] Fix No such file or directory expression error

Author: Abhina Sreeskantharajan Date: 2021-01-19T07:25:24-05:00 New Revision: 2c4f6be86c14c28243915ab9eb3a2ff1902fee99 URL: https://github.com/llvm/llvm-project/commit/2c4f6be86c14c28243915ab9eb3a2ff1902fee99 DIFF:

[PATCH] D94879: Implement dynamic mapAnyOf in terms of ASTNodeKinds

aaron.ballman added inline comments. Comment at: clang/lib/ASTMatchers/Dynamic/Marshallers.h:948 + return {}; +auto VM = Arg.Value.getMatcher(); +if (VM.hasTypedMatcher(NK)) { Note, this is an example of why use of `auto` is discouraged

[PATCH] D94624: PATCH] [clang-query] Add a --use-color option to clang-query to allow forcing the behavior

tomrittervg added a comment. In D94624#2506831 , @aaron.ballman wrote: > In D94624#2501894 , @tomrittervg > wrote: > >> I started trying to work on a patch, but I'm still unpacking from a move and >> don't have

[PATCH] D94871: [Clang][OpenMP] Fixed an issue that clang crashed when compiling OpenMP program in device only mode without host IR

ABataev added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:2944-2947 +// This could happen if the device compilation is invoked standalone. +if (!hasTargetRegionEntryInfo(DeviceID, FileID, ParentName, LineNum)) +

[PATCH] D94942: [clangd] Add tweak for implementing abstract class

njames93 updated this revision to Diff 317523. njames93 added a comment. Update printing policy. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94942/new/ https://reviews.llvm.org/D94942 Files:

[PATCH] D94961: [OpenMP] Add OpenMP offloading toolchain skeleton for AMDGPU

ABataev added a comment. In D94961#2506460 , @JonChesterfield wrote: > This patch was written, roughly, by: > > - copying the known-working openmp driver from rocm into the trunk source tree > - deleting lots of stuff that didn't look necessary > -

[PATCH] D94961: [OpenMP] Add OpenMP offloading toolchain skeleton for AMDGPU

jdoerfert added a comment. Won't this just prevent us from building clang due to the missing cmake changes? We need somewhat testable chunks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94961/new/ https://reviews.llvm.org/D94961

[PATCH] D94785: [clangd] Index local classes, virtual and overriding methods.

usaxena95 marked an inline comment as done. usaxena95 added a comment. In D94785#2506186 , @hokein wrote: > I think we'd better bump the index version, even though this is not a > breaking change, but we will collect more data. Not bumping the index

[clang] a6f9077 - [clang] Check for nullptr when instantiating late attrs

Author: Adam Czachorowski Date: 2021-01-19T13:43:15+01:00 New Revision: a6f9077b16da90204b296acd4f840769e83460ac URL: https://github.com/llvm/llvm-project/commit/a6f9077b16da90204b296acd4f840769e83460ac DIFF:

[PATCH] D94933: [clang] Check for nullptr when instantiating late attrs

This revision was automatically updated to reflect the committed changes. Closed by commit rGa6f9077b16da: [clang] Check for nullptr when instantiating late attrs (authored by adamcz). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94933/new/

[PATCH] D93630: [Attr] Apply GNU-style attributes to expression statements

vsavchenko added inline comments. Comment at: clang/test/Parser/stmt-attributes.c:5 + + __attribute__((unknown_attribute));// expected-warning {{unknown attribute 'unknown_attribute' ignored}} + __attribute__((unknown_attribute)) {} // expected-warning

[PATCH] D93630: [Attr] Apply GNU-style attributes to expression statements

aaron.ballman added a comment. In D93630#2504758 , @vsavchenko wrote: > I'll clean up the tests! But, unfortunately, I couldn't proceed with GCC > folks. I asked around and I'm not allowed to do that (company rules). Ah, that's unfortunate. When I get

[PATCH] D94961: [OpenMP] Add OpenMP offloading toolchain skeleton for AMDGPU

pdhaliwal updated this revision to Diff 317553. pdhaliwal added a comment. Fix clang-tidy error Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94961/new/ https://reviews.llvm.org/D94961 Files: clang/lib/Driver/ToolChains/AMDGPUOpenMP.cpp

[PATCH] D94880: Add clang-query support for mapAnyOf

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM aside from some minor nits. Comment at: clang/lib/ASTMatchers/Dynamic/Marshallers.h:1081 +if (NodeKinds.empty()) { + // Set error + return

[PATCH] D94927: [clangd] Use ASTSignals in Heuristics CC Ranking.

adamcz accepted this revision. adamcz added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/Quality.cpp:477 + if (MainFileRefs >= 2) { +// E.g.: (2, 1.12), (9, 2.0), (48, 3.0). Can you add a comment

[PATCH] D94606: [clangd] Move DirBasedCDB broadcasting onto its own thread.

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks, lgtm! Comment at: clang-tools-extra/clangd/GlobalCompilationDatabase.cpp:496 + std::condition_variable CV; + std::atomic ShouldStop = {false}; // Must notify

[PATCH] D94785: [clangd] Index local classes, virtual and overriding methods.

usaxena95 updated this revision to Diff 317525. usaxena95 added a comment. Herald added a subscriber: wenlei. Updated index tests's input files. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94785/new/ https://reviews.llvm.org/D94785 Files:

[PATCH] D93630: [Attr] Apply GNU-style attributes to expression statements

aaron.ballman added inline comments. Comment at: clang/test/Parser/stmt-attributes.c:5 + + __attribute__((unknown_attribute));// expected-warning {{unknown attribute 'unknown_attribute' ignored}} + __attribute__((unknown_attribute)) {} // expected-warning

[PATCH] D94865: [ASTMatchers] Add callOrConstruct matcher

aaron.ballman added inline comments. Comment at: clang/include/clang/ASTMatchers/ASTMatchers.h:2867 +extern const internal::MapAnyOfMatcher +callOrConstruct; + I'm not super keen on this name. It's certainly descriptive, but I do wonder if it's a bit too

[PATCH] D94785: [clangd] Index local classes, virtual and overriding methods.

usaxena95 added a comment. In D94785#2506685 , @hokein wrote: > if you don't mind, could you rerun the benchmark (we have a behavior changes > from original version, I guess it won't not change significantly)? and update > the data in the description

[PATCH] D94785: [clangd] Index local classes, virtual and overriding methods.

usaxena95 updated this revision to Diff 317522. usaxena95 added a comment. Index all member functions instead of only polymorphic functions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94785/new/ https://reviews.llvm.org/D94785 Files:

[PATCH] D94599: [clang][Tooling] Get rid of a hack in SymbolOccurrences, NFCI

simon_tatham added inline comments. Comment at: clang/include/clang/Tooling/Refactoring/Rename/SymbolOccurrences.h:81 + union { +SourceRange SingleRange; +unsigned NumRanges; simon_tatham wrote: > This surely relies on `SourceRange` having no

[PATCH] D93630: [Attr] Apply GNU-style attributes to expression statements

vsavchenko added a comment. In D93630#2506604 , @aaron.ballman wrote: > In D93630#2504758 , @vsavchenko > wrote: > >> I'll clean up the tests! But, unfortunately, I couldn't proceed with GCC >> folks. I asked

[PATCH] D94871: [Clang][OpenMP] Fixed an issue that clang crashed when compiling OpenMP program in device only mode without host IR

tianshilei1992 added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:2944-2947 +// This could happen if the device compilation is invoked standalone. +if (!hasTargetRegionEntryInfo(DeviceID, FileID, ParentName, LineNum)) +

[PATCH] D94877: Add API to retrieve a clade kind from ASTNodeKind

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM aside from the use of `auto`. Comment at: clang/lib/AST/ASTTypeTraits.cpp:67 +ASTNodeKind ASTNodeKind::getCladeKind() const { + auto LastId = KindId; +

[PATCH] D94878: Make it possible to store a ASTNodeKind in VariantValue

aaron.ballman added a comment. I assume the test coverage for this change is from existing tests that are being updated as part of another patch? Or is there test coverage missing for this change? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D94952: [clangd] Take into account what is in the index (symbols, references, etc.) at indexes merge

ArcsinX updated this revision to Diff 317521. ArcsinX added a comment. Prevent crash in debug mode. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94952/new/ https://reviews.llvm.org/D94952 Files:

[PATCH] D94864: [ASTMatchers] Re-order the internals to allow another use-case

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, though it would have been a bit easier to review had the rearranging been done in a separate NFC patch. Comment at:

[PATCH] D94876: Remove TypedMatcherOps from VariantValue

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. I did some digging to see why this was added in the first place and it came with the original commit of AST matchers. Thank you for the cleanup, LGTM! Repository: rG LLVM

[libunwind] 480643a - [CMake] Remove dead code setting policies to NEW

Author: Raul Tambre Date: 2021-01-19T17:19:36+02:00 New Revision: 480643a95cd157e654f4f97e8231b18850e7d79a URL: https://github.com/llvm/llvm-project/commit/480643a95cd157e654f4f97e8231b18850e7d79a DIFF: https://github.com/llvm/llvm-project/commit/480643a95cd157e654f4f97e8231b18850e7d79a.diff

[PATCH] D94624: PATCH] [clang-query] Add a --use-color option to clang-query to allow forcing the behavior

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. In D94624#2501894 , @tomrittervg wrote: > I started trying to work on a patch, but I'm still unpacking from a move and > don't have all

[clang] 480643a - [CMake] Remove dead code setting policies to NEW

Author: Raul Tambre Date: 2021-01-19T17:19:36+02:00 New Revision: 480643a95cd157e654f4f97e8231b18850e7d79a URL: https://github.com/llvm/llvm-project/commit/480643a95cd157e654f4f97e8231b18850e7d79a DIFF: https://github.com/llvm/llvm-project/commit/480643a95cd157e654f4f97e8231b18850e7d79a.diff

[PATCH] D92715: [Clang][RISCV] Define RISC-V V builtin types

HsiangKai updated this revision to Diff 316854. HsiangKai added a comment. According to "9. Vector Memory Alignment Constraints" in V specification, change the alignment of RVV types to the element size. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D81678: Introduce noundef attribute at call sites for stricter poison analysis

nikic added a comment. As the discussion is spread out across multiple threads, do I understand correctly that the current consensus is to introduce the `-disable-noundef-analysis` flag, and explicitly add it to all the relevant tests (rather than adding it to the substitutions)? In any case,

[PATCH] D92715: [Clang][RISCV] Define RISC-V V builtin types

HsiangKai added a comment. Ping. If we all agree to use builtin types to model RVV types, is there any other issues we need to address in this patch? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92715/new/ https://reviews.llvm.org/D92715

[PATCH] D94374: [CMake] Remove dead code setting policies to NEW

tambre marked an inline comment as done. tambre added a comment. ldionne: ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94374/new/ https://reviews.llvm.org/D94374 ___ cfe-commits mailing list

[PATCH] D94374: [CMake] Remove dead code setting policies to NEW

ldionne accepted this revision. ldionne added a comment. This revision is now accepted and ready to land. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94374/new/ https://reviews.llvm.org/D94374

[PATCH] D94785: [clangd] Index local classes, virtual and overriding methods.

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. Thanks, looks good! if you don't mind, could you rerun the benchmark (we have a behavior changes from original version, I guess it won't not change significantly)? and update the data in the

[PATCH] D92797: APINotes: add initial stub of APINotesWriter

martong accepted this revision. martong added a comment. This revision is now accepted and ready to land. In D92797#2505254 , @compnerd wrote: > Ping x 3 Sorry, just came back from holidays. Generally, I have no major concerns. My minor concern is that

[PATCH] D94614: [FPEnv][X86] Platform builtins edition: clang should get from the AST the metadata for constrained FP builtins

kpn added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:12268 + case X86::BI__builtin_ia32_cvtqq2pd512_mask: { +CodeGenFunction::CGFPOptionsRAII FPOptsRAII(*this, E); return EmitX86ConvertIntToFp(*this, Ops, /*IsSigned*/true); pengfei

[PATCH] D94785: [clangd] Index local classes, virtual and overriding methods.

This revision was automatically updated to reflect the committed changes. Closed by commit rG8bf7116d50bf: [clangd] Index local classes, virtual and overriding methods. (authored by usaxena95). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang-tools-extra] 8bf7116 - [clangd] Index local classes, virtual and overriding methods.

Author: Utkarsh Saxena Date: 2021-01-19T16:18:48+01:00 New Revision: 8bf7116d50bfe8cb881273798ff384ed965c05e9 URL: https://github.com/llvm/llvm-project/commit/8bf7116d50bfe8cb881273798ff384ed965c05e9 DIFF:

[PATCH] D94067: [clang][ASTImporter] Fix a possible assertion failure `NeedsInjectedClassNameType(Decl)'.

martong added a comment. @balazske Thanks Balázs! Great work! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94067/new/ https://reviews.llvm.org/D94067 ___ cfe-commits mailing list

[PATCH] D94786: [clang][ASTImporter] Add support for importing CXXFoldExpr.

martong accepted this revision. martong added a comment. This revision is now accepted and ready to land. Looks good to me! Thanks! Comment at: clang/lib/AST/ASTImporter.cpp:8019 + auto ToType = importChecked(Err, E->getType()); + auto ToCallee = importChecked(Err,

[PATCH] D94374: [CMake] Remove dead code setting policies to NEW

This revision was automatically updated to reflect the committed changes. Closed by commit rG480643a95cd1: [CMake] Remove dead code setting policies to NEW (authored by tambre). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94374/new/

[PATCH] D94973: [clang][OpenMP] Use OpenMPIRBuilder for workshare loops.

Meinersbur created this revision. Meinersbur added reviewers: jdoerfert, AMDChirag, anchu-rajendran, kiranchandramohan, SouraVX, ftynse, kiranktp, fghanim, ABataev. Meinersbur added projects: OpenMP, clang. Herald added subscribers: dexonsmith, rriddle, arphaman, guansong, hiraditya, yaxunl.

[PATCH] D94871: [Clang][OpenMP] Fixed an issue that clang crashed when compiling OpenMP program in device only mode without host IR

jdoerfert added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:2944-2947 +// This could happen if the device compilation is invoked standalone. +if (!hasTargetRegionEntryInfo(DeviceID, FileID, ParentName, LineNum)) +

[PATCH] D92808: [ObjC][ARC] Annotate calls with attributes instead of emitting retainRV or claimRV calls in the IR

ahatanak added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92808/new/ https://reviews.llvm.org/D92808 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D94979: [CGExpr] Honor getCharWidth() in ConstantAggregateBuilderUtils

bjope created this revision. bjope requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. In CGExprConstant.cpp, when dealing with padding etc, some sizes are calculated as char units. But then the type used when creating the aggregate expression

[PATCH] D94979: [CGExpr] Honor getCharWidth() in ConstantAggregateBuilderUtils

lebedev.ri added subscribers: jfb, lebedev.ri. lebedev.ri added a comment. As far as i recall, all RFC's about LLVM support for non-8-bit char targets didn't end in favor of the proposal I'd say that until there's general consensus/buy-in (including testing path), cleaning stuff up will only

[PATCH] D85223: [CUDA][HIP] Support accessing static device variable in host code for -fgpu-rdc

tra added a comment. I'd propose splitting the patch into two. One with the addition of CUID and the other that changes the way we havdle static vars. CUID is useful on its own and is relatively uncontroversial. Externalizing static vars is a more interesting issue and I'm not sure what's the

[PATCH] D94987: DR39: Perform ambiguous subobject checks for class member access as part of object argument conversion, not as part of name lookup.

rjmccall added a comment. (I didn't mean to submit the last comment before I finished the review, sorry) It looks like you've chosen to treat this as a DR that we should apply under all standards. Have you investigated whether it causes compatibility problems? It does look like it'd be

[PATCH] D94977: [CodeGen] Honor getCharWidth() in CGRecordLowering

bjope created this revision. bjope requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. When using getByteArrayType the requested size was calculated in char units, but the type used for the array was hardcoded to the Int8Ty. Honor the size of

[PATCH] D94986: Remove requirement for -maltivec to be used when using -mabi=vec-extabi or -mabi=vec-default when not using vector code

ZarkoCA created this revision. ZarkoCA added reviewers: cebowleratibm, hubert.reinterpretcast, sfertile, Xiangling_L, etiotto. ZarkoCA requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. If we are not using vector code `-maltivec` should not

[clang-tools-extra] 17846ed - [clangd] Use ASTSignals in Heuristics CC Ranking.

Author: Utkarsh Saxena Date: 2021-01-19T19:48:42+01:00 New Revision: 17846ed5af4a83334ef7d07f0b4a9d525e6ec0db URL: https://github.com/llvm/llvm-project/commit/17846ed5af4a83334ef7d07f0b4a9d525e6ec0db DIFF:

[PATCH] D94987: DR39: Perform ambiguous subobject checks for class member access as part of object argument conversion, not as part of name lookup.

rjmccall added a comment. How does this new rule work if we find overlapping but non-equal sets of declarations in different subobjects? I'm sure you can get that with `using` declarations. Comment at: clang/include/clang/AST/CXXInheritance.h:77 - CXXBasePath() =

[PATCH] D94854: [Clang] Fix SwiftCallingConv's aggregate lowering for _Atomic(_Bool).

varungandhi-apple abandoned this revision. varungandhi-apple added a comment. Closing this in favor of a Swift-side fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94854/new/ https://reviews.llvm.org/D94854

[PATCH] D93668: [clang] Override the Fuchsia platform ABI using the triple environment

leonardchan added a comment. In D93668#2492081 , @phosek wrote: > I agree that if we want to allow selecting C++ ABI only, a flag like > `-fc++abi=` with some additional checks to disallow invalid combinations is > better. The question is whether we

[PATCH] D94927: [clangd] Use ASTSignals in Heuristics CC Ranking.

usaxena95 updated this revision to Diff 317613. usaxena95 marked an inline comment as done. usaxena95 added a comment. Added a comment about the calculation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94927/new/ https://reviews.llvm.org/D94927

[PATCH] D94979: [CGExpr] Honor getCharWidth() in ConstantAggregateBuilderUtils

bjope added a comment. In D94979#2507242 , @lebedev.ri wrote: > As far as i recall, all RFC's about LLVM support for non-8-bit char targets > didn't end in favor of the proposal > I'd say that until there's general consensus/buy-in (including testing

[PATCH] D94987: DR39: Perform ambiguous subobject checks for class member access as part of object argument conversion, not as part of name lookup.

rsmith created this revision. rsmith added a reviewer: rjmccall. rsmith requested review of this revision. Herald added a project: clang. Under C++ core issue 39, the rules for class-scope name lookup were reworked so that name lookup no longer concerns itself with whether the names were found in

[PATCH] D94599: [clang][Tooling] Get rid of a hack in SymbolOccurrences, NFCI

miyuki updated this revision to Diff 317627. miyuki edited the summary of this revision. miyuki added a comment. Added `static_assert`s that check that `SourceRange` and `SourceLocation` are trivially destructible. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D94871: [Clang][OpenMP] Fixed an issue that clang crashed when compiling OpenMP program in device only mode without host IR

This revision was automatically updated to reflect the committed changes. Closed by commit rG82e537a9d28a: [Clang][OpenMP] Fixed an issue that clang crashed when compiling OpenMP program… (authored by tianshilei1992). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 82e537a - [Clang][OpenMP] Fixed an issue that clang crashed when compiling OpenMP program in device only mode without host IR

Author: Shilei Tian Date: 2021-01-19T14:18:42-05:00 New Revision: 82e537a9d28a2c18bd1637e2eac0e0af658ed829 URL: https://github.com/llvm/llvm-project/commit/82e537a9d28a2c18bd1637e2eac0e0af658ed829 DIFF: https://github.com/llvm/llvm-project/commit/82e537a9d28a2c18bd1637e2eac0e0af658ed829.diff

[PATCH] D86465: [analyzer][solver] Redesign constraint ranges data structure

ASDenysPetrov added a comment. I didn't check correctness of each Factory function but if it passes all tests and improves performance, I think it's enough. Comment at: clang/include/clang/StaticAnalyzer/Core/PathSensitive/RangedConstraintManager.h:77-78 + // + // *

[clang] 6f69f2e - Consider ASan messages interesting for creduce

Author: Reid Kleckner Date: 2021-01-19T11:15:02-08:00 New Revision: 6f69f2ed61ae805df496fc86ef22e7685573d556 URL: https://github.com/llvm/llvm-project/commit/6f69f2ed61ae805df496fc86ef22e7685573d556 DIFF: https://github.com/llvm/llvm-project/commit/6f69f2ed61ae805df496fc86ef22e7685573d556.diff

[clang] e678656 - Add bounds checking assertions to APValue, NFC

Author: Reid Kleckner Date: 2021-01-19T11:15:02-08:00 New Revision: e678656625a3e2b6a5f2849f4a6f7612ceeaed07 URL: https://github.com/llvm/llvm-project/commit/e678656625a3e2b6a5f2849f4a6f7612ceeaed07 DIFF: https://github.com/llvm/llvm-project/commit/e678656625a3e2b6a5f2849f4a6f7612ceeaed07.diff

[PATCH] D94884: [Clang][OpenMP] Include header for CUDA builtin vars into OpenMP wrapper header

tianshilei1992 updated this revision to Diff 317647. tianshilei1992 added a comment. Refined the patch to make it only work in C++ mode. In C mode everything is unchanged. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94884/new/

[PATCH] D94884: [Clang][OpenMP] Include header for CUDA builtin vars into OpenMP wrapper header

tianshilei1992 marked 2 inline comments as done. tianshilei1992 added inline comments. Comment at: clang/lib/Headers/__clang_cuda_builtin_vars.h:40 +#ifdef __cplusplus #define __CUDA_DEVICE_BUILTIN(FIELD, INTRINSIC) \ tra

[PATCH] D91630: [Parse] Add parsing support for C++ attributes on using-declarations

ldionne added a comment. Gentle ping! Can we merge this? I'd love to move forward with https://reviews.llvm.org/D90257. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91630/new/ https://reviews.llvm.org/D91630 ___ cfe-commits mailing list

[PATCH] D94624: PATCH] [clang-query] Add a --use-color option to clang-query to allow forcing the behavior

aaron.ballman added a comment. In D94624#2506906 , @tomrittervg wrote: > In D94624#2506831 , @aaron.ballman > wrote: > >> In D94624#2501894 , @tomrittervg >> wrote: >> >>>

[PATCH] D94472: [WIP][clang][cli] Command line round-trip for HeaderSearch options

jansvoboda11 added a comment. Thanks for putting your time into the comment, @dexonsmith. I agree that adding a `-round-trip-args` flag to enable/disable round-tripping is more sensible than hard-coding it via something like `#ifndef NDEBUG`. Providing `-round-trip-args-debug-mode` to help with

[PATCH] D94927: [clangd] Use ASTSignals in Heuristics CC Ranking.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG17846ed5af4a: [clangd] Use ASTSignals in Heuristics CC Ranking. (authored by usaxena95). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D93585: [AArch64] Enable out-of-line atomics by default.

t.p.northover added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64.td:1087 FeatureNEON, + FeatureOutlineAtomics, FeaturePerfMon, ilinpv wrote: > t.p.northover wrote: > > I think this

[PATCH] D94884: [Clang][OpenMP] Include header for CUDA builtin vars into OpenMP wrapper header

tra added inline comments. Comment at: clang/lib/Headers/__clang_cuda_builtin_vars.h:40 +#ifdef __cplusplus #define __CUDA_DEVICE_BUILTIN(FIELD, INTRINSIC) \ Perhaps we should move all C++-related code under `#ifdef

[clang] 987760b - [www] Fix background color in table cell.

Author: Richard Smith Date: 2021-01-19T11:04:31-08:00 New Revision: 987760b463c1303121fff8197c4ebc66b61f0616 URL: https://github.com/llvm/llvm-project/commit/987760b463c1303121fff8197c4ebc66b61f0616 DIFF: https://github.com/llvm/llvm-project/commit/987760b463c1303121fff8197c4ebc66b61f0616.diff

[PATCH] D94871: [Clang][OpenMP] Fixed an issue that clang crashed when compiling OpenMP program in device only mode without host IR

tianshilei1992 marked 6 inline comments as done. tianshilei1992 added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:2944-2947 +// This could happen if the device compilation is invoked standalone. +if (!hasTargetRegionEntryInfo(DeviceID, FileID,

[PATCH] D94871: [Clang][OpenMP] Fixed an issue that clang crashed when compiling OpenMP program in device only mode without host IR

ABataev added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:2944-2947 +// This could happen if the device compilation is invoked standalone. +if (!hasTargetRegionEntryInfo(DeviceID, FileID, ParentName, LineNum)) +

[PATCH] D94941: Add minor version to libclang.so and libclang-cpp.so SONAME

dim added a comment. @sylvestre.ledru removed the minor version from the binary (on purpose, I think?) in rGa8b717fda42294d1c8e1f05d71280503e5839f14 : commit a8b717fda42294d1c8e1f05d71280503e5839f14 Author: Sylvestre

[PATCH] D92191: [clang-scan-deps] Add support for clang-cl

saudi added a comment. Ping! Would anybody have a chance to take a look at this? I'd like to submit this before the LLVM 12 branch, if possible? Thanks in advance! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92191/new/ https://reviews.llvm.org/D92191

[PATCH] D94391: CGDebugInfo: Drop Loc.isInvalid() special case from getLineNumber

MaskRay added a comment. In D94391#2495056 , @dblaikie wrote: > I'll leave this one to @aprantl @aprantl :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94391/new/ https://reviews.llvm.org/D94391

[PATCH] D90188: Add support for attribute 'using_if_exists'

Quuxplusone added inline comments. Comment at: clang/test/SemaCXX/using-if-exists.cpp:11 + +using NotNS::x UIE; // expected-error{{use of undeclared identifier 'NotNS'}} +} // test_basic Do you also have a test for `using NS::NotNS::x UIE;`? (Both of these

[PATCH] D94884: [Clang][OpenMP] Include header for CUDA builtin vars into OpenMP wrapper header

tra accepted this revision. tra added a comment. This revision is now accepted and ready to land. LGTM for `__clang_cuda_builtin_vars.h`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94884/new/ https://reviews.llvm.org/D94884

[PATCH] D93844: [clang-format] Add possibility to be based on parent directory

HazardyKnusperkeks updated this revision to Diff 317679. HazardyKnusperkeks added a comment. Found and fixed the case when no `BasedOnStyle` apart from `InheritParentConfig` is used. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93844/new/

[PATCH] D94884: [Clang][OpenMP] Include header for CUDA builtin vars into OpenMP wrapper header

tianshilei1992 added a comment. In D94884#2508000 , @JonChesterfield wrote: > Note that a cuda-free openmp devicertl compilation doesn't require this > patch, or any other pieces of cuda headers. Yes, we can write all code with CUDA built-in or others

[PATCH] D94864: [ASTMatchers] Re-order the internals to allow another use-case

This revision was automatically updated to reflect the committed changes. Closed by commit rGecf696641e6c: [ASTMatchers] Allow use of mapAnyOf in more contexts (authored by stephenkelly). Changed prior to commit: https://reviews.llvm.org/D94864?vs=317175=317690#toc Repository: rG LLVM

[PATCH] D94986: Remove requirement for -maltivec to be used when using -mabi=vec-extabi or -mabi=vec-default when not using vector code

cebowleratibm added inline comments. Comment at: clang/test/CodeGen/altivec.c:1 // RUN: %clang_cc1 -target-feature +altivec -triple powerpc-unknown-unknown -emit-llvm %s -o - | FileCheck %s --check-prefixes=CHECK,CHECK-BE // RUN: %clang_cc1 -target-feature +altivec -triple

[PATCH] D93978: [clangd] DefineOutline doesn't require implementation file being saved

njames93 planned changes to this revision. njames93 added a comment. I've decided I much prefer the implementation in D94554 , So once thats cleaned up and split up, I'll merge changes in here with there. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D95001: [CodeView] Emit function types in -gline-tables-only.

akhuang updated this revision to Diff 317718. akhuang marked an inline comment as done. akhuang added a comment. Add check for CodeView Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95001/new/ https://reviews.llvm.org/D95001 Files:

[PATCH] D95001: [CodeView] Emit function types in -gline-tables-only.

akhuang added inline comments. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:1050-1052 + // Don't include a linkage name in line tables only, except to differentiate + // between lambdas. + if (CGM.getCodeGenOpts().hasReducedDebugInfo() || RD->isLambda())

[PATCH] D94884: [Clang][OpenMP] Include header for CUDA builtin vars into OpenMP wrapper header

tra added inline comments. Comment at: clang/lib/Headers/__clang_cuda_builtin_vars.h:31 +#ifdef __OPENMP_NVPTX__ +#define DEVICE +#else You should use `__` prefix to avoid unintentional clashes with user-defined macros. `__DEVICE__` ? Comment

[clang] da98651 - Revert "DR2064: decltype(E) is only a dependent type if E is type-dependent, not

Author: Richard Smith Date: 2021-01-19T12:48:40-08:00 New Revision: da986511fb9da1a46a0ca4dba2e49e2426036303 URL: https://github.com/llvm/llvm-project/commit/da986511fb9da1a46a0ca4dba2e49e2426036303 DIFF: https://github.com/llvm/llvm-project/commit/da986511fb9da1a46a0ca4dba2e49e2426036303.diff

[PATCH] D93585: [AArch64] Enable out-of-line atomics by default.

jgreenhalgh added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64.td:1087 FeatureNEON, + FeatureOutlineAtomics, FeaturePerfMon, t.p.northover wrote: > ilinpv wrote: > > t.p.northover

[PATCH] D94814: [HIP] Support `__managed__` attribute

tra added a comment. Presumably, `__managed__` variables would have to be memory-mapped into the host address space. Comment at: clang/lib/CodeGen/CGCUDANV.cpp:391 + SmallVector, 8> WorkList; + for (auto & : Var->uses()) { +WorkList.push_back({UU.getUser()});

[PATCH] D95002: [RISCV] Update B extension version to 0.93.

craig.topper created this revision. craig.topper added reviewers: asb, luismarques, frasercrmck, lewis-revill, simoncook, PaoloS, kito-cheng. Herald added subscribers: NickHung, evandro, apazos, sameer.abuasal, pzheng, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult,

[PATCH] D92797: APINotes: add initial stub of APINotesWriter

compnerd added a comment. Welcome back, hope you had a good time off. Thanks for the review! Comment at: clang/lib/APINotes/APINotesWriter.cpp:35 + bool SwiftImportAsMember = false; +#endif + martong wrote: > compnerd wrote: > > Please ignore this

[PATCH] D95001: [CodeView] Emit function types in -gline-tables-only.

akhuang updated this revision to Diff 317701. akhuang added a comment. Remove lambda change Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95001/new/ https://reviews.llvm.org/D95001 Files: clang/lib/CodeGen/CGDebugInfo.cpp

[PATCH] D94879: Implement dynamic mapAnyOf in terms of ASTNodeKinds

steveire updated this revision to Diff 317705. steveire added a comment. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94879/new/ https://reviews.llvm.org/D94879 Files: clang/lib/ASTMatchers/Dynamic/Marshallers.h Index:

[PATCH] D85223: [CUDA][HIP] Support accessing static device variable in host code for -fgpu-rdc

yaxunl updated this revision to Diff 317712. yaxunl edited the summary of this revision. yaxunl added a comment. separate CUID patch. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85223/new/ https://reviews.llvm.org/D85223 Files: clang/lib/AST/ASTContext.cpp

  1   2   >