[PATCH] D64146: [Clang Interpreter] Initial patch for the constexpr interpreter

jrtc27 added a comment. In D64146#2567710 , @nand wrote: > CodePtr points into the bytecode emitted by the byte code compiler. In some > instances, pointers to auxiliary data structures are embedded into the byte > code, such as functions or AST nodes

[PATCH] D64146: [Clang Interpreter] Initial patch for the constexpr interpreter

jrtc27 added a comment. In D64146#2591830 , @jrtc27 wrote: > In D64146#2591732 , @jrtc27 wrote: > >> In D64146#2567710 , @nand wrote: >> >>> CodePtr points into the bytecode

[PATCH] D97606: [Clang interpreter] Avoid storing pointers at unaligned locations

jrtc27 added a comment. Is there any way I can usefully test this? As far as I can tell there's only a single constexpr test in the tree that uses the new interpreter, and it's pretty trivial? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D97577: [clang-tidy] performance-for-range-copy: Don't trigger on implicit type conversions.

flx created this revision. flx added reviewers: aaron.ballman, alexfh, sbenza. Herald added a subscriber: xazax.hun. flx requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This disables the check for false positive cases where implicit type

[PATCH] D97449: [Diagnose] Unify MCContext and LLVMContext diagnosing

ychen updated this revision to Diff 326797. ychen added a comment. - Simplify MCContext changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97449/new/ https://reviews.llvm.org/D97449 Files: clang/lib/CodeGen/CodeGenAction.cpp

[PATCH] D97447: Add GNU attribute 'retain'

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8afdacba9dcd: Add GNU attribute retain (authored by MaskRay). Changed prior to commit: https://reviews.llvm.org/D97447?vs=326766=326839#toc

[clang] 8afdacb - Add GNU attribute 'retain'

Author: Fangrui Song Date: 2021-02-26T16:37:50-08:00 New Revision: 8afdacba9dcd36fc838eb86fca86f7f903040030 URL: https://github.com/llvm/llvm-project/commit/8afdacba9dcd36fc838eb86fca86f7f903040030 DIFF: https://github.com/llvm/llvm-project/commit/8afdacba9dcd36fc838eb86fca86f7f903040030.diff

[PATCH] D97605: [Lifetimes] Fix false positive warning from BUG 49342

xazax.hun created this revision. xazax.hun added reviewers: rsmith, mgehre. xazax.hun added a project: clang. Herald added subscribers: Charusso, gamesh411, Szelethus, dkrupp, rnkovacs. xazax.hun requested review of this revision. Herald added a subscriber: cfe-commits. After some interaction

[clang] 2e2ee43 - [test] Add -triple x86_64 to attr-retain.cpp

Author: Fangrui Song Date: 2021-02-26T19:35:53-08:00 New Revision: 2e2ee4300d1f9766209d435c0d8c44c72092b974 URL: https://github.com/llvm/llvm-project/commit/2e2ee4300d1f9766209d435c0d8c44c72092b974 DIFF: https://github.com/llvm/llvm-project/commit/2e2ee4300d1f9766209d435c0d8c44c72092b974.diff

[PATCH] D97577: [clang-tidy] performance-for-range-copy: Don't trigger on implicit type conversions.

flx updated this revision to Diff 326793. flx added a comment. Remove include. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97577/new/ https://reviews.llvm.org/D97577 Files: clang-tools-extra/clang-tidy/performance/ForRangeCopyCheck.cpp

[clang] 233ba27 - [Driver] Fix a warning about the the initialization order

Author: Kazu Hirata Date: 2021-02-26T16:32:30-08:00 New Revision: 233ba2709bde54ea820cdaba0405d46b2c197e01 URL: https://github.com/llvm/llvm-project/commit/233ba2709bde54ea820cdaba0405d46b2c197e01 DIFF: https://github.com/llvm/llvm-project/commit/233ba2709bde54ea820cdaba0405d46b2c197e01.diff

[PATCH] D97577: [clang-tidy] performance-for-range-copy: Don't trigger on implicit type conversions.

lebedev.ri added a comment. It is best not to change existing tests, but add new ones. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97577/new/ https://reviews.llvm.org/D97577 ___ cfe-commits mailing

[PATCH] D94973: [clang][OpenMP] Use OpenMPIRBuilder for workshare loops.

jdenny added a comment. In D94973#2591210 , @Meinersbur wrote: > In D94973#2590867 , @jdenny wrote: > >> One property of this patch that has bothered me is that OMPCanonicalLoop is >> not a loop. Instead, it's an

[clang] a0c1cd6 - [test] Add -triple x86_64 to attr-retain.c

Author: Fangrui Song Date: 2021-02-26T17:26:26-08:00 New Revision: a0c1cd642da51ab8f471d2dd5ba905cf81760187 URL: https://github.com/llvm/llvm-project/commit/a0c1cd642da51ab8f471d2dd5ba905cf81760187 DIFF: https://github.com/llvm/llvm-project/commit/a0c1cd642da51ab8f471d2dd5ba905cf81760187.diff

[PATCH] D97449: [Diagnose] Unify MCContext and LLVMContext diagnosing

nickdesaulniers added a comment. I tested this on some wacko LTO kernel build failure (https://github.com/ClangBuiltLinux/linux/issues/1269). The error message went from: > :0: error: __ia32_compat_sys_sysctl changed binding to STB_GLOBAL To: unimplemented UNREACHABLE executed at

[PATCH] D97608: Move EntryExitInstrumentation pass location

aeubanks created this revision. Herald added subscribers: nikic, pengfei, hiraditya. aeubanks requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. This seems to be more of a Clang thing rather than a generic LLVM thing, so

[PATCH] D97567: [clang-tidy] performance-* checks: Also allow allow member expressions to be used in a const manner.

flx updated this revision to Diff 326798. flx added a comment. Add tests for PerformanceUnnecssaryCopyInitialization check which actually uses decl_ref_expr::isOnlyUsedAsConst(). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97567/new/

[PATCH] D97606: [Clang interpreter] Avoid storing pointers at unaligned locations

jrtc27 updated this revision to Diff 326872. jrtc27 added a comment. Reworked code slightly to make it look nicer after clang-format uglified it Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97606/new/ https://reviews.llvm.org/D97606 Files:

[PATCH] D97577: [clang-tidy] performance-for-range-copy: Don't trigger on implicit type conversions.

flx updated this revision to Diff 326792. flx added a comment. Remove include. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97577/new/ https://reviews.llvm.org/D97577 Files: clang-tools-extra/clang-tidy/performance/ForRangeCopyCheck.cpp

[PATCH] D96120: [scudo] Port scudo sanitizer to Windows

vitalybuka added a comment. >> This is intended as a step to porting scudo standalone. Why this is needed for scudo stadalone? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96120/new/ https://reviews.llvm.org/D96120

[PATCH] D64146: [Clang Interpreter] Initial patch for the constexpr interpreter

jrtc27 added a comment. In D64146#2591732 , @jrtc27 wrote: > In D64146#2567710 , @nand wrote: > >> CodePtr points into the bytecode emitted by the byte code compiler. In some >> instances, pointers to auxiliary

[PATCH] D97411: [DebugInfo] Add an attribute to force type info to be emitted for types that are required to be complete.

akhuang updated this revision to Diff 326787. akhuang marked 3 inline comments as done. akhuang added a comment. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97411/new/ https://reviews.llvm.org/D97411 Files:

[PATCH] D94973: [clang][OpenMP] Use OpenMPIRBuilder for workshare loops.

Meinersbur added a comment. In D94973#2590867 , @jdenny wrote: > One property of this patch that has bothered me is that OMPCanonicalLoop is > not a loop. Instead, it's an AST node that is sandwiched between a directive > and a loop to contain extra

[PATCH] D95409: [clang] implicitly delete space ship operator with function pointers

This revision was automatically updated to reflect the committed changes. Closed by commit rG4a8530fc3039: [clang] implicitly delete space ship operator with function pointers (authored by mizvekov, committed by rsmith). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 4a8530f - [clang] implicitly delete space ship operator with function pointers

Author: Matheus Izvekov Date: 2021-02-26T16:03:01-08:00 New Revision: 4a8530fc3039f128eddc38737f0172bb3d489bcf URL: https://github.com/llvm/llvm-project/commit/4a8530fc3039f128eddc38737f0172bb3d489bcf DIFF:

[clang] 155c49e - [Driver] Print process statistics report on CC_PRINT_PROC_STAT env variable.

Author: Vladimir Vereschaka Date: 2021-02-26T16:16:00-08:00 New Revision: 155c49e0878de667b8021b9ba685390151dee11e URL: https://github.com/llvm/llvm-project/commit/155c49e0878de667b8021b9ba685390151dee11e DIFF:

[PATCH] D97094: [Driver] Print process statistics report on CC_PRINT_PROC_STAT env variable.

This revision was automatically updated to reflect the committed changes. Closed by commit rG155c49e0878d: [Driver] Print process statistics report on CC_PRINT_PROC_STAT env variable. (authored by vvereschaka). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 9e0d550 - [clang][NFC] Clean up whitespace in ClangOpcodesEmitter output

Author: Jessica Clarke Date: 2021-02-27T01:28:56Z New Revision: 9e0d55024d4ed776f209ee04e260bdd314854993 URL: https://github.com/llvm/llvm-project/commit/9e0d55024d4ed776f209ee04e260bdd314854993 DIFF: https://github.com/llvm/llvm-project/commit/9e0d55024d4ed776f209ee04e260bdd314854993.diff

[PATCH] D97449: [Diagnose] Unify MCContext and LLVMContext diagnosing

MaskRay added a comment. I am supportive of getting rid of InlineAsmDiagnosticHandler, too. The updated AMDGPU tests suggeste that previously `MCContext::reportError` may be called with no `SrcMgr` or `InlineSrcMgr`, so the error is propagated to the temporary `SourceMgr()`. The

[PATCH] D97606: [Clang interpreter] Avoid storing pointers at unaligned locations

jrtc27 created this revision. jrtc27 added reviewers: nand, jfb, Bigcheese, rsmith, dexonsmith. Herald added subscribers: kristof.beyls, arichardson. jrtc27 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The Clang interpreter's bytecode

[PATCH] D96120: [scudo] Port scudo sanitizer to Windows

mstorsjo added a comment. In D96120#2590587 , @russell.gallop wrote: > Hi @mstorsjo. Thanks for the suggestions. I tried running up an mingw > environment with msys but had trouble getting it working (running into cmake > issues). Would you be able to

[PATCH] D97417: [clangd] use a compatible preamble for the first AST built

qchateau updated this revision to Diff 326816. qchateau added a comment. - [clangd] make more compile commands compatible - [clangd] ignore incompatible preamble I improved command line compatibility detection (faster & matches more files) and I had to blacklist some preambles. Namely, when

[PATCH] D97449: [Diagnose] Unify MCContext and LLVMContext diagnosing

MaskRay added inline comments. Comment at: clang/lib/CodeGen/CodeGenAction.cpp:477 + StringRef Message = D.getMessage(); + if (Message.startswith("error: ")) +Message = Message.substr(7); `StringRef::consume_front` I know you are moving code, but do you

[PATCH] D96803: EntryExitInstrumenter: Enable at all optimization levels (PR49143)

aeubanks added a comment. Alternatively: https://reviews.llvm.org/D97608 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96803/new/ https://reviews.llvm.org/D96803 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D97535: [clangd] Use URIs instead of paths in the index file list

ArcsinX created this revision. Herald added subscribers: usaxena95, kadircet, arphaman. ArcsinX requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang. Without this patch the file list of the index is derived from the keys,

[PATCH] D97361: [clang-tidy] Add readability-redundant-using check

balazske added a comment. You can look into **misc/UnusedUsingDeclsCheck.cpp** (if not done yet), that check handles `using` too. And that check is related to this check, the module should be the same too (`misc`)? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D97534: SEH: capture 'this'

ogoffart created this revision. ogoffart added reviewers: rnk, asl, cfe-commits. ogoffart requested review of this revision. Herald added a project: clang. Simply make sure that the CodeGenFunction::CXXThisValue and CXXABIThisValue are correctly initialized to the recovered value. For lambda

[clang] e9475a2 - [Sema] Fix MSVC "attribute is not recognized" warning (NFC)

Author: Yang Fan Date: 2021-02-26T17:28:24+08:00 New Revision: e9475a276267f1bc74d9624fc797c7a754b5b90b URL: https://github.com/llvm/llvm-project/commit/e9475a276267f1bc74d9624fc797c7a754b5b90b DIFF: https://github.com/llvm/llvm-project/commit/e9475a276267f1bc74d9624fc797c7a754b5b90b.diff

[PATCH] D97536: [clangd][remote] Add flag to set idletimeout

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: usaxena95, arphaman. kadircet requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang. By default gRPC has no idletimeout and

[PATCH] D97535: [clangd] Use URIs instead of paths in the index file list

ArcsinX added reviewers: sammccall, kadircet, hokein. ArcsinX added a comment. Initial discussion D94952#inline-892421 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97535/new/

[PATCH] D97536: [clangd][remote] Add flag to set idletimeout

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/index/remote/server/Server.cpp:84 +llvm::cl::opt IdleTimeoutSeconds( +"idle-timeout", llvm::cl::init(10), +

[PATCH] D97536: [clangd][remote] Add flag to set idletimeout

kadircet updated this revision to Diff 326632. kadircet marked an inline comment as done. kadircet added a comment. Change 10 seconds to 600 seconds. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97536/new/ https://reviews.llvm.org/D97536 Files:

[PATCH] D97536: [clangd][remote] Add flag to set idletimeout

kadircet added inline comments. Comment at: clang-tools-extra/clangd/index/remote/server/Server.cpp:84 +llvm::cl::opt IdleTimeoutSeconds( +"idle-timeout", llvm::cl::init(10), +llvm::cl::desc("Maximum time a channel may stay idle until server closes "

[PATCH] D97493: [clang][NFC] Extract Target and AuxTarget creation in CompilerInstance to new function

This revision was automatically updated to reflect the committed changes. Closed by commit rGd412dbe38881: [clang][NFC] Extract Target and AuxTarget creation in CompilerInstance to new… (authored by oToToT, committed by sammccall). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang] d412dbe - [clang][NFC] Extract Target and AuxTarget creation in CompilerInstance to new function

Author: Yu-Hsun Chiang Date: 2021-02-26T09:29:11+01:00 New Revision: d412dbe388819dd68bbe4a3967783fdf80400860 URL: https://github.com/llvm/llvm-project/commit/d412dbe388819dd68bbe4a3967783fdf80400860 DIFF:

[PATCH] D94661: [clang-format] [PR19056] Add support for access modifiers indentation

This revision was automatically updated to reflect the committed changes. Closed by commit rG2a42c759ae7b: [clang-format] [PR19056] Add support for access modifiers indentation (authored by Budovi, committed by curdeius). Changed prior to commit:

[clang] 2a42c75 - [clang-format] [PR19056] Add support for access modifiers indentation

Author: Jakub Budiský Date: 2021-02-26T09:17:07+01:00 New Revision: 2a42c759ae7bb09dd448d188138f310d014fcab6 URL: https://github.com/llvm/llvm-project/commit/2a42c759ae7bb09dd448d188138f310d014fcab6 DIFF: https://github.com/llvm/llvm-project/commit/2a42c759ae7bb09dd448d188138f310d014fcab6.diff

[PATCH] D97361: [clang-tidy] Add readability-redundant-using check

balazske added a comment. There should be already a name lookup implemented somewhere in clang (`DeclContext`? or Sema) that maybe usable here (check if the name of the "used" entity is visible in the declaration context of the `using` statement). Probably it is not as simple to do because the

[clang] d5e0868 - [Basic] Fix Wreturn-type gcc warning (NFC)

Author: Yang Fan Date: 2021-02-26T17:14:13+08:00 New Revision: d5e0868e5e321e2a2f3bf73599ae9239c5aaa0c9 URL: https://github.com/llvm/llvm-project/commit/d5e0868e5e321e2a2f3bf73599ae9239c5aaa0c9 DIFF: https://github.com/llvm/llvm-project/commit/d5e0868e5e321e2a2f3bf73599ae9239c5aaa0c9.diff

[PATCH] D96976: [analyzer] Fix reinterpret_cast handling for pointer-to-member

RedDocMD updated this revision to Diff 326731. RedDocMD added a comment. Replaced BFS with existing CXXRecordDeclMethod Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96976/new/ https://reviews.llvm.org/D96976 Files:

[PATCH] D96976: [analyzer] Fix reinterpret_cast handling for pointer-to-member

RedDocMD added a comment. @steakhal, you are absolutely right! It works. Thank you for pointing it out, not sure how I missed this earlier this evening. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96976/new/ https://reviews.llvm.org/D96976

[PATCH] D97512: [clang] removes check against integral-to-pointer conversion...

aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:10320 + + const clang::CastKind Kind = Cast->getCastKind(); + if (Kind == clang::CK_BitCast && We don't typically use top-level `const` on locals or params.

[PATCH] D97094: [Driver] Print process statistics report on CC_PRINT_PROC_STAT env variable.

vvereschaka updated this revision to Diff 326729. vvereschaka added a comment. Updated diff: - updated doc parts @aganea thanks a lot for your suggestions for doc improvements. I have updated it accordingly. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D96976: [analyzer] Fix reinterpret_cast handling for pointer-to-member

RedDocMD updated this revision to Diff 326733. RedDocMD added a comment. Removed unnecessary includes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96976/new/ https://reviews.llvm.org/D96976 Files:

[PATCH] D97544: [clang-tidy] Remove some test c++ mode restrictions.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97544/new/ https://reviews.llvm.org/D97544

[PATCH] D97563: [clang-tidy] Enable modernize-concat-nested-namespaces also on headers

DmitryPolukhin updated this revision to Diff 326734. DmitryPolukhin added a comment. Comments resolved Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97563/new/ https://reviews.llvm.org/D97563 Files:

[PATCH] D97563: [clang-tidy] Enable modernize-concat-nested-namespaces also on headers

DmitryPolukhin marked an inline comment as done. DmitryPolukhin added a comment. @njames93 thank you for quick response and good suggestion! Comment at: clang-tools-extra/test/clang-tidy/checkers/modernize-concat-nested-namespaces.cpp:4 +// RUN: FileCheck

[PATCH] D97183: [analyzer] Add NoteTag for smart-ptr get()

RedDocMD marked an inline comment as done. RedDocMD added a comment. In D97183#2589445 , @NoQ wrote: > Nice! > > I suspect you're adding too many notes. The note needs to not be there if the > *raw* pointer is not tracked. Eg., I suspect that your patch

[PATCH] D97411: [DebugInfo] Add an attribute to force type info to be emitted for types that are required to be complete.

akhuang updated this revision to Diff 326738. akhuang marked an inline comment as done. akhuang added a comment. -Add documentation -Add more test cases and semantics tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97411/new/

[PATCH] D97447: Add GNU attribute 'retain'

MaskRay added a comment. I have performed a large-scale internal test. I don't find any problem with a toolchain built with D97446 /D97447 /D97448 . Repository: rG LLVM Github Monorepo

[PATCH] D97566: [WIP][RGT] Rotten Green Test checking for LLVM and Clang unittests

probinson created this revision. probinson added reviewers: MaskRay, dblaikie. Herald added a subscriber: mgrang. probinson requested review of this revision. Herald added projects: clang, LLVM. Herald added a subscriber: cfe-commits. This is an enhancement of the 'googletest' support code, to

[PATCH] D97553: [clang][NFC] pack StaticDiagInfoRec

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Comment at: clang/lib/Basic/DiagnosticIDs.cpp:171 const StaticDiagInfoRec StaticDiagInfo[] = { +// clang-format off #define DIAG(ENUM, CLASS,

[PATCH] D97446: Change some addUsedGlobal to addUsedOrCompilerUsedGlobal

MaskRay updated this revision to Diff 326739. MaskRay added a comment. Simplify with `CodeGenModule::getTriple()` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97446/new/ https://reviews.llvm.org/D97446 Files: clang/lib/CodeGen/CGDecl.cpp

[clang] 28cb620 - Change some addUsedGlobal to addUsedOrCompilerUsedGlobal

Author: Fangrui Song Date: 2021-02-26T10:42:07-08:00 New Revision: 28cb620321f5461255423f84c85e6891b5174c13 URL: https://github.com/llvm/llvm-project/commit/28cb620321f5461255423f84c85e6891b5174c13 DIFF: https://github.com/llvm/llvm-project/commit/28cb620321f5461255423f84c85e6891b5174c13.diff

[PATCH] D97446: Change some addUsedGlobal to addUsedOrCompilerUsedGlobal

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG28cb620321f5: Change some addUsedGlobal to addUsedOrCompilerUsedGlobal (authored by MaskRay). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D97488: [clang-tidy][NFC] Tweak some generation of diag messages

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Thanks, these are really nice cleanups! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97488/new/

[PATCH] D97223: Add Alignment argument to IRBuilder CreateAtomicRMW and CreateAtomicCmpXchg.

jyknight added inline comments. Comment at: llvm/lib/CodeGen/AtomicExpandPass.cpp:1037 + assert(AddrAlign >= ResultTy->getPrimitiveSizeInBits() / 8 && + "Expected at least natural alignment at this point."); jrtc27 wrote: > Doesn't this introduce

[PATCH] D97388: [analyzer] Replace StoreManager::evalIntegralCast with SValBuilder::evalCast

ASDenysPetrov added a comment. @steakhal > Please make sure that you specify the parent revision or the patch can be > applied on top of the tree. Sorry, probably missed to add a parent revision. Done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97388/new/

[PATCH] D97561: [clang] Use CompilerInstance::createTarget to createTarget

oToToT created this revision. oToToT added reviewers: sammccall, rsmith, klimek, dexonsmith. oToToT added a project: clang. oToToT requested review of this revision. Herald added a subscriber: cfe-commits. As proposed in D97109 , I tried to replace all similar

[PATCH] D97561: [clang] Use CompilerInstance::createTarget to createTarget

oToToT added inline comments. Comment at: clang/lib/Frontend/PrecompiledPreamble.cpp:368 // Create the target instance. - Clang->setTarget(TargetInfo::CreateTargetInfo( - Clang->getDiagnostics(), Clang->getInvocation().TargetOpts)); - if (!Clang->hasTarget()) + if

[PATCH] D97536: [clangd][remote] Add flag to set idletimeout

sammccall accepted this revision. sammccall added inline comments. Comment at: clang-tools-extra/clangd/index/remote/server/Server.cpp:84 +llvm::cl::opt IdleTimeoutSeconds( +"idle-timeout", llvm::cl::init(10), +llvm::cl::desc("Maximum time a channel may stay idle until

[PATCH] D97544: [clang-tidy] Remove some test c++ mode restrictions.

njames93 created this revision. njames93 added reviewers: aaron.ballman, alexfh. Herald added subscribers: kbarton, xazax.hun, nemanjai. njames93 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Some comments are redundant, others just

[PATCH] D97196: [clang-tidy] Add new check 'bugprone-unhandled-exception-at-new'.

balazske updated this revision to Diff 326642. balazske added a comment. Rebase, fixes according to review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97196/new/ https://reviews.llvm.org/D97196 Files:

[clang] 04c3071 - [Driver] Flush file in locked area

Author: Serge Pavlov Date: 2021-02-26T19:02:54+07:00 New Revision: 04c3071c16d799a4406c1742f239e8381c00b2b8 URL: https://github.com/llvm/llvm-project/commit/04c3071c16d799a4406c1742f239e8381c00b2b8 DIFF: https://github.com/llvm/llvm-project/commit/04c3071c16d799a4406c1742f239e8381c00b2b8.diff

[PATCH] D97534: SEH: capture 'this'

ogoffart updated this revision to Diff 326656. ogoffart added a comment. (git-clang-format) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97534/new/ https://reviews.llvm.org/D97534 Files: clang/lib/CodeGen/CGException.cpp clang/test/CodeGenCXX/exceptions-seh-filter-captures.cpp

[PATCH] D96586: [analyzer][CTU][NFC] Add an extra regression test

steakhal added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96586/new/ https://reviews.llvm.org/D96586 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang-tools-extra] 1a5dfb7 - [clangd][remote] Add flag to set idletimeout

Author: Kadir Cetinkaya Date: 2021-02-26T15:04:44+01:00 New Revision: 1a5dfb7db23e3c0aec0b4356a60b9d6b7c8f9683 URL: https://github.com/llvm/llvm-project/commit/1a5dfb7db23e3c0aec0b4356a60b9d6b7c8f9683 DIFF:

[PATCH] D97536: [clangd][remote] Add flag to set idletimeout

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1a5dfb7db23e: [clangd][remote] Add flag to set idletimeout (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D97536: [clangd][remote] Add flag to set idletimeout

kadircet added inline comments. Comment at: clang-tools-extra/clangd/index/remote/server/Server.cpp:84 +llvm::cl::opt IdleTimeoutSeconds( +"idle-timeout", llvm::cl::init(10), +llvm::cl::desc("Maximum time a channel may stay idle until server closes "

[PATCH] D97462: [clang][cli] Round-trip cc1 arguments in assert builds

jansvoboda11 updated this revision to Diff 326677. jansvoboda11 added a comment. Rebase on top of D97552 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97462/new/ https://reviews.llvm.org/D97462 Files:

[clang] cb81135 - [clang][cli] Implement '-cuid=' marshalling

Author: Jan Svoboda Date: 2021-02-26T13:17:51+01:00 New Revision: cb81135f94e58ce0a0e91d764841acee90eeb59f URL: https://github.com/llvm/llvm-project/commit/cb81135f94e58ce0a0e91d764841acee90eeb59f DIFF: https://github.com/llvm/llvm-project/commit/cb81135f94e58ce0a0e91d764841acee90eeb59f.diff

[PATCH] D97461: [clang][cli] Implement '-cuid=' marshalling

This revision was automatically updated to reflect the committed changes. Closed by commit rGcb81135f94e5: [clang][cli] Implement -cuid= marshalling (authored by jansvoboda11). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97461/new/

[PATCH] D97388: [analyzer] Replace StoreManager::evalIntegralCast with SValBuilder::evalCast

steakhal added a comment. Please make sure that you specify the parent revision or the patch can be applied on top of the tree. Your lines clearly not match the top of the tree state.

[PATCH] D97548: [clangd] Introduce client state invalidation

kadircet added inline comments. Comment at: clang-tools-extra/clangd/test/semantic-tokens-refresh.test:13 +# CHECK:"method": "workspace/semanticTokens/refresh", +# CHECK-NEXT: "params": null +# CHECK-NEXT: } lsp spec says `params: none` for this

[PATCH] D97388: [analyzer] Replace StoreManager::evalIntegralCast with SValBuilder::evalCast

ASDenysPetrov updated this revision to Diff 326651. ASDenysPetrov added a comment. A bit improved. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97388/new/ https://reviews.llvm.org/D97388 Files: clang/include/clang/StaticAnalyzer/Core/PathSensitive/SValBuilder.h

[clang] 8dc70bd - [clang][cli] Fix build failure in CompilerInvocation

Author: Jan Svoboda Date: 2021-02-26T13:14:23+01:00 New Revision: 8dc70bdcd0fe4efb65876dce0144d9c3386a2f07 URL: https://github.com/llvm/llvm-project/commit/8dc70bdcd0fe4efb65876dce0144d9c3386a2f07 DIFF: https://github.com/llvm/llvm-project/commit/8dc70bdcd0fe4efb65876dce0144d9c3386a2f07.diff

[PATCH] D96280: [clang][cli] Round-trip the whole CompilerInvocation

jansvoboda11 added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:666 + // semantics as the original. + SmallVector GeneratedArgs1; + Generate(DummyInvocation, GeneratedArgs1, SA); scui wrote: > This is failing our build, This line and

[PATCH] D97510: [AArch64][Docs] Release notes 12.x on outline atomics

t.p.northover accepted this revision. t.p.northover added a comment. This revision is now accepted and ready to land. I think this is fine. Comment at: clang/docs/ReleaseNotes.rst:82 + if compilation target supports LSE. Atomic instructions are used directly in + that case.

[PATCH] D97094: [Driver] Print process statistics report on CC_PRINT_PROC_STAT env variable.

aganea accepted this revision. aganea added a comment. This revision is now accepted and ready to land. LGTM, just a few minor things: Comment at: clang/docs/UsersManual.rst:798 + Setting ``CC_PRINT_PROC_STAT`` to ``1`` enables the feature, the report goes to + the stdout

[PATCH] D97548: [clangd] Introduce client state invalidation

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: usaxena95, arphaman. kadircet requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang. Clangd can invalidate client state of

[PATCH] D95016: [Clang][RISCV] Add custom TableGen backend for riscv-vector intrinsics.

khchen updated this revision to Diff 326585. khchen marked 10 inline comments as done. khchen added a comment. 1. address Craig's comments. 2. use ListSeparator in some code snippet. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95016/new/

[PATCH] D96976: [analyzer] Fix reinterpret_cast handling for pointer-to-member

steakhal added a comment. In D96976#2587513 , @RedDocMD wrote: > Many thanks for you comments, @steakhal! > I will address the issues you have pointed out in this comment. To clean > things up I should perhaps add some more clarification to the summary.

[PATCH] D97536: [clangd][remote] Add flag to set idletimeout

kadircet updated this revision to Diff 326667. kadircet marked an inline comment as done. kadircet added a comment. - change default from 10 to 8 minutes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97536/new/ https://reviews.llvm.org/D97536

[PATCH] D96280: [clang][cli] Round-trip the whole CompilerInvocation

scui added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:666 + // semantics as the original. + SmallVector GeneratedArgs1; + Generate(DummyInvocation, GeneratedArgs1, SA); jansvoboda11 wrote: > scui wrote: > > This is failing our

[PATCH] D97552: [clang][cli] Fix generation of '-fvisibility' with regards to '-mignore-xcoff-visibility'

jansvoboda11 created this revision. jansvoboda11 added reviewers: Bigcheese, dexonsmith, DiggerLin. Herald added a subscriber: dang. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch fixes failure of the

[PATCH] D97411: [DebugInfo] Add an attribute to force type info to be emitted for types that are required to be complete.

aaron.ballman added a comment. Thanks! I am still curious about the forward declare/redeclaration behavior and whether that is a situation that makes sense or not. I suspect this case may make sense (and likely already works): // Should test redeclaration behavior. struct

[PATCH] D96744: clang-format IncludeBlocks: Regroup determination of "main" for framework-style includes fix

poelmanc added a comment. In D96744#2564828 , @MyDeveloperDay wrote: > Does this need to be an option? It's easy to add an option, but there are already two //main include//-related options, so before adding a third I wanted to give this some thought.

[PATCH] D97574: [AIX][clang][driver] Restrict /usr/lib to internal library search paths

daltenty created this revision. daltenty added reviewers: hubert.reinterpretcast, stevewan, jasonliu. daltenty requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Adding it to the general filepaths results in it being added to the linker

[PATCH] D97411: [DebugInfo] Add an attribute to force type info to be emitted for types that are required to be complete.

ldionne added a comment. In D97411#2588181 , @akhuang wrote: > @ldionne Do you think it'd be reasonable to add this debug info attribute to > some types in libc++? (For types that have constructors but don't call them; > some previous discussion in

[PATCH] D84924: [clang-tidy] Added command line option `fix-notes`

njames93 updated this revision to Diff 326779. njames93 marked 6 inline comments as done. njames93 added a comment. Rebased and address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84924/new/ https://reviews.llvm.org/D84924 Files:

  1   2   >