[PATCH] D99830: [DebugInfo, CallSites, test] Fix use of undef FileCheck var

thopre created this revision. thopre added reviewers: djtodoro, vsk. thopre requested review of this revision. Herald added a project: clang. Clang test CodeGen/debug-info-extern-call.c tries to check for the absence of a sequence of instructions with several CHECK-NOT with one of those

[PATCH] D99037: [Matrix] Implement explicit type conversions for matrix types

SaurabhJha updated this revision to Diff 335083. SaurabhJha added a comment. Addressed most of the comments. I couldn't understand "..would also be good to have C++ tests that test casting with matrix types where some of the dimensions are template arguments...". When I tried this """ cx4x4

[PATCH] D99797: [analyzer] Handle intersections and adjacency in RangeSet::Factory::add function

ASDenysPetrov added a comment. @vsavchenko Many thanks for your feedback! I will make a new separate function for checking intersections considering all your suggestions along with the old quick `add` versions. I'll be more optimized. Comment at:

Re: [clang] 2458aa0 - Add missing override to clang tblgen AttrEmitter

Thank you for this cleanup! ~Aaron On Sat, Apr 3, 2021 at 12:00 AM David Blaikie via cfe-commits wrote: > > > Author: David Blaikie > Date: 2021-04-02T20:47:49-07:00 > New Revision: 2458aa0b9136e7616f529b027d1d478cf699340f > > URL: >

[PATCH] D99791: [CGCall] Annotate pointer argument with alignment

lebedev.ri added a comment. @efriedma thank you for taking a look! I agree that D99790 is basically guaranteed safe, and this "probably" isn't. In D99791#2667047 , @efriedma wrote: > This feels scary: the C standard

[PATCH] D99447: [OpenMP] Define omp_is_initial_device() variants in omp.h

JonChesterfield added a comment. Nice, thanks! I think the function in the devicertl is dead with this change, maybe remove that too? Comment at: openmp/runtime/src/include/omp.h.var:479 +# endif + # undef __KAI_KMPC_CONVENTION jdoerfert wrote: > hbae

[PATCH] D99838: [C++20, test] Fix use of undef FileCheck variable

thopre created this revision. thopre added reviewers: rsmith, EricWF, akhuang. thopre requested review of this revision. Herald added a project: clang. Commit f495de43bd5da50286da6020e508d106cfc60f57 forgot two lines when

[PATCH] D99839: [C++, test] Fix typo in NSS* vars

thopre created this revision. thopre added reviewers: respindola, pcc, EricWF. thopre requested review of this revision. Herald added a project: clang. The NSS FileCheck variables at the end of the CodeGenCXX/split-stacks.cpp clang testcase are off by 1, resulting in the use of an undefined

[PATCH] D69218: [ASTMatchers] Add `cxxBaseSpecifier` matcher (non-top-level)

steveire added a comment. In D69218#2654638 , @nick wrote: > In D69218#2654614 , @steveire wrote: > >> @nick Sorry that getting these changes merged takes so long. >> >> @njames93 If you have an alternative way

[PATCH] D99821: [PGO, test] Fix typo in FileCheck var

This revision was automatically updated to reflect the committed changes. Closed by commit rG95f448aa86cd: [PGO, test] Fix typo in FileCheck var (authored by thopre). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99821/new/

[clang] 95f448a - [PGO, test] Fix typo in FileCheck var

Author: Thomas Preud'homme Date: 2021-04-03T08:44:46+01:00 New Revision: 95f448aa86cd3680a9493b2311d9efb41c4d4c01 URL: https://github.com/llvm/llvm-project/commit/95f448aa86cd3680a9493b2311d9efb41c4d4c01 DIFF:

[PATCH] D99832: [HIP, test] Fix use of undef FileCheck var

thopre created this revision. thopre added reviewers: yaxunl, ashi1, MaskRay, hliao, pcc. thopre requested review of this revision. Herald added a project: clang. Clang test CodeGenCUDA/kernel-stub-name.cu uses never defined DKERN variable in a CHECK-NOT directive. This commit replace the

[PATCH] D99797: [analyzer] Handle intersections and adjacency in RangeSet::Factory::add function

vsavchenko added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:138-139 - return makePersistent(std::move(Result)); -} + if (!Original.pin(From, To)) +return getEmptySet(); ASDenysPetrov wrote: > This allows to

[PATCH] D99426: [SystemZ][z/OS][Windows] Add new OF_TextWithCRLF flag and use this flag instead of OF_Text

abhina.sreeskantharajan added a comment. In D99426#2666341 , @aganea wrote: > In D99426#2666141 , > @abhina.sreeskantharajan wrote: > >> In D99426#2665361 , @aganea wrote:

[clang] b4f2e80 - [RISCV] Refactor conversion of B extensions to IR intrinsics a little to reduce clang binary size.

Author: Craig Topper Date: 2021-04-02T23:49:44-07:00 New Revision: b4f2e8060075761dd0e9727ea01ca0142b4e767f URL: https://github.com/llvm/llvm-project/commit/b4f2e8060075761dd0e9727ea01ca0142b4e767f DIFF: https://github.com/llvm/llvm-project/commit/b4f2e8060075761dd0e9727ea01ca0142b4e767f.diff

[PATCH] D99831: [HIP-Clang, test] Fix use of undef FileCheck var

thopre created this revision. thopre added reviewers: ashi1, yaxunl, MaskRay, hliao, pcc. thopre requested review of this revision. Herald added a project: clang. Commit 8129521318accc44c2a009647572f6ebd3fc56dd changed a line defining PREFIX in clang test CodeGenCUDA/device-stub.cu into a

[PATCH] D80344: [Windows SEH]: HARDWARE EXCEPTION HANDLING (MSVC -EHa) - Part 1

tentzen updated this revision to Diff 335068. tentzen added a comment. rebase the patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80344/new/ https://reviews.llvm.org/D80344 Files: clang/include/clang/AST/Stmt.h

[PATCH] D99797: [analyzer] Handle intersections and adjacency in RangeSet::Factory::add function

vsavchenko added a comment. In D99797#2666565 , @ASDenysPetrov wrote: > @vsavchenko > OK, what do you think of ***adjacency*** feature? I mean it simplifies such > ranges `[1,2][3,4][5,6]` to `[1,6]`. Is it worth for implementation? I want to clarify

[PATCH] D99797: [analyzer] Handle intersections and adjacency in RangeSet::Factory::add function

vsavchenko added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:114-115 +return RHS; + for (const Range : RHS) +LHS = add(LHS, R); + return LHS; This is REAL bad. The main benefit of the new `RangeSet` over the

[PATCH] D99837: [Windows] Turn off text mode correctly in Rewriter to stop CRLF translation

abhina.sreeskantharajan created this revision. abhina.sreeskantharajan added a reviewer: aganea. abhina.sreeskantharajan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. I incorrectly changed the RewriteTestAction::ExecuteAction's file to

[PATCH] D99715: [CMake] Respect LLVM_MINIMUM_PYTHON_VERSION in Tooling/CMakeLists.txt

steveire added a reviewer: steveire. steveire added a comment. Yes, please remove the line instead. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99715/new/ https://reviews.llvm.org/D99715 ___

[PATCH] D99037: [Matrix] Implement C-style explicit type conversions for matrix types

SaurabhJha updated this revision to Diff 335084. SaurabhJha added a comment. Update one inline comment in SemaCast.cpp Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99037/new/ https://reviews.llvm.org/D99037 Files:

[PATCH] D75844: [clang] Set begin loc on GNU attribute parsed attrs

tbaeder added a comment. I compiled libc++ with a clang that has this patch applied and didn't run into more problems. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75844/new/ https://reviews.llvm.org/D75844 ___ cfe-commits mailing list

[clang] 1b4800c - [clang][parser] Set source ranges for GNU-style attributes

Author: Timm Bäder Date: 2021-04-04T07:59:22+02:00 New Revision: 1b4800c2625912d16867d27e5eec3af27af31557 URL: https://github.com/llvm/llvm-project/commit/1b4800c2625912d16867d27e5eec3af27af31557 DIFF: https://github.com/llvm/llvm-project/commit/1b4800c2625912d16867d27e5eec3af27af31557.diff

[PATCH] D99840: [clang-format] Correctly attach enum braces with ShortEnums disabled

lunasorcery created this revision. lunasorcery added reviewers: djasper, klimek. lunasorcery added a project: clang-format. lunasorcery requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Previously, with AllowShortEnumsOnASingleLine disabled,

[PATCH] D99852: [Driver] Detect libstdc++ include paths for native gcc (-m32 and -m64) on Debian i386

MaskRay created this revision. MaskRay added a reviewer: sylvestre.ledru. MaskRay requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Take gcc-8 on Debian i386 as an example. The target-specific libstdc++ search path

[PATCH] D99852: [Driver] Detect libstdc++ include paths for native gcc (-m32 and -m64) on Debian i386

MaskRay updated this revision to Diff 335127. MaskRay added a comment. `git add` two .keep files Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99852/new/ https://reviews.llvm.org/D99852 Files: clang/lib/Driver/ToolChains/Gnu.cpp

[PATCH] D69218: [ASTMatchers] Add `cxxBaseSpecifier` matcher (non-top-level)

nick added a comment. In D69218#2667523 , @steveire wrote: > What name/email should I use for the commit? Nikita Kniazev CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69218/new/ https://reviews.llvm.org/D69218

[PATCH] D99838: [C++20, test] Fix use of undef FileCheck variable

This revision was automatically updated to reflect the committed changes. Closed by commit rG1cc9d949a123: [C++20, test] Fix use of undef FileCheck variable (authored by thopre). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99838/new/

[PATCH] D99225: [clang] tests: cleanup, update and add some new ones

mizvekov added inline comments. Comment at: clang/test/SemaCXX/conversion-function.cpp:160 + return "Hello"; // cxx98_14-error {{calling a private constructor}} #if __cplusplus <= 199711L // expected-warning@-2 {{an accessible copy constructor}} mizvekov

[PATCH] D99517: Implemented [[clang::musttail]] attribute for guaranteed tail calls.

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:458 +same number of arguments as the caller. The types of the return value and all +arguments must be similar, including the implicit "this" argument, if any. +Any variables in scope,

[PATCH] D99517: Implemented [[clang::musttail]] attribute for guaranteed tail calls.

haberman updated this revision to Diff 335106. haberman added a comment. - Added missing S.setFunctionHasMustTail(). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99517/new/ https://reviews.llvm.org/D99517 Files:

[PATCH] D99517: Implemented [[clang::musttail]] attribute for guaranteed tail calls.

haberman added inline comments. Comment at: clang/lib/Sema/SemaStmt.cpp:561-568 + for (const auto *A : Attrs) { +if (A->getKind() == attr::MustTail) { + if (!checkMustTailAttr(SubStmt, *A)) { +return SubStmt; + } + setFunctionHasMustTail(); +}

Re: [clang] 4a47da2 - [Sema] turns -Wfree-nonheap-object on by default

Looks like this has a false positive (that's firing on some mlir code, committed a workaround in 499571ea835daf786626a0db1e12f890b6cd8f8d ) like this: $ cat test.cpp #include void f1(int & x) { free(); } int main() { f1(*(int*)malloc(sizeof(int))); } Could you fix that? (& then revert the

[PATCH] D99225: [clang] tests: cleanup, update and add some new ones

mizvekov updated this revision to Diff 335121. mizvekov added a comment. - Addresses most of Arthur's points. - Re-adds test coverage for `conversion-function.cpp` and `temp.mem/p5.cpp` with no C++ version specified. - Adds a couple more tests on nrvo-tracking for blocks returning references.

[PATCH] D99517: Implemented [[clang::musttail]] attribute for guaranteed tail calls.

haberman updated this revision to Diff 335103. haberman marked 3 inline comments as done. haberman added a comment. - Addressed comments and tried moving check to SemaStmtAttr.cpp. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99517/new/

[PATCH] D99517: Implemented [[clang::musttail]] attribute for guaranteed tail calls.

haberman added inline comments. Comment at: clang/lib/Sema/SemaStmt.cpp:588 + + const CallExpr *CE = dyn_cast(Ex->IgnoreUnlessSpelledInSource()); + rsmith wrote: > `IgnoreUnlessSpelledInSource` is a syntactic check that's only really > intended for tooling use

[PATCH] D99848: [OPENMP51]Initial support for nocontext clause

jyu2 created this revision. jyu2 added reviewers: mikerice, ABataev, jdoerfert. Herald added subscribers: arphaman, guansong, yaxunl. Herald added a reviewer: sscalpone. jyu2 requested review of this revision. Herald added a subscriber: sstefan1. Herald added projects: clang, LLVM. Added basic

[PATCH] D99732: [AST] Pick last tentative definition as the acting definition

pestctrl updated this revision to Diff 335113. pestctrl edited the summary of this revision. pestctrl added a comment. Removed extra pass over decl chain for acting definition. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99732/new/

[PATCH] D99732: [AST] Pick last tentative definition as the acting definition

pestctrl added inline comments. Comment at: clang/lib/AST/Decl.cpp:2192 DefinitionKind Kind = isThisDeclarationADefinition(); - if (Kind != TentativeDefinition) + if (Kind != TentativeDefinition || hasDefinition()) return nullptr; rsmith wrote: > Is

[PATCH] D99811: [TextAPI] move source code files out of subdirectory, NFC

int3 accepted this revision. int3 added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99811/new/ https://reviews.llvm.org/D99811 ___

[PATCH] D99696: [clang] WIP: NRVO: Improvements and handling of more cases.

mizvekov updated this revision to Diff 335124. mizvekov added a comment. . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99696/new/ https://reviews.llvm.org/D99696 Files: clang/include/clang/Sema/Sema.h clang/lib/Sema/Sema.cpp

[PATCH] D75844: [clang] Set begin loc on GNU attribute parsed attrs

aaron.ballman added a comment. Thank you for the additional test case, this LGTM again. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75844/new/ https://reviews.llvm.org/D75844 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] 1cc9d94 - [C++20, test] Fix use of undef FileCheck variable

Author: Thomas Preud'homme Date: 2021-04-04T00:05:48+01:00 New Revision: 1cc9d949a1233e8b17b3b345ccb67ca7296c1a6c URL: https://github.com/llvm/llvm-project/commit/1cc9d949a1233e8b17b3b345ccb67ca7296c1a6c DIFF:

[PATCH] D99696: [clang] WIP: NRVO: Improvements and handling of more cases.

mizvekov updated this revision to Diff 335122. mizvekov added a comment. Rebased. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99696/new/ https://reviews.llvm.org/D99696 Files: clang/include/clang/Sema/Sema.h clang/lib/Sema/Sema.cpp