[PATCH] D101328: [clangd] run clang-format on FindTargetTests.cpp

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101328/new/ https://reviews.llvm.org/D101328

[PATCH] D101122: introduce flag -fsanitize-address-detect-stack-use-after-return-mode. No functional change.

kda updated this revision to Diff 340746. kda added a comment. Revisions as requested. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101122/new/ https://reviews.llvm.org/D101122 Files: clang/include/clang/Basic/CodeGenOptions.def

[PATCH] D100772: [ARM] Neon Polynomial vadd Intrinsic fix

DavidSpickett accepted this revision. DavidSpickett added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100772/new/ https://reviews.llvm.org/D100772 ___ cfe-commits mailing

[PATCH] D98726: [analyzer] Enabling MallocChecker to take up after SmartPtrModelling

RedDocMD added a comment. The call to `PathSensitiveBugReport::markInvalid()` is triggered by `LikelyFalsePositiveSuppressionBRVisitor::finalizeVisitor()`. So I guess we need to see now why the visitor thinks this is a false positive. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D101059: [X86][AMX] Add description for AMX new interface.

xiangzhangllvm added a comment. +1 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101059/new/ https://reviews.llvm.org/D101059 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] 17139b2 - [clang-format] Reformat. NFC.

Author: Marek Kurdej Date: 2021-04-27T09:10:58+02:00 New Revision: 17139b2b21a080c8584fbfe059e8adf85fd26c07 URL: https://github.com/llvm/llvm-project/commit/17139b2b21a080c8584fbfe059e8adf85fd26c07 DIFF: https://github.com/llvm/llvm-project/commit/17139b2b21a080c8584fbfe059e8adf85fd26c07.diff

[clang] 3feb84a - [clang-format] Merge SpacesInAngles tests. NFC.

Author: Marek Kurdej Date: 2021-04-27T09:32:09+02:00 New Revision: 3feb84a36f5128dd0f6e9c65314609a9ce4372bc URL: https://github.com/llvm/llvm-project/commit/3feb84a36f5128dd0f6e9c65314609a9ce4372bc DIFF: https://github.com/llvm/llvm-project/commit/3feb84a36f5128dd0f6e9c65314609a9ce4372bc.diff

[PATCH] D100841: [clangd][Index][NFC] Make local class collection optional

kadircet abandoned this revision. kadircet added a comment. > This seems reasonable, but having found the problem, do we still want to land > it? I suppose not. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100841/new/

[PATCH] D89013: [libcxx] Support per-target __config_site in per-target runtime build

phosek updated this revision to Diff 340743. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89013/new/ https://reviews.llvm.org/D89013 Files: clang/lib/Driver/ToolChains/Fuchsia.cpp clang/lib/Driver/ToolChains/Gnu.cpp

[PATCH] D100667: [clang] Fix assert() crash when checking undeduced arg alignment

hokein added a comment. thanks, I think we can simplify a bit more. Comment at: clang/lib/Sema/SemaChecking.cpp:4543 // getTypeAlignInChars requires complete types - if (ParamTy->isIncompleteType() || ArgTy->isIncompleteType() || - ParamTy->isUndeducedType() ||

[PATCH] D101344: [clang-format] Add `SpacesInAngles: Leave` option to keep spacing inside angle brackets as is.

curdeius created this revision. curdeius added reviewers: MyDeveloperDay, HazardyKnusperkeks. curdeius requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. A need for such an option came up in a few libc++ reviews. That's because libc++ has

[PATCH] D100581: [Clang] -Wunused-but-set-parameter and -Wunused-but-set-variable

Abpostelnicu added a comment. I think this added a regression, where you have this context: uint32_t LocalAccessible::SelectedItemCount() { uint32_t count = 0; AccIterator iter(this, filters::GetSelected); LocalAccessible* selected = nullptr; while ((selected = iter.Next()))

[PATCH] D85802: [clang] Add -fc++-abi= flag for specifying which C++ ABI to use

jansvoboda11 added a comment. In D85802#2717684 , @leonardchan wrote: >> That's odd. Does your `CMakeCache.txt` file have >> `CLANG_ROUND_TRIP_CC1_ARGS:BOOL=OFF` by any chance? It's possible it didn't >> get switched to `ON` when D97462

[PATCH] D101317: hurd: Fix i386 research path

sthibaul updated this revision to Diff 340749. sthibaul added a comment. Retrigger buildable Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101317/new/ https://reviews.llvm.org/D101317 Files: clang/lib/Driver/ToolChains/Gnu.cpp

[PATCH] D101346: [AST] Fix getExprLoc reported for cxxDependentScopeMemberExpr

steveire created this revision. steveire added a reviewer: rsmith. steveire requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. All other CallExpr use the location of the member name as the getExprLoc: https://godbolt.org/z/jx16G9Gdr

[clang] 3a3fbbe - [Fuchsia] Use correct target triple for ARM

Author: Petr Hosek Date: 2021-04-26T23:48:12-07:00 New Revision: 3a3fbbe21720839e8ad9f7eb70db7b0b7cda1c4f URL: https://github.com/llvm/llvm-project/commit/3a3fbbe21720839e8ad9f7eb70db7b0b7cda1c4f DIFF: https://github.com/llvm/llvm-project/commit/3a3fbbe21720839e8ad9f7eb70db7b0b7cda1c4f.diff

[PATCH] D77598: Integral template argument suffix and cast printing

reikdas added a comment. ping... CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77598/new/ https://reviews.llvm.org/D77598 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D101259: [clang-tidy] Fix cppcoreguidelines-pro-type-vararg false positives with __builtin_ms_va_list

jubnzv updated this revision to Diff 340738. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101259/new/ https://reviews.llvm.org/D101259 Files: clang-tools-extra/clang-tidy/cppcoreguidelines/ProTypeVarargCheck.cpp

[PATCH] D101059: [X86][AMX] Add description for AMX new interface.

pengfei accepted this revision. pengfei added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101059/new/ https://reviews.llvm.org/D101059

[PATCH] D100581: [Clang] -Wunused-but-set-parameter and -Wunused-but-set-variable

uabelho added a comment. I noticed that with this patch libcxx/test/std/strings/basic.string/string.cons/iter_alloc_deduction.fail.cpp fails: error: 'warning' diagnostics seen but not expected: File

[clang] d6c6db2 - [X86][AMX] Add description for AMX new interface.

Author: Luo, Yuanke Date: 2021-04-27T16:05:11+08:00 New Revision: d6c6db2feaab42c8132d584b547c18e443ba7f96 URL: https://github.com/llvm/llvm-project/commit/d6c6db2feaab42c8132d584b547c18e443ba7f96 DIFF: https://github.com/llvm/llvm-project/commit/d6c6db2feaab42c8132d584b547c18e443ba7f96.diff

[PATCH] D101059: [X86][AMX] Add description for AMX new interface.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd6c6db2feaab: [X86][AMX] Add description for AMX new interface. (authored by LuoYuanke). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D101324: Hurd: Clean up Debian multiarch /usr/include/

sthibaul added a comment. FI, I don't have commit access. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101324/new/ https://reviews.llvm.org/D101324 ___ cfe-commits mailing list

[PATCH] D101317: hurd: Fix i386 research path

sthibaul updated this revision to Diff 340751. sthibaul added a comment. Retrigger buildable Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101317/new/ https://reviews.llvm.org/D101317 Files: clang/lib/Driver/ToolChains/Gnu.cpp

[PATCH] D101122: introduce flag -fsanitize-address-detect-stack-use-after-return-mode. No functional change.

kda marked 4 inline comments as done. kda added a comment. Thank you for delineating the steps. Unfortunately, I don't know where to even start looking for the tests you mention in step 1. Are you looking for something like this: https://reviews.llvm.org/differential/changeset/?ref=2496958

[PATCH] D101122: introduce flag -fsanitize-address-detect-stack-use-after-return-mode. No functional change.

kda updated this revision to Diff 340754. kda added a comment. fixed up some more naming issues. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101122/new/ https://reviews.llvm.org/D101122 Files: clang/include/clang/Basic/CodeGenOptions.def

[PATCH] D101327: [Clang][Driver] validate sysregs for -mstack-protector-guard-reg=

DavidSpickett added a comment. A lot of these system registers are going to be unsuitable for the stack canary. They're either read only, they have fixed bits, or they'll get overwritten by various system events. I'm not suggesting we audit this list for those things, what seems reasonable to

[PATCH] D101346: [AST] Fix getExprLoc reported for cxxDependentScopeMemberExpr

steveire updated this revision to Diff 340762. steveire added a comment. Update test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101346/new/ https://reviews.llvm.org/D101346 Files: clang/include/clang/AST/ExprCXX.h

[PATCH] D98726: [analyzer] Enabling MallocChecker to take up after SmartPtrModelling

RedDocMD added a comment. Judging by this line in the `LikelyFalsePositiveSuppressionBRVisitor::finalizeVisitor()` method, it seems that the bug

[PATCH] D101168: [C++4OpenCL] Add clang extension for unsafe kernel parameters

olestrohm added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:8651 static OpenCLParamType getOpenCLKernelParameterType(Sema , QualType PT) { + if (PT->isDependentType()) +return InvalidKernelParam; Anastasia wrote: > I would rather add an assert

[clang] 59ad4e0 - Reapply "[AMDGPU][OpenMP] Add amdgpu-arch tool to list AMD GPUs installed"

Author: Pushpinder Singh Date: 2021-04-27T10:47:05Z New Revision: 59ad4e0f01a8402016a690b3915bdd083285561e URL: https://github.com/llvm/llvm-project/commit/59ad4e0f01a8402016a690b3915bdd083285561e DIFF: https://github.com/llvm/llvm-project/commit/59ad4e0f01a8402016a690b3915bdd083285561e.diff

[PATCH] D101352: [DOCS] Removed inconsistency in clang vs Clang usage in docs (c vs C)

sushmaunnibhavi created this revision. sushmaunnibhavi added reviewers: xgupta, kbarton, nickdesaulniers, tmfink. sushmaunnibhavi requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fixed bug #37411 Bug

[clang] 37bc1dc - [NFC] Workaround MSVC2019 32-bit compiler crash

Author: Sven van Haastregt Date: 2021-04-27T11:15:47+01:00 New Revision: 37bc1dc9877fc480493c85c6d02709b3015bb5e8 URL: https://github.com/llvm/llvm-project/commit/37bc1dc9877fc480493c85c6d02709b3015bb5e8 DIFF:

[PATCH] D101259: [clang-tidy] Fix cppcoreguidelines-pro-type-vararg false positives with __builtin_ms_va_list

jubnzv added a comment. Thanks, I updated my patch and now CI is happy. I also found a few additional cases that can lead to false positives on the platforms which implements `__builtin_va_list` as `void *` or `char *`, and added additional checks for this. CHANGES SINCE LAST ACTION

[PATCH] D100980: [OpenCL] Allow use of double type without extension pragma

azabaznov added a comment. > When the pragma is parsed we can't know why it is in the code to be able to > issue any warning. I mean diagnose once when, for example in your particular case, double type is parsed. Does it require much effort? I think this warning might be useful for

[PATCH] D101259: [clang-tidy] Fix cppcoreguidelines-pro-type-vararg false positives with __builtin_ms_va_list

jubnzv updated this revision to Diff 340757. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101259/new/ https://reviews.llvm.org/D101259 Files: clang-tools-extra/clang-tidy/cppcoreguidelines/ProTypeVarargCheck.cpp

[PATCH] D99840: [clang-format] Correctly attach enum braces with ShortEnums disabled

curdeius accepted this revision. curdeius added a comment. This revision is now accepted and ready to land. LGTM. I also consider it a bug. LLVM should not be affected as it uses `AllowShortEnumsOnASingleLine: true` whereas this problem arises only with `AllowShortEnumsOnASingleLine: false`.

[PATCH] D100919: [AArch64] Support customizing stack protector guard

DavidSpickett added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:3110 +} +if (EffectiveTriple.isAArch64() && Value != "sysreg" && Value != "global") { + D.Diag(diag::err_drv_invalid_value_with_suggestion) Shouldn't this also

[PATCH] D100919: [AArch64] Support customizing stack protector guard

DavidSpickett added inline comments. Comment at: clang/test/Driver/stack-protector-guard.c:59 +// INVALID-VALUE-AARCH64: error: invalid value 'tls' in 'mstack-protector-guard=','valid arguments to '-mstack-protector-guard=' are:sysreg global' +// INVALID-REG-AARCH64: error:

[PATCH] D101348: [Driver] Fix tests failing in per-target multiarch layout

phosek created this revision. phosek added reviewers: haowei, leonardchan. phosek requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. These failures were revealed by b4537c3f51bc6c011ddd9c10b80043ac4ce16a01

[PATCH] D101347: hurd: Clean up test

sthibaul updated this revision to Diff 340769. sthibaul added a comment. Retrigger buildable with the dep Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101347/new/ https://reviews.llvm.org/D101347 Files:

[PATCH] D100492: [OpenCL] Change OpenCL builtin version encoding

svenvh added a comment. Thanks for experimenting! I have pushed 37bc1dc9877f ("[NFC] Workaround MSVC2019 32-bit compiler crash", 2021-04-27). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D100482: [PowerPC] Provide MMA builtins for compatibility

nemanjai requested changes to this revision. nemanjai added a comment. This revision now requires changes to proceed. There may be something I am overlooking here, but I really don't think we need to or want to change the back end. Just add the new builtins to the front end as aliases to the

[PATCH] D101347: hurd: Clean up test

sthibaul created this revision. sthibaul requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. - We dropped windows support - Upgrade to current gcc 10 version Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D101347 Files:

[PATCH] D101331: hurd: Detect libstdc++ include paths on Debian Hurd i386

sthibaul updated this revision to Diff 340765. sthibaul added a comment. Fix clang-tidy warning Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101331/new/ https://reviews.llvm.org/D101331 Files: clang/lib/Driver/ToolChains/Gnu.cpp

[PATCH] D100980: [OpenCL] Allow use of double type without extension pragma

azabaznov added a comment. > Anyway since there is not clear benefit that can be found now for the pragma > I think we should minimize its use as much as possible. Unfortunately it's already there :( > Anyway since there is not clear benefit that can be found now for the pragma > I think we

[PATCH] D100980: [OpenCL] Allow use of double type without extension pragma

Anastasia added a comment. In D100980#2719043 , @azabaznov wrote: >> I am not sure, to be honest I personally think the extension pragma is a >> spec failure as it is not specified properly or to allow reasonable >> implementation > > Unfortunately

[clang-tools-extra] 4581bf3 - [clangd] Dont index deeply nested symbols

Author: Kadir Cetinkaya Date: 2021-04-27T12:34:56+02:00 New Revision: 4581bf31bb8333dc1372959f7d650ed940eab710 URL: https://github.com/llvm/llvm-project/commit/4581bf31bb8333dc1372959f7d650ed940eab710 DIFF:

[PATCH] D101066: [clangd] Dont index deeply nested symbols

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4581bf31bb83: [clangd] Dont index deeply nested symbols (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D101192: Add support for #elifdef and #elifndef

aaron.ballman updated this revision to Diff 340797. aaron.ballman marked 3 inline comments as done. aaron.ballman added a comment. Updating based on review comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101192/new/ https://reviews.llvm.org/D101192 Files:

[PATCH] D101192: Add support for #elifdef and #elifndef

aaron.ballman added a comment. In D101192#2716596 , @mibintc wrote: > Wow thanks for doing this! I worked on it a couple days a while ago but I > abandoned the effort and went back to my day job. Happy to help! > It seems like preprocessing ought to

[PATCH] D99689: [OPENMP]Add option -fopenmp-cuda-const-firstprivate to control address space of the corresponding global.

ABataev updated this revision to Diff 340803. ABataev added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99689/new/ https://reviews.llvm.org/D99689 Files: clang/include/clang/Basic/LangOptions.def

[PATCH] D101358: [analyzer][StdLibraryFunctionsChecker] Track dependent arguments

martong added a comment. Wow, thanks for the real quick review! I appreciate it! :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101358/new/ https://reviews.llvm.org/D101358 ___ cfe-commits mailing

[PATCH] D101352: [DOCS] Removed inconsistency in clang vs Clang usage in docs (c vs C)

xgupta accepted this revision. xgupta added a comment. This revision is now accepted and ready to land. LGTM, Thanks for the patch! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101352/new/ https://reviews.llvm.org/D101352

[PATCH] D100983: [OpenCL] Fix optional image types

azabaznov accepted this revision. azabaznov added a comment. This revision is now accepted and ready to land. Generally looks good to me, but maybe a test needed, see a comment. Thanks! But I'm still not sure about completely removing pragmas for type declarations (see

[PATCH] D100980: [OpenCL] Allow use of double type without extension pragma

Anastasia added a comment. In D100980#2719196 , @azabaznov wrote: >> When the pragma is parsed we can't know why it is in the code to be able to >> issue any warning. > > I mean diagnose once when, for example in your particular case, double type > is

[PATCH] D100667: [clang] Fix assert() crash when checking undeduced arg alignment

adamcz updated this revision to Diff 340802. adamcz marked 2 inline comments as done. adamcz added a comment. review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100667/new/ https://reviews.llvm.org/D100667 Files:

[PATCH] D100667: [clang] Fix assert() crash when checking undeduced arg alignment

adamcz added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:19668 T = Context.DependentTy; + else if (const auto *U = T->getUnqualifiedDesugaredType()) +if (U->isUndeducedType()) hokein wrote: > I'm not sure we need this well. I think the

[PATCH] D100591: [Clang][AArch64] Disable rounding of return values for AArch64

t.p.northover accepted this revision. t.p.northover added a comment. This revision is now accepted and ready to land. Thanks for updating it. A little disappointing that we can't support BE first-class, but much more important that it's not broken and it's not actually that common. So I think

[PATCH] D101358: [analyzer][StdLibraryFunctionsChecker] Track dependent arguments

vsavchenko accepted this revision. vsavchenko added a comment. This revision is now accepted and ready to land. Looking great, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101358/new/ https://reviews.llvm.org/D101358

[PATCH] D101168: [C++4OpenCL] Add clang extension for unsafe kernel parameters

olestrohm updated this revision to Diff 340796. olestrohm added a comment. Improved the description and example per the feedback. The check for dependent type is needed. If it is not included the diagnostic will get triggered when the extension is disabled, but not when it's enabled. CHANGES

[PATCH] D96203: [clang][patch] Modify sanitizer options names: renaming blacklist to blocklist

mibintc abandoned this revision. mibintc added a comment. There was no resolution about what option name would be acceptable Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96203/new/ https://reviews.llvm.org/D96203

[PATCH] D100860: [C++4OpenCL] Add missing OpenCL specific diagnostics in templates

This revision was automatically updated to reflect the committed changes. Closed by commit rG6a92c19f3bbc: [C++4OpenCL] Add diagnostics for OpenCL types in templates. (authored by Anastasia). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100860/new/

[clang] 6a92c19 - [C++4OpenCL] Add diagnostics for OpenCL types in templates.

Author: Anastasia Stulova Date: 2021-04-27T13:04:25+01:00 New Revision: 6a92c19f3bbc47827b8844a2b527f6c6fba63afd URL: https://github.com/llvm/llvm-project/commit/6a92c19f3bbc47827b8844a2b527f6c6fba63afd DIFF:

[PATCH] D70340: Add a key method to Sema to optimize debug info size

erichkeane added inline comments. Comment at: clang/include/clang/Sema/Sema.h:335 + /// A key method to reduce duplicate type info from Sema. + virtual void anchor(); rnk wrote: > erichkeane wrote: > > rnk wrote: > > > hans wrote: > > > > I worry that this

[PATCH] D101358: [analyzer][StdLibraryFunctionsChecker] Track dependent arguments

martong created this revision. martong added reviewers: vsavchenko, NoQ, steakhal. Herald added subscribers: ASDenysPetrov, gamesh411, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun, whisperity. Herald added a reviewer: Szelethus.

[PATCH] D101191: [InstCombine] Fully disable select to and/or i1 folding

nikic added inline comments. Comment at: llvm/test/Transforms/InstCombine/logical-select.ll:385 +; CHECK-NEXT:[[OR:%.*]] = select i1 [[AND1]], i1 true, i1 [[AND2]] +; CHECK-NEXT:ret i1 [[OR]] ; aqjune wrote: > nikic wrote: > > It looks like this fold

[PATCH] D101191: [InstCombine] Fully disable select to and/or i1 folding

spatel added inline comments. Comment at: llvm/test/Transforms/PhaseOrdering/X86/vector-reductions.ll:282 +; FIXME: this should be vectorized define i1 @cmp_lt_gt(double %a, double %b, double %c) { I don't think we need to worry about regressing this. It's

[PATCH] D100581: [Clang] -Wunused-but-set-parameter and -Wunused-but-set-variable

aeubanks added a comment. In D100581#2718840 , @uabelho wrote: > I noticed that with this patch > > libcxx/test/std/strings/basic.string/string.cons/iter_alloc_deduction.fail.cpp > fails: > > error: 'warning' diagnostics seen but not expected: >

[PATCH] D100581: [Clang] -Wunused-but-set-parameter and -Wunused-but-set-variable

aeubanks added a comment. In D100581#2718947 , @Abpostelnicu wrote: > I think this added a regression, where you have this context: > > uint32_t LocalAccessible::SelectedItemCount() { > uint32_t count = 0; > AccIterator iter(this,

[PATCH] D101378: [llvm, clang] Remove stdlib includes from .h files without `std::`

aeubanks accepted this revision. aeubanks added a comment. This revision is now accepted and ready to land. lgtm CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101378/new/ https://reviews.llvm.org/D101378 ___ cfe-commits mailing list

[PATCH] D101191: [InstCombine] Fully disable select to and/or i1 folding

aqjune added inline comments. Comment at: llvm/test/Transforms/InstCombine/logical-select.ll:385 +; CHECK-NEXT:[[OR:%.*]] = select i1 [[AND1]], i1 true, i1 [[AND2]] +; CHECK-NEXT:ret i1 [[OR]] ; nikic wrote: > aqjune wrote: > > nikic wrote: > > > It

[PATCH] D100807: [clang][driver] Use the canonical Darwin arch name when printing out the triple for a Darwin target

thakis added a comment. In D100807#2719873 , @arphaman wrote: > We have M1 CI running internally but it's post > commit only right now Which tests is it running? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D100667: [clang] Fix assert() crash when checking undeduced arg alignment

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. Thanks! Comment at: clang/test/SemaCXX/cxx17-undeduced-alignment.cpp:19 +void baz() { + // S(123) is undeduced, but when passed to foo() via bar() it is wrapped in + //

[PATCH] D101191: [InstCombine] Fully disable select to and/or i1 folding

spatel added inline comments. Comment at: llvm/test/Transforms/PhaseOrdering/unsigned-multiply-overflow-check.ll:20 +; FIXME: noundef should be attached to args define i1 @will_not_overflow(i64 %arg, i64 %arg1) { aqjune wrote: > aqjune wrote: > > spatel

[PATCH] D100581: [Clang] -Wunused-but-set-parameter and -Wunused-but-set-variable

eugenis added a comment. I fixed another one in https://reviews.llvm.org/rG561f4b9087457e9ea3cf4aeb57dcd507e2fa6258 Please watch the bots after you land changes like this one and don't let them stay broken for an entire day! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D101191: [InstCombine] Fully disable select to and/or i1 folding

aqjune added inline comments. Comment at: llvm/test/Transforms/PhaseOrdering/unsigned-multiply-overflow-check.ll:20 +; FIXME: noundef should be attached to args define i1 @will_not_overflow(i64 %arg, i64 %arg1) { aqjune wrote: > spatel wrote: > > Any ideas

[PATCH] D101365: [clang-query] Add check to prevent setting srcloc when no introspection is available.

njames93 updated this revision to Diff 340902. njames93 added a comment. Fix up tests(probably, see what premerge says) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101365/new/ https://reviews.llvm.org/D101365 Files:

[PATCH] D94355: [Passes] Add relative lookup table converter pass

nathanchance added a comment. In D94355#2717958 , @gulfem wrote: > @nathanchance do you prefer me to revert the patch first as it might take me > a while to investigate it? > Btw, I was able to reproduce the issue by following your steps. I would say if

[PATCH] D101327: [Clang][Driver] validate sysregs for -mstack-protector-guard-reg=

nickdesaulniers updated this revision to Diff 340915. nickdesaulniers added a comment. - prefer vanilla array + llvm::find Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101327/new/ https://reviews.llvm.org/D101327 Files:

[PATCH] D100872: Use OpenFlags instead of boolean to set a file as text/binary

dexonsmith added a subscriber: sammccall. dexonsmith added inline comments. Comment at: clang/include/clang/Frontend/CompilerInstance.h:738-740 + createOutputFileImpl(StringRef OutputPath, llvm::sys::fs::OpenFlags Flags, bool RemoveFileOnSignal, bool

[PATCH] D101317: hurd: Fix i386 research path

sthibaul updated this revision to Diff 340875. sthibaul marked an inline comment as done. sthibaul added a comment. Fix triplet Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101317/new/ https://reviews.llvm.org/D101317 Files:

[PATCH] D101317: hurd: Fix i386 research path

sthibaul added inline comments. Comment at: clang/test/Driver/hurd.c:2 // RUN: %clang -no-canonical-prefixes %s -### 2>&1 \ // RUN: --target=i386-pc-gnu \ // RUN: --sysroot=%S/Inputs/basic_hurd_tree \ MaskRay wrote: > While we currently detects

[PATCH] D101378: [llvm, clang] Remove stdlib includes from .h files without `std::`

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG21da04f70173: [llvm, clang] Remove stdlib includes from .h files without `std::` (authored by thakis). Herald added a project: clang. Repository:

[PATCH] D99436: [OPENMP]Fix PR49366: crash on VLAs in task untied regions.

ABataev updated this revision to Diff 340887. ABataev added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99436/new/ https://reviews.llvm.org/D99436 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td

[clang] 21da04f - [llvm, clang] Remove stdlib includes from .h files without `std::`

Author: Nico Weber Date: 2021-04-27T12:41:39-04:00 New Revision: 21da04f701735ecd42f1d43b3f58b708ad382905 URL: https://github.com/llvm/llvm-project/commit/21da04f701735ecd42f1d43b3f58b708ad382905 DIFF: https://github.com/llvm/llvm-project/commit/21da04f701735ecd42f1d43b3f58b708ad382905.diff

[PATCH] D101327: [Clang][Driver] validate sysregs for -mstack-protector-guard-reg=

nickdesaulniers added a comment. In D101327#2718989 , @DavidSpickett wrote: > So if kernel builds are using a small subset of registers, just check for > those. The kernel uses just one for aarch64. It looks like GCC just feeds through whatever is

[PATCH] D101327: [Clang][Driver] validate sysregs for -mstack-protector-guard-reg=

nickdesaulniers updated this revision to Diff 340931. nickdesaulniers added a comment. - rebase on D101387 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101327/new/ https://reviews.llvm.org/D101327 Files:

[PATCH] D101388: [clangd] Add SymbolID to LocatedSymbol.

usaxena95 created this revision. usaxena95 added a reviewer: sammccall. Herald added subscribers: kadircet, arphaman. usaxena95 requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. This is useful for running

[PATCH] D101400: [Driver] Add -print-multiarch-triple

phosek created this revision. phosek added reviewers: rnk, MaskRay. Herald added a subscriber: dang. phosek requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This is useful in runtimes build for example which currently try to guess the

[PATCH] D101400: [Driver] Add -print-multiarch-triple

MaskRay added a comment. gcc has `--print-multiarch`. Just use `--print-multiarch`? I think our semantics are compatible. It seems odd to have print-runtime-dir tests in `immediate-options.c`. The tests should be moved to a `print-*` file. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D99975: [clangd][ObjC] Improve support for class properties

dgoldman updated this revision to Diff 340885. dgoldman marked 2 inline comments as done. dgoldman added a comment. Fixes for review Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99975/new/ https://reviews.llvm.org/D99975 Files:

[PATCH] D100919: [AArch64] Support customizing stack protector guard

nickdesaulniers updated this revision to Diff 340905. nickdesaulniers marked 3 inline comments as done. nickdesaulniers added a comment. - prefer err_drv_invalid_value Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100919/new/

[PATCH] D100919: [AArch64] Support customizing stack protector guard

nickdesaulniers added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:3138 } +if (EffectiveTriple.isAArch64() && Value != "sp_el0") { + D.Diag(diag::err_drv_invalid_value_with_suggestion) DavidSpickett wrote: > nickdesaulniers

[PATCH] D100872: Use OpenFlags instead of boolean to set a file as text/binary

abhina.sreeskantharajan added a comment. ping :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100872/new/ https://reviews.llvm.org/D100872 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] 9c552d2 - hurd: Fix i386 research path

Author: Samuel Thibault Date: 2021-04-27T12:41:18-07:00 New Revision: 9c552d27ee03ad485c2d36827e73bea75faee5e1 URL: https://github.com/llvm/llvm-project/commit/9c552d27ee03ad485c2d36827e73bea75faee5e1 DIFF:

[PATCH] D101317: hurd: Fix i386 research path

This revision was automatically updated to reflect the committed changes. Closed by commit rG9c552d27ee03: hurd: Fix i386 research path (authored by sthibaul, committed by MaskRay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101317/new/

[PATCH] D100901: [CMake][llvm] The first argument to check_linker_flag is the language

radford updated this revision to Diff 340956. radford added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. [CMake][llvm] The first argument to check_linker_flag is the language Match the API for the new check_linker_flag and use it directly when available,

[PATCH] D101194: [Driver] Push multiarch path setup to individual drivers

bjope added a comment. Got some problems with my builds after this commit. My cmake commands looks like this (well, this is after having tried to fix the problem by replacing `x86_64-unknown-linux-gnu` by `x86_64-linux-gnu` as I figured that might be needed after looking at the changes in this

[PATCH] D101324: Hurd: Clean up Debian multiarch /usr/include/

MaskRay added a comment. I see that this makes the code similar to the similar logic in Linux.cpp. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101324/new/ https://reviews.llvm.org/D101324 ___

  1   2   3   >