[PATCH] D104604: [clang] NFC: add line break at the end of if expressions

zhouyizhou created this revision. zhouyizhou added reviewers: pengfei, rsmith, rjmccall, doug.gregor, sepavloff, craig.topper, klimek. zhouyizhou requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Hi, In function TransformTemplateArgument,

[PATCH] D104044: [clang-format] Fix the issue that empty lines being removed at the beginning of namespace

MyDeveloperDay added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:281 + CustomStyle)); + EXPECT_EQ("/* something */ namespace N\n" +"{\n" What does ``` namespace N { /* comment */ ``` or ``` namespace N

[PATCH] D104285: [analyzer] Retrieve value by direct index from list initialization of constant array declaration.

chrish_ericsson_atx added a comment. I've looked this over and tested it locally, and I'm pretty sure it's a good patch. If it were solely up to me, I'd accept this patch as-is. I don't think I should assume I have enough experience in this area though... @NoQ , could you take a look over

[PATCH] D98710: [clang-tidy] Add --skip-headers, part 1 (use setTraversalScope)

chh updated this revision to Diff 353224. chh marked an inline comment as done. chh edited the summary of this revision. chh added a comment. Sync up; moved DeclFilter to ClangTidy.cpp. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98710/new/ https://reviews.llvm.org/D98710 Files:

[PATCH] D94333: [Inliner] Change inline remark format and update ReplayInlineAdvisor to use it

sylvestre.ledru added a comment. > I think this change broke apt.llvm.org Confirmed: reverting this change fixed the link issue Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94333/new/ https://reviews.llvm.org/D94333

[PATCH] D98710: [clang-tidy] Add --skip-headers, part 1 (use setTraversalScope)

chh added inline comments. Comment at: clang-tools-extra/clang-tidy/ClangTidyCheck.h:31 + +struct DeclFilter : public OptionsDeclFilter { + DeclFilter(ClangTidyContext , SourceManager ) sammccall wrote: > The layering in clang-tidy is... not particularly great

[PATCH] D103750: [analyzer] Handle std::make_unique for SmartPtrModeling

NoQ added a comment. Yes, @xazax.hun is correct. It's incorrect to say that the static analyzer "doesn't seem to be able to make up its mind". The analyzer gives perfectly clear and consistent answers for each execution path it explores and it's not surprising that the results are different

[PATCH] D104145: [clang] NFC: adjust indentation of statements with more than one lines

This revision was automatically updated to reflect the committed changes. Closed by commit rG735ad67a4ce8: [clang] NFC: adjust indentation of statements with more than one lines (authored by zhouyizhou, committed by pengfei). Herald added a project: clang. Herald added a subscriber: cfe-commits.

[clang] 735ad67 - [clang] NFC: adjust indentation of statements with more than one lines

Author: Zhouyi Zhou Date: 2021-06-21T10:17:10+08:00 New Revision: 735ad67a4ce8d4a6c10f10d12f4282c796ea7ab7 URL: https://github.com/llvm/llvm-project/commit/735ad67a4ce8d4a6c10f10d12f4282c796ea7ab7 DIFF: https://github.com/llvm/llvm-project/commit/735ad67a4ce8d4a6c10f10d12f4282c796ea7ab7.diff

[PATCH] D94333: [Inliner] Change inline remark format and update ReplayInlineAdvisor to use it

modimo added a comment. In D94333#2829233 , @sylvestre.ledru wrote: >> I think this change broke apt.llvm.org > > Confirmed: reverting this change fixed the link issue What exact commit/download package and build command repros this? M68kSubtarget.cpp

[PATCH] D104604: [clang] NFC: add line break at the end of if expressions

pengfei accepted this revision. pengfei added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104604/new/ https://reviews.llvm.org/D104604

[PATCH] D104500: [clang] Apply P1825 as Defect Report from C++11 up to C++20.

mizvekov updated this revision to Diff 353240. mizvekov added a comment. . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104500/new/ https://reviews.llvm.org/D104500 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td

[PATCH] D103501: [clang][AIX] Enable inlined quadword atomic operations

lkail updated this revision to Diff 353268. lkail added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103501/new/ https://reviews.llvm.org/D103501 Files: clang/lib/Basic/Targets/PPC.cpp

[clang-tools-extra] e37653d - [clangd] Type hints for C++14 return type deduction

Author: Nathan Ridge Date: 2021-06-21T01:13:00-04:00 New Revision: e37653da1399d846e02897680412139fdcde93ab URL: https://github.com/llvm/llvm-project/commit/e37653da1399d846e02897680412139fdcde93ab DIFF: https://github.com/llvm/llvm-project/commit/e37653da1399d846e02897680412139fdcde93ab.diff

[PATCH] D103789: [clangd] Type hints for C++14 return type deduction

This revision was automatically updated to reflect the committed changes. Closed by commit rGe37653da1399: [clangd] Type hints for C++14 return type deduction (authored by nridge). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103789/new/

[PATCH] D97915: [Coroutines] Handle overaligned frame allocation

ChuanqiXu added a comment. A remained question. - what's the semantics if user specified their allocation/deallocation functions? Previously, we discussed for the ::operator new and ::operator delete. But what would we do for user specified allocation/deallocation functions? It looks like we

[PATCH] D103501: [clang][AIX] Enable inlined quadword atomic operations

lkail added inline comments. Comment at: clang/lib/Basic/Targets/PPC.cpp:336 .Default(false); + Features["quadword-atomics"] = llvm::StringSwitch(CPU) + .Case("pwr10", true) qiucf wrote: > What about