[PATCH] D116786: [clangd] Add designator inlay hints for initializer lists.

kadircet added a comment. > Agree. I guess then we ignore the issue for this patch? As you say that's > affects other hints too, and a mitigation (hopefully) won't be specific to > the kind of hint. Yup. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D117522: [clang-tidy] Add modernize-macro-to-enum check

LegalizeAdulthood updated this revision to Diff 402416. LegalizeAdulthood added a comment. Switch back to SmallVector after debugging with std::vector Drop unnecessary includes CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117522/new/ https://reviews.llvm.org/D117522 Files:

[PATCH] D118011: [RISCV] Adjust predicates and update intrinsic for clmul and clmulh in Zbkc extension

Jimerlife added a comment. In D118011#3265069 , @kito-cheng wrote: > Actually this patch is NOT NFC, you fixed an issue that is: `zbkc` isn't > include `cmul` and `clmulh`. > > So I would suggest you: > > 1. Remove NFC from the title. > 2. Add test

[PATCH] D118018: [RFC] [C+++20] [Modules] Mangling lambda in modules

ChuanqiXu created this revision. ChuanqiXu added reviewers: urnathan, aaron.ballman, dblaikie, rsmith, erichkeane, efriedma, gbenyei. ChuanqiXu added a project: clang. ChuanqiXu requested review of this revision. Herald added a subscriber: cfe-commits. This tries to solve

[PATCH] D118016: [clang-tidy] Change code of SignalHandlerCheck (NFC).

balazske added a comment. The plan is to take over functionality from D91164 , D97960 and D33825 after this change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D117600: [CGCall] Annotate operator new with inaccessiblememonly if AssumeSaneOperatorNew is on

nikic added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:2071 RetAttrs.addAttribute(llvm::Attribute::NoAlias); + FuncAttrs.addAttribute("inaccessiblememonly"); +} This should be `Attribute::InacccessibleMemOnly`. It's not

[PATCH] D117522: [clang-tidy] Add modernize-macro-to-enum check

LegalizeAdulthood updated this revision to Diff 402415. LegalizeAdulthood added a comment. Testing on iterated dynamics revealed a number of shortcomings; update the code to address those: - Improve handling of include guards - Handle conditional compilation blocks better - Reject macros that

[PATCH] D118011: [RISCV] Adjust predicates and update intrinsic for clmul and clmulh in Zbkc extension

Jimerlife added a comment. In D118011#3265071 , @craig.topper wrote: > Will you also be updating clang's RISCVBuiltins.def? > > Can you add tests? I update BuiltinsRISCV.def and add "__builtin_riscv_clmul_kc" intrinsic for zbkc extension, but I am not

[PATCH] D117520: [clang-format] Fix SeparateDefinitionBlocks issues

curdeius accepted this revision. curdeius added a comment. LGTM. Comment at: clang/lib/Format/DefinitionBlockSeparator.cpp:141-145 +if (NextLine->MightBeFunctionDecl && +NextLine->mightBeFunctionDefinition()) + if (NextLine->First->NewlinesBefore

[clang] 81793bd - [clang-format] Assert Line->First and State.NextToken->Previous. NFC.

Author: Marek Kurdej Date: 2022-01-24T09:36:46+01:00 New Revision: 81793bd276afefea0e525307676181478fc614c9 URL: https://github.com/llvm/llvm-project/commit/81793bd276afefea0e525307676181478fc614c9 DIFF: https://github.com/llvm/llvm-project/commit/81793bd276afefea0e525307676181478fc614c9.diff

[PATCH] D118011: [RISCV] Adjust predicates and update intrinsic for clmul and clmulh in Zbkc extension

Jimerlife updated this revision to Diff 402414. Jimerlife retitled this revision from "[RISCV][NFC] Add "zbkc" predicate for clmul and clmulh pattern" to "[RISCV] Adjust predicates and update intrinsic for clmul and clmulh in Zbkc extension ". Jimerlife edited the summary of this revision.

[PATCH] D117862: [clang][tests] Fix a typo in wasm-toolchain.cpp tests

This revision was automatically updated to reflect the committed changes. Closed by commit rG3ad6de31c0cf: [clang][tests] Fix a c++/libc++ -stdlib value typo (authored by tbaeder). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117862/new/

[clang] ba84578 - [clang][sema] Add missing diagnostic parameter

Author: Timm Bäder Date: 2022-01-24T09:59:20+01:00 New Revision: ba845787b3fdd03380b8651d6ce11afeac9d6bba URL: https://github.com/llvm/llvm-project/commit/ba845787b3fdd03380b8651d6ce11afeac9d6bba DIFF: https://github.com/llvm/llvm-project/commit/ba845787b3fdd03380b8651d6ce11afeac9d6bba.diff

[PATCH] D118011: [RISCV] Adjust predicates and update intrinsic for clmul and clmulh in Zbkc extension

craig.topper added inline comments. Comment at: llvm/include/llvm/IR/IntrinsicsRISCV.td:91 - // Zbc + // ZbcorZbkc def int_riscv_clmul : BitManipGPRGPRIntrinsics; Add spaces around “or” Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 3ad6de3 - [clang][tests] Fix a c++/libc++ -stdlib value typo

Author: Timm Bäder Date: 2022-01-24T09:59:20+01:00 New Revision: 3ad6de31c0cf5064867e6f9bf99e27e0b5c4128d URL: https://github.com/llvm/llvm-project/commit/3ad6de31c0cf5064867e6f9bf99e27e0b5c4128d DIFF: https://github.com/llvm/llvm-project/commit/3ad6de31c0cf5064867e6f9bf99e27e0b5c4128d.diff

[PATCH] D116595: [clang][sema] Add missing diagnostic parameter

This revision was automatically updated to reflect the committed changes. Closed by commit rGba845787b3fd: [clang][sema] Add missing diagnostic parameter (authored by tbaeder). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116595/new/

[PATCH] D118021: [Driver] Use libatomic for 32-bit SPARC atomics support

joerg added inline comments. Comment at: clang/lib/Driver/ToolChains/Solaris.cpp:135 } +// LLVM lacks atomics support on 32-bit SPARC, so forcibly link with +// libatomic as a workaround. This comment is misleading. It's not so much that LLVM

[PATCH] D118021: [Driver] Use libatomic for 32-bit SPARC atomics support

glaubitz added inline comments. Comment at: clang/lib/Driver/ToolChains/Solaris.cpp:135 } +// LLVM lacks atomics support on 32-bit SPARC, so forcibly link with +// libatomic as a workaround. ro wrote: > glaubitz wrote: > > joerg wrote: > > > This

[PATCH] D112646: [clang-tidy] Add `readability-container-contains` check

whisperity added a comment. In D112646#3251025 , @avogelsgesang wrote: > @xazax.hun Can you please merge this to `main` on my behalf? (I don't have > commit rights) Hey! Sorry for my absence, I'm terribly busy with doing stuffs  I'll check the patch

[PATCH] D117881: [X86] Remove avx512f integer and/or/xor/min/max reduction intrinsics and use generic equivalents

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe4074432d5bf: [X86] Remove avx512f integer and/or/xor/min/max reduction intrinsics and use… (authored by RKSimon). Repository: rG LLVM Github

[PATCH] D118021: [Driver] Use libatomic for 32-bit SPARC atomics support

glaubitz added a comment. Ah, I actually ran into this very problem! Thanks for fixing this. Will test this today on Linux and report back! Could you maybe have a look at my updated revision here? https://reviews.llvm.org/D98575 I think this particular change should be save on Solaris as

[PATCH] D117181: [PowerPC] Use IEEE long double in proper toolchain

qiucf added a comment. In D117181#3262288 , @jsji wrote: >> Won't that end up producing a warning on ALL code built on any Linux distro >> with a GCC toolchain older than 12.1? That would be terrible. > > Good point. Yes, so should be something like: >

[PATCH] D118021: [Driver] Use libatomic for 32-bit SPARC atomics support

glaubitz added inline comments. Comment at: clang/lib/Driver/ToolChains/Solaris.cpp:135 } +// LLVM lacks atomics support on 32-bit SPARC, so forcibly link with +// libatomic as a workaround. joerg wrote: > This comment is misleading. It's not so

[PATCH] D107769: [OpenCL] Make generic addrspace optional for -fdeclare-opencl-builtins

Anastasia added a comment. Herald added a subscriber: Naghasan. In D107769#3064171 , @svenvh wrote: > In D107769#2967565 , @Anastasia > wrote: > >> In D107769#2960441 ,

[PATCH] D112646: [clang-tidy] Add `readability-container-contains` check

This revision was automatically updated to reflect the committed changes. Closed by commit rG3696c70e67d9: [clang-tidy] Add `readability-container-contains` check (authored by avogelsgesang, committed by whisperity). Changed prior to commit:

[clang-tools-extra] 3696c70 - [clang-tidy] Add `readability-container-contains` check

Author: Adrian Vogelsgesang Date: 2022-01-24T12:57:18+01:00 New Revision: 3696c70e67d9b9e54307ef25077bae7a6f76636e URL: https://github.com/llvm/llvm-project/commit/3696c70e67d9b9e54307ef25077bae7a6f76636e DIFF:

[PATCH] D118011: [RISCV] Adjust predicates and update intrinsic for clmul and clmulh in Zbkc extension

Jimerlife updated this revision to Diff 402426. Jimerlife added a comment. add spaces around "or" Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118011/new/ https://reviews.llvm.org/D118011 Files: clang/include/clang/Basic/BuiltinsRISCV.def

[PATCH] D118023: Corrected fragment size for tf32 LD B matrix.

JackAKirk added a comment. Note that the test, llvm/test/CodeGen/NVPTX/wmma.py line 210, had the correct value already but didn't seem to cover the mistake. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118023/new/

[PATCH] D118021: [Driver] Use libatomic for 32-bit SPARC atomics support

ro added inline comments. Comment at: clang/lib/Driver/ToolChains/Solaris.cpp:135 } +// LLVM lacks atomics support on 32-bit SPARC, so forcibly link with +// libatomic as a workaround. glaubitz wrote: > joerg wrote: > > This comment is misleading.

[PATCH] D118021: [Driver] Use libatomic for 32-bit SPARC atomics support

ro added inline comments. Comment at: clang/lib/Driver/ToolChains/Solaris.cpp:135 } +// LLVM lacks atomics support on 32-bit SPARC, so forcibly link with +// libatomic as a workaround. glaubitz wrote: > ro wrote: > > glaubitz wrote: > > > joerg

[PATCH] D118021: [Driver] Use libatomic for 32-bit SPARC atomics support

glaubitz added inline comments. Comment at: clang/lib/Driver/ToolChains/Solaris.cpp:138-139 +if (getToolChain().getTriple().getArch() == llvm::Triple::sparc) { + CmdArgs.push_back(getAsNeededOption(getToolChain(), true)); + CmdArgs.push_back("-latomic"); +

[PATCH] D112646: [clang-tidy] Add `readability-container-contains` check

xazax.hun added a comment. In D112646#3264010 , @avogelsgesang wrote: > @xazax.hun ping re merging this to `main`. Would be amazing to get this in > still in time for clang 14. Sorry for the delay. I'm on vacation at the moment and will not be able to

[PATCH] D118015: [RISCV][NFC] Rename RequiredExtensions to RequiredFeatures.

asb added a comment. Makes sense to me, but I'll defer to someone else working more actively with this part of the codebase for a final LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118015/new/ https://reviews.llvm.org/D118015

[clang] 3e50593 - [X86] Remove `__builtin_ia32_pmax/min` intrinsics and use generic `__builtin_elementwise_max/min`

Author: Simon Pilgrim Date: 2022-01-24T11:40:29Z New Revision: 3e50593b18840ab4508a25d0f761afb65535a38d URL: https://github.com/llvm/llvm-project/commit/3e50593b18840ab4508a25d0f761afb65535a38d DIFF: https://github.com/llvm/llvm-project/commit/3e50593b18840ab4508a25d0f761afb65535a38d.diff

[PATCH] D112646: [clang-tidy] Add `readability-container-contains` check

whisperity accepted this revision. whisperity added a comment. In D112646#3265670 , @whisperity wrote: > Please specify what name and e-mail address you'd like to have the Git commit > author attributed with! Nevermind, I forgot that you commented

[PATCH] D118021: [Driver] Use libatomic for 32-bit SPARC atomics support

ro created this revision. ro added reviewers: jyknight, venkatra, efriedma, jrtc27. ro added a project: clang. Herald added a subscriber: fedor.sergeev. ro requested review of this revision. Herald added a subscriber: cfe-commits. Even after D86621 , `clang -m32`

[PATCH] D117306: [clang-tidy] Add new check 'shared-ptr-array-mismatch'.

balazske updated this revision to Diff 402439. balazske added a comment. Fixed small issues. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117306/new/ https://reviews.llvm.org/D117306 Files:

[PATCH] D118021: [Driver] Use libatomic for 32-bit SPARC atomics support

glaubitz added inline comments. Comment at: clang/lib/Driver/ToolChains/Solaris.cpp:138-139 +if (getToolChain().getTriple().getArch() == llvm::Triple::sparc) { + CmdArgs.push_back(getAsNeededOption(getToolChain(), true)); + CmdArgs.push_back("-latomic"); +

[PATCH] D118023: Corrected fragment size for tf32 LD B matrix.

JackAKirk created this revision. JackAKirk added a reviewer: tra. JackAKirk requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Signed-off-by: JackAKirk Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D118023 Files:

[clang] e5147f8 - [X86] Remove __builtin_ia32_pabs intrinsics and use generic __builtin_elementwise_abs

Author: Simon Pilgrim Date: 2022-01-24T11:25:21Z New Revision: e5147f82e1cba6791252d8f44c1a014cd9ea7927 URL: https://github.com/llvm/llvm-project/commit/e5147f82e1cba6791252d8f44c1a014cd9ea7927 DIFF: https://github.com/llvm/llvm-project/commit/e5147f82e1cba6791252d8f44c1a014cd9ea7927.diff

[clang] e407443 - [X86] Remove avx512f integer and/or/xor/min/max reduction intrinsics and use generic equivalents

Author: Simon Pilgrim Date: 2022-01-24T11:57:53Z New Revision: e4074432d5bf5c295f96eeed27c5b693f5b3bf16 URL: https://github.com/llvm/llvm-project/commit/e4074432d5bf5c295f96eeed27c5b693f5b3bf16 DIFF: https://github.com/llvm/llvm-project/commit/e4074432d5bf5c295f96eeed27c5b693f5b3bf16.diff

[PATCH] D118018: [RFC] [C+++20] [Modules] Mangling lambda in modules

urnathan added a comment. I don't think this is wanted. there are two cases: a) lambda is attached to some ODR-visible entitity. Something like (in module-purview at namespace-scope) '[maybe-export] auto var = []{};'. Here the lambda acquires 'var' as its context. b) lambda is not attached

[PATCH] D117301: [clang][NFC] Wrap TYPE_SWITCH in "do while (0)" in the interpreter

RKSimon accepted this revision. RKSimon added a comment. This revision is now accepted and ready to land. LGTM - cheers CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117301/new/ https://reviews.llvm.org/D117301 ___ cfe-commits mailing list

[PATCH] D118034: [C++20] [Modules] Don't complain about duplicated default template argument across modules

ChuanqiXu created this revision. ChuanqiXu added reviewers: rsmith, urnathan, aaron.ballman, erichkeane. ChuanqiXu added a project: clang. ChuanqiXu requested review of this revision. Herald added a subscriber: cfe-commits. See https://github.com/cplusplus/draft/pull/5204 for a detailed

[PATCH] D107769: [OpenCL] Make generic addrspace optional for -fdeclare-opencl-builtins

svenvh added a comment. In D107769#3265665 , @Anastasia wrote: > The way I understand the spec for OpenCL C 2.0 is that whenever the address > space of the pointer is not listed it means generic has to be used, here is > one example: >

[PATCH] D118011: [RISCV] Adjust predicates and update intrinsic for clmul and clmulh in Zbkc extension

liaolucy added a comment. clang Zbkc patch: https://reviews.llvm.org/D112774， If there are any mistakes, you can help to point them out Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118011/new/ https://reviews.llvm.org/D118011

[PATCH] D116085: [clang-tidy] Performance improvements for NOLINTBEGIN/END blocks

kadircet added inline comments. Comment at: clang-tools-extra/clang-tidy/ClangTidyDiagnosticConsumer.cpp:214 + std::string CheckName = getCheckName(Info.getID()); + return NoLintHandler.shouldSuppress(DiagLevel, Info, CheckName, NoLintErrors); +} we don't

[PATCH] D118038: [clang][dataflow] Enable merging distinct values in Environment::join

sgatev updated this revision to Diff 402490. sgatev added a comment. Add missing include. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118038/new/ https://reviews.llvm.org/D118038 Files:

[PATCH] D118018: [RFC] [C+++20] [Modules] Mangling lambda in modules

ChuanqiXu added a comment. In D118018#3265810 , @urnathan wrote: > I don't think this is wanted. there are two cases: > a) lambda is attached to some ODR-visible entitity. Something like (in > module-purview at namespace-scope) '[maybe-export] auto

[PATCH] D118018: [RFC] [C+++20] [Modules] Mangling lambda in modules

urnathan added a comment. sure, please reassign them Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118018/new/ https://reviews.llvm.org/D118018 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D91000: [clang-tidy] Add cert-msc24-c checker.

whisperity added a reviewer: whisperity. whisperity added a comment. Herald added a subscriber: rnkovacs. Bump! Thanks @futogergely for picking up @ktomi996's work, and @steakhal for the help given during the implementation process! In D91000#3231417 ,

[PATCH] D118038: [clang][dataflow] Enable merging distinct values in Environment::join

sgatev created this revision. sgatev added reviewers: ymandel, xazax.hun, gribozavr2. Herald added subscribers: steakhal, rnkovacs. sgatev requested review of this revision. Herald added a project: clang. Make specializations of `DataflowAnalysis` extendable with domain-specific logic for merging

[PATCH] D117846: [ASTMatchers] Add `isConstinit` matcher

aaron.ballman closed this revision. aaron.ballman added a comment. I've commit on your behalf in 589a93907222cf2380198ca2172ff6697dd43d87 , thanks for the new matcher! Repository: rG LLVM Github Monorepo CHANGES SINCE

[clang] 589a939 - Add `isConstinit` matcher

Author: Evgeny Shulgin Date: 2022-01-24T08:35:42-05:00 New Revision: 589a93907222cf2380198ca2172ff6697dd43d87 URL: https://github.com/llvm/llvm-project/commit/589a93907222cf2380198ca2172ff6697dd43d87 DIFF:

[PATCH] D112646: [clang-tidy] Add `readability-container-contains` check

avogelsgesang added a comment. Thanks, @xazax.hun and @whisperity for helping me to get this over the finish line! :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112646/new/ https://reviews.llvm.org/D112646

[PATCH] D116387: [CodeCompletion][clangd] Clean __uglified parameter names in completion & hover

hokein added inline comments. Comment at: clang-tools-extra/clangd/Hover.cpp:65 Base.SuppressTemplateArgsInCXXConstructors = true; + Base.CleanUglifiedParameters = true; return Base; IIUC, the code looks like we change the hover behavior as well, but I

[PATCH] D117091: [Clang] Add attributes alloc_size and alloc_align to mm_malloc

xbolva00 added a comment. Ping @reames CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117091/new/ https://reviews.llvm.org/D117091 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D118011: [RISCV] Adjust predicates and update intrinsic for clmul and clmulh in Zbkc extension

alextsao1999 added a comment. In D118011#3265374 , @Jimerlife wrote: > In D118011#3265071 , @craig.topper > wrote: > >> Will you also be updating clang's RISCVBuiltins.def? >> >> Can you add tests? > > I update

[PATCH] D117846: [ASTMatchers] Add `isConstinit` matcher

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117846/new/ https://reviews.llvm.org/D117846

[PATCH] D98110: [NFC][clangd] Use table to collect option aliases

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks, lgtm! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98110/new/ https://reviews.llvm.org/D98110

[clang-tools-extra] a0d5e93 - Add missing include llvm/ADT/STLExtras

Author: serge-sans-paille Date: 2022-01-24T14:41:24+01:00 New Revision: a0d5e938fe9c1fd6ca492a91cdc3d841aa03fc0d URL: https://github.com/llvm/llvm-project/commit/a0d5e938fe9c1fd6ca492a91cdc3d841aa03fc0d DIFF:

[clang] 5e5efd8 - [clang-format] Fix SeparateDefinitionBlocks issues

Author: ksyx Date: 2022-01-24T14:23:20Z New Revision: 5e5efd8a91f2e340e79a73bedbc6ab66ad4a4281 URL: https://github.com/llvm/llvm-project/commit/5e5efd8a91f2e340e79a73bedbc6ab66ad4a4281 DIFF: https://github.com/llvm/llvm-project/commit/5e5efd8a91f2e340e79a73bedbc6ab66ad4a4281.diff LOG:

[PATCH] D117520: [clang-format] Fix SeparateDefinitionBlocks issues

This revision was automatically updated to reflect the committed changes. ksyx marked 2 inline comments as done. Closed by commit rG5e5efd8a91f2: [clang-format] Fix SeparateDefinitionBlocks issues (authored by ksyx). Changed prior to commit:

[PATCH] D118038: [clang][dataflow] Enable merging distinct values in Environment::join

xazax.hun added a comment. Interesting. So clients can affect how the environment is being merged. As a result, we potentially cannot run multiple clients in the same fixed-point iteration, each of them will require separate passes. I think this is OK, just wanted to to be explicit.

[PATCH] D117181: [PowerPC] Use IEEE long double in proper toolchain

jsji added a comment. > Besides, would it be acceptable that we add a variable to cmake to determine > default long double semantics (like current GCC)? Yes, we can. But I think that can be in another patch, and we shouldn't rely on it -- as we shouldn't assume user will config/build

[PATCH] D117939: [clang-tidy] Add more documentation about check development

njames93 added a comment. @aaron.ballman I think this has exposed some limitations with the add-new-check script. Maybe there is merit for the script to be updated to support preprocessor callbacks and options, WDYT? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117939/new/

[PATCH] D118015: [RISCV][NFC] Rename RequiredExtensions to RequiredFeatures.

khchen accepted this revision. khchen added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118015/new/ https://reviews.llvm.org/D118015

[PATCH] D117939: [clang-tidy] Add more documentation about check development

aaron.ballman added a comment. Thank you so much for working on this documentation, I really like the direction it's going! Comment at: clang-tools-extra/docs/clang-tidy/Contributing.rst:78 +build :program:`clang-tidy`. +Since your new check will have associated

[PATCH] D116266: [SPIR-V] Add linking of separate translation units using spirv-link

bader added inline comments. Comment at: clang/docs/UsersManual.rst:3602 +Linking is done using ``spirv-link`` from `the SPIRV-Tools project +`_. Similar to other external @Anastasia, sorry for late

[PATCH] D93298: [RISCV] add the MC layer support of Zfinx extension

asb added a comment. Herald added a subscriber: pcwang-thead. Thanks for your work on this. The way you've managed to use multiclasses to handle this with the 'ExtInfo' definitions takes a bit of unpicking to follow, but it does a really good job of keeping the instruction definitions largely

[PATCH] D117939: [clang-tidy] Add more documentation about check development

LegalizeAdulthood added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/Contributing.rst:229 +If you need to interact macros and preprocessor directives, you will want to +override the method ``registerPPCallbacks``. The ``add_new_check.py`` script +does not

[PATCH] D117939: [clang-tidy] Add more documentation about check development

LegalizeAdulthood added a comment. In D117939#3266228 , @njames93 wrote: > @aaron.ballman I think this has exposed some limitations with the > add-new-check script. Maybe there is merit for the script to be updated to > support preprocessor callbacks

[PATCH] D93298: [RISCV] add the MC layer support of Zfinx extension

asb added a comment. Not an issue for this MC-layer patch, but I've created https://github.com/riscv/riscv-zfinx/issues/14 to point out what seems to be an incorrect statement about the status quo on the ABI for 32-bit floating point types on RV64 in the Zfinx spec. Repository: rG LLVM

[PATCH] D56303: [clang-tidy] Recognize labelled statements when simplifying boolean exprs

njames93 added a comment. A large portion of the changes, especially in the checks implementation file, appear to be NFC stylistic or formatting only fixes. While these changes are generally good, they shouldn't be a part of this patch. Instead they should be committed in their own NFC patch.

[PATCH] D117795: [AArch64] Fixes for strict FP vector instructions

cameron.mcinally added a comment. Is it possible to break the 4 subtasks into separate reviews? -In clang generate fcmps when appropriate for neon intrinsics -Fix legalization of scalarized strict FP vector operations -Add some missing strict FP handling to AArch64TargetLowering -Adjust

[PATCH] D113237: [RISCV] Support I extension version 2.1

khchen added a comment. Herald added subscribers: pcwang-thead, eopXD. https://groups.google.com/a/groups.riscv.org/g/sw-dev/c/aE1ZeHHCYf4 RISC-V GNU toolchain are going to bump the default ISA spec to 20191213, which means will default with I 2.1, A 2.1, F 2.2 and D 2.2. I think it will be

[PATCH] D115521: [Templight] Don't display empty strings for names of unnamed template parameters

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3ad35ba4dea5: [Templight] Dont display empty strings for names of unnamed template parameters (authored by Szelethus). Changed prior to commit:

[clang] 3ad35ba - [Templight] Don't display empty strings for names of unnamed template parameters

Author: Kristóf Umann Date: 2022-01-24T16:37:11+01:00 New Revision: 3ad35ba4dea5240dd58476f0c85f0fe096d6c7ce URL: https://github.com/llvm/llvm-project/commit/3ad35ba4dea5240dd58476f0c85f0fe096d6c7ce DIFF: https://github.com/llvm/llvm-project/commit/3ad35ba4dea5240dd58476f0c85f0fe096d6c7ce.diff

[PATCH] D118038: [clang][dataflow] Enable merging distinct values in Environment::join

sgatev updated this revision to Diff 402529. sgatev marked an inline comment as done. sgatev added a comment. Address reviewers' comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118038/new/ https://reviews.llvm.org/D118038 Files:

[PATCH] D118038: [clang][dataflow] Enable merging distinct values in Environment::join

sgatev added a comment. Right. To model the behavior of a language feature (e.g. a simple model that tracks whether a `std::optional` value is engaged) clients can attach properties to symbolic values and decide how distinct values are joined. This doesn't completely rule out the possibility

[PATCH] D118011: [RISCV] Adjust predicates and update intrinsic for clmul and clmulh in Zbkc extension

VincentWu added a comment. Hi, Jimerlife it is a great work to implement the intrinsic of `zbkb`. however, I don't know whether you have noticed that there is already to patch https://reviews.llvm.org/D112774 and https://reviews.llvm.org/D102310. these two patches have included almost all the

[PATCH] D115640: [OpenCL] Add support of __opencl_c_device_enqueue feature macro.

Anastasia added inline comments. Comment at: clang/test/Misc/opencl-c-3.0.incorrect_options.cl:21 + // CHECK-FP64: error: options cl_khr_fp64 and __opencl_c_fp64 are set to different values azabaznov wrote: > Anastasia wrote: > > Anastasia wrote: > > > I

[clang] c133516 - Don't run test/ClangScanDeps/modules-symlink.c on Windows

Author: Hans Wennborg Date: 2022-01-24T16:52:01+01:00 New Revision: c1335166b2659b02784b9dfb562c6b8b1c746407 URL: https://github.com/llvm/llvm-project/commit/c1335166b2659b02784b9dfb562c6b8b1c746407 DIFF: https://github.com/llvm/llvm-project/commit/c1335166b2659b02784b9dfb562c6b8b1c746407.diff

[PATCH] D118038: [clang][dataflow] Enable merging distinct values in Environment::join

xazax.hun accepted this revision. xazax.hun added a comment. This revision is now accepted and ready to land. I think the canonical approach most of the time is to have a map lattice that maps from values to your lattice elements. Storing properties directly at the object sounds like an

[PATCH] D117569: Constexpr not supported with __declspec(dllimport).

zahiraam added a comment. In D117569#3262595 , @zahiraam wrote: > @majnemer > > I did take an example completely different with no use of the constexpr in > order to understand (at least for me) when the _imp prefix is generated with > CL. > This is

[PATCH] D107769: [OpenCL] Make generic addrspace optional for -fdeclare-opencl-builtins

Anastasia added a comment. In D107769#3265867 , @svenvh wrote: > In D107769#3265665 , @Anastasia > wrote: > >> The way I understand the spec for OpenCL C 2.0 is that whenever the address >> space of the pointer

[PATCH] D117929: [XRay] Add support for RISCV

ashwin98 updated this revision to Diff 402533. ashwin98 added a comment. Herald added a subscriber: pcwang-thead. Updated the diff, made the following changes: 1. Merged the riscv files into xray_riscv.cpp and removed the if-else code for %hi() 2. Cleaned up the issues related to indenting and

[PATCH] D117899: [OpenCL] Make read_write images optional for -fdeclare-opencl-builtins

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117899/new/ https://reviews.llvm.org/D117899

[PATCH] D115921: [RISCV] Refactor the RISCV ISA extension info and target features to support multiple extension version

khchen added a comment. Herald added subscribers: pcwang-thead, eopXD. In D115921#3206434 , @luismarques wrote: > I think this would benefit from increased test coverage, namely to show that > the mattr command-line options are properly handled. Some

[clang] 50999e8 - [clang-format] Space between attribute closing parenthesis and qualified type colon.

Author: Marek Kurdej Date: 2022-01-24T18:09:20+01:00 New Revision: 50999e82e8844615b1ae53edb9d56cdcace91b04 URL: https://github.com/llvm/llvm-project/commit/50999e82e8844615b1ae53edb9d56cdcace91b04 DIFF: https://github.com/llvm/llvm-project/commit/50999e82e8844615b1ae53edb9d56cdcace91b04.diff

[PATCH] D117894: [clang-format] Space between attribute closing parenthesis and qualified type colon.

This revision was automatically updated to reflect the committed changes. Closed by commit rG50999e82e884: [clang-format] Space between attribute closing parenthesis and qualified type… (authored by curdeius). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D117913: [Clang][RISCV] Guard vmulh, vsmul correctly

craig.topper accepted this revision. craig.topper added a comment. Still LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117913/new/ https://reviews.llvm.org/D117913 ___ cfe-commits mailing list

[PATCH] D117391: [AST] Ignore implicit nodes in CastExpr::getConversionFunction

kimgr added a comment. @rsmith Weekly ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117391/new/ https://reviews.llvm.org/D117391 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D117994: [Clang] Implement multidimentional subscript operator

aaron.ballman added reviewers: rsmith, erichkeane, rjmccall. aaron.ballman added a comment. I've not had the chance to review yet, but adding some more reviewers for better visibility (I've got WG14 meetings coming up so my availability is a bit limited at the moment). Repository: rG LLVM

[PATCH] D118023: Corrected fragment size for tf32 LD B matrix.

tra added a comment. If you are not sure if you have commit access, you probably do not. It must be explicitly granted: https://llvm.org/docs/DeveloperPolicy.html#obtaining-commit-access As for landing the patch, I do it manually with git. Never tried it with `arc`, so I can't say much, except

[PATCH] D114483: [SYCL] Add support for sycl_special_class attribute

zahiraam marked 11 inline comments as done. zahiraam added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:16686-16687 +if (RD->hasAttr()) { + auto *Def = RD->getDefinition(); + if (Def && !Def->hasInitMethod()) +Diag(RD->getLocation(),

[PATCH] D118063: [DONOTSUBMIT] work on prototyping bracket fix its

dgoldman created this revision. Herald added subscribers: usaxena95, kadircet, arphaman. dgoldman requested review of this revision. Herald added projects: clang, clang-tools-extra. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D118063

[PATCH] D118023: Corrected fragment size for tf32 LD B matrix.

tra added a comment. The patch uses a `@gmail.com` email. Should I change it to `JackAKirk ` to match the sign-off email? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118023/new/ https://reviews.llvm.org/D118023

[PATCH] D118038: [clang][dataflow] Enable merging distinct values in Environment::join

sgatev updated this revision to Diff 402550. sgatev added a comment. Address reviewers' comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118038/new/ https://reviews.llvm.org/D118038 Files:

[clang] 7cd441f - [clang][NFC] Wrap TYPE_SWITCH in "do while (0)" in the interpreter

Author: Owen Pan Date: 2022-01-24T09:05:27-08:00 New Revision: 7cd441ff537e00c743236658bfbcfc16c30ce031 URL: https://github.com/llvm/llvm-project/commit/7cd441ff537e00c743236658bfbcfc16c30ce031 DIFF: https://github.com/llvm/llvm-project/commit/7cd441ff537e00c743236658bfbcfc16c30ce031.diff

  1   2   3   >