[PATCH] D126192: [Driver] Support linking with lld for target AVR

benshi001 updated this revision to Diff 432459. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126192/new/ https://reviews.llvm.org/D126192 Files: clang/lib/Driver/ToolChains/AVR.cpp clang/test/Driver/Inputs/basic_avr_tree/usr/lib/avr/lib/ldscripts/avr5.xn

[PATCH] D126192: [Driver] Support linking with lld for target AVR

benshi001 added inline comments. Comment at: clang/lib/Driver/ToolChains/AVR.cpp:461 << CPU; - } else if (TC.getGCCInstallPath().empty()) { -// We can not link since there is no avr-ld. benshi001 wrote: > This check is no longer needed,

[PATCH] D126192: [Driver] Support linking with lld for target AVR

benshi001 updated this revision to Diff 432457. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126192/new/ https://reviews.llvm.org/D126192 Files: clang/lib/Driver/ToolChains/AVR.cpp clang/test/Driver/Inputs/basic_avr_tree/usr/bin/ld.lld

[PATCH] D126192: [Driver] Support linking with lld for target AVR

benshi001 marked 2 inline comments as done. benshi001 added inline comments. Comment at: clang/lib/Driver/ToolChains/AVR.cpp:435 - std::string Linker = getToolChain().GetProgramPath(getShortName()); + // Compute the linker program path, and use GNU "avr-ld" as default. +

[PATCH] D125499: Enabling the detection of devtoolset-11 toolchain.

tstellar added a comment. I'm curious what is your system configuration where this patch actually allows for detection of devtoolset? I noticed that if clang and gcc are both installed to /usr/, then driver will pick the gcc in /usr/ over the one in /opt/rh/.../ Repository: rG LLVM Github

[PATCH] D126192: [Driver] Support linking with lld for target AVR

benshi001 updated this revision to Diff 432460. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126192/new/ https://reviews.llvm.org/D126192 Files: clang/include/clang/Basic/DiagnosticDriverKinds.td clang/lib/Driver/ToolChains/AVR.cpp

[PATCH] D126192: [Driver] Support linking with lld for target AVR

benshi001 added inline comments. Comment at: clang/lib/Driver/ToolChains/AVR.cpp:528 + CmdArgs.push_back(Args.MakeArgString("-T")); + CmdArgs.push_back(Args.MakeArgString(Prefix + *FamilyName + ".x")); +} Though I can seperate my AVR

[PATCH] D126189: [C++20][Modules] Build module static initializers per P1874R1.

ChuanqiXu added inline comments. Comment at: clang/include/clang/AST/ASTContext.h:476 + /// For module code-gen cases, this is the top-level module we are building. + mutable Module *PrimaryModule = nullptr; + The name `PrimaryModule` looks confusing.

[PATCH] D126438: [clang-format] Fix an invalid code generation in RemoveBracesLLVM

curdeius accepted this revision. curdeius added a comment. This revision is now accepted and ready to land. LGTM. Good catch for this bug! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126438/new/ https://reviews.llvm.org/D126438

[PATCH] D126451: [Clang][CSKY] Add support about CSKYABIInfo

zixuan-wu added a comment. In D126451#3539512 , @DavidSpickett wrote: > Can you reupload with more context? See > https://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface > > I doubt I'll be able to give any in depth review but

[clang] 85750de - Use the canonical type when matching a generic selection association

Author: Aaron Ballman Date: 2022-05-26T07:42:13-04:00 New Revision: 85750de685f543443ec38c407392d9d7cdc19451 URL: https://github.com/llvm/llvm-project/commit/85750de685f543443ec38c407392d9d7cdc19451 DIFF: https://github.com/llvm/llvm-project/commit/85750de685f543443ec38c407392d9d7cdc19451.diff

[PATCH] D126380: [clang][AArch64][SVE] Implicit conversions for vector-scalar operations

c-rhodes added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:13534-13556 // Strip vector types. if (isa(Source)) { if (Target->isVLSTBuiltinType() && (S.Context.areCompatibleSveTypes(QualType(Target, 0),

[PATCH] D126451: [Clang][CSKY] Add support about CSKYABIInfo

DavidSpickett added a comment. Can you reupload with more context? See https://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface I doubt I'll be able to give any in depth review but if things look good generally I'm sure you'll find the issues through your own testing as

[clang] ad1d60c - [FileCheck] Catch missspelled directives.

Author: Ivan Kosarev Date: 2022-05-26T11:37:19+01:00 New Revision: ad1d60c3befd606d6864b367f939238e50fb0f7e URL: https://github.com/llvm/llvm-project/commit/ad1d60c3befd606d6864b367f939238e50fb0f7e DIFF: https://github.com/llvm/llvm-project/commit/ad1d60c3befd606d6864b367f939238e50fb0f7e.diff

[PATCH] D125604: [FileCheck] Catch missspelled directives.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGad1d60c3befd: [FileCheck] Catch missspelled directives. (authored by kosarev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D126377: [clang][AArch64][SVE] Improve diagnostics for SVE operators

c-rhodes added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:10609-10614 - if (RHSType->isVLSTBuiltinType() && !LHSType->isVLSTBuiltinType()) { -auto DestType = tryScalableVectorConvert((IsCompAssign ? nullptr : ), -

[PATCH] D126365: [git-clang-format] Stop ignoring changes for files with space in path

Eitot updated this revision to Diff 432221. Eitot added a comment. I have uploaded a complete diff. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126365/new/ https://reviews.llvm.org/D126365 Files: clang/tools/clang-format/git-clang-format

[PATCH] D126451: [Clang][CSKY] Add support about CSKYABIInfo

zixuan-wu updated this revision to Diff 432228. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126451/new/ https://reviews.llvm.org/D126451 Files: clang/lib/CodeGen/TargetInfo.cpp clang/test/CodeGen/CSKY/csky-abi.c clang/test/CodeGen/CSKY/csky-hard-abi.c Index:

[PATCH] D125604: [FileCheck] Catch missspelled directives.

kosarev added a comment. Committing this revealed some more failures, fixed in rG8894c05b0d351f998b1836542ba791247394bd12 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D126406: [analyzer] Return from reAssume if State is posteriorly overconstrained

steakhal accepted this revision. steakhal added a comment. This revision is now accepted and ready to land. Typo; other than that LGTM Comment at: clang/include/clang/StaticAnalyzer/Core/PathSensitive/ProgramState.h:118 + // Make internal constraint solver entities friends

[PATCH] D126189: [C++20][Modules] Build module static initializers per P1874R1.

iains updated this revision to Diff 432241. iains marked 14 inline comments as done. iains added a comment. address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126189/new/ https://reviews.llvm.org/D126189 Files:

[PATCH] D126364: Fix interaction of pragma FENV_ACCESS with other pragmas

sepavloff added a comment. In D126364#3537964 , @efriedma wrote: > Could you lay out the expected interaction between "STDC FENV_ACCESS", "clang > fp exceptions", "float_control", and "fenv_access"? If there's some way to > map everything to "#pragma

[PATCH] D126189: [C++20][Modules] Build module static initializers per P1874R1.

iains added a comment. not sure why the Debian clang-format is complaining - I am using llvm-14's clang-format with git clang-format + arc. Comment at: clang/include/clang/AST/ASTContext.h:476 + /// For module code-gen cases, this is the top-level module we are building. +

[PATCH] D126451: [Clang][CSKY] Add support about CSKYABIInfo

rengolin added a comment. This looks good to me, but wait to make sure others see it, too. My reasons are: it is largely similar to RISCV implementation, it seems to follow what I expected of the ABI (which is similar to other targets) and has a large corpus of tests. I can't comment on the

[PATCH] D126189: [C++20][Modules] Build module static initializers per P1874R1.

ChuanqiXu added inline comments. Comment at: clang/lib/CodeGen/CGDeclCXX.cpp:699 +Guard = new llvm::GlobalVariable(getModule(), Int8Ty, /*isConstant=*/false, + llvm::GlobalVariable::InternalLinkage, +

[PATCH] D126406: [analyzer] Return from reAssume if State is posteriorly overconstrained

martong updated this revision to Diff 432225. martong marked 5 inline comments as done. martong added a comment. - Make reAssume friend, pin the target in the test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126406/new/

[PATCH] D126406: [analyzer] Return from reAssume if State is posteriorly overconstrained

martong added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/PathSensitive/ProgramState.h:127 + +public: bool isPosteriorlyOverconstrained() const { steakhal wrote: > This shouldnt be the way. > Consider fwd declaring and making it

[PATCH] D126451: [Clang][CSKY] Add support about CSKYABIInfo

zixuan-wu created this revision. zixuan-wu added reviewers: rengolin, DavidSpickett. Herald added a project: All. zixuan-wu requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. According to the CSKY ABIv2 document

[PATCH] D126137: [X86] Add support for `-mharden-sls=all`

pengfei added inline comments. Comment at: llvm/lib/Target/X86/X86AsmPrinter.cpp:346 + auto IsIndirectTailCall = [I, ]() { +return Desc.isCall() && Desc.isReturn() && Desc.isBarrier() && + !I->getOperand(0).isGlobal(); nickdesaulniers

[PATCH] D126420: [clang][dataflow] Remove private-field filtering from `StorageLocation` creation.

ymandel updated this revision to Diff 432249. ymandel added a comment. address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126420/new/ https://reviews.llvm.org/D126420 Files:

[clang] d4d28f2 - [clang-format] Fix QualifierAlignment with global namespace qualified types.

Author: Marek Kurdej Date: 2022-05-26T15:02:33+02:00 New Revision: d4d28f2ace764a0420a33462628b43a1c71fc3dc URL: https://github.com/llvm/llvm-project/commit/d4d28f2ace764a0420a33462628b43a1c71fc3dc DIFF: https://github.com/llvm/llvm-project/commit/d4d28f2ace764a0420a33462628b43a1c71fc3dc.diff

[PATCH] D126096: [clang-format] Fix QualifierAlignment with global namespace qualified types.

This revision was automatically updated to reflect the committed changes. Closed by commit rGd4d28f2ace76: [clang-format] Fix QualifierAlignment with global namespace qualified types. (authored by curdeius). Changed prior to commit: https://reviews.llvm.org/D126096?vs=431074=432258#toc

[PATCH] D125986: [clang][ASTImporter] Add support for import of UsingPackDecl.

martong accepted this revision. martong added a comment. This revision is now accepted and ready to land. LGTM! Thanks! And sorry for the delay in the review, please ping me next time. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125986/new/

[PATCH] D125848: [clang-format] Handle attributes in enum declaration.

This revision was automatically updated to reflect the committed changes. Closed by commit rG8f70d16c9ab2: [clang-format] Handle attributes in enum declaration. (authored by tchatow, committed by curdeius). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 8f70d16 - [clang-format] Handle attributes in enum declaration.

Author: Tyler Chatow Date: 2022-05-26T15:43:57+02:00 New Revision: 8f70d16c9ab2d7c060f5c92a31a0fc4a82349897 URL: https://github.com/llvm/llvm-project/commit/8f70d16c9ab2d7c060f5c92a31a0fc4a82349897 DIFF: https://github.com/llvm/llvm-project/commit/8f70d16c9ab2d7c060f5c92a31a0fc4a82349897.diff

[PATCH] D126420: [clang][dataflow] Remove private-field filtering from `StorageLocation` creation.

ymandel marked 3 inline comments as done. ymandel added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/DataflowEnvironment.cpp:407 for (const FieldDecl *Field : getAccessibleObjectFields(Type)) { assert(Field != nullptr); sgatev

[PATCH] D125318: [analyzer] Add UnarySymExpr

martong added inline comments. Comment at: clang/test/Analysis/unary-sym-expr.c:35 +return; + clang_analyzer_eval(-(x + y) == -3); // expected-warning{{TRUE}} +} steakhal wrote: > martong wrote: > > steakhal wrote: > > > Does it work if you swap x and y? >

[clang] cd5783d - [analyzer][solver] Handle UnarySymExpr in SMTConv

Author: Gabor Marton Date: 2022-05-26T14:14:10+02:00 New Revision: cd5783d3e82b98bfa140853fee95170852fd3c74 URL: https://github.com/llvm/llvm-project/commit/cd5783d3e82b98bfa140853fee95170852fd3c74 DIFF: https://github.com/llvm/llvm-project/commit/cd5783d3e82b98bfa140853fee95170852fd3c74.diff

[PATCH] D125395: [analyzer][solver] Handle UnarySymExpr in RangeConstraintSolver

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG88abc50398eb: [analyzer][solver] Handle UnarySymExpr in RangeConstraintSolver (authored by martong). Changed prior to commit:

[PATCH] D125547: [analyzer][solver] Handle UnarySymExpr in SMTConv

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGcd5783d3e82b: [analyzer][solver] Handle UnarySymExpr in SMTConv (authored by martong). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang] b5b2aec - [analyzer] Add UnarySymExpr

Author: Gabor Marton Date: 2022-05-26T14:00:27+02:00 New Revision: b5b2aec1ff51197343dede9741ea377f8314d41b URL: https://github.com/llvm/llvm-project/commit/b5b2aec1ff51197343dede9741ea377f8314d41b DIFF: https://github.com/llvm/llvm-project/commit/b5b2aec1ff51197343dede9741ea377f8314d41b.diff

[clang] 88abc50 - [analyzer][solver] Handle UnarySymExpr in RangeConstraintSolver

Author: Gabor Marton Date: 2022-05-26T14:09:46+02:00 New Revision: 88abc50398eb26d536518270b91939ce18687305 URL: https://github.com/llvm/llvm-project/commit/88abc50398eb26d536518270b91939ce18687305 DIFF: https://github.com/llvm/llvm-project/commit/88abc50398eb26d536518270b91939ce18687305.diff

[PATCH] D125318: [analyzer] Add UnarySymExpr

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. martong marked 2 inline comments as done. Closed by commit rGb5b2aec1ff51: [analyzer] Add UnarySymExpr (authored by martong). Changed prior to commit:

[PATCH] D126451: [Clang][CSKY] Add support about CSKYABIInfo

DavidSpickett added a comment. Looks good to me. Can you just clarify how the tests are split? My guess is that one is stuff that doesn't vary with hard/soft float and the other is the bits that change when hardfloat is enabled. If so is it worth checking those situations with soft float too

[clang] 6056511 - Fix failing test case with strict prototype changes

Author: Aaron Ballman Date: 2022-05-26T08:46:11-04:00 New Revision: 605651135b4c37e423825a9201b06a16ff6160a1 URL: https://github.com/llvm/llvm-project/commit/605651135b4c37e423825a9201b06a16ff6160a1 DIFF: https://github.com/llvm/llvm-project/commit/605651135b4c37e423825a9201b06a16ff6160a1.diff

[PATCH] D126289: [Clang][Driver] Fix include paths for `--sysroot /` on Linux

egorzhdan updated this revision to Diff 432256. egorzhdan added a comment. - Remove unnecessary trailing `/` - Add `-SAME` in tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126289/new/ https://reviews.llvm.org/D126289 Files:

[PATCH] D126377: [clang][AArch64][SVE] Improve diagnostics for SVE operators

DavidTruby added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:10614 + (!RHSType->isVLSTBuiltinType() && !RHSType->isRealType())) { +Diag(Loc, diag::err_typecheck_vector_not_convertable_non_scalar) +<< LHSType << RHSType << LHS.get()->getSourceRange()

[PATCH] D125400: [clang][Analyzer] Add errno state to standard functions modeling.

martong added a comment. Nice work, looks promising! Once this https://reviews.llvm.org/D125400?vs=431909=431924#inline-1206369 is addressed I will accept. Comment at: clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp:2273 +// here) may indicate failure.

[PATCH] D126302: [PowerPC] Diagnose invalid combination with Altivec, VSX and soft-float

amyk added inline comments. Comment at: clang/lib/Basic/Targets/PPC.cpp:452 + if (llvm::is_contained(FeaturesVec, "-hard-float") && + llvm::is_contained(FeaturesVec, "+altivec")) +Diags.Report(diag::err_opt_not_valid_with_opt) << "-msoft-float" Do we

[PATCH] D126061: [clang] [WIP] Reject non-declaration C++11 attributes on declarations

aaron.ballman added inline comments. Comment at: clang/include/clang/Sema/DeclSpec.h:1853-1856 /// Attrs - Attributes. ParsedAttributes Attrs; + ParsedAttributes DeclarationAttrs; mboehme wrote: > aaron.ballman wrote: > > We should probably rename

[clang] 3087afb - [OpenCL][Doc] Misc improvements related to SPIR-V support.

Author: Anastasia Stulova Date: 2022-05-26T15:54:33+01:00 New Revision: 3087afb421bf4ca4450d8981a1410e1a09f3794a URL: https://github.com/llvm/llvm-project/commit/3087afb421bf4ca4450d8981a1410e1a09f3794a DIFF:

[PATCH] D125904: [Cuda] Use fallback method to mangle externalized decls if no CUID given

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1bae02b77335: [Cuda] Use fallback method to mangle externalized decls if no CUID given (authored by jhuber6). Repository: rG LLVM Github Monorepo

[clang] 1bae02b - [Cuda] Use fallback method to mangle externalized decls if no CUID given

Author: Joseph Huber Date: 2022-05-26T09:18:22-04:00 New Revision: 1bae02b77335eb1a01d9a0bb36c2b2a29dfdd5d9 URL: https://github.com/llvm/llvm-project/commit/1bae02b77335eb1a01d9a0bb36c2b2a29dfdd5d9 DIFF: https://github.com/llvm/llvm-project/commit/1bae02b77335eb1a01d9a0bb36c2b2a29dfdd5d9.diff

[PATCH] D126377: [clang][AArch64][SVE] Improve diagnostics for SVE operators

DavidTruby added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:10609-10614 - if (RHSType->isVLSTBuiltinType() && !LHSType->isVLSTBuiltinType()) { -auto DestType = tryScalableVectorConvert((IsCompAssign ? nullptr : ), -

[PATCH] D120244: [clang][sema] Enable first-class bool support for C2x

ldionne added a comment. In D120244#3538660 , @aaron.ballman wrote: > In D120244#3538380 , @ldionne wrote: > >> We've started having several internal user complaints because their system >> headers are suddenly

[PATCH] D125814: Improve the strict prototype diagnostic behavior

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. aaron.ballman marked an inline comment as done. Closed by commit rG681c50c62e93: Improve the strict prototype diagnostic behavior (authored by aaron.ballman). Changed

[clang] 681c50c - Improve the strict prototype diagnostic behavior

Author: Aaron Ballman Date: 2022-05-26T08:35:56-04:00 New Revision: 681c50c62e9338afdf58ebfd663f8e3ff43439fb URL: https://github.com/llvm/llvm-project/commit/681c50c62e9338afdf58ebfd663f8e3ff43439fb DIFF: https://github.com/llvm/llvm-project/commit/681c50c62e9338afdf58ebfd663f8e3ff43439fb.diff

[PATCH] D125814: Improve the strict prototype diagnostic behavior

aaron.ballman marked an inline comment as done. aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:3959 + // it's a user-visible declaration. There is one exception to this: + // when the new declaration is one without a prototype, the

[PATCH] D126461: [RISCV] Extract and store new vl of vleff iff destination isn't null

pcwang-thead created this revision. pcwang-thead added reviewers: khchen, kito-cheng, craig.topper, asb. Herald added subscribers: sunshaoce, VincentWu, luke957, StephenFan, vkmr, frasercrmck, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o,

[PATCH] D102122: Support warn_unused_result on typedefs

aaron.ballman added a comment. In D102122#3538668 , @dblaikie wrote: > Sorry, with all the layers in the previous messages I'm not sure what the > summary is. Sounds like the summary is "this is OK to continue work in the > direction of supporting

[clang] ca3d962 - [analyzer] Return from reAssume if State is posteriorly overconstrained

Author: Gabor Marton Date: 2022-05-26T13:50:40+02:00 New Revision: ca3d962548b9699d69157d102e071607d27ba126 URL: https://github.com/llvm/llvm-project/commit/ca3d962548b9699d69157d102e071607d27ba126 DIFF: https://github.com/llvm/llvm-project/commit/ca3d962548b9699d69157d102e071607d27ba126.diff

[PATCH] D126406: [analyzer] Return from reAssume if State is posteriorly overconstrained

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. martong marked an inline comment as done. Closed by commit rGca3d962548b9: [analyzer] Return from reAssume if State is posteriorly overconstrained (authored by

[PATCH] D126406: [analyzer] Return from reAssume if State is posteriorly overconstrained

martong added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/PathSensitive/ProgramState.h:118 + // Make internal constraint solver entities friends so they can access the + // overconstrained related functions. We want to keep this API inaccessible + //

[PATCH] D126137: [X86] Add support for `-mharden-sls=all`

pengfei updated this revision to Diff 432247. pengfei marked 6 inline comments as done. pengfei added a comment. Address @nickdesaulniers 's comments. Thanks for the review! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126137/new/

[PATCH] D126084: [Sema] Reject implicit conversions between different scoped enum types in list initialization

aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaInit.cpp:4506 !S.Context.hasSameUnqualifiedType(E->getType(), DestType) && -(E->getType()->isIntegralOrEnumerationType() || +(E->getType()->isIntegralOrUnscopedEnumerationType() ||

[clang] 6b8c6f1 - [clang][PR55406] CFG for coroutine

Author: Nathan Sidwell Date: 2022-05-26T06:40:43-07:00 New Revision: 6b8c6f15fdd8c147dfb7b0beb6f3d6eb98bf5772 URL: https://github.com/llvm/llvm-project/commit/6b8c6f15fdd8c147dfb7b0beb6f3d6eb98bf5772 DIFF:

[PATCH] D126399: [clang][PR55406] CFG for coroutine

This revision was automatically updated to reflect the committed changes. Closed by commit rG6b8c6f15fdd8: [clang][PR55406] CFG for coroutine (authored by urnathan). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D126377: [clang][AArch64][SVE] Improve diagnostics for SVE operators

c-rhodes added inline comments. Comment at: clang/test/Sema/aarch64-sve-vector-arith-ops.c:23 - (void)(i8 + f64); // expected-error{{invalid operands to binary expression}} - (void)(i8 + 0); // expected-error{{invalid operands to binary expression}} - (void)(i8 + 0l); //

[clang] 634c8ef - [PS5] Allow dllimport/dllexport same as PS4

Author: Paul Robinson Date: 2022-05-26T07:01:30-07:00 New Revision: 634c8ef69a836f3436d027b03965965bad6f3ff0 URL: https://github.com/llvm/llvm-project/commit/634c8ef69a836f3436d027b03965965bad6f3ff0 DIFF: https://github.com/llvm/llvm-project/commit/634c8ef69a836f3436d027b03965965bad6f3ff0.diff

[PATCH] D125291: Introduce @llvm.threadlocal.address intrinsic to access TLS variable (1/3)

nhaehnle added inline comments. Comment at: llvm/include/llvm/IR/IRBuilder.h:746-747 + /// Create a call to llvm.threadlocal.address intrinsic. + CallInst *CreateThreadLocalAddress(Value *Ptr); + ChuanqiXu wrote: > nhaehnle wrote: > > This could be a

[PATCH] D125052: [HLSL] Enable vector types for hlsl.

Anastasia added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:3490 + if (!Args.hasArg(options::OPT_dxc_no_stdinc)) +CmdArgs.push_back("-finclude-default-header"); } Sharing command line options is great, let's just update the help

[PATCH] D120244: [clang][sema] Enable first-class bool support for C2x

aaron.ballman added a comment. In D120244#3540598 , @aaron.ballman wrote: > We could maybe extend `#pragma clang deprecate` to deprecate inclusion of the > current file so that it acts sort of like a `[[deprecated]]` attribute that > triggers on

[PATCH] D124752: [HLSL] clang codeGen for HLSLShaderAttr.

Anastasia added inline comments. Comment at: clang/test/CodeGenHLSL/entry.hlsl:1 +// RUN: %clang --driver-mode=dxc -Tcs_6_1 -Efoo -fcgl -Fo - %s | FileCheck %s + Is this test here accidental? Comment at:

[PATCH] D126137: [X86] Add support for `-mharden-sls=all`

nickdesaulniers accepted this revision. nickdesaulniers added a comment. This revision is now accepted and ready to land. Nice work Phoebe; thank you very much for this patch! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126137/new/

[PATCH] D111283: [clang] template / auto deduction deduces common sugar

mizvekov updated this revision to Diff 432339. mizvekov added a comment. - Just rebase, no review comments addressed yet. - One small churn in test/SemaCXX/deduced-return-void.cpp, which is new since last rebase. As this patch uses the template deduction machinery to also handle the mutiple

[PATCH] D125847: LTO: Decide upfront whether to use opaque/non-opaque pointer types

MatzeB updated this revision to Diff 432350. MatzeB marked an inline comment as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125847/new/ https://reviews.llvm.org/D125847 Files: clang/lib/Driver/ToolChains/CommonArgs.cpp

[libunwind] 3d2b5b7 - [libunwind] Factor out sigreturn check condition. NFC

Author: Shoaib Meenai Date: 2022-05-26T09:12:50-07:00 New Revision: 3d2b5b7b87857b0cc4c322cfc145c46c42fe2bbf URL: https://github.com/llvm/llvm-project/commit/3d2b5b7b87857b0cc4c322cfc145c46c42fe2bbf DIFF: https://github.com/llvm/llvm-project/commit/3d2b5b7b87857b0cc4c322cfc145c46c42fe2bbf.diff

[libunwind] 0be0a53 - [libunwind] Use process_vm_readv to avoid potential segfaults

Author: Shoaib Meenai Date: 2022-05-26T09:12:51-07:00 New Revision: 0be0a53df65cb402359c257922d80ab93d86fb40 URL: https://github.com/llvm/llvm-project/commit/0be0a53df65cb402359c257922d80ab93d86fb40 DIFF: https://github.com/llvm/llvm-project/commit/0be0a53df65cb402359c257922d80ab93d86fb40.diff

[PATCH] D120244: [clang][sema] Enable first-class bool support for C2x

aaron.ballman added a comment. In D120244#3540746 , @aaron.ballman wrote: > I'll roll back the `#warning` use and report back when that's done. I've rolled it back in 6273b5cbcdd346a833120c55061ab56f61827068

[PATCH] D119051: Extend the C++03 definition of POD to include defaulted functions

dblaikie added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:5596 + DefaultedSMFArePOD = false; + } + probinson wrote: > dblaikie wrote: > > probinson wrote: > > > Does this mean `-fclang-abi-compat` will override the PS4/Darwin

[PATCH] D126481: [analyzer] Handle SymbolCast in SValBuilder

martong created this revision. martong added reviewers: ASDenysPetrov, steakhal, NoQ. Herald added subscribers: manas, gamesh411, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun. Herald added a reviewer: Szelethus. Herald added a project:

[clang] 0a5cfbf - [OpenMP] Use the align clause value from 'omp allocate' for globals

Author: Mike Rice Date: 2022-05-26T09:51:48-07:00 New Revision: 0a5cfbf7b2e82e7980b66428e88b4e28e814d7bb URL: https://github.com/llvm/llvm-project/commit/0a5cfbf7b2e82e7980b66428e88b4e28e814d7bb DIFF: https://github.com/llvm/llvm-project/commit/0a5cfbf7b2e82e7980b66428e88b4e28e814d7bb.diff

[PATCH] D126426: [OpenMP] Use the align clause value from 'omp allocate' for globals

This revision was automatically updated to reflect the committed changes. Closed by commit rG0a5cfbf7b2e8: [OpenMP] Use the align clause value from omp allocate for globals (authored by mikerice). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github

[PATCH] D126481: [analyzer] Handle SymbolCast in SValBuilder

steakhal added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/SimpleSValBuilder.cpp:1359 + return cache(S, + SVB.evalCast(Op, S->getType(), S->getOperand()->getType())); +} Hoist this common subexpression.

[clang] ce54b22 - [Clang][CoverageMapping] Fix switch counter codegen compile time explosion

Author: Bruno Cardoso Lopes Date: 2022-05-26T11:05:15-07:00 New Revision: ce54b22657f01d1c40de4941ceb6e7119848aecf URL: https://github.com/llvm/llvm-project/commit/ce54b22657f01d1c40de4941ceb6e7119848aecf DIFF:

[PATCH] D126345: [Clang][CoverageMapping] Fix switch case counter compile time explosion

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGce54b22657f0: [Clang][CoverageMapping] Fix switch counter codegen compile time explosion (authored by bruno). Repository: rG LLVM Github Monorepo

[clang] 6273b5c - Roll back use of #warning for header deprecations

Author: Aaron Ballman Date: 2022-05-26T14:51:39-04:00 New Revision: 6273b5cbcdd346a833120c55061ab56f61827068 URL: https://github.com/llvm/llvm-project/commit/6273b5cbcdd346a833120c55061ab56f61827068 DIFF: https://github.com/llvm/llvm-project/commit/6273b5cbcdd346a833120c55061ab56f61827068.diff

[PATCH] D125847: LTO: Decide upfront whether to use opaque/non-opaque pointer types

MatzeB updated this revision to Diff 432347. MatzeB marked an inline comment as done. MatzeB added a comment. Address review feedback. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125847/new/ https://reviews.llvm.org/D125847 Files:

[PATCH] D125052: [HLSL] Enable vector types for hlsl.

python3kgae updated this revision to Diff 432346. python3kgae added a comment. Update comment for finclude_default_header. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125052/new/ https://reviews.llvm.org/D125052 Files:

[PATCH] D125847: LTO: Decide upfront whether to use opaque/non-opaque pointer types

MatzeB marked an inline comment as done. MatzeB added inline comments. Comment at: lld/ELF/Options.td:311 + "Use opaque pointers in IR used during LTO", + "Use typed pointers in IR used during LTO (default)">; + nikic wrote: > `(default)` here is outdated. >

[PATCH] D120244: [clang][sema] Enable first-class bool support for C2x

aaron.ballman added a comment. In D120244#3539852 , @ldionne wrote: > In D120244#3538660 , @aaron.ballman > wrote: > >> In D120244#3538380 , @ldionne >> wrote: >> >>>

[PATCH] D124753: [HLSL] Set main as default entry.

Anastasia added inline comments. Comment at: clang/test/CodeGenHLSL/entry_default.hlsl:1 +// RUN: %clang --driver-mode=dxc -Tcs_6_1 -fcgl -Fo - %s | FileCheck %s + Would it make sense to test the opposite i.e. if `-E` is passed in the command line `main` is not

[PATCH] D124752: [HLSL] clang codeGen for HLSLShaderAttr.

Anastasia added inline comments. Comment at: clang/lib/CodeGen/CGHLSLRuntime.cpp:54 + +void clang::CodeGen::CGHLSLRuntime::setHLSLFnuctionAttributes( +llvm::Function *F, const FunctionDecl *FD) { I don't think you need `clang::CodeGen::`?

[PATCH] D120244: [clang][sema] Enable first-class bool support for C2x

ldionne added a comment. In D120244#3540598 , @aaron.ballman wrote: > The system header including a header that's explicitly deprecated is dubious > practice, but that does still require some amount of timing coordination. I agree, and I'll be filing

[PATCH] D124690: [clangd] add inlay hints for std::forward-ed parameter packs

upsj added a comment. I've hit a roadblock I'm not sure how to proceed with. It seems that in some cases, a `ParmVarDecl` of an instantiated function template indeed doesn't preserve the `SubstTemplateTypeParmType` type sugar allowing me to check which template parameter it was instantiated

[PATCH] D126100: Add sanitizer-specific GlobalValue attributes.

hctim added a comment. (friendly ping) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126100/new/ https://reviews.llvm.org/D126100 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] 48ca3a5 - [OpenMP] Extend omp teams to permit nested omp atomic

Author: Joel E. Denny Date: 2022-05-26T14:59:16-04:00 New Revision: 48ca3a5ebb156ccb776eea399138b7cda4d13395 URL: https://github.com/llvm/llvm-project/commit/48ca3a5ebb156ccb776eea399138b7cda4d13395 DIFF: https://github.com/llvm/llvm-project/commit/48ca3a5ebb156ccb776eea399138b7cda4d13395.diff

[PATCH] D126323: [OpenMP] Extend omp teams to permit nested omp atomic

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG48ca3a5ebb15: [OpenMP] Extend omp teams to permit nested omp atomic (authored by jdenny). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D126494: [clang] avoid assert due to device treated long double as double

cchen created this revision. Herald added a project: All. cchen requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D126494 Files:

[PATCH] D126479: [Clang] Allow 'Complex float __attribute__((mode(HC)))'

jolanta.jensen created this revision. Herald added a project: All. jolanta.jensen requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Adding half float to types that can be represented by __attribute__((mode(xx))). Original implementation

  1   2   >