[PATCH] D130831: [CodeGen] Track DeferredDecls that have been emitted

v.g.vassilev added reviewers: rjmccall, rsmith. v.g.vassilev added a comment. This looks good to me but let’s add more reviewers. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130831/new/ https://reviews.llvm.org/D130831

[PATCH] D130827: [clang] Fixed a number of typos

junaire added a comment. Hi, I think the main issue is that your patch contains another patch unintentionally, please fix that :) Comment at: clang/CMakeLists.txt:513 -endif() - option(CLANG_ENABLE_ARCMT "Build ARCMT." ON) Why delete these lines?

[PATCH] D130422: [clang-repl] Fix incorrect return code

v.g.vassilev accepted this revision. v.g.vassilev added a comment. This revision is now accepted and ready to land. Thanks for working on this. This is one of the problems where is hard to find the right behavior. For example, if a repl running in interactive issues an error and then

[PATCH] D130422: [clang-repl] Fix incorrect return code

v.g.vassilev added a comment. In D130422#3689397 , @junaire wrote: > In D130422#3689392 , @v.g.vassilev > wrote: > >> Thanks for working on this. This is one of the problems where is hard to >> find the right

[PATCH] D130422: [clang-repl] Fix incorrect return code

junaire updated this revision to Diff 448844. junaire added a comment. Rebase and add a FIXME Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130422/new/ https://reviews.llvm.org/D130422 Files: clang/test/Interpreter/fail.cpp

[PATCH] D130827: [clang] Fixed a number of typos

GabrielRavier updated this revision to Diff 448850. GabrielRavier added a comment. Fixed it so that it doesn't accidentally revert all the changes made since my original diff Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130827/new/

[PATCH] D130422: [clang-repl] Fix incorrect return code

junaire updated this revision to Diff 448846. junaire added a comment. Fix some typos Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130422/new/ https://reviews.llvm.org/D130422 Files: clang/test/Interpreter/fail.cpp

[PATCH] D130422: [clang-repl] Fix incorrect return code

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9caee577ef0f: [clang-repl] Fix incorrect return code (authored by junaire). Changed prior to commit:

[clang] 9caee57 - [clang-repl] Fix incorrect return code

Author: Jun Zhang Date: 2022-07-31T19:07:05+08:00 New Revision: 9caee577ef0f97242a233174be8a980bc4d5446e URL: https://github.com/llvm/llvm-project/commit/9caee577ef0f97242a233174be8a980bc4d5446e DIFF: https://github.com/llvm/llvm-project/commit/9caee577ef0f97242a233174be8a980bc4d5446e.diff

[PATCH] D130827: [clang] Fixed a number of typos

junaire added inline comments. Comment at: clang/include/clang/Sema/Sema.h:4022 + ExprResult , bool DoFunctionPointerConversion = false, + bool Complain = false, SourceRange OpRangeForComplaining = SourceRange(), + QualType DestTypeForComplaining = QualType(),

[PATCH] D130827: [clang] Fixed a number of typos

GabrielRavier updated this revision to Diff 448858. GabrielRavier added a comment. Reverted reversion of `git clang-format` on `clang/include/clang/Sema/Sema.h` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130827/new/ https://reviews.llvm.org/D130827 Files:

[PATCH] D130788: [clang-repl] Disable building when LLVM_STATIC_LINK_CXX_STDLIB is ON.

dyung added a comment. The test simple-exception.cpp is failing on the PS5 Windows bot after this change. Can you take a look? I forced a build using the commit prior to yours which passed: https://lab.llvm.org/buildbot/#/builders/216/builds/7636 And then I forced a build using your commit,

[PATCH] D130827: [clang] Fixed a number of typos

GabrielRavier added a comment. Ooh yeah looks like there's some damage. Shouldn't have done this at 12:30 AM without looking at what that `git rebase` on the latest pull ended up doing... I'll go fix this asap Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D130827: [clang] Fixed a number of typos

GabrielRavier added inline comments. Comment at: clang/lib/Headers/opencl-c.h:17856 +intel_sub_group_avc_sic_payload_t __ovld intel_sub_group_avc_sic_configure_ipe( +uchar luma_intra_partition_mask, uchar intra_neighbour_availability, uchar left_edge_luma_pixels, uchar

[PATCH] D130422: [clang-repl] Fix incorrect return code

junaire added a comment. In D130422#3689392 , @v.g.vassilev wrote: > Thanks for working on this. This is one of the problems where is hard to find > the right behavior. For example, if a repl running in interactive issues an > error and then

[PATCH] D130422: [clang-repl] Fix incorrect return code

v.g.vassilev accepted this revision. v.g.vassilev added inline comments. Comment at: clang/tools/clang-repl/ClangRepl.cpp:138 - return checkDiagErrors(Interp->getCompilerInstance()); + llvm::llvm_shutdown(); + This seems not needed. We have already

[PATCH] D130827: [clang] Fixed a number of typos

GabrielRavier added inline comments. Comment at: clang/include/clang/Sema/Sema.h:4022 + ExprResult , bool DoFunctionPointerConversion = false, + bool Complain = false, SourceRange OpRangeForComplaining = SourceRange(), + QualType DestTypeForComplaining =

[PATCH] D130847: [clang] SourceManager: fix isOffsetInFileID for the case of a fake SLocEntry

ivanmurashko created this revision. ivanmurashko added reviewers: dexonsmith, aaron.ballman. ivanmurashko added a project: clang. Herald added subscribers: usaxena95, kadircet. Herald added a project: All. ivanmurashko requested review of this revision. Herald added subscribers: cfe-commits,

[PATCH] D130422: [clang-repl] Fix incorrect return code

junaire added inline comments. Comment at: clang/tools/clang-repl/ClangRepl.cpp:138 - return checkDiagErrors(Interp->getCompilerInstance()); + llvm::llvm_shutdown(); + v.g.vassilev wrote: > This seems not needed. We have already `llvm::llvm_shutdown_obj Y;`

[PATCH] D130841: [clang] Fixed a number of typos

GabrielRavier created this revision. Herald added subscribers: steakhal, martong, arphaman, whisperity, mgorny. Herald added a reviewer: aaron.ballman. Herald added a reviewer: dang. Herald added a reviewer: NoQ. Herald added a reviewer: ributzka. Herald added a project: All. GabrielRavier

[PATCH] D130841: [clang] Fixed a number of typos

GabrielRavier abandoned this revision. GabrielRavier added a comment. Nvm I'm an idiot I thought this would update https://reviews.llvm.org/D130827 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130841/new/ https://reviews.llvm.org/D130841

[PATCH] D127462: [Clang] Begin implementing Plan 9 C extensions

ksaunders added a comment. Gentle ping. I have 2 other patches ready, and I'd like to get the discussion started on this if possible. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127462/new/ https://reviews.llvm.org/D127462

[PATCH] D130857: [Clang] Plan 9 member resolution

ksaunders created this revision. ksaunders added a reviewer: rsmith. ksaunders added a project: clang. Herald added a project: All. ksaunders requested review of this revision. Herald added a subscriber: cfe-commits. This patch implements the Plan 9 member resolution algorithm which is described

[clang] ed29930 - [Sema] Remove an unused forward declaration (NFC)

Author: Kazu Hirata Date: 2022-07-31T15:17:00-07:00 New Revision: ed2993051994546771a1d8e8256baa960609ee11 URL: https://github.com/llvm/llvm-project/commit/ed2993051994546771a1d8e8256baa960609ee11 DIFF: https://github.com/llvm/llvm-project/commit/ed2993051994546771a1d8e8256baa960609ee11.diff

[PATCH] D130788: [clang-repl] Disable building when LLVM_STATIC_LINK_CXX_STDLIB is ON.

dyung added a comment. In D130788#3689918 , @sunho wrote: > In D130788#3689820 , @dyung wrote: > >> In D130788#3689795 , @sunho wrote: >> >>> The test isn't supposed to

[PATCH] D128490: [ODRHash diagnostics] Transform method `ASTReader::diagnoseOdrViolations` into a class `ODRDiagsEmitter`. NFC.

ChuanqiXu accepted this revision. ChuanqiXu added a comment. This revision is now accepted and ready to land. LGTM then. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128490/new/ https://reviews.llvm.org/D128490

[PATCH] D125291: Introduce @llvm.threadlocal.address intrinsic to access TLS variable

ChuanqiXu updated this revision to Diff 448904. ChuanqiXu marked an inline comment as done. ChuanqiXu added a comment. Address comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125291/new/ https://reviews.llvm.org/D125291 Files: llvm/docs/LangRef.rst

[PATCH] D125291: Introduce @llvm.threadlocal.address intrinsic to access TLS variable

ChuanqiXu added a comment. In D125291#3687295 , @nikic wrote: > LG. Now that LLVM 15 has branched, I think it is safe to land this, and there > will be enough time before LLVM 16 to convert it to the token variant. Yeah, thanks for reviewing! CHANGES

[PATCH] D130847: [clang] SourceManager: fix isOffsetInFileID for the case of a fake SLocEntry

ivanmurashko updated this revision to Diff 448885. ivanmurashko added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130847/new/ https://reviews.llvm.org/D130847 Files: clang/include/clang/Basic/SourceManager.h Index:

[PATCH] D130788: [clang-repl] Disable building when LLVM_STATIC_LINK_CXX_STDLIB is ON.

dyung added a comment. In D130788#3689795 , @sunho wrote: > The test isn't supposed to be ran on windows -- we don't support exception on > windows at all yet. I guess XFAIL: windows-msvc, windows-gnu is not working > out. If you don't want the test

[clang] 773d51c - [clang-repl] XFAIL windows properly in simple-exception test case.

Author: Sunho Kim Date: 2022-08-01T09:06:35+09:00 New Revision: 773d51ce3bedd091539aa86a5e5fc15a9174ff7b URL: https://github.com/llvm/llvm-project/commit/773d51ce3bedd091539aa86a5e5fc15a9174ff7b DIFF: https://github.com/llvm/llvm-project/commit/773d51ce3bedd091539aa86a5e5fc15a9174ff7b.diff

[PATCH] D130788: [clang-repl] Disable building when LLVM_STATIC_LINK_CXX_STDLIB is ON.

sunho added a comment. In D130788#3689820 , @dyung wrote: > In D130788#3689795 , @sunho wrote: > >> The test isn't supposed to be ran on windows -- we don't support exception >> on windows at all yet. I guess

[PATCH] D130863: [clangd] Make git ignore index directories

sums created this revision. sums added a reviewer: clang-tools-extra. sums added a project: clang-tools-extra. Herald added subscribers: usaxena95, kadircet, arphaman. Herald added a project: All. sums requested review of this revision. Herald added subscribers: cfe-commits, MaskRay,

[PATCH] D130788: [clang-repl] Disable building when LLVM_STATIC_LINK_CXX_STDLIB is ON.

sunho added a comment. In D130788#3689693 , @dyung wrote: > The test simple-exception.cpp is failing on the PS5 Windows bot after this > change. Can you take a look? > > I forced a build using the commit prior to yours which passed: >

[PATCH] D93138: Add initial support for multilibs in Baremetal toolchain.

zixuan-wu added inline comments. Comment at: clang/lib/Driver/ToolChains/BareMetal.cpp:177 if (!getDriver().SysRoot.empty()) -return getDriver().SysRoot; +return getDriver().SysRoot + SelectedMultilib.osSuffix(); abidh wrote: > zixuan-wu wrote: > >

[PATCH] D130858: [HLSL] emit-obj when set output.

python3kgae created this revision. python3kgae added reviewers: amccarth, craig.topper, hans, rnk, stefan_reinalter, beanz, pow2clk, bogner. Herald added subscribers: Anastasia, StephenFan. Herald added a project: All. python3kgae requested review of this revision. Herald added subscribers:

[PATCH] D125291: Introduce @llvm.threadlocal.address intrinsic to access TLS variable

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG970105351710: Introduce @llvm.threadlocal.address intrinsic to access TLS variable (authored by ChuanqiXu). Repository: rG LLVM Github Monorepo

[PATCH] D130422: [clang-repl] Fix incorrect return code

junaire added a comment. @v.g.vassilev if you can take another look at the wording of the FIXME, and make sure you're happy about it, that will be awesome. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130422/new/ https://reviews.llvm.org/D130422

[PATCH] D130827: [clang] Fixed a number of typos

GabrielRavier added inline comments. Comment at: clang/include/clang/Sema/Sema.h:4022 + ExprResult , bool DoFunctionPointerConversion = false, + bool Complain = false, SourceRange OpRangeForComplaining = SourceRange(), + QualType DestTypeForComplaining =

[PATCH] D130864: [NFC] Introduce ASTContext::isInSameModule()

ChuanqiXu created this revision. ChuanqiXu added reviewers: iains, ilya-biryukov, erichkeane. ChuanqiXu added a project: clang-modules. Herald added a project: All. ChuanqiXu requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Previously, when

[PATCH] D125944: Template instantiation error recovery

Purva-Chaudhari added a comment. In D125944#3689022 , @v.g.vassilev wrote: > @Purva-Chaudhari can you rebase this patch? Yes. I realized I would have to rebase Comment at: clang/lib/Interpreter/IncrementalParser.cpp:180

[PATCH] D130867: WORK-IN-PROGRESS [clang] adds builtin `std::invoke` and `std::invoke_r`

cjdb created this revision. cjdb added reviewers: aaron.ballman, rsmith. Herald added a reviewer: NoQ. Herald added a project: All. cjdb requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. `std::invoke` and `std::invoke_r` are fairly easy to

[PATCH] D126742: [RISCV][Clang] Support RVV policy functions.

kito-cheng accepted this revision. kito-cheng added a comment. This revision is now accepted and ready to land. LGTM, and verified with internal testsuite :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126742/new/