[PATCH] D132324: [RFC] Remove support for building libc++ with `LLVM_ENABLE_PROJECTS`

aaron.ballman added a comment. In D132324#3742605 , @ldionne wrote: > This sucks, but I'm going to revert this series of patches. This is getting > somewhat out of hands and I feel that we're rushing to fix all kinds of > issues in various directions.

[PATCH] D132414: [Clang] follow-up D128745, use ClangABICompat15 instead of ClangABICompat14

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. Good catch @royjacobson on the ABI version number needing to be bumped! LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D132461: [clang-tidy] Add cppcoreguidelines-avoid-do-while check

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/cppcoreguidelines/avoid-do-while.rst:6 + +This check warns when using ``do-while`` loops. They are less readable than +plain ``while`` loops since the termination condition is at the end

[PATCH] D132461: [clang-tidy] Add cppcoreguidelines-avoid-do-while check

carlosgalvezp added a comment. PS: @aaron.ballman I didn't add you as reviewer since you have expressed in the past that you'd prefer not to review C++ Core Guidelines patches. Let me know if that has changed :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D132248: [CUDA][OpenMP] Fix the new driver crashing on multiple device-only outputs

yaxunl accepted this revision. yaxunl added a comment. This revision is now accepted and ready to land. LGTM. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132248/new/ https://reviews.llvm.org/D132248

[PATCH] D132209: [Clang][OpenMP] Make copyin clause on combined and composite construct work

This revision was automatically updated to reflect the committed changes. Closed by commit rG2e2caea37f4b: [Clang][OpenMP] Make copyin clause on combined and composite construct work… (authored by yutsumi, committed by ABataev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 86bfab2 - [OffloadPackager] Resolve copy elision warnings

Author: Joseph Huber Date: 2022-08-23T10:01:54-05:00 New Revision: 86bfab2723618772f5c4ffc2a68eedca592c6928 URL: https://github.com/llvm/llvm-project/commit/86bfab2723618772f5c4ffc2a68eedca592c6928 DIFF: https://github.com/llvm/llvm-project/commit/86bfab2723618772f5c4ffc2a68eedca592c6928.diff

[PATCH] D132324: [RFC] Remove support for building libc++ with `LLVM_ENABLE_PROJECTS`

ldionne added a comment. In D132324#3742700 , @Ericson2314 wrote: >> I also think we don't want to move forward with D132411 >> -- it's going against this transition. > > I would like to discuss some of this sort of

[PATCH] D132131: [clang-format] Adds a formatter for aligning trailing comments over empty lines

yusuke-kadowaki updated this revision to Diff 454864. yusuke-kadowaki edited the summary of this revision. yusuke-kadowaki added a comment. - [clang-format] Adds a formatter for aligning trailing comments over empty lines - Remove unnecessary style specifications - Add more tests - Port

[PATCH] D132131: [clang-format] Adds a formatter for aligning trailing comments over empty lines

yusuke-kadowaki added inline comments. Comment at: clang/include/clang/Format/Format.h:379 /// \version 3.7 bool AlignTrailingComments; HazardyKnusperkeks wrote: > Maybe you can port this to `AlignConsecutiveStyle`? `AcrossComments` would > not affect

[PATCH] D131616: [clang][dataflow] Generalise match switch utility to other AST types and add a `CFGMatchSwitch` which currently handles `CFGStmt` and `CFGInitializer`.

wyt updated this revision to Diff 454869. wyt added a comment. Fix comments for consistency. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131616/new/ https://reviews.llvm.org/D131616 Files:

[PATCH] D131858: [clang] Track the templated entity in type substitution.

mizvekov updated this revision to Diff 454872. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131858/new/ https://reviews.llvm.org/D131858 Files: clang-tools-extra/clang-tidy/hicpp/ExceptionBaseclassCheck.cpp

[clang] 16cb3be - [analyzer] Deadstore static analysis: Fix false positive on C++17 assignments

Author: Fred Tingaud Date: 2022-08-23T18:33:26+02:00 New Revision: 16cb3be62600621361644ebd15d071c711d6aa86 URL: https://github.com/llvm/llvm-project/commit/16cb3be62600621361644ebd15d071c711d6aa86 DIFF: https://github.com/llvm/llvm-project/commit/16cb3be62600621361644ebd15d071c711d6aa86.diff

[PATCH] D126534: [analyzer] Deadstore static analysis: Fix false positive on C++17 assignments

This revision was automatically updated to reflect the committed changes. Closed by commit rG16cb3be62600: [analyzer] Deadstore static analysis: Fix false positive on C++17 assignments (authored by frederic-tingaud-sonarsource, committed by steakhal). Repository: rG LLVM Github Monorepo

Re: [clang] acaf6b9 - [NFC] Add [[maybe_unused]] to avoid warning in gcc9

Hi David, This is the reproduce link from godbolt: https://godbolt.org/z/nEc7WYKnq. It is weird that it requries `-Wunused-but-set-parameter` instead of `-Wunused-parameter`. The bug exists in all versions of GCC9. And it gets fixed in GCC10 and later. Personally, I feel it looks better to

[PATCH] D132444: [clang] Allow using -rtlib=platform to switching to the default rtlib on all targets

thakis added a comment. Do we have precedent for "platform" for this? For fuse-ld=, one is supposed to use `-fuse-ld=` (without anything after the `=`) to get the default ld. That's not great (...but it can't collide with actual linker names, i suppose). Using "platform" (or any other

[PATCH] D131203: [HLSL] Initial codegen for SV_GroupIndex

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131203/new/ https://reviews.llvm.org/D131203

[PATCH] D132473: [Docs][OpenCL][SPIR-V] Release 15 notes for Clang

Anastasia updated this revision to Diff 454838. Anastasia added a comment. Minor formatting changes CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132473/new/ https://reviews.llvm.org/D132473 Files: clang/docs/ReleaseNotes.rst Index: clang/docs/ReleaseNotes.rst

[PATCH] D131939: [clang-tidy] Add performance-expensive-flat-container-operation check

nicovank added a reviewer: alexfh. nicovank added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131939/new/ https://reviews.llvm.org/D131939 ___ cfe-commits mailing list

[PATCH] D129570: [clang-tidy] Add new clang-tidy check to find implicit conversions from enum to integer.

pfultz2 added a comment. Anymore feedback? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129570/new/ https://reviews.llvm.org/D129570 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D132111: [clang][Interp] Implement pointer (de)ref operations and DeclRefExprs

tbaeder added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:662 + return this->emitGetPtrParam(It->second, E); + } + tahonermann wrote: > tbaeder wrote: > > tahonermann wrote: > > > Perhaps add: > > > else { > > > assert(0 &&

[PATCH] D132473: [Docs][OpenCL][SPIR-V] Release 15 notes for Clang

Anastasia added a comment. @svenvh as you made quite a lot of changes in the headers feel free to expand the description if you feel we should document some of those in more detail. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132473/new/ https://reviews.llvm.org/D132473

[clang] 2c923b8 - [clang-cl] Expose the /volatile:{iso, ms} choice via _ISO_VOLATILE

Author: David Majnemer Date: 2022-08-23T14:29:52Z New Revision: 2c923b88631cda41cbddf58a13ccfb5c04a2fc3c URL: https://github.com/llvm/llvm-project/commit/2c923b88631cda41cbddf58a13ccfb5c04a2fc3c DIFF: https://github.com/llvm/llvm-project/commit/2c923b88631cda41cbddf58a13ccfb5c04a2fc3c.diff

[PATCH] D128113: Clang: fix AST representation of expanded template arguments.

joanahalili added a comment. F24241982: reproduction.cpp clang -fsyntax-only -std=c++17 -fproc-stat-report -Wno-deprecated-declarations -fsized-deallocation -Werror -Wno-deprecated-declarations -Wno-inconsistent-missing-override -Wno-null-conversion

[clang] 3708a14 - [clang] Pull some utility functions into CompilerInvocation NFC

Author: Ben Langmuir Date: 2022-08-23T08:18:14-07:00 New Revision: 3708a148421fd0449081b9a91fba28f51f1dfb12 URL: https://github.com/llvm/llvm-project/commit/3708a148421fd0449081b9a91fba28f51f1dfb12 DIFF: https://github.com/llvm/llvm-project/commit/3708a148421fd0449081b9a91fba28f51f1dfb12.diff

[PATCH] D132419: [clang] Pull some utility functions into CompilerInvocation NFC

This revision was automatically updated to reflect the committed changes. Closed by commit rG3708a148421f: [clang] Pull some utility functions into CompilerInvocation NFC (authored by benlangmuir). Changed prior to commit: https://reviews.llvm.org/D132419?vs=454639=454847#toc Repository: rG

[PATCH] D132430: [clang][modules] Track affecting modules

benlangmuir added inline comments. Comment at: clang/lib/Tooling/DependencyScanning/ModuleDepCollector.cpp:311 +if (!MDC.isPrebuiltModule(M)) + DirectModularDeps.insert(M); + If using eager loading, this will cause us to load the module, right? Does

[PATCH] D132236: [analyzer] Fix liveness of LazyCompoundVals

steakhal updated this revision to Diff 454861. steakhal added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132236/new/ https://reviews.llvm.org/D132236 Files: clang/lib/StaticAnalyzer/Core/RegionStore.cpp

[PATCH] D132289: [analyzer] Drop deprecated flags

This revision was automatically updated to reflect the committed changes. Closed by commit rG6ca17b58f569: [analyzer] Drop deprecated flags (authored by steakhal). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132289/new/

[clang] 6ca17b5 - [analyzer] Drop deprecated flags

Author: Balazs Benics Date: 2022-08-23T18:39:21+02:00 New Revision: 6ca17b58f569d43838404f5c94856e3584a23d0f URL: https://github.com/llvm/llvm-project/commit/6ca17b58f569d43838404f5c94856e3584a23d0f DIFF: https://github.com/llvm/llvm-project/commit/6ca17b58f569d43838404f5c94856e3584a23d0f.diff

[PATCH] D132415: [LLDB] Add data formatter for std::coroutine_handle

aprantl added inline comments. Comment at: lldb/source/Plugins/Language/CPlusPlus/Coroutines.h:1 +//===-- Coroutines.h ---*- C++//-*-===// +// typo: `-*- C++ -*-` Comment at:

[PATCH] D132415: [LLDB] Add data formatter for std::coroutine_handle

avogelsgesang updated this revision to Diff 454830. avogelsgesang added a comment. clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132415/new/ https://reviews.llvm.org/D132415 Files: clang/docs/tools/clang-formatted-files.txt

[PATCH] D132316: [CMake] `${LLVM_BINARY_DIR}/lib(${LLVM_LIBDIR_SUFFIX})?` -> `${LLVM_LIBRARY_DIR}`

Ericson2314 updated this revision to Diff 454829. Ericson2314 added a comment. Redo sed mandating ending on word boundary Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132316/new/ https://reviews.llvm.org/D132316 Files:

[PATCH] D132142: [analyzer] Prefer wrapping SymbolicRegions by ElementRegions

steakhal updated this revision to Diff 454859. steakhal added a comment. upload the same with context Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132142/new/ https://reviews.llvm.org/D132142 Files:

[PATCH] D132473: [Docs][OpenCL][SPIR-V] Release 15 notes for Clang

svenvh added a comment. In D132473#3742688 , @Anastasia wrote: > @svenvh as you made quite a lot of changes in the headers feel free to expand > the description if you feel we should document some of those in more detail. I think you have captured it

[clang] cd24120 - [clang] Remove a FIXME that we can't fix

Author: Nico Weber Date: 2022-08-23T10:12:52-04:00 New Revision: cd24120c9d9544b202641fbff46be38175bb2470 URL: https://github.com/llvm/llvm-project/commit/cd24120c9d9544b202641fbff46be38175bb2470 DIFF: https://github.com/llvm/llvm-project/commit/cd24120c9d9544b202641fbff46be38175bb2470.diff

[PATCH] D132400: [clang] Remove a FIXME that we can't fix

This revision was automatically updated to reflect the committed changes. Closed by commit rGcd24120c9d95: [clang] Remove a FIXME that we cant fix (authored by thakis). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D132400: [clang] Remove a FIXME that we can't fix

thakis added a comment. Thanks, fixed commit message. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132400/new/ https://reviews.llvm.org/D132400 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D132324: [RFC] Remove support for building libc++ with `LLVM_ENABLE_PROJECTS`

Ericson2314 added a comment. That sounds good to me too. Sorry I did unquestionably jump the gun here --- I suppose I was surprised to get a fairly simple approval when I put on the `[RFC]`, and thought "hmm, maybe this isn't so controversial as I feared because indeed the deprecation cycle

[PATCH] D132316: [CMake] `${LLVM_BINARY_DIR}/lib(${LLVM_LIBDIR_SUFFIX})?` -> `${LLVM_LIBRARY_DIR}`

sebastian-ne added inline comments. Comment at: llvm/tools/llvm-shlib/CMakeLists.txt:91 set(LIB_DIR ${LLVM_BINARY_DIR}/${CMAKE_CFG_INTDIR}/lib${LLVM_LIBDIR_SUFFIX}) set(LIB_NAME ${LIB_DIR}/${CMAKE_SHARED_LIBRARY_PREFIX}LLVM) Ericson2314 wrote: >

[clang] 0565e65 - [clang/test] Correctly specify simulator env in target flag in fsanitize.c

Author: Nico Weber Date: 2022-08-23T10:13:51-04:00 New Revision: 0565e65a69676a75a9da89c35d2ceda2ef4d21f7 URL: https://github.com/llvm/llvm-project/commit/0565e65a69676a75a9da89c35d2ceda2ef4d21f7 DIFF: https://github.com/llvm/llvm-project/commit/0565e65a69676a75a9da89c35d2ceda2ef4d21f7.diff

[PATCH] D132399: [clang/test] Correctly specify simulator env in target flag in fsanitize.c

thakis added a comment. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132399/new/ https://reviews.llvm.org/D132399 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D132399: [clang/test] Correctly specify simulator env in target flag in fsanitize.c

This revision was automatically updated to reflect the committed changes. Closed by commit rG0565e65a6967: [clang/test] Correctly specify simulator env in target flag in fsanitize.c (authored by thakis). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D132248: [CUDA][OpenMP] Fix the new driver crashing on multiple device-only outputs

jhuber6 updated this revision to Diff 454839. jhuber6 added a comment. Adding HIP test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132248/new/ https://reviews.llvm.org/D132248 Files: clang/lib/Driver/Driver.cpp

[PATCH] D132461: [clang-tidy] Add cppcoreguidelines-avoid-do-while check

carlosgalvezp updated this revision to Diff 454841. carlosgalvezp marked 2 inline comments as done. carlosgalvezp added a comment. Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132461/new/ https://reviews.llvm.org/D132461 Files:

[PATCH] D132461: [clang-tidy] Add cppcoreguidelines-avoid-do-while check

carlosgalvezp added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/cppcoreguidelines/avoid-do-while.rst:21 + +The check implements +`rule ES.75 of C++ Core Guidelines

[PATCH] D132461: [clang-tidy] Add cppcoreguidelines-avoid-do-while check

carlosgalvezp added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/cppcoreguidelines/avoid-do-while.rst:21 + +The check implements +`rule ES.75 of C++ Core Guidelines

[clang] 2e2caea - [Clang][OpenMP] Make copyin clause on combined and composite construct work (patch by Yuichiro Utsumi (utsumi.yuich...@fujitsu.com))

Author: utsumi Date: 2022-08-23T07:58:35-07:00 New Revision: 2e2caea37f4b70568cec180e5af12ee532aba0af URL: https://github.com/llvm/llvm-project/commit/2e2caea37f4b70568cec180e5af12ee532aba0af DIFF: https://github.com/llvm/llvm-project/commit/2e2caea37f4b70568cec180e5af12ee532aba0af.diff LOG:

[PATCH] D132142: [analyzer] Prefer wrapping SymbolicRegions by ElementRegions

steakhal updated this revision to Diff 454857. steakhal added a comment. - Simplify `getApproximatedType()` to `return sym->getType()->getPointeeType();` - Add doc comments to `getApproximatedType()` - Removed the "Copied from RegionStoreManager::bind()" FIXME from the

[clang-tools-extra] 552b59b - [clangd] Bump timeout for a flaky test

Author: Kadir Cetinkaya Date: 2022-08-23T18:18:17+02:00 New Revision: 552b59b9e69fe1cb2b1ee0cb49cf8376a3dc0869 URL: https://github.com/llvm/llvm-project/commit/552b59b9e69fe1cb2b1ee0cb49cf8376a3dc0869 DIFF:

[PATCH] D132444: [clang] Allow using -rtlib=platform to switching to the default rtlib on all targets

thakis added a comment. Makes sense to me. Maybe @hans has an opinion too. WDYT about accepting the same string for -fuse-ld= to mean "platform linker" there as well? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132444/new/

[PATCH] D132444: [clang] Allow using -rtlib=platform to switching to the default rtlib on all targets

mstorsjo added a comment. In D132444#3743020 , @thakis wrote: > Makes sense to me. Maybe @hans has an opinion too. > > WDYT about accepting the same string for -fuse-ld= to mean "platform linker" > there as well? Sounds reasonable to me - requiring the

[PATCH] D132473: [Docs][OpenCL][SPIR-V] Release 15 notes for Clang

Anastasia created this revision. Anastasia added a reviewer: svenvh. Herald added subscribers: ebevhan, yaxunl. Herald added a project: All. Anastasia requested review of this revision. Added list of functional changes to release notes. https://reviews.llvm.org/D132473 Files:

[PATCH] D132316: [CMake] `${LLVM_BINARY_DIR}/lib(${LLVM_LIBDIR_SUFFIX})?` -> `${LLVM_LIBRARY_DIR}`

Ericson2314 marked an inline comment as done. Ericson2314 added inline comments. Comment at: llvm/tools/llvm-shlib/CMakeLists.txt:91 set(LIB_DIR ${LLVM_BINARY_DIR}/${CMAKE_CFG_INTDIR}/lib${LLVM_LIBDIR_SUFFIX}) set(LIB_NAME ${LIB_DIR}/${CMAKE_SHARED_LIBRARY_PREFIX}LLVM)

[PATCH] D128619: [Clang] Implement P0848 (Conditionally Trivial Special Member Functions)

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM, thank you for this!! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128619/new/ https://reviews.llvm.org/D128619 ___ cfe-commits

[PATCH] D132074: [OpenMP] Add option to assert no nested OpenMP parallelism on the GPU

jhuber6 updated this revision to Diff 454845. jhuber6 added a comment. Fix missing `()` in assertion and accidentally deleting device libs addition. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132074/new/ https://reviews.llvm.org/D132074 Files:

[PATCH] D132111: [clang][Interp] Implement pointer (de)ref operations and DeclRefExprs

tahonermann added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:662 + return this->emitGetPtrParam(It->second, E); + } + tbaeder wrote: > tahonermann wrote: > > Perhaps add: > > else { > > assert(0 && "Unhandled declaration

[PATCH] D131616: [clang][dataflow] Generalise match switch utility to other AST types and add a `CFGMatchSwitch` which currently handles `CFGStmt` and `CFGInitializer`.

wyt updated this revision to Diff 454868. wyt marked 13 inline comments as done. wyt added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131616/new/ https://reviews.llvm.org/D131616 Files:

[PATCH] D131616: [clang][dataflow] Generalise match switch utility to other AST types and add a `CFGMatchSwitch` which currently handles `CFGStmt` and `CFGInitializer`.

wyt added inline comments. Comment at: clang/include/clang/Analysis/FlowSensitive/CFGMatchSwitch.h:55 +MSActionT A) && { +std::move(std::move(StmtBuilder).template CaseOf(M, A)); +return std::move(*this); sgatev

[PATCH] D132352: Introduce noread_thread_id to address the thread identification problem in coroutines

rjmccall added inline comments. Comment at: llvm/include/llvm/IR/InstrTypes.h:1863 + /// not access or only reads memory. + bool doesNotReadThreadIDNorLivesInPresplitCoroutine() const { +return doesNoReadThreadID() || !getFunction() || rjmccall wrote: >

[PATCH] D131616: [clang][dataflow] Generalise match switch utility to other AST types and add a `CFGMatchSwitch` which currently handles `CFGStmt` and `CFGInitializer`.

sgatev added inline comments. Comment at: clang/include/clang/Analysis/FlowSensitive/CFGMatchSwitch.h:24-25 +#include "clang/AST/Stmt.h" +#include "clang/ASTMatchers/ASTMatchFinder.h" +#include "clang/ASTMatchers/ASTMatchers.h" +#include "clang/Analysis/CFG.h"

[PATCH] D132377: [clang][dataflow] Add `SetupTest` parameter for `AnalysisInputs`.

wyt updated this revision to Diff 454754. wyt marked 5 inline comments as done. wyt added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132377/new/ https://reviews.llvm.org/D132377 Files:

[PATCH] D113107: Support of expression granularity for _Float16.

pengfei added inline comments. Comment at: clang/test/CodeGen/X86/Float16-arithmetic.c:207 +// CHECK-NEXT:[[EXT:%.*]] = fpext half [[TMP0]] to float +// CHECK-NEXT:store float [[EXT]], ptr [[RETVAL]], align 2 +// CHECK-NEXT:[[TMP1:%.*]] = load half, ptr [[RETVAL]],

[clang] 4332b04 - [docs] Add examples for printing asynchronous stack for coroutines

Author: Chuanqi Xu Date: 2022-08-23T17:37:12+08:00 New Revision: 4332b049edf6ccf98c9e31dcc983760a89f01d40 URL: https://github.com/llvm/llvm-project/commit/4332b049edf6ccf98c9e31dcc983760a89f01d40 DIFF: https://github.com/llvm/llvm-project/commit/4332b049edf6ccf98c9e31dcc983760a89f01d40.diff

[PATCH] D132451: [docs] Add examples for printing asynchronous stack for coroutines

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4332b049edf6: [docs] Add examples for printing asynchronous stack for coroutines (authored by ChuanqiXu). Repository: rG LLVM Github Monorepo

[PATCH] D132388: [pseudo] Fix HeadsPartition is not initialized correctly.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGedb8fb265990: [pseudo] Fix HeadsPartition is not initialized correctly. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE

[clang-tools-extra] edb8fb2 - [pseudo] Fix HeadsPartition is not initialized correctly.

Author: Haojian Wu Date: 2022-08-23T15:08:33+02:00 New Revision: edb8fb265990c3c4d0453d6b789554ccb5341123 URL: https://github.com/llvm/llvm-project/commit/edb8fb265990c3c4d0453d6b789554ccb5341123 DIFF: https://github.com/llvm/llvm-project/commit/edb8fb265990c3c4d0453d6b789554ccb5341123.diff

[PATCH] D131625: [HLSL] Entry functions require param annotation

aaron.ballman added inline comments. Comment at: clang/include/clang/AST/Attr.h:193 +class HLSLAnnotationAttr : public InheritableAttr { +protected: beanz wrote: > aaron.ballman wrote: > > beanz wrote: > > > aaron.ballman wrote: > > > > Is this intended to be

[PATCH] D129464: [Clang][CodeGen] Set FP options of builder at entry to compound statement

sepavloff updated this revision to Diff 454822. sepavloff edited the summary of this revision. sepavloff added a comment. Rebase and ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129464/new/ https://reviews.llvm.org/D129464 Files:

[PATCH] D132451: [docs] Add examples for printing asynchronous stack for coroutines

ChuanqiXu updated this revision to Diff 454744. ChuanqiXu edited the summary of this revision. ChuanqiXu added a comment. Fix a typo. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132451/new/ https://reviews.llvm.org/D132451 Files: clang/docs/DebuggingCoroutines.rst Index:

[PATCH] D132444: [clang] Allow using -rtlib=platform to switching to the default rtlib on all targets

mstorsjo added a comment. In D132444#3742295 , @thakis wrote: > Do we have precedent for "platform" for this? For fuse-ld=, one is supposed > to use `-fuse-ld=` (without anything after the `=`) to get the default ld. > That's not great (...but it can't

[PATCH] D132461: [clang-tidy] Add cppcoreguidelines-avoid-do-while check

carlosgalvezp updated this revision to Diff 454793. carlosgalvezp added a comment. Fix typo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132461/new/ https://reviews.llvm.org/D132461 Files:

[PATCH] D132324: [RFC] Remove support for building libc++ with `LLVM_ENABLE_PROJECTS`

ldionne added a comment. In D132324#3742406 , @aaron.ballman wrote: > For clarity, @ldionne are you requesting that these changes be reverted due > to being incomplete, or do you prefer this be fixed forward? Sorry, I left no action item on my end

[clang-tools-extra] f7dc91a - [pseudo] Eliminate a false parse of structured binding declaration.

Author: Haojian Wu Date: 2022-08-23T15:25:52+02:00 New Revision: f7dc91ad5609fab02cb805861dd232cab492340d URL: https://github.com/llvm/llvm-project/commit/f7dc91ad5609fab02cb805861dd232cab492340d DIFF: https://github.com/llvm/llvm-project/commit/f7dc91ad5609fab02cb805861dd232cab492340d.diff

[PATCH] D132260: [pseudo] Eliminate a false parse of structured binding declaration.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf7dc91ad5609: [pseudo] Eliminate a false parse of structured binding declaration. (authored by hokein). Repository: rG LLVM Github Monorepo

[PATCH] D131683: Diagnosing the Future Keywords

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/DiagnosticLexKinds.td:85 + InGroup, DefaultIgnore; +def warn_c23_keyword : Warning<"'%0' is a keyword in C23">, + InGroup, DefaultIgnore; Comment at:

[PATCH] D132400: [clang] Remove a FIXME that we can't fix

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. lgtm "No behavior change." occurs twice in the change description. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132400/new/ https://reviews.llvm.org/D132400

[PATCH] D132461: [clang-tidy] Add cppcoreguidelines-avoid-do-while check

carlosgalvezp updated this revision to Diff 454789. carlosgalvezp added a comment. Add check to list of checks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132461/new/ https://reviews.llvm.org/D132461 Files:

[PATCH] D132324: [RFC] Remove support for building libc++ with `LLVM_ENABLE_PROJECTS`

ldionne added a comment. Please don't change libc++ things like that without my approval first. This is a transition I've been working on for 2+ years, I had a local patch for it waiting to be published, and this patch is incomplete in several ways. I greatly appreciate the effort and wanting

[PATCH] D131979: [clang][UBSan] Fix __builtin_assume_aligned crash

yihanaa added a comment. As far as I know, turning on the -fsanitizer=alignment options when calling __builtin_assume_aligned in C code, if the 1st arg has volatile qualifier, Clang will emit "call void @__ubsan_handle_alignment_assumption(...)" in CodeGen, else Clang will emit an warning and

[PATCH] D132141: [X86] Emulate _rdrand64_step with two rdrand32 if it is 32bit

RKSimon accepted this revision. RKSimon added a comment. This revision is now accepted and ready to land. LGTM - cheers Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132141/new/ https://reviews.llvm.org/D132141

[PATCH] D132461: [clang-tidy] Add cppcoreguidelines-avoid-do-while check

carlosgalvezp updated this revision to Diff 454787. carlosgalvezp added a comment. Document default value Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132461/new/ https://reviews.llvm.org/D132461 Files:

[PATCH] D132444: [clang] Allow using -rtlib=platform to switching to the default rtlib on all targets

mstorsjo added a comment. In D132444#3742305 , @mstorsjo wrote: > In D132444#3742295 , @thakis wrote: > >> Do we have precedent for "platform" for this? For fuse-ld=, one is supposed >> to use `-fuse-ld=`

[PATCH] D132470: [pseudo] add the spurious left-and-upwads recovery case to unittest.

hokein created this revision. hokein added a reviewer: sammccall. Herald added a project: All. hokein requested review of this revision. Herald added a subscriber: alextsao1999. Herald added a project: clang-tools-extra. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D132470

[PATCH] D132399: [clang/test] Correctly specify simulator env in target flag in fsanitize.c

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. lgtm CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132399/new/ https://reviews.llvm.org/D132399 ___ cfe-commits mailing list

[PATCH] D132451: [docs] Add examples for printing asynchronous stack for coroutines

ChuanqiXu updated this revision to Diff 454745. ChuanqiXu added a comment. Fix a typo. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132451/new/ https://reviews.llvm.org/D132451 Files: clang/docs/DebuggingCoroutines.rst Index: clang/docs/DebuggingCoroutines.rst

[PATCH] D132324: [RFC] Remove support for building libc++ with `LLVM_ENABLE_PROJECTS`

ldionne added a comment. This sucks, but I'm going to revert this series of patches. This is getting somewhat out of hands and I feel that we're rushing to fix all kinds of issues in various directions. I'm going to revert the following patches, in this order: 1. 952f90b72b35

[PATCH] D132141: [X86] Emulate _rdrand64_step with two rdrand32 if it is 32bit

yubing updated this revision to Diff 454738. yubing added a comment. Execute the second rdrand32 despite of whether the first one fail or not Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132141/new/ https://reviews.llvm.org/D132141 Files:

[PATCH] D132451: [docs] Add examples for printing asynchronous stack for coroutines

ChuanqiXu created this revision. ChuanqiXu added reviewers: avogelsgesang, dblaikie, aprantl, labath, JDevlieghere. ChuanqiXu added a project: debug-info. Herald added a project: All. ChuanqiXu requested review of this revision. Herald added a project: clang. Herald added a subscriber:

[PATCH] D132451: [docs] Add examples for printing asynchronous stack for coroutines

avogelsgesang accepted this revision. avogelsgesang added a comment. This revision is now accepted and ready to land. LGTM, thanks! I guess I will update this documentation with LLDB examples, as soon as https://reviews.llvm.org/D132415 and a couple of follow-up improvements landed. As soon as

[PATCH] D132451: [docs] Add examples for printing asynchronous stack for coroutines

ChuanqiXu added a comment. In D132451#3742064 , @avogelsgesang wrote: > LGTM, thanks! > > I guess I will update this documentation with LLDB examples, as soon as > https://reviews.llvm.org/D132415 and a couple of follow-up improvements > landed. > As

[PATCH] D132461: [clang-tidy] Add cppcoreguidelines-avoid-do-while check

carlosgalvezp created this revision. Herald added subscribers: shchenz, kbarton, xazax.hun, mgorny, nemanjai. Herald added a project: All. carlosgalvezp requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Implements rule ES.75 of

[PATCH] D132302: [clang] Add support for __attribute__((guard(nocf)))

alvinhochun updated this revision to Diff 454798. alvinhochun marked an inline comment as done. alvinhochun added a comment. Rebased and added a release note entry. @mstorsjo would you mind landing this for me? Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D132451: [docs] Add examples for printing asynchronous stack for coroutines

ChuanqiXu added inline comments. Comment at: clang/docs/DebuggingCoroutines.rst:619 + +.. code-block:: text + Here we can't use `.. code-block:: console` since it will meet some parsing problems. CHANGES SINCE LAST ACTION

[PATCH] D132324: [RFC] Remove support for building libc++ with `LLVM_ENABLE_PROJECTS`

aaron.ballman added a comment. In D132324#3742394 , @ldionne wrote: > Please don't change libc++ things like that without my approval first. This > is a transition I've been working on for 2+ years, I had a local patch for it > waiting to be published,

[PATCH] D131632: [clang] Enable output of SARIF diagnostics

aaron.ballman added inline comments. Comment at: clang/include/clang/Frontend/SARIFDiagnosticPrinter.h:63-65 + void setSarifWriter(SarifDocumentWriter *SarifWriter) { +Writer = std::unique_ptr(SarifWriter); + } abrahamcd wrote: > aaron.ballman wrote: > >

[PATCH] D132260: [pseudo] Eliminate a false parse of structured binding declaration.

hokein updated this revision to Diff 454816. hokein marked 3 inline comments as done. hokein added a comment. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132260/new/ https://reviews.llvm.org/D132260 Files:

[clang] ea0549d - [OffloadPackager] Add necessary move statement on returned value

Author: Joseph Huber Date: 2022-08-23T08:45:30-05:00 New Revision: ea0549d41bc44f60db6a2fb9e0f32e752d47e177 URL: https://github.com/llvm/llvm-project/commit/ea0549d41bc44f60db6a2fb9e0f32e752d47e177 DIFF: https://github.com/llvm/llvm-project/commit/ea0549d41bc44f60db6a2fb9e0f32e752d47e177.diff

[PATCH] D132414: [Clang] follow-up D128745, use ClangABICompat15 instead of ClangABICompat14

This revision was automatically updated to reflect the committed changes. Closed by commit rG088ba8efeb49: [Clang] follow-up D128745, use ClangABICompat15 instead of ClangABICompat14 (authored by ychen). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 088ba8e - [Clang] follow-up D128745, use ClangABICompat15 instead of ClangABICompat14

Author: Yuanfang Chen Date: 2022-08-23T10:45:35-07:00 New Revision: 088ba8efeb4921deb49534714ddefb14a91afe46 URL: https://github.com/llvm/llvm-project/commit/088ba8efeb4921deb49534714ddefb14a91afe46 DIFF: https://github.com/llvm/llvm-project/commit/088ba8efeb4921deb49534714ddefb14a91afe46.diff

  1   2   3   >