[PATCH] D135269: [AMDGPU] Disable bool range metadata to workaround backend issue

This revision was automatically updated to reflect the committed changes. Closed by commit rG107ee2613063: [AMDGPU] Disable bool range metadata to workaround backend issue (authored by yaxunl). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 107ee26 - [AMDGPU] Disable bool range metadata to workaround backend issue

Author: Yaxun (Sam) Liu Date: 2022-10-07T10:46:04-04:00 New Revision: 107ee2613063183cb643cef97f0fad403508c9f0 URL: https://github.com/llvm/llvm-project/commit/107ee2613063183cb643cef97f0fad403508c9f0 DIFF:

[clang] eb26baf - Fix test bool-range.cu

Author: Yaxun (Sam) Liu Date: 2022-10-07T11:17:28-04:00 New Revision: eb26baf4ade6c1e73eb14e8a89d5771e57bc61a3 URL: https://github.com/llvm/llvm-project/commit/eb26baf4ade6c1e73eb14e8a89d5771e57bc61a3 DIFF:

[PATCH] D135366: [clang][Interp] Implement String- and CharacterLiterals

aaron.ballman added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:446 + if (Optional T = classify(LitType)) { +APInt Val(getIntWidth(LitType), E->getValue()); +return this->emitConst(*T, 0, Val, E); Should this be concerned about

[PATCH] D129755: Thread safety analysis: Support copy-elided production of scoped capabilities through arbitrary calls

aaronpuchert added a comment. In D129755#3843144 , @gulfem wrote: > We also started seeing `-Wthread-safety-precise` error in our Fuchsia code. >

[PATCH] D135091: Create storage for the `_cmd` argument to the helper function for generated getters/setters of `direct` Objective-C properties.

mwyman added inline comments. Comment at: clang/lib/CodeGen/CGObjC.cpp:1125 +llvm::Type *selType = CGF.ConvertType(CGF.getContext().getObjCSelType()); +return llvm::UndefValue::get(selType); + } nlopes wrote: > Please consider using PoisonValue here

[PATCH] D135099: [C2x] Implement support for nullptr and nullptr_t

aaron.ballman added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135099/new/ https://reviews.llvm.org/D135099 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D135461: [LLDB] Fix crash when printing a struct with a static wchar_t member

aeubanks created this revision. aeubanks added a reviewer: DavidSpickett. Herald added a project: All. aeubanks requested review of this revision. Herald added projects: clang, LLDB. Herald added subscribers: lldb-commits, cfe-commits. Similar to D135170 .

[clang] bb46022 - [CMake] Small fix to HLSL header install paths

Author: Chris Bieneman Date: 2022-10-07T09:45:11-05:00 New Revision: bb46022abe78497d3d5a8c6a6cf8599f7ec0d2ec URL: https://github.com/llvm/llvm-project/commit/bb46022abe78497d3d5a8c6a6cf8599f7ec0d2ec DIFF:

[clang] 3b652fc - [analyzer] Fix static code analysis concerns

Author: Soumi Manna Date: 2022-10-07T16:58:37+02:00 New Revision: 3b652fc6d6447aae91c9e8c35815eed19245757d URL: https://github.com/llvm/llvm-project/commit/3b652fc6d6447aae91c9e8c35815eed19245757d DIFF: https://github.com/llvm/llvm-project/commit/3b652fc6d6447aae91c9e8c35815eed19245757d.diff

[PATCH] D135290: [analyzer] Fix static code analysis concerns

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3b652fc6d644: [analyzer] Fix static code analysis concerns (authored by Manna, committed by isuckatcs). Herald added a project: clang. Herald added

[PATCH] D129689: [limits.h] USHRT_MAX fix for 16 bit architectures

aaron.ballman added a comment. This seems to have fallen through the cracks -- @SebastianPerta are you planning to update the patch, or would you be okay if I commandeered it? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129689/new/ https://reviews.llvm.org/D129689

[PATCH] D135367: [clang-tidy] Dump effective diagnostics level in YAML output

njames93 accepted this revision. njames93 added a comment. This revision is now accepted and ready to land. LGTM, just maybe include a test case where a warning from a clang-tidy check is promoted to an error as well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D133668: [HLSL] Use _BitInt(16) for int16_t to avoid promote to int.

python3kgae added a comment. Hi, @rjmccall and @efriedma, Could you take a look at this PR? Or should I find someone else to review it? Thanks Xiang Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133668/new/ https://reviews.llvm.org/D133668

[PATCH] D129755: Thread safety analysis: Support copy-elided production of scoped capabilities through arbitrary calls

gulfem added a comment. In D129755#3843206 , @aaronpuchert wrote: > In D129755#3843144 , @gulfem wrote: > >> We also started seeing `-Wthread-safety-precise` error in our Fuchsia code. >>

[PATCH] D129755: Thread safety analysis: Support copy-elided production of scoped capabilities through arbitrary calls

aaronpuchert planned changes to this revision. aaronpuchert added a comment. In D129755#3843206 , @aaronpuchert wrote: > Presumably `Cursor` is some kind of alias to `VmoCursor`, as we don't look at > base destructors yet. Since the code is not easily

[PATCH] D135236: [Clang][OpenMP] Add one missing form of atomic compare capture

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135236/new/ https://reviews.llvm.org/D135236

[PATCH] D135341: [clang] adds `__reference_constructs_from_temporary` and `__reference_converts_from_temporary`

cjdb updated this revision to Diff 466088. cjdb added a comment. Gets `__reference_constructs_from_temporary` correct. Still WIP for the latter. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135341/new/ https://reviews.llvm.org/D135341 Files:

[PATCH] D134330: [Docs] [HLSL] Add note about PCH support

This revision was automatically updated to reflect the committed changes. Closed by commit rG6a6f10fd23b2: [Docs] [HLSL] Add note about PCH support (authored by python3kgae). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134330/new/

[clang] 6a6f10f - [Docs] [HLSL] Add note about PCH support

Author: Xiang Li Date: 2022-10-07T10:49:21-07:00 New Revision: 6a6f10fd23b2730e2c01051541c5a83f5df9131b URL: https://github.com/llvm/llvm-project/commit/6a6f10fd23b2730e2c01051541c5a83f5df9131b DIFF: https://github.com/llvm/llvm-project/commit/6a6f10fd23b2730e2c01051541c5a83f5df9131b.diff

[PATCH] D135199: [OpenMP][C++] Allow #pragma omp simd in constexpr functions

jdoerfert added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:8274-8279 // Only if a local variable was declared in the function currently being // evaluated, do we expect to be able to find its value in the current // frame. (Otherwise it was likely

[PATCH] D133983: [HLSL] Add SV_DispatchThreadID

beanz added inline comments. Comment at: clang/lib/CodeGen/CGHLSLRuntime.cpp:135 +llvm::Function *DxThreadID = CGM.getIntrinsic(Intrinsic::dx_thread_id); +// dx_thread_id +return buildVectorInput(B, DxThreadID, Ty); nit: this comment doesn't add

[PATCH] D135370: Narrow inline namespace filtration for unqualified friend declarations

troyj updated this revision to Diff 466072. troyj added a comment. Added more diff context as requested. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135370/new/ https://reviews.llvm.org/D135370 Files:

[PATCH] D135199: [OpenMP][C++] Allow #pragma omp simd in constexpr functions

aaron.ballman added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:8274-8279 // Only if a local variable was declared in the function currently being // evaluated, do we expect to be able to find its value in the current // frame. (Otherwise it was

[PATCH] D135099: [C2x] Implement support for nullptr and nullptr_t

erichkeane accepted this revision. erichkeane added a comment. This revision is now accepted and ready to land. Happy with this, thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135099/new/ https://reviews.llvm.org/D135099 ___

[PATCH] D129755: Thread safety analysis: Support copy-elided production of scoped capabilities through arbitrary calls

gulfem added a comment. We also started seeing `-Wthread-safety-precise` error in our Fuchsia code. https://luci-milo.appspot.com/ui/p/fuchsia/builders/ci/clang_toolchain.ci.core.x64-release/b8800959115965408001/overview I'm trying to verify with our team whether it is a false positive, but I

[PATCH] D135384: Enable the use of the -pg flag

cebowleratibm added inline comments. Comment at: clang/test/CodeGen/mcount-aix.c:2 +// RUN: %clang_cc1 -pg -no-opaque-pointers -triple powerpc-ibm-aix7.2.0.0 -S -emit-llvm %s -o - | FileCheck %s +// RUN: %clang_cc1 -pg -no-opaque-pointers -triple powerpc64-ibm-aix7.2.0.0 -S

[PATCH] D129755: Thread safety analysis: Support copy-elided production of scoped capabilities through arbitrary calls

aaronpuchert added a comment. In D129755#3842729 , @hans wrote: > We're hitting a false positive in grpc after this: > > > ../../third_party/grpc/src/src/core/lib/gprpp/ref_counted_ptr.h:335:31: > error: calling function 'TlsSessionKeyLoggerCache'

[PATCH] D135466: [clang-format] Add support to remove unnecessary semicolons after function definition

MyDeveloperDay created this revision. MyDeveloperDay added reviewers: HazardyKnusperkeks, owenpan, curdeius, rymiel, Eugene.Zelenko. MyDeveloperDay added projects: clang, clang-format. Herald added a project: All. MyDeveloperDay requested review of this revision. Fixes: #58217 This change is to

[PATCH] D135245: [clang][Tooling] Move STL recognizer to its own library

kamaub added a comment. This change causes a linking failure during the `check-all` testing of 'clang-tools-extra' on the clang-ppc64le-rhel #22596 and clang-ppc64le-linux-multistage #23864

[clang-tools-extra] bb4f0af - [clangd] Fix buildbots after d1f13c54f172875d9a14c46c09afb1f22d78cdf8

Author: Kadir Cetinkaya Date: 2022-10-07T20:10:32+02:00 New Revision: bb4f0af97dba600c50a0f727b25a760e8185c578 URL: https://github.com/llvm/llvm-project/commit/bb4f0af97dba600c50a0f727b25a760e8185c578 DIFF:

[PATCH] D135328: [CUDA] Refactored CUDA version housekeeping to use less boilerplate.

tra added a comment. @yaxunl - Are you OK with the patch? PTAL. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135328/new/ https://reviews.llvm.org/D135328 ___ cfe-commits mailing list

[PATCH] D135177: [clang] adds `__is_scoped_enum`, `__is_nullptr`, and `__is_referenceable`

aaron.ballman accepted this revision. aaron.ballman added a comment. Assuming the additional test cases don't uncover any surprises, this LGTM as well (modulo nits already brought up). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135177/new/

[PATCH] D135306: [CUDA] Add support for CUDA-11.8 and sm_{87,89,90} GPUs.

tra updated this revision to Diff 466171. tra added a comment. Updated a failing test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135306/new/ https://reviews.llvm.org/D135306 Files: clang/docs/ReleaseNotes.rst

[PATCH] D135486: [Clang] Use C++17 in constant-builtins-fmax.cpp test

Izaron added a comment. ASAP fix from previous review request, see comment: https://reviews.llvm.org/D134369#3843824 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135486/new/ https://reviews.llvm.org/D135486

[clang] 9a01cca - Add support for CUDA-11.8 and sm_{87,89,90} GPUs.

Author: Artem Belevich Date: 2022-10-07T13:59:28-07:00 New Revision: 9a01cca66036087e4da37c221a4b911818910524 URL: https://github.com/llvm/llvm-project/commit/9a01cca66036087e4da37c221a4b911818910524 DIFF:

[PATCH] D135476: [clang-tidy] Support concepts in `bugprone-forwarding-reference-overload`

Izaron updated this revision to Diff 466175. Izaron added a comment. Follow 80 characters limit. Thanks to @Eugene.Zelenko! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135476/new/ https://reviews.llvm.org/D135476 Files:

[PATCH] D135476: [clang-tidy] Support concepts in `bugprone-forwarding-reference-overload`

Izaron marked an inline comment as done. Izaron added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/bugprone/forwarding-reference-overload.rst:54 constructor could hide in this case. We also suppress warnings for constructors -like C3 and C4 that are

[PATCH] D135486: [Clang] Use C++17 in constant-builtins-fmax.cpp test

Izaron added a comment. Thanks, will land the patch after `Build 288902: pre-merge checks` is passed =) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135486/new/ https://reviews.llvm.org/D135486 ___

[PATCH] D130324: [ODRHash] Hash `ObjCProtocolDecl` and diagnose discovered mismatches.

jansvoboda11 added a comment. Should we also update `ODRHash::isDeclToBeProcessed`? Comment at: clang/lib/AST/ODRDiagsEmitter.cpp:313 +DeclarationName SecondProtocolName = SecondProtocol->getDeclName(); +if (FirstProtocolName != SecondProtocolName) { +

[PATCH] D122078: [clang-tidy] Ignore concepts in `misc-redundant-expression`

Izaron added a comment. Hi! A friendly ping =) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122078/new/ https://reviews.llvm.org/D122078 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D129755: Thread safety analysis: Support copy-elided production of scoped capabilities through arbitrary calls

aaronpuchert added a comment. In D129755#3843144 , @gulfem wrote: > We also started seeing `-Wthread-safety-precise` error in our Fuchsia code. >

[PATCH] D133457: Add Clang driver flags equivalent to cl's /MD, /MT, /MDd, /MTd.

akhuang added a comment. In D133457#3832590 , @mstorsjo wrote: > @akhuang I noticed that > https://github.com/llvm/llvm-project/blob/main/clang/lib/Driver/ToolChains/MSVC.cpp#L199-L200 > has got an explicit check for

[PATCH] D135472: [ODRHash] Hash attributes on declarations.

vsapsai added inline comments. Comment at: clang/lib/AST/ODRHash.cpp:479-480 + + llvm::copy_if(D->attrs(), std::back_inserter(HashableAttrs), +[](const Attr *A) { return !A->isImplicit(); }); +} I'm not sure `isImplicit` is the best indicator of

[PATCH] D135471: [CMake] Drop libLTO and switch to PIE for Fuchsia toolchain

abrachet accepted this revision. abrachet added a comment. This revision is now accepted and ready to land. Nice thats 71mb saved :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135471/new/ https://reviews.llvm.org/D135471

[PATCH] D135476: [clang-tidy] Support concepts in `bugprone-forwarding-reference-overload`

Izaron created this revision. Izaron added reviewers: hokein, aaron.ballman, LegalizeAdulthood, njames93. Herald added subscribers: carlosgalvezp, xazax.hun. Herald added a project: All. Izaron requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber:

[PATCH] D134369: [Clang] Support constexpr builtin fmax

Izaron updated this revision to Diff 466151. Izaron added a comment. Add TODO comment about sNaN. Thanks to @jcranmer-intel! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134369/new/ https://reviews.llvm.org/D134369 Files:

[PATCH] D135370: Narrow inline namespace filtration for unqualified friend declarations

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM! Should we also add a release note or do we think this isn't enough of a compile-time performance improvement to warrant that? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 0edff6f - [Clang] Support constexpr builtin fmax

Author: Evgeny Shulgin Date: 2022-10-07T20:27:17Z New Revision: 0edff6faa26664772c41fed8d7759bba703f4987 URL: https://github.com/llvm/llvm-project/commit/0edff6faa26664772c41fed8d7759bba703f4987 DIFF: https://github.com/llvm/llvm-project/commit/0edff6faa26664772c41fed8d7759bba703f4987.diff

[PATCH] D134369: [Clang] Support constexpr builtin fmax

This revision was automatically updated to reflect the committed changes. Closed by commit rG0edff6faa266: [Clang] Support constexpr builtin fmax (authored by Izaron). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134369/new/

[PATCH] D134369: [Clang] Support constexpr builtin fmax

Izaron added a comment. I've got an email about "Buildbot failure" with this link: https://lab.llvm.org/buildbot/#/builders/216/builds/10955 Line 51: 'static_assert' with no message is a C++17 extension Why is it failing if pre-merge checks has been passed? =( Repository: rG LLVM Github

Re: [PATCH] D135245: [clang][Tooling] Move STL recognizer to its own library

sorry for that, bb4f0af97dba600c50a0f727b25a760e8185c578 should fix it On Fri, Oct 7, 2022 at 7:46 PM Kamau Bridgeman via Phabricator < revi...@reviews.llvm.org> wrote: > kamaub added a comment. > > This change causes a linking failure during the `check-all` testing of > 'clang-tools-extra' on

[PATCH] D129755: Thread safety analysis: Support copy-elided production of scoped capabilities through arbitrary calls

aaronpuchert updated this revision to Diff 466172. aaronpuchert added a comment. This revision is now accepted and ready to land. - Pass `til::LiteralPtr *Self` for automatic object destructors into handling of `require_capability` and `locks_excluded` attributes. - Add `[[maybe_unused]]`

[PATCH] D135411: Add generic KCFI operand bundle lowering

nickdesaulniers accepted this revision. nickdesaulniers added inline comments. This revision is now accepted and ready to land. Comment at: llvm/lib/Transforms/Instrumentation/KCFI.cpp:48-49 + SmallVector KCFICalls; + for (inst_iterator I = inst_begin(F), E = inst_end(F); I !=

[PATCH] D134369: [Clang] Support constexpr builtin fmax

Izaron added a comment. In D134369#3843824 , @efriedma wrote: > You might need to explicitly specify -std=c++17 in the RUN line. (That bot > has a different target triple, and I think with that triple the default C++ > standard isn't C++17?) Thanks

[PATCH] D135429: [HLSL] [DirectX backend] Move generateGlobalCtorDtorCalls into DirectX backend.

efriedma added a comment. In D135429#3844172 , @efriedma wrote: >> The pass will be always enabled in >> registerPipelineEarlySimplificationEPCallback (Not controlled by >> optimization level), is it possible that things registered in >>

[PATCH] D135091: Create storage for the `_cmd` argument to the helper function for generated getters/setters of `direct` Objective-C properties.

mwyman updated this revision to Diff 466212. mwyman edited the summary of this revision. mwyman added a comment. Updated to use `PoisonValue` rather than `UndefValue`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135091/new/ https://reviews.llvm.org/D135091 Files:

[PATCH] D135397: [clang][dataflow] Add support for a Top value in boolean formulas.

ymandel marked 11 inline comments as done. ymandel added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/WatchedLiteralsSolver.cpp:237-238 + case Value::Kind::Top: +// Nothing more to do. Each `Top` instance will be mapped to a fresh +//

[PATCH] D134369: [Clang] Support constexpr builtin fmax

jcranmer-intel added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:14029-14030 + case Builtin::BI__builtin_fmaxf16: + case Builtin::BI__builtin_fmaxf128: { +APFloat RHS(0.); +if (!EvaluateFloat(E->getArg(0), Result, Info) || I think you

[PATCH] D135433: [clang][Interp] Implement while and do-while loops

aaron.ballman added inline comments. Comment at: clang/test/AST/Interp/loops.cpp:93 + } + static_assert(f4() == 5, ""); +}; Can you also add some tests that use nested loops with multiple levels of `break` and `continue` use? Also, I think it might be useful

[PATCH] D129755: Thread safety analysis: Support copy-elided production of scoped capabilities through arbitrary calls

hans added a comment. In D129755#3843146 , @aaronpuchert wrote: > In D129755#3842729 , @hans wrote: > >> We're hitting a false positive in grpc after this: >> >> >

[PATCH] D135328: [CUDA] Refactored CUDA version housekeeping to use less boilerplate.

yaxunl accepted this revision. yaxunl added a comment. This revision is now accepted and ready to land. LGTM. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135328/new/ https://reviews.llvm.org/D135328

[PATCH] D135422: Fix clang-format misattributing preprocessor directives to macros

jacob-abraham updated this revision to Diff 466166. jacob-abraham added a comment. Fix patch, sorry about that CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135422/new/ https://reviews.llvm.org/D135422 Files: clang/lib/Format/UnwrappedLineFormatter.cpp clang/test/Format/macro.cpp

[PATCH] D134369: [Clang] Support constexpr builtin fmax

efriedma added a comment. You might need to explicitly specify -std=c++17 in the RUN line. (That bot has a different target triple, and I think with that triple the default C++ standard isn't C++17?) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D135306: [CUDA] Add support for CUDA-11.8 and sm_{87,89,90} GPUs.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9a01cca66036: Add support for CUDA-11.8 and sm_{87,89,90} GPUs. (authored by tra). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] f3a2cbc - Refactored CUDA version housekeeping to use less boilerplate.

Author: Artem Belevich Date: 2022-10-07T13:59:23-07:00 New Revision: f3a2cbcf97f5c7a58f9d4c5588c2bea8028f8c58 URL: https://github.com/llvm/llvm-project/commit/f3a2cbcf97f5c7a58f9d4c5588c2bea8028f8c58 DIFF:

[PATCH] D135328: [CUDA] Refactored CUDA version housekeeping to use less boilerplate.

This revision was automatically updated to reflect the committed changes. Closed by commit rGf3a2cbcf97f5: Refactored CUDA version housekeeping to use less boilerplate. (authored by tra). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135328/new/

[PATCH] D130325: [ODRHash] Hash `ObjCMethodDecl` and diagnose discovered mismatches.

jansvoboda11 accepted this revision. jansvoboda11 added a comment. This revision is now accepted and ready to land. This look good to me, but you might want to get a review from someone who worked on this before. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D135490: [clang/Sema] Follow-up for fix of non-deterministic order of `-Wunused-variable` diagnostic

akyrtzi created this revision. Herald added a subscriber: mgrang. Herald added a project: All. akyrtzi requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Commit `371883f46dc23f8464cbf578e2d12a4f92e61917` caused a noticeable compile-time

[PATCH] D135489: [clangd] Fix rename for symbol introduced by UsingDecl

tom-anders created this revision. tom-anders added a reviewer: kadircet. Herald added a subscriber: arphaman. Herald added a project: All. tom-anders requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Fixes

[PATCH] D135118: [clang/Sema] Fix non-deterministic order for certain kind of diagnostics

akyrtzi added a comment. In D135118#3840259 , @akyrtzi wrote: > In D135118#3839442 , @nikic wrote: > >> FYI this caused a noticeable compile-time regression (about 0.4% geomean at >> `-O0`): >>

[PATCH] D135440: [SourceManager] Speedup getFileIDLocal with a separate Offset Table.

nickdesaulniers added inline comments. Comment at: clang/include/clang/Basic/SourceManager.h:696 + /// An in-parallel SlocEntry offset table, merely used for speeding up the + /// FileID lookup. + SmallVector LocalLocOffsetTable; Add to this comment that the

[PATCH] D135493: [Clang] Support constexpr builtin fmin

Izaron added a comment. This is a mirror of my previous patch about builtin **max**. I promised to make the patch for builtin **min** =) Here: https://reviews.llvm.org/D134369#3806131 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135493/new/

[PATCH] D135405: fix handling of braced-init temporaries for modernize-use-emplace

BigPeet updated this revision to Diff 466197. BigPeet added a comment. applying clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135405/new/ https://reviews.llvm.org/D135405 Files:

[PATCH] D135488: [codegen][WIP] Display stack layouts in console

nickdesaulniers added a comment. (I totally think we should ship this, perhaps a Note: diagnostic that says to "rebuild with debug info and -fmy-new-flag-for-more-info") Probably not much precedence for those kind of warnings, but idk. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D135091: Create storage for the `_cmd` argument to the helper function for generated getters/setters of `direct` Objective-C properties.

mwyman marked 2 inline comments as done. mwyman added inline comments. Comment at: clang/lib/CodeGen/CGObjC.cpp:1125 +llvm::Type *selType = CGF.ConvertType(CGF.getContext().getObjCSelType()); +return llvm::UndefValue::get(selType); + } nlopes wrote: >

[PATCH] D135429: [HLSL] [DirectX backend] Move generateGlobalCtorDtorCalls into DirectX backend.

python3kgae added a comment. In D135429#3844179 , @efriedma wrote: > In D135429#3844172 , @efriedma > wrote: > >>> The pass will be always enabled in >>> registerPipelineEarlySimplificationEPCallback (Not

[PATCH] D135397: [clang][dataflow] Add support for a Top value in boolean formulas.

ymandel updated this revision to Diff 466124. ymandel marked an inline comment as done. ymandel added a comment. Address (most) comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135397/new/ https://reviews.llvm.org/D135397 Files:

[PATCH] D135471: [CMake] Drop libLTO and switch to PIE for Fuchsia toolchain

phosek created this revision. phosek added a reviewer: abrachet. Herald added a subscriber: inglorion. Herald added a project: All. phosek requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. All our users have migrated to ld64.lld so we no

[PATCH] D135466: [clang-format] Add support to remove unnecessary semicolons after function definition

lahwaacz added inline comments. Comment at: clang/docs/ClangFormatStyleOptions.rst:3769 + care should be taken to review code changes made by this option. + NOTE: + Setting this to false will not add `;` where they were missing Nit: the note should

[PATCH] D135476: [clang-tidy] Support concepts in `bugprone-forwarding-reference-overload`

Izaron updated this revision to Diff 466147. Izaron added a comment. Fixes https://github.com/llvm/llvm-project/issues/58230 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135476/new/ https://reviews.llvm.org/D135476 Files:

[PATCH] D135326: Half-done attempt to move tail padding callback from TargetCXXABI to TargetInfo

dblaikie added inline comments. Comment at: clang/lib/Basic/Targets/OSTargets.h:169 +if (T.getOS() == llvm::Triple::WatchOS || +this->getCXXABI().getKind() == TargetCXXABI::AppleARM64) + return TargetInfo::UseTailPaddingUnlessPOD11; dblaikie

[PATCH] D135466: [clang-format] Add support to remove unnecessary semicolons after function definition

HazardyKnusperkeks added a comment. Maybe even extend the option to other unnecessary semicolons like `int x = 5;;` or other noop statements, one just has to be careful not to remove the semicolon when it's the sole if/loop body. Comment at:

[PATCH] D135422: Fix clang-format misattributing preprocessor directives to macros

jacob-abraham updated this revision to Diff 466165. jacob-abraham added a comment. Added regression test CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135422/new/ https://reviews.llvm.org/D135422 Files: clang/test/Format/macro.cpp Index: clang/test/Format/macro.cpp

[PATCH] D135384: [AIX] Enable the use of the -pg flag

cebowleratibm added inline comments. Comment at: clang/lib/Basic/Targets/OSTargets.h:754 : OSTargetInfo(Triple, Opts) { +this->MCountName = "__mcount.aix"; this->TheCXXABI.set(TargetCXXABI::XL); Suggest sticking with the normal mcount name and

[PATCH] D135486: [Clang] Use C++17 in constant-builtins-fmax.cpp test

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. Looks fine Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135486/new/ https://reviews.llvm.org/D135486

[PATCH] D135440: [SourceManager] Speedup getFileIDLocal with a separate Offset Table.

nickdesaulniers added inline comments. Comment at: clang/include/clang/Basic/SourceManager.h:697 + /// FileID lookup. + SmallVector LocalLocOffsetTable; nickdesaulniers wrote: > `LocalSLocEntryTable` is a vec of `SrcMgr::SLocEntry`. `SrcMgr::SLocEntry`'s >

[PATCH] D135493: [Clang] Support constexpr builtin fmin

Izaron updated this revision to Diff 466193. Izaron added a comment. Aligned slashes in defines Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135493/new/ https://reviews.llvm.org/D135493 Files: clang/docs/LanguageExtensions.rst

[PATCH] D135476: [clang-tidy] Support concepts in `bugprone-forwarding-reference-overload`

Eugene.Zelenko added a subscriber: MyDeveloperDay. Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/bugprone/forwarding-reference-overload.rst:54 constructor could hide in this case. We also suppress warnings for constructors -like C3

[PATCH] D135488: [codegen][WIP] Display stack layouts in console

nickdesaulniers added a comment. Thanks for the patch, here's the output I observe from the LKML thread : https://paste.debian.net/1256338/. I think the stack slot numbers printed at the end aren't correct; the two large

[PATCH] D135495: [clang-tidy] handle pointers in `ExceptionAnalyzer`

isuckatcs updated this revision to Diff 466204. isuckatcs edited the summary of this revision. isuckatcs added a comment. Updated CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135495/new/ https://reviews.llvm.org/D135495 Files:

[PATCH] D135488: [codegen][WIP] Display stack layouts in console

paulkirth added a comment. In D135488#3844117 , @nickdesaulniers wrote: > Thanks for the patch, here's the output I observe from the LKML thread > : >

[PATCH] D135500: [Clang] reject bit-fields as instruction operands in Microsoft style inline asm blocks.

tahonermann created this revision. tahonermann added reviewers: erichkeane, aaron.ballman. Herald added a project: All. tahonermann requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. MSVC allows bit-fields to be specified as instruction

[PATCH] D135397: [clang][dataflow] Add support for a Top value in boolean formulas.

gribozavr2 accepted this revision. gribozavr2 added inline comments. Comment at: clang/include/clang/Analysis/FlowSensitive/DataflowAnalysisContext.h:157 + TopValue () { +return takeOwnership(std::make_unique()); + } ymandel wrote: > xazax.hun wrote: > >

[PATCH] D135472: [ODRHash] Hash attributes on declarations.

vsapsai created this revision. vsapsai added reviewers: rtrieu, aaron.ballman, ChuanqiXu, Bigcheese. Herald added a subscriber: ributzka. Herald added a project: All. vsapsai requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Arguments not

[PATCH] D135177: [clang] adds `__is_scoped_enum`, `__is_nullptr`, and `__is_referenceable`

aaron.ballman added inline comments. Comment at: clang/test/SemaCXX/type-traits.cpp:374 +void is_scoped_enum() { + static_assert(!__is_scoped_enum(Enum), ""); It'd probably not be a bad idea at some point to add test coverage for incomplete types.

[PATCH] D133983: [HLSL] Add SV_DispatchThreadID

python3kgae updated this revision to Diff 466141. python3kgae marked 5 inline comments as done. python3kgae added a comment. Fix test fail after rebase and code cleanup to match comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133983/new/

[PATCH] D135476: [clang-tidy] Support concepts in `bugprone-forwarding-reference-overload`

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/bugprone/forwarding-reference-overload.rst:54 constructor could hide in this case. We also suppress warnings for constructors -like C3 and C4 that are guarded with an ``enable_if``,

[PATCH] D134813: Properly print unnamed TagDecl objects in diagnostics

aaron.ballman updated this revision to Diff 466145. aaron.ballman added a comment. Fixes the failing AST unit test in Clang found by precommit CI. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134813/new/ https://reviews.llvm.org/D134813 Files:

[PATCH] D135486: [Clang] Use C++17 in constant-builtins-fmax.cpp test

Izaron created this revision. Izaron added reviewers: efriedma, jcranmer-intel, aaron.ballman, cor3ntin. Herald added a project: All. Izaron requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Add `-std=c++17` to the test so that buildbot

  1   2   >